[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 114279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114279
Bug 24254: Add Koha::Items->filter_by_visible_in_opac

Review of attachment 114279:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24254&attachment=114279)
-----------------------------------------------------------------

::: Koha/Items.pm
@@ +70,5 @@
> +        $search_params->{$field}->{'-not_in'} = $rules->{$field};
> +    }
> +
> +    $search_params->{itemlost}->{'<='} = 0
> +        if C4::Context->preference('hidelostitems');

Where is that <= 0 coming from?

>From C4::Search:
1919                 # hidden because lost
1920                 if ($hidelostitems && $item->{itemlost}) {
1921                     $hideatopac_count++;
1922                     next;
1923                 }

Remember that -1 is evaluated true.

-- 
You are receiving this mail because:
You are watching all bug changes.