[Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 29 12:44:57 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 114721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114721&action=edit
Bug 27311 - Don't pass borrowernumber to check_password

Bug 22706 added the check_password plugin hook, taking both a
borrowernumber and the raw password as arguments. The hook is
called in two places in Koha::Patron, but because of how the code
that calls the hook is placed, passing borrowernumber to the plugin
inside "sub store" never worked. This patch removes the passing
of the borrowernumber from both calls.

A tiny plugin that uses the check_password hooks can ve found here:
https://github.com/Libriotech/koha-plugin-pin

To test:
- Enable plugins
- Optionally install the PIN plugin
- Add and edit users in all possible ways, including
-- Setting a password for a new user
-- Changing a password in the staff client
-- Changing a password in the OPAC
-- Creating a disabled user account

Sign off, if all this works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list