From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:13:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:13:01 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
about precision
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
CC| |joy at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #6 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:13:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:13:22 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
ACCOUNT_CREDIT notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Status|Pushed to master |Pushed to stable
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
--- Comment #6 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:14:49 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
Koha::Biblio->to_api
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #10 from Joy Nelson ---
Does not apply to 19.11.x branch. Please rebase if needed for 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:20:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:20:24 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--- Comment #19 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:25:35 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com
CC| |lucas at bywatersolutions.com
--- Comment #1 from Lucas Gass ---
Andrew,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:25:41 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
edit template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
CC| |joy at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #8 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:25:56 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
enforced after item is captured for hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
CC| |joy at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #21 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:26:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:26:10 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
without leading articles (allow for title sort with anti-the)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #6 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:26:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:26:24 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
apache-shared-intranet.conf
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
--- Comment #7 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:29:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:29:51 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #8 from Joy Nelson ---
Does not apply to 19.11.x branch. Please rebase if needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:35:33 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
confirmation dialogs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
CC| |joy at bywatersolutions.com
Resolution|--- |FIXED
--- Comment #8 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:35:33 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
suggestion in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336
Bug 24336 depends on bug 24341, which changed state.
Bug 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:35:34 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
confirmation before deleting hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433
Bug 24433 depends on bug 24341, which changed state.
Bug 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:36:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:36:45 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
confirmation before deleting hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
CC| |joy at bywatersolutions.com
--- Comment #6 from Joy Nelson ---
Not backported to 19.11.x due to dependencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:37:32 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
suggestion in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Resolution|--- |FIXED
Status|Pushed to master |RESOLVED
--- Comment #10 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:46:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:46:11 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #5 from Joy Nelson ---
This applies to 19.11. branch, but qa tests show this error:
Processing files before patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 287.
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 287.
Not backported unless these are not major errors.
-joy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:46:51 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
--- Comment #9 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:47:17 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
--- Comment #5 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:47:33 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
increase the original quantity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
--- Comment #14 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:50:21 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 23:50:23 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
--- Comment #2 from Lucas Gass ---
Created attachment 98259
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98259&action=edit
Bug 24560: Dont show Public lists if there are 0
TEST PLAN:
1. have no public list and look at the List dropdown on the OPAC. It says No
Public Lists.
2. Apply patch
3. It should now not say anything about public lists but still be formatted
nice.
4. Add some public lists and confirm that everything looks normal.
5. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:00:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:00:47 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
Chrome
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Version(s)|20.05.00 |20.05.00, 19.11.03
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #34 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.03
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:01:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:01:31 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
order number and ISBN to late orders page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--- Comment #53 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:01:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:01:32 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
claims
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Bug 24161 depends on bug 12502, which changed state.
Bug 12502 Summary: Add columns for note, order number and ISBN to late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:02:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:02:22 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #12 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:02:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:02:53 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
to "OPAC item level holds"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
CC| |joy at bywatersolutions.com
Resolution|--- |FIXED
--- Comment #8 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:03:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:03:24 +0000
Subject: [Koha-bugs] [Bug 24343] Show subtitle,
number and parts in course reserves list of titles in staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
Resolution|--- |FIXED
Status|Pushed to master |RESOLVED
--- Comment #6 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:03:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:03:58 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
for purchase
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to master |RESOLVED
CC| |joy at bywatersolutions.com
--- Comment #5 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:04:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:04:48 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
outstanding credits should warn and block the deletion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
CC| |joy at bywatersolutions.com
Resolution|--- |FIXED
--- Comment #19 from Joy Nelson ---
Enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:05:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:05:27 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
ByWater Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98259|0 |1
is obsolete| |
--- Comment #3 from ByWater Sandboxes ---
Created attachment 98260
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98260&action=edit
Bug 24560: Dont show Public lists if there are 0
Signed-off-by: Kelly McElligott
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:05:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 00:05:56 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Kelly McElligott changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 02:55:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 01:55:29 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
linking to correct records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094
Myka Kennedy Stephens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #5 from Myka Kennedy Stephens ---
These patches work as expected in both Zebra and ES for personal names. Applied
the patch and saved the record again. It stripped the ending "," before $e in a
100 field and created a new authority record. Re-saving the record again kept
the 100 field linked to the same authority record.
Uniform titles are another matter. Applied patch and saved the record again. It
stripped the ending ";" before $v in an 830 field and created a new authority
record. Re-saving the record again created another new authority record and
re-linked the 830 to the new authority record.
I'm also noticing that it is still creating additional authority records for
other fields, but not consistently. For example, one record I tried kept
subject heading links between saves, but another record did not. Switching
between Zebra and ES didn't seem to make a difference.
The bibliographic records I tested came from the Library of Congress Z39.50
server:
#1 - ISBN 9781540960573
#2 - ISBN 9789004130784
#3 - ISBN 9781532653308
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:12:21 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |24561
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
[Bug 24561] Add embedded column filter feature to datatables api wrapper
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:12:21 +0000
Subject: [Koha-bugs] [Bug 24561] New: Add embedded column filter feature to
datatables api wrapper
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
Bug ID: 24561
Summary: Add embedded column filter feature to datatables api
wrapper
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: agustinmoyano at theke.io
Reporter: agustinmoyano at theke.io
QA Contact: testopia at bugs.koha-community.org
CC: tomascohen at gmail.com
Depends on: 20212, 24502
Blocks: 20936
Bug 24502 introduced filtering by embedded columns. It would be great if
datatables wrapper for the API in bug 20212 could use this feature.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
[Bug 24502] Add a query language and param (q=) to the API
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:12:21 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |24561
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
[Bug 24561] Add embedded column filter feature to datatables api wrapper
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:12:21 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24561
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
[Bug 24561] Add embedded column filter feature to datatables api wrapper
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:17:41 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|24356, 24502 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
[Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
[Bug 24502] Add a query language and param (q=) to the API
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:17:41 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20936 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:17:41 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20936 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:47:09 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:47:13 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97935|0 |1
is obsolete| |
Attachment #97936|0 |1
is obsolete| |
--- Comment #12 from Agustín Moyano ---
Created attachment 98261
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98261&action=edit
Bug 24356: prefetch_whitelist tests
This patch adds tests for the introduced methods.
To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:47:17 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
--- Comment #13 from Agustín Moyano ---
Created attachment 98262
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98262&action=edit
Bug 24356: Make objects.search prefetch embedded relations
This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object* \
t/db_dependent/Koha/REST/Plugin/Objects.t \
t/db_dependent/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 04:49:01 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
--- Comment #14 from Agustín Moyano ---
(In reply to David Nind from comment #11)
> Tests fail:
>
> prove t/db_dependent/Koha/Object*
>
> t/db_dependent/Koha/Objects.t .. 18/21
> # Failed test 'Relationship matching method name is listed'
> # at t/db_dependent/Koha/Objects.t line 800.
>
> # Failed test 'Guessed the object class correctly'
> # at t/db_dependent/Koha/Objects.t line 804.
> # got: undef
> # expected: 'Koha::Acquisition::BasketGroup'
> # Looks like you failed 2 tests of 2.
>
> # Failed test 'prefetch_whitelist() tests'
> # at t/db_dependent/Koha/Objects.t line 809.
> # Looks like you failed 1 test of 21.
> t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/21 subtests
> t/db_dependent/Koha/Object.t ... 17/18
> # Failed test 'Relationship matching method name is listed'
> # at t/db_dependent/Koha/Object.t line 754.
>
> # Failed test 'Guessed the object class correctly'
> # at t/db_dependent/Koha/Object.t line 758.
> # got: undef
> # expected: 'Koha::Acquisition::BasketGroup'
> # Looks like you failed 2 tests of 2.
>
> # Failed test 'prefetch_whitelist() tests'
> # at t/db_dependent/Koha/Object.t line 763.
> # Looks like you failed 1 test of 18.
> t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/18 subtests
>
> Test Summary Report
> -------------------
> t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1)
> Failed test: 21
> Non-zero exit status: 1
> t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1)
> Failed test: 18
> Non-zero exit status: 1
> Files=2, Tests=39, 22 wallclock secs ( 0.05 usr 0.01 sys + 17.92 cusr 3.05
> csys = 21.03 CPU)
> Result: FAIL
Hi David, thanks for testing.
I just rebased and fixed tests. Could you please do another run?
Regards.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 08:21:18 +0000
Subject: [Koha-bugs] [Bug 20627] Prevent leakages of user permissions to api
access tokens
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627
--- Comment #2 from Martin Renvoize ---
I still hope to get to it at some point.. likely when rebasing Kyle's work on
permissions which is on my list for later this month.
I envisage an OAuth2 style scopes system from the API perspective.. but th
foundations for that are not yet available in Koha permissions code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:42:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 08:42:36 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #44 from Martin Renvoize ---
Thanks David, that's great news.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 11:20:02 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
koha-sip
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:20:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 11:20:05 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
koha-sip
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98258|0 |1
is obsolete| |
--- Comment #16 from David Nind ---
Created attachment 98263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98263&action=edit
Bug 24340: allow koha-sip --disable inst
To test:
- Enable sip for your testing instance
sudo koha-sip --enable inst
- Start sip for your testing instance
sudo koha-sip --start inst
- Verify it is running
ps ax |grep sip -> you should see processes
- Disable sip for your testing intance
sudo koha-sip --disable inst
- Verify that the following has happened:
* SIP is no longer running for your instance - no SIP processes
* SIP Cannot be started for the instance because it is not enabled.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:53:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 11:53:01 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
--- Comment #15 from David Nind ---
Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error
message:
Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at
/usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261.
TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x562a13917438),
TAP::Parser::Source=HASH(0x562a13917510)) called at
/usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211
TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x562a13917438),
TAP::Parser::Source=HASH(0x562a13917510)) called at
/usr/share/perl/5.24/TAP/Parser.pm line 472
TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0),
HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55
TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at
/usr/share/perl/5.24/TAP/Object.pm line 130
TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0),
"TAP::Parser", HASH(0x562a136dc0e0)) called at
/usr/share/perl/5.24/TAP/Harness.pm line 852
TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0),
TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at
/usr/share/perl/5.24/TAP/Harness.pm line 651
TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0),
TAP::Parser::Aggregator=HASH(0x562a13168d48),
TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at
/usr/share/perl/5.24/TAP/Harness.pm line 743
TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0),
TAP::Parser::Aggregator=HASH(0x562a13168d48),
"t/db_dependent/Koha/REST/Plugin/Query.t") called at
/usr/share/perl/5.24/TAP/Harness.pm line 558
TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm
line 571
TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0),
"t/db_dependent/Koha/REST/Plugin/Query.t") called at
/usr/share/perl/5.24/App/Prove.pm line 546
App::Prove::_runtests(App::Prove=HASH(0x562a13143888),
HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at
/usr/share/perl/5.24/App/Prove.pm line 504
App::Prove::run(App::Prove=HASH(0x562a13143888)) called at
/usr/bin/prove line 13
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 14:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 13:04:50 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
Staff override a Holds Per Record Rule
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 14:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 13:25:09 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
$0
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510
--- Comment #6 from Andreas Roussos ---
As Hugo pointed out, this bug has two aspects.
1) Firstly, there's the issue of the subfield not appearing in the MARC
Modification Template (MMT) action description when its value is 0 (even though
it will appear when editing the action). These are the relevant lines of code
from marc_modification_templates.tt:
136 [% ActionsLoo.from_field | html %][% IF ( ActionsLoo.from_subfield ) %]$[%
ActionsLoo.from_subfield | html %][% END %]
143 to [% ActionsLoo.to_field | html %][% IF ( ActionsLoo.to_subfield ) %]$[%
ActionsLoo.to_subfield | html %][% END %]
154 [% ActionsLoo.conditional_field | html %][% IF (
ActionsLoo.conditional_subfield ) %]$[% ActionsLoo.conditional_subfield | html
%][% END %]
The problem lies with the "[% IF ( ... ) %]" statements: when the
from/to/conditional subfield value is set to 0 the IF clause will evaluate to
false and therefore the value will not be printed.
2) Secondly, we have an error message coming up in the Plack log file ("This
action is not implemented yet"), and this relates to commit c7d862b (from Bug
11319). In that commit, among other things, the update_field() subroutine was
added to SimpleMARC.pm, the most relevant lines of which are:
167 if ( not $subfieldName or $subfieldName eq '' ) {
168 # FIXME I'm not sure the actual implementation is correct.
169 die "This action is not implemented yet";
170 #_update_field({ record => $record, field => $fieldName, values =>
\@values });
171 } else {
172 _update_subfield({ record => $record, field => $fieldName, subfield =>
$subfieldName, values => \@values, field_numbers => $field_numbers });
173 }
The first condition in the 'if' clause above results in the expression
evaluating to true when a subfield value of 0 (integer zero) or '0' (string
zero) is entered -- hence the error message.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 16:36:31 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:36:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 16:36:33 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98260|0 |1
is obsolete| |
--- Comment #4 from Lucas Gass ---
Created attachment 98264
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98264&action=edit
Bug 24560: Dont show No Public Lists in OPAC
Offering a better patch. Test plan remains the same.
TEST PLAN:
1. have no public list and look at the List dropdown on the OPAC. It says No
Public Lists.
2. Apply patch
3. It should now not say anything about public lists but still be formatted
nice.
4. Add some public lists and confirm that everything looks normal.
5. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:43:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 16:43:18 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
if no public lists exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98264|0 |1
is obsolete| |
--- Comment #5 from Lucas Gass ---
Created attachment 98265
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98265&action=edit
Bug 24560: Remove No public list text from OPAC
TEST PLAN:
1. have no public list and look at the List dropdown on the OPAC. It says No
Public Lists.
2. Apply patch
3. It should now not say anything about public lists but still be formatted
nice.
4. Add some public lists and confirm that everything looks normal.
5. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 20:47:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 19:47:07 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
Search::Elasticsearch 6.00
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
|ity.org |
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:23:19 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
to_api
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:23:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:23:22 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
to_api
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98225|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 98266
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98266&action=edit
Bug 24554: Only embed relations from Koha::Biblio in to_api
This patch simplifies the behaviour of Koha::Biblio->to_api. It was
designed with the idea of handling possible methods that would be added
to Koha::Biblioitem. But it had a weird fallback behaviour was
highlighted by using it with bug 24528.
On fixing it it become obvious that it was unnessessarily complex and
that it was not worth. That's the reason there wasn't any test for it,
as Koha::Biblioitem doesn't implement any extra methods.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests pass!
4. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:47:46 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #67 from Katrin Fischer ---
Created attachment 98267
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98267&action=edit
Bug 23590: (QA follow-up) Fix some problems created by recent changes and
updatedatabase statement
- Ensure that the sequence of columns will be the same for new
and updated installations (add AFTER ...)
- Fix permissions (see bug 22868)
- Fix column configuration (see 16784)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:53:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:53:38 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98267|0 |1
is obsolete| |
--- Comment #68 from Katrin Fischer ---
Created attachment 98268
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98268&action=edit
Bug 23590: (QA follow-up) Fix some problems created by recent changes and
updatedatabase statement
- Ensure that the sequence of columns will be the same for new
and updated installations (add AFTER ...)
- Fix permissions (see bug 22868)
- Fix column configuration (see 16784)
- Remove '- ' displying before the date
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:58:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:58:04 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #69 from Katrin Fischer ---
Notes & questions
1) We might want to modify the bug title a little - in addition to allow
changing the manager, this will also store the last person to change and date.
Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
2) lastmodificationdate and lastmodificationby are quite long. It might be
nicer to used something more readable like: last_modified_on and
last_modified_by. Not blocker for me, but putting the thought out there.
3) Is there a reason why we don't let the db update thelastmodificationdate?
4) Please check my follow-up
Blockers
1) When I change the manager, the lastmodification* are not updated.
2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for
the manager. I believe this should be handled separately. ( Bug 13014: Notify
budget owner on new suggestion - cronjob)
3)
+ if ( $notify ) {
+ my $patron = Koha::Patrons->find(
$suggestion_only->{managedby} );
+ my $email_address = $patron->notice_email_address;
+ if ($patron->notice_email_address) {
+ my $budget = C4::Budgets::GetBudget(
$suggestion_only->{budgetid} );
$budget appears not to be used - possibly a copy&paste because of 2).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:58:22 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 20:59:41 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #70 from Katrin Fischer ---
I think it would have been nice to split this:
- Add last modification*
- Add ability to change manager
- Add ability to notify - last bit could still be pulled out maybe
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:19:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 21:19:52 +0000
Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place
resets to logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:19:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 21:19:55 +0000
Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place
resets to logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #95821|0 |1
is obsolete| |
--- Comment #9 from David Nind ---
Created attachment 98269
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98269&action=edit
Bug 9993: On editing basket group delivery place resets to logged in branch
This patch modifies basketgroups.pl so that existing data about a basket
group's billing and delivery place are correctly preselected in the edit
form. These fields shouldn't reset to the logged-in user's home branch
just because they have an empty value.
To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups.
When adding or editing a basket group the pre-selected value for
"Billing place" and "Delivery place" should be correct:
- When creating a new basket group: The logged-in user's library
should be pre-selected.
- When editing a basket group which has a library defined for either
the billing or delivery places, the correct library should be
pre-selected.
- When editing a basket group which has no library defined for either
the billing or delivery place there should be no library
pre-selected (the "--" option should be pre-selected).
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 21:46:51 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:46:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 21:46:57 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98232|0 |1
is obsolete| |
--- Comment #5 from David Nind ---
Created attachment 98270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98270&action=edit
Bug 24545: Fix license statements
Bug 9978 should have fixed them all, but some were missing.
We want all the license statements part of Koha to be identical, and
using the GPLv3 statement.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:47:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Feb 2020 21:47:00 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98233|0 |1
is obsolete| |
--- Comment #6 from David Nind ---
Created attachment 98271
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98271&action=edit
Bug 24545: Fix find-license-problems.t to catch future wrong license statements
File adjust to run tests and be executed on all our codebase.
Test plan:
- Apply this patch without the other one
- run the tests
=> Several failures
- apply the other patch
- run the tests
=> Should pass now
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 02:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2020 01:48:04 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
--- Comment #11 from David Nind ---
(In reply to David Nind from comment #10)
> I get this message when trying to apply this patch (git bz apply 24502):
>
> Failed to retrieve bug information: NotPermitted
Figured it out - a dependency is security related.
Will let someone else test who has the right access!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:13:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2020 20:13:45 +0000
Subject: [Koha-bugs] [Bug 24562] New: addbiblio.pl overloading CPU
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562
Bug ID: 24562
Summary: addbiblio.pl overloading CPU
Change sponsored?: ---
Product: Koha
Version: 19.11
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: jawad_makki at hotmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Hello.
Sometimes during the day, addbiblio.pl is overloading CPU (100%) and therefore
it is making Koha completely not responding for few minutes (can reach 20
minutes).
in apache2 log, the response time for "POST
/cgi-bin/koha/cataloguing/addbiblio.pl HTTP/1.1" is reaching gateway timeout
few times per day.
below are some errors retrieved from plack-error.log
Use of uninitialized value $mode in string ne at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 845.
Use of uninitialized value $searchid in concatenation (.) or string at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 876.
Koha version 19.11 , running on debian 9
memcached and plack are enabled.
this problem was also in 18.11, we have upgraded koha to 19.11 but the problem
is still occuring
Any help
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:18:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2020 20:18:56 +0000
Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562
--- Comment #1 from Jawad Makki ---
these are more errors retrieved from plack-error.log
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 708.
Use of uninitialized value $frameworkcode in string eq at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 712.
Use of uninitialized value $frameworkcode in string eq at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 731.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:51:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2020 20:51:11 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
should only work for for SIP-based checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleymapley at catalyst.net.n
| |z
Version(s)|20.05.00,, 19.11.02 |20.05.00, 19.11.02,
released in| |19.05.08
--- Comment #42 from Hayley Mapley ---
Enhancement will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:44:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Feb 2020 22:44:36 +0000
Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 01:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 00:49:18 +0000
Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860
--- Comment #3 from Tomás Cohen Arazi ---
We come up with a totally different approach to this with bug 22835. While this
is still valid for legacy plugins, I suggest we push everyone into updating
their plugins.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 03:37:02 +0000
Subject: [Koha-bugs] [Bug 24563] New: Internal Server error when clicking
Tools
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563
Bug ID: 24563
Summary: Internal Server error when clicking Tools
Change sponsored?: ---
Product: Koha
Version: 19.11
Hardware: All
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: librarian at sageuniversity.in
QA Contact: testopia at bugs.koha-community.org
I am face problem in tools module,i am enable plugin in koha and click this
module
internal server error please see the matter.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:59:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 05:59:17 +0000
Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563
Govind Basedia changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |librarian at sageuniversity.in
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 07:41:25 +0000
Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data,
cannot decode object"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425
--- Comment #15 from Rudolf Byker ---
Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page, it's
still not handled gracefully on these pages:
/cgi-bin/koha/catalogue/ISBDdetail.pl
/cgi-bin/koha/catalogue/MARCdetail.pl
New issue? Or re-open this one?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:54:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 07:54:43 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
--- Comment #7 from Marcel de Rooy ---
etc/zebradb/authorities/etc/dom-config-marc.xml
etc/zebradb/authorities/etc/dom-config.xml
etc/zebradb/biblios/etc/dom-config-marc.xml
etc/zebradb/biblios/etc/dom-config.xml
etc/zebradb/xsl/zebra.xsl
koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt
koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js
xt/find-license-problems.t
xt/fix-old-fsf-address
Should we still address a few of these ones?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:59:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 07:59:59 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:00:03 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
--- Comment #3 from David Nind ---
Created attachment 98272
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98272&action=edit
Bug 24463: Add a basket_group relationship for baskets
This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:01:22 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
subscriptions tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--- Comment #16 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #15)
> As I said this morning on #koha, I do not think we should silently delete
> those rows.
Instead of deleting we could look at setting to NULL. Not sure if it would be
very valuable? We could dump the original serial tables to a backup file
allowing a local developer to restore information; not sure if anyone would.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:04:50 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
basket_group in Basket.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:04:53 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
basket_group in Basket.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97628|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 98273
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98273&action=edit
Bug 24463: Add a basket_group relationship for baskets
This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:11:23 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #4 from David Nind ---
Hi Tomás.
I think I've somehow mucked up the sign-off - I've somehow added Bug 24463
patch to it as well..
If you could let me know how to fix it up, or reset it so I can sign-off again,
that would be great!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:31:19 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
on opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |david at davidnind.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:31:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:31:59 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
on opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473
--- Comment #3 from David Nind ---
Looks like this was signed-off, but the status wasn't changed. Have changed to
signed-off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:32:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:32:41 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
on opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stina.hallin at ub.lu.se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:35:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:35:15 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
subscriptions tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901
--- Comment #17 from Martin Renvoize ---
Setting to NULL leaves us with broken data and worse an avenue to new broken
data being input.
Personally, as I couldn't' find any cases where a delete would actually take
place (and I went back to some koha versions many years old) and the data being
deleted would lead to errors in the client as relations would be broken I feel
it's justified to leave the delete in place... open to being countered as ever
but I'd rather this didn't end up stuck in perpetuity as so many FK bugs do
:'(.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:41:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:41:59 +0000
Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data,
cannot decode object"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #16 from Katrin Fischer ---
(In reply to Rudolf Byker from comment #15)
> Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page, it's
> still not handled gracefully on these pages:
>
> /cgi-bin/koha/catalogue/ISBDdetail.pl
> /cgi-bin/koha/catalogue/MARCdetail.pl
>
> New issue? Or re-open this one?
Hi Rudolf, when in doubt always open a new bug report. Especially when the bug
has been already pushed/released/closed as is the case here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:46:16 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
subscriptions tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #18 from Katrin Fischer ---
If I undertand this correctly the problem might be cases where there is
incomplete data? like a subscription without subscription history? Or a serial
entry with a link to a nonexisting subscription?
We store the user's name in subscription... so if we are very strict we might
not want to dump it to the file system to be forgotten about. If we set to
null, we need to make the db structure more lenient... I guess dumping might be
the best option.
How likely is it those cases exist?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:47:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:47:24 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Attachment #98272|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:47:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:47:56 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
--- Comment #5 from Katrin Fischer ---
Hi David, I fixed it, the way is: Details > Edit details > Obsolete. Do you
want to try again?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:56:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:56:41 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:56:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 08:56:44 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97269|0 |1
is obsolete| |
--- Comment #4 from David Nind ---
Created attachment 98274
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98274&action=edit
Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface
It was noted, that 'sub fund' might be a better term to use than
'child fund'. So this patch changes it.
To test, check with and without patch:
- Add a budget in acquisitions
- Add a fund in acquisitions
- Add a sub/child fund to your fund (label of menu item #1)
- Edit your first fund, check option to update owners of
sub/child funds (#2)
- Try to delete your 'parent' fund (tooltip #3)
- Click on the greyed out entry (alert ÃÃ#4)
If you like the change, please sign-off. If you think otherwise,
please comment on the bug report.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:00:03 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
--- Comment #6 from David Nind ---
Thanks Katrin!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:03:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:03:27 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97631|0 |1
is obsolete| |
--- Comment #7 from David Nind ---
Created attachment 98275
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98275&action=edit
Bug 24464: Unit tests
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:03:30 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97632|0 |1
is obsolete| |
--- Comment #8 from David Nind ---
Created attachment 98276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98276&action=edit
Bug 24464: Add K::A::Basket->creator
This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.
Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:38:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:38:02 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
RFC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:38:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:38:05 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
RFC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97624|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 98277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98277&action=edit
Bug 24462: Adapt mapping to voted RFC (Invoices)
This trivial patch changes the attribute names for API reprensentation
of Koha::Acquisition::Invoice objects.
To test:
1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC
2. Check the mappings are correct
=> SUCCESS: The patch makes the right changes to the mappings
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:46:18 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
--- Comment #8 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #7)
> etc/zebradb/authorities/etc/dom-config-marc.xml
> etc/zebradb/authorities/etc/dom-config.xml
> etc/zebradb/biblios/etc/dom-config-marc.xml
> etc/zebradb/biblios/etc/dom-config.xml
> etc/zebradb/xsl/zebra.xsl
=> Zebra license
> koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt
tiny mce license
> koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js
Yes, follow-up coming.
> xt/find-license-problems.t
False positive.
> xt/fix-old-fsf-address
Yes, follow-up coming.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 09:47:08 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
--- Comment #9 from Jonathan Druart ---
Created attachment 98278
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98278&action=edit
Bug 24545: (follow-up) Fix license statements
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:19:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:19:26 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #71 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #69)
> Notes & questions
>
> 1) We might want to modify the bug title a little - in addition to allow
> changing the manager, this will also store the last person to change and
> date. Also gives a checkbox for TO_PROCESS. We really needs some release
> notes :)
Any suggestions? :)
> 2) lastmodificationdate and lastmodificationby are quite long. It might be
> nicer to used something more readable like: last_modified_on and
> last_modified_by. Not blocker for me, but putting the thought out there.
I followed the existing pattern As there were already 4 of those I thought it
was better to keep names consistent.
> 3) Is there a reason why we don't let the db update thelastmodificationdate?
We can pick the max date of suggesteddate, manageddate, accepteddate,
rejecteddate, is that was you have in mind?
> 4) Please check my follow-up
They look good, thanks!
> Blockers
>
> 1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when
the suggestion is edited via the edit form. If we want to update it whenever
the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
> 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> for the manager. I believe this should be handled separately. ( Bug 13014:
> Notify budget owner on new suggestion - cronjob)
That was part of the original specification.
It makes sense to have 2 different notice templates. Something to suggest?
UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
> 3)
> + if ( $notify ) {
> + my $patron = Koha::Patrons->find(
> $suggestion_only->{managedby} );
> + my $email_address = $patron->notice_email_address;
> + if ($patron->notice_email_address) {
> + my $budget = C4::Budgets::GetBudget(
> $suggestion_only->{budgetid} );
> $budget appears not to be used - possibly a copy&paste because of 2).
Indeed, follow-up coming.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:20:03 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #72 from Jonathan Druart ---
Created attachment 98279
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98279&action=edit
Bug 23590: remove unused variable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:27:20 +0000
Subject: [Koha-bugs] [Bug 24564] New: The adding of new subfields according
to IFLA updates doesn't respect existing tab
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564
Bug ID: 24564
Summary: The adding of new subfields according to IFLA updates
doesn't respect existing tab
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: koha at univ-lyon3.fr
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
When using the script misc/migration_tools/ifla/update.pl (cf. BZ20434),
missing fields/subfields are added but if subfields already existed in the
framework, the script doesn't verifiy in which tab they existed and can add
them in a different tab.So for the same field, you could have subfields in
different tabs. It can lead to wrong and blocking alerts when saving a biblio
record.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:27:41 +0000
Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to
IFLA updates doesn't respect existing tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564
Koha Team University Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |koha at univ-lyon3.fr
Depends on| |20434
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434
[Bug 20434] UNIMARC update from IFLA for existing Koha installations
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:27:41 +0000
Subject: [Koha-bugs] [Bug 20434] UNIMARC update from IFLA for existing Koha
installations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434
Koha Team University Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |24564
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564
[Bug 24564] The adding of new subfields according to IFLA updates doesn't
respect existing tab
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:46:51 +0000
Subject: [Koha-bugs] [Bug 22686] Koha::Acquisition::Bookseller->contacts
should match the coding guidline
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22686
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Resolution|--- |DUPLICATE
Status|Needs Signoff |RESOLVED
--- Comment #2 from Jonathan Druart ---
I missed this one. I did that on bug 22685, and provided tests :)
*** This bug has been marked as a duplicate of bug 22685 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:46:51 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
return Koha::Objects using the DBIx::Class relationships
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685
--- Comment #2 from Jonathan Druart ---
*** Bug 22686 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:46:51 +0000
Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch
related object rather than searching for the object
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
Bug 22407 depends on bug 22686, which changed state.
Bug 22686 Summary: Koha::Acquisition::Bookseller->contacts should match the coding guidline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22686
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |RESOLVED
Resolution|--- |DUPLICATE
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:53:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:53:38 +0000
Subject: [Koha-bugs] [Bug 24565] New: ILL requests do not display in patron
profile in intranet
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565
Bug ID: 24565
Summary: ILL requests do not display in patron profile in
intranet
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew.isherwood at ptfs-europe.com
A patron's ILL requests are not displaying on the "ILL requests history" tab on
their profile page on intranet.
This is due to a check in ill-list-table.js that checks what page the user is
on before sending the API request to get the requests. This check was added in
bug 23229. I failed to realise that it adversely affected the patron profile
page in this way.
I will create a fix now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:53:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 10:53:57 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
profile in intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P3
Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
|ity.org |e.com
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:25:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:25:37 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:25:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:25:58 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
--- Comment #66 from Martin Renvoize ---
Seems I forgot to reset the status when I added the followup.. ready for QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:32:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:32:52 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
payment_types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |19.11
--- Comment #3 from Martin Renvoize ---
OK, so on master it's already added in bug 23354, but it's not in the 19.11
branch yet. Setting branch appropriately.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:33:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:33:33 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
payment_types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:36:24 +0000
Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301
Lucy Vaux-Harvey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucy.vaux-harvey at ptfs-europ
| |e.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:36:48 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
'first patron' details
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
Lucy Vaux-Harvey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucy.vaux-harvey at ptfs-europ
| |e.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:38:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:38:30 +0000
Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #3 from Jonathan Druart ---
(In reply to Michal Denar from comment #2)
> Hi Jonathan,
> can you rebase this patch?
>
> sing index info to reconstruct a base tree...
> M t/db_dependent/Koha/Acquisition/Basket.t
> Falling back to patching base and 3-way merge...
> Auto-merging t/db_dependent/Koha/Acquisition/Basket.t
> CONFLICT (content): Merge conflict in
> t/db_dependent/Koha/Acquisition/Basket.t
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 24161: Add tests
This patch is at the top of a long dependency list.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:44:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:44:26 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
claims
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97472|0 |1
is obsolete| |
--- Comment #12 from Jonathan Druart ---
Created attachment 98280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98280&action=edit
Bug 24161: Add tests
Sponsored-by: Cork Institute of Technology
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:45:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:45:02 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:48:31 +0000
Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301
--- Comment #1 from Lucy Vaux-Harvey ---
This issue has been raised also by one of our supported libraries on 18.11.11.
When the item is scanned the hold is always assigned to the correct user (first
on the hold priority list) but this is often not the user that was listed in
the 'First patron' column in the holds to Pull report.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:50:56 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
profile in intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565
--- Comment #1 from Andrew Isherwood ---
Created attachment 98281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98281&action=edit
Bug 24565: Add patron profile to ILL list pages
We need the API call to get ILL requests on the patron profile page,
this commit allows this.
Test plan:
- Do not apply the patch.
- Go to the "Ill requests history" page for a patron who has made ILL
requests
- TEST: Observe that no requests are displayed
- Apply the patch
- Refresh the page
- TEST: Observe that requests are displayed
- Go to the main "ILL requests" page
- TEST: Observe that requests are displayed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 11:52:25 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
profile in intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:00:03 +0000
Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301
--- Comment #2 from Michal Denar ---
Hi Lucy,
yes, we need to see first on the hold priority list borrower name. Now is it
more or less random name from priority list. It's confusing for librarians.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:01:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:01:58 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98054|0 |1
is obsolete| |
--- Comment #67 from Jonathan Druart ---
Created attachment 98282
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98282&action=edit
Bug 23260: Add a new test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:02:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:02:57 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #68 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #66)
> Seems I forgot to reset the status when I added the followup.. ready for QA
The test was not passing. I have updated it, as I think we are expecting 1
checkout to be anonymised here. Still not passing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:25 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:28 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98205|0 |1
is obsolete| |
Attachment #98206|0 |1
is obsolete| |
Attachment #98207|0 |1
is obsolete| |
Attachment #98208|0 |1
is obsolete| |
Attachment #98237|0 |1
is obsolete| |
--- Comment #22 from Jonathan Druart ---
Created attachment 98283
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98283&action=edit
Bug 24440: Unit tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:32 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #23 from Jonathan Druart ---
Created attachment 98284
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98284&action=edit
Bug 24440: Add ->current_holds to Koha::Acquisition::Order
This patch introduces a method to fetch the current holds associated with the
items linked to an order line. It basically implements what's done in
parcel.pl, but fully tested and suitable for using on the API.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:36 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #24 from Jonathan Druart ---
Created attachment 98285
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98285&action=edit
Bug 24440: ->biblio tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:40 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #25 from Jonathan Druart ---
Created attachment 98286
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98286&action=edit
Bug 24440: (follow-up) Make related objects prefetchable
This patch creates aliases for the relations used to retrieve the linked
objects from other tables. It makes the accessor names match the used
relation name, for consistency.
This is important for code trying to be smart and guessing what needs to
be prefetched, like the API code.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests pass! No behaviour change
4. Verify the POD changes make sense
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:44 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #26 from Jonathan Druart ---
Created attachment 98287
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98287&action=edit
Bug 24440: Adding 2 more tests for ->biblio
Not directly related to the other changes but seems good to have them
here.
Signed-off-by: Jonathan Druart
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:37:48 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #27 from Jonathan Druart ---
Created attachment 98288
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98288&action=edit
Bug 24440: Rename current_holds with current_item_level_holds
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:39:42 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
--- Comment #28 from Jonathan Druart ---
Not blocker, but part of this patch:
Bug 24440: (follow-up) Make related objects prefetchable
should have been moved to its own bug report.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:41:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:41:10 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_item_level_holds to
Koha::Acquisition::Order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add ->current_holds to |Add
|Koha::Acquisition::Order |->current_item_level_holds
| |to Koha::Acquisition::Order
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:54:48 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363
--- Comment #14 from Jonathan Druart ---
Created attachment 98289
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98289&action=edit
Bug 24363: Do not use the two-value syntax for background-position-x
It's not supported by chrome and chromium (inspector says "invalidd
property value".
See also:
https://developer.mozilla.org/en-US/docs/Web/CSS/background-position-x section
"Browser compatibility"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:55:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:55:18 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363
--- Comment #15 from Jonathan Druart ---
(In reply to David Nind from comment #13)
> Everything looks good in Firefox.
>
> However with Google Chrome the icon is aligned to the inside left of the box
> and the start of the date overlays it.
>
> I can post screenshots if required.
I confirm that on both Chrome and Chromium, inspector says "invalid property
value" for rule background-position-x.
The new patch should fix it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:55:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:55:51 +0000
Subject: [Koha-bugs] [Bug 24566] New: UpdateItemLocationOnCheckin triggers
SIP2 alert flag, even with checked_in_ok enabled
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Bug ID: 24566
Summary: UpdateItemLocationOnCheckin triggers SIP2 alert flag,
even with checked_in_ok enabled
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted
on in the same way as LocalUse and thus should be removed in the same fashion.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:56:05 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:56:12 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:56:37 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
potential security issue when running from git
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949
--- Comment #23 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #22)
> Rebased
Should not we prefer to revive bug 16922 instead?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:57:49 +0000
Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963
--- Comment #5 from Jonathan Druart ---
(In reply to Todd Goatley from comment #3)
> Created attachment 98179 [details]
> Image display issues
>
> Martin and Fridolin, I've recently been contacted by a Koha site on 19.05.06
> reporting they're still having issues with images. I have 3 images but could
> only attached 1. This Koha site reports:
>
> The top example is from before the upgrade. - clear and crisp
> The bottom 2 are from after the upgrade - blurred
>
> Images that come in automatically from online are clean/clear, but many of
> the images I add myself. There was no change in the quality of the images,
> but it changed with the upgrade.
>
> Thanks! Curious as to what is happening with this...
It has been reverted as it caused regressions, see bug 22988.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:59:04 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:59:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 12:59:07 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
--- Comment #1 from Kyle M Hall ---
Created attachment 98290
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98290&action=edit
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with
checked_in_ok enabled
If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted
on in the same way as LocalUse and thus should be removed in the same fashion.
Test Plan:
1) Enable UpdateItemLocationOnCheckin and set it up to trigger at
checkin for an item
2) Return that item via SIP2
3) Note the alert flag is set
4) Apply this patch
5) Repeat steps 1 and 2
6) The alert flag should not be set
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:00:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:00:51 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:00:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:00:54 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
alert flag, even with checked_in_ok enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98290|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 98291
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98291&action=edit
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with
checked_in_ok enabled
If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted
on in the same way as LocalUse and thus should be removed in the same fashion.
Test Plan:
1) Enable UpdateItemLocationOnCheckin and set it up to trigger at
checkin for an item
2) Return that item via SIP2
3) Note the alert flag is set
4) Apply this patch
5) Repeat steps 1 and 2
6) The alert flag should not be set
Signed-off-by: Kyle M Hall
Signed-off-by: Kevin Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:22:09 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
'return to homebranch'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97535|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize ---
Created attachment 98292
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98292&action=edit
Bug 24298: Add return enums to branchstransfer triggers
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:22:12 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
'return to homebranch'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97536|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize ---
Created attachment 98293
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98293&action=edit
Bug 24298: Record transfer triggers for returns
This patch adds handling to catch transfers that may have been triggered
on item return.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:22:15 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
'return to homebranch'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
--- Comment #10 from Martin Renvoize ---
Created attachment 98294
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98294&action=edit
Bug 24298: Add tests for ModItemTransfer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:23:33 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
'rotating collections'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97537|0 |1
is obsolete| |
--- Comment #7 from Martin Renvoize ---
Created attachment 98295
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98295&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:23:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:23:36 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
'rotating collections'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #97538|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize ---
Created attachment 98296
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98296&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:50:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:50:47 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
columns for system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
--- Comment #40 from Jonathan Druart ---
Created attachment 98297
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98297&action=edit
Bug 22844: DBIC Schema changes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:50:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:50:51 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
columns for system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
--- Comment #41 from Jonathan Druart ---
Created attachment 98298
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98298&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:56:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 13:56:06 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
about precision
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408
--- Comment #7 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #3)
> PR for QA script:
> https://gitlab.com/koha-community/qa-test-tools/commits/issue_21
> Will be merged if this bugfix is accepted.
Done!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:06:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:06:36 +0000
Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by
barcode incremental by default (regression to 17.11)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800
Patrick Robitaille changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |patrick.robitaille at collecto
| |.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:14:34 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
(bug 11373)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|11373 |24208
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
[Bug 11373] Add "change calculation" feature to the fine payment forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208
[Bug 24208] Remove change calculation for writeoffs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:14:34 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
fine payment forms
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22359 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
[Bug 22359] Improve usability of 'change calculation' (bug 11373)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:14:34 +0000
Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |22359
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
[Bug 22359] Improve usability of 'change calculation' (bug 11373)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:20:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:20:57 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
potential security issue when running from git
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949
--- Comment #24 from Martin Renvoize ---
It seemed like a reasonable idea to clarify our directory structure somewhat as
this patch tries to do.. I'm open to either patch really, but wanted to see how
viable this one was before defaulting to the other.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:23:01 +0000
Subject: [Koha-bugs] [Bug 4809] Allow to pay lost item replacement fee when
changing the lost status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |14825
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:23:01 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |4809
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809
[Bug 4809] Allow to pay lost item replacement fee when changing the lost status
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:27:35 +0000
Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login
account
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237
--- Comment #10 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > Marcel, do you still plan to work on this?
>
> I cleared the Assignee field.
Although I am still interested in this feature btw.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:42:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:42:19 +0000
Subject: [Koha-bugs] [Bug 22684] Make Acquisition::Basket->bookseller match
the code guidlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
Resolution|--- |WONTFIX
--- Comment #3 from Martin Renvoize ---
I don't remember the history of this bug.. closing until it raises itself
again.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:42:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:42:19 +0000
Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch
related object rather than searching for the object
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
Bug 22407 depends on bug 22684, which changed state.
Bug 22684 Summary: Make Acquisition::Basket->bookseller match the code guidlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:44:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:44:51 +0000
Subject: [Koha-bugs] [Bug 23317] Elasticsearch -
IntranetCatalogSearchPulldown breaks searching indexes via query
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23317
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:47:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:47:00 +0000
Subject: [Koha-bugs] [Bug 24567] New: CCL syntax does not allow for multiple
indexes to be searched at once
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567
Bug ID: 24567
Summary: CCL syntax does not allow for multiple indexes to be
searched at once
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
A search like:
ti:glory and au:clinton
should return results with glory in the title and clinton in the author, this
works in Zebra but does not work in ES currently
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:53:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 14:53:34 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200
--- Comment #7 from Jonathan Druart ---
Not fixed it seems :-/
Koha_Master_D8 (run 661)
koha_1 | DBIC result _type isn't of the _type BiblioMetadata at
/kohadevbox/koha/Koha/Patron.pm line 621.
koha_1 | # Looks like your test exited with 255 just after 58.
koha_1 | [12:01:25] t/db_dependent/Patron/Borrower_PrevCheckout.t
...........................
koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00)
koha_1 | Failed 2/60 subtests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:03:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:03:13 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
never called and should be removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #5 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt by:
> > commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
> > Bug 21346: Convert dialogs to modals.
As for what it used to do, I couldn't work it out either.. hence removing it as
at the moment it's just noise in an already complicated template file... I hope
to continue down this tree and ratify transfers handling.. just waiting for a
few more of the foundational bugs to be signed off before I continue.
>
> I do not manage to know if that was expected. How is this related to bug
> 21944?
Hmm, maybe my git blame foo got the wrong bug for where the use was dropped.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:04:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:04:10 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
circulation_rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936
--- Comment #105 from Joonas Kylmälä ---
I would still like to wait Joubu to update
https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that
branch all the tests pass again. The defaults currently differ from the
original values and therefore the tests don't pass.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:08:28 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
circulation_rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936
--- Comment #106 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #105)
> I would still like to wait Joubu to update
> https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that
> branch all the tests pass again. The defaults currently differ from the
> original values and therefore the tests don't pass.
I can actually just do upgradedatabase from master and run the tests so this is
not necessary. Sorry for the noise.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:21:21 +0000
Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #2 from Jonathan Druart ---
Hello Jawad,
Are you able to know if it happens on an edit or a new bibliographic record?
Also, were you able to identify the record(s?) that causes this problem?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:39:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:39:35 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
response even when cancellation succeeds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #1 from Jonathan Druart ---
What is the point of SIP::Patron->drop_hold? Are we maintaining a list of holds
to avoid fetching them several times?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:49:33 +0000
Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set
- even if showLastPatron is turned off
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |20312
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312
[Bug 20312] Add a link towards the last consulted patron
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 15:49:33 +0000
Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |24549
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549
[Bug 24549] Cookies for last patron link are always set - even if
showLastPatron is turned off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 16:01:22 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
circulation_rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936
Joonas Kylmälä changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #107 from Joonas Kylmälä ---
I followed the test plan, and as requested there to test some specific rules I
know, I choose to test hold related rules and renewal rules.
Signed-off-by: Joonas Kylmälä
Big thanks for all involved on this 2+ years old bug!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:05:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Feb 2020 16:05:48 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
circulation_rules
In-Reply-To: