From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:13:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:13:01 +0000 Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care about precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:13:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:13:22 +0000 Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:14:49 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #10 from Joy Nelson --- Does not apply to 19.11.x branch. Please rebase if needed for 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:20:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:20:24 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:25:35 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- Andrew, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:25:41 +0000 Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:25:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:25:56 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #21 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:26:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:26:10 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:26:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:26:24 +0000 Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:29:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:29:51 +0000 Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #8 from Joy Nelson --- Does not apply to 19.11.x branch. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:35:33 +0000 Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:35:33 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Bug 24336 depends on bug 24341, which changed state. Bug 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:35:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:35:34 +0000 Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Bug 24433 depends on bug 24341, which changed state. Bug 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:36:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:36:45 +0000 Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- Not backported to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:37:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:37:32 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:46:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:46:11 +0000 Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- This applies to 19.11. branch, but qa tests show this error: Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 287. Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 287. Not backported unless these are not major errors. -joy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:46:51 +0000 Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #9 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:47:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:47:17 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:47:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:47:33 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #14 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:50:21 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 00:50:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Jan 2020 23:50:23 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 --- Comment #2 from Lucas Gass --- Created attachment 98259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98259&action=edit Bug 24560: Dont show Public lists if there are 0 TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:00:47 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #34 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:01:31 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #53 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:01:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:01:32 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Bug 24161 depends on bug 12502, which changed state. Bug 12502 Summary: Add columns for note, order number and ISBN to late orders page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:02:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:02:22 +0000 Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:02:53 +0000 Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column to "OPAC item level holds" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:03:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:03:24 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #6 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:03:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:03:58 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:04:48 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #19 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:05:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:05:27 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98259|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98260&action=edit Bug 24560: Dont show Public lists if there are 0 Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 01:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 00:05:56 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 02:55:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 01:55:29 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Myka Kennedy Stephens --- These patches work as expected in both Zebra and ES for personal names. Applied the patch and saved the record again. It stripped the ending "," before $e in a 100 field and created a new authority record. Re-saving the record again kept the 100 field linked to the same authority record. Uniform titles are another matter. Applied patch and saved the record again. It stripped the ending ";" before $v in an 830 field and created a new authority record. Re-saving the record again created another new authority record and re-linked the 830 to the new authority record. I'm also noticing that it is still creating additional authority records for other fields, but not consistently. For example, one record I tried kept subject heading links between saves, but another record did not. Switching between Zebra and ES didn't seem to make a difference. The bibliographic records I tested came from the Library of Congress Z39.50 server: #1 - ISBN 9781540960573 #2 - ISBN 9789004130784 #3 - ISBN 9781532653308 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:12:21 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column filter feature to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:12:21 +0000 Subject: [Koha-bugs] [Bug 24561] New: Add embedded column filter feature to datatables api wrapper Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Bug ID: 24561 Summary: Add embedded column filter feature to datatables api wrapper Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: agustinmoyano at theke.io Reporter: agustinmoyano at theke.io QA Contact: testopia at bugs.koha-community.org CC: tomascohen at gmail.com Depends on: 20212, 24502 Blocks: 20936 Bug 24502 introduced filtering by embedded columns. It would be great if datatables wrapper for the API in bug 20212 could use this feature. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] Add a query language and param (q=) to the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:12:21 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column filter feature to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:12:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:12:21 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column filter feature to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:17:41 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24356, 24502 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 [Bug 24356] objects.search prefetch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] Add a query language and param (q=) to the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:17:41 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:17:41 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:47:09 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:47:13 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97935|0 |1 is obsolete| | Attachment #97936|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano --- Created attachment 98261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98261&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:47:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:47:17 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #13 from Agustín Moyano --- Created attachment 98262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98262&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 05:49:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 04:49:01 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #14 from Agustín Moyano --- (In reply to David Nind from comment #11) > Tests fail: > > prove t/db_dependent/Koha/Object* > > t/db_dependent/Koha/Objects.t .. 18/21 > # Failed test 'Relationship matching method name is listed' > # at t/db_dependent/Koha/Objects.t line 800. > > # Failed test 'Guessed the object class correctly' > # at t/db_dependent/Koha/Objects.t line 804. > # got: undef > # expected: 'Koha::Acquisition::BasketGroup' > # Looks like you failed 2 tests of 2. > > # Failed test 'prefetch_whitelist() tests' > # at t/db_dependent/Koha/Objects.t line 809. > # Looks like you failed 1 test of 21. > t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/21 subtests > t/db_dependent/Koha/Object.t ... 17/18 > # Failed test 'Relationship matching method name is listed' > # at t/db_dependent/Koha/Object.t line 754. > > # Failed test 'Guessed the object class correctly' > # at t/db_dependent/Koha/Object.t line 758. > # got: undef > # expected: 'Koha::Acquisition::BasketGroup' > # Looks like you failed 2 tests of 2. > > # Failed test 'prefetch_whitelist() tests' > # at t/db_dependent/Koha/Object.t line 763. > # Looks like you failed 1 test of 18. > t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/18 subtests > > Test Summary Report > ------------------- > t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1) > Failed test: 21 > Non-zero exit status: 1 > t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1) > Failed test: 18 > Non-zero exit status: 1 > Files=2, Tests=39, 22 wallclock secs ( 0.05 usr 0.01 sys + 17.92 cusr 3.05 > csys = 21.03 CPU) > Result: FAIL Hi David, thanks for testing. I just rebased and fixed tests. Could you please do another run? Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:21:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 08:21:18 +0000 Subject: [Koha-bugs] [Bug 20627] Prevent leakages of user permissions to api access tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627 --- Comment #2 from Martin Renvoize --- I still hope to get to it at some point.. likely when rebasing Kyle's work on permissions which is on my list for later this month. I envisage an OAuth2 style scopes system from the API perspective.. but th foundations for that are not yet available in Koha permissions code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 09:42:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 08:42:36 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #44 from Martin Renvoize --- Thanks David, that's great news. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:20:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 11:20:02 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:20:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 11:20:05 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98258|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 98263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98263&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 12:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 11:53:01 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #15 from David Nind --- Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error message: Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261. TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser.pm line 472 TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0), HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55 TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 130 TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0), "TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Harness.pm line 852 TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at /usr/share/perl/5.24/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at /usr/share/perl/5.24/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm line 571 TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 546 App::Prove::_runtests(App::Prove=HASH(0x562a13143888), HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 504 App::Prove::run(App::Prove=HASH(0x562a13143888)) called at /usr/bin/prove line 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 14:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 13:04:50 +0000 Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 14:25:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 13:25:09 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #6 from Andreas Roussos --- As Hugo pointed out, this bug has two aspects. 1) Firstly, there's the issue of the subfield not appearing in the MARC Modification Template (MMT) action description when its value is 0 (even though it will appear when editing the action). These are the relevant lines of code from marc_modification_templates.tt: 136 [% ActionsLoo.from_field | html %][% IF ( ActionsLoo.from_subfield ) %]$[% ActionsLoo.from_subfield | html %][% END %] 143 to [% ActionsLoo.to_field | html %][% IF ( ActionsLoo.to_subfield ) %]$[% ActionsLoo.to_subfield | html %][% END %] 154 [% ActionsLoo.conditional_field | html %][% IF ( ActionsLoo.conditional_subfield ) %]$[% ActionsLoo.conditional_subfield | html %][% END %] The problem lies with the "[% IF ( ... ) %]" statements: when the from/to/conditional subfield value is set to 0 the IF clause will evaluate to false and therefore the value will not be printed. 2) Secondly, we have an error message coming up in the Plack log file ("This action is not implemented yet"), and this relates to commit c7d862b (from Bug 11319). In that commit, among other things, the update_field() subroutine was added to SimpleMARC.pm, the most relevant lines of which are: 167 if ( not $subfieldName or $subfieldName eq '' ) { 168 # FIXME I'm not sure the actual implementation is correct. 169 die "This action is not implemented yet"; 170 #_update_field({ record => $record, field => $fieldName, values => \@values }); 171 } else { 172 _update_subfield({ record => $record, field => $fieldName, subfield => $subfieldName, values => \@values, field_numbers => $field_numbers }); 173 } The first condition in the 'if' clause above results in the expression evaluating to true when a subfield value of 0 (integer zero) or '0' (string zero) is entered -- hence the error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:36:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 16:36:31 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:36:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 16:36:33 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98260|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 98264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98264&action=edit Bug 24560: Dont show No Public Lists in OPAC Offering a better patch. Test plan remains the same. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 17:43:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 16:43:18 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98264|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 98265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98265&action=edit Bug 24560: Remove No public list text from OPAC TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 20:47:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 19:47:07 +0000 Subject: [Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:23:19 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:23:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:23:22 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98225|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98266&action=edit Bug 24554: Only embed relations from Koha::Biblio in to_api This patch simplifies the behaviour of Koha::Biblio->to_api. It was designed with the idea of handling possible methods that would be added to Koha::Biblioitem. But it had a weird fallback behaviour was highlighted by using it with bug 24528. On fixing it it become obvious that it was unnessessarily complex and that it was not worth. That's the reason there wasn't any test for it, as Koha::Biblioitem doesn't implement any extra methods. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:47:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:47:46 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #67 from Katrin Fischer --- Created attachment 98267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98267&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:53:38 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98267|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer --- Created attachment 98268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98268&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:58:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:58:04 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #69 from Katrin Fischer --- Notes & questions 1) We might want to modify the bug title a little - in addition to allow changing the manager, this will also store the last person to change and date. Also gives a checkbox for TO_PROCESS. We really needs some release notes :) 2) lastmodificationdate and lastmodificationby are quite long. It might be nicer to used something more readable like: last_modified_on and last_modified_by. Not blocker for me, but putting the thought out there. 3) Is there a reason why we don't let the db update thelastmodificationdate? 4) Please check my follow-up Blockers 1) When I change the manager, the lastmodification* are not updated. 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for the manager. I believe this should be handled separately. ( Bug 13014: Notify budget owner on new suggestion - cronjob) 3) + if ( $notify ) { + my $patron = Koha::Patrons->find( $suggestion_only->{managedby} ); + my $email_address = $patron->notice_email_address; + if ($patron->notice_email_address) { + my $budget = C4::Budgets::GetBudget( $suggestion_only->{budgetid} ); $budget appears not to be used - possibly a copy&paste because of 2). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:58:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:58:22 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 21:59:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 20:59:41 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #70 from Katrin Fischer --- I think it would have been nice to split this: - Add last modification* - Add ability to change manager - Add ability to notify - last bit could still be pulled out maybe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:19:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 21:19:52 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:19:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 21:19:55 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95821|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 98269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98269&action=edit Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly preselected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 21:46:51 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:46:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 21:46:57 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98232|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 98270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98270&action=edit Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 1 22:47:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Feb 2020 21:47:00 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98233|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 98271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98271&action=edit Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 02:48:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2020 01:48:04 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #11 from David Nind --- (In reply to David Nind from comment #10) > I get this message when trying to apply this patch (git bz apply 24502): > > Failed to retrieve bug information: NotPermitted Figured it out - a dependency is security related. Will let someone else test who has the right access! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:13:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2020 20:13:45 +0000 Subject: [Koha-bugs] [Bug 24562] New: addbiblio.pl overloading CPU Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 Bug ID: 24562 Summary: addbiblio.pl overloading CPU Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jawad_makki at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hello. Sometimes during the day, addbiblio.pl is overloading CPU (100%) and therefore it is making Koha completely not responding for few minutes (can reach 20 minutes). in apache2 log, the response time for "POST /cgi-bin/koha/cataloguing/addbiblio.pl HTTP/1.1" is reaching gateway timeout few times per day. below are some errors retrieved from plack-error.log Use of uninitialized value $mode in string ne at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 845. Use of uninitialized value $searchid in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 876. Koha version 19.11 , running on debian 9 memcached and plack are enabled. this problem was also in 18.11, we have upgraded koha to 19.11 but the problem is still occuring Any help -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:18:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2020 20:18:56 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #1 from Jawad Makki --- these are more errors retrieved from plack-error.log /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 708. Use of uninitialized value $frameworkcode in string eq at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 712. Use of uninitialized value $frameworkcode in string eq at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 731. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 21:51:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2020 20:51:11 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00,, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.08 --- Comment #42 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 2 23:44:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Feb 2020 22:44:36 +0000 Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 01:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 00:49:18 +0000 Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 --- Comment #3 from Tomás Cohen Arazi --- We come up with a totally different approach to this with bug 22835. While this is still valid for legacy plugins, I suggest we push everyone into updating their plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 04:37:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 03:37:02 +0000 Subject: [Koha-bugs] [Bug 24563] New: Internal Server error when clicking Tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563 Bug ID: 24563 Summary: Internal Server error when clicking Tools Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: librarian at sageuniversity.in QA Contact: testopia at bugs.koha-community.org I am face problem in tools module,i am enable plugin in koha and click this module internal server error please see the matter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 06:59:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 05:59:17 +0000 Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563 Govind Basedia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian at sageuniversity.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:41:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 07:41:25 +0000 Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 --- Comment #15 from Rudolf Byker --- Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page, it's still not handled gracefully on these pages: /cgi-bin/koha/catalogue/ISBDdetail.pl /cgi-bin/koha/catalogue/MARCdetail.pl New issue? Or re-open this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 07:54:43 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #7 from Marcel de Rooy --- etc/zebradb/authorities/etc/dom-config-marc.xml etc/zebradb/authorities/etc/dom-config.xml etc/zebradb/biblios/etc/dom-config-marc.xml etc/zebradb/biblios/etc/dom-config.xml etc/zebradb/xsl/zebra.xsl koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js xt/find-license-problems.t xt/fix-old-fsf-address Should we still address a few of these ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 08:59:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 07:59:59 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:00:03 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 --- Comment #3 from David Nind --- Created attachment 98272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98272&action=edit Bug 24463: Add a basket_group relationship for baskets This patch aims to bring consistency between the accessor name and the underlying relationship to ease things when using it from the API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! No behavior change! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:01:22 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > As I said this morning on #koha, I do not think we should silently delete > those rows. Instead of deleting we could look at setting to NULL. Not sure if it would be very valuable? We could dump the original serial tables to a backup file allowing a local developer to restore information; not sure if anyone would. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:04:50 +0000 Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:04:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:04:53 +0000 Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97628|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98273&action=edit Bug 24463: Add a basket_group relationship for baskets This patch aims to bring consistency between the accessor name and the underlying relationship to ease things when using it from the API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! No behavior change! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:11:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:11:23 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Hi Tomás. I think I've somehow mucked up the sign-off - I've somehow added Bug 24463 patch to it as well.. If you could let me know how to fix it up, or reset it so I can sign-off again, that would be great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:31:19 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:31:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:31:59 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #3 from David Nind --- Looks like this was signed-off, but the status wasn't changed. Have changed to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:32:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:32:41 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:35:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:35:15 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #17 from Martin Renvoize --- Setting to NULL leaves us with broken data and worse an avenue to new broken data being input. Personally, as I couldn't' find any cases where a delete would actually take place (and I went back to some koha versions many years old) and the data being deleted would lead to errors in the client as relations would be broken I feel it's justified to leave the delete in place... open to being countered as ever but I'd rather this didn't end up stuck in perpetuity as so many FK bugs do :'(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:41:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:41:59 +0000 Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- (In reply to Rudolf Byker from comment #15) > Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page, it's > still not handled gracefully on these pages: > > /cgi-bin/koha/catalogue/ISBDdetail.pl > /cgi-bin/koha/catalogue/MARCdetail.pl > > New issue? Or re-open this one? Hi Rudolf, when in doubt always open a new bug report. Especially when the bug has been already pushed/released/closed as is the case here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:46:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:46:16 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- If I undertand this correctly the problem might be cases where there is incomplete data? like a subscription without subscription history? Or a serial entry with a link to a nonexisting subscription? We store the user's name in subscription... so if we are very strict we might not want to dump it to the file system to be forgotten about. If we set to null, we need to make the db structure more lenient... I guess dumping might be the best option. How likely is it those cases exist? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:47:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:47:24 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #98272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:47:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:47:56 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 --- Comment #5 from Katrin Fischer --- Hi David, I fixed it, the way is: Details > Edit details > Obsolete. Do you want to try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:56:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:56:41 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 09:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 08:56:44 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97269|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 98274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98274&action=edit Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface It was noted, that 'sub fund' might be a better term to use than 'child fund'. So this patch changes it. To test, check with and without patch: - Add a budget in acquisitions - Add a fund in acquisitions - Add a sub/child fund to your fund (label of menu item #1) - Edit your first fund, check option to update owners of sub/child funds (#2) - Try to delete your 'parent' fund (tooltip #3) - Click on the greyed out entry (alert ÃÃ#4) If you like the change, please sign-off. If you think otherwise, please comment on the bug report. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:00:03 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 --- Comment #6 from David Nind --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:03:27 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97631|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 98275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98275&action=edit Bug 24464: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:03:30 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97632|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98276&action=edit Bug 24464: Add K::A::Basket->creator This patch adds a ->creator method to Koha::Acquisition::Basket to retrieve the related Koha::Patron object. Note: this should be re-done once 22658 is pushed, but at the time being, there's not patch submitted, and it is not a trivial task because of the column type missmatch. That said, the implementation of ->creator in this class is simple enough to just rewrite it once 22658 is submitted, and the tests will reflect the expected/unchanged behavior. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:38:02 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:38:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:38:05 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97624|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98277&action=edit Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:46:18 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > etc/zebradb/authorities/etc/dom-config-marc.xml > etc/zebradb/authorities/etc/dom-config.xml > etc/zebradb/biblios/etc/dom-config-marc.xml > etc/zebradb/biblios/etc/dom-config.xml > etc/zebradb/xsl/zebra.xsl => Zebra license > koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt tiny mce license > koha-tmpl/intranet-tmpl/prog/js/offlinecirc.js Yes, follow-up coming. > xt/find-license-problems.t False positive. > xt/fix-old-fsf-address Yes, follow-up coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 10:47:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 09:47:08 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #9 from Jonathan Druart --- Created attachment 98278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98278&action=edit Bug 24545: (follow-up) Fix license statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:19:26 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #71 from Jonathan Druart --- (In reply to Katrin Fischer from comment #69) > Notes & questions > > 1) We might want to modify the bug title a little - in addition to allow > changing the manager, this will also store the last person to change and > date. Also gives a checkbox for TO_PROCESS. We really needs some release > notes :) Any suggestions? :) > 2) lastmodificationdate and lastmodificationby are quite long. It might be > nicer to used something more readable like: last_modified_on and > last_modified_by. Not blocker for me, but putting the thought out there. I followed the existing pattern As there were already 4 of those I thought it was better to keep names consistent. > 3) Is there a reason why we don't let the db update thelastmodificationdate? We can pick the max date of suggesteddate, manageddate, accepteddate, rejecteddate, is that was you have in mind? > 4) Please check my follow-up They look good, thanks! > Blockers > > 1) When I change the manager, the lastmodification* are not updated. That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion. Séverine, can you confirm the behavior you expect? > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it > for the manager. I believe this should be handled separately. ( Bug 13014: > Notify budget owner on new suggestion - cronjob) That was part of the original specification. It makes sense to have 2 different notice templates. Something to suggest? UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER? > 3) > + if ( $notify ) { > + my $patron = Koha::Patrons->find( > $suggestion_only->{managedby} ); > + my $email_address = $patron->notice_email_address; > + if ($patron->notice_email_address) { > + my $budget = C4::Budgets::GetBudget( > $suggestion_only->{budgetid} ); > $budget appears not to be used - possibly a copy&paste because of 2). Indeed, follow-up coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:20:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:20:03 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #72 from Jonathan Druart --- Created attachment 98279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98279&action=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:27:20 +0000 Subject: [Koha-bugs] [Bug 24564] New: The adding of new subfields according to IFLA updates doesn't respect existing tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Bug ID: 24564 Summary: The adding of new subfields according to IFLA updates doesn't respect existing tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using the script misc/migration_tools/ifla/update.pl (cf. BZ20434), missing fields/subfields are added but if subfields already existed in the framework, the script doesn't verifiy in which tab they existed and can add them in a different tab.So for the same field, you could have subfields in different tabs. It can lead to wrong and blocking alerts when saving a biblio record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:27:41 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr Depends on| |20434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 [Bug 20434] UNIMARC update from IFLA for existing Koha installations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:27:41 +0000 Subject: [Koha-bugs] [Bug 20434] UNIMARC update from IFLA for existing Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:46:51 +0000 Subject: [Koha-bugs] [Bug 22686] Koha::Acquisition::Bookseller->contacts should match the coding guidline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #2 from Jonathan Druart --- I missed this one. I did that on bug 22685, and provided tests :) *** This bug has been marked as a duplicate of bug 22685 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:46:51 +0000 Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must return Koha::Objects using the DBIx::Class relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685 --- Comment #2 from Jonathan Druart --- *** Bug 22686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:46:51 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug 22407 depends on bug 22686, which changed state. Bug 22686 Summary: Koha::Acquisition::Bookseller->contacts should match the coding guidline https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22686 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:53:38 +0000 Subject: [Koha-bugs] [Bug 24565] New: ILL requests do not display in patron profile in intranet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565 Bug ID: 24565 Summary: ILL requests do not display in patron profile in intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com A patron's ILL requests are not displaying on the "ILL requests history" tab on their profile page on intranet. This is due to a check in ill-list-table.js that checks what page the user is on before sending the API request to get the requests. This check was added in bug 23229. I failed to realise that it adversely affected the patron profile page in this way. I will create a fix now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 11:53:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 10:53:57 +0000 Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron profile in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:25:37 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:25:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:25:58 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #66 from Martin Renvoize --- Seems I forgot to reset the status when I added the followup.. ready for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:32:52 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.11 --- Comment #3 from Martin Renvoize --- OK, so on master it's already added in bug 23354, but it's not in the 19.11 branch yet. Setting branch appropriately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:33:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:33:33 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:36:24 +0000 Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:36:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:36:48 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:38:30 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart --- (In reply to Michal Denar from comment #2) > Hi Jonathan, > can you rebase this patch? > > sing index info to reconstruct a base tree... > M t/db_dependent/Koha/Acquisition/Basket.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Koha/Acquisition/Basket.t > CONFLICT (content): Merge conflict in > t/db_dependent/Koha/Acquisition/Basket.t > error: Failed to merge in the changes. > Patch failed at 0001 Bug 24161: Add tests This patch is at the top of a long dependency list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:44:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:44:26 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97472|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 98280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98280&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:45:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:45:02 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:48:31 +0000 Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301 --- Comment #1 from Lucy Vaux-Harvey --- This issue has been raised also by one of our supported libraries on 18.11.11. When the item is scanned the hold is always assigned to the correct user (first on the hold priority list) but this is often not the user that was listed in the 'First patron' column in the holds to Pull report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:50:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:50:56 +0000 Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron profile in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565 --- Comment #1 from Andrew Isherwood --- Created attachment 98281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98281&action=edit Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 12:52:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 11:52:25 +0000 Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron profile in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:00:03 +0000 Subject: [Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301 --- Comment #2 from Michal Denar --- Hi Lucy, yes, we need to see first on the hold priority list borrower name. Now is it more or less random name from priority list. It's confusing for librarians. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:01:58 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98054|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 98282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98282&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:02:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:02:57 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from Jonathan Druart --- (In reply to Martin Renvoize from comment #66) > Seems I forgot to reset the status when I added the followup.. ready for QA The test was not passing. I have updated it, as I think we are expecting 1 checkout to be anonymised here. Still not passing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:25 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:28 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98205|0 |1 is obsolete| | Attachment #98206|0 |1 is obsolete| | Attachment #98207|0 |1 is obsolete| | Attachment #98208|0 |1 is obsolete| | Attachment #98237|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 98283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98283&action=edit Bug 24440: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:32 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #23 from Jonathan Druart --- Created attachment 98284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98284&action=edit Bug 24440: Add ->current_holds to Koha::Acquisition::Order This patch introduces a method to fetch the current holds associated with the items linked to an order line. It basically implements what's done in parcel.pl, but fully tested and suitable for using on the API. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:36 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #24 from Jonathan Druart --- Created attachment 98285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98285&action=edit Bug 24440: ->biblio tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:40 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #25 from Jonathan Druart --- Created attachment 98286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98286&action=edit Bug 24440: (follow-up) Make related objects prefetchable This patch creates aliases for the relations used to retrieve the linked objects from other tables. It makes the accessor names match the used relation name, for consistency. This is important for code trying to be smart and guessing what needs to be prefetched, like the API code. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No behaviour change 4. Verify the POD changes make sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:44 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #26 from Jonathan Druart --- Created attachment 98287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98287&action=edit Bug 24440: Adding 2 more tests for ->biblio Not directly related to the other changes but seems good to have them here. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:37:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:37:48 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #27 from Jonathan Druart --- Created attachment 98288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98288&action=edit Bug 24440: Rename current_holds with current_item_level_holds Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:39:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:39:42 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #28 from Jonathan Druart --- Not blocker, but part of this patch: Bug 24440: (follow-up) Make related objects prefetchable should have been moved to its own bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:41:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:41:10 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_item_level_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ->current_holds to |Add |Koha::Acquisition::Order |->current_item_level_holds | |to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:54:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:54:48 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #14 from Jonathan Druart --- Created attachment 98289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98289&action=edit Bug 24363: Do not use the two-value syntax for background-position-x It's not supported by chrome and chromium (inspector says "invalidd property value". See also: https://developer.mozilla.org/en-US/docs/Web/CSS/background-position-x section "Browser compatibility" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:55:18 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #15 from Jonathan Druart --- (In reply to David Nind from comment #13) > Everything looks good in Firefox. > > However with Google Chrome the icon is aligned to the inside left of the box > and the start of the date overlays it. > > I can post screenshots if required. I confirm that on both Chrome and Chromium, inspector says "invalid property value" for rule background-position-x. The new patch should fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:55:51 +0000 Subject: [Koha-bugs] [Bug 24566] New: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Bug ID: 24566 Summary: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:56:05 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:56:12 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:56:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:56:37 +0000 Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize from comment #22) > Rebased Should not we prefer to revive bug 16922 instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:57:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:57:49 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 --- Comment #5 from Jonathan Druart --- (In reply to Todd Goatley from comment #3) > Created attachment 98179 [details] > Image display issues > > Martin and Fridolin, I've recently been contacted by a Koha site on 19.05.06 > reporting they're still having issues with images. I have 3 images but could > only attached 1. This Koha site reports: > > The top example is from before the upgrade. - clear and crisp > The bottom 2 are from after the upgrade - blurred > > Images that come in automatically from online are clean/clear, but many of > the images I add myself. There was no change in the quality of the images, > but it changed with the upgrade. > > Thanks! Curious as to what is happening with this... It has been reverted as it caused regressions, see bug 22988. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:59:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:59:04 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 13:59:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 12:59:07 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 --- Comment #1 from Kyle M Hall --- Created attachment 98290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98290&action=edit Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:00:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:00:51 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:00:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:00:54 +0000 Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98290|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 98291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98291&action=edit Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall Signed-off-by: Kevin Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:22:09 +0000 Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97535|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 98292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98292&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:22:12 +0000 Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97536|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 98293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98293&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:22:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:22:15 +0000 Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #10 from Martin Renvoize --- Created attachment 98294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98294&action=edit Bug 24298: Add tests for ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:23:33 +0000 Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97537|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 98295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98295&action=edit Bug 24299: Add 'RotatingCollection' branchtransfer trigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:23:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:23:36 +0000 Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97538|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 98296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98296&action=edit Bug 24299: Record 'RotatingCollection' as a transfer trigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:50:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:50:47 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #40 from Jonathan Druart --- Created attachment 98297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98297&action=edit Bug 22844: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:50:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:50:51 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #41 from Jonathan Druart --- Created attachment 98298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98298&action=edit Bug 22844: Add is_boolean flag for new 'mandatory' column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 14:56:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 13:56:06 +0000 Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care about precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > PR for QA script: > https://gitlab.com/koha-community/qa-test-tools/commits/issue_21 > Will be merged if this bugfix is accepted. Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:06:36 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:14:34 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11373 |24208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 [Bug 24208] Remove change calculation for writeoffs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:14:34 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22359 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:14:34 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:20:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:20:57 +0000 Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #24 from Martin Renvoize --- It seemed like a reasonable idea to clarify our directory structure somewhat as this patch tries to do.. I'm open to either patch really, but wanted to see how viable this one was before defaulting to the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:23:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:23:01 +0000 Subject: [Koha-bugs] [Bug 4809] Allow to pay lost item replacement fee when changing the lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:23:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:23:01 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 [Bug 4809] Allow to pay lost item replacement fee when changing the lost status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:27:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:27:35 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > (In reply to Katrin Fischer from comment #8) > > Marcel, do you still plan to work on this? > > I cleared the Assignee field. Although I am still interested in this feature btw. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:42:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:42:19 +0000 Subject: [Koha-bugs] [Bug 22684] Make Acquisition::Basket->bookseller match the code guidlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Martin Renvoize --- I don't remember the history of this bug.. closing until it raises itself again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:42:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:42:19 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug 22407 depends on bug 22684, which changed state. Bug 22684 Summary: Make Acquisition::Basket->bookseller match the code guidlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:44:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:44:51 +0000 Subject: [Koha-bugs] [Bug 23317] Elasticsearch - IntranetCatalogSearchPulldown breaks searching indexes via query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:47:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:47:00 +0000 Subject: [Koha-bugs] [Bug 24567] New: CCL syntax does not allow for multiple indexes to be searched at once Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Bug ID: 24567 Summary: CCL syntax does not allow for multiple indexes to be searched at once Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com A search like: ti:glory and au:clinton should return results with glory in the title and clinton in the author, this works in Zebra but does not work in ES currently -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 15:53:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 14:53:34 +0000 Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200 --- Comment #7 from Jonathan Druart --- Not fixed it seems :-/ Koha_Master_D8 (run 661) koha_1 | DBIC result _type isn't of the _type BiblioMetadata at /kohadevbox/koha/Koha/Patron.pm line 621. koha_1 | # Looks like your test exited with 255 just after 58. koha_1 | [12:01:25] t/db_dependent/Patron/Borrower_PrevCheckout.t ........................... koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 2/60 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:03:13 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #5 from Martin Renvoize --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt by: > > commit 5ed171a45c46f63b18266ad3a3d0a978719ca285 > > Bug 21346: Convert dialogs to modals. As for what it used to do, I couldn't work it out either.. hence removing it as at the moment it's just noise in an already complicated template file... I hope to continue down this tree and ratify transfers handling.. just waiting for a few more of the foundational bugs to be signed off before I continue. > > I do not manage to know if that was expected. How is this related to bug > 21944? Hmm, maybe my git blame foo got the wrong bug for where the use was dropped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:04:10 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #105 from Joonas Kylmälä --- I would still like to wait Joubu to update https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that branch all the tests pass again. The defaults currently differ from the original values and therefore the tests don't pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:08:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:08:28 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #106 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #105) > I would still like to wait Joubu to update > https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that > branch all the tests pass again. The defaults currently differ from the > original values and therefore the tests don't pass. I can actually just do upgradedatabase from master and run the tests so this is not necessary. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:21:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:21:21 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hello Jawad, Are you able to know if it happens on an edit or a new bibliographic record? Also, were you able to identify the record(s?) that causes this problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:39:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:39:35 +0000 Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What is the point of SIP::Patron->drop_hold? Are we maintaining a list of holds to avoid fetching them several times? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:49:33 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20312 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 [Bug 20312] Add a link towards the last consulted patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 16:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 15:49:33 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:01:22 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #107 from Joonas Kylmälä --- I followed the test plan, and as requested there to test some specific rules I know, I choose to test hold related rules and renewal rules. Signed-off-by: Joonas Kylmälä Big thanks for all involved on this 2+ years old bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:05:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:05:48 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #108 from Jonathan Druart --- Created attachment 98299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98299&action=edit Bug 18936: Convert issuingrules fields to circulation_rules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:05:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:05:54 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #109 from Jonathan Druart --- Created attachment 98300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98300&action=edit Bug 18936: (followup) Fix upgrade step Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:05:58 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #110 from Jonathan Druart --- Created attachment 98301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98301&action=edit Bug 18936: Fix api/v1/holds.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:05 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #111 from Jonathan Druart --- Created attachment 98302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98302&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:10 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #112 from Jonathan Druart --- Created attachment 98303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98303&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:15 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #113 from Jonathan Druart --- Created attachment 98304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98304&action=edit Bug 18936: (follow-up) fix rental odiscount lookup Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:20 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #114 from Jonathan Druart --- Created attachment 98305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98305&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:25 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #115 from Jonathan Druart --- Created attachment 98306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98306&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:30 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #116 from Jonathan Druart --- Created attachment 98307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98307&action=edit Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:35 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #117 from Jonathan Druart --- Created attachment 98308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98308&action=edit Bug 18936: move get_opacitemholds_policy method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:40 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #118 from Jonathan Druart --- Created attachment 98309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98309&action=edit Bug 18936: Move guess_article_requestable_itemtypes method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:45 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #119 from Jonathan Druart --- Created attachment 98310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98310&action=edit Bug 18936: Remove last bit of Koha::IssuingRule Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:50 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #120 from Jonathan Druart --- Created attachment 98311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98311&action=edit Bug 18936: Fix syntax issue TODO: Replace croak with exceptions Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:06:55 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #121 from Jonathan Druart --- Created attachment 98312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98312&action=edit Bug 18936: Fix several issues Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:01 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #122 from Jonathan Druart --- Created attachment 98313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98313&action=edit Bug 18936: chargename removed by bug 21753 Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:06 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #123 from Jonathan Druart --- Created attachment 98314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98314&action=edit Bug 18936: new suspension_chargeperiod Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:11 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #124 from Jonathan Druart --- Created attachment 98315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98315&action=edit Bug 18936: new holds_per_day Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:16 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #125 from Jonathan Druart --- Created attachment 98316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98316&action=edit Bug 18936: Replace an other insert into issuingrules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:21 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #126 from Jonathan Druart --- Created attachment 98317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98317&action=edit Bug 18936: Fix Circulation.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:27 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #127 from Jonathan Druart --- Created attachment 98318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98318&action=edit Bug 18936: More fixes Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:32 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #128 from Jonathan Druart --- Created attachment 98319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98319&action=edit Bug 18936: Add missing filters Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:37 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #129 from Jonathan Druart --- Created attachment 98320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98320&action=edit Bug 18936: Fix Update DB entry Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:43 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #130 from Jonathan Druart --- Created attachment 98321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98321&action=edit Bug 18936: fixes from comment #88 - holds per day are not transferred in database update (actually not displayed) - in note column, I can see link "view notes" even if there is no note - No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:48 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #131 from Jonathan Druart --- Created attachment 98322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98322&action=edit Bug 18936: Fix warning about page about wrong lengthunit Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:53 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #132 from Jonathan Druart --- Created attachment 98323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98323&action=edit Bug 18936: (follow-up) Don't retrieve unused issuing rule The chargename rule is not used anywhere in the code Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:07:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:07:59 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #133 from Jonathan Druart --- Created attachment 98324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98324&action=edit Bug 18936: Fix some more tests * CanItemBeReserved Prior to "Bug 18936: Convert issuingrules fields to circulation_rules", GetHoldRule returned holds_per_record even if no reservesallowed was defined. This change restores this behavior. FIXME Note: In GetHoldRule we return itemtype only if reservesallowed is set, not sure it is correct. * t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t When setting returnbranch, holdallowed and hold_fulfillment_policy, we should not provide categorycode. * t/db_dependent/Holds.t Prefer to keep the existing rules instead of removing them. It got quite hard to understand what was going on here because of the mixup with the rule reservesallowed that was in issuingrules, and the other rules we used for the tests. Also, categorycode should not be passed to set those 3 rules (holdallowed, hold_fulfillment_policy and returnbranch) * t/db_dependent/Circulation.t Setting lengthunit to 'hours', no need to make sure the rule has been correctly be saved * t/db_dependent/Circulation/CalcDateDue.t It uses hardcoded data that is not in the sample data (categorycode=C). Let use K that exists and postpone a refactore of the whole script (to make it create the data it needs). * t/db_dependent/Circulation/ReturnClaims.t * t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t Simple replace Koha::IssuingRule with Koha::CirculationRules * t/db_dependent/Koha/Charges/Fees.t => FIXME Still failing, stuck here, need help Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:04 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #134 from Jonathan Druart --- Created attachment 98325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98325&action=edit Bug 18936: (follow-up) Add missing circulation rule to fix tests The tests passed before by a chance because the default kohadevbox installation script added a issuing rule that had lengthunit = days. If you use a Koha version before the commits introduced by Bug 18936 you can reproduce the Fees.t tests failing by deleting all the issuing rules from database with > delete issuingrules; and then running $ prove t/db_dependent/Koha/Charges/Fees.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:09 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #135 from Jonathan Druart --- Created attachment 98326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98326&action=edit Bug 18936: Make sure we default to '*' if no rule exist Making sure the code is doing what we expect. Also this patch fix CirculationRules.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:14 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #136 from Jonathan Druart --- Created attachment 98327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98327&action=edit Bug 18936: Insert default rules during the onboarding tool Those default values have been picked from bug 15522 (Koha::CirculationRules) Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:20 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #137 from Jonathan Druart --- Created attachment 98328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98328&action=edit Bug 18936: Replace '*' with undef No test was provided initially so considering out of the scope for this one as well, but that's lacking terribly! Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:25 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #138 from Jonathan Druart --- Created attachment 98329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98329&action=edit Bug 18936: Fix the delete rule buttons The itemtype and categorycode were always set to '*' Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:31 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #139 from Jonathan Druart --- Created attachment 98330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98330&action=edit Bug 18936: (follow-up 2) Add foreign key and scope enhancement to circ rules The previous patch modifies: - categorycode => undef, - itemtype => undef, - branchcode => $branch, + branchcode => undef, But in that condition $branchcode is not '*' and so we should not set it to undef Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:36 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #140 from Jonathan Druart --- Created attachment 98331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98331&action=edit Bug 18936: (follow-up) Fix typo in documentation Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:41 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #141 from Jonathan Druart --- Created attachment 98332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98332&action=edit Bug 18936: (follow-up) Add missing import of Koha::CirculationRules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:47 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #142 from Jonathan Druart --- Created attachment 98333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98333&action=edit Bug 18936: Fix inconsistencies in IssuingRules.t * get_effective_rule should not pass rule_value * indentation fix * add comment to list the rules we have when the test _is_row_match is executed * compare ->rule_name and ->rule_value returns Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:52 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #143 from Jonathan Druart --- Created attachment 98334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98334&action=edit Bug 18936: (follow-up2) Fix tests, replace old get_onshelfholds_policy method Previous change to this file was different from the one that existed prior to this patchset. Restoring value for onshelfholds, note that it did not change anything in the test result. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:08:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:08:58 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #144 from Jonathan Druart --- Created attachment 98335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98335&action=edit Bug 18936: (follow-up) Add cloning of circulation rules back to Koha The "Clone these rules" feature in admin/smart-rules.pl was dropped. This re-implements the cloning using Koha objects. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:03 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #145 from Jonathan Druart --- Created attachment 98336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98336&action=edit Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day Without this it is not possible to make for a specific patron category or itemtype a more specific unlimited holds_per_day rule if you have a catch all rule (categorycode = *, itemtype = *) with limited holds_per_day value. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:08 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #146 from Jonathan Druart --- Created attachment 98337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98337&action=edit Bug 18936: (follow-up2) Make possible to have unlimited value for holds_per_day Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:14 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #147 from Jonathan Druart --- Created attachment 98338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98338&action=edit Bug 18936: Fix IssuingRules/guess_article_requestable_itemtypes.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:19 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #148 from Jonathan Druart --- Created attachment 98339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98339&action=edit Bug 18936: (follow-up) Adjust circ rule related tests so that they pass Bunch of tests broke after moving from issuingrules to circulation_rules. This accomodates the tests for this refactoring and DB change. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:25 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #149 from Jonathan Druart --- Created attachment 98340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98340&action=edit Bug 18936: (follow-up2) Adjust circ rule related tests so that they pass The itemtype did not exist in the DB. We create it at the beginning of the tests. Ideally we would like to create it filling the form. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:30 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #150 from Jonathan Druart --- Created attachment 98341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98341&action=edit Bug 18936: (follow-up) Fix checkouts endpoint and its tests - Fixes a bug caused by the refactoring in Koha/REST/V1/Checkouts.pm (run the tests without this patch and you will see the tests fails because 'rule_name' parameter was forgotten). - Changes the tests to use the new Koha::CirculationRule objects instead of directly using issuingrules DB table Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:35 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #151 from Jonathan Druart --- Created attachment 98342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98342&action=edit Bug 18936: (QA follow-up) Add missing POD Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:41 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #152 from Jonathan Druart --- Created attachment 98343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98343&action=edit Bug 18936: (follow-up) More fixes Previous "More fixes" patch added a debugging statement, not needed. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:46 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #153 from Jonathan Druart --- Created attachment 98344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98344&action=edit Bug 18936: (QA follow-up) Convert remaining tests to use Koha::CirculationRules These two uses of Koha::IssuingRule were forgotten so this converts them to use the new Koha::CirculationRules object. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:52 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #154 from Jonathan Druart --- Created attachment 98345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98345&action=edit Bug 18936: Remove 2 new occurrences of Koha::IssuingRules Fix conflict with bug 13121 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:09:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:09:57 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #155 from Jonathan Druart --- Created attachment 98346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98346&action=edit Bug 18936: (QA follow-up) Fix failing test Using categorycode as a scope is not possible for any of these rules so lets remove it. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:10:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:10:03 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #156 from Jonathan Druart --- Created attachment 98347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98347&action=edit Bug 18936: Fix failing test in api/v1/holds.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:12:24 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #5 from Christopher Brannon --- > Hi Christopher, we don't use the longoverdue process ourselves, I was not > aware that it's used in combination with the overdue notices. I am confused. If you were not aware that it is used in combination with the overdue notices, what is it intended for? The header says 'Defining default overdue actions', and the choices include sending a letter. Without this pl, how else do overdue notices get sent? > For our libraries the major concern is that it should be timed > with the creating of fines, which is usually happening in a weekly interval > here. Many of our libraries are no longer charging fines. > I wonder if it could make sense to not tie it overdue notices but to their > own set of notices by itemtype? Both could live on the same configuration > page tho. I'm not sure what you mean? Can you elaborate? How would you implement this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:13:15 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98262|0 |1 is obsolete| | --- Comment #16 from Agustín Moyano --- Created attachment 98348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98348&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:14:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:14:14 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #17 from Agustín Moyano --- (In reply to David Nind from comment #15) > Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error > message: > > Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at > /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261. > TAP::Parser::IteratorFactory::detect_source(TAP::Parser:: > IteratorFactory=HASH(0x562a13917438), > TAP::Parser::Source=HASH(0x562a13917510)) called at > /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211 > TAP::Parser::IteratorFactory::make_iterator(TAP::Parser:: > IteratorFactory=HASH(0x562a13917438), > TAP::Parser::Source=HASH(0x562a13917510)) called at > /usr/share/perl/5.24/TAP/Parser.pm line 472 > TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0), > HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55 > TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at > /usr/share/perl/5.24/TAP/Object.pm line 130 > TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0), "TAP::Parser", > HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Harness.pm line 852 > TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0), > TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at > /usr/share/perl/5.24/TAP/Harness.pm line 651 > TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0), > TAP::Parser::Aggregator=HASH(0x562a13168d48), > TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at > /usr/share/perl/5.24/TAP/Harness.pm line 743 > TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0), > TAP::Parser::Aggregator=HASH(0x562a13168d48), > "t/db_dependent/Koha/REST/Plugin/Query.t") called at > /usr/share/perl/5.24/TAP/Harness.pm line 558 > TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm line > 571 > TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0), > "t/db_dependent/Koha/REST/Plugin/Query.t") called at > /usr/share/perl/5.24/App/Prove.pm line 546 > App::Prove::_runtests(App::Prove=HASH(0x562a13143888), > HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at > /usr/share/perl/5.24/App/Prove.pm line 504 > App::Prove::run(App::Prove=HASH(0x562a13143888)) called at /usr/bin/prove > line 13 Ups!.. the path of Query.t was not in db_dependent. Sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:22:18 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98282|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 98349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98349&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:22:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:22:58 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #70 from Jonathan Druart --- (In reply to Jonathan Druart from comment #68) > (In reply to Martin Renvoize from comment #66) > > Seems I forgot to reset the status when I added the followup.. ready for QA > > The test was not passing. I have updated it, as I think we are expecting 1 > checkout to be anonymised here. Still not passing. Forget that, I misread the code. We want 4 checkouts to be anonymised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:28:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:28:09 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98265|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes --- Created attachment 98350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98350&action=edit Bug 24560: Remove No public list text from OPAC Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:28:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:28:27 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:32:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:32:17 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #71 from Martin Renvoize --- I see!!!! Right.. I totally missed that `but not if the item is lost, damaged, or withdrawn.` in the original request is different to how the existing anonymisation logic works. Personally (and I've checked with a few people now) I feel that the two locations this data is stored should be anonymised equally so they don't fall out of sync. As this is a change in a privacy feature I think we probably need to govern whether we filter out by item status based on a system preference to keep everyone happy. I'll add that as a followup now and update the test to correspond. Good catch Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:32:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:32:36 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:32:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:32:39 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 --- Comment #2 from Jonathan Druart --- Created attachment 98351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98351&action=edit Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:33:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:33:11 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |12166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 [Bug 12166] Improve display of hold charges in patron account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:33:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:33:11 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of hold charges in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 [Bug 24516] Column Configuration does not hide Return Date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:33:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:33:53 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Martin Renvoize --- Setting to Failed QA whilst I code the followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 17:45:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 16:45:18 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:05:02 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #73 from Martin Renvoize --- Created attachment 98352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98352&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:13:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:13:23 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:13:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:13:27 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98261|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 98353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98353&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:13:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:13:30 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98348|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 98354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98354&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:23:28 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Patch doesn't apply on 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 18:57:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 17:57:22 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CCL syntax does not allow |Elasticsearch: CCL syntax |for multiple indexes to be |does not allow for multiple |searched at once |indexes to be searched at | |once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:04:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:04:57 +0000 Subject: [Koha-bugs] [Bug 24568] New: Allow selection of multiple authorised values in runtime parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Bug ID: 24568 Summary: Allow selection of multiple authorised values in runtime parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It'd be really useful to be able to run a report and pick multiple values on a runtime parameter. So, given a library with collection codes A,B,C, and D, I'd like to be able to set a runtime parameter that allowed one to pick collections A and C, for example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:05:12 +0000 Subject: [Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:31:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:31:06 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #16 from David Nind --- This now looks good to me! (Firefox + Google Chrome on Ubuntu 18.04) Should Jonathan's patch include the updated CSS file? Originally I had to regenerate the CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:47:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:47:36 +0000 Subject: [Koha-bugs] [Bug 24569] New: Cannot add to basket if it is the only action Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Bug ID: 24569 Summary: Cannot add to basket if it is the only action Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When "Add to basket" is the only action the modal is not created so one cannot add to the basket from booksellers.pl Regression caused by Bug 23031 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:47:45 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 [Bug 23031] Improve UX of buttons on order search page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:47:45 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 [Bug 24569] Cannot add to basket if it is the only action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:50:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:50:00 +0000 Subject: [Koha-bugs] [Bug 24570] New: Cart location showing/duplicated when editing item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24570 Bug ID: 24570 Summary: Cart location showing/duplicated when editing item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using the CART location to show recently returned items, that location displays in field c when editing or duplicating the item. This causes problems with cataloging as it will cause that location to permanently be assigned to that item or duplicated items. Field c should be reflecting the location in the permanent_location field, not the location field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 19:54:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 18:54:01 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #17 from David Nind --- Created attachment 98355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98355&action=edit Bug 24363 - Browse button broken Actually, the patch "breaks" the 'Browse' button in Firefox. Displays fine in Google Chrome. See the attachment with before and after screenshots. It did this as well when originally tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:01:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:01:45 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:01:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:01:48 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98084|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 98356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98356&action=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:03:14 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I have no particular view on whether to display the number of title notes or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:22:37 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:24:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:24:47 +0000 Subject: [Koha-bugs] [Bug 24571] New: Attempting to place multi hold requests on Firefox only places some of them Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 Bug ID: 24571 Summary: Attempting to place multi hold requests on Firefox only places some of them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: agustinmoyano at theke.io Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the staff client do a search that returns 20+ results that can be held Select all Place hold Confirm The api submits ~8 requests, then the page moves to the hold results, but not alll records are held -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:24:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:24:58 +0000 Subject: [Koha-bugs] [Bug 24571] Attempting to place multi hold requests on Firefox only places some of them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 20:43:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 19:43:36 +0000 Subject: [Koha-bugs] [Bug 24571] Attempting to place multi hold requests on Firefox only places some of them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 --- Comment #1 from Nick Clemens --- While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:10:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 20:10:10 +0000 Subject: [Koha-bugs] [Bug 24572] New: Add books from mysql manually Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24572 Bug ID: 24572 Summary: Add books from mysql manually Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: chrs.markx86 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi everyone, I'm trying to bulk import book items into Koha database using a custom script that I have created (in python). Here are some of the mysql commands I use for it: insert into biblio (title, biblionumber, frameworkcode, datecreated) values('{}',{},'{}',NOW())".format(title, biblionumber, biblio_framework) so as to create a new book, and then insert into biblio_metadata (id, biblionumber, format, marcflavour, metadata) values ({},{},'{}','{}','{}')".format(id, biblionumber, "marcxml", "UNIMARC", meta) in order to attach metadata to it. The result is that the sql entries are successfully inserted however I cannot search the book from the basic search at http://192.168.1.12/cgi-bin/koha/opac-main.pl I guess that some more date need to be populated so as to have the books available from the search bar? Could you please point me which tables are required to be populated so as to have books listed in searches like the one I described above? Thank you in advance, C. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 20:31:09 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:31:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 20:31:12 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98351|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 98357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98357&action=edit Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 21:32:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 20:32:28 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Lucas Gass from comment #1) > I cannot reproduce this in master now. I believe the problem was solved by > bz24515. I was able to reproduce on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:22:09 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #6 from Katrin Fischer --- Are we maybe talking about different things? For me 'long overdue' refers to the longoverdue.pl cronjob and the system preferences available for it. Overdues and notice triggers refer to the overdue_notices.pl cronjob. Both jobs have different functionality and different options available to them and are not tied together. I meant instead of changing how the overdue_notices work, enhance the longoverdue process by adding more configuration options in the interface. Maybe a second table like the one already on the overdues page, but instead having the "delay" tabs, the tabs would refer to different itemtypes. Or: - pages for libraries - tabs for delays - An option to add new rules to the notice triggers with an adiditional column for itemtype - A new checkbox at the end to set the long overdue status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:34:09 +0000 Subject: [Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Andrew, I think this is a duplicate to bug 16002 - please unlink if I am mistaken. *** This bug has been marked as a duplicate of bug 16002 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:34:09 +0000 Subject: [Koha-bugs] [Bug 16002] MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Katrin Fischer --- *** Bug 24568 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:35:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:35:31 +0000 Subject: [Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 --- Comment #2 from Andrew Fuerste-Henry --- Ahha! Thanks! That seemed like something that would have already been filed but I couldn't find it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:37:55 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #7 from Andrew Fuerste-Henry --- Hi y'all. The long overdue cronjob and the overdue notice system are two fundamentally disconnected things in Koha. However, it's been standard practice with ByWater partners to use the third overdue notice to alert patrons to the replacement charge generated by the long overdue cron. That already presented some issues based on holidays. As Christopher points out, Bug 20436 moves the potential behavior of the long overdue cron further away from the rather inflexible behavior of the overdue notices. If we want to maintain our practice of using the third overdue notice to alert patrons to the charges generated by the long overdue cronjob, then we need to do some work to make the two processes able to line up better. That would mean teaching the overdues to differ by item type and also teaching the long overdue cron to skip holidays (again, bug 18064. However, the new patron_emailer cron cron could be used to send a notice about items impacted by the long overdue cron without involving the overdues process at all. I'd suggest that approach at least as a short term answer (if not as an alternative to this bug entirely). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 22:42:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 21:42:25 +0000 Subject: [Koha-bugs] [Bug 24572] Add books from mysql manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi, Koha needs a full valid and well-formed MARC record in metadata (depends on version), I think you'd have much more 'fun' with getting records into Koha using the build in import tools like staged marc impord or bulkmarcimport.pl or one of the available APIs. Doing things on SQL level you run at a high risk of missing things or importing things that won't fit your configuration later on - like the mappings in your frameworks and keyword to MARC mappings. And as you need a full MARC record in any case, there is no advantage to using SQL over the other available options. For more help/discussion, please ask on the mailing list - the bug tracker is read only by a few and should be only used for enhancement requests and bugs. koha-devel is read by most of the developers: https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 3 23:32:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 22:32:58 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #78 from Agnes Rivers-Moore --- Maybe this Wiki entry could be updated, or deleted? https://wiki.koha-community.org/wiki/Claimed_Returned_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 00:39:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 23:39:59 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Michelle Carrillo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcarrillo at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 00:47:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Feb 2020 23:47:56 +0000 Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00 released in| | --- Comment #8 from Joy Nelson --- Reverted from 19.11.03 until fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:56:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 06:56:18 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:59:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 06:59:39 +0000 Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 07:59:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 06:59:42 +0000 Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97992|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 98358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98358&action=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:03:27 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #5 from Marcel de Rooy --- (In reply to David Nind from comment #3) > Signed-off-by: David Nind Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:07:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:07:03 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:07:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:07:08 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98189|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 98359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98359&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:07:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:07:12 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98190|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 98360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98360&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:10:13 +0000 Subject: [Koha-bugs] [Bug 24573] New: Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Bug ID: 24573 Summary: Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:10:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:10:59 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #1 from Julian Maurice --- Created attachment 98361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98361&action=edit Bug 24573: Add missing dependencies to PerlDependencies.pm Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation The `max_ver` for Catmandu::Store::ElasticSearch is only informative and is not used anywhere. Koha is not compatible with Catmandu::Store::ElasticSearch 0.9_01 and later versions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:11:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:11:09 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:13:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:13:11 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:13:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:13:14 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98350|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 98362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98362&action=edit Bug 24560: Remove No public list text from OPAC On the OPAC, the dropdown for Lists always includes the heading Public Lists, even if no public lists exist. This is sub-optimal for libraries that want VirtualShelves enabled for private lists but don't want to use public lists. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:13:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:13:20 +0000 Subject: [Koha-bugs] [Bug 24574] New: Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Bug ID: 24574 Summary: Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: rudolfbyker at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page (see Bug #23425 ), it's still not handled gracefully on these pages: /cgi-bin/koha/catalogue/ISBDdetail.pl /cgi-bin/koha/catalogue/MARCdetail.pl Use case: Some of our staff have to update books. They use "cataloging search", enter the barcode, then click the title of the book. This takes them directly to the MARCdetail page. To fix the MARC data, they need to work around the problem by editing the URL and replacing "MARCdetail.pl" with "detail.pl". Since most of our staff is not very technically apt, this is a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:14:04 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Lucas, please make sure that you include a description of the problem and a test plan in your commit messages - I've fixed it this time around :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:16:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:16:29 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:16:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:16:30 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:16:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:16:34 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98191|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 98363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98363&action=edit Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:17:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:17:24 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 --- Comment #4 from Katrin Fischer --- Trusting Owen and Lucas to have tested with OverDrive - small template change, reads well, should have no side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:19:17 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:20:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:20:13 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:20:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:20:17 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98269|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 98364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98364&action=edit Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly preselected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:20:35 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #11 from Katrin Fischer --- Reported this in 2013 - so happy to see it fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:20:50 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|On editing basket group |On editing basket group |delivery place resets to |delivery place resets to |logged in branch |logged in library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:22:37 +0000 Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |23425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 [Bug 23425] Search explodes with "invalid data, cannot decode object" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:22:37 +0000 Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:36:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:36:18 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #74 from Katrin Fischer --- When the option to store the last patron was introduced separately from the normal reading history feature, I was quite happy as it would allow us to keep that information, without necessarily keeping all the history. What libraries often ask for is to know the last person that checked out an item, in case they have missed damage on return (like it can happen in times of self checks). In my opinion, by synching those with no option to not delete both at the same time - we make the StoreLastPatron obsolete. We could always have used the other tables to retrieve the information, but it was added with a new table as a separate thing with the reasoning of avoiding automatic anonymization. See the bug description from the initial feature add (bug 14945): "Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:38:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:38:15 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9011, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14945 --- Comment #75 from Katrin Fischer --- I guess what I was trying to say is that this was designed to fall out of sync with the other tables - so we should not break that use case and allow for separate treatment of both. Added see also the bugs with former discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:38:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:38:15 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23260 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:38:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:38:15 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23260 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 08:39:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 07:39:39 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 anne-cecile.bories at iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories at iepg.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 09:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 08:19:20 +0000 Subject: [Koha-bugs] [Bug 24575] New: Search for locations and collections broken when using ICU Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24575 Bug ID: 24575 Summary: Search for locations and collections broken when using ICU Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de We found a strange bug when using ICU in 17.11 and 18.11 after upgrading from Jessie to Stretch, to be confirmed in later versions: Searching for locations and collections from advanced search in the OPAC/staff client doesn't work using the checkboxes. Redundant quotes are no longer ignored. We found that removing these lines from Search.pm fixes the issue for us: if ( $k !~ /mc-i(tem)?type/ ) { # in case the mc-ccode value has complicating chars like ()'s inside it we wrap in quotes $this_limit =~ tr/"//d; $this_limit = $k.":'".$v."'"; } The patch is backward compatible with Jessie. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:01:08 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #76 from Martin Renvoize --- OK.. at this point I'm totally confused as to why/how this dev request came about... The items_last_borrower table is only populated if you enable the `StoreLastBorrower` system preference and the original idea of that preference was to allow staff to keep a record of last_borrower separately from the checkout history, which may be anonymized, so that staff can refer back to who was the last borrower if they find a book is damaged and as such that can associate that damage with a patron. As such, I'm not sure I understand at all the reasoning behind wanting to remove it at the same time as the rest of the anonymisation and also why you would want to filter on the given item states, given that the idea of the original feature is that you're not likely to have set such a status until after in this case you would have deleted it. Is this actually just a misunderstanding of the original feature in question I wonder? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:07:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:07:35 +0000 Subject: [Koha-bugs] [Bug 24576] New: `StoreLastBorrower` preference is in the wrong tab and is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Bug ID: 24576 Summary: `StoreLastBorrower` preference is in the wrong tab and is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As far as I can make out, the `StoreLastBorrower` preference is available to allow staff to track down who may have returned an item last when said item is found to be damaged or lost even when privacy policy or patron privacy settings are set to anonymize checkout history. As such, I feel this setting would be better placed under the `Circulation`, `Logs` or `Staff client` tabs with a clearer explanation for it's use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:07:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:07:50 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24576 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:07:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:07:50 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23260 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:08:31 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:08:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:08:36 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97004|0 |1 is obsolete| | --- Comment #94 from David Nind --- Created attachment 98365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98365&action=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. To test: 1) Enable patch and update database to apply atomic updates 2) Go to system preferences and set both 'numSearchResultsDropdown' and 'OPACnumSearchResultsDropdown' to 'Show' 3) Set both 'numSearchResults' and 'OPACnumSearchResults' system preferences to 10 so that it will be clear to see how the patch works 4) Do a catalogue search in the intranet using a search term that will bring lots of results 5) The results per page dropdown should show with the selected option as the library default, the value of numSearchResults. The number of results shown on the page should match numSearchResults. 6) Choose a different number of results per page in the dropdown. The search results will automatically refresh 7) Confirm that the correct number of results per page shows 8) Confirm that changing pages does not revert the number of results shown per page to the default value 9) Confirm that you are still able to use other search facets as expected 10) Repeat steps 4-9 on the OPAC (note OPAC uses OPACnumSearchResults as the default value) Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:08:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:08:36 +0000 Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- The invalid data must be fixed. We provided a feedback on the normal view and a check in the search_for_inconsistencies.pl maintenance script. Not sure we should handle such data issues everywhere in our code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:12:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:12:57 +0000 Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 --- Comment #2 from Rudolf Byker --- IMO, software should be stable, regardless of input data. Refusing such data is one thing, but falling over is quite another. Moreover, these data issues occur during normal use when importing MARC records via Z39.50. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:14:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:14:36 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #95 from David Nind --- A couple of things I noticed during testing, not sure whether they are show stoppers or not: - OPAC and staff interface: the number of results resets to the default if you select any of the refine search options/facets - Staff interface: if you choose any option from the sort drop down this also resets the number of search results to the default Otherwise, it works very nicely! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:17:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:17:26 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:25:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:25:06 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98289|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 98366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98366&action=edit Bug 24363: Do not use the two-value syntax for background-position-x It's not supported by chrome and chromium (inspector says "invalidd property value". See also: https://developer.mozilla.org/en-US/docs/Web/CSS/background-position-x section "Browser compatibility" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:27:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:27:24 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #19 from Jonathan Druart --- (In reply to David Nind from comment #16) > Should Jonathan's patch include the updated CSS file? Originally I had to > regenerate the CSS. No, it should not. Resubmitted. (In reply to David Nind from comment #17) > Created attachment 98355 [details] > Bug 24363 - Browse button broken > > Actually, the patch "breaks" the 'Browse' button in Firefox. Displays fine > in Google Chrome. See the attachment with before and after screenshots. > > It did this as well when originally tested. Indeed, I recreate that. Apparently it is caused by: + height: 26px; Owen, could you explain where do come from the @mixin default-input rules? Do we really need them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:45:38 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 --- Comment #1 from Jonathan Druart --- Created attachment 98367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98367&action=edit Bug 24569: (bug 23031 follow-up) Fix "add to basket" link The modal needs to be defined in both cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:50:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:50:35 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:50:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:50:40 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98048|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98368&action=edit Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set HideReserveExpiration system preference to 'Hide' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:52:17 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- Would it make sense to have the "Add order" link a bit more visible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:53:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:53:02 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- I worked through the test plan and I think everything works as expected. But it may require sign-off or review from someone who is more familiar with holds/reserves! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:53:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:53:25 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:53:28 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98367|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 98369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98369&action=edit Bug 24569: (bug 23031 follow-up) Fix "add to basket" link The modal needs to be defined in both cases. Test plan: Repeat test plan from bug 23031 and click on the buttons! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 10:58:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 09:58:21 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #26 from David Nind --- Patches no longer apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:03:30 +0000 Subject: [Koha-bugs] [Bug 23618] Make addition SIP2 fields available to self service to add cost of items checked out to check out slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23618 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:04:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:04:22 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:04:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:04:24 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #157 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:09:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:09:55 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #21 from Jonathan Druart --- Not sure what should be the status of this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:10:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:10:45 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #158 from Martin Renvoize --- Guys, this has been a real stirling effort! Thanks to all involved in pushing it over the finish line, amazing work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:10:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:10:54 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:13:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:13:32 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22021 [Bug 22021] Item status not shown accurately on request.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:13:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:13:32 +0000 Subject: [Koha-bugs] [Bug 22021] Item status not shown accurately on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 [Bug 20708] Withdrawn status should show when placing a request in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:19:17 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:19:20 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 --- Comment #3 from Jonathan Druart --- Created attachment 98370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98370&action=edit Bug 20708: Add Withdrawn status when placing a request in staff Same as bug 22021 for the withdrawn status. 1. Withdraw an item 2. Place an hold on this item Notice the new "withdrawn" status in the information column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:19:29 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:21:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:21:59 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:01 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:03 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:05 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:07 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:08 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:10 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:12 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:14 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_item_level_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:16 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_item_level_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #29 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:18 +0000 Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:20 +0000 Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:21 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:22:23 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:25:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:25:19 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:26:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:26:17 +0000 Subject: [Koha-bugs] [Bug 23622] Add the ability to edit suspension restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23622 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:43:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:43:16 +0000 Subject: [Koha-bugs] [Bug 20359] Auto-Renew notice not able to pull branch information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:47:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:47:25 +0000 Subject: [Koha-bugs] [Bug 10190] Overdue notices based on item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:50:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:50:46 +0000 Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:50:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:50:49 +0000 Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95737|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 98371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98371&action=edit Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:57:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:57:20 +0000 Subject: [Koha-bugs] [Bug 23620] Improve checkin message when suspensions are accrued at check in to include number of 'days' overdue and the resulting no. of suspension days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23620 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:58:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:58:30 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Jonathan Druart --- FAIL Koha/Patrons/Import.pm FAIL forbidden patterns forbidden pattern: tab char (line 297) forbidden pattern: tab char (line 298) forbidden pattern: tab char (line 299) forbidden pattern: tab char (line 300) forbidden pattern: tab char (line 301) forbidden pattern: tab char (line 302) forbidden pattern: tab char (line 303) forbidden pattern: tab char (line 304) forbidden pattern: tab char (line 305) forbidden pattern: tab char (line 306) forbidden pattern: tab char (line 307) forbidden pattern: tab char (line 308) forbidden pattern: tab char (line 309) forbidden pattern: tab char (line 310) forbidden pattern: tab char (line 311) forbidden pattern: tab char (line 312) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt FAIL filters missing_filter at line 120 ( Password is too short for patron with borrowernumber [% e.borrowernumber | html %]. Minimum length is [% e.min_length %], length is [% e.length %]) missing_filter at line 120 ( Password is too short for patron with borrowernumber [% e.borrowernumber | html %]. Minimum length is [% e.min_length %], length is [% e.length %]) OK misc/import_patrons.pl FAIL t/db_dependent/Koha/Patrons/Import.t FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 494) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 11:59:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 10:59:38 +0000 Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun |m |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:05:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:05:04 +0000 Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- If we agree with such naming conventions (ie. create the rs when the DB column is poorly named), I think we should have a global plan, and do it widely. I do not think we should have 1 bug report per rs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:10:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:10:51 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:10:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:10:55 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91922|0 |1 is obsolete| | Attachment #91923|0 |1 is obsolete| | Attachment #91924|0 |1 is obsolete| | Attachment #91925|0 |1 is obsolete| | Attachment #91926|0 |1 is obsolete| | Attachment #91927|0 |1 is obsolete| | Attachment #91928|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 98373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98373&action=edit Bug 19008: More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:10:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:10:59 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #41 from Jonathan Druart --- Created attachment 98374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98374&action=edit Bug 19008: More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:03 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #42 from Jonathan Druart --- Created attachment 98375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98375&action=edit Bug 19008: More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:07 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #43 from Jonathan Druart --- Created attachment 98376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98376&action=edit Bug 19008: More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(timestamp) from old_issues group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:12 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #44 from Jonathan Druart --- Created attachment 98377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98377&action=edit Bug 19008: More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(timestamp) from old_reserves group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:15 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #45 from Jonathan Druart --- Created attachment 98378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98378&action=edit Bug 19008: More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:20 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #46 from Jonathan Druart --- Created attachment 98379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98379&action=edit Bug 19008: More database cleanups - QA followup This patch tries to change the POD as suggested in the QA process. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:11:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:11:24 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #47 from Jonathan Druart --- Created attachment 98380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98380&action=edit Bug 19008: Replace issues with checkouts in print statement Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:26:38 +0000 Subject: [Koha-bugs] [Bug 24571] Attempting to place multi hold requests on Firefox only places some of them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 24410 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:26:38 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Jonathan Druart --- *** Bug 24571 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:27:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:27:43 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #5 from Jonathan Druart --- >From Nick on bug 24571 """ In the staff client do a search that returns 20+ results that can be held Select all Place hold Confirm The api submits ~8 requests, then the page moves to the hold results, but not alll records are held While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:30:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:30:26 +0000 Subject: [Koha-bugs] [Bug 24577] New: API schema merging breaks with older versions of JSON module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24577 Bug ID: 24577 Summary: API schema merging breaks with older versions of JSON module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com I discovered this while deploying a plugin that defines an API route. If the installation is using a version of the JSON module < 2.90, schema merging doesn't work correctly, these are the sort of errors that were being generated during validation of the merged schema: { 'path' => '/paths/~1contrib~1ill_availability_unpaywall~1ill_availability_search_unpaywall/get/parameters/0', 'message' => 'oneOf failed: oneOf failed: Properties not allowed: type. oneOf failed: (Not in enum list: header.. Expected boolean - got JSON::XS::Boolean.) (Not in enum list: formData.. Expected boolean - got JSON::XS::Boolean.) Expected boolean - got JSON::XS::Boolean. (Expected boolean - got JSON::XS::Boolean.. Not in enum list: path.) Properties not allowed: name, required, type, description, in.' } Pretty nonsensical and a nightmare to try and get to the bottom of. I was seeing this using JSON 2.61. I believe the change that was implemented in 2.90 that we're dependent on, is the top one listed here: https://metacpan.org/changes/release/MAKAMAKA/JSON-2.90 Koha is currently specifying 2.07 as the required version. I'm wondering if it is worth moving this to 2.90. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:50:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:50:15 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:50:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:50:19 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97972|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 98381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98381&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 12:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 11:55:04 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Jonathan Druart --- Switching back to NQA as the QA question has been answered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:07:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:07:33 +0000 Subject: [Koha-bugs] [Bug 23616] Private repeatable note field needed in Serials Subscription Record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23616 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:08:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:08:08 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #6 from Nick Clemens --- Does it matter that this is not idempotent? You can have repeated values in the authorised_values table with no complaints - should there be a key on id,category,authorised_value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:15:45 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:15:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:15:48 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #26 from Nick Clemens --- Created attachment 98382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98382&action=edit Bug 23473: (follow-up) Fix QA complaints (tabs, filters, Dumper) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:23:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:23:25 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94871|0 |1 is obsolete| | --- Comment #79 from Julian Maurice --- Created attachment 98383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98383&action=edit Bug 15261: Check if checkout/reserve request overlaps existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. - A user places a hold from opac whose requested period overlaps with an existing reserve period => prevent reserve - A librarian places a hold from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) - A librarian makes a checkout from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): - Place a hold on title (which has only one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are warned about an existing reserve 2 (staff side): - Place a hold on title (which has more than one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): - Place a hold on item level with start date and expiration date. - Place another hold on item level with period overlaping this reserve. - Check you are warned about an existing reserve. 4 (opac side): - Do the same than for staff side. Instead of a warn, reserve is prevented. 5: - Place a hold on title (which has only one items) level with start date and expiration date. - Try to checkout the unique item from this title with period overlaping the reserve period. - Check you are warned about an existing reserve 6: - Place a hold on title (which has more than one items) level with start date and expiration date. - Checkout an item from this title with period overlaping the reserve period. - Check you are NOT warned about an existing reserve. 7: - Place a hold on item level with start date and expiration date. - Checkout this item period overlaping the reserve period. - Check you are warned about an existing reserve 8: - Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}), - Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30 days}), - Check that you cannot renew the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:24:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:24:02 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #80 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:37:49 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:37:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:37:52 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98369|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 98384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98384&action=edit Bug 24569: (bug 23031 follow-up) Fix "add to basket" link The modal needs to be defined in both cases. Test plan: Repeat test plan from bug 23031 and click on the buttons! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:37:55 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 --- Comment #4 from Nick Clemens --- Created attachment 98385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98385&action=edit Bug 24569: (QA follow-up) Fix closing tag Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:38:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:38:11 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Nick Clemens --- Small fix, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:40:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:40:55 +0000 Subject: [Koha-bugs] [Bug 24577] API schema merging breaks with older versions of JSON module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- So.. we already require Mojolicious.. so I'd be tempted to switch to Mojo::JSON.. I believe it's the fastest pure perl implementation of JSON to date and it will automatically use Cpanel::JSON::XS when found to go faster still. It's also not introducing a new dependency, but rather using one we're already importing. Thoughts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:44:28 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:44:32 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98370|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 98386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98386&action=edit Bug 20708: Add Withdrawn status when placing a request in staff Same as bug 22021 for the withdrawn status. 1. Withdraw an item 2. Place an hold on this item Notice the new "withdrawn" status in the information column Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 13:44:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 12:44:51 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Nick Clemens --- Trivial patch, works well, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:08:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:08:43 +0000 Subject: [Koha-bugs] [Bug 24558] Catching old holds on check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24558 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:09:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:09:09 +0000 Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:09:58 +0000 Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items that have holds but have not yet been captured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:12:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:12:06 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:12:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:12:50 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #1 from Andrew Fuerste-Henry --- Agreed this is a pesky inconsistency. Easy enough to work around, but an annoying little trap for new users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:15:52 +0000 Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > If we agree with such naming conventions (ie. create the rs when the DB > column is poorly named), I think we should have a global plan, and do it > widely. I do not think we should have 1 bug report per rs. I started adding them as needed on the bugs that will actually take advantage of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:15:56 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:16:21 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #20 from Owen Leonard --- > > Actually, the patch "breaks" the 'Browse' button in Firefox. The difference is almost imperceptible in Firefox on Windows, so I'm glad you caught it. > Owen, could you explain where do come from the @mixin default-input rules? > Do we really need them? We don't *need* them but using a @mixin lets us define the rules once and apply them to more than one element. I don't think the mixin is a problem if we add "height:unset" to input[type='file']. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:16:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:16:31 +0000 Subject: [Koha-bugs] [Bug 24578] New: Add wording to Cart Feature on the OPAC indicating this is temporary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24578 Bug ID: 24578 Summary: Add wording to Cart Feature on the OPAC indicating this is temporary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The purpose of the Cart feature is a place to temporary store items that a patron may want to look at without logging into their account on the OPAC. However, there is no wording to indicate that this is a temporary cart - and this is confusing to patrons. Wording such as "Placing items in a cart is temporary- once you log out of the OPAC or close the browser you lose the items in your cart" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:16:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:16:44 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #21 from Owen Leonard --- Created attachment 98387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98387&action=edit Bug 24363: (follow-up) Remove height from input[type='file'] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:17:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:17:50 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:19:01 +0000 Subject: [Koha-bugs] [Bug 24579] New: Add the ability to email the Cart contents without Logging into Account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24579 Bug ID: 24579 Summary: Add the ability to email the Cart contents without Logging into Account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org As the cart is a temporary location, a user is limited to what this feature is capable of. If they close the browser and have items in the cart, they will go away. I would love to give the patrons the ability to send the cart to an email without having to log in. The advantage of the cart is to store items without logging in, but the cart has such a short shelf life (pun ! ) and would like to give more cart possibilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:20:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:20:01 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #7 from Martin Renvoize --- Created attachment 98388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98388&action=edit Bug 24338: (QA follow-up) Make update idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:20:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:20:19 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #8 from Martin Renvoize --- Good catch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:23:08 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- CC| |kelly at bywatersolutions.com Status|RESOLVED |REOPENED --- Comment #12 from Kelly McElligott --- I want to open this back up, please. I believe that this is worth talking about again. A system preference would be optimal to allow libraries to turn on/off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:23:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:23:20 +0000 Subject: [Koha-bugs] [Bug 24578] Add wording to Cart Feature on the OPAC indicating this is temporary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24578 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:31:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:31:29 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98063|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 98389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98389&action=edit Bug 21466: Keep all AVs for a given framework There was a major (and silly) issue in the previous version, only one AV was kept as we erased the hash value at the end of each iteration: $invalid_locations_per_framework->{$framework->frameworkcode } = { items => $items, av_category => $mss->authorised_value, kohafield => $kohafield }; Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:31:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:31:51 +0000 Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:32:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:32:17 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- OK, Tested thoroughly here.. looks good... Thanks Jonathan, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:37:14 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #4 from Andrew Isherwood --- This is a great idea Magnus, I somehow missed this bug when it first appeared. I'm not sure of the value of cleaning up the codes to be tested for. Currently we have no restriction of status code formats, so the clean up could actually cause matching results to not be found. Happy to test and sign this off, it'll be a great addition, a few of our customers are wanting something like this! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:37:20 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:05 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:07 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #48 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:09 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:11 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:13 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:15 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 --- Comment #19 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:17 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:39:19 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:44:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:44:24 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #5 from Magnus Enger --- (In reply to Andrew Isherwood from comment #4) > This is a great idea Magnus, I somehow missed this bug when it first > appeared. > > I'm not sure of the value of cleaning up the codes to be tested for. > Currently we have no restriction of status code formats, so the clean up > could actually cause matching results to not be found. So do you think I should get rid of the cleanup? > Happy to test and sign this off, it'll be a great addition, a few of our > customers are wanting something like this! :) Yay! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:45:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:45:36 +0000 Subject: [Koha-bugs] [Bug 24577] API schema merging breaks with older versions of JSON module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24577 --- Comment #2 from Andrew Isherwood --- Sounds like a possibility. Though I think we'd have to audit all 172 uses of the JSON module and ensure that a) Mojo::JSON fulfils all requirements (JSON does a lot) and b) has an straightforward migration path -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:48:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:48:19 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #6 from Andrew Isherwood --- (In reply to Magnus Enger from comment #5) > (In reply to Andrew Isherwood from comment #4) > So do you think I should get rid of the cleanup? I'm just not sure what it gives us other than potentially breaking the matching. I think we have to trust users to be able to enter the status codes without messing them up. Of course, I could be entirely missing your intention with the cleanup! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:48:31 +0000 Subject: [Koha-bugs] [Bug 24579] Add the ability to email the Cart contents without Logging into Account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24579 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I remember poking at this once before, but cannot find the existing bug. Wherever it is, that bug raises the concern that emailing the cart without logging in opens the possibility of koha being used to send bot spam. That's a solvable problem, but a complication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:53:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:53:21 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #7 from Magnus Enger --- (In reply to Andrew Isherwood from comment #6) > I'm just not sure what it gives us other than potentially breaking the > matching. I think we have to trust users to be able to enter the status > codes without messing them up. Of course, I could be entirely missing your > intention with the cleanup! I'm not sure myself, any longer... I'll do a revised patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:58:41 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96222|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 98390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98390&action=edit Bug 23391 - Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 14:59:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 13:59:36 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #9 from Magnus Enger --- New version of the patch is without the cleanup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:00:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:00:09 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:00:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:00:09 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24338 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:07:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:07:07 +0000 Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from changing location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:12:07 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:12:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:12:10 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98390|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood --- Created attachment 98391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98391&action=edit Bug 23391 - Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:12:51 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #21 from Martin Renvoize --- (In reply to Jonathan Druart from comment #17) > (In reply to Martin Renvoize from comment #16) > > I've attempted a rebase of the patch.. it's not an area I'm all that > > familiar with so testing is required. > > Reading previous comments it seems that this patch will introduce > regressions. I think there are regressions for specific versions of zebra.. but I also felt that relevance issues outweighted the regressions introduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:14:58 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #22 from Martin Renvoize --- De-escalating this one.. it's been around for 6 years and hasn't really recieved the attention a critical should.. I personally feel at the time it was critical and it's still a nice to fix.. but as we're moving toward elastic search and possible deprecating QueryParser entirely I'm not sure how to progress this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:05 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #5 from Jonathan Druart --- Created attachment 98392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98392&action=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned - Check an item out - Create a manual invoice LOST for the checked in item - Pay the fine (Make a payment> Pay > Confirm) - Renew the item => Item is checked in (NOT EXPECTED) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:08 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #6 from Jonathan Druart --- Created attachment 98393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98393&action=edit Bug 24474: A try This does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:46 +0000 Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:51 +0000 Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98038|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 98394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98394&action=edit Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:56 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:17:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:17:59 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #2 from Nick Clemens --- Created attachment 98395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98395&action=edit Bug 22302: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:18:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:18:02 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #3 from Nick Clemens --- Created attachment 98396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98396&action=edit Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:18:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:18:35 +0000 Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Code scans well and does whats expected.. simple improvement and passes qa scripts.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:19:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:19:45 +0000 Subject: [Koha-bugs] [Bug 18155] Add useful classes to the rows of checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18155 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 15:19:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 14:19:45 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- I gave a try to this, wrote the test then try to fix it. But my understanding of the code leads me to abandon. I do not understand why there are 3 calls to ReturnLostItem: Koha/Account.pm: C4::Circulation::ReturnLostItem( $self->{patron_id}, $fine->itemnumber ) unless $checkout; Koha/Account.pm: C4::Circulation::ReturnLostItem( $self->{patron_id}, $fine->itemnumber ) unless $checkout; Koha/Account/Line.pm: C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber ); That seems wrong to me. So I guess my test will not cover all the cases. Hope it could help as a start anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:00:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:00:39 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #159 from Jonathan Druart --- Created attachment 98407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98407&action=edit Bug 18936: Display 'Unlimited' for Holds allowed (total) holds_per_day and reservesallowed are set to unlimited in the rules inserted by misc4dev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:00:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:00:45 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #160 from Jonathan Druart --- Created attachment 98408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98408&action=edit Bug 18936: Fix selenium/administration_tasks.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:03:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:03:44 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:05:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:05:47 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #161 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:06:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:06:19 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #17 from Jonathan Druart --- Created attachment 98409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98409&action=edit Bug 23533: Remove spaces after/before the open/close parenthesis t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:09:51 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #18 from Martin Renvoize --- Followup pushed, thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:32:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:32:00 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #4 from Andrew Fuerste-Henry --- Test plan: - create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) - connect an item type to your category - go to the advanced search page on the OPAC - see a radio button with no label - apply patch - reload OPAC adv search page - radio button has a label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:42:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:42:23 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98395|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 98410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98410&action=edit Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:42:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:42:25 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98396|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes --- Created attachment 98411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98411&action=edit Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:42:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:42:44 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #34 from Benjamin Daeuber --- (In reply to Christopher Brannon from comment #31) > (In reply to Jonathan Druart from comment #30) > > Christopher, could you add your stamp on Kyle's follow-up? > > I tested master without the patch, and the hold is routed properly. > Something has changed. I don't know if it is Owen's work on the modal, but > it seems to be working properly without the patch. Can anyone confirm? The problem is still occurring on master for me. However, I am getting the same error as Lisette when testing the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 16:44:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 15:44:36 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Andrew Fuerste-Henry --- Amended test plan: 1 create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) 2 connect an item type to your category 3 go to the advanced search page on the OPAC 4 see a radio button with no label 5 apply patch 6 reload OPAC adv search page 7 radio button has a label 8 go back to authorized values and add a Description (OPAC) that does not match Description 9 Reload OPAC and see that your radio button shows Description (OPAC) Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 16:16:18 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #8 from Martin Renvoize --- (In reply to Aleisha Amohia from comment #0) > This was a bug introduced by Bug 22982. > > "Hey all, this patch is causing problems for some of our libraries because > it's been assumed that lost items with no attached charge should > automatically be returned. I don't understand what you mean by this.. the code in bug 22982 only applies to LOST charges.. I'm not sure I can see how items are being returned when no lost item charge is attached in the first place? > This is not always the desired behaviour - we have one case where the > library wants to keep lost items on a patron's record, and another case > where a checked out lost item will be renewed, but the amount outstanding is > zero, so the item gets returned. So, this is where there are LOST charges being applied right? Instead of automatically returning the item on lost charge payment we want to allow for configurable state changes instead.. or am I misunderstanding the problem/request? > > These are edge cases, but the assumptions in this patch do not consider > them, and are causing problems. Is there a workaround? Or perhaps a better > way of doing this patch that can allow for the cases of 'renewing a lost > item' or 'wanting to keep a lost item on the checkouts record'? A solution > that avoids doing circulation actions in the accounts modules as this patch > does would be ideal." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:20:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 16:20:22 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #9 from Martin Renvoize --- (In reply to Jonathan Druart from comment #7) > I gave a try to this, wrote the test then try to fix it. > > But my understanding of the code leads me to abandon. I do not understand > why there are 3 calls to ReturnLostItem: > > Koha/Account.pm: C4::Circulation::ReturnLostItem( > $self->{patron_id}, $fine->itemnumber ) unless $checkout; > Koha/Account.pm: C4::Circulation::ReturnLostItem( > $self->{patron_id}, $fine->itemnumber ) unless $checkout; > Koha/Account/Line.pm: C4::Circulation::ReturnLostItem( > $self->borrowernumber, $debit->itemnumber ); > > That seems wrong to me. > > So I guess my test will not cover all the cases. Hope it could help as a > start anyway. Not sure I understand what you tried here Jonathan.. looking like you're simply adding a second check to see if the item is still checked out before returning it.. I think we need clarification on the requested behaviour before continuing here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:24:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 16:24:22 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Websites, Mailing Lists, |Web services |etc | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 17:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 16:25:45 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 18:45:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 17:45:49 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #17 from Katrin Fischer --- (In reply to Jonathan Druart from comment #16) > Would it make sense to have the "Add order" link a bit more visible? As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:33:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:33:07 +0000 Subject: [Koha-bugs] [Bug 24580] New: Allow patron_emailer or parallel structure to generate custom print notices from report output Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580 Bug ID: 24580 Summary: Allow patron_emailer or parallel structure to generate custom print notices from report output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 16149 adds the ability to combine report results with a custom notice to generate emails. Many libraries do not reliably have email addresses for their patrons and could use a method to generate print notices. This could be a failover from email to print (as overdues do) or a separate cron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:33:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:33:28 +0000 Subject: [Koha-bugs] [Bug 24580] Allow patron_emailer or parallel structure to generate custom print notices from report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |lucas at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:51:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:51:13 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #23 from Katrin Fischer --- (In reply to Martin Renvoize from comment #22) > De-escalating this one.. it's been around for 6 years and hasn't really > recieved the attention a critical should.. I personally feel at the time it > was critical and it's still a nice to fix.. but as we're moving toward > elastic search and possible deprecating QueryParser entirely I'm not sure > how to progress this bug. I'd argue it's still a very bad bug and Elastic not ready yet for wide use yet (thinking of libraries without IT experts and support especially). As it breaks things when NOT using QueryParser, there is no link to that. It hurts a lot of our libraries and is very hard to figure out - I think we shoudl really fix it. The sole reason it was not fixed yet is probably people are scared of Search.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:55:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:55:28 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #10 from Katrin Fischer --- >From what I understand: - the LOST charge is applied, but the library decided to not auto-return the item (config wise) - then renewing the item returns it I'll have to give this a go in testing, but I think we need to verify and try stuff here. Would be great to get a step by step by Aleisha if possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:56:44 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #11 from Katrin Fischer --- .. or maybe they just don't charge a fee. (no lost charge). I really wish our lost handling options were less confusing and more in one spot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 19:59:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 18:59:12 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #12 from Katrin Fischer --- WhenLostChargeReplacementFee DefaultLongOverdueChargeValue MarkLostItemsAsReturned Are the ones I am thinking of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 20:04:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 19:04:09 +0000 Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 --- Comment #7 from Magnus Enger --- What it is the right approach here? 1. Create the directory indicated by --output if it does not exist 2. Check if the directory indicated by --output exists, and exit if it does not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 20:22:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 19:22:06 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:00:34 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #13 from Chris Cormack --- Thats right, you have an item that is marked lost. But the library wants that to stay on the persons card. Not be removed, so it is still out to them. Then if you renew that item, * then that makes it no longer lost - correct * removes the charge - correct - Now the code goes on, there is a paid charge for lost, I will return it - not correct IE when you renew a lost item, the code in the accounts now returns it, because it has a paid for charge. I feel like having circulation actions inside the accounts module is a bad thing anyway, but certainly creates unexpected (and wrong) behaviour in this case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:17:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:17:14 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #14 from Martin Renvoize --- Thanks for the clarifications guys.. it's a real action at a distance issue I see.. hmm, I agree it would be best to strip out the behaviour from the accounts code and push it up a level into the controllers really. I'll have a go at that when I'm fresh tomorrow.. unless anyone else wants to give it a punt.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:20:50 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:20:54 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98381|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 98412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98412&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Test plan: 1) Check the values shown for the PAYMENT_TYPE authorized value category (Home > Administration > Basic parameters > Authorized values) 2) There should be no CASH authorized value 3) Apply the patch 4) Run the database update (perl installer/data/mysql/updatedatabase.pl) 5) Refresh the PAYMENT_TYPE authorized value page 6) A CASH authorized value should now be one of the values 7) Sign-off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:20:58 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98388|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 98413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98413&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:28:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:28:02 +0000 Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 21:47:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 20:47:09 +0000 Subject: [Koha-bugs] [Bug 24581] New: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581 Bug ID: 24581 Summary: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: HP OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: rajofigueroa at yahoo.com QA Contact: testopia at bugs.koha-community.org In upgrading Koha I.L.S. from koha 19.05 to koha 19.10.2. I installe koha 19.10 en my laptop envy hp, in Debian 10 buster, and everything was ok. But whan I bring tried to change the new database with the old one , it give me that error mesage DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 An in the OPAC : Software error: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.reset_password' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 269 Please some hep needed. Thanks a lot Lic. Ramon Figueroa, from caracas, Venezuea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:16:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 21:16:00 +0000 Subject: [Koha-bugs] [Bug 24582] New: Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Bug ID: 24582 Summary: Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When cloning circ rules to a branch, Koha clones the issuingrules table but not the circulation_rules table. That means all the created rules have Unlimited for number of checkouts and onsite checkouts allowed. That's not great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 21:16:25 +0000 Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:42:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 21:42:47 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #77 from George Williams (NEKLS) --- NEKLS is sponsoring the development of this cronjob. Currently we have StoreLastBorrower turned on because we want the last borrower information stored if patron privacy is anonymized. We also have a cron running that prunes old_issues more than 400 days old so that all patron data is effectively anonymized after about 13 months. But we are not pruning items_last_borrower because staff at many of our libraries want the last borrower information saved on the item record if the item was lost. This means that we are currently anonymizing patron data in old_issues after it's 400 days old and never anonymizing that same data in items_last_borrower for the sake of the libraries that want that data saved for lost items. So for us the point of this cronjob is to prune items_last_borrower once the data is more than 400 days old which is in line with the other pruning we're already doing but it will make an exception if the item has a lost status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 22:58:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 21:58:36 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #78 from Katrin Fischer --- Hi George, I think an option to clean it is not in question, I just think we should not tie it to the same 'switch' - so libraries can make the decision to delete both tables after a different number of days. This change as proposed currently would not only affect the cronjob. The method changed is used in different areas: - batch_anonymise.pl cronjob - When using the batch anonymize feature tool in the staff interface - When a patron decides to delete their reading history from the OPAC (OpacPrivacy etc.) So if I know I just returned a damaged book via the self check... I could delete my reading history from the OPAC. Info might still be retrievable somewhere, but I feel StoreLastPatron should be covering that use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 23:29:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 22:29:59 +0000 Subject: [Koha-bugs] [Bug 24583] New: Rewrite mandatory installation files to YAML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bug ID: 24583 Summary: Rewrite mandatory installation files to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr A complete rewrite of mandatary instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 4 23:30:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 22:30:37 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC|frederic at tamil.fr | Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:28:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:28:40 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io --- Comment #6 from Agustín Moyano --- (In reply to Jonathan Druart from comment #5) > From Nick on bug 24571 > > """ > In the staff client do a search that returns 20+ results that can be held > > Select all > > Place hold > > Confirm > > The api submits ~8 requests, then the page moves to the hold results, but > not alll records are held > > > While this does work in Chrome, there is no feedback as to what is happening > - the submit button is not disabled. Testing with 200 holds there is a lot > of waiting with no feedback > """ I'm thinking.. is there any RFC for bulk processing endpoints?.. maybe we can create an endpoint that does multiholds. What do You think Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:49:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:49:08 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98414&action=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:49:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:49:11 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98415&action=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:49:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:49:14 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 98416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98416&action=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:49:18 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98417&action=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:49:21 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 98418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98418&action=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:53:46 +0000 Subject: [Koha-bugs] [Bug 24584] New: Rewrite optional installation files to YAML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bug ID: 24584 Summary: Rewrite optional installation files to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr A complete rewrite of optional instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 00:54:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Feb 2020 23:54:08 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | CC|frederic at tamil.fr | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 01:33:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 00:33:07 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #24 from David Cook --- (In reply to Katrin Fischer from comment #23) > I'd argue it's still a very bad bug and Elastic not ready yet for wide use > yet (thinking of libraries without IT experts and support especially). As it > breaks things when NOT using QueryParser, there is no link to that. It hurts > a lot of our libraries and is very hard to figure out - I think we shoudl > really fix it. The sole reason it was not fixed yet is probably people are > scared of Search.pm. I'm not scared but there's no time/money for me to work on fixing it :/. In my opinion, Search.pm is really really bad, and fixing it would be a very time-consuming exercise. (I suppose part of the time-consuming part would be finding a lack of people wiling to test/QA because of fear of Search.pm though that's true...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:02:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:02:44 +0000 Subject: [Koha-bugs] [Bug 24585] New: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Bug ID: 24585 Summary: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When looking a specific patrons suggestions from pat_purchase_suggestions.tt it would be nice if there were columns for 'Managed on' date and 'Suggested on' date which could sort by these dates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:14:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:14:41 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98090|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes --- Created attachment 98419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98419&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:14:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:14:44 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98091|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 98420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98420&action=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:15:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:15:04 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:15:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:15:07 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #1 from Lucas Gass --- Created attachment 98421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98421&action=edit Bug 24585: Add suggested on/managed on columns This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:15:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:15:22 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 02:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 01:15:24 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #24 from Andrew Fuerste-Henry --- Re-checked and re-signed-off. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 03:43:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 02:43:22 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:23:33 +0000 Subject: [Koha-bugs] [Bug 24586] New: Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 Bug ID: 24586 Summary: Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:28:21 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #1 from David Cook --- QueryParser takes this as input: (authtype:UNIF_TITLE) match-heading:"McGraw-Hill \\"Demystified\\" series" #AuthidAsc And it outputs this: @or @attr 1=Local-Number @attr 7=1 0 @and @and @attr 1=authtype @attr 5=100 @attr 4=6 "UNIF_TITLE" @and @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Demystified\\\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "series\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "McGraw-Hill \\" Which causes ZOOM::Query::PQF to throw a fatal error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 1=Local-Number @attr 7=1 0 @and @and @attr 1=authtype @attr 5=100 @attr 4=6 "UNIF_TITLE" @and @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "Demystified\\\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "series\\"" @attr 1=Match-heading @attr 4=1 @attr 5=100 @attr 6=3 "McGraw-Hill \\"") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:37:36 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:37:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:37:39 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60366|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 98422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98422&action=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:55:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:55:42 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #2 from David Cook --- Created attachment 98423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98423&action=edit Bug 24586: Gracefully fail authority lookup if PQF query invalid If Koha's query building has produced an invalid PQF query, don't throw a fatal error. Instead, trap the error, warn, and then skip the authority lookup for that field. Test Plan: I don't really have a good test plan at the moment. Enable AutoCreateAuthorities and BiblioAddsAuthorities maybe, and then try to do a search for 830$a with a value of the following: Bad "query" value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 05:56:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 04:56:53 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #3 from David Cook --- I've included a patch that I'm temporarily using as a workaround, but silently failing isn't perfect either. We should probably give the user a report after saving the record saying what happened with the authority linking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:05:08 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Lucas, can you please update your patch to include a bug description and test plan? I think you might have done it in the git bz attach step - but that doesn't change the patch file itself and it's still empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:05:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:05:55 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #3 from Katrin Fischer --- I'll usually just do it - but I noticed it happens quite often now, so trying to get to the root of the issue :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:07:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:07:30 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12742 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 [Bug 12742] Omnibus: QueryParser -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:07:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:07:30 +0000 Subject: [Koha-bugs] [Bug 12742] Omnibus: QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:08:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:08:05 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #4 from Katrin Fischer --- I've added the omnibus bug for QueryParser - there is a ton of issues with it basically. I think we might deprecate it soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:38:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:38:10 +0000 Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:39:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:39:30 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98383|0 |1 is obsolete| | --- Comment #81 from Julian Maurice --- Created attachment 98424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98424&action=edit Bug 15261: Check if checkout/reserve request overlaps existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. - A user places a hold from opac whose requested period overlaps with an existing reserve period => prevent reserve - A librarian places a hold from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) - A librarian makes a checkout from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): - Place a hold on title (which has only one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are warned about an existing reserve 2 (staff side): - Place a hold on title (which has more than one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): - Place a hold on item level with start date and expiration date. - Place another hold on item level with period overlaping this reserve. - Check you are warned about an existing reserve. 4 (opac side): - Do the same than for staff side. Instead of a warn, reserve is prevented. 5: - Place a hold on title (which has only one items) level with start date and expiration date. - Try to checkout the unique item from this title with period overlaping the reserve period. - Check you are warned about an existing reserve 6: - Place a hold on title (which has more than one items) level with start date and expiration date. - Checkout an item from this title with period overlaping the reserve period. - Check you are NOT warned about an existing reserve. 7: - Place a hold on item level with start date and expiration date. - Checkout this item period overlaping the reserve period. - Check you are warned about an existing reserve 8: - Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}), - Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30 days}), - Check that you cannot renew the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:39:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:39:54 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:43:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:43:27 +0000 Subject: [Koha-bugs] [Bug 24587] New: reserve/placerequest.pl is not used anymore and should be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Bug ID: 24587 Summary: reserve/placerequest.pl is not used anymore and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 19618 Bug 19618 removed the last place where reserve/placerequest.pl was used and forgot to remove it. It should be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:43:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:43:27 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:45:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:45:09 +0000 Subject: [Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 --- Comment #1 from Julian Maurice --- Created attachment 98425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98425&action=edit Bug 24587: Remove unused script reserve/placerequest.pl Bug 19618 removed the last place where reserve/placerequest.pl was used and forgot to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:45:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:45:18 +0000 Subject: [Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:55:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:55:20 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:55:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:55:23 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97466|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 98426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98426&action=edit Bug 24363: Datepicker calendar is not sexy on additem.pl This patch is essentially an alternative to Bug 24181. Instead of trying to make the datepicker inputs match default fields, it defines a default style for text inputs, selects, and textareas. This new default style borrows some from Bootstrap's input styling and some from the Select2 plugin's style. This makes forms like the one on the add item page have unified styling for all fields. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test as many pages as you can to look for consistent styling of form fields: Patron entry, cataloging (basic and advanced), reports, batch item modification, system preferences, etc. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:55:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:55:27 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98366|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 98427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98427&action=edit Bug 24363: Do not use the two-value syntax for background-position-x It's not supported by chrome and chromium (inspector says "invalidd property value". See also: https://developer.mozilla.org/en-US/docs/Web/CSS/background-position-x section "Browser compatibility" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:55:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:55:30 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98387|0 |1 is obsolete| | --- Comment #24 from David Nind --- Created attachment 98428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98428&action=edit Bug 24363: (follow-up) Remove height from input[type='file'] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 08:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 07:59:08 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #25 from David Nind --- Magic! Have tested in Google Chrome and Firefox Developer Edition on Ubuntu 18.04. Everything looks much better - date pickers and upload buttons. While I didn't check all the screens with data pickers, I checked a fair number of them and they all look consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:03:04 +0000 Subject: [Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24410 --- Comment #2 from Julian Maurice --- ... and it looks like bug 24410 restores the use of placerequest.pl, so maybe we should wait for the resolution of 24410 before deciding to delete it or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:03:04 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24587 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:07:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:07:11 +0000 Subject: [Koha-bugs] [Bug 24588] New: Prevent e-mails from Koha to be flagged as spam Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Bug ID: 24588 Summary: Prevent e-mails from Koha to be flagged as spam Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: ulrich.kleiber at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Set the e-mail headers Mailer-X und MessageID by Koha, to gain a better positive score from the spam filter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:08:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:08:38 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:19:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:19:35 +0000 Subject: [Koha-bugs] [Bug 24589] New: Add plugin hook addbiblio_check_record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 Bug ID: 24589 Summary: Add plugin hook addbiblio_check_record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Adds a new plugin hook, addbiblio_check_record, to addbiblio.pl. When saving a record, the hook is called with the MARC record as a parameter. If the hook returns anything, the return values are shown to the user, and saving the record is prevented. This can be used to create plugins that eg. check or modify the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:19:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:19:52 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #25 from Jonathan Druart --- (In reply to David Cook from comment #24) > (In reply to Katrin Fischer from comment #23) > > I'd argue it's still a very bad bug and Elastic not ready yet for wide use > > yet (thinking of libraries without IT experts and support especially). As it > > breaks things when NOT using QueryParser, there is no link to that. It hurts > > a lot of our libraries and is very hard to figure out - I think we shoudl > > really fix it. The sole reason it was not fixed yet is probably people are > > scared of Search.pm. > > I'm not scared but there's no time/money for me to work on fixing it :/. > > In my opinion, Search.pm is really really bad, and fixing it would be a very > time-consuming exercise. (I suppose part of the time-consuming part would be > finding a lack of people wiling to test/QA because of fear of Search.pm > though that's true...) What about the patch? Was not it suppose to fix the issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:20:58 +0000 Subject: [Koha-bugs] [Bug 24587] reserve/placerequest.pl is not used anymore and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 24410 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:20:58 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Jonathan Druart --- *** Bug 24587 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:21:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:21:32 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | --- Comment #1 from paxed --- Created attachment 98429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98429&action=edit Add plugin hook addbiblio_check_record Adds a new plugin hook, addbiblio_check_record, to addbiblio.pl. When saving a record, the hook is called with the MARC record as a parameter. If the hook returns anything, the return values are shown to the user, and saving the record is prevented. This can be used to create plugins that eg. check or modify the record. Advanced editor has not been changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:22:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:22:56 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|tomascohen at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Agustin, as this affect stable and that the bug is now confirmed I think we should move this patch forward ASAP then discuss later how we can use the endpoint for multi holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:30:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:30:34 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #26 from Jonathan Druart --- I think there is still a problem with the inputs (radio now): Before: https://snipboard.io/plg4Ye.jpg After : https://snipboard.io/KHaCVI.jpg Alignment and padding/margin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:30:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:30:59 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:38:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:38:45 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Jonathan Druart --- Agustin, it seems that updated_on should be set to time_queued when the column is added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:41:28 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #1 from Ulrich Kleiber --- Created attachment 98430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98430&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:45:14 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #26 from Jonathan Druart --- Created attachment 98431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98431&action=edit Bug 23673: Avoid sleep in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:50:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:50:19 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:50:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:50:23 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98419|0 |1 is obsolete| | Attachment #98420|0 |1 is obsolete| | Attachment #98431|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 98432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98432&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:50:28 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #28 from Jonathan Druart --- Created attachment 98433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98433&action=edit Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:50:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:50:32 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #29 from Jonathan Druart --- Created attachment 98434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98434&action=edit Bug 23673: Avoid sleep in tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:50:37 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #30 from Jonathan Druart --- Created attachment 98435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98435&action=edit Bug 23673: Set updated_on=time_queued on DB update Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:51:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:51:14 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #31 from Jonathan Druart --- Not sure about the latch patch. Martin, please wait for Agustin approval before pushing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:57:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:57:46 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98393|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Comment on attachment 98393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98393 Bug 24474: A try That really did not make sense! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 09:59:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 08:59:23 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #16 from Jonathan Druart --- (In reply to Chris Cormack from comment #13) > Then if you renew that item, > * then that makes it no longer lost - correct > * removes the charge - correct > - Now the code goes on, there is a paid charge for lost, I will return it > - not correct Martin, I think these steps are what my tests are doing and that they could be use to prove that a fix is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:05:35 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #17) > (In reply to Jonathan Druart from comment #16) > > Would it make sense to have the "Add order" link a bit more visible? > > As you have to start from the basket I don't mind the current display - > people will be looking for the link. But open to ideas, what were you > thinking of? To be honest I spent 10 min trying to understand which parameter was missing, and why the previous view (the table with the "Order" buttons on the right) did not appear. I thought it was a bug! If we are coming from the acquisition module we certainly only want to do that action, however the link is lost between all the other links. I do not have an idea that could be ergonomic however (I thought maybe cats, snow or stars around the new link? but...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:21:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:21:57 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #17 from Martin Renvoize --- Created attachment 98436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98436&action=edit Bug 24474: Drop `ReturnLostItem` from ::Account classes This patche removes the ReturnLostItem calls from Koha::Account->pay and Koha::Account::Line->apply methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:22:00 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #18 from Martin Renvoize --- Created attachment 98437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98437&action=edit Bug 24474: Add ReturnLostItem handling for SIP Payments This patch adds a call to ReturnLostItem for Lost Item payments taken via SIP machines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:22:03 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #19 from Martin Renvoize --- Created attachment 98438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98438&action=edit Bug 24474: Add ReturnLostItem handling for staff client payments This patch adds a call to ReturnLostItem for Lost Item payments taken via the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:22:06 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #20 from Martin Renvoize --- Created attachment 98439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98439&action=edit Bug 24474: Add ReturnLostItem handling for paypal payments This patch adds a call to ReturnLostItem for Lost Item payments taken via OPAC online payments through PayPal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:22:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:22:39 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #19 from Katrin Fischer --- (In reply to Jonathan Druart from comment #18) > (In reply to Katrin Fischer from comment #17) > > (In reply to Jonathan Druart from comment #16) > > > Would it make sense to have the "Add order" link a bit more visible? > > > > As you have to start from the basket I don't mind the current display - > > people will be looking for the link. But open to ideas, what were you > > thinking of? > > To be honest I spent 10 min trying to understand which parameter was > missing, and why the previous view (the table with the "Order" buttons on > the right) did not appear. I thought it was a bug! > If we are coming from the acquisition module we certainly only want to do > that action, however the link is lost between all the other links. > I do not have an idea that could be ergonomic however (I thought maybe cats, > snow or stars around the new link? but...) I think the inbuilt list for odering lacked some of the information that you would want to see. To me this works similar now than the 'search to hold' or 'order from holds ratio report' where we display an additional link, when the feature was activated. What could be nice is maybe displaying a 'back to basket' link where the 'last patron' thing is? Just thinking how we could further streamline navigation... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:27:08 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #21 from Martin Renvoize --- This is still a work in progress.. I need to add some further tests selenium tests as this is moving code out of tested objects and into the controllers where really it should belong.. I really wish our controller layer was lighter and more clearly tested.. paycollect, for example, is a real mess at this point and I'm sure must contain untested functionality. I'll get writing tests and hopefully get this patchset through before swinging back around for a refactoring effort there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:35:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:35:39 +0000 Subject: [Koha-bugs] [Bug 24590] New: Koha/Object.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Bug ID: 24590 Summary: Koha/Object.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org % prove t/db_dependent/Koha/Object.t is failing on MySQL 8 with: kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 15/18 # Failed test 'Exception field is correct' # at t/db_dependent/Koha/Object.t line 650. # got: 'api_keys.secret' # expected: 'secret' # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .. 16/18 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 723. MySQL 8 displays the tablename in the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:36:02 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha/Object.t |Koha/Object.t is failing on | |MySQL 8 Blocks| |23996 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:36:02 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 [Bug 24590] Koha/Object.t is failing on MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:36:02 +0000 Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24590 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:36:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:36:10 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:37:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:37:21 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:37:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:37:24 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 --- Comment #1 from Jonathan Druart --- Created attachment 98440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98440&action=edit Bug 24590: Fix Koha/Object.t on MySQL 8 % prove t/db_dependent/Koha/Object.t is failing on MySQL 8 with: kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 15/18 # Failed test 'Exception field is correct' # at t/db_dependent/Koha/Object.t line 650. # got: 'api_keys.secret' # expected: 'secret' # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .. 16/18 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 723. MySQL 8 displays the tablename in the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:38:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:38:54 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|koha-bugs at lists.koha-commun |ulrich.kleiber at bsz-bw.de |ity.org | Status|ASSIGNED |Needs Signoff CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:46:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:46:19 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #6 from Anneli Österman --- I tested this again using a sandbox with this bug number (using master) and it worked perfectly well on all three pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 10:47:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 09:47:12 +0000 Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Which versions? I would like to know if it's a new thing (since bug 18936) or affect stable releases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:01:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:01:30 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- Do we really need the print statements? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:08:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:08:23 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98430|0 |1 is obsolete| | --- Comment #2 from Ulrich Kleiber --- Created attachment 98441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98441&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:24:43 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #44 from Jonathan Druart --- Nick, could you confirm it will not break the display for UNIMARC and NORMARC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:25:37 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Katrin Fischer --- Thx anneli, do you want to add your sign off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:36:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:36:57 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Jonathan Druart --- The tests are failing: t/db_dependent/selenium/patrons_search.t .. # Failed test 'Invalid option not added when DefaultPatronSearchFields is populated with an invalid field' # at t/db_dependent/selenium/patrons_search.t line 97. # got: '13' # expected: '12' # Failed test 'Invalid filter option not added when DefaultPatronSearchFields is populated with an invalid field' # at t/db_dependent/selenium/patrons_search.t line 98. # got: '13' # expected: '12' # Looks like you failed 2 tests of 12. t/db_dependent/selenium/patrons_search.t .. 1/1 # Failed test 'Search patrons' # at t/db_dependent/selenium/patrons_search.t line 137. # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:37:57 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 --- Comment #14 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > Back to SO for now. Next week things will be better ;) Ping Marcel? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:42:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:42:12 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92541|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 98442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98442&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:42:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:42:18 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:42:22 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98410|0 |1 is obsolete| | Attachment #98411|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 98443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98443&action=edit Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:42:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:42:26 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #9 from Jonathan Druart --- Created attachment 98444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98444&action=edit Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:42:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:42:51 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:43:07 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:45:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:45:30 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #8 from Jonathan Druart --- I do not think it is correct to have the condition check in the controller. I am pretty sure Tomas will disagree with that as we will want the API taking into account those new sysprefs. CCing Tomas to get his opinion on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:47:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:47:47 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:47:51 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96810|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 98445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98445&action=edit Bug 23784: Show subtitle, number and part in course reserve list of records At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserce course Make sure you have some with different combinations of 245$b$n$p - Look at the course details in the OPAC - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:53:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:53:11 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:53:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:53:14 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97585|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 98446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98446&action=edit Bug 23844: Check if field defined in framework and specify 'Default' for framework To test: 1 - Go to Cataloguing 2 - New from Z3950 3 - Find an import a record 4 - Check the plack logs: Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 565. Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 580. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 711. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 715. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 734. 5 - Apply patch 6 - Repeat 7 - No new errors 8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates no errors Signed-off-by: Myka Kennedy Stephens Signed-off-by: Jonathan Druart Note: the template change does not seem necessary here but should not hurt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 11:55:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 10:55:28 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #3 from Jawad Makki --- Hello Jonathan, it is not clear if it is happening during edit or new bibliographic. the logs on apache2 are showing a gateway timeout on below operations POST /cgi-bin/koha/cataloguing/addbiblio.pl /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=BKS Getting the exact time from apache2 logs and checking Koha logs from the intranet this shows the 2 options : sometime it an edit operation and sometime it is a new record. I've checked some of these records, they look fine :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:02:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:02:21 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #47 from Jonathan Druart --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:06:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:06:14 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 --- Comment #2 from paxed --- Created attachment 98447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98447&action=edit Plugin to test Bug 24589 This is a Koha plugin used to test Bug 24589 functionality. Test plan: 1) Go to cataloging > New record 2) Edit the record, and save it. 3) Enable plugins, upload this plugin, and enable it. 4) Go to cataloging > New record 5) Edit the record, fill the required fields. Make sure 245$a does not contain "FOOBAR". 6) Try to save the record, you'll get a complaint: "ERROR: 245$a was not FOOBAR. Try saving again." 6) Check field 245$a, it should now contain "FOOBAR" 7) Try saving the record, it should now work normally. 8) Disable this plugin, and repeat 1 & 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:07:21 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart --- We should not reuse OpacMaxItemsToDisplay but create a new pref here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:13:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:13:16 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 Jawad Makki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jawad_makki at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:17:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:17:17 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Should not the option be displayed but greyed instead? With a popup telling the user why it's not selectable? Is the idea to remove ClaimReturnedLostValue from LOST wherever this dropdown list is displayed? I guess we will need to adjust the acquisition (new order, serial receiving) views as well in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:22:32 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #4 from Jonathan Druart --- What happen if you edit this record again? Does it timeout? You should compare with a supervision log/graph and see if the server was not overloaded (by something else) at that moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:27:06 +0000 Subject: [Koha-bugs] [Bug 24591] New: Add developer script to preview a letter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Bug ID: 24591 Summary: Add developer script to preview a letter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org I just a wrote a tiny script to help me preview a letter content. I'm not sure if it should go in Koha sources but I don't know where to put it and I think it may help other people -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:27:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:27:44 +0000 Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 --- Comment #1 from Julian Maurice --- Created attachment 98448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98448&action=edit Bug 24591: Add developer script to preview a letter The script is very simple, it just calls GetPreparedLetter with arguments given on command line and print the resulting letter content Usage example: misc/devel/get-prepared-letter.pl --module circulation \ --letter_code ODUE --tables '{"borrowers":1,"branches":"CPL"}' \ --repeat '{"item":[{"biblio":1,"items":1}]}' \ --loops '{"overdues":[1]}' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:27:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:27:57 +0000 Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:29:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:29:05 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #82 from Laurence Rault --- Patch put on biblibre sandbox 1 1 : impossible to place a hold from staff : First click on Place hold button in request.pl do nothing ; second click makes browser do something but next page never displays and reserve is not added (tested in firefox and chromium) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:31:32 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 --- Comment #9 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Should not the option be displayed but greyed instead? With a popup telling > the user why it's not selectable? > > Is the idea to remove ClaimReturnedLostValue from LOST wherever this > dropdown list is displayed? I guess we will need to adjust the acquisition > (new order, serial receiving) views as well in that case. That sounds a bit challenging to implement. Would adding some "help" text indicating something along those lines be acceptable. If you know how to implement a tooltip on a disable select value, that does seem like the nicest way to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:36:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:36:38 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #12 from Martin Renvoize --- (In reply to Jonathan Druart from comment #11) > Do we really need the print statements? Oops, not at all.. leftover debugging whilst I was working on the DB update.. my bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:38:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:38:07 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #17 from Jonathan Druart --- Does it make sense to display the "edit ... to configure" part each time? "Enabling SIP server for kohadev - edit /etc/koha/sites/kohadev/SIPconfig.xml to configure" I think "This is the first time SIP has been enabled. Please check the configurations in /etc/koha/sites/${name}/SIPconfig.xml" is enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:39:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:39:52 +0000 Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #16 from Jonathan Druart --- Please use the Branches TT plugin instead (Branches.GetName). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:40:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:40:16 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #34 from Kyle M Hall --- Alex, it looks like this patch set will need to be updated to move the new rule into circulation_rules. Are you planning on doing that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:40:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:40:46 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:40:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:40:46 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 [Bug 24376] Wording of Fine Returned is confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:41:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:41:30 +0000 Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- Also I bet that this column does not make sense if IndependentBranches or singleBranchMode is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:44:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:44:23 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 --- Comment #10 from Jonathan Druart --- disabled then title attribute on the option should work. It is used already in opac-reserve.tt: 244 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 12:45:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 11:45:24 +0000 Subject: [Koha-bugs] [Bug 24592] New: Clarify LOST_RETURN process by using FOUND over RETURNED Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Bug ID: 24592 Summary: Clarify LOST_RETURN process by using FOUND over RETURNED Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The phrasing of LOST_RETURN is confusing, the item is not always immediately returned, sometimes it is renewed for example.. I think it would be clearer to reword this to use 'FOUND' to more clearly reflect the states.. I intend to do this in the accounts handling as well as rename the _FixAccountForLostAndReturned method in C4::Circulation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:01:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:01:51 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96223|0 |1 is obsolete| | Attachment #96224|0 |1 is obsolete| | Attachment #96225|0 |1 is obsolete| | Attachment #96226|0 |1 is obsolete| | Attachment #96227|0 |1 is obsolete| | Attachment #96229|0 |1 is obsolete| | Attachment #96230|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 98449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98449&action=edit Bug 24156: DB changes Add a new table tables_settings to store default_display_length and default_sort_order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:01:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:01:55 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #12 from Jonathan Druart --- Created attachment 98450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98450&action=edit Bug 24156: DBIC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:01:58 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #13 from Jonathan Druart --- Created attachment 98451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98451&action=edit Bug 24156: move ColumnsSettings to TablesSettings We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:02:02 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #14 from Jonathan Druart --- Created attachment 98452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98452&action=edit Bug 24156: Add columns_settings.yml changes Modification of the structure of the yml file. It was table: - column list It now becomes table: default_display_length: X default_sort_order: Y columns: - column list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:02:05 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #15 from Jonathan Druart --- Created attachment 98453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98453&action=edit Bug 24156: Add missing columns to yml There were 2 columns missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:02:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:02:09 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #16 from Jonathan Druart --- Created attachment 98454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98454&action=edit Bug 24156: Adjust other tables in the yml file To match the new structure, we adjust the other tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:02:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:02:12 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #17 from Jonathan Druart --- Created attachment 98455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98455&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. Sponsored-by: Institute of Technology Tallaght -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:02:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:02:16 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #18 from Jonathan Druart --- Created attachment 98456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98456&action=edit Bug 24156: Fix set sort order to the first column In that case it's equal to 0 and we need to adjust the test condition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:03:46 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14474 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:03:46 +0000 Subject: [Koha-bugs] [Bug 14474] Circulation alerts should have a From: address based on the current logged-in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24592 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:04:01 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=14474 |?id=24474 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:04:01 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24592 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:04:01 +0000 Subject: [Koha-bugs] [Bug 14474] Circulation alerts should have a From: address based on the current logged-in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24592 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:06:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:06:41 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:06:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:06:41 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:20:18 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 --- Comment #1 from Martin Renvoize --- Created attachment 98457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98457&action=edit Bug 24592: Reword LOST_RETURN to LOST_FOUND This patch updates the wording in the 'lost and found' process to more closely reflect what the process is achieving by replacing 'RETURNED' with 'FOUND' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:20:21 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 --- Comment #2 from Martin Renvoize --- Created attachment 98458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98458&action=edit Bug 24592: Database Update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:20:41 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:20:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:20:47 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:22:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:22:05 +0000 Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:24:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:24:40 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #5 from Jawad Makki --- the record is edited and saved normally (no timeout). we were monitoring the server during the problem, and we've noticed that it is the "addbiblio.pl" script that is causing this overload on the CPU ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:25:48 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #22 from Martin Renvoize --- OK.. having another go.. I don't like that I was moving the logic out of a well testing Object and into untested and hard to test messy controllers... bare with me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:25:55 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:25:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:25:59 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha at catalyst.net.nz |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:28:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:28:22 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:28:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:28:26 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98256|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 98459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98459&action=edit Bug 24420: Display waiting on hold items in the Cataloging search results Location column To Test: 1. Place a hold on an item and trigger it. 2 Do a cataloging search that would include this record. 3. Notice that the 'Location' column does not account for this onhold item. 4. Apply patch and look at catalog results again. 5. You should see information display about the item being on hold. Signed-off-by: Barbara Johnson Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:28:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:28:34 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #23 from Martin Renvoize --- Created attachment 98460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98460&action=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:28:57 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:29:06 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:29:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:29:14 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:29:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:29:22 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:31:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:31:04 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98440|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 98461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98461&action=edit Bug 24590: Fix Koha/Object.t on MySQL 8 % prove t/db_dependent/Koha/Object.t is failing on MySQL 8 with: kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 15/18 # Failed test 'Exception field is correct' # at t/db_dependent/Koha/Object.t line 650. # got: 'api_keys.secret' # expected: 'secret' # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .. 16/18 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 723. MySQL 8 displays the tablename in the error. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:31:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:31:14 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:31:33 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize --- Trivial and obvious fix, Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:32:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:32:56 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #83 from Julian Maurice --- Apparently holds are broken on master (bug 24410). We better wait for this bug to be resolved before rebasing it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:33:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:33:11 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 [Bug 24410] Multi holds broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:33:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:33:11 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:33:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:33:21 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:33:31 +0000 Subject: [Koha-bugs] [Bug 24485] AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sys Pref |AllowHoldPolicyOverride |AllowHoldPolicyOverride |should allow Staff to |will not Staff override a |override the Holds Per |Holds Per Record Rule |Record Rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:34:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:34:32 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #23 from Jonathan Druart --- Could someone test this patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:35:19 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:35:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:35:23 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97595|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 98462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98462&action=edit Bug 24449: Add too_many_overdue to patron status for SIP To test: 1 - Have sip running and use the cli to get info for a patron example: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su koha -sp koha -l CPL -m patron_status_request --patron koha 2 - Checkout an item to the patron, backdated so it is overdue 3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block" 4 - Get the patron status via SIP, note circ blocked flag is set, but too_many_overdue is not 5 - Apply patch 6 - Restart all the things 7 - Get the patron status via SIP 8 - Note the too_many_overdue flag is now triggered and there is a message example: READ: 24Y Y 00120200117 142716AEEdna Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha. -- Patron has overdues -- Patron owes 0.25|AOCPL| Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:37:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:37:56 +0000 Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:38:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:38:52 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:38:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:38:54 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:38:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:38:55 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:38:57 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:38:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:38:59 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:01 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:03 +0000 Subject: [Koha-bugs] [Bug 24485] AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:05 +0000 Subject: [Koha-bugs] [Bug 24485] AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:07 +0000 Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:08 +0000 Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:10 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:39:12 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:42:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:42:40 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #27 from Owen Leonard --- Created attachment 98463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98463&action=edit Image "diff" of the two screenshots I don't think this difference warrants failing the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:59:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:59:48 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98464&action=edit Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 13:59:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 12:59:55 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98465&action=edit Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:02 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 98466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98466&action=edit Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:09 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98467&action=edit Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:17 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 98468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98468&action=edit Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:25 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 98469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98469&action=edit Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:35 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 98470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98470&action=edit Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:47 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 98471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98471&action=edit Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:00:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:00:58 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 98472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98472&action=edit Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:01:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:01:09 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 98473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98473&action=edit Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:01:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:01:19 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 98474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98474&action=edit Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:01:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:01:27 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 98475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98475&action=edit Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:01:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:01:34 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 98476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98476&action=edit Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:01:40 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 98477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98477&action=edit Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:03:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:03:43 +0000 Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 --- Comment #2 from Andrew Fuerste-Henry --- I found this in 19.05 and confirmed it in master. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:04:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:04:49 +0000 Subject: [Koha-bugs] [Bug 24593] New: Rewrite MARC21 optional data to YAML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Bug ID: 24593 Summary: Rewrite MARC21 optional data to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr A complete rewrite of MARC21 optional instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:05:08 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | CC|frederic at tamil.fr | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:08:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:08:15 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Please add a commit message with a test plan: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:08:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:08:43 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:08:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:08:46 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #43 from Nick Clemens --- Created attachment 98478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98478&action=edit Bug 17374: (follow-up) Remove all spaces from include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:15:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:15:44 +0000 Subject: [Koha-bugs] [Bug 24594] New: Rewrite MARC21 mandatory data to YAML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Bug ID: 24594 Summary: Rewrite MARC21 mandatory data to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr A complete rewrite of MARC21 mandatory instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files In this case the patches are too big, they will be uploaded compressed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:16:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:16:00 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC|frederic at tamil.fr | Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:23:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:23:18 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97310|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 98479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98479&action=edit Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:23:28 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:23:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:23:50 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Nick Clemens --- The problem still exists on master in my testing, these patches fix the problem I cannot recreate the error encountered by Ben or Lisette, these patches do not touch returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:27:48 +0000 Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #18 from Katrin Fischer --- It would be really nice if it could be hidden automatically for single branches or using the column configuration settings. We have similar checks for single branches in multiple places. I don't think IndependentBranches is a problem - you could still check otu items from different branches or get them via holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:29:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:29:07 +0000 Subject: [Koha-bugs] [Bug 24595] New: Warnings displayed by Circulation.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Bug ID: 24595 Summary: Warnings displayed by Circulation.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 15/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. t/db_dependent/Circulation.t .. 18/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601. Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. t/db_dependent/Circulation.t .. 27/46 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. t/db_dependent/Circulation.t .. 30/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 31/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 38/46 Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Circulation.pm line 962. t/db_dependent/Circulation.t .. 44/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=46, 32 wallclock secs ( 0.07 usr 0.01 sys + 20.75 cusr 7.61 csys = 28.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:29:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:29:24 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |24217 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:29:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:29:24 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 [Bug 24595] Warnings displayed by Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:29:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:29:59 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:30:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:30:02 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 --- Comment #1 from Jonathan Druart --- Created attachment 98480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98480&action=edit Bug 24595: Silent warnings from Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:32:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:32:57 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #28 from Jonathan Druart --- I am worried they are not the only regressions we are going to introduce with this patch as it can impact all the inputs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:45:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:45:13 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Can we imagine whitelist a list of html tags? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:46:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:46:09 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98457|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 98481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98481&action=edit Bug 24592: Reword LOST_RETURN to LOST_FOUND This patch updates the wording in the 'lost and found' process to more closely reflect what the process is achieving by replacing 'RETURNED' with 'FOUND' Test plan: 1) Grep codebase for _FixAccountForLostAndReturned and note there are no longer any instanced of it. 2) Run t/db_dependent/Circulation.t and note it passes 3) Test returning/renewing an item that has been marked as lost and note the updated values in the accountlines now use LOST_FOUND as credit_type_code and 'FOUND' as the status for the 'LOST' fee (debit_type_code 'LOST') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:46:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:46:11 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98458|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 98482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98482&action=edit Bug 24592: Database Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:46:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:46:45 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |24474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:46:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:46:45 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24592 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:46:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:46:45 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:58:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:58:04 +0000 Subject: [Koha-bugs] [Bug 24510] When Placing a Hold, cursor doesn't focus on Patron Name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- What is the purpose of the test? if ( $(".focus").is(":visible") ) I do not understand your patch, neither why it works. I have the feeling that it is not the correct way to do what you want. We already have .focus in this DOM (the header search), and the same .focus() applied on them (in staff-global.js). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:58:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:58:35 +0000 Subject: [Koha-bugs] [Bug 24510] When Placing a Hold, cursor doesn't focus on Patron Name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Jonathan Druart --- CCing Owen, maybe he will know what's going on here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 14:58:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 13:58:51 +0000 Subject: [Koha-bugs] [Bug 24510] When Placing a Hold, cursor doesn't focus on Patron Name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:00:03 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98421|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 98483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98483&action=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:04:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:04:26 +0000 Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 --- Comment #19 from Jonathan Druart --- Could we unify the code in boraccount please? Also it seems than we will need to move this code in an include file, to avoid seeing it c/p all over the members template modules... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:05:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:05:03 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- See bug 24339 comment 19. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:06:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:06:21 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:06:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:06:24 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98441|0 |1 is obsolete| | --- Comment #4 from Ulrich Kleiber --- Created attachment 98484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98484&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There shoud be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There shoud be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490 at FQDN> 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:08:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:08:22 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98392|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 98485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98485&action=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:08:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:08:26 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98460|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 98486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98486&action=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:08:29 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #26 from Martin Renvoize --- Created attachment 98487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98487&action=edit Bug 24474: Filter out LOST_FOUND -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:08:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:08:46 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:09:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:09:26 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #27 from Martin Renvoize --- Probably not QA ready, but certainly in good enough shape for some testing please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:09:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:09:38 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24592 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:09:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:09:38 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24474 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:22 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 --- Comment #9 from Julian Maurice --- Created attachment 98488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98488&action=edit Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create manual invoice for any patron and click on "Save", you should be redirected to Account tab 2. Create manual invoice for any patron and click on "Save and pay", you should be redirected to Account tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:29 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:29 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:34 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98484|0 |1 is obsolete| | --- Comment #5 from Ulrich Kleiber --- Created attachment 98489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98489&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490 at FQDN> 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:36 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Attachment #42896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:10:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:10:46 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:13:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:13:56 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98412|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 98490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98490&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:13:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:13:59 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98413|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 98491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98491&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:14:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:14:16 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #15 from Martin Renvoize --- Second patch now corrected to remove debug print lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:14:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:14:30 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:15:39 +0000 Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97815|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 98492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98492&action=edit Bug 24489: Don't allow payment of 0 To test: 1 - Put a fine on a patron 2 - Go to Accounting->Make a payment on the patrons record 3 - Select the fine and click 'Write off selected' 4 - Enter '.0001' into Writeoff amount and hit confirm 5 - You are redirected to make a payment with no error and are no longer writing off selected 6 - Apply patch 7 - Attempt to pay less than a cent 8 - You are warned that you must pay more than 0 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:16:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:16:12 +0000 Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Thanks for jumping on this Nick.. :) Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:17:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:17:42 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98480|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 98493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98493&action=edit Bug 24595: Silent warnings from Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:18:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:18:00 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Sweet silence.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:18:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:18:07 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:21 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:23 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #32 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:25 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:27 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:32 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:33 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:35 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:28:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:28:37 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:42:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:42:40 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98494&action=edit Bug 24593: Rewrite marc21_default_matching_rules to YAML YAML version of marc21 optional marc21_default_matching_rules. To test: 1) Do a clean install with optional data, dump table marc_matchers, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' Error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:42:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:42:43 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98495&action=edit Bug 24593: Rewrite marc21_sample_fastadd_framework to YAML YAML version of marc21_sample_fastadd_framework To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:42:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:42:46 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 98496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98496&action=edit Bug 24593: Rewrite marc21_simple_bib_frameworks to YAML YAML version of marc21_simple_bib_frameworks To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:55:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:55:32 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Thanks Ulrich :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 15:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 14:56:16 +0000 Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Nick Clemens --- This patch does highlight some issues - it is possible to create fines of partial cents. With this patch those fines cannot be written off, or at least the partial cents cannot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:05:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:05:42 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:05:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:05:46 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98082|0 |1 is obsolete| | Attachment #98083|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 98497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98497&action=edit Bug 24526: Add verbose and commit options to automatic_renewals cronjob To test: 1 - Apply patch 2 - Have some items marked for auto-renewal 3 - Run the job with no parameters 4 - It should print 'Test mode' 5 - Provide -v 6 - It should print 'Test mode' then a line for each item 7 - Provide -v -c 8 - It should not say test mode, but should provide a line for each item 9 - Provide -c 10 - Shoudl run as expected with no output Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:05:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:05:49 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #8 from Jonathan Druart --- Created attachment 98498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98498&action=edit Bug 24526: (follow-up) clean up verbose conditional Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:05:53 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #9 from Jonathan Druart --- Created attachment 98499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98499&action=edit Bug 24526: Use sprintf for readability Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:05:56 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #10 from Jonathan Druart --- Created attachment 98500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98500&action=edit Bug 24526: Replace commit with confirm Usually commit takes a value Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:06:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:06:00 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #11 from Jonathan Druart --- Created attachment 98501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98501&action=edit Bug 24526: Set verbose if confirm not set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:06:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:06:59 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Nick, I submitted few follow-ups, do you agree with them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:14:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:14:26 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98502&action=edit Bug 24594: Rewrite authorities_normal_marc21 to YAML YAML version of marc21 mandatory authorities_normal_marc21. To test: 1) Do a clean install with mandatory data, dump table auth_types, auth_tag_structure and auth_subfield_structure, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");' Error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:14:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:14:55 +0000 Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508 --- Comment #6 from Hans Pålsson --- Thanks for all replies. Can this bug be closed or marked as resolved (or blocked?). It was clearly not a bug that was caused by Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:15:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:15:50 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98503&action=edit Bug 24594: Rewrite marc21_framework_DEFAULT to YAML YAML version of marc21 mandatory marc21_framework_DEFAULT. To test: 1) Do a clean install with mandatory data, dump table marc_tag_structure and marc_subfield_structure, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("marc21_framework_DEFAULT.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("marc21_framework_DEFAULT.yml");' Error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:17:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:17:48 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:17:52 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98490|0 |1 is obsolete| | Attachment #98491|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 98504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98504&action=edit Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:17:56 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 --- Comment #17 from Jonathan Druart --- Created attachment 98505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98505&action=edit Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:13 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13897, 24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:13 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 [Bug 24594] Rewrite MARC21 mandatory data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:13 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 [Bug 24594] Rewrite MARC21 mandatory data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:55 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13897, 24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:55 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 [Bug 24593] Rewrite MARC21 optional data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:18:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:18:55 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 [Bug 24593] Rewrite MARC21 optional data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:25 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13897, 24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:25 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 [Bug 24584] Rewrite optional installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:25 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 [Bug 24584] Rewrite optional installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:56 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13897, 24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:56 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 [Bug 24583] Rewrite mandatory installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:19:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:19:56 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 [Bug 24583] Rewrite mandatory installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:22:18 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96626|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 98506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98506&action=edit Bug 24262: Translate installer data in YAML format This patch adds the ability to: 1) Create new translation files from yaml installer files 2) Create installer directory for a given language It will not create a installer directory if it already exists. New (possible) translation files: xx-YY-installer.po xx-YY-installer-MARC21.po xx-YY-installer-UNIMARC.po Needs Bug 13897 (for yaml files) NOTE: updated version adding ability to process multiline fields, discard small ( < 2) strings, and discard strings with pure html, TT or punctuation. To test: 1) Apply patches from Bug 13897 2) Apply this patch 3) Go to misc/translation 4) Create translation files for a NEW language $ ./translate create xx-YY check new file 'xx-YY-installer.po' 5) Copy ../../installer/data/mysql/en/optional/auth_val.yml into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/ and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/ remove po/xx-YY*, then repeat creation check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po' and 'xx-YY-installer-UNIMARC.po' remove all new files 6) Create for xx-YY again and try update $ ./translate create xx-YY edit ../../installer/data/mysql/en/optional/auth_val.yml and change one char in one of the translatable values, also edit 'xx-YY-installer.po', translate the same string (in msgstr). Do an update $ ./translate update xx-YY check in 'xx-YY-installer.po' a fuzzy value for the translated value and the preservation of the translation Fix the translation, or add a new one. 7) Create an install dir for xx-YY ./translate install xx-YY Check new dir '../../installer/data/mysql/xx-YY/' Check files on it $ tree ../../installer/data/mysql/xx-YY/ and compare with ../../installer/data/mysql/en/ All installation files must be present 8) Try a new Koha install using this language in the usual way. Check in authorised_values table for the translated string. 9) Try create an install dir for an existing language (eg. es-ES, de-DE or fr-FR ), eg. ./translate install de-DE Install dir is detected and not changed, a note is printed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:24:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:24:13 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #50 from Bernardo Gonzalez Kriegel --- Created attachment 98507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98507&action=edit Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:25:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:25:36 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #51 from Bernardo Gonzalez Kriegel --- New patch added, needs sign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 16:25:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 15:25:43 +0000 Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:09:21 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #12 from Agustín Moyano --- (In reply to David Nind from comment #11) > (In reply to David Nind from comment #10) > > I get this message when trying to apply this patch (git bz apply 24502): > > > > Failed to retrieve bug information: NotPermitted > > Figured it out - a dependency is security related. > > Will let someone else test who has the right access! Thaks for trying anyway! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:15:39 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #13 from Nick Clemens --- All looks good to me - we wil need to highlight in the release notes that existing cronjobs will need to have the confirm switch added after upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:17:28 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds new release notes| |options to the | |automatic_renewals.pl | |script to allow test and | |verbose modes. | | | |The patches | |make the --confirm switch | |required, without it script | |will be run in test mode. | |Existing scheduled cronjobs | |will need to be updated to | |supply this switch. | | | |Running without --confirm | |will default in verbose | |mode as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:19:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:19:10 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #14 from Jonathan Druart --- (In reply to Nick Clemens from comment #13) > All looks good to me - we wil need to highlight in the release notes that > existing cronjobs will need to have the confirm switch added after upgrade You are right, we also need to update debian/koha-common.cron.daily! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:19:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:19:35 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #13 from Agustín Moyano --- Hi Martin, I tryed to use this version of q parameter to be sent into the body of a GET request, but unfortunately browsers don't allow that kind of messages. I stripped the code to de bare bones of JS creating a XMLHTTPRequest and it's replacement, the "Fetch API", but nither of both sends body content with a GET request. The first one ignores the content if the method is GET, and the second one throws an exception. I would suggest to keep q parameter in body, but also to have a q parameter in the query, and maybe also in a header (something like 'x-koha-query') So if you are using any server side program to fetch from de API, you can send body content in the GET request, but if you are using the browser you can choose to use q parameter in the query, or if you want to keep it clean, use the x-koha-query header. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:20:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:20:11 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > (In reply to Nick Clemens from comment #13) > > All looks good to me - we wil need to highlight in the release notes that > > existing cronjobs will need to have the confirm switch added after upgrade > > You are right, we also need to update debian/koha-common.cron.daily! And the POD of the script. Not ready for pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:50:31 +0000 Subject: [Koha-bugs] [Bug 24382] Wrong information showing on detail pages for fines/fees and payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:50:31 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382 [Bug 24382] Wrong information showing on detail pages for fines/fees and payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:53:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:53:22 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #7 from Julian Maurice --- (In reply to Jonathan Druart from comment #6) > I like the "tags" on https://keepachangelog.com/en/1.0.0/, like "Added", > "Deprecated", etc. > > It would be great to have some like "new modules", "new method", "new api > route", "deprecated", "new/rm/mv sysprefs", "new table/column", etc. > > So a single entry "feature foo" could have several tags. > > We could have that at the end of the "Text to go in the release notes", like: > > """ > This is a release note for feature foo that bring useful stuffs. > %%%%%%%%%%%%%% # a separator line > [Add pref]YetAnotherPref > [Add DB table]a_new_db_table > """ > > The changelog could then be built using that and make the DB changes (or any > other type of changes) eyeballed easily. Why not add this directly in the patch ? Following the keepachangelog convention we could have: ChangeLog.md ### Added - This is a release note for feature foo that bring useful stuffs. ### Sysprefs - Add new syspref YetAnotherPref ### Technical/Dev - Add new database table a_new_db_table I see several benefits over using the bugzilla field: - Documentation of the change is close to the code. It can be part of the QA process to review that doc. - No additional tooling needed. We can even remove some tools because we won't need to generate release notes at release time. - Having to write in a specific format ([tag]description) that would be parsed by a script is error-prone and errors would be discovered only at release time. - ChangeLog is always up to date in master, making it easy to see what changed since the latest stable version. - It would be easy to see what changed between 2 commits, which can be really helpful when rebasing patches. The downside is that it will cause git conflicts, so we should probably have to do something similar to updatedatabase (atomicupdate) We can also consider having a DeveloperChangeLog.md to avoid polluting the main changelog too much with technical details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:55:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:55:26 +0000 Subject: [Koha-bugs] [Bug 24596] New: Due dates confusing on fines for renewed items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24596 Bug ID: 24596 Summary: Due dates confusing on fines for renewed items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The due date for fines that have been 'fixed' due to a renewal are confusing/misleading as they show the new due date rather than the due date for which the fine was created. As an aside, we could also display 'Renewal date' in place of 'Returned date' in this table for renewed items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:55:35 +0000 Subject: [Koha-bugs] [Bug 24596] Due dates confusing on fines for renewed items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:55:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:55:45 +0000 Subject: [Koha-bugs] [Bug 24596] Due dates confusing on fines for renewed items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 17:55:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 16:55:45 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24596 [Bug 24596] Due dates confusing on fines for renewed items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:00:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 17:00:23 +0000 Subject: [Koha-bugs] [Bug 24596] Due dates confusing on fines for renewed items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24596 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose --- Also, if an item is renewed twice, the second due date is recorded (not the original, not the new due date). It's like it's fixed to the due date of the item when the first fine was paid. I'll try to come up with a test plan, although not exactly sure how since it involves a lot of time in between the actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:13:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 17:13:59 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose --- Maybe "Fixed fine"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 18:52:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 17:52:24 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #79 from Martin Renvoize --- I've run out of steam for this at this point I'm afraid. We've gone nearly full circle now.. to me this highlights the need for good RFC's as the first step. I'll try to revisit unless someone takes it back over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:04:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:04:32 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98479|0 |1 is obsolete| | --- Comment #10 from Agustín Moyano --- Created attachment 98508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98508&action=edit Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:19:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:19:57 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:53:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:53:00 +0000 Subject: [Koha-bugs] [Bug 24597] New: Add ability to add note on all payment screens Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Bug ID: 24597 Summary: Add ability to add note on all payment screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On pay.pl staff can add a note if 'Pay amount', 'Pay selected', or 'Write off selected' are selected yet no note textarea appears if staff select 'Pay' or 'Write-off' Staff should have the ability to add a note regardless of which type of payment they select. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:58:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:58:14 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:58:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:58:17 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85401|0 |1 is obsolete| | --- Comment #57 from Nick Clemens --- Created attachment 98509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98509&action=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:58:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:58:48 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85402|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:58:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:58:54 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:59:01 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:59:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:59:10 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:59:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:59:18 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 19:59:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 18:59:36 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 19:04:07 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #58 from Nick Clemens --- (In reply to Katrin Fischer from comment #53) > +# This is the temporary entrance point to the API. Once bug #13799 is > settled, > +# it should be ported to using that. > +my $api = $query->param('api'); > > Should we file a separate bug for this? Yes, eventually, API endpoint for the search engine is going to be a larger task - comment amended to explain what this variable currently does >- "Browse interface" is a poor link text. Since the actual breadcrumb uses "Browse search", why not use that in the menu too? Updated >- I'm not quite following the logic of how the actual fuzziness is determined, >and it's not obvious in the UI that what the user chooses may not be what they >get. At the very least there should be comments in the code describing why it >does what it does. There are comments in the Browse.pm - it uses # of substitutions, ES limits to 2 >- Looks like a longer term may get truncated causing the search for records to >fail. An example subject term I encountered is "A history of geographical >discovery in the sevente" Fixed in the mappings we cna set a max - raised to 100 >- I think the UI needs to be polished a bit more. Did you run "yarn build --view=opac"? The list is scrollable I don't think this has to be the same as the scan from 22592 - I think allowing both would allow for comparison to decide if one does work better. On test DB they are comparable at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 19:09:54 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 20:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 19:41:52 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #15 from Agnes Rivers-Moore --- I had to get help deleting a couple of accidental categories. Anyone still interested in finishing this up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:01:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:01:30 +0000 Subject: [Koha-bugs] [Bug 24598] New: Hold not reset properly if checked out to another patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Bug ID: 24598 Summary: Hold not reset properly if checked out to another patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! To replicate: 1) Place an item on hold at Library A for Patron 1 at Library B. 2) Check in the item at Library A to trigger the hold transfer. 3) At Library B, check out the item to Patron 2 (click Yes). * Note that the hold still show in transit in the status. * Note that the Pickup library shows the item is waiting. * Note that the since date in the Pickup library is blank. What needs to happen: If an item is intercepted and checked out to a patron while in transit: * The transfer needs to be cancelled. * The hold needs to revert back to the top of the queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:16:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:16:38 +0000 Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must return Koha::Objects using the DBIx::Class relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:16:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:16:41 +0000 Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must return Koha::Objects using the DBIx::Class relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98157|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 98510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98510&action=edit Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods To match PERL15 we change the behavior of Koha::Object methods to make them use the DBIx::Class relationships. Test plan: - Create a vendor, basket and contact - Edit the vendor => the contact must appears - Go to the view of a vendor => you cannot delete the vendor, it has a basket attached - Create another vendor, without basket - Go to the view of the vendor => You can delete it Additionally: % prove t/db_dependent/Koha/Acquisition/Booksellers.t must return green Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:37:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:37:43 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #11 from Andrew Fuerste-Henry --- Bug 24203 brings up the fact that as the longoverdue cron is now able to differ based on itype while overdues are not. This moves the two processes further apart. This pushes me further into the belief that we should abandon the idea of making overdue notices work for alerting patrons to long overdue charges and should instead work to accomplish that via the patron emailer cron. I just put together a plan for doing so: https://bywatersolutions.com/education/sending-notices-for-long-overdue-items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:43:48 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.08 --- Comment #18 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:45:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:45:00 +0000 Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- 19.05.x lacks dependency, no backport -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:45:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:45:23 +0000 Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:54:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:54:52 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #6 from Josef Moravec --- What if there is repeated subfield with same code in one field? Then only first one is taken into account. I do think we want to count on all of them... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 21:58:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 20:58:48 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.08 --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:00:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:00:01 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #19 from Lucas Gass --- missing dependencies, no backport for 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:14:45 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:14:49 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97994|0 |1 is obsolete| | Attachment #97995|0 |1 is obsolete| | --- Comment #26 from Josef Moravec --- Created attachment 98511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98511&action=edit Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:14:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:14:54 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #27 from Josef Moravec --- Created attachment 98512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98512&action=edit Bug 13420: Fallback to the previous behavior if published date is not used Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:14:58 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #28 from Josef Moravec --- Created attachment 98513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98513&action=edit Bug 13420: (QA follow-up): Fix typo itemdate -> itemdata Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:15:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:15:21 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:20:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:20:17 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:21:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:21:48 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #52 from Lucas Gass --- enhancement will not be backported to 19.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:24:29 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 Andreas Hedström Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se --- Comment #8 from Andreas Hedström Mace --- I would go with the simplest solution: "Fine" and "Fine Accruing". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:37:15 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:38:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:38:08 +0000 Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:42:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:42:47 +0000 Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 22:51:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 21:51:54 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #34 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:00:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:00:04 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #49 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:05:08 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- Looks like items that have been left behind in collections_tracking after their collection has been deleted are also blocked from being added to a new collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:05:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:05:23 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 --- Comment #5 from Andrew Fuerste-Henry --- Confirmed this is still true in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:05:28 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:09:54 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:14:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:14:54 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:19:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:19:43 +0000 Subject: [Koha-bugs] [Bug 20852] Make "All libraries" default organisation for article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20852 eboyd at uls.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eboyd at uls.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 5 23:58:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 22:58:30 +0000 Subject: [Koha-bugs] [Bug 24550] Books renewals triggers item loan policies to revert to branch renewing item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- With 19.05 there was a fix that changed how the 2 system prefs CircControl HomeOrHoldingBranch worked. It sounds like they should both be set to home branch/item's home library. Can you check and make sure both of these preferences are set this way? Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 00:00:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 23:00:21 +0000 Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- When you enable using Koha Plugins, the plugin system must also be enabled in the Koha configuration file to be fully enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 00:14:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 23:14:06 +0000 Subject: [Koha-bugs] [Bug 24550] Books renewals triggers item loan policies to revert to branch renewing item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550 --- Comment #2 from R Russell --- We didn't change anything. This just started to happen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 00:16:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Feb 2020 23:16:37 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #80 from Agustín Moyano --- (In reply to Martin Renvoize from comment #79) > I've run out of steam for this at this point I'm afraid. We've gone nearly > full circle now.. to me this highlights the need for good RFC's as the first > step. > > I'll try to revisit unless someone takes it back over. I'll take ir again as soon as I can -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:11:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:11:49 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #26 from David Cook --- (In reply to Jonathan Druart from comment #25) > > What about the patch? Was not it suppose to fix the issue? Oh yeah... apparently I wrote that patch 6 years ago. I didn't realize I was even the author of it. But according to my comment from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430#c6, I think my patch would actually break some searches in Koha where older versions of Zebra are used (ie < 2.0.62). I think the koha-common package uses 2.0.59 by default, so probably not a good idea to use this patch. I think my hopelessness with Search.pm led me to making this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430#c9 and opening this bug yesterday: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 I think the problem with Koha's search is that it looks like it works in many cases, so attempts to fix it will change the familiar behaviour, and people will complain. But I don't think it's possible to fix it and maintain backwards compatibility with current behaviour. The hardest part for me is finding the resources to fix it. Because it mostly works, I don't have a client-led or employer-led mandate to spend my resources fixing it. I wish I could do it out of the goodness of my heart, but my heart has other priorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:18:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:18:37 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #27 from David Cook --- I have been thinking that maybe we should modularize search more so that it would make it easier to customize behaviour, unit test, and swap different backends in/out, but... I think one of the biggest struggles we face is that Koha doesn't really have a search query language. We have something like CCL, but it's not CCL, and our compensating for that fact leads to problems. And without a real query language, we don't have a real query parser, and without a real query parser, it's hard to safely and programmatically alter the queries. But... I don't really have a solution in mind either. Sometimes, I hope that we'll just get rid of Zebra, and then we can just focus on Elasticsearch, and maybe change our search query syntax to be safer, easier to parse, and easier to integrate with Elasticsearch. I think it would be a breaking change away from the Zebra CCL-like search syntax we've used... but that would probably be a good thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:20:58 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I've added the omnibus bug for QueryParser - there is a ton of issues with > it basically. I think we might deprecate it soon. I am very much in favour of deprecating and removing the QueryParser. In the beginning, I was very supportive of the QueryParser, but I think there are just too many challenges trying to support it and the regular Koha query parsing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:22:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:22:07 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #6 from David Cook --- For what it's worth, this patch would work for non-QueryParser as well. It's just about validating the PQF query before trying to search Zebra. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:32:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:32:01 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nightly Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95933|0 |1 is obsolete| | --- Comment #20 from Nightly Build Bot --- Created attachment 98514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98514&action=edit Bug 17108- Automatic debian/control updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 01:33:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 00:33:12 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #24 from David Cook --- (In reply to Jonathan Druart from comment #23) > Could someone test this patch please? I'll spin up my koha-testing-docker (hopefully) and give it a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:06:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:06:56 +0000 Subject: [Koha-bugs] [Bug 16972] ./misc/sip_cli_emulator.pl should list mandatory vs. optional command line options in its usage section. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16972 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- This was just driving me crazy. I totally agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:11:00 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #25 from David Cook --- (In reply to Jonathan Druart from comment #23) > Could someone test this patch please? I'm trying but it looks like the SIP server might be broken in master. I can't do a "checkout" and even a "checkin" seems to be messed up: root at 9fb85e7ec5c6:koha(bug_23640)$ perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l CPL --patron 1 --item 3999900000001 -m checkout Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20200206 01104320200206 011043AOCPL|AA1|AB3999900000001|ACkoha|BON|BIN| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 344, chunk 1. READ: root at 9fb85e7ec5c6:koha(bug_23640)$ perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l CPL --patron 1 --item 3999900000001 -m checkin Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20200206 01104520200206 011045APCPL|AOCPL|AB3999900000001|ACkoha|BIN| READ: 100YNY20200206 011046AOCPL|AB3999900000001|AQCPL|AJE Street shuffle :|CYC4::SIP::SIPServer=HASH(0x55cb126dd0b8)|DAC4::SIP::SIPServer=HASH(0x55cb126dd0b8)|AFItem not checked out| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:11:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:11:51 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #26 from David Cook --- Here's a new better draft test plan: Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev -c "bash misc/bin/sip_run.sh etc/SIPconfig.xml" 2c. If necessary, logs are at /var/lib/koha/kohadev/sip.out and /var/lib/koha/kohadev/sip.err 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check action_logs or circulation logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=1 5. Disable IssueLog 6. Issue another book via SIP 7. Check action_logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:14:49 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #27 from David Cook --- Remembering that koha-testing-docker doesn't have syslog... and the SIP server actually only logs to syslog in practice I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:22:35 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #28 from David Cook --- apt-get install rsyslog koha-shell kohadev -c "bash misc/bin/sip_shutdown.sh" koha-shell kohadev -c "bash misc/bin/sip_run.sh etc/SIPconfig.xml" Now the SIP server won't start... apt-get purge rsyslog apt autoremove And the SIP server still won't start in koha-testing-docker... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:28:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:28:46 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #29 from David Cook --- apt-get install rsyslog service rsyslog start koha-shell kohadev perl C4/SIP/SIPServer.pm etc/SIPconfig.xml (Next in a separate terminal window) root at 9fb85e7ec5c6:koha(bug_23640)$ perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l CPL --patron 1 --item 3999900000001 -m checkout Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPCPL| READ: 940 Login Failed! -- No idea why this is happening now, but at least we have /var/log/messages to look at.... 624 Feb 6 01:25:50 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '9300CNkoha|COkoha|CPCPL' 625 Feb 6 01:25:50 9fb85e7ec5c6 koha_sip[2504]: api_auth failed for SIP terminal 'koha' of 'kohalibrary': maintenance 626 Feb 6 01:25:50 9fb85e7ec5c6 koha_sip[2504]: OUTPUT MSG: '940' 627 Feb 6 01:25:50 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '' 628 Feb 6 01:25:50 9fb85e7ec5c6 koha_sip[2504]: raw_transport: shutting down 629 Feb 6 01:26:31 9fb85e7ec5c6 koha_sip[2504]: raw_transport: shutting down: EOF during login 630 Feb 6 01:26:55 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '9300CNstaff|COstaff|CPCPL' 631 Feb 6 01:26:55 9fb85e7ec5c6 koha_sip[2504]: api_auth failed for SIP terminal 'staff' of 'CPL': maintenance 632 Feb 6 01:26:55 9fb85e7ec5c6 koha_sip[2504]: OUTPUT MSG: '940' 633 Feb 6 01:26:55 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '' 634 Feb 6 01:26:55 9fb85e7ec5c6 koha_sip[2504]: raw_transport: shutting down 635 Feb 6 01:27:13 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '9300CNkoha|COkoha|CPCPL' 636 Feb 6 01:27:13 9fb85e7ec5c6 koha_sip[2504]: api_auth failed for SIP terminal 'koha' of 'kohalibrary': maintenance 637 Feb 6 01:27:13 9fb85e7ec5c6 koha_sip[2504]: OUTPUT MSG: '940' 638 Feb 6 01:27:13 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '' 639 Feb 6 01:27:13 9fb85e7ec5c6 koha_sip[2504]: raw_transport: shutting down 640 Feb 6 01:27:53 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '9300CNkoha|COkoha|CPCPL' 641 Feb 6 01:27:53 9fb85e7ec5c6 koha_sip[2504]: api_auth failed for SIP terminal 'koha' of 'kohalibrary': maintenance 642 Feb 6 01:27:53 9fb85e7ec5c6 koha_sip[2504]: OUTPUT MSG: '940' 643 Feb 6 01:27:53 9fb85e7ec5c6 koha_sip[2504]: INPUT MSG: '' 644 Feb 6 01:27:53 9fb85e7ec5c6 koha_sip[2504]: raw_transport: shutting down -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:30:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:30:27 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #30 from David Cook --- I know it says "maintenance" but it's not in maintenance mode... bloody thing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:36:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:36:53 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #31 from David Cook --- *facepalm* I had rebased my git after starting the docker containers... koha-plack --restart kohadev Now getting into maintenance mode... -- Restart the SIP server: perl C4/SIP/SIPServer.pm etc/SIPconfig.xml And... the SIP server is still not doing the checkin/checkout correctly... and /var/log/messages is showing that the SIP server isn't writing an OUTPUT MSG... but it's not showing any errors either... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:40:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:40:10 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #32 from David Cook --- By the way, this is just "master" without the patch applied... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:48:50 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #33 from David Cook --- Oh so we get /var/log/debug as well... 64 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Configuration::find_service: Trying 6001/tcp 65 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Configuration::find_service: Trying *:6001/tcp 66 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Configuration::find_service: Trying 127.0.0.1:6001/tcp 67 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: raw_transport: timeout is 60 68 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: read_request trimmed 1 character(s) 69 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0', protocol 2 70 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPCPL', 'A1A1', '2', ...) 71 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: login_core: $VAR1 = 'ILS'; 72 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: new ILS 'kohalibrary' 73 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: raw_transport: uname/inst: 'koha/kohalibrary' 74 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: read_request trimmed 2 character(s) 75 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '11YN202002...', '11'): seq.no '0', protocol 2 76 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: Sip::MsgType::_initialize('Checkout', 'YN20200206 01353920200206 013539AOCPL|AA1|AB3999900000001|ACkoha|BON|BIN', 'CCA18A18', '38', ...) 77 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: new ILS::Patron(1): found patron '1' 78 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: new ILS::Item('3999900000001'): found with title 'E Street shuffle :' 79 Feb 6 01:35:39 9fb85e7ec5c6 koha_sip[2819]: ILS::Transaction::Checkout performing checkout... Oh wait the screen output from "perl C4/SIP/SIPServer.pm etc/SIPconfig.xml" is now showing some errors: Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, line 1. Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, line 2. DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 [for Statement "INSERT INTO `issues` ( `auto_renew`, `borrowernumber`, `branchcode`, `date_due`, `issuedate`, `itemnumber`, `onsite_checkout`) VALUES ( ?, ?, ? , ?, ?, ?, ? )" with ParamValues: 0=0, 1=1, 2="kohalibrary", 3='2020-02-11 23:59:00', 4='2020-02-06 01:47:47', 5=1, 6=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836, line 2. So that's just bad config... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:51:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:51:10 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #34 from David Cook --- perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout Finally! Some success! root at 9fb85e7ec5c6:koha(bug_23640)$ perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20200206 01504620200206 015046AOCPL|AA1|AB3999900000001|ACterm1|BON|BIN| READ: 121NNY20200206 015047AOCPL|AA1|AB3999900000001|AJE Street shuffle :|AH20200211 235900| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:57:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:57:42 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #35 from David Cook --- (In reply to Jonathan Druart from comment #23) > Could someone test this patch please? Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev 2c. perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check circulation logs for the item: http://localhost:8081/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=1 5. Disable IssueLog 6. Check in the book and then check it out again perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkin perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 7. Check circulation logs http://localhost:8081/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=1 8. Note results Without the patch, you'll see a 2nd checkout. With the patch, you won't see the 2nd checkout. (Note: After applying the patch, you have to restart the SIP server.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 02:58:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 01:58:21 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #36 from David Cook --- Ok I think my newest test plan is just bad... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 03:06:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 02:06:44 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 03:06:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 02:06:47 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95415|0 |1 is obsolete| | --- Comment #37 from David Cook --- Created attachment 98515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98515&action=edit Bug 23640: Flushing L1 on every SIP connection This patch flushes the L1 cache on each SIP connection (ie every invocation of process_request). This means each SIP connection will fetch values from the L2 cache (ie memcached) and persist the L1 cache (in Perl memory cache) only until a new SIP connection comes in. Without this patch, the L1 cache persists for the length of the server process, which means the L1 cache will become stale very quickly, which can lead to unexpected behaviour. Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev 2c. perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 5. Disable IssueLog 6. Check in the book and then check it out again perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkin perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 7. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 8. Note results Without the patch, you'll see a 2nd checkout. With the patch, you won't see the 2nd checkout. (Note: After applying the patch, you have to restart the SIP server.) Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 03:08:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 02:08:10 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #38 from David Cook --- (Apologies for all the comments. Quite the stream-of-consciousness for troubleshooting the SIP server and SIP client simulator...) Jonathan's patch worked beautifully, once I was able to arrive at a good test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 04:20:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 03:20:07 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #23 from Hugo Agud --- just one question will be this bug backported to 19.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:43:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:43:31 +0000 Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563 --- Comment #2 from Govind Basedia --- Yes Sir I am enable Usekoha plug in and conf.xml file enable . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:52:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:52:40 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:52:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:52:43 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95849|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 98516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98516&action=edit Bug 21177: Use koha-conf.xml in misc/devel/update_dbix_class_files.pl It is annoying to have to specify database connection parameters each time DBIx::Class files need to be updated. This patch adds a new option --koha-conf that takes an optional which defaults to the value of KOHA_CONF environment variable, and use the database connection parameters found in that file. --db_* options override values from $KOHA_CONF Test plan: 1. Run the script with the same parameters as before the patch and see that it still works. Example: misc/devel/update_dbix_class_files.pl --db_name koha_dev \ --db_user koha --db_pass koha 2. Verify that KOHA_CONF is set and execute: misc/devel/update_dbix_class_files.pl --koha-conf Verify that Koha/Schema files were updated accordingly 3. Execute: misc/devel/update_dbix_class_files.pl --koha-conf \ /path/to/another/koha-conf.xml Verify that Koha/Schema files were updated accordingly Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:52:57 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:52:57 +0000 Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:54:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:54:41 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #14) > (In reply to Marcel de Rooy from comment #13) > > Back to SO for now. Next week things will be better ;) > > Ping Marcel? :) A typical Koha week ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:56:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:56:29 +0000 Subject: [Koha-bugs] [Bug 24581] DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- First I would like to highlight that Buster is not yet supported and there are known bugs, including security ones, which we are currently working to resolve. I strongly recommend against using Buster for Koha right now. I've not seen this particular error in question, but it feels like a DB update has not taken place.. have you run updatedatabase yet? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 08:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 07:56:44 +0000 Subject: [Koha-bugs] [Bug 24581] DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.privacy_guarantor_fines' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 92 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:01:31 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 --- Comment #7 from Magnus Enger --- (In reply to Josef Moravec from comment #6) > What if there is repeated subfield with same code in one field? Then only > first one is taken into account. I do think we want to count on all of > them... Gah, how did I miss that? I'll update the patch. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:52:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:52:41 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98508|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 98517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98517&action=edit Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:52:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:52:59 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:53:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:53:41 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- This is a simple partial revert to restore functionality.. Passing QA. Lets handle the final removal of those controllers and switch to REST apis as a separate issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:53:46 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:55:35 +0000 Subject: [Koha-bugs] [Bug 24599] New: Add endpoints for bulk processing of holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 Bug ID: 24599 Summary: Add endpoints for bulk processing of holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com As highlighted by bug 24410, we need a way to handle bulk submission of holds via the API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:55:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:55:44 +0000 Subject: [Koha-bugs] [Bug 24599] Add endpoints for bulk processing of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 [Bug 24410] Multi holds broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:55:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:55:44 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 [Bug 24599] Add endpoints for bulk processing of holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:55:56 +0000 Subject: [Koha-bugs] [Bug 24599] Add endpoints for bulk processing of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 09:58:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 08:58:40 +0000 Subject: [Koha-bugs] [Bug 18501] Automatic refunds need protection from failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- I'm wondering if Alex ever actually worked on this? If so, it would be good to see some patches, if not please can you unassign yourself so it may be re-assigned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:00:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:00:54 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98489|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 98518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98518&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490 at FQDN> 6) Sign off. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:01:53 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Works as expected, no regressions found and it moves us closer to the ever-moving target that is 'email best practice'. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:13:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:13:12 +0000 Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #7 from Martin Renvoize --- The bug here was inadvertently fixed by bug 22982 in which a check on amountoutstanding was introduced. We should still short-circuit the loop at some point to prevent needless processing, but at this point that change is now an architectural enhancement rather a major bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:19:08 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:19:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:19:19 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:19:22 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98266|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 98519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98519&action=edit Bug 24554: Only embed relations from Koha::Biblio in to_api This patch simplifies the behaviour of Koha::Biblio->to_api. It was designed with the idea of handling possible methods that would be added to Koha::Biblioitem. But it had a weird fallback behaviour was highlighted by using it with bug 24528. On fixing it it become obvious that it was unnessessarily complex and that it was not worth. That's the reason there wasn't any test for it, as Koha::Biblioitem doesn't implement any extra methods. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:30:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:30:02 +0000 Subject: [Koha-bugs] [Bug 20626] Fines are recalculated and removed on SIP checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- I believe this was fixed as part of bug 14591 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:33:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:33:09 +0000 Subject: [Koha-bugs] [Bug 20766] KohaPlugins.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20766 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |martin.renvoize at ptfs-europe | |.com Assignee|chris at bigballofwax.co.nz |kyle at bywatersolutions.com --- Comment #3 from Martin Renvoize --- I'm not sure what the state of this one is, but it feels like we can de-escalate it.. It's a 'nice to fix', but not a major issue as it only effects developers doing regular testing rather than causing major issues to end users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:56:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:56:17 +0000 Subject: [Koha-bugs] [Bug 24600] New: 1885 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24600 Bug ID: 24600 Summary: 1885 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: leena at nbri.res.in QA Contact: testopia at bugs.koha-community.org DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied for user 'koha_library'@'localhost' (using password: YES) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at /usr/share/koha/lib/Koha/Database.pm line 107 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 10:58:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 09:58:05 +0000 Subject: [Koha-bugs] [Bug 24600] 1885 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24600 Leena Wahi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leena at nbri.res.in Priority|P5 - low |P1 - high Keywords| |regression URL| |127.0.0.1:8080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:08:52 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:23:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:23:13 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #9 from Ulrich Kleiber --- Thanks Martin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:26:53 +0000 Subject: [Koha-bugs] [Bug 24600] 1885 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Leena, there is not enough information on this bug report in order to help you und it looks like a configuration/installation issue, as Koha is not able to connect to your database. Please ask on the mailing list instead and tell us the steps that led to this error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:33:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:33:35 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:33:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:33:44 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #16 from Jonathan Druart --- Created attachment 98520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98520&action=edit Bug 24526: Add the confirm flag to the cronjob files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:42:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:42:32 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #8 from Jonathan Druart --- (In reply to Julian Maurice from comment #7) > The downside is that it will cause git conflicts, so we should probably have > to do something similar to updatedatabase (atomicupdate) > > We can also consider having a DeveloperChangeLog.md to avoid polluting the > main changelog too much with technical details. Developers can add their own ChangeLog entries in the commit message or the "Text to go in the release notes", then the RM move it to ChangeLog.md -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 11:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 10:44:55 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:02:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:02:23 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:03:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:03:32 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:03:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:03:49 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:04:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:04:06 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:04:21 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:10:47 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #32 from Andrew Isherwood --- Created attachment 98521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98521&action=edit Bug 23173: (follow-up) Allow for wide characters The conversion of the metadata into Base64 for passing in the API call to the plugin API routes was failing if the metadata contained a wide character, so we now encode it into UTF-8 first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:21:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:21:17 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:22:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:22:17 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #9 from Jonathan Druart --- Should we have: * dev (.06, .12) versions in unreleased? * 1 entry per "version" (ie. our DB versioning), or per important bug report, per action (Add/Remove/Move), or even per "entity" (pref, db, new feature) ? * Some possible examples: Example 1: #Changelog ## [19.12.00.002] - 2019-12-16 ### Added - pref NewPref added by bug 12345 ### Removed - DB column removed by bug 23456 ## [19.12.00.001] - 2019-12-09 ### Removed - Pref removed by bug 11233 ## [19.11.00.000] - 2019-11-27 Example 2: #Changelog ## [Unreleased] ### Added - pref NewPref added by bug 12345 ### Removed - DB column removed by bug 23456 - Pref removed by bug 11233 ## [19.12.00] - 2019-11-27 Example 3: #Changelog ## [Unreleased] ### Bug 12345 [- with push date?] - This does something great - Added NewPref ### Bug 23456 - Removed DB column ### Bug 11233 - Removed Pref ## [19.12.00] - 2019-11-27 Example 4: #Changelog ## [Unreleased] ### Prefs - Added NewPref by bug 12345 - Removed Pref by bug 11233 ### DB structure - Removed DB column by bug 23456 ## [19.12.00] - 2019-11-27 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:22:23 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:27 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97114|0 |1 is obsolete| | Attachment #97115|0 |1 is obsolete| | Attachment #97116|0 |1 is obsolete| | Attachment #97470|0 |1 is obsolete| | Attachment #97471|0 |1 is obsolete| | Attachment #98280|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 98522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98522&action=edit Bug 24161: DB changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:31 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #14 from Jonathan Druart --- Created attachment 98523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98523&action=edit Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:35 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #15 from Jonathan Druart --- Created attachment 98524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98524&action=edit Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:39 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #16 from Jonathan Druart --- Created attachment 98525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98525&action=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:43 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #17 from Jonathan Druart --- Created attachment 98526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98526&action=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:28:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:28:47 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #18 from Jonathan Druart --- Created attachment 98527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98527&action=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:35:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:35:12 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #10 from Julian Maurice --- (In reply to Jonathan Druart from comment #8) > Developers can add their own ChangeLog entries in the commit message > or the "Text to go in the release notes", then the RM move it to ChangeLog.md In my opinion, commit messages and changelogs have different goals. Commit messages should contain a detailed description of a change, especially what cannot be found in the diff (things like why it is needed, why it has been implemented that way, alternatives that have been considered, benchmarks, ...). Changelogs should contain a summary of what changed. "Text to go in the release notes" is fine I guess, and not really different from what I had in mind (a .md file per bug in changelog.d/) What is the most convenient for the release team ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 12:53:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 11:53:08 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #11 from Julian Maurice --- (In reply to Jonathan Druart from comment #9) > * Some possible examples: I'd eliminate example 1 because DB versions are not released versions. I'd also eliminate example 3 because as a changelog reader I'm more interested in "categories of changes" (security fixes, new features, breaking change, ...) than in "what this particular bug changed" Examples 2 and 4 are very similar and only differ in the list of categories. I'd go with something like this: ### Added (new features) ### Changed (enhancements) ### Fixed (bugfixes) ### Security (security fixes) ### Sysprefs (new, renamed, deleted sysprefs) ### Dependencies (new, updated, deleted Perl dependencies) ### REST API (new, renamed, deleted API routes and parameters) ### Database structure (new, renamed, deleted tables and columns) ### Perl API (new, renamed, deleted Perl modules and subroutines) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:12:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:12:44 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Failed QA --- Comment #12 from Bernardo Gonzalez Kriegel --- Sorry, does not apply, conflicts in C4/Items.pm C4/OAI/Sets.pm C4/Search.pm admin/searchengine/elasticsearch/mappings.pl also a few more cases. C4/OAI/Sets.pm: if(0 == grep /^$value$/, @subfield_values) { C4/OAI/Sets.pm: if(0 < grep /^$value$/, @subfield_values) { misc/translator/translate: if ( $cmd ne 'create' and $lang and not grep( /^$lang$/, @{ $installer->{langs} } ) ) { t/db_dependent/Acquisition.t: unless grep ( /^$field$/, @$exp_fields ); t/db_dependent/Budgets.t: my $is_in_new_budgets = grep /^$budget->{budget_id}$/, @new_budget_ids; t/db_dependent/Budgets.t: my $is_in_old_budgets = grep /^$budget->{budget_id}$/, @old_budget_ids; t/db_dependent/Serials.t:my @arrived_missing = map { my $status = $_->{status}; ( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? $_ : () } @serials; t/db_dependent/Serials.t:my @others = map { my $status = $_->{status}; ( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? () : $_ } @serials; t/db_dependent/Serials.t:@arrived_missing = map { my $status = $_->{status}; ( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? $_ : () } @serials; t/db_dependent/Serials.t:@others = map { my $status = $_->{status}; ( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? () : $_ } @serials; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:34:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:34:01 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95950|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 98528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98528&action=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:34:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:34:05 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95951|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 98529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98529&action=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:34:09 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95952|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 98530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98530&action=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:34:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:34:34 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #39 from Martin Renvoize --- Back to signed off.. I can't replicate the issues either.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:37:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:37:46 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:37:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:37:50 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #29 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:37:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:37:53 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:37:55 +0000 Subject: [Koha-bugs] [Bug 24410] Multi holds broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:37:57 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:38:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:38:01 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:39:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:39:07 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:39:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:39:11 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98383|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:39:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:39:28 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 13:40:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 12:40:41 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:16:35 +0000 Subject: [Koha-bugs] [Bug 24601] New: Catalogue detail table last seen date not sorting correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24601 Bug ID: 24601 Summary: Catalogue detail table last seen date not sorting correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: emmi.takkinen at outlook.com QA Contact: testopia at bugs.koha-community.org On catalogue/detail.pl items table "Last seen" column is sorted based on day of month not the whole date. There is no difference between different dateformats eg. DD.MM.YYYY or MM/DD/YYYY. Column "Date accessioned" however sorts correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:20:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:20:55 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:20:58 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #3 from Nick Clemens --- Created attachment 98531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98531&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:35:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:35:09 +0000 Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification or deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Broken link to return to |Broken link to return to |record after batch item |record after batch item |modification |modification or deletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:35:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:35:46 +0000 Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification or deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 --- Comment #11 from Andrew Fuerste-Henry --- Updated the title of this bug to reflect the fact that it also impacts batch item deletion. The patch fixes that, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 14:58:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 13:58:57 +0000 Subject: [Koha-bugs] [Bug 23581] Do not fill hold when patron account has overdues/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23581 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team University Lyon 3 --- I agree and it should also check if patron have restriction (after a suspension in days). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:08:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:08:22 +0000 Subject: [Koha-bugs] [Bug 24602] New: The fallback value for onshelfholds should be 0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Bug ID: 24602 Summary: The fallback value for onshelfholds should be 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:09:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:09:44 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #10 from Bernardo Gonzalez Kriegel --- This works well, but qa-tool shows an error: Processing files before patches |========================>| 7 / 7 (100.00%) Processing files after patches |===> | 1 / 7 (14.29%) An error occurred : Unmatched [ in regex; marked by <-- HERE in m/_\(\(?[ <-- HERE ^\]*)\\)/ at /.../qa-test-tools/QohA/File/JS.pm line 29. Is this a false positive? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:11:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:11:54 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #11 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > This works well, but qa-tool shows an error: > > Processing files before patches > |========================>| 7 / 7 (100.00%) > Processing files after patches > |===> | 1 / 7 (14.29%) > > An error occurred : Unmatched [ in regex; marked by <-- HERE in > m/_\(\(?[ <-- HERE ^\]*)\\)/ at /.../qa-test-tools/QohA/File/JS.pm > line 29. > > Is this a false positive? Yes, definitely, I am going to open an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:15:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:15:03 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > (In reply to Bernardo Gonzalez Kriegel from comment #10) > > This works well, but qa-tool shows an error: > > > > Processing files before patches > > |========================>| 7 / 7 (100.00%) > > Processing files after patches > > |===> | 1 / 7 (14.29%) > > > > An error occurred : Unmatched [ in regex; marked by <-- HERE in > > m/_\(\(?[ <-- HERE ^\]*)\\)/ at /.../qa-test-tools/QohA/File/JS.pm > > line 29. > > > > Is this a false positive? > > Yes, definitely, I am going to open an issue. https://gitlab.com/koha-community/qa-test-tools/issues/23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:03 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 98532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98532&action=edit Bug 24602: Tests for get_onshlefholds_policy Ths patch introduces tests for get_onshelf_policy. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t => FAIL: Tests fail because the current code returns undef instead of 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:07 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 98533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98533&action=edit Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:12 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22982 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:12 +0000 Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:31 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:19:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:19:31 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 [Bug 24602] The fallback value for onshelfholds should be 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:20:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:20:31 +0000 Subject: [Koha-bugs] [Bug 24603] New: Allow to cancel charges in patron accounting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Bug ID: 24603 Summary: Allow to cancel charges in patron accounting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org There is already a button to void a payment. It should be possible to cancel a charge too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:21:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:21:01 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #1 from Julian Maurice --- Created attachment 98534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98534&action=edit Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:21:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:21:13 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:22:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:22:50 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97346|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 98535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98535&action=edit Bug 21156: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian jessie, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr-FR-messages-js.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side Signed-off-by: Martin Renvoize Signed-off-by: Bernardo Gonzalez Kriegel Works well, translation is Ok and test message is displayed correctly. Current qa-tool error is a false positive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:30:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:30:15 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 --- Comment #2 from Jonathan Druart --- Created attachment 98536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98536&action=edit Bug 24131: Move the print statement to a new subroutine -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:30:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:30:20 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 --- Comment #3 from Jonathan Druart --- Created attachment 98537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98537&action=edit Bug 24131: Handle several descriptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:33:16 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- What did you have in mind exactly? It will be hard to make things flexible as we are using a log file to write the output of the script. I have the feeling that if we want flexibility we will need to move stuff to a module. Maybe also use a DB table to keep track of the upgrades and errors? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:35:16 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #12) ... > > Yes, definitely, I am going to open an issue. > > https://gitlab.com/koha-community/qa-test-tools/issues/23 Good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:42:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:42:59 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- I'm going to take that second signoff from Bernardo as a PQA as the resident translation expert. I found no regressions in my own testing and am confident in the change.. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:43:07 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:48:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:48:10 +0000 Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 15:54:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 14:54:12 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #18 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:03:13 +0000 Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:20:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:20:51 +0000 Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- unit tests do not apply cleanly to 19.05.x branch, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:25:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:25:28 +0000 Subject: [Koha-bugs] [Bug 24604] New: Add 'Pay' button under Transactions tab in patron accounting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 Bug ID: 24604 Summary: Add 'Pay' button under Transactions tab in patron accounting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:26:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:26:02 +0000 Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 --- Comment #1 from Julian Maurice --- Created attachment 98538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98538&action=edit Bug 24604: Add 'Pay' button under Transactions tab in patron accounting It does the same thing as the 'Pay' button under 'Make a payment' tab. It is nothing more than a shortcut. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:26:23 +0000 Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 16:37:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 15:37:38 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #19 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:04:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 16:04:28 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 --- Comment #3 from Andrew Fuerste-Henry --- Some conditions that could cause this were eliminated in bug 22982, which was backported into 19.05.01. However, I've got an example from a lost item payment made in 19.05.06. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:08:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 16:08:12 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:10:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 16:10:40 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage and update MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:11:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 16:11:02 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 17:24:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 16:24:48 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:01:56 +0000 Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:14:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:14:24 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:21:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:21:59 +0000 Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification or deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:26:47 +0000 Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:42:06 +0000 Subject: [Koha-bugs] [Bug 24605] New: Series link from 830 is not uri encoded Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Bug ID: 24605 Summary: Series link from 830 is not uri encoded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Missed one on bug 14716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:50:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:50:43 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:50:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:50:45 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 --- Comment #1 from Nick Clemens --- Created attachment 98539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98539&action=edit Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:52:11 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14716 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 18:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 17:52:11 +0000 Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 [Bug 24605] Series link from 830 is not uri encoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:00:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 18:00:58 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 18:26:42 +0000 Subject: [Koha-bugs] [Bug 24606] New: Allow storing item values as a template for creating new items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Bug ID: 24606 Summary: Allow storing item values as a template for creating new items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This is a feature developed by Kyle...elsewhere... Would need to be reworked to fit into modern Koha https://github.com/liblime/LibLime-Koha/commit/ac11f3d86772891e605b58ab7b5d9eac3be5b605 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:37:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 18:37:16 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03 released in|19.05.08 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 19:38:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 18:38:38 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #15 from Lucas Gass --- this patchset has been reverted from 19.05.x as it has been problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 20:14:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 19:14:36 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #66 from Tomás Cohen Arazi --- I tested this branch (which Jonathan rebased against master) and: - Some tests were failing due to old and new rebase issues: fixed! - Some typos in controllers and libs: fixed! I'm not 100% comfortable with the legacy approaches to avoid regressions, but I AGREE they are better than breaking things in large scale. This way we can start writing the API for items in a way that we are sure will preserve behaviour, one page at a time, so all good! I tested: STAFF - Search results - Detail view - Edit/add/delete items - Circulation, placing holds - Course reserves - Acquisition workflows - Batch item modification - Batch item deletion OPAC - Course reserves - Search results, detail view - Reading history - Shelf browser I'm confident about this patchset at this stage. Jonathan: please add my signature to your branch's commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:02:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 20:02:21 +0000 Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:12:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 20:12:14 +0000 Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item, even if it is checked out to a different patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 21:27:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 20:27:10 +0000 Subject: [Koha-bugs] [Bug 24485] AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 21:17:35 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- backported to 19.05.x for 19.05.08. backporting this without the bz21073 dependency after speaking with Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:21:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 21:21:40 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00, 19.05.08 released in| | --- Comment #27 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:21:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 21:21:50 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:37:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 21:37:11 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.03 released in| | Status|Passed QA |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #18 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 22:48:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 21:48:44 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User should know when they |Show message on OPAC |are blocked from checkouts |summary if checkouts |on OPAC + Translatability |blocked due to fines |fixes for OPAC Summary page | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:27:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:27:37 +0000 Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #13 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:27:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:27:37 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:27:38 +0000 Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug 23990 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:27:38 +0000 Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 Bug 24419 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:27:38 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Bug 24430 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:28:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:28:20 +0000 Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #9 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:28:21 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24419, which changed state. Bug 24419 Summary: Add Koha::Suggestion->suggester accessor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:02 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #16 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:02 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Bug 17628 depends on bug 24430, which changed state. Bug 24430 Summary: Remove C4::Biblio::CountBiblioInOrders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:02 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24430, which changed state. Bug 24430 Summary: Remove C4::Biblio::CountBiblioInOrders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:03 +0000 Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Bug 24435 depends on bug 24430, which changed state. Bug 24430 Summary: Remove C4::Biblio::CountBiblioInOrders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:03 +0000 Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Bug 24467 depends on bug 24430, which changed state. Bug 24430 Summary: Remove C4::Biblio::CountBiblioInOrders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:05 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:08 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49516|0 |1 is obsolete| | Attachment #63710|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia --- Created attachment 98540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98540&action=edit Bug 15775: Show message on OPAC summary if checkouts blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from checkouts and holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:36 +0000 Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #8 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:36 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24435, which changed state. Bug 24435 Summary: Add Koha::Biblio->items_count https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:29:36 +0000 Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Bug 24467 depends on bug 24435, which changed state. Bug 24435 Summary: Add Koha::Biblio->items_count https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:30:19 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #21 from Aleisha Amohia --- This patch had gotten a little messy and looks like much of the content of the patch has now been dealt with in master, so I've written a new patch to deal simply with the bug title. Ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:30:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:30:56 +0000 Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 --- Comment #20 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:31:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:31:49 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #64 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:34:10 +0000 Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #19 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:41:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:41:32 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47275|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 98541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98541&action=edit Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:42:22 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:42:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:42:26 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64943|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 98542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98542&action=edit Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:42:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:42:49 +0000 Subject: [Koha-bugs] [Bug 24481] Incorrect permission in admin/cash_registers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #16 from Joy Nelson --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:42:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:42:49 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Bug 23355 depends on bug 24481, which changed state. Bug 24481 Summary: Incorrect permission in admin/cash_registers.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:44:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:44:04 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #15 from Thomas Dukleth --- As is well known, databases such as MySQL and Postgres do not have any magical diff friendly dump which would have appropriate granularity to use in an automated comparison to find any actual problem without being overwhelmed with noise from necessary differences between databases where the essential data is the same for relevant columns but where there are necessary database specific differences such as an extra indexing column, etc. Similar to what I had done for some part of debugging the Python script for the database migration, I am working on API based automated select of for every column and every row to write out each row equivalent of data between the two databases so that actual data is compared with appropriate granularity and not whole rows. Such an approach should be helpful to automatically check that the migrated data is complete and spot any unlikely but possible issues, such as with encoding of names from CJK languages which some users have, which would never be a problem for true UTF8 in Postgres but for which the MediaWiki solution to historic MySQL 3 byte limit for MySQL uft8 character set encoding is using binary data type for MySQL columns. [Encoding differences have been well addressed by insertion to MediaWiki supported binary data type columns for use in MySQL some time ago as will be explained retrospectively in a more detailed comment complete with references to an old version Debian time machine allowing the MySQL database to be created correctly for where we landed with MediaWiki when apprehending the database choice mistake.] The issue here is about an automated test for data comparison in which data has been read from both the originating Postgres database and the migrated MySQL database, then granularly saved in full UTF8 for diff comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:44:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:44:47 +0000 Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #16 from Joy Nelson --- does not apply to 19.11.x. Not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:46:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:46:05 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Catherine E. Ingram changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Catherine E. Ingram --- (In reply to Agustín Moyano from comment #27) > (In reply to Catherine E. Ingram from comment #21) > > We were playing around with it this morning and wondered about roll out. > > The way it looked in the sandbox was that it would default to all existing > > patrons getting NO notices (with both email and digest un-checked). Did > > anyone else encounter this? > > ~Catherine > > Hi Catherine, you were right.. I believed that if I didn't add that > preference on patrons that already had preferences setted, Koha would break, > but it didn't happen at the end. > > Thanks for spotting that out. > > Can you please try it out again? > > Thanks. Hi Agustín, We have tested the latest patch you have submitted. After applying the patch, we notice that all patrons will have Auto Renewals UNCHECKED for both Email and Digest. This means NO Auto Renewal communication after we apply the patch. This is a problem, because patrons will suddenly stop receiving all Auto Renewal communication unless they re-configure their preferences individually. Can we request that the patch updates ALL patrons to have both Email and Digest CHECKED for the Auto Renewal function? Thank you! Catherine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:50:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:50:48 +0000 Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #13 from Joy Nelson --- does not apply to 19.11.x not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:50:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:50:49 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Bug 20936 depends on bug 24432, which changed state. Bug 24432 Summary: order_by broken for date columns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:55:04 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #9 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:55:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:55:17 +0000 Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:57:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:57:42 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com --- Comment #51 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:57:43 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 18731, which changed state. Bug 18731 Summary: Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:57:43 +0000 Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent class implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 Bug 24457 depends on bug 18731, which changed state. Bug 18731 Summary: Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:57:43 +0000 Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params through In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459 Bug 24459 depends on bug 18731, which changed state. Bug 18731 Summary: Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:57:43 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Bug 24462 depends on bug 18731, which changed state. Bug 18731 Summary: Add routes for acquisition orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:58:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:58:05 +0000 Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent class implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Joy Nelson --- Missing dependencies in 19.11.x not backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:58:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:58:06 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24457, which changed state. Bug 24457 Summary: K::A::Basket->to_api is not passing the parameters to the parent class implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 6 23:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 22:58:41 +0000 Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params through In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #8 from Joy Nelson --- dependencies lacking in 19.11.x not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:00:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:00:27 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #9 from Joy Nelson --- Missing dependency, not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:04:10 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #9 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:04:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:04:27 +0000 Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:04:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:04:44 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #14 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:05:35 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #52 from David Cook --- This is still on my todo list but just haven't had the time yet... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:21:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:21:47 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #31 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:23:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:23:14 +0000 Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:24:49 +0000 Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:25:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:25:03 +0000 Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:25:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:25:21 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:25:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:25:51 +0000 Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Joy Nelson --- Enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:25:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:25:51 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Bug 23355 depends on bug 24478, which changed state. Bug 24478 Summary: Make it possible to deactivate point of sale https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:26:38 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Joy Nelson --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:26:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:26:39 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Bug 24151 depends on bug 24149, which changed state. Bug 24149 Summary: Add new Koha::Statistic[s] classes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:53:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:53:34 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98353|0 |1 is obsolete| | Attachment #98354|0 |1 is obsolete| | --- Comment #20 from Agustín Moyano --- Created attachment 98543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98543&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:53:39 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #21 from Agustín Moyano --- Created attachment 98544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98544&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 00:57:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Feb 2020 23:57:38 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #22 from Agustín Moyano --- Patches didn't apply so rebased this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:26:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 01:26:25 +0000 Subject: [Koha-bugs] [Bug 11268] Biblioitems URL field is too small for some URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11268 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- Hurray! Glad to see this was changed to long ago. Looks like items.uri is still stuck at 255 characters, but I'll open up a separate bug report for that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:36:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 01:36:03 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- biblioitems.url now uses MEDIUMTEXT However, I don't think items.uri necessarily need to be the same as biblioitems.url. With biblioitems.url, multiple URLs are concatenated in the same field, but items.uri should only ever store 1 URL. This link presents a number of different length limits for 1 URL: https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers The largest CloudFlare seems to support is 32Kb and a TEXT field can store 64KB. I suppose using MEDIUMTEXT could provide some future proofing, but TEXT is probably good enough for items.uri. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 01:36:50 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix adds CASH as an release notes| |authorized value for | |PAYMENT_TYPES. This is | |required for the new cash | |register feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:51:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 01:51:09 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 02:51:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 01:51:13 +0000 Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if checkouts blocked due to fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98540|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 98545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98545&action=edit Bug 15775: Show message on OPAC summary if checkouts blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from checkouts and holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 07:24:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 06:24:05 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92867|0 |1 is obsolete| | --- Comment #53 from Mason James --- Created attachment 98546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98546&action=edit Bug 13193: Make Memcached usage fork safe update debian/control file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 07:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 06:25:25 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92931|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 07:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 06:26:54 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92867|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 07:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 06:27:52 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 07:33:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 06:33:00 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #54 from Mason James --- (In reply to Joonas Kylmälä from comment #43) > Martin, oh noes, the dependency was not added yet to the Koha repositories? > This needs to be reverted? hi folks, i've added this module to the KC repo # cat /etc/apt/sources.list.d/koha.list deb http://debian.koha-community.org/koha stable main # apt-cache policy libcache-memcached-fast-safe-perl libcache-memcached-fast-safe-perl: Installed: (none) Candidate: 0.06-1~koha1 Version table: 0.06-1~koha1 0 500 http://debian.koha-community.org/koha/ stable/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:35:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 08:35:43 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #55 from Joonas Kylmälä --- The fix looks good but commit message title doesn't tell what the bug does (https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2). Mason, if you could just move the "update debian/control file" to the title and maybe add a body describing why it needed to be updated would be great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:37:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 08:37:07 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #56 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #55) > The fix looks good but commit message title doesn't tell what the bug does oh, I was supposed to write it doesn't tell what the patch does. The problem is that it tells what the bug is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 09:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 08:50:21 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #12 from David Nind --- This all works as expected for the file name changes - with the default of marc, and when changing the file name. However, the content when authority records are exported as XML is in MARC format, rather than XML (this works correctly before the patch is applied). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:03:21 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #12 from Martin Renvoize --- I still think maintaining this inside Bugzilla and pulling it into a changelog.md file for each release is the way to go... I'd maintain it in a file with every commit/patchset if we were only supporting one definitive version/branch of Koha but as we're continually supporting at least 3 versions in parallel I think ensuring it's properly chronological would be difficult in commits.. An example would be with almost any bug.. it's is the rmaints decision whether the bug is a required backport and as such the RM doesn't know at the time of his/her push what version this bug is going to appear in.. as such they would put it under their version, and when the rmaints backported the rm would then need to forward port a second patch to get move the change down the changelog to get the chronology right again. By maintaining this in bugzilla we already have scripts to add koha version into the relevant fields at the time of push and also have tools that pull out the release notes fields for release note built at release.. so we could have a clear way of getting the chronology correct at release time. As for the format, the keepachangelog seems great to me.. I wouldn't be against having two distinct fields in bugzilla.. one for librarian facing release notes and one for developer-facing notes as they're often rather different use cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:05:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:05:27 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #13 from Martin Renvoize --- In fact, I'd go so far as to say it might be nice to filter out a fair bit of the existing data that goes into the release notes.. I don't think librarian end users actually need/want to see a record of every single 'bug' that's made it into a release.. especially at the moment whilst there's lots of architectural bugs going in that don't really affect end users. By having the two distinct fields we could more easily direct the information to the right people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:29:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:29:58 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98187|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 98547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98547&action=edit Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:30:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:30:01 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #5 from Martin Renvoize --- Created attachment 98548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98548&action=edit Bug 24525: (follow-up) Factor out to an include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:31:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:31:07 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #6 from Martin Renvoize --- Followup as requested.. I should just have done it this way in the first place :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:41:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:41:27 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #14 from Julian Maurice --- (In reply to Martin Renvoize from comment #12) > I still think maintaining this inside Bugzilla and pulling it into a > changelog.md file for each release is the way to go... I'd maintain it in a > file with every commit/patchset if we were only supporting one definitive > version/branch of Koha but as we're continually supporting at least 3 > versions in parallel I think ensuring it's properly chronological would be > difficult in commits.. > > An example would be with almost any bug.. it's is the rmaints decision > whether the bug is a required backport and as such the RM doesn't know at > the time of his/her push what version this bug is going to appear in.. as > such they would put it under their version, and when the rmaints backported > the rm would then need to forward port a second patch to get move the change > down the changelog to get the chronology right again. I don't think the forward port would be needed. Each stable branch would have its own changelog. For instance, if you are on 19.11.x Changelog would contain: # Unreleased - bugfix X - ... # 19.11.01 - bugfix Y - ... #19.11.00 And on master you would have # Unreleased - bugfix X - bugfix Y - ... # 19.11.00 I think it would be confusing to have bugfixes referenced twice or more in the same file (once for master, once for stable, once for oldstable, ...). Stable branches live their own life and I think it's ok if only them contain the changes for minor releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:50:28 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #15 from Martin Renvoize --- I don't think I explained myself well.. you've actually basically highlighted my point. I don't want bugs to appear twice at all.. I'd want them to appear once and only once and at the earliest point that they were added to the codebase. I'm thinking of upgrades from one mid-point release.. say a 17.05.04 to another mid-point release in the next major version, say 18.11.08. The Changelog should simply list all changes between those two versions in order and you shouldn't have to refer to different files from the different branches. Does that make more sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:53:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:53:20 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.11.00,19.05.04 |19.11.00,19.05.04, 18.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:53:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:53:41 +0000 Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:53:45 +0000 Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98538|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98549&action=edit Bug 24604: Add 'Pay' button under Transactions tab in patron accounting It does the same thing as the 'Pay' button under 'Make a payment' tab. It is nothing more than a shortcut. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:57:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:57:28 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #57 from Martin Renvoize --- Sorry Joonas, I think I've confused the issue here.. Mason just did the packaging of the requisit dependancy for me at my request.. the bug itself was already PQA. You are indeed correct regarding the commit message of the followup.. but I'll just fix that on push now we have the dependancy packaged and on our repository. Many thanks for taking a look though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:59:03 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 10:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 09:59:06 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98546|0 |1 is obsolete| | --- Comment #58 from Mason James --- Created attachment 98550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98550&action=edit Bug 13193: Add new module to debian/control file this patch adds the new module to the debian/control file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:01:02 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:01:08 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:01:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:01:23 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:01:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:01:25 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #59 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:06:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:06:52 +0000 Subject: [Koha-bugs] [Bug 24607] New: XSLT output should be listed in MARC tag order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Bug ID: 24607 Summary: XSLT output should be listed in MARC tag order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be useful if the (e.g.) MARC21slim2OPACDetail.xsl template displayed the fields in numeric MARC tag order, for example 100, 110, 245, 246, 260, 300, etc. At the moment, it seems fairly random, e.g. 505, 583, 508, 586, 773, 511 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:08:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:08:14 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #16 from Julian Maurice --- (In reply to Martin Renvoize from comment #15) > Does that make more sense? Yep. After re-reading your original comment I see what I misunderstood. Sorry :) But still... there is no "earliest point" for a particular bug. We have several different timelines. Let's take an example: - I install Koha 19.11.00 on release day - I wait a few months, in the meantime bugfixes are backported to 19.11.x, some of which are also backported to 19.05.x. - On the next 19.11.x release, changelog entries for bugs that have been pushed to 19.05.x are moved down to the corresponding 19.05.x release. - Now I want to update and see what changed between 19.11.00 and 19.11.06. Problem: the changelog will not be complete because some entries are under 19.05.x section instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:17:35 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #17 from Julian Maurice --- (In reply to Martin Renvoize from comment #13) > In fact, I'd go so far as to say it might be nice to filter out a fair bit > of the existing data that goes into the release notes.. I don't think > librarian end users actually need/want to see a record of every single 'bug' > that's made it into a release.. especially at the moment whilst there's lots > of architectural bugs going in that don't really affect end users. I did not answer to that, but I totally agree with you. I'm not sure if we should have several changelog/release notes for specific audience, but each different kind of users (end-users, sysadmins, developers, ...) should be able to find useful infos quickly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:26:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:26:40 +0000 Subject: [Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:27:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:27:34 +0000 Subject: [Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi David, I am not sure if this would work a general rule - an example would be the 700, 710, 711, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:29:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:29:52 +0000 Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #12 from David Nind --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:30:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:30:00 +0000 Subject: [Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 --- Comment #2 from David Roberts --- No, I agree that the 1XX and 7XX fields are currently a complication that might make it difficult to implement 100%. I still think that it is expected that the fields are in the correct order though, and librarians new to Koha often query why this is not the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:31:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:31:44 +0000 Subject: [Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 --- Comment #3 from Fiona Borthwick --- I have just completed training for a new customer and they requested that the 700 fields display after the 650 Subjects and questioned why some other fields seemed to be out of numerical order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:43:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:43:00 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98534|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98551&action=edit Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:43:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:43:23 +0000 Subject: [Koha-bugs] [Bug 24608] New: Allow modification of checkout due date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Bug ID: 24608 Summary: Allow modification of checkout due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently it is not possible to modify a checkout's due date. This bug proposes to allow such an action. It is only proposed to allow modification of a due date *forward* at this stage as moving a due date backwards may involve additional complication that will require further thought. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:43:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:43:42 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:44:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:44:02 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:50:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:50:00 +0000 Subject: [Koha-bugs] [Bug 24609] New: Add routes for getting and setting checkout due date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Bug ID: 24609 Summary: Add routes for getting and setting checkout due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com To allow the work in bug 24608 to proceed, we need an API route to allow the setting of a checkout's due date. I will add a GET route also. The proposed endpoints are: Return a checkout's due date: Method: GET URL: /checkouts/{checkout_id}/date_due Set a checkout's due date: Method: POST URL: /checkouts/{checkout_id}/date_due Body: { date_due: '2020-02-07 10:49:08' } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:50:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:50:15 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 [Bug 24609] Add routes for getting and setting checkout due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:50:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:50:15 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 [Bug 24608] Allow modification of checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:53:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:53:14 +0000 Subject: [Koha-bugs] [Bug 24610] New: Let user switch between 'Pay' and 'Write off' mode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Bug ID: 24610 Summary: Let user switch between 'Pay' and 'Write off' mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This bug will add a way to switch between 'Pay' and 'Write off' mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:54:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:54:27 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #1 from Julian Maurice --- Created attachment 98552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98552&action=edit Bug 24610: Let user switch between 'Pay' and 'Write off' mode In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This patch adds link above the form to easily switch between the two modes. Also fixes a CSS bug to be able to use Bootstrap's nav pills inside .statictabs Test plan: 1. Create some manual invoices 2. Go to 'Make a payment' tab 3. Click on the 'Pay' button in a table row 4. Above the form you should see two links ('Pay' and 'Write off'). Click on 'Write off', confirm the write off and verify that it did make a 'write off'. 5. Go to 'Make a payment' tab 6. Click on the 'Write off' button in a table row 7. Click 'Pay', confirm the pay and verify that it did make a 'pay' 8. Go to 'Make a payment' tab 9. Select some lines and click on 'Pay selected' 10. Click on 'Write off', confirm the 'write off' and verify that it did make a 'write off' 11. Go to 'Make a payment' tab 12. Select some lines and click on 'Write off selected' 13. Click on 'Pay', confirm the pay and verify that it did make a 'pay' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:54:30 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #2 from Julian Maurice --- Created attachment 98553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98553&action=edit Bug 24610: Compiled CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 11:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 10:54:43 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:02:27 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Is this a warning? root at 8881cb995d76:koha(bz24602)$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 8/62 Argument "book_reserved" isn't numeric in numeric eq (==) at /kohadevbox/koha/C4/Items.pm line 1776. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=62, 8 wallclock secs ( 0.04 usr 0.00 sys + 6.64 cusr 0.63 csys = 7.31 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:06:42 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #4 from Tomás Cohen Arazi --- (In reply to David Nind from comment #3) > Is this a warning? > > root at 8881cb995d76:koha(bz24602)$ prove t/db_dependent/Reserves.t > t/db_dependent/Reserves.t .. 8/62 Argument "book_reserved" isn't numeric in > numeric eq (==) at /kohadevbox/koha/C4/Items.pm line 1776. > t/db_dependent/Reserves.t .. ok > All tests successful. > Files=1, Tests=62, 8 wallclock secs ( 0.04 usr 0.00 sys + 6.64 cusr 0.63 > csys = 7.31 CPU) > Result: PASS That's new, this is the warning I'm referring to: Use of uninitialized value $on_shelf_holds in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 1239. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:23:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:23:31 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:23:34 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98532|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 98554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98554&action=edit Bug 24602: Tests for get_onshlefholds_policy Ths patch introduces tests for get_onshelf_policy. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t => FAIL: Tests fail because the current code returns undef instead of 0 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:23:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:23:37 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98533|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 98555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98555&action=edit Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:31:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:31:44 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at outlook.com Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |emmi.takkinen at outlook.com --- Comment #4 from Emmi Takkinen --- Created attachment 98556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98556&action=edit Bug 4985: Edit a calendar entry for all branches Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 12:48:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 11:48:34 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:20:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:20:46 +0000 Subject: [Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|major |normal --- Comment #9 from Martin Renvoize --- Is this still valid.. or perhaps it should really be moved to library groups rather than independent branches at this point? At this point, it feels like an enhancement to me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:36:44 +0000 Subject: [Koha-bugs] [Bug 24611] New: wrong budget_id query parameter in /acquisitions/orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Bug ID: 24611 Summary: wrong budget_id query parameter in /acquisitions/orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Between the writing time of the endpoint (2017) and the time it was refactored and pushed, attribute mappings were introduced, and the query parameters didn't get enough attention so it still refers to budget_id. We need to fix it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:36:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:36:53 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18731 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:36:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:36:53 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 [Bug 24611] wrong budget_id query parameter in /acquisitions/orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:37:36 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:38:27 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #7 from Martin Renvoize --- Created attachment 98560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98560&action=edit Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:38:30 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #8 from Martin Renvoize --- Created attachment 98561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98561&action=edit Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:38:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:38:48 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #52316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:38:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:38:56 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:40:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:40:07 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #9 from Martin Renvoize --- Code works as expected and seems to resolve the issue described. I could not spot any regressions and it appears a sane change to me. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:40:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:40:15 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:47:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:47:37 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #10 from Oliver Behnke --- Seems like you accepted both of my patches. Nice! Thanks guys! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:47:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:47:55 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #28 from Martin Renvoize --- (In reply to David Cook from comment #27) > I have been thinking that maybe we should modularize search more so that it > would make it easier to customize behaviour, unit test, and swap different > backends in/out, but... I think one of the biggest struggles we face is that > Koha doesn't really have a search query language. > > We have something like CCL, but it's not CCL, and our compensating for that > fact leads to problems. And without a real query language, we don't have a > real query parser, and without a real query parser, it's hard to safely and > programmatically alter the queries. > > But... I don't really have a solution in mind either. Sometimes, I hope that > we'll just get rid of Zebra, and then we can just focus on Elasticsearch, > and maybe change our search query syntax to be safer, easier to parse, and > easier to integrate with Elasticsearch. I think it would be a breaking > change away from the Zebra CCL-like search syntax we've used... but that > would probably be a good thing. Agreed, but I feel that's for another bug ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:48:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:48:45 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #29 from Martin Renvoize --- Regarding this bug, I think we should use the patch here and update our minimum required zebra version (and document how to get said zebra version via either the indexdata repo's or pulling a copy into the koha repo) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:54:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:54:31 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 98562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98562&action=edit Bug 24611: Regression test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:54:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:54:34 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 98563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98563&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 13:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 12:55:04 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |ere.maijala at helsinki.fi, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 13:06:36 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se --- Comment #2 from Stina Hallin --- Hello, I cannot recreate the error message in the sandbox. I can recreate it in our own test Koha on version 19.05.04. Of course there can be differences in our setups. I have tried the sandbox both with and without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:09:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 13:09:26 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #22 from Julian Maurice --- Created attachment 98564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98564&action=edit Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:13:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 13:13:47 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #23 from Julian Maurice --- Not sure if it should still be BLOCKED, or if it is the right bug for this patch. Martin, can you take a look please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 14:46:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 13:46:45 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED --- Comment #1 from Andrew Isherwood --- Change of plan on this one. It's unnecessary to create a new endpoint for this. Following a discussion with Martin, I've realised we can just add a PUT endpoint for the /checkouts/{checkout_id} route, with whole checkout objects passed as the body. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:01:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:01:04 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98556|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 98565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98565&action=edit Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:02:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:02:40 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Christofer Zorn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #6 from Christofer Zorn --- Good morning! Followed test plan and was able to create a single date holiday and apply it to all branches. Was then able to switch branches, make the edit and apply to all and it worked. I'm not sure if this is intended to edit holidays over a range, but when I tried for a "closure week", the edit didn't apply and only changed the first day. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:10:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:10:33 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98552|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98566&action=edit Bug 24610: Let user switch between 'Pay' and 'Write off' mode In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This patch adds link above the form to easily switch between the two modes. Also fixes a CSS bug to be able to use Bootstrap's nav pills inside .statictabs Test plan: 1. Create some manual invoices 2. Go to 'Make a payment' tab 3. Click on the 'Pay' button in a table row 4. Above the form you should see two links ('Pay' and 'Write off'). Click on 'Write off', confirm the write off and verify that it did make a 'write off'. 5. Go to 'Make a payment' tab 6. Click on the 'Write off' button in a table row 7. Click 'Pay', confirm the pay and verify that it did make a 'pay' 8. Go to 'Make a payment' tab 9. Select some lines and click on 'Pay selected' 10. Click on 'Write off', confirm the 'write off' and verify that it did make a 'write off' 11. Go to 'Make a payment' tab 12. Select some lines and click on 'Write off selected' 13. Click on 'Pay', confirm the pay and verify that it did make a 'pay' Signed-off-by: Christofer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:10:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:10:35 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98553|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 98567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98567&action=edit Bug 24610: Compiled CSS Signed-off-by: Christofer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:11:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:11:18 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Christofer Zorn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #5 from Christofer Zorn --- Hello! I was able to follow the test plan below and it worked according to the plan. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:19:07 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #10 from Martin Renvoize --- I need some more of the other accounts bugs to move before I can delegate time to this I'm afraid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:22:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:22:49 +0000 Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #6 from Julian Maurice --- Thank you for testing it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:28:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:28:03 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97484|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 98568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98568&action=edit Bug 19735: Script to generate cpanfile (DO NOT PUSH) For testing purposes only Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:28:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:28:06 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97485|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 98569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98569&action=edit Bug 19735: Move Perl deps definitions into a cpanfile cpanfile is a format for describing CPAN dependencies for Perl applications. It is more concise - thus easier to read and maintain - than C4::Installer::PerlDependencies, and allows to describe requirements more accurately (using version ranges or features for instance) Additionally it can be read by tools such as cpanm or carton for an easy way to install dependencies on non-Debian-based systems. For more information on cpanfile, see http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod This patch replace C4::Installer::PerlDependencies by an equivalent cpanfile and update all scripts/modules that were using PerlDependencies It also removes dead code from C4::Installer::PerlModules (some subroutines were not used at all, except in unit tests) Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) Test plan: 1. Go to About page, tab Perl modules and keep this browser tab open 2. Apply patch 3. Install Module::CPANfile and CPAN::Meta a. On Debian-based systems: # will install libcpan-meta-perl as a dependency sudo apt install libmodule-cpanfile-perl b. Others: # will install CPAN::Meta as a dependency sudo cpanm Module::CPANfile 4. In a new browser tab, go to About page, tab Perl modules and compare the table with the one in the previous browser tab They should be identical, except for newly added dependencies (Module::CPANfile and CPAN::Meta) 5. Do a 'standard' install a. perl Makefile.PL (select 'standard') b. make c. sudo make install d. Configure your database, web server, ... and go through the web install process 6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which should be /usr/share/koha/lib) 7. Go to the about page of this fresh install and compare it with your dev install 8. Verify that debian/list-deps still works This takes a lot of time and it may not be necessary to wait until the end. If you see some Debian package names that correspond to modules in cpanfile, it means it still works (you need apt-file for this script to work) 9. Verify that koha_perl_deps.pl still works 10. prove t/Installer_pm.t t/Installer_PerlModules.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:28:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:28:10 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #26 from Martin Renvoize --- Created attachment 98570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98570&action=edit Bug 19735: Remove C4::Installer::PerlDependancies This patch does the actual removal of the PerlDependancies module. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:29:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:29:56 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Martin Renvoize --- Signing off.. all works as expected. I did a minor rebase whilst I was testing (new dependencies added to PerlDependancies. As part of that I separated the 'remove PerlDependancies' step into it's own commit to make it easier to rebase and use the included test script for building an updated cpanfile at time of push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:33:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:33:01 +0000 Subject: [Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 Wendy Sharkey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog at bfli.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:35:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:35:54 +0000 Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.08 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #4 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:36:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:36:03 +0000 Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:48:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:48:15 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #28 from Julian Maurice --- (In reply to Martin Renvoize from comment #27) > Signing off.. all works as expected. > > I did a minor rebase whilst I was testing (new dependencies added to > PerlDependancies. As part of that I separated the 'remove PerlDependancies' > step into it's own commit to make it easier to rebase and use the included > test script for building an updated cpanfile at time of push. I wanted to do that, but never did... Thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 15:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 14:56:05 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #107 from Bouzid Fergani --- Created attachment 98571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98571&action=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 16:03:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 15:03:41 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95152|0 |1 is obsolete| | Attachment #98571|0 |1 is obsolete| | --- Comment #108 from Bouzid Fergani --- Created attachment 98572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98572&action=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 16:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 15:04:41 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #109 from Bouzid Fergani --- Hi, 1. Refactoring AddAuthorityFromHeading 2. Deleting New images and use bootstrap icons 3. Replace require by use In authorities.pl 4. Add permission editcatalogue in cataloguing/automatic_linker.pl. 5. Indentation in all files 6. When running qa tools, all it's ok Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 17:56:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 16:56:55 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 17:56:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 16:56:58 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98560|0 |1 is obsolete| | Attachment #98561|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 98573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98573&action=edit Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 17:57:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 16:57:01 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #12 from Nick Clemens --- Created attachment 98574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98574&action=edit Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 17:57:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 16:57:03 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #13 from Nick Clemens --- Created attachment 98575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98575&action=edit Bug 16719: (QA follow-up) Remove tabs Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 18:00:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 17:00:20 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #14 from Nick Clemens --- https://wiki.koha-community.org/wiki/Ldap_testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 18:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 17:15:09 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #29 from Martin Renvoize --- Created attachment 98576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98576&action=edit Bug 19735: (QA follow-up) Drop references to 'usage' The 'usage' key was dropped as part of this migration to cpanfile but it was still refered to by the installed. This patch simply removes references to it. After considering how we might add it back in I decided that as it stands it wasn't a well maintained list and should be re-implimented in the future in a more consistent form if we miss it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 18:33:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 17:33:12 +0000 Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, testing this. Patch is simple and syntactically correct. What framework are you using? With english or unimarc_complete (fr-FR) field 009 is hidden. Are you using another one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 18:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 17:34:12 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #30 from Martin Renvoize --- Created attachment 98577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98577&action=edit Bug 19735: Add support for max_ver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:36:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:36:34 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:36:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:36:36 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98554|0 |1 is obsolete| | Attachment #98555|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 98578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98578&action=edit Bug 24602: Tests for get_onshlefholds_policy Ths patch introduces tests for get_onshelf_policy. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t => FAIL: Tests fail because the current code returns undef instead of 0 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:36:40 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #8 from Nick Clemens --- Created attachment 98579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98579&action=edit Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:38:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:38:41 +0000 Subject: [Koha-bugs] [Bug 15563] Cronjob to regularly delete patroncard and label batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Summary|Cronjob to regularly delete |Cronjob to regularly delete |patroncard label batches |patroncard and label | |batches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:44:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:44:17 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:44:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:44:19 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98547|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 98580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98580&action=edit Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:44:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:44:22 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98548|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 98581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98581&action=edit Bug 24525: (follow-up) Factor out to an include Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:51:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:51:37 +0000 Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:51:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:51:40 +0000 Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98107|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 98582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98582&action=edit Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' check that the change calculation is correct. 11) Sign-off the patch! Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:53:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:53:05 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- I don't know if you want to resolve here, or open a new bug. The dropdown for payment type contains an empty option. If you don't select a payment type you get an internal server error. Either that field should be made required, or we shouldn't include a blank option, or a blank shouldn't crash Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 19:55:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 18:55:41 +0000 Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column name "Pending order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97390|0 |1 is obsolete| | --- Comment #7 from Bouzid Fergani --- Created attachment 98583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98583&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:03:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:03:41 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96814|0 |1 is obsolete| | --- Comment #4 from Bouzid Fergani --- Created attachment 98584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98584&action=edit Bug 24211: Compress/uncompress translation files This patch adds the ability to compress/uncompress translations files. On update/install the files are uncompressed first The only gain is to use less space. To test: 1) Apply the patch 2) Go to misc/translator 3) Try it $ ./translate compress fr-FR (check po/*.gz) $ ./translate uncompress fr-FR ( check normal files) 4) Try again with verbose mode $ ./translate compress fr-FR -v (list compressed files) $ ./translate uncompress fr-FR -v (list uncompressed files) 5) Try update compressed files $ ./translate compress fr-FR $ ./translate update fr-FR (result is uncompressed) 6) Try install compressed files $ ./translate compress fr-FR $ ./translate install fr-FR 7) Try compress all $ ./translate compress (add '-v' for verbose output) 8) Try uncompress all $ ./translate uncompress (add '-v' for verbose output) Signed-off-by: David Nind Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:04:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:04:22 +0000 Subject: [Koha-bugs] [Bug 24612] New: expirationdate blank if patron has more than one item from bib on hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Bug ID: 24612 Summary: expirationdate blank if patron has more than one item from bib on hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It is impossible to print the expiration date on a hold slip (HOLD_SLIP) if the patron has more than one hold on that bib. The expirationdate comes back blank. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:15:56 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #1 from Christopher Brannon --- I have confirmed by looking at [% hold.reserve_id %] that HOLD_SLIP is looking at the wrong hold record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:22:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:22:40 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:22:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:22:42 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98515|0 |1 is obsolete| | --- Comment #39 from Nick Clemens --- Created attachment 98585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98585&action=edit Bug 23640: Flushing L1 on every SIP connection This patch flushes the L1 cache on each SIP connection (ie every invocation of process_request). This means each SIP connection will fetch values from the L2 cache (ie memcached) and persist the L1 cache (in Perl memory cache) only until a new SIP connection comes in. Without this patch, the L1 cache persists for the length of the server process, which means the L1 cache will become stale very quickly, which can lead to unexpected behaviour. Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev 2c. perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 5. Disable IssueLog 6. Check in the book and then check it out again perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkin perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 7. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 8. Note results Without the patch, you'll see a 2nd checkout. With the patch, you won't see the 2nd checkout. (Note: After applying the patch, you have to restart the SIP server.) Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:24:45 +0000 Subject: [Koha-bugs] [Bug 24613] New: SIP reports unable to checkin withdrawn item if not checked out and checked_in_ok set Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24613 Bug ID: 24613 Summary: SIP reports unable to checkin withdrawn item if not checked out and checked_in_ok set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The code that checks circ_ok against checked_in_ok comes after warning about withdrawn item so it says return has been blocked even if it hasn't -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:25:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:25:03 +0000 Subject: [Koha-bugs] [Bug 24613] SIP reports unable to checkin withdrawn item if not checked out and checked_in_ok set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24613 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:29:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:29:37 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #2 from Christopher Brannon --- If I assign <> to another variable, for some reason, [% hold.expirationdate %] works. Very wonky behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:35:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:35:18 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #10 from Martin Renvoize --- Nice catch nick.. I think that may have come about from the factoring out but I should work out here anti correct it really.. payment type is required if cash registers are in use, otherwise they're optional. I'm sure I can come up with a resolution for that.. will submit a follow-up after the weekend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:35:26 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |bouzid.fergani at inlibro.com --- Comment #24 from Bouzid Fergani --- Hi, Thanks to rebase this patch. Bug 23777 - Text converted to html entity codes in cataloguing edit form 97685 - Bug 23777: Fix auth finder escaping 97686 - Bug 23777: Fix for the advanced editor 97687 - Bug 23777: Use To.json in preferences.tt 97688 - Bug 23777: Use To.json in authorities.tt 97689 - Bug 23777: Use To.json in results.tt 97690 - Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt 97691 - Bug 23777: Use To.json in request.tt Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23777: Fix auth finder escaping Applying: Bug 23777: Fix for the advanced editor Applying: Bug 23777: Use To.json in preferences.tt Applying: Bug 23777: Use To.json in authorities.tt Applying: Bug 23777: Use To.json in results.tt Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 23777: Use To.json in results.tt The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23777-Use-Tojson-in-resultstt-VwtpJU.patch Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:42:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:42:58 +0000 Subject: [Koha-bugs] [Bug 24614] New: Can't edit reports if not using cache Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 Bug ID: 24614 Summary: Can't edit reports if not using cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To test: Enable strict mode Disable/stop memcached Create a report (note you don't see the cache expiry option) Try to edit the report It fails Enable memcached You get the cache expiry option back You can edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 20:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 19:57:11 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com --- Comment #5 from Bouzid Fergani --- Hi, I can't reproduce this issue in the updated master mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ prove t/db_dependent/selenium/authentication.t t/db_dependent/selenium/authentication.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.68 cusr 0.11 csys = 1.81 CPU) Result: PASS mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ You can check this please. Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:02:33 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:18 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97719|0 |1 is obsolete| | --- Comment #28 from Bouzid Fergani --- Created attachment 98586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98586&action=edit Bug 23916: Add issues.issuer column and FK This patch adds the issues.issuer column which is a foreign key to borrowers.borrowernumber Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:23 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97720|0 |1 is obsolete| | --- Comment #29 from Bouzid Fergani --- Created attachment 98587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98587&action=edit Bug 23916: Add "RecordIssuer" syspref This patch adds the "RecordIssuer" syspref, which is disabled by default Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:28 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97721|0 |1 is obsolete| | --- Comment #30 from Bouzid Fergani --- Created attachment 98588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98588&action=edit Bug 23916: Record and display item issuer This patch adds the recording and display of the item issuer. This behaviour is governed by the RecordIssuer syspref, if disabled (the default), no recording or display of issuer will take place. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:32 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97722|0 |1 is obsolete| | --- Comment #31 from Bouzid Fergani --- Created attachment 98589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98589&action=edit Bug 23916: Anonymise 'issuer' when required This patch adds the anonymisation of 'old_issues.issuer' alongside the existing anonymisation of 'old_issues.borrowernumber' Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:36 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97723|0 |1 is obsolete| | --- Comment #32 from Bouzid Fergani --- Created attachment 98590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98590&action=edit Bug 23916: Add unit tests This patch adds unit tests for the new functions Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 21:17:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 20:17:40 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97724|0 |1 is obsolete| | --- Comment #33 from Bouzid Fergani --- Created attachment 98591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98591&action=edit Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:01:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:01:41 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:01:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:01:44 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98562|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 98592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98592&action=edit Bug 24611: Regression test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:01:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:01:47 +0000 Subject: [Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98563|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 98593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98593&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:13:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:13:58 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #34 from Bouzid Fergani --- Created attachment 98594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98594&action=edit Bug 24495: Reword change collection feature This patch changes the text of the "Collect from patron" field to read "Amount tendered" To Test: 1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collect from patron" 2) Go into a patron record, and create a manual invoice. 3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collect from patron". 4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice) 5) Install the patch 6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collect from patron" in all payment options in the patron record, and in the Point of Sale screen. Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:17:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:17:21 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Attachment #98594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 22:18:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 21:18:17 +0000 Subject: [Koha-bugs] [Bug 24495] Reword change collection feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98043|0 |1 is obsolete| | --- Comment #14 from Bouzid Fergani --- Created attachment 98595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98595&action=edit Bug 24495: Reword change collection feature This patch changes the text of the "Collect from patron" field to read "Amount tendered" To Test: 1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collect from patron" 2) Go into a patron record, and create a manual invoice. 3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collect from patron". 4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice) 5) Install the patch 6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collect from patron" in all payment options in the patron record, and in the Point of Sale screen. Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bouzid Fergani https://bugs.koha-community.org/show_bug.cgi?id=23916 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:10:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:10:57 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98185|0 |1 is obsolete| | Attachment #98186|0 |1 is obsolete| | --- Comment #14 from Agustín Moyano --- Created attachment 98596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98596&action=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:11:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:11:01 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #15 from Agustín Moyano --- Created attachment 98597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98597&action=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:15:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:15:55 +0000 Subject: [Koha-bugs] [Bug 24615] New: REST API order by prefetched columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Bug ID: 24615 Summary: REST API order by prefetched columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: agustinmoyano at theke.io Reporter: agustinmoyano at theke.io CC: tomascohen at gmail.com Depends on: 24502 Blocks: 20936 Make object.search helper be able to order by prefetched columns Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] Add a query language and param (q=) to the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:15:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:15:55 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 [Bug 24615] REST API order by prefetched columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:15:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:15:55 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 [Bug 24615] REST API order by prefetched columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:16:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:16:49 +0000 Subject: [Koha-bugs] [Bug 24616] New: Cannot copy notice to another branch if it already exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Bug ID: 24616 Summary: Cannot copy notice to another branch if it already exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org If you try to copy a notice or slip to another branch and that branch already has that notice or slip, it will not let you save it. There needs to be a way to overwrite the existing notice or slip without having to delete first then copy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:18:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:18:36 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92719|0 |1 is obsolete| | --- Comment #112 from David Nind --- Created attachment 98598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98598&action=edit Bug 11297: Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Server name: BAnQ Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : MARC21/USMARC 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:18:42 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92720|0 |1 is obsolete| | --- Comment #113 from David Nind --- Created attachment 98599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98599&action=edit Bug 11297: Add atomicupdate patch and modify kohastructure.sql Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:18:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:18:47 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92721|0 |1 is obsolete| | --- Comment #114 from David Nind --- Created attachment 98600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98600&action=edit Bug 11297: Modify Z3950server schema file Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:18:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:18:53 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92722|0 |1 is obsolete| | --- Comment #115 from David Nind --- Created attachment 98601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98601&action=edit Bug 11297: (follow-up) Add html filter to new input field Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:19:22 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 7 23:40:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 22:40:49 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 00:01:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 23:01:05 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #177 from David Nind --- Patch no longer applies 8-( (Not sure of the correct protocol here - paste the message from git bz, or just say the patch no longer applies). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 00:14:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 23:14:36 +0000 Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special or repeatable holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 00:41:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Feb 2020 23:41:50 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #29 from Joy Nelson --- Backported to 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:14:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:14:32 +0000 Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #6 from Joy Nelson --- QA tests all show OK, except for nonnumeric error. Pushing to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:15:46 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com --- Comment #7 from Joy Nelson --- QA tests all show OK, except for nonnumeric error. Pushing to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:16:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:16:37 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #67 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:16:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:16:38 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bug 23916 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:16:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:16:38 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Bug 24356 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:16:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:16:38 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:17:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:17:00 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Joy Nelson --- New feature not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:17:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:17:01 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Bug 20936 depends on bug 24302, which changed state. Bug 24302 Summary: Add a way to specify nested objects to embed in OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:17:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:17:02 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 24302, which changed state. Bug 24302 Summary: Add a way to specify nested objects to embed in OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:20:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:20:55 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #12 from David Nind --- For whatever reason, I can't get this to run and get this error message: root at d541025c7641:cronjobs(bz11887)$ ./account_collections.pl -h Can't locate Koha/Accounts.pm in @INC (you may need to install the Koha::Accounts module) (@INC contains: /kohadevbox/koha /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./account_collections.pl line 27. BEGIN failed--compilation aborted at ./account_collections.pl line 27. For reference for testing: Add four patron attribute codes (Home > Administration > Patrons and circulation > Patron attribute types) and use these codes when running, suggestions are: - COLLECT-CF (Description: Code used to define if a patron can be collected from; YES_NO authorized value) - COLLECT-IN (Description: Code used to define if a patron is currently in collections; YES_NO authorized value) - COLLECT-LU (Description: Attribute field used to define the date the patron was last updated for collections purposes) - COLLECT-PB (Description: Attribute field to record the patron balance of the last time the update report was run) Add a collection fee code (Home > Administration > Accounting > Debit types), suggestion is: - COLLECT (Default amount: 10.00; Description: Collection fee; Can be manually invoiced: ticked) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:46:56 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98543|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 98602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98602&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:46:59 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98544|0 |1 is obsolete| | --- Comment #24 from David Nind --- Created attachment 98603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98603&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 01:47:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 00:47:40 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #25 from David Nind --- (In reply to Agustín Moyano from comment #22) > Patches didn't apply so rebased this bug. Not sure I needed to, but signed off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 02:15:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 01:15:00 +0000 Subject: [Koha-bugs] [Bug 12186] Deduplicate TT code for account payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #4 from David Nind --- Patch no longer applies 8-( Looks to me like these files had a significant amount of change over the last year or so, so maybe this change is not required any more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 02:28:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 01:28:07 +0000 Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #3 from David Nind --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 02:31:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 01:31:07 +0000 Subject: [Koha-bugs] [Bug 12297] Waitingreserves code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12297 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:03:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:03:24 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:04:10 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 --- Comment #1 from Agustín Moyano --- Created attachment 98604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98604&action=edit Bug 24615: Make object.search helper also order by embedded columns With this patch REST API request can order results by embedded columns. Full path to the column must be given for it to work. For example: If you are on biblio endpoint and you want to order by holding patron's card number you could > GET /biblio/1?_order_by=item.holds.cardnumber HTTP/1.1 > x-koha-embed: item.holds To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:05:51 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98596|0 |1 is obsolete| | Attachment #98597|0 |1 is obsolete| | --- Comment #16 from Agustín Moyano --- Created attachment 98605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98605&action=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:05:56 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #17 from Agustín Moyano --- Created attachment 98606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98606&action=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:58:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:58:03 +0000 Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #12 from David Nind --- I don't really understand anything about ILS-DI, but from working through the tests: 1) Showing the branch and call number works fine 2) Running the tests (prove t/db_dependent/ILSDI_Services.t): the tests pass, but there is one warning: root at a08c360ba7cc:koha(bz12469)$ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 6/10 Use of uninitialized value $charge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2978. t/db_dependent/ILSDI_Services.t .. ok All tests successful. Files=1, Tests=10, 9 wallclock secs ( 0.03 usr 0.00 sys + 7.59 cusr 1.12 csys = 8.74 CPU) Result: PASS 3) Adding due dates: this seems to only show the current date and time - for a record with 2 items, I checked one out (item 22 - due date 26 February 2020) and the other was available (item 21); with the URL cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=21+22&id_type=item I get this result returned as XML - availability status is 'available' and 'dateavailable' is the same for both: 21 available Fairview 947.084/1092 B 2020-02-08T03:36:40 22 available Centerville 947.084/1092 B 2020-02-08T03:36:40 If this is what is expected I'm happy to it off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 04:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 03:59:01 +0000 Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469 --- Comment #13 from David Nind --- That last sentence should say "If this is what is expected I'm happy to sign it off." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 05:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 04:17:52 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #17 from David Nind --- I get this error when applying the database update: root at 2fa601aba3df:koha(bz11361)$ perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug11361.perl DBD::mysql::db do failed: Unknown column 'attributes' in 'z3950servers' [for Statement "ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1) AFTER attributes;"] at (eval 1404) line 3. Add opac column to z3950servers table.Add OPACZ3950 preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 06:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 05:19:29 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 06:19:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 05:19:34 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97325|0 |1 is obsolete| | --- Comment #94 from David Nind --- Created attachment 98607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98607&action=edit Bug 8643: Add important constraint to marc subfields This enhancement adds an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Update the database (perl installer/data/mysql/updatedatabase.pl) 3) Regenerate the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure (Default framework) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default framework) » Subfield » tag a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record 8) Confirm that this message is displayed: A few important fields are not filled: * tag 100 subfield a Personal name in tab 1 * Field 100 is important, at least one of its subfields must be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 06:19:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 05:19:39 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97326|0 |1 is obsolete| | --- Comment #95 from David Nind --- Created attachment 98608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98608&action=edit Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 06:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 05:59:06 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 06:59:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 05:59:09 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97650|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98609&action=edit Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 07:37:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 06:37:32 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 07:37:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 06:37:37 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98488|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 98610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98610&action=edit Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create a manual invoice for any patron and click on "Save", you should be redirected to the Transactions tab (current behavour) 2. Create a manual invoice for any patron and click on "Save and pay", you should be redirected to Make a payment tab Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 10:35:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 09:35:06 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #28 from David Nind --- For whatever reason I can't seem to get the 'onpayment' option to show up for MarkLostItemsAsReturned. (Applied patch, ran database update, restart_all). For the tests I get this fail: root at 50d5e409ced0:koha(bz24474)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 30/47 # Failed test 'Should have a single 10 days overdue fine and lost charge' # at t/db_dependent/Circulation.t line 2344. # got: '27' # expected: '17' # Looks like you failed 1 test of 3. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2347. # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 31/47 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2347. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-99, 1='25', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-99, 1='28', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-74, 1='33', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-100, 1='37', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. t/db_dependent/Circulation.t .. 45/47 # Looks like you planned 2 tests but ran 1. t/db_dependent/Circulation.t .. 47/47 # Failed test 'Do not return on renewal (LOST charge)' # at t/db_dependent/Circulation.t line 3689. # Looks like you failed 2 tests of 47. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/47 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 47 Failed: 2) Failed tests: 31, 47 Non-zero exit status: 2 Files=1, Tests=47, 29 wallclock secs ( 0.09 usr 0.00 sys + 23.87 cusr 2.77 csys = 26.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:03:38 +0000 Subject: [Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607 --- Comment #4 from Katrin Fischer --- I wonder if this is a librarian vs users thing. As a user, I would expect the first author and other authors to be be displayed together - having to scroll way back down for the second author would not make sense to me, as the whole first/second thing is a bit of an artificial librarian thing. It's also very based on how MARC is structured - in Germany we used to have our own format (MAB) and also a big part of cataloguing is still not done in MARC, but based on the internal format of our union catalogs. I'd argue we should always try to keep things in an order, that makes sense from the content. MARC lends to that, but not totally. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:06:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:06:26 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #28 from Katrin Fischer --- issuingrules is gone - so this turns into "INVALID". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:14:58 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** Bug 22064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:14:58 +0000 Subject: [Koha-bugs] [Bug 22064] Allow to change due date of an item without requiring checkin or renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Choosing the newer bug in this case as it's assigned (hopefully to be worked on) *** This bug has been marked as a duplicate of bug 24608 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:28:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:28:36 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:39:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:39:26 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:41:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:41:23 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 --- Comment #13 from Katrin Fischer --- Hm, have you run it from koha-shell? But it could also be caused by all the changes to the Accounts code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 12:48:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 11:48:35 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Awesome to see the old and bad moving - thx guys! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 15:01:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 14:01:39 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #29 from Agustín Moyano --- (In reply to Catherine E. Ingram from comment #28) > (In reply to Agustín Moyano from comment #27) > > (In reply to Catherine E. Ingram from comment #21) > > > We were playing around with it this morning and wondered about roll out. > > > The way it looked in the sandbox was that it would default to all existing > > > patrons getting NO notices (with both email and digest un-checked). Did > > > anyone else encounter this? > > > ~Catherine > > > > Hi Catherine, you were right.. I believed that if I didn't add that > > preference on patrons that already had preferences setted, Koha would break, > > but it didn't happen at the end. > > > > Thanks for spotting that out. > > > > Can you please try it out again? > > > > Thanks. > > Hi Agustín, > > We have tested the latest patch you have submitted. > > After applying the patch, we notice that all patrons will have Auto Renewals > UNCHECKED for both Email and Digest. This means NO Auto Renewal > communication after we apply the patch. > > This is a problem, because patrons will suddenly stop receiving all Auto > Renewal communication unless they re-configure their preferences > individually. > > Can we request that the patch updates ALL patrons to have both Email and > Digest CHECKED for the Auto Renewal function? > > Thank you! > Catherine Hi Catherine, I'm afraid that setting email and digest checked for all patrons would break the rule of keeping behavior as it is when upgrading.. Current behavior would match by making email checked and digest unchecked, but if I set that in every patron's preference that would mean that to get digest messages every patron should set that up individually. So, what I propose is not to set any preference in patron, but set email checked and digest unchecked for every patron category. That way, I believe behavior whould be the same after update, and if a library wants digest messages for there patrons, they only have to set that once in patrons categories. What do you think? Regards Agustín. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 15:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 14:21:53 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from David Nind --- (In reply to Katrin Fischer from comment #13) > Hm, have you run it from koha-shell? But it could also be caused by all the > changes to the Accounts code. I did - other scripts ran okay. Changing status to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 15:36:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 14:36:16 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98606|0 |1 is obsolete| | --- Comment #18 from Agustín Moyano --- Created attachment 98611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98611&action=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 15:44:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 14:44:25 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 Jawad Makki changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 15:46:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 14:46:49 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #29 from David Nind --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 16:05:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 15:05:42 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Hasina changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shumi78 at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 16:37:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 15:37:10 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column filter feature to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 [Bug 24615] REST API order by prefetched columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 16:37:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 15:37:10 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column filter feature to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 18:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 17:45:14 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add embedded column filter |Add embedded column order |feature to datatables api |by and filter features to |wrapper |datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 19:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 18:06:55 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 19:07:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 18:07:19 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 --- Comment #1 from Agustín Moyano --- Created attachment 98612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98612&action=edit Bug 24561: Datatables api wrapper also filter and order embedded columns This patch adds the ability to filter and order by embedded columns. To use it you must in JS: $('datatable_selector').api({datatables_options}) where datatables_options are all datatables options plus: 1. embed: [list of embeddable tables] This option adds x-koha-embed header to request. 2. header_filter: true|false This option if true sets x-koha-query header with stringyfied json of filters Oderable and searchable columns must define data option as string, otherwise filter and order won't be possible. If you must custom the output, use the render function. For example: * Don't > $('.table_selector').api({ > columns: [ > { > data: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); * Do > $('.table_selector').api({ > columns: [ > { > data: 'holds.patron.firstname', > render: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); To test you must implement and test bug 20936, where it will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 8 21:24:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Feb 2020 20:24:10 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fix updates the help release notes| |links for 09x, 59x, and 69x | |fields in the basic and | |advanced MARC21 editor. The | |links now go to the correct | |Library of Congress | |documentation pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:00:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:00:02 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|wrong budget_id query |Wrong budget_id query |parameter in |parameter in |/acquisitions/orders |/acquisitions/orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:28:54 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #5 from Katrin Fischer --- Test is not happy on my system - leaving this Signed Off as I think they passed for David and Tomas: # Failed test 'SWAGGER3.2.2' # at t/db_dependent/api/v1/acquisitions_orders.t line 65. # got: '500' # expected: '200' # Failed test 'has value for JSON Pointer "/14/order_id"' # at t/db_dependent/api/v1/acquisitions_orders.t line 65. # Looks like you failed 2 tests of 8. t/db_dependent/api/v1/acquisitions_orders.t .. 1/5 # Failed test 'list() tests' # at t/db_dependent/api/v1/acquisitions_orders.t line 97. t/db_dependent/api/v1/acquisitions_orders.t .. 5/5 # Looks like you failed 1 test of 5. t/db_dependent/api/v1/acquisitions_orders.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report ------------------- t/db_dependent/api/v1/acquisitions_orders.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=5, 16 wallclock secs ( 0.02 usr 0.02 sys + 11.47 cusr 1.89 csys = 13.40 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:35:19 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Most notably before this patch tabbing through the input fields would jump over the drop down fields. With the patch applied this seems to work much better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:35:44 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:35:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:35:47 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98609|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 98613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98613&action=edit Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:37:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:37:40 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #4) > Can we imagine whitelist a list of html tags? Can you explain this a bit? I am not sure what the Syndetics code looks like, but as it's a paid for service... I hope the risk of malicious code would be small here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:41:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:41:11 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- (In reply to Lucas Gass from comment #1) > I cannot reproduce this in master now. I believe the problem was solved by > bz24515. I think the problem here is that it works on one tab, but not the other: - Make a payment = OK - Transaction = Not OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:42:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:42:43 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:42:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:42:46 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98357|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 98614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98614&action=edit Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:52:39 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I can replicate the issue on master - trying the fix next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:55:18 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:55:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:55:21 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97771|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 98615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98615&action=edit Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:58:41 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 11:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 10:58:45 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98277|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 98616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98616&action=edit Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:04:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:04:19 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Printing holds awaiting |Add column configuration to |pickup prints both tabs |'Holds awaiting pickup' | |tables allowing to print | |both tables separately --- Comment #4 from Katrin Fischer --- I think this is a great solution to this old issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:07:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:07:26 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:07:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:07:29 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98371|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 98617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98617&action=edit Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:08:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:08:21 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 --- Comment #6 from Katrin Fischer --- There is a bit of weird behavior depending on screen size, as the table always 'centers'. But it's not perfect before the patch either - maybe something for a small follow-up. Owen, could you have a quick look to see if you can reproduce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:55:52 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 --- Comment #17 from Katrin Fischer --- I am not totally persuaded by the removal of the 'Total available' column as it works well for libraries not using sub funds (we always recommend not to use them, tbh) and it removes valuable information for them. > When searching the table and limiting rows you lose the values form the children I am not sure how this column is different in this regard to the others that we display the total amount for now? Basically our main problem is the way that the fund hierarchy works. While we can divide the funds in sub funds, we can spent on all levels. And the parent fund has the full amount to spend (including what's in the sub funds), instead of only the remaining amount (total - sub funds). At the moment, when you look at the "Totel spend" on the budget page, it will include the spent values of the sub funds. But on the acq hope page, it won't. Same for ordered. I believe, as the columns appear to be the same, this is quite confusing. If the funds are collapsed, it might look like nothing was spent - even tho the child funds might be almost out of means and the total shows an amount. I believe we should fix this the other direction - make it match the 'Total' columns on the budgets page by adding the spent and ordered from the sub funds to the parent funds. If we do that, I imagine calculating the totals also should get easier as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 12:57:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 11:57:07 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 --- Comment #18 from Katrin Fischer --- Not switching status... I think I could be persuaded with the first patch as a bug fix that is universal (for now), but I still believe there are fundamental issues left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:00:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:00:54 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 --- Comment #19 from Katrin Fischer --- Created attachment 98618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98618&action=edit With patch applied The 2 in total is correct, but it's not visible/clear where it's coming from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:03:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:03:16 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #30 from Katrin Fischer --- (In reply to Martin Renvoize from comment #29) > Regarding this bug, I think we should use the patch here and update our > minimum required zebra version (and document how to get said zebra version > via either the indexdata repo's or pulling a copy into the koha repo) +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:18:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:18:54 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16581 --- Comment #31 from Katrin Fischer --- It appears there are other known and sever issues with .59 - so that could lead as another motivation to move us to a newer version by default: bug 16581 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:18:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:18:54 +0000 Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:31:00 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #32 from Katrin Fischer --- Search example, for testing with our test data: - Who The Doctor Who books move down the list without this patch, but are on top with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:37:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:37:38 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #19 from Agustín Moyano --- (In reply to David Nind from comment #11) > (In reply to David Nind from comment #10) > > I get this message when trying to apply this patch (git bz apply 24502): > > > > Failed to retrieve bug information: NotPermitted > > Figured it out - a dependency is security related. > > Will let someone else test who has the right access! Hi David, bug 24487 is now in master. Would you please try again? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:38:02 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #33 from Katrin Fischer --- (In reply to David Cook from comment #6) > It appears that this patch could break the "Publication Date (yyyy)" search, > when using "yr,st-numeric" (which might be the case after bug 9368). > > If we were to use "yr,st-year" instead, you might get results for a "2000-" > query but they would only be for "2000". If you specified a full range > "2000-2012", it would break. > > It seems that relevance can't be run with date ranges (which is usually > fine, as we use date ranges as limits which are not affected by relevance > ranking). I can't find any issues with my kohadevbox using Zebra 2.0.59. Tested on our sample data with the following date range searches from advanced search, receiving the correct results: 1941 -1941 1900-1941 2000 2000- Adding my sign-off to this, as all tests so far are positive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:38:30 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98188|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer --- Created attachment 98619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98619&action=edit Bug 12430 - Truncation disables relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:43:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:43:51 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hi Emmi, there are some fails with the QA tools for missing filters, can you please fix? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL filters missing_filter at line 1071 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";) missing_filter at line 1072 ( var fines = "[% fines %]";) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL filters missing_filter at line 890 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";) missing_filter at line 891 ( var fines = "[% fines %]";) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:55:40 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This works really well apart from the case Christopher found. I will attach a screenshot to show what I did. When I click on save, no holiday is deleted - neither on the currently selected branch, nor on others. Adding the range worked nicely! Can you have a look? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:56:27 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #8 from Katrin Fischer --- Created attachment 98620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98620&action=edit Deleting holidays on a date range not working -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:56:47 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24615 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 [Bug 24615] REST API order by prefetched columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:56:47 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:57:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:57:22 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24502 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] Add a query language and param (q=) to the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 13:57:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 12:57:22 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24561 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column order by and filter features to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:04:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:04:16 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I have some worries about this one: - Changes only OPAC, not staff - Might show a false 0 in some context: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
  • Title notes ( [% MARCNOTES.size %] )
  • If there are notes and/or Syndetics content, but no MARCNOTES, the tab will display 0, looking 'empty' to the patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:06:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:06:25 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #7 from Katrin Fischer --- I think the nicest way might be to include the Syndetics and note content in the number. If we can't tell for syndetics, maybe we could do something like: 1+ 5 5xx displaying + Syndetics content available = 5+ ? Or only show the number if Syndetics is not active. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:10:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:10:17 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:10:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:10:20 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98483|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 98621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98621&action=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:12:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:12:16 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #6 from Katrin Fischer --- I can see in bug history, that this was switched to signed off by shumi78 at gmail.com, but there is no sign-off line/comment. As this is a easy to read/test template change, I think PQA is ok with or without the SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:12:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:12:57 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to suggestions tab in patron account in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'Managed on' and |Add 'Managed on' and |'Suggested on' columns to |'Suggested on' columns to |pat_purchase_suggestions.tt |suggestions tab in patron | |account in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:45:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:45:34 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23767 Status|Signed Off |In Discussion --- Comment #25 from Katrin Fischer --- I found this after having tested bug 23767 earlier and I think we should think about merging both bugs in a way - they deal with very similar problems. I will move both to 'in Discussion' meaning that I hope you can talk to each other and figure out the best way to move those 2 forward! 1) I notice the removal of the "Total available" here. I think this is one of the things libraries really look at - would it be possible to add it back? 2) Also in my case I have the following: Parent fund, spent: 0,00 Sub fund, spent: 2,00 For Total spent: It shows on both parent and sub fund level, adding up to 2 still. = OK For Base-level spent: 2,00 shows, but is added up to 0,00 Total. So... the totals are quite confusing: 2+2 = 2 2+0 = 0 As it's the same we display on budget, maybe adopting the "italic" formatting from the budgets page could help a little here. Attaching a screnshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:45:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:45:34 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:47:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:47:15 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #26 from Katrin Fischer --- Created attachment 98622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98622&action=edit With patch applied Makes sense to me, but the totals could be a little confusing when comparing to coumn entries (formatting) and the 'Total available' total is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 14:48:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 13:48:30 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #20 from Katrin Fischer --- I've now found 16126 and would love if both could be merged/moved forward together. Both sadly lack the total amount, although it's available on the budget page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 15:55:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 14:55:49 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #6 from Tomás Cohen Arazi --- Katirna, I don't manage to reproduce: (base) ✔ ~/git/koha [qa_24611 ↑·2|⚑ 13] 11:52 $ git reset --hard origin/master HEAD is now at 99e2fbd083 Bug 13193: (RM follow-up) Remove Cache::Memcached::Fast from PerlDependencies (base) ✔ ~/git/koha [qa_24611|⚑ 13] 11:53 $ git bz apply 24611 Bug 24611 - Wrong budget_id query parameter in /acquisitions/orders 98592 - Bug 24611: Regression test 98593 - Bug 24611: Fix wrong budget_id query param in /acquisitions/orders Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24611: Regression test Applying: Bug 24611: Fix wrong budget_id query param in /acquisitions/orders (base) ✔ ~/git/koha [qa_24611 ↑·2|⚑ 13] 11:53 $ kshell root at d749cd762ad3:kohadevbox$ kshell kohadev-koha at d749cd762ad3:/kohadevbox/koha$ prove t/db_dependent/api/v1/acquisitions_orders.t t/db_dependent/api/v1/acquisitions_orders.t .. ok All tests successful. Files=1, Tests=5, 22 wallclock secs ( 0.05 usr 0.02 sys + 12.53 cusr 2.75 csys = 15.35 CPU) Result: PASS kohadev-koha at d749cd762ad3:/kohadevbox/koha$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 16:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 15:44:32 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #7 from Katrin Fischer --- Just what I thought - I think it's my environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 18:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 17:01:12 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #7) > Just what I thought - I think it's my environment. Katrina, it would be interesting to see the output of you add use Data::Printer colored => 1; p($t->tx->res); After the failed test. It might highlight something important (bad handling on error conditions). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 19:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 18:44:55 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #20 from David Nind --- > Hi David, bug 24487 is now in master. Would you please try again? The bug is still restricted, so not able to yet. Also, is there anyway to test the query parameters in the follow up patch (without writing a program, as I'm not a programmer), or are these sufficiently covered by the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 20:25:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 19:25:57 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #21 from Tomás Cohen Arazi --- (In reply to David Nind from comment #20) > > Hi David, bug 24487 is now in master. Would you please try again? > > The bug is still restricted, so not able to yet. > > Also, is there anyway to test the query parameters in the follow up patch > (without writing a program, as I'm not a programmer), or are these > sufficiently covered by the tests? David, you don't seem to need to apply that bug: (base) ✔ ~/git/koha [qa_24502|⚑ 13] 16:24 $ git bz apply 24502 Bug 24502 Depends on bug 24356 Follow? [(y)es, (n)o] y Bug 24356 - objects.search prefetch 98602 - Bug 24356: prefetch_whitelist tests 98603 - Bug 24356: Make objects.search prefetch embedded relations Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24356: prefetch_whitelist tests Applying: Bug 24356: Make objects.search prefetch embedded relations Bug 24502 - Add a query language and param (q=) to the API 98605 - Bug 24502: object.search also filter by prefetched columns 98611 - Bug 24502: (follow-up) Add all 3 query parameters in api definition Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24502: object.search also filter by prefetched columns Applying: Bug 24502: (follow-up) Add all 3 query parameters in api definition (base) ✔ ~/git/koha [qa_24502 ↑·4|⚑ 13] 16:25 $ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 20:50:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 19:50:35 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- 24356 is not in security, which is the bug that gives you trouble? I can give you access to security bugs if needed (just needs someone with access to add you to the CC list) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 20:58:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 19:58:21 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #23 from David Nind --- This is what I get when I try to apply: root at b7a19a96d4cf:koha(bz24502)$ git bz apply 24502 Bug 24502 Depends on bug 24356 Follow? [(y)es, (n)o] y Bug 24356 - objects.search prefetch 98602 - Bug 24356: prefetch_whitelist tests 98603 - Bug 24356: Make objects.search prefetch embedded relations Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24356: prefetch_whitelist tests Applying: Bug 24356: Make objects.search prefetch embedded relations Failed to retrieve bug information: NotPermitted When I go to bug 24487 in Bugzilla I get "You are not authorized to access bug #24487." (with a red background) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 21:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 20:03:13 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #24 from Katrin Fischer --- (In reply to David Nind from comment #23) > This is what I get when I try to apply: > > root at b7a19a96d4cf:koha(bz24502)$ git bz apply 24502 > > Bug 24502 Depends on bug 24356 > Follow? [(y)es, (n)o] y > Bug 24356 - objects.search prefetch > > 98602 - Bug 24356: prefetch_whitelist tests > 98603 - Bug 24356: Make objects.search prefetch embedded relations > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 24356: prefetch_whitelist tests > Applying: Bug 24356: Make objects.search prefetch embedded relations > Failed to retrieve bug information: NotPermitted > > When I go to bug 24487 in Bugzilla I get "You are not authorized to access > bug #24487." (with a red background) Hi David, I've added you to the CC list, that should give you access. As it's already pushed, maybe it's a problem in git bz not being able to determine the status. Applying the bugs manually without following the dependencies could also work in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 21:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 20:46:56 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 21:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 20:46:59 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66591|0 |1 is obsolete| | Attachment #66592|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 98623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98623&action=edit Bug 3137: HideFieldsPatronAddForm syspref This patches adds a syspref - HideFieldsAddPatronFrom - that controls which fieldsets are hidden by default in the add patron form. To test: 1) Apply patch and update database 2) Go to System preferences and confirm HideFieldsPatronAddForm has no fields selected 3) Go to add a patron / edit an existing patron (any patron category). confirm everything still works as expected. 4) Tick some of the fields in the syspref to hide them in the form 5) Go back to add patron form. 6) Confirm these fields are hidden and listed at the top of the page 7) Toggle the checkbox and confirm the hidden fields show or hide as expected. 8) Go back to the HideFieldsPatronAddForm system preference and ensure the Main address option is checked to be hidden 9) Go to the patron's details page 10) Click to edit the Contact Information section 11) Confirm the Main address option shows and the checkbox to show hidden fields is not present. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 21:49:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 20:49:10 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98612|0 |1 is obsolete| | --- Comment #2 from Agustín Moyano --- Created attachment 98624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98624&action=edit Bug 24561: Datatables api wrapper also filter and order embedded columns This patch adds the ability to filter and order by embedded columns. To use it you must in JS: $('datatable_selector').api({datatables_options}) where datatables_options are all datatables options plus: 1. embed: [list of embeddable tables] This option adds x-koha-embed header to request. 2. header_filter: true|false This option if true sets x-koha-query header with stringyfied json of filters Oderable and searchable columns must define data option as string, otherwise filter and order won't be possible. If you must custom the output, use the render function. For example: * Don't > $('.table_selector').api({ > columns: [ > { > data: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); * Do > $('.table_selector').api({ > columns: [ > { > data: 'holds.patron.firstname', > render: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); To test you must implement and test bug 20936, where it will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 21:53:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 20:53:23 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97578|0 |1 is obsolete| | --- Comment #9 from Agustín Moyano --- Created attachment 98625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98625&action=edit Bug 24455: Add JS functions to format date and datetime strings This patch adds the a js-date-format.inc file on each opac and staff interface (date-format.inc whas not available as name) When you include that file in your TT, you'll get the following functions available: 1. $date(raw_date_string, options) This function parses a date string, as produced by an api call, and returns the corresponding date formatted according to 'dateformat' and 'TimeFormat' parameters. For example: // dateformat: us // timeformat: 12hr // Timezone: UTC $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020' $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get '03/23/2020 14:00' $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) // You will get '03/23/2020 15:00+01:00' Options: * dateformat: override date format as configured in staff interface (accepts also 'rfc3339') * timeformat: override time format as configured in staff client (available options are '12hr' and '24hr') * withtime: also print the time part (default false) * tz: set the timezone 2. $datetime(raw_date_string, option) The same as $date but sets withtime to true 3. $time(raw_date_string, option) The same as $datetime but shows only the time part To test you must implement and test bug 20936, where it will be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:05:58 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/19.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (stable/18.11.x) |updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:18:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:18:49 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98623|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 98626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98626&action=edit Bug 3137: HideFieldsPatronAddForm syspref This patches adds a syspref - HideFieldsAddPatronFrom - that controls which fieldsets are hidden by default in the add patron form. To test: 1) Apply patch and update database 2) Go to System preferences and confirm HideFieldsPatronAddForm has no fields selected 3) Go to add a patron / edit an existing patron (any patron category). confirm everything still works as expected. 4) Tick some of the fields in the syspref to hide them in the form 5) Go back to add patron form. 6) Confirm these fields are hidden and listed at the top of the page 7) Toggle the checkbox and confirm the hidden fields show or hide as expected. 8) Go back to the HideFieldsPatronAddForm system preference and ensure the Main address option is checked to be hidden 9) Go to the patron's details page 10) Click to edit the Contact Information section 11) Confirm the Main address option shows and the checkbox to show hidden fields is not present. 12) Confirm you can click the legend of each section to show and hide sections Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:33:18 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:33:22 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #13 from Aleisha Amohia --- Created attachment 98627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98627&action=edit Bug 14647: (follow-up) Fix script not detecting XML output format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:46:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:46:34 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 --- Comment #6 from Aleisha Amohia --- I have been able to verify that this bug only occurs if SMSSendDriver is set to Email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:54:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:54:29 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #12 from Hayley Mapley --- Based on enhancement not backported to 18.11.x so will not be backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:56:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:56:28 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 22:56:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 21:56:32 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65014|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 98628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98628&action=edit Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 23:01:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 22:01:03 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED --- Comment #10 from Aleisha Amohia --- Can no longer reproduce this bug in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 23:01:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 22:01:04 +0000 Subject: [Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Bug 18798 depends on bug 17896, which changed state. Bug 17896 Summary: BakerTaylorEnabled is not plack safe in reading history at the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 9 23:03:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Feb 2020 22:03:17 +0000 Subject: [Koha-bugs] [Bug 14580] Warn when accessing Help from error pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #8 from Aleisha Amohia --- Looks like this has been fixed in master by redirecting to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:06:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:06:46 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:06:50 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #4 from Agustín Moyano --- Created attachment 98629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98629&action=edit Bug 20936: Add OPACHoldsHistory syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:06:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:06:54 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #5 from Agustín Moyano --- Created attachment 98630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98630&action=edit Bug 20936: Add patron's hold history menu in OPAC This patch adds patron's hold history in OPAC. Right now, it only shows records from old_reserves table, but I'll wait till bug 20271 is pushed to show full history (old and new holds) To test: 1. apply this patch 2. Find a patron, place several holds and cancel or fulfill them 3. Go to patron's opac CHECK => There is no 'your holds history' option in menu 4. In admin preferences enable OPACHoldsHistory 5. Go back to patron's opac SUCCESS => There is a 'your holds history' menu option => Holds history displays all holds canceled or fulfilled 6. Filter, order and change page SUCCESS => All controls work as expected 7. Sign off. Table content is fetched from the api. If you see data, and you can order and filter then please sign off bug 24561. Date columns use $date function to transform dates strings from api (for example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you change dateformat prefernce and see the changes reflected in date columns, please sign off bug 24455. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:23:08 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #35 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:43:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:43:36 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #60 from David Cook --- Hurray! Extra special thanks to Barton, Martin, Joonas, and Mason. (That sentence actually sounds really good when you say it outloud. Excellent names heh.) My apologies for not getting the dependency packaged. I'm going to leave it on my TODO list and work on getting it accepted into Debian. I figure once I have a handle on Debian policies, it shouldn't be too challenging to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:46:56 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #25 from David Nind --- Thanks Katrin. Can now apply the patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 01:49:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 00:49:57 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from David Nind --- After all that, 1 test failed for me! root at 5bbe8b290c9a:koha(bz24502)$ prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t t/Koha/REST/Plugin/Query.t ................. 3/6 # Failed test '200 OK' # at t/Koha/REST/Plugin/Query.t line 314. # got: '500' # expected: '200' # Failed test 'exact match for JSON Pointer "/-and"' # at t/Koha/REST/Plugin/Query.t line 314. # Structures begin differing at: # $got = undef # $expected = ARRAY(0x5564a4153a48) # Looks like you failed 2 tests of 3. # Failed test '/merge_q_params' # at t/Koha/REST/Plugin/Query.t line 357. # Looks like you failed 1 test of 6. t/Koha/REST/Plugin/Query.t ................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests t/db_dependent/Koha/REST/Plugin/Objects.t .. ok Test Summary Report ------------------- t/Koha/REST/Plugin/Query.t (Wstat: 256 Tests: 6 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=2, Tests=14, 25 wallclock secs ( 0.06 usr 0.01 sys + 21.66 cusr 3.74 csys = 25.47 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:06:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:06:58 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:07:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:07:01 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98541|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 98631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98631&action=edit Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:07:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:07:05 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98542|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 98632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98632&action=edit Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:07:09 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98627|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 98633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98633&action=edit Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:19:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:19:21 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #35 from David Cook --- (In reply to Martin Renvoize from comment #29) > Regarding this bug, I think we should use the patch here and update our > minimum required zebra version (and document how to get said zebra version > via either the indexdata repo's or pulling a copy into the koha repo) +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 02:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 01:20:12 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #61 from David Cook --- Because this adds a new dependency, I'm guessing it may not be backported to older versions? Would love to see this get into 19.11, but understand if that's not possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 03:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 02:43:24 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 04:00:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 03:00:36 +0000 Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #10 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 04:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 03:05:19 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #19 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 04:56:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 03:56:11 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z --- Comment #8 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 04:57:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 03:57:47 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 05:20:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 04:20:43 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.01 |20.05.00, 19.11.01, released in| |19.05.06, 18.11.14 --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 07:49:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 06:49:35 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 08:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 07:10:29 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #10 from Emmi Takkinen --- Created attachment 98634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98634&action=edit Bug 23415: Add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:02:03 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #2 from David Nind --- Path doesn't apply: .git/rebase-apply/patch:67: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M Koha/REST/Plugin/Query.pm M t/db_dependent/Koha/REST/Plugin/Objects.t .git/rebase-apply/patch:67: trailing whitespace. warning: 1 line applied after fixing whitespace errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:04:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:04:03 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > Just wondering about this line in the opac-detail template: > > [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && > SyndeticsSummary && SYNDETICS_SUMMARY )) %] > > Where do we fill notes? Cant find that at first. notes is coming from biblio.notes; but still cant find the place where it is passed into the template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:04:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:04:56 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #7) > I think the nicest way might be to include the Syndetics and note content in > the number. If we can't tell for syndetics, maybe we could do something > like: 1+ > > 5 5xx displaying + Syndetics content available = 5+ ? > > Or only show the number if Syndetics is not active. If there is a Syndetics summary, I will add +1. It is a html blob. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:10:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:10:30 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:10:32 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #10 from Marcel de Rooy --- Created attachment 98635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98635&action=edit Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy Tested by enabling the prefs and passing contents to the template var. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:11:55 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #6) Thanks for QAing. > - Changes only OPAC, not staff Will open a new report for that. > - Might show a false 0 in some context: > > [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && > SYNDETICS_SUMMARY )) %] >
  • Title notes ( [% > MARCNOTES.size %] )
  • > > If there are notes and/or Syndetics content, but no MARCNOTES, the tab will > display 0, looking 'empty' to the patrons. Good point. Adjusted in follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:13:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:13:43 +0000 Subject: [Koha-bugs] [Bug 24617] New: Add title notes count in staff detail (following 24530) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Bug ID: 24617 Summary: Add title notes count in staff detail (following 24530) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:14:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:14:22 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 [Bug 24617] Add title notes count in staff detail (following 24530) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:14:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:14:22 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:15:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:15:26 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:48:17 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98568|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 98636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98636&action=edit Bug 19735: Script to generate cpanfile (DO NOT PUSH) For testing purposes only Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:48:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:48:21 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98569|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 98637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98637&action=edit Bug 19735: Move Perl deps definitions into a cpanfile cpanfile is a format for describing CPAN dependencies for Perl applications. It is more concise - thus easier to read and maintain - than C4::Installer::PerlDependencies, and allows to describe requirements more accurately (using version ranges or features for instance) Additionally it can be read by tools such as cpanm or carton for an easy way to install dependencies on non-Debian-based systems. For more information on cpanfile, see http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod This patch replace C4::Installer::PerlDependencies by an equivalent cpanfile and update all scripts/modules that were using PerlDependencies It also removes dead code from C4::Installer::PerlModules (some subroutines were not used at all, except in unit tests) Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) Test plan: 1. Go to About page, tab Perl modules and keep this browser tab open 2. Apply patch 3. Install Module::CPANfile and CPAN::Meta a. On Debian-based systems: # will install libcpan-meta-perl as a dependency sudo apt install libmodule-cpanfile-perl b. Others: # will install CPAN::Meta as a dependency sudo cpanm Module::CPANfile 4. In a new browser tab, go to About page, tab Perl modules and compare the table with the one in the previous browser tab They should be identical, except for newly added dependencies (Module::CPANfile and CPAN::Meta) 5. Do a 'standard' install a. perl Makefile.PL (select 'standard') b. make c. sudo make install d. Configure your database, web server, ... and go through the web install process 6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which should be /usr/share/koha/lib) 7. Go to the about page of this fresh install and compare it with your dev install 8. Verify that debian/list-deps still works This takes a lot of time and it may not be necessary to wait until the end. If you see some Debian package names that correspond to modules in cpanfile, it means it still works (you need apt-file for this script to work) 9. Verify that koha_perl_deps.pl still works 10. prove t/Installer_pm.t t/Installer_PerlModules.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:48:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:48:25 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98570|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 98638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98638&action=edit Bug 19735: Remove C4::Installer::PerlDependancies This patch does the actual removal of the PerlDependancies module. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:48:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:48:28 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98576|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 98639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98639&action=edit Bug 19735: (QA follow-up) Drop references to 'usage' The 'usage' key was dropped as part of this migration to cpanfile but it was still refered to by the installed. This patch simply removes references to it. After considering how we might add it back in I decided that as it stands it wasn't a well maintained list and should be re-implimented in the future in a more consistent form if we miss it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:48:31 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98577|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 98640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98640&action=edit Bug 19735: Add support for max_ver This patchset adds support for extracting 'max_ver' from the cpanfile so we can use version ranges properly and report errors if we have modules installed that do not fit within that version range. Test plan: 1) Manually modify the module version of a required module in the cpanfile to have a max version greater than the version you have installed. 2) Run through the install proceedure and note the new warning that a module needs upgrade for the module in question. 3) The module should also be reported in the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:49:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:49:45 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:50:04 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 09:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 08:50:18 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:17:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:17:40 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #11 from Martin Renvoize --- Created attachment 98641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98641&action=edit Bug 24525: (QA follow-up) Make payment type required with cash registers The use of cash registers adds the requirement to enter a payment type, this patch adds the required status when cash registers are configured. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:13 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:15 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:17 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:18 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:20 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:22 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:24 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:26 +0000 Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:28 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:30 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #40 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:32 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:34 +0000 Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:35 +0000 Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:37 +0000 Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a comma In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:39 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:41 +0000 Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:43 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:45 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:46 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:23:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:23:48 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:34:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:34:44 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:55:19 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from David Nind --- Path no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:59:08 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |23894 Status|BLOCKED |Needs Signoff Depends on|23894 | --- Comment #24 from Martin Renvoize --- Thanks for taking this on Julian, I'll just reverse the dependencies and we can unblock this one, it's great to see a new face taking an interest in this work. I'll give it a test later today :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:59:08 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:59:08 +0000 Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:59:58 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 10:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 09:59:58 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:00:37 +0000 Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:00:37 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:00:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:00:51 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:00:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:00:51 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:01:56 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create configuration for |Create configuration for |account types |account credit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:02:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:02:22 +0000 Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #11 from David Nind --- Patch no longer applies because of an issue with bug 18595: Applying: Bug 18595: Unit tests preparing for GetMessagingPreferences move Using index info to reconstruct a base tree... M t/db_dependent/Circulation.t M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t Auto-merging t/db_dependent/Circulation.t Applying: Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences .git/rebase-apply/patch:146: trailing whitespace. This method defines how a user (or a default for a patron category) wants to get a certain .git/rebase-apply/patch:272: trailing whitespace. warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Reserves.pm M circ/returns.pl M misc/cronjobs/advance_notices.pl .git/rebase-apply/patch:146: trailing whitespace. This method defines how a user (or a default for a patron category) wants to get a certain .git/rebase-apply/patch:272: trailing whitespace. warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/advance_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/advance_notices.pl Auto-merging circ/returns.pl Auto-merging C4/Reserves.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18595-Move-C4MembersMessagingGetMessagingPrefe-TcECxc.patch Cannot apply cleanly patches from bug 18595. Everything will be left dirty. git bz apply --continue will not continue the process if patches from other bug reports need to be applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:05:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:05:21 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:05:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:05:21 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account credit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:05:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:05:49 +0000 Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23805 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:05:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:05:49 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23894 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:14:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:14:14 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #17 from Martin Renvoize --- Awesome.. you even added notes for release without prompting! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:16:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:16:49 +0000 Subject: [Koha-bugs] [Bug 24618] New: 856u at Koha 3.16 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24618 Bug ID: 24618 Summary: 856u at Koha 3.16 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: 4363733 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I was wondering how to store a .pdf which can be downloaded by users remotely. Do I need to store it somewhere within the Koha folders, if yes which directory, please? How it's url can be defined if pdf is stored the same server which Koha is installed on. Any example script should be a great help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:16 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:18 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:20 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:20 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:22 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 --- Comment #17 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:23 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98628|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98642&action=edit Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:24 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:26 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 --- Comment #18 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:27 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to suggestions tab in patron account in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 11:17:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 10:17:29 +0000 Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to suggestions tab in patron account in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 12:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 11:22:08 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98482|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 98643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98643&action=edit Bug 24592: Database Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 12:22:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 11:22:11 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98481|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 98644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98644&action=edit Bug 24592: Reword LOST_RETURN to LOST_FOUND This patch updates the wording in the 'lost and found' process to more closely reflect what the process is achieving by replacing 'RETURNED' with 'FOUND' Test plan: 1) Grep codebase for _FixAccountForLostAndReturned and note there are no longer any instanced of it. 2) Run t/db_dependent/Circulation.t and note it passes 3) Test returning/renewing an item that has been marked as lost and note the updated values in the accountlines now use LOST_FOUND as credit_type_code and 'FOUND' as the status for the 'LOST' fee (debit_type_code 'LOST') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 12:48:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 11:48:19 +0000 Subject: [Koha-bugs] [Bug 24618] 856u at Koha 3.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24618 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Marcel de Rooy --- (In reply to Rana from comment #0) > I was wondering how to store a .pdf which can be downloaded by users > remotely. > > Do I need to store it somewhere within the Koha folders, if yes which > directory, please? How it's url can be defined if pdf is stored the same > server which Koha is installed on. > > Any example script should be a great help. Your title mentions a very old Koha version (3.16). This version is not supported anymore for a long time. Koha allows you to upload files with the Tools/Upload feature. It is possible to connect this upload feature to field 856$u. Please check the documentation about it. Since this is a bug tracker, I am closing the report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 12:42:22 +0000 Subject: [Koha-bugs] [Bug 19634] Advanced editor - Rancor - error in display of macro editor in firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634 --- Comment #3 from Nick Clemens --- Still encountering this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 13:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 12:59:28 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #1 from Marcel de Rooy --- At the same time wondering if we not should allow some item subfields to be repeatable just as some under in MARC21 852 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:00:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:00:06 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20882 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:00:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:00:06 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:10:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:10:03 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98485|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 98645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98645&action=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:10:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:10:07 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98486|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 98646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98646&action=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:10:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:10:10 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98487|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 98647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98647&action=edit Bug 24474: Filter out LOST_FOUND -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:10:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:10:15 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #32 from Martin Renvoize --- Created attachment 98648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98648&action=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:28:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:28:03 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96207|0 |1 is obsolete| | --- Comment #7 from Magnus Enger --- Created attachment 98649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98649&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:29:06 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98649|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 98650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98650&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:30:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:30:37 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #9 from Magnus Enger --- (In reply to Stina Hallin from comment #6) > Hello Magnus, I tried the patch, but when testing, Koha gave an error > message when I unchecked the Cancel and Suspend hold check boxes on the Item > types administration side (the error message came after saving). It said > "Error when saving..." The new settings where not saved. Hm, I can't reproduce that problem. But I did have to rebase/update the patch a bit to work with current master. Would you mind trying again now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:45:07 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 --- Comment #2 from Marcel de Rooy --- (In reply to David Cook from comment #1) > biblioitems.url now uses MEDIUMTEXT > > However, I don't think items.uri necessarily need to be the same as > biblioitems.url. Since it is variable length, I dont think making the distinction is needed. The link you gave talks about keeping it under 2048 btw. I would go for MEDIUMTEXT here too for consistency. > With biblioitems.url, multiple URLs are concatenated in the same field, but > items.uri should only ever store 1 URL. Why only ever 1? Our 952$u is derived from 852$u which is a repeatable field. Unfortunately our editor does not yet support it [1]. But the Koha to MARC mapping underneath supports url1 | url2 | url3 etc., like in biblioitems.url. [1] It does not support adding a subfield directly. But if you save url1 | url2 in $u and reopen the item record, the field is cloned for you. Editing and savin g again is supported now too. Which is something that we wanted to prevent on bug 21800 but luckily we did not yet so far ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:49:46 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:53:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:53:42 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96274|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 98651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98651&action=edit Bug 24157: New permission - reopen_closed_invoices New permission to reopen a closed invoice. Test plan: - Remove the new permission "reopen_closed_invoices" for a given patron, use it to log in into Koha - Create an invoice, close it => You are not able to reopen the invoice - Add the permission => You are able to reopen the invoice Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:53:45 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96275|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 98652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98652&action=edit Bug 24157: New permission - edit_invoices Add a new permission to edit invoices Test plan: - Remove the new permission "edit_invoices" for a given patron, use it to log in into Koha - Create an invoice, edit it (click "detail") => You can see the detail of the invoice, but cannot edit it. It's a read-only view. - Add the permission => The form is back and you can modify the invoices and save the changes. Also, you are able to create adjustments. Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:53:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:53:49 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96276|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 98653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98653&action=edit Bug 24157: Add new method Acq::Invoice::Adjustement->fund Moving to its own commit in case we want to cherry-pick or move it to its own bug report. Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:53:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:53:52 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96277|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 98654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98654&action=edit Bug 24157: New permission - delete_invoices Add a new permission to delete invoices Test plan: - Remove the new permission "delete_invoices" for a given patron, use it to log in into Koha - Create an invoice, try to delete it => There is no way to delete it - Add the permission => Now you can delete the invoice Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:53:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:53:55 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96278|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 98655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98655&action=edit Bug 24157: New permission - delete_baskets Add a new permission to delete acquisition baskets Test plan: - Remove the new permission "delete_basket" for a given patron, use it to log in into Koha - Create basket, try to delete it => There is no way to delete it - Add the permission => Now you can delete the basket Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:54:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:54:16 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Rebased to allow the application to sandboxes for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:55:22 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #9 from Emmi Takkinen --- Christofer, you mean "Edit this holiday"? Tried it with this patch applied (and on master) and edit indeed applies only to the first day. I'm not sure is this behaviour intended or is it something that needs to be fixed. However deleting on range worked as it should for me. I tried scenario from the screenshot and also retested with other deleting options without any problems. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:55:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:55:49 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #1 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #0) > Koha allows you to add new item subfields using the more_subfields_xml field > in the items field. They can be marked as repeatable and adding/editing and > deleting them works nicely. On current master dd 2/20 clicking the clone button creates an unaligned text box in the item editor. But saving and reediting works. Deleting is done by clearing the text box. Perhaps adding a delete button just like in cataloging should be nicer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:56:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:56:21 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #0) > But the item table on the MARC view in the staff catalog displays only the > last of the repeated subfields. Still a problem. Does also occur on MARC view in OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:56:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:56:48 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:56:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:56:50 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94637|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 98656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98656&action=edit Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:58:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:58:18 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13574 CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > [1] It does not support adding a subfield directly. But if you save url1 | > url2 in $u and reopen the item record, the field is cloned for you. Editing > and savin g again is supported now too. Which is something that we wanted to > prevent on bug 21800 but luckily we did not yet so far ;) Not even completely true. In master you can set the item field repeatable and you have a clone button. It acts a bit weird but works. See bug 13574. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:58:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:58:18 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20882 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:59:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:59:22 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #10 from Christofer Zorn --- Hello Emmi, I was able to follow the test plan and it worked for single holidays. I created one for a week, then tried to edit it following the test plan again. It adjusted only the first day. I'm not sure if the bug fix was intended to handle a range of holidays, or just edit the single one. Perhaps I should be deleting the range and reapplying it rather than trying to stretch this functionality. I'm new to this signing off thing and may have overstepped what is expected of me. Thanks! Christofer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:59:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:59:36 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98656|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 98657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98657&action=edit Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 14:59:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 13:59:54 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:01:18 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #33 from Martin Renvoize --- (In reply to David Nind from comment #28) > For whatever reason I can't seem to get the 'onpayment' option to show up > for MarkLostItemsAsReturned. (Applied patch, ran database update, > restart_all). Doh! I missed a file when committing.. that should now be resolved. The test failure we're actually in the dependancy bug.. I've resolved them there and rebased this patchset upon them now. Cheers for testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:13:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:13:09 +0000 Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting pickup' tables allowing to print both tables separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #6) > There is a bit of weird behavior depending on screen size, as the table > always 'centers' We should add "autowidth: false" to the global DataTables configuration because I don't think there's any case where we don't want it. Doing so would help here I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:18:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:18:23 +0000 Subject: [Koha-bugs] [Bug 24618] 856u at Koha 3.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24618 --- Comment #2 from Owen Leonard --- Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:26:53 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #84 from Julian Maurice --- Resetting status to Needs Signoff now that bug 24410 is pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:31:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:31:46 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:31:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:31:49 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 --- Comment #4 from Marcel de Rooy --- Created attachment 98658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98658&action=edit Bug 20882: Move items.uri to mediumtext Applies to items and deleteditems. Test plan: Run new install or upgrade. Check field size. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:32:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:32:03 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:36:19 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98564|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 98659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98659&action=edit Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:36:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:36:23 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #26 from Martin Renvoize --- Created attachment 98660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98660&action=edit Bug 17702: (QA follow-up) Add new field to kohastructure Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:36:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:36:58 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |julian.maurice at biblibre.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:37:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:37:22 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Martin Renvoize --- Thanks for taking this on Julian, it's all looking good to me, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:37:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:37:47 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:37:49 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98658|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 98661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98661&action=edit Bug 20882: Move items.uri to mediumtext Applies to items and deleteditems. Test plan: Run new install or upgrade. Check field size. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:45:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:45:44 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #6 from Lucas Gass --- Cait, Syndetics sends HTML. So a description might look like this:

    Dementors and House-elves, merpeople and Chinese Fireball Dragons--these are just a few of the magical creatures and frightening monsters populating J. K. Rowling's wizarding world. Harry Potter: The Creature Vault is a fascinating look at how this menagerie was brought to life for the blockbuster Harry Potter film series. Detailed profiles of each creature include rare concept illustrations, behind-the-scenes photography, and filmmaking secrets from the Warner Bros. archive. A removable poster picturing each of the creatures and an interactive Eeylops Owl Emporium catalog complete this must-have package.

    Librarians would like this to $raw filter on the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 15:47:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 14:47:09 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #11 from Katrin Fischer --- > I'm new to this signing off thing and may have overstepped what is expected > of me. Don't worry, you are doing really well - we expect people to question and comment :) Nothing bad about that! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:03:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:03:50 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:13:35 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95325|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 98662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98662&action=edit Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice This patch re-arrange the manualinvoice controller script to clarify code flow, replaces the last call to C4::Accounts::manualinvoice with a call to Koha::Accounts->add_debit wrapped in a try catch block. It also adds a check on passed barcodes when the invoice type is 'LOST' so it can link the subsequently created accuntline to the item and issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:13:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:13:39 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95326|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 98663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98663&action=edit Bug 22393: (follow-up) Handle deleted items This patch adds fallback handling to looking items in the old items table if they're not found in the items table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:14:04 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #15 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:27:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:27:56 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:27:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:27:59 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #3 from Marcel de Rooy --- Created attachment 98664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98664&action=edit Bug 13574: Fix display of repeatable item subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:28:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:28:17 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #4 from Marcel de Rooy --- Not ready yet ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:29:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:29:37 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 --- Comment #6 from Marcel de Rooy --- (In reply to Nick Clemens from comment #5) > Signed-off-by: Nick Clemens Thx for very fast SO ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:38:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:38:35 +0000 Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron profile in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:39:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:39:59 +0000 Subject: [Koha-bugs] [Bug 15563] Cronjob to regularly delete patroncard and label batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:40:30 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Nick Clemens --- (In reply to Myka Kennedy Stephens from comment #5) > The bibliographic records I tested came from the Library of Congress Z39.50 > server: > #1 - ISBN 9781540960573 > #2 - ISBN 9789004130784 > #3 - ISBN 9781532653308 I applied the patches, imported the three records, and saved multiple times - the authorities were generated once, and didn't happen again, everything correctly relinked. There is the possibility that your linker was set to 'Default' and so not linking because there were duplicates in the system and the Default linker only links if a single record is returned. Can you retest with 'First' or 'Last' match linker, and or clearing out the duplicates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:46:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:46:57 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:47:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:47:18 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #46 from Martin Renvoize --- Looks promising, but needs a rebase I'm afraid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:47:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:47:58 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:48:31 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 --- Comment #12 from Martin Renvoize --- Any update on testing here Magnus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:50:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:50:24 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:51:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:51:28 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ILL |Hold requests CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:52:21 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #10 from Martin Renvoize --- This is more of a general enhancement than purely an ILL feature.. as such I've set the status's accordingly to try and expose it to a few more interested parties and get it moving. Looks like a reasonable implementation to me so far :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:52:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:52:48 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:52:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:52:51 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98657|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98668&action=edit Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:55:40 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #11 from Martin Renvoize --- Created attachment 98669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98669&action=edit Bug 22833: Schema update, DO NOT PUSH Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:55:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:55:43 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #12 from Martin Renvoize --- Created attachment 98670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98670&action=edit Bug 22833: Flag booleans in Itemtype.pm Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:55:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:55:46 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #13 from Martin Renvoize --- Created attachment 98671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=edit Bug 22833: Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:56:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:56:06 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:56:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:56:13 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:56:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:56:21 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 16:56:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 15:56:34 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- Works well for me, Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:05:40 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- `error: sha1 information is lacking or useless (acqui/neworderbiblio.pl).`.. any chance of a rebase on this one Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:10:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:10:02 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 --- Comment #13 from Magnus Enger --- Trying to get round to it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:34:45 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #85 from Laurence Rault --- tested on biblibre sandbox1 all tests OK One remark on test 6 : when there are several items, and hold is placed on title, there is no warn when checking out on item, OK. I think we could be warned if all items are checked out with overlap, maybe when checking out the last available item, as no more item is available for hold then. But this could be be an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:36:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:36:12 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #86 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:36:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:36:29 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:36:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:36:39 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #87 from sandboxes at biblibre.com --- Created attachment 98672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98672&action=edit Bug 15261: Check if checkout/reserve request overlaps existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. - A user places a hold from opac whose requested period overlaps with an existing reserve period => prevent reserve - A librarian places a hold from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) - A librarian makes a checkout from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): - Place a hold on title (which has only one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are warned about an existing reserve 2 (staff side): - Place a hold on title (which has more than one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): - Place a hold on item level with start date and expiration date. - Place another hold on item level with period overlaping this reserve. - Check you are warned about an existing reserve. 4 (opac side): - Do the same than for staff side. Instead of a warn, reserve is prevented. 5: - Place a hold on title (which has only one items) level with start date and expiration date. - Try to checkout the unique item from this title with period overlaping the reserve period. - Check you are warned about an existing reserve 6: - Place a hold on title (which has more than one items) level with start date and expiration date. - Checkout an item from this title with period overlaping the reserve period. - Check you are NOT warned about an existing reserve. 7: - Place a hold on item level with start date and expiration date. - Checkout this item period overlaping the reserve period. - Check you are warned about an existing reserve 8: - Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}), - Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30 days}), - Check that you cannot renew the checkout. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:38:02 +0000 Subject: [Koha-bugs] [Bug 24485] AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:53:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:53:31 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:53:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:53:35 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98645|0 |1 is obsolete| | --- Comment #34 from David Nind --- Created attachment 98673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98673&action=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:53:38 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98646|0 |1 is obsolete| | --- Comment #35 from David Nind --- Created attachment 98674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98674&action=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:53:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:53:42 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98647|0 |1 is obsolete| | --- Comment #36 from David Nind --- Created attachment 98675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98675&action=edit Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:53:46 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98648|0 |1 is obsolete| | --- Comment #37 from David Nind --- Created attachment 98676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98676&action=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 17:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 16:57:43 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #38 from David Nind --- Now works as outlined in the test plan! I re-ran the tests after signing off and one test fails: root at 314245d82a59:koha(bz24474)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 30/47 # Failed test 'Should have a single 10 days overdue fine and lost charge' # at t/db_dependent/Circulation.t line 2344. # got: '27' # expected: '17' # Looks like you failed 1 test of 3. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2347. # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 31/47 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2347. t/db_dependent/Circulation.t .. 47/47 # Looks like you failed 1 test of 47. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/47 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 256 Tests: 47 Failed: 1) Failed test: 31 Non-zero exit status: 1 Files=1, Tests=47, 29 wallclock secs ( 0.08 usr 0.00 sys + 23.90 cusr 2.79 csys = 26.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:57:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 17:57:09 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 18:57:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 17:57:09 +0000 Subject: [Koha-bugs] [Bug 24619] New: Phase out jquery.cookie.js: MARC Frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Bug ID: 24619 Summary: Phase out jquery.cookie.js: MARC Frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 The MARC Framework page uses a cookie to set a preference for whether to "display only used tags/subfields." This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:18:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:18:25 +0000 Subject: [Koha-bugs] [Bug 24620] New: Existing transfers not closed when hold is set to waiting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 Bug ID: 24620 Summary: Existing transfers not closed when hold is set to waiting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:18:51 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:18:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:18:53 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 --- Comment #1 from Owen Leonard --- Created attachment 98677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98677&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:24:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:24:00 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:24:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:24:03 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 --- Comment #1 from Nick Clemens --- Created attachment 98678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98678&action=edit Bug 24620: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:24:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:24:05 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 --- Comment #2 from Nick Clemens --- Created attachment 98679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98679&action=edit Bug 24620: Close existing transfers when setting item to waiting This patch adds a clause in ModReserveAffect to check if there are existing transfers and close them when setting a hold to waiting To test: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting 9 - Apply patch 10 - Delete hold and repeat 11 - Confirm that transfer is closed when hold marked waiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:45:33 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:45:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:45:36 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98643|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 98680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98680&action=edit Bug 24592: Database Update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:45:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:45:40 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98644|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98681&action=edit Bug 24592: Reword LOST_RETURN to LOST_FOUND This patch updates the wording in the 'lost and found' process to more closely reflect what the process is achieving by replacing 'RETURNED' with 'FOUND' Test plan: 1) Grep codebase for _FixAccountForLostAndReturned and note there are no longer any instanced of it. 2) Run t/db_dependent/Circulation.t and note it passes 3) Test returning/renewing an item that has been marked as lost and note the updated values in the accountlines now use LOST_FOUND as credit_type_code and 'FOUND' as the status for the 'LOST' fee (debit_type_code 'LOST') Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 19:48:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 18:48:38 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Here is an updated test plan (I had to work out how to do some of the things, so I hope it is useful to others and what was intended to check): 1) Apply the patch and run the database update (perl installer/data/mysql/updatedatabase.pl) 2) Grep th codebase for _FixAccountForLostAndReturned and note there are no longer any instanced of it (grep -r1 "_FixAccountForLostAndReturned" koha) 3) Run t/db_dependent/Circulation.t and note it passes 4) For a patron: - Check out an item (Circulation > Check out) - Create a manual invoice for the item using the 'Lost item' type (Patrons > [Account for patron] > Accounting > Create manual invoice > Enter the barcode and amount) - Edit the record for the item and change the 'Lost status' to 'Lost' (From the list of transactions click on the barcode, and change the 'Lost status' to 'Lost' and then 'clcik 'Set status') - Check in the lost item (Circulation > Check in) - A message should pop up saying 'Item was lost, now found.....' - Check the transactions for the patron: there should now be a transaction with a refund, the account type will say 'Lost item fee refund', and in the description it will say 'Item found...' 5) Check the database to see the changes: - koha-mysql kohadev - Use the query 'select * from accountlines' - For the original manual invoice the debit_type_code will show as 'LOST' and the status will show as 'FOUND' - For the transactions to reverse the lost item fee the credit_type_code will show as "LOST_FOUND' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:01:36 +0000 Subject: [Koha-bugs] [Bug 24621] New: Phase out jquery.cookie.js: Basic MARC editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Bug ID: 24621 Summary: Phase out jquery.cookie.js: Basic MARC editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 The basic cataloging editor uses cookies to set preferences for whether to show tag numbers or MARC documentation links. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:01:36 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:15:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:15:41 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:15:45 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 --- Comment #14 from David Nind --- Created attachment 98682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98682&action=edit Bug 21156: (RM follow-up) Add missing filters Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:15:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:15:49 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98626|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 98683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98683&action=edit Bug 3137: HideFieldsPatronAddForm syspref This patches adds a syspref - HideFieldsAddPatronFrom - that controls which fieldsets are hidden by default in the add patron form. To test: 1) Apply patch and update database 2) Go to System preferences and confirm HideFieldsPatronAddForm has no fields selected 3) Go to add a patron / edit an existing patron (any patron category). confirm everything still works as expected. 4) Tick some of the fields in the syspref to hide them in the form 5) Go back to add patron form. 6) Confirm these fields are hidden and listed at the top of the page 7) Toggle the checkbox and confirm the hidden fields show or hide as expected. 8) Go back to the HideFieldsPatronAddForm system preference and ensure the Main address option is checked to be hidden 9) Go to the patron's details page 10) Click to edit the Contact Information section 11) Confirm the Main address option shows and the checkbox to show hidden fields is not present. 12) Confirm you can click the legend of each section to show and hide sections Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:19:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:19:16 +0000 Subject: [Koha-bugs] [Bug 24622] New: Restrict Circulation by price Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24622 Bug ID: 24622 Summary: Restrict Circulation by price Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: christofer.zorn at ajaxlibrary.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hello All! Thank you for all the work you're doing on things like this. I know we can currently restrict circulation by quantity, saying that someone can borrow up to a certain number of items concurrently (in our case it is 50). Has it ever been discussed, or is it even possible to restrict based on the sum of the replacement value being under a defined amount? We're looking at this from a risk management standpoint and asking if it is reasonable to allow a patron to borrow one iPad, one Chromebook, one Launchpad device, etc and have say 10 items out that carry a total replacement value of $2000? It would be great to limit our exposure to loss by preventing patrons from being able to borrow more than $1500 of our material concurrently. We are not trying to prevent people from borrowing things, but simply mitigating our risk on not having those items brought back and having to send someone to collections with little to no hope of recovery. Thank you again! Christofer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:21:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:21:12 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:21:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:21:14 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 --- Comment #1 from Owen Leonard --- Created attachment 98684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98684&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply tThiss he patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:25:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:25:11 +0000 Subject: [Koha-bugs] [Bug 24623] New: Phase out jquery.cookie.js: Advanced MARC editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24623 Bug ID: 24623 Summary: Phase out jquery.cookie.js: Advanced MARC editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 The advanced cataloging editor uses a cookie to set the user's preference for whether to use the advanced cataloging editor by default. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:25:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:25:11 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24623 [Bug 24623] Phase out jquery.cookie.js: Advanced MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:32:52 +0000 Subject: [Koha-bugs] [Bug 24624] New: Phase out jquery.cookie.js: Receipt summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Bug ID: 24624 Summary: Phase out jquery.cookie.js: Receipt summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 In acquisitions, the receipt summary page uses cookies to remember the settings in the sidebar filter. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:32:52 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 [Bug 24624] Phase out jquery.cookie.js: Receipt summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:44:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:44:48 +0000 Subject: [Koha-bugs] [Bug 12410] Remove useless use of cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12410 --- Comment #1 from Owen Leonard --- The only reason I can think of that we would want to change this is if we're concerned about the 365-day expiration of these cookies. Is there another factor behind this bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:52:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:52:12 +0000 Subject: [Koha-bugs] [Bug 24625] New: Phase out jquery.cookie.js: showLastPatron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 Bug ID: 24625 Summary: Phase out jquery.cookie.js: showLastPatron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 The showLastPatron feature uses cookies to store information about last searched patron in the staff client. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 20:52:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 19:52:12 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 [Bug 24625] Phase out jquery.cookie.js: showLastPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 21:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 20:01:15 +0000 Subject: [Koha-bugs] [Bug 24622] Restrict Circulation by price In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24622 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 22:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 21:29:21 +0000 Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification or deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z --- Comment #13 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 22:30:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 21:30:22 +0000 Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 --- Comment #18 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:01:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:01:23 +0000 Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #11 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:01:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:01:37 +0000 Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #15 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:01:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:01:48 +0000 Subject: [Koha-bugs] [Bug 24503] Missing use in value builder barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:11:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:11:05 +0000 Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #5 from Joy Nelson --- not pushed to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:11:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:11:05 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug 23996 depends on bug 24509, which changed state. Bug 24509 Summary: API related tests failing on MySQL8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:29:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:29:12 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #17 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:30:18 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #28 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:31:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:31:26 +0000 Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #5 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:31:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:31:45 +0000 Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:32:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:32:09 +0000 Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified email column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #6 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:32:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:32:26 +0000 Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #9 from Joy Nelson --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:37:57 +0000 Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com --- Comment #15 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:37:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:37:58 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24448, which changed state. Bug 24448 Summary: Add Koha::Biblio->subscriptions_count https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:37:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:37:58 +0000 Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Bug 24467 depends on bug 24448, which changed state. Bug 24448 Summary: Add Koha::Biblio->subscriptions_count https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:39:23 +0000 Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were triggered. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #8 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:39:23 +0000 Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from `comments` to `reason` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Bug 24296 depends on bug 24287, which changed state. Bug 24287 Summary: Transfers should record how they were triggered. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:40:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:40:10 +0000 Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from `comments` to `reason` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #14 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:40:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:40:10 +0000 Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 Bug 23432 depends on bug 24296, which changed state. Bug 24296 Summary: Move stock rotation transfer triggers from `comments` to `reason` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:40:11 +0000 Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bug 24298 depends on bug 24296, which changed state. Bug 24296 Summary: Move stock rotation transfer triggers from `comments` to `reason` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:40:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:40:58 +0000 Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #11 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:41:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:41:41 +0000 Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com --- Comment #7 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:42:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:42:41 +0000 Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation in staged MARC record management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:43:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:43:09 +0000 Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron Modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #11 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:44:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:44:25 +0000 Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #13 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:44:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:44:39 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:44:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:44:52 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:56:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:56:13 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com --- Comment #11 from Joy Nelson --- Backported to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 10 23:56:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 22:56:31 +0000 Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #5 from Joy Nelson --- Backported to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:03:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:03:26 +0000 Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #21 from Joy Nelson --- Backported to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:15:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:15:50 +0000 Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #30 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:19:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:19:46 +0000 Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #11 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:20:12 +0000 Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #31 from Joy Nelson --- Feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:20:12 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug 23590 depends on bug 23594, which changed state. Bug 23594 Summary: Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:20:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:20:38 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #20 from Joy Nelson --- New feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:21:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:21:28 +0000 Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #10 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:21:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:21:28 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Bug 24569 depends on bug 23031, which changed state. Bug 23031 Summary: Improve UX of buttons on order search page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:23:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:23:03 +0000 Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method "search" via package "Koha::Account::DebitTypes" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:23:28 +0000 Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference description to make clear where it will apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:23:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:23:44 +0000 Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:29:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:29:40 +0000 Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:30:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:30:04 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #11 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:30:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:30:31 +0000 Subject: [Koha-bugs] [Bug 24626] New: error en RunSQL.pm line 273. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24626 Bug ID: 24626 Summary: error en RunSQL.pm line 273. Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: xavierxamora at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 98685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98685&action=edit image with the error that comes out install koha on ubuntu 16.04.06 versions 19.11 and 19.05 and I get the same error as this [Mon Feb 10 17:12:17 2020] install.pl: DBD :: mysql :: st execute failed: Cannot delete or update a parent row: a foreign key constraint fails at /usr/share/perl5/DBIx/RunSQL.pm line 273. I am doing my university stay and at the time of installation I get this, some solution; I am occupying mariadb 10.0.38 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:40:11 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #162 from Joy Nelson --- Not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:40:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:40:12 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Bug 15522 depends on bug 18936, which changed state. Bug 18936 Summary: Convert issuingrules fields to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:40:14 +0000 Subject: [Koha-bugs] [Bug 23323] Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Bug 23323 depends on bug 18936, which changed state. Bug 18936 Summary: Convert issuingrules fields to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:40:14 +0000 Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should be 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Bug 24602 depends on bug 18936, which changed state. Bug 18936 Summary: Convert issuingrules fields to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:16 +0000 Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on x-koha-embed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #17 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:16 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24528, which changed state. Bug 24528 Summary: Add a syntax for specifying counts on x-koha-embed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:17 +0000 Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Bug 24467 depends on bug 24528, which changed state. Bug 24528 Summary: Add a syntax for specifying counts on x-koha-embed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:17 +0000 Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 Bug 24554 depends on bug 24528, which changed state. Bug 24528 Summary: Add a syntax for specifying counts on x-koha-embed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:47 +0000 Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:48:48 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24467, which changed state. Bug 24467 Summary: *_count methods should be avoided https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:52:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:52:43 +0000 Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:53:01 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #13 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:53:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:53:17 +0000 Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:58:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:58:02 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #49 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:58:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:58:03 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 19008, which changed state. Bug 19008 Summary: More database cleanups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:58:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:58:04 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Bug 24152 depends on bug 19008, which changed state. Bug 19008 Summary: More database cleanups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:58:47 +0000 Subject: [Koha-bugs] [Bug 24440] Add ->current_item_level_holds to Koha::Acquisition::Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy at bywatersolutions.com Resolution|--- |FIXED --- Comment #30 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 00:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Feb 2020 23:58:47 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24440, which changed state. Bug 24440 Summary: Add ->current_item_level_holds to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:02:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:02:01 +0000 Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #21 from Joy Nelson --- Does not apply to 19.11.x branch not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:02:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:02:47 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy at bywatersolutions.com --- Comment #19 from Joy Nelson --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:02:48 +0000 Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Bug 23534 depends on bug 23533, which changed state. Bug 23533 Summary: Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:02:48 +0000 Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Bug 23536 depends on bug 23533, which changed state. Bug 23533 Summary: Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:03:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:03:18 +0000 Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00, 19.05.08 |19.11.00, 19.05.08, released in| |18.11.14 CC| |hayleymapley at catalyst.net.n | |z --- Comment #5 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:07:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:07:03 +0000 Subject: [Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #7 from Joy Nelson --- dependencies missing in 19.11.x Not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:09:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:09:29 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:09:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:09:48 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:10:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:10:03 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:10:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:10:17 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #13 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:10:32 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:15:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:15:41 +0000 Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #7 from Joy Nelson --- missing dependencies in 19.11.x not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:18:18 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com --- Comment #11 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:18:30 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:18:42 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:19:08 +0000 Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:19:26 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:24:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:24:51 +0000 Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:25:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:25:43 +0000 Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Joy Nelson --- dependencies not in 19.11.x not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:25:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:25:43 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 24525, which changed state. Bug 24525 Summary: Hide SIP payment types from the Point of Sale page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:27:20 +0000 Subject: [Koha-bugs] [Bug 24595] Warnings displayed by Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #5 from Joy Nelson --- missing dependencies in 19.11.x not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 01:47:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 00:47:21 +0000 Subject: [Koha-bugs] [Bug 24627] New: Selecting Club for which to place the hold is missing Box to Select Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Bug ID: 24627 Summary: Selecting Club for which to place the hold is missing Box to Select Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 98686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98686&action=edit select In almost all places in Koha, when a user is given a list of options in the Hold Menu, the option to choose is indicated with either a button to pick or a circle to check. This is indicating a choice has been made. When picking which Club to place a book club book for, there is no indication, that a choice can be made. Yes, the club can be chosen (by clicking the words) but it is not the usual way for Koha, and I think users will be confused. See screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:50:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 03:50:07 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66323|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia --- Created attachment 98687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98687&action=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 03:50:21 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66324|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia --- Created attachment 98688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98688&action=edit Bug 4461: Problem Report Koha objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 04:50:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 03:50:29 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #20 from Aleisha Amohia --- Created attachment 98689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98689&action=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 08:10:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 07:10:25 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #7 from Katrin Fischer --- (In reply to Lucas Gass from comment #6) > Cait, > > Syndetics sends HTML. So a description might look like this: > >

    Dementors and House-elves, merpeople and Chinese Fireball Dragons--these > are just a few of the magical creatures and frightening monsters populating > J. K. Rowling's wizarding world. Harry Potter: The Creature Vault is a > fascinating look at how this menagerie was brought to life for the > blockbuster Harry Potter film series. Detailed profiles of each creature > include rare concept illustrations, behind-the-scenes photography, and > filmmaking secrets from the Warner Bros. archive. A removable poster > picturing each of the creatures and an interactive Eeylops Owl Emporium > catalog complete this must-have package.

    > > > Librarians would like this to $raw filter on the OPAC. Hi Lucas, I understand, I was wondering about Jonathan's suggestion. Whitelisting might actually work if it's only

    etc. but wondering if they send styling information etc. too. Leaning the way that $raw might be safer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 08:53:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 07:53:29 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Stina Hallin --- Tried the patsch again and got this plack error message when I unchecked the box: DBD::mysql::st execute failed: Column 'can_cancel_hold' cannot be null [for Statement "UPDATE `itemtypes` SET `can_cancel_hold` = ?, `can_suspend_hold` = ?, `defaultreplacecost` = ?, `processfee` = ? WHERE ( `itemtype` = ? )" with ParamValues: 0=undef, 1=undef, 2=undef, 3=undef, 4='BK'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. When I tried to uncheck the boxes Koha gave me this message: An error occurred when updating this item type. Perhaps the value already exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:12:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:12:19 +0000 Subject: [Koha-bugs] [Bug 24628] New: Fine grained control over reserve notice recipients Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24628 Bug ID: 24628 Summary: Fine grained control over reserve notice recipients Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org In bug 17014 comment 32 Ray requested a more advanced configurability of reserve notices as quoted below: >No Notice Before parameter: Rather than this being a system preference I see it better as an additional column in the Circulation & Fine rules. This would be configurable line by line (user category / item type) and allow the Koha library to email as many or as few current holders of the non-renewed items as they wished. Libraries that wanted to be more lenient that us could increase the No Renewal Before to 1, 2, or 3, say, but it would be the wise choice of a No Notice Before value that would be the best driver in targeting users whose items are likely to fulfil the reservation / hold. > We have multiple copies of the same item (with various loan periods) out on loan. If a reservation is placed we want to send renewal-failure notification only to users whose copy is due “soon”, and not to people who have, say, just taken a long-term loan copy out. Native Koha auto-renewal functionality currently sees every holder of the item emailed. But the first copy returned satisfies the reservation. Why pester everyone- we want to better target the email. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:12:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:12:35 +0000 Subject: [Koha-bugs] [Bug 24628] Fine grained control over reserve notice recipients In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24628 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:12:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:12:56 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #16 from Magnus Enger --- (In reply to Stina Hallin from comment #15) > Tried the patsch again and got this plack error message when I unchecked the > box: > > DBD::mysql::st execute failed: Column 'can_cancel_hold' cannot be null [for > Statement "UPDATE `itemtypes` SET `can_cancel_hold` = ?, `can_suspend_hold` > = ?, `defaultreplacecost` = ?, `processfee` = ? WHERE ( `itemtype` = ? )" > with ParamValues: 0=undef, 1=undef, 2=undef, 3=undef, 4='BK'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > > When I tried to uncheck the boxes Koha gave me this message: > > An error occurred when updating this item type. Perhaps the value already > exists. Weird. It still works for me. And I double checked that the database is getting updated as it should. Some sources of error I can think of: - Testing with Swedish as the active language in the staff client, without updating the templates (but then you should not see the checkboxes for "Hold can be suspended/cancelled in OPAC", I guess - The db update did not succeed completely. Could you paste the output of "describe itemtypes;" here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:16:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:16:37 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #63 from Martin Renvoize --- Sorry Nick, this one needs a rebase. The coding looks solid to me, and it seems to appease the many. I've opened a new bug to take into account Ray's last comments regarding enhanced control of reserve targets. Once rebased, I'll give this a once over for QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:16:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:16:44 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:25:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:25:04 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Nice, we're in 2020 now, I wonder if things have stablised enough to attempt adding such functionality now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:46:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:46:25 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24161 Depends on|24162 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 [Bug 24161] Late orders improvements - keeping track of claims https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:46:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:46:25 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 [Bug 24388] Useless test in acqui/lateorders.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:46:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:46:25 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24388 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 [Bug 24388] Useless test in acqui/lateorders.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:51:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:51:31 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97125|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 98690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98690&action=edit Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:54:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:54:25 +0000 Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97122|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 98691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98691&action=edit Bug 24163: Allow to define CSV profile for late orders export This new enhancement adds the ability to create a CSV profile for the late orders export. Prior to this, the CSV profile was hardcoded in a template and not editable (unless you modify the .tt file of course). The main difficulty of the request was to make the multiple claims dates accessible from the CSV profile. So far we only accept columns from the database. However we would like to use the Koha::Acquisition::Order object to make things easier (it had a ->claims method to access the different claims). To acchieve this, we are going to accept the TT syntax for that CSV profile. It means that only CSV profiles created for 'late_orders' will have the capability to use the TT syntax (can be extended later of course if needed). The alternative was to use specific placeholders, like %claims_count%, %claimed_date%, but it sounded more powerful and flexible to allow the TT syntax instead. Note that the former export (template based) still exists and is the default option. Test plan: 0. Apply the patches and execute the update database entry 1. Create some orders, close the basket 2. Claim some of the orders 3. Note the new button at the bottom of the table that have several entries. => The first entry will generate a CSV file using the previous method => The second entry will generate it using the new CSV profile, note that the number of claims as well as the different claims date are displayed. 4. Bonus point: Edit the CSV profile (Home › Tools › CSV export profiles) that is named "Late orders (csv profile)", or create a new one, and modify it. Export the late orders using this CSV profile and confirm that the generated CSV file is the one you expect. Sponsored-by: Institute of Technology Tralee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:54:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:54:28 +0000 Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97123|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 98692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98692&action=edit Bug 24163: Add the csv into the DB - as an example Sponsored-by: Institute of Technology Tralee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 09:56:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 08:56:08 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_24162 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:08:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:08:46 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97124|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 98693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98693&action=edit Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:18:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:18:14 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 --- Comment #10 from Martin Renvoize --- Thanks for testing David :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:24:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:24:50 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #67 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #66) > Jonathan: please add my signature to your branch's commits. Done, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:27:40 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #39 from Martin Renvoize --- Hmm, I can't seem to replicate that test failure.. lets see how it goes in the QA run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:33:22 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:33:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:33:26 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96147|0 |1 is obsolete| | Attachment #96148|0 |1 is obsolete| | Attachment #96149|0 |1 is obsolete| | Attachment #96150|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 98694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98694&action=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:33:31 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #48 from Jonathan Druart --- Created attachment 98695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98695&action=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:33:36 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #49 from Jonathan Druart --- Created attachment 98696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98696&action=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:33:40 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #50 from Jonathan Druart --- Created attachment 98697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98697&action=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:46:10 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:46:10 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24347 Resolution|--- |WONTFIX --- Comment #4 from Jonathan Druart --- acqui/neworderbiblio.pl has been removed by bug 24347 and should have fixed the issue reported initially. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:52:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:52:08 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:54:49 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED --- Comment #11 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #10) > Can no longer reproduce this bug in master. This is still valid. 1. hit opac-readingrecord.pl 2. Turn the pref BakerTaylorEnabled on 3. hit again opac-readingrecord.pl => Kaboom! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:54:49 +0000 Subject: [Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Bug 18798 depends on bug 17896, which changed state. Bug 17896 Summary: BakerTaylorEnabled is not plack safe in reading history at the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:55:40 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:55:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:55:50 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 10:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 09:55:56 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:02:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:02:52 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- > 3. hit again opac-readingrecord.pl > => Kaboom! I like your dramatic ending of the test plan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:08:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:08:39 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:25:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:25:02 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:25:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:25:06 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97689|0 |1 is obsolete| | Attachment #97690|0 |1 is obsolete| | Attachment #97691|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 98698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98698&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:25:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:25:10 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #26 from Jonathan Druart --- Created attachment 98699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98699&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:25:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:25:14 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #27 from Jonathan Druart --- Created attachment 98700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98700&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:32:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:32:59 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Hi Andrew, As I'm working on bug 24474 which refines and corrects some issues introduced in bug 22982 I'd be interested to know if you can replicate any of these issues against master at the moment? I was about to mark this one as RESOLVED FIXED as I felt 22982 covered all cases... but if there's still ways to get into this state which I'm unaware of then it needs to stay open and we need to clarify what cases are still open to lead to this situation. Thanks in advance, Martin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:33:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:33:05 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:33:16 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24474 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:33:16 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:38:28 +0000 Subject: [Koha-bugs] [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:45:38 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #14 from Martin Renvoize --- I've tried and failed to replicate this as well I'm afraid... :(. As this appears to be only affecting one installation at this time I'm going to de-escalate it a little so we can concentrate on bugs affecting more users. If you are still having issues, please let us know and perhaps try to narrow down a reproducible test plan for us. As an aside, it's always worth keeping up with the point, bugfix, releases.. It would be sensible to perform such an update to 18.11.13 if you have not already done so.. you may find the bug is fixed there already. Many thanks for your report, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:45:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:45:56 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:46:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:46:49 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #32 from Jonathan Druart --- (In reply to Joy Nelson from comment #31) > Enhancement not backported to 19.11.x I think this change needs to be backported. Or you will have to be meticulous to not backport a ->find call in a list context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:47:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:47:14 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:47:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:47:18 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:47:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:47:24 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 11:54:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 10:54:05 +0000 Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #12 from Emmi Takkinen --- > I'm new to this signing off thing and may have overstepped what is expected of me. Not at all and I'm sorry if my answer made you feel that way. Just wanted to make sure if I understood last part of your comment correctly :) Your comment was totally valid and in my opinion it pointed out possible need for enhancement. I say "in my opinion" since I have no idea if this edit is intended to affect only single days or not and should it be fixed. To make it clear, this patch just adds functionality to copy edits and deletes to all branches at once just the way holidays can be copied to all branches when they are created. So if the changes that are made for single branch are copied to every other branch this patch works as it's intended. I'm still unable to repeat problem with delete as in Katrins screenshot. I added and copied holidays on a range, then deleted them on a range and copied change to all libraries. Delete worked without problem also for the single, weekly, yearly and exception holidays. So Katrin, I have no idea why it's not working you :/ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 12:13:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 11:13:37 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 --- Comment #9 from Martin Renvoize --- I took a look at the code here and found that the renewal case at least 'should' use 'RENEWED' as it's status.. but it appears that AddRenewal is seldom called for renewals, instead, AddIssue is called again and we end up with the 'RETURNED' status. I'm not sure what the worth of having such detailed status's for OVERDUE fines is if I'm honest at this point.. We should be focusing on the state of the fine more than the state of the circulation in these fields and so I would propose 'ACRUING' and 'FIXED' as the status's for OVERDUE's.. (along with 'FORGIVEN' and 'VOID' which are further account states via the staff client actions). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 12:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 11:31:34 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 --- Comment #10 from Martin Renvoize --- To clarify that a little.. Existing states: [%- CASE 'UNRETURNED' -%] (Accruing) # Set when fine is first created and still accruing [%- CASE 'RETURNED' -%] (Returned) # Set in C4::Circulation::AddReturn (can be called via AddIssue) [%- CASE 'RENEWED' -%] (Renewed) # Set in C4::Circulation::AddRenewal (can be called via AddIssue, but seldom is) [%- CASE 'REPLACED' -%] (Replaced) # [%- CASE 'REFUNDED' -%] (Refunded) # [%- CASE 'FORGIVEN' -%] (Forgiven) # Inside _FixOverduesOnReturn, if 'exemptfine' is true [%- CASE 'VOID' -%] (Voided) # [%- CASE 'LOST' -%] (Lost) # Set in C4::Circulation::LostItem (if WhenLostForgiveFine is disabled) I think it would make sense to reduce that list to `ACCRUING` and `FIXED` for overdues that are unpaid.. and then allow for 'FORGIVEN', 'VOID', and 'PAID' to signify 'payment' actions on the lines. This may have a knock on effect with our WhenLostForgiveFine handling if the item is subsequently found and returned.. I believe there's another bug already discussing that case however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 12:59:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 11:59:40 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:04:41 +0000 Subject: [Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |WONTFIX --- Comment #2 from Martin Renvoize --- 18.05 is officially end of life at this point and I believe this bug is fixed in more recent versions... certainly, accountno was removed in 19.05, though not backported to 18.11 as far as I'm aware.. at this point, I would suggest we close this bug recommend an upgrade to 19.05 or above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:06:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:06:26 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:06:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:06:29 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90823|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 98701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98701&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:06:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:06:58 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #14 from Jonathan Druart --- Rebased. Remaining occurrences are in tests, should not be a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:14:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:14:32 +0000 Subject: [Koha-bugs] [Bug 12410] Remove useless use of cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12410 --- Comment #2 from Jonathan Druart --- Cookies are returned to the server, then back to the client. I do not think we should use them when not needed, here it is only needed client-side, and can be replaced with local storage. Also, privacy, useless data going through the network, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:19:25 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:19:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:19:31 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98607|0 |1 is obsolete| | Attachment #98608|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart --- Created attachment 98702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98702&action=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Amended-patch: Remove the schema change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:19:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:19:37 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #97 from Jonathan Druart --- Created attachment 98703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98703&action=edit Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:21:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:21:18 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #6 from Jonathan Druart --- Are you using Zebra or Elasticsearch? How many items on the bibliographic record? I am afraid that we cannot help you much without more information. Lowering the severity until the issue is confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:41:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:41:51 +0000 Subject: [Koha-bugs] [Bug 17483] Forgiving charge should apply to item's last fine. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Martin Renvoize --- OK, tried again and still can't replicate this one.. I'm going to close it with WORKSFORME.. if you can still replicate it please open a new bug with a reproducible test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:43:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:43:09 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #15 from Bernardo Gonzalez Kriegel --- It applies now, no (new) qa errors. Just a question: In C4/TAGS.pm you replace scalar grep {/^ $key $/x} @ok_fields with scalar grep { $_ eq $key } @ok_fields Is this correct? The spaces in '/^ $key $/x' are in the matching string (by way of /x), then perhaps scalar grep { $_ eq " $key " } @ok_fields is preferable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:46:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:46:40 +0000 Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23091 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:46:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:46:40 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24376 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:50:28 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #16 from Jonathan Druart --- the 'x' modifier allows whitespaces, so they must be explicitly provided by \w to be taken into account. So I think we are good here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:57:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:57:21 +0000 Subject: [Koha-bugs] [Bug 6383] itemnumber not stored when a lost item is returned and credited to account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6383 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Martin Renvoize --- This will be resolved as a side effect of bug 24592. *** This bug has been marked as a duplicate of bug 24592 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 13:57:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 12:57:21 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #11 from Martin Renvoize --- *** Bug 6383 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:18:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:18:43 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:18:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:18:47 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97395|0 |1 is obsolete| | --- Comment #64 from Nick Clemens --- Created attachment 98704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98704&action=edit Bug 19014: Unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:18:51 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97396|0 |1 is obsolete| | --- Comment #65 from Nick Clemens --- Created attachment 98705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98705&action=edit Bug 19014: Return auto_too_soon before on_reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:18:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:18:55 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97397|0 |1 is obsolete| | --- Comment #66 from Nick Clemens --- Created attachment 98706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98706&action=edit Bug 19014: on_reserve blocks auto_renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:29:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:29:39 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:29:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:29:43 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98701|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 98707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98707&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! Signed-off-by: Bernardo Gonzalez Kriegel Looks correct, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:30:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:30:21 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #18 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #16) > the 'x' modifier allows whitespaces, so they must be explicitly provided by > \w to be taken into account. So I think we are good here. You are right! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 14:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 13:53:01 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:03:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:03:10 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:03:14 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77940|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 98708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98708&action=edit Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:13:02 +0000 Subject: [Koha-bugs] [Bug 24629] New: SIP2 logs garbage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Bug ID: 24629 Summary: SIP2 logs garbage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When looking at the messages SIP2 puts in syslog there are several messages where hashes are printed directly to the log, producing messages like these: Feb 11 09:00:23 koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0) Feb 11 09:00:25 koha koha_sip_koha[13575]: summary_info: list = (HASH(0x55a5b18aea60), HASH(0x55a5b18ae718), HASH(0x55a5b184ef48)... Not very useful? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:18:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:18:02 +0000 Subject: [Koha-bugs] [Bug 24630] New: UNIMARC XSLT Update for bug 7611 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Bug ID: 24630 Summary: UNIMARC XSLT Update for bug 7611 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Add some classes and display authorized values for notforloan statuses based on work from bug 7611 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:18:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:18:29 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Selecting Club for which to |Correct style of clubs |place the hold is missing |search results during hold |Box to Select |process Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Component|Hold requests |Templates Version|19.11 |master --- Comment #1 from Owen Leonard --- It is the usual way if we look at the way patrons are chosen from search results during the hold process. The difference is that search results table of Clubs doesn't have the hover style to help indicate that the rows are clickable. I'm updating the but title to reflect this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:19:20 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:19:22 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #1 from Nick Clemens --- Created attachment 98709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98709&action=edit Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:20:58 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 --- Comment #2 from Kelly McElligott --- Thanks Owen! I had a hard time figuring out the correct words to make this understandable. If others don't have an issue with this way to click, that if fine, I felt it was odd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:21:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:21:12 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #45 from Nick Clemens --- (In reply to Jonathan Druart from comment #44) > Nick, could you confirm it will not break the display for UNIMARC and > NORMARC? NORMARC is no longer maintained according to Magnuse, so we cna ignore that UNIMARC is not affected by these changes - the status for notforloan items remains the same, only substatus is added. The CSS changes rely on classes that don't exist in the UNIMARC xslt I did file bug 24630 and attempt UNIMARC changes, but that should not block this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:25:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:25:58 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98708|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 98710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98710&action=edit Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:28:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:28:05 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Works as expected.. a look through the code doesn't highlight any issues regressions.. I'm tempted to PQA and push and let Jenkins do it's thing here rather than let it languish and require another rebase. As for the note.. I think we're safe with the signature.. the db column name mismatch isn't the first and should likely get cleaned up as a distinct issue upon more to Koha:: PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:28:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:28:10 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:28:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:28:16 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:38:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:38:05 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #21 from Owen Leonard --- This looks like it's working well. I have only one issue: Based on how we handle it with other features/pages which can be deactivated I think this page should return a 404 error if it's not active. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:38:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:38:48 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:38:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:38:51 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #98 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:38:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:38:54 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:38:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:38:55 +0000 Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 15:59:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 14:59:53 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 --- Comment #5 from Andrew Fuerste-Henry --- I have not been able to recreate this on master or 19.05. The example we've got is pretty mystifying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:05:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:05:32 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 --- Comment #6 from Chris Slone --- I believe that one of the bugs shown in the See Also section (8016, 22982, 24474) may have corrected this. This bug was submitted as a related but separate issue to 8016. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:09:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:09:19 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:18:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:18:06 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:18:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:18:43 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98679|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98711&action=edit Bug 24620: Close existing transfers when setting item to waiting This patch adds a clause in ModReserveAffect to check if there are existing transfers and close them when setting a hold to waiting To test: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting 9 - Apply patch 10 - Delete hold and repeat 11 - Confirm that transfer is closed when hold marked waiting Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:19:01 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:36:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:36:10 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Rinrada Wongsaichua changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |hlunlin93 at gmail.com Status|Failed QA |RESOLVED --- Comment #28 from Rinrada Wongsaichua --- Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 Can be fixed by add this one line into /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl 52 $profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} } ); +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, printer_name => 'No Profile'}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:36:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:36:10 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 24001, which changed state. Bug 24001 Summary: Cannot edit card template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:39:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:39:32 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #29 from Jonathan Druart --- (In reply to Rinrada Wongsaichua from comment #28) > Error when saving Patron card Template: > Can't bless non-reference value at > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 > > Can be fixed by add this one line into > /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl > > 52 $profile_list = get_all_profiles({ fields => [ qw( profile_id > printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} > } ); > +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, > printer_name => 'No Profile'}; Can you please provide a patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:39:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:39:33 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 24001, which changed state. Bug 24001 Summary: Cannot edit card template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:39:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:39:39 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:42:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:42:48 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 Tomáš Wünsch changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fraktik at gmail.com --- Comment #6 from Tomáš Wünsch --- I would also love this feature very much. I am trying to learn how to process an complete audit of whole library without moving all those items from shelves to the desk and back or buying laptops just for this purpose. We are obligated to do this every second or fifth year here in Czech Republic, and it is every time quite an operation - we have 10 "big" (20-80k) and 100 small (2-6k of volumes) local libraries. As of now, smoothest solution I see in Android tablets/phablets/phones + dedicated readers (we have USB versions, but I am thinking about buying some Bluetooth variations, any experience or recomendation in this field)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:44:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:44:41 +0000 Subject: [Koha-bugs] [Bug 21927] Acq: Allow blank values in pull downs in the item form when subfield is mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21927 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:44:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:44:54 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #99 from Jonathan Druart --- Created attachment 98712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98712&action=edit Bug 8643: Fix IsMarcStructureInternal tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:46:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:46:37 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 --- Comment #7 from Tomáš Wünsch --- I would also love this feature very much. I am trying to learn how to process an complete audit of whole library without moving all those items from shelves to the desk and back or buying laptops just for this purpose. We are obligated to do this every second or fifth year here in Czech Republic, and it is every time quite an operation - we have 10 "big" (20-80k) and 100 small (2-6k of volumes) local libraries. As of now, smoothest solution I see in Android tablets/phablets/phones + dedicated readers (we have USB versions, but I am thinking about buying some Bluetooth variations, any experience or recomendation in this field)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:47:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:47:54 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #18 from Liz Rea --- is it harmful? Just because you know what to do, doesn't mean everyone does, and the reminder can be useful when you don't do it often. I'm not keen to remove it, but I won't block a follow up doing so. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 16:52:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 15:52:34 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- They are debug messages, if syslog is not configured to log "debug" I would not expect them to be in the logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:14:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:14:38 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #8 from Laura Horgan --- Additionally, I think having an audit trail would be helpful in working with blanket POs. Write now I add notes when changes are made. I use a blanket po to track expenses for our patron driven acquisitions accounts as well as some others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:15:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:15:37 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:15:39 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 --- Comment #3 from Owen Leonard --- Created attachment 98713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98713&action=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:21:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:21:08 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Rinrada Wongsaichua changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #30 from Rinrada Wongsaichua --- (In reply to Jonathan Druart from comment #29) > (In reply to Rinrada Wongsaichua from comment #28) > > Error when saving Patron card Template: > > Can't bless non-reference value at > > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 > > > > Can be fixed by add this one line into > > /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl > > > > 52 $profile_list = get_all_profiles({ fields => [ qw( profile_id > > printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} > > } ); > > +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, > > printer_name => 'No Profile'}; > > Can you please provide a patch? Sorry I'm new here(In reply to Jonathan Druart from comment #29) > (In reply to Rinrada Wongsaichua from comment #28) > > Error when saving Patron card Template: > > Can't bless non-reference value at > > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 > > > > Can be fixed by add this one line into > > /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl > > > > 52 $profile_list = get_all_profiles({ fields => [ qw( profile_id > > printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} > > } ); > > +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, > > printer_name => 'No Profile'}; > > Can you please provide a patch? I'm sorry I'm new for this site, really don't know how to attach patch or create one Basically you just need to add this line into edit-template.pl then issue resolved You'll now able to save patron card template without any error --- /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl on line 52 $profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} } ); ++++++++++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, printer_name => 'No Profile'}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:21:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:21:08 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 24001, which changed state. Bug 24001 Summary: Cannot edit card template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:25:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:25:08 +0000 Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:25:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:25:11 +0000 Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 --- Comment #1 from Jonathan Druart --- Created attachment 98714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98714&action=edit Bug 24614: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:25:15 +0000 Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 --- Comment #2 from Jonathan Druart --- Created attachment 98715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98715&action=edit Bug 24614: Use Koha::Reports from save_report and update_sql In order to get the default value defined at DBMS level, we use Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit methods of C4::Reports::Guided. A second step would be to remove completely those CRUD subroutines and use directly Koha::Reports instead. Test plan: 1. Add and edit some reports 2. Disable memcached, create a report, edit it => Should not crash 3. Make sure the tests make sense and that they pass after the second patch. The error was: DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(), report_name = ?, report_group = ?, report_subgroup = ?, notes = ?, cache_expiry = ?, public = ? WHERE id = ? "] at /kohadevbox/koha/C4/Reports/Guided.pm line 633. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:25:25 +0000 Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:27:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:27:11 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #19 from Jonathan Druart --- I think it's confusing to tell "edit to configure" when it is already supposed to be configured. Letting RM to decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:27:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:27:46 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:27:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:27:49 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98263|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 98716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98716&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:29:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:29:29 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:29:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:29:29 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 24001, which changed state. Bug 24001 Summary: Cannot edit card template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:30:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:30:15 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #31 from Jonathan Druart --- Please do not change the status to "resolved". It is marked resolved once we have a patch pushed into master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:34:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:34:07 +0000 Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 --- Comment #3 from Jonathan Druart --- Andrew, I do not recreate on master. Can you confirm it is fixed? Otherwise can you provide a step-by-step plan to recreate the issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:36:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:36:07 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #32 from Rinrada Wongsaichua --- okay I don't know how it works But I just wanted to share solution that work for me I've tested on my server and issue has been resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:41:19 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98704|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 98717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98717&action=edit Bug 19014: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:41:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:41:23 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98705|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 98718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98718&action=edit Bug 19014: Return auto_too_soon before on_reserve Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:41:28 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98706|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 98719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98719&action=edit Bug 19014: on_reserve blocks auto_renew Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:41:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:41:32 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #70 from Martin Renvoize --- Created attachment 98720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98720&action=edit Bug 19014: (QA follow-up) Update test for AddReserve change Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:42:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:42:35 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #21 from Martin Renvoize --- I think it's OK having the reminder of where the config file is.. we can certainly revisit it at a future date if we decide it's superflous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:43:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:43:38 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #71 from Martin Renvoize --- Works well, passes tests and qa scripts. I can't find any regressions and the code reads well. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:46:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:46:13 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #7 from Jonathan Druart --- Created attachment 98721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98721&action=edit Bug 24586: Add tests Not sure about this approach. Maybe we are hiding a problem coming from somewhere else. Maybe better to handle the error from the callers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 17:59:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 16:59:40 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #5 from Martin Renvoize --- Lets get this one moving again.. lots of great enhancements suggested, but lets start with this bug and build a tree of enhancements later. So.. I think all that's missing is the 'install' action.. I'll take a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:04:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:04:54 +0000 Subject: [Koha-bugs] [Bug 24631] New: Plugin metadata should be outside the main class Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug ID: 24631 Summary: Plugin metadata should be outside the main class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, plugin metadata is stored within the main plugin class file but this means one has to load the class to read it. We should pull this data out into a manifest/metadata file in a standard format (JSON/YAML) to allow simpler external parsing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:05:12 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:05:12 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 [Bug 24631] Plugin metadata should be outside the main class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:07:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:07:02 +0000 Subject: [Koha-bugs] [Bug 24632] New: Plugins should support simple signing for security/varifiability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Bug ID: 24632 Summary: Plugins should support simple signing for security/varifiability Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Plugins are currently simply perl code packed into a zip file.. We should add some form of standardized signing protocol to allow verification and authentication of source code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:07:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:07:25 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/varifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:07:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:07:25 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 [Bug 24632] Plugins should support simple signing for security/varifiability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:08:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:08:37 +0000 Subject: [Koha-bugs] [Bug 24633] New: Add support for gitlab searching of plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 Bug ID: 24633 Summary: Add support for gitlab searching of plugins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As the title says, add support for gitlab to the work started in bug 23975 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:08:51 +0000 Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:08:51 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 [Bug 24633] Add support for gitlab searching of plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:11:11 +0000 Subject: [Koha-bugs] [Bug 24634] New: Support display of changelog files for plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Bug ID: 24634 Summary: Support display of changelog files for plugins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Well maintained plugins should include a changelog file in their package. We should support displaying this changelog from the plugin management pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:11:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:11:17 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- +1 Having to load the class is also a potential security breach, as it allows disabled plugins to execute code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:11:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:11:28 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:11:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:11:28 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 [Bug 24634] Support display of changelog files for plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:12:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:12:55 +0000 Subject: [Koha-bugs] [Bug 24635] New: Support display of readme files for plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 Bug ID: 24635 Summary: Support display of readme files for plugins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 23975, 24634 Well maintained plugins should include a readme file in their package. We should support displaying this readme from the plugin management pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 [Bug 24634] Support display of changelog files for plugins -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:12:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:12:55 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 [Bug 24635] Support display of readme files for plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:12:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:12:55 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 [Bug 24635] Support display of readme files for plugins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:13:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:13:12 +0000 Subject: [Koha-bugs] [Bug 24635] Support display of readme files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24634 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 [Bug 24634] Support display of changelog files for plugins -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:13:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:13:12 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24635 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 [Bug 24635] Support display of readme files for plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:17:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:17:29 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #33 from Rinrada Wongsaichua --- Created attachment 98722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98722&action=edit [PATCH] Bug 24001: Cannot edit card template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:18:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:18:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #294 from Jonathan Druart --- (In reply to Jonathan Druart from comment #290) > Another one (Koha_Master_D9 run 1061): > > koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | # Looks like you planned 114 tests but ran 121. > koha_1 | # Looks like you failed 7 tests of 121 run. > koha_1 | > koha_1 | # Failed test 'pickup_locations' > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > koha_1 | # Looks like you failed 1 test of 4. > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > .............................................. These ones are still failing. Agustín, could you take a look at them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:34:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:34:43 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Laura Horgan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu --- Comment #5 from Laura Horgan --- I would be really interested in getting this to work. In many cases we have multiple editions of a specific textbook and being able to add a date would be helpful. In previous opensource systems we have used (Evergreen) for me this was possible. Sometimes it is possible to add the information to the keyword field but it does not work consistently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 18:57:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 17:57:05 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #295 from Agustín Moyano --- (In reply to Jonathan Druart from comment #294) > (In reply to Jonathan Druart from comment #290) > > Another one (Koha_Master_D9 run 1061): > > > > koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | # Looks like you planned 114 tests but ran 121. > > koha_1 | # Looks like you failed 7 tests of 121 run. > > koha_1 | > > koha_1 | # Failed test 'pickup_locations' > > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > > koha_1 | # Looks like you failed 1 test of 4. > > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > > .............................................. > > These ones are still failing. > Agustín, could you take a look at them? ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:10:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:10:27 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82771|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 98723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98723&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:10:32 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 --- Comment #7 from Josef Moravec --- Created attachment 98724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98724&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form in acquisition Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" in acquisition module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:12:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:12:08 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Josef Moravec --- (In reply to Katrin Fischer from comment #4) > This works well, but can you please add it to the search form in acq too? > While the sequence is different (bug 22122), we currently offer the same > search options there and I think it would be better to not have the forms > drift apart. Does make sense, I've added one more patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:20:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:20:13 +0000 Subject: [Koha-bugs] [Bug 24636] New: Acquisitions planning sections untranslatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Bug ID: 24636 Summary: Acquisitions planning sections untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When you go in Adminitration > Budgets > (Budget) > Planning > Plan by ... (aqplan.pl), the terms for MONTHS, BRANCHES and ITEMTYPES are not translatable. To reproduce: 1. Install another language if you don't already have one 2. Go to Administration > Budgets 3. Click on a budget (or create one if you don't already have one) 4. Click on Planning and choose one of the options (for example Plan by months) 5. Notice at the top it says 'Planning for by MONTHS' 6. Switch languages 7. Notice 'MONTHS' is still in English I looked in my fr-CA-staff-prog.po file and 'MONTHS' is not in there (even after an update). I know it's been like this for several versions, but I can't find a bug report for this. Sorry if it is a duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:49:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:49:16 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 20:49:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 19:49:20 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #22 from Aleisha Amohia --- Created attachment 98725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98725&action=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:11:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:11:57 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:11:59 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98723|0 |1 is obsolete| | Attachment #98724|0 |1 is obsolete| | --- Comment #9 from Michal Denar --- Created attachment 98726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98726&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:12:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:12:04 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 --- Comment #10 from Michal Denar --- Created attachment 98727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98727&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form in acquisition Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" in acquisition module Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:12:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:12:36 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #33 from Joy Nelson --- Rebased and pushed to 19.11.x for 19.11.03 (thanks Nick!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:12:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:12:47 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97404|0 |1 is obsolete| | Attachment #97566|0 |1 is obsolete| | --- Comment #5 from Cori Lynn Arnold --- Created attachment 98728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98728&action=edit Bug 24429: Advanced editor - Add ability to generate an export file as cataloger saves Adds the ability for catalogers to *automatically* save a list of bibs to export as they are cataloging. To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Click on "Export" button (verify a modal window comes up) 4/Click on the link for "New Export File", name the export file 5/Close the modal window 6/Search for a record by entering "specious" in the keyword box and hitting enter 7/Click "import" on a record 8/Make some changes and hit "Save", note the bib number 9/Repeat steps 6-8 for several records, getting records from the catalog and importing through the "import" button in the UI 10/Click on "Export..." button 11/Click on the link for the name you created in step 4 12/Verify the bib numbers from step 8 are in the Export Files Editor 13/Click "Generate Export File" 14/Verify that all the records for every bib listed is in the file generated 15/Repeat steps with different file names / records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:14:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:14:12 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97566|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:14:25 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97404|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:28:54 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #2 from Magnus Enger --- (In reply to Jonathan Druart from comment #1) > They are debug messages, if syslog is not configured to log "debug" I would > not expect them to be in the logs. Are they useful in any way? To me it just says "there were x number of hashes here", not sure if that makes me much wiser? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:30:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:30:22 +0000 Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Andrew Fuerste-Henry --- Can no longer replicate on master. Nevermind! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:47:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:47:44 +0000 Subject: [Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Laura Horgan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu Priority|P5 - low |P3 --- Comment #4 from Laura Horgan --- The marc tags for 776 |w are usually coming from OCLC and not something that is created by our librarians. I think the |w is looking for additional records within the KOHA system and we could use the |w for this if appropriate. When however, you want to send the patron out of the system I think the only way to do this would be to add a KOHA specific code that would allow you to include a link outside the catalog. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 21:50:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 20:50:50 +0000 Subject: [Koha-bugs] [Bug 22108] Items generated through MARCItemFieldsToOrder do not receive values applied in Item Information and Default Accounting Details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22108 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 22:02:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 21:02:36 +0000 Subject: [Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 --- Comment #5 from Katrin Fischer --- (In reply to Laura Horgan from comment #4) > The marc tags for 776 |w are usually coming from OCLC and not something that > is created by our librarians. I think the |w is looking for additional > records within the KOHA system and we could use the |w for this if > appropriate. When however, you want to send the patron out of the system I > think the only way to do this would be to add a KOHA specific code that > would allow you to include a link outside the catalog. Hi Laura, if you don't want Koha to use the $w you can set the UseControlNumber preference accordingly. In our union catalog $w is also used for linking records, but when the linked record is also in Koha, the link works correctly. An example would be a 773$w => 001 link for an analytical and a serial record. At the moment this will only work, if you have 1 $w matching the 001 of another record. It could be discussed, how to improve this further. When I 'built' it, it was certainly influenced by the MARC records I knew from our environment and how I read the standard, but since I have been wondering :) We could also imagine changing the control-number search to a other-control-number search - this could be tested easily with jQuery and if it works better turned into a preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 22:02:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 21:02:49 +0000 Subject: [Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 22:15:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 21:15:23 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #30 from Catherine E. Ingram --- OK... But having NEITHER checked also breaks the rule of keeping behavior as it is when upgrading. That has been my whole point. To your point the email box SHOULD be default checked. (so they keep getting the auto renew emails) The digest box should NOT be checked. If both are not checked they will go from getting way too much email to getting NO emails about automatic renewals. Catherine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:28:54 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96906|0 |1 is obsolete| | --- Comment #20 from ByWater Sandboxes --- Created attachment 98729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98729&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:28:57 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96907|0 |1 is obsolete| | --- Comment #21 from ByWater Sandboxes --- Created attachment 98730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98730&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:29:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:29:00 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96908|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes --- Created attachment 98731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98731&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:29:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:29:02 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96909|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 98732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98732&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:29:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:29:05 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96910|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes --- Created attachment 98733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98733&action=edit Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott Signed-off-by: Christopher Kellermeyer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:37:44 +0000 Subject: [Koha-bugs] [Bug 24637] New: Pay selected & Pay amount does not log branchcode in 19.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Bug ID: 24637 Summary: Pay selected & Pay amount does not log branchcode in 19.05 Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When paying a fine (in 19.05.x) and lower branchcode is not properly logged. I believe this is fixed in 19.11.x by bz23321 To Recreate: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:59:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:59:04 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 11 23:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 22:59:06 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 --- Comment #1 from Lucas Gass --- Created attachment 98734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98734&action=edit Bug 24637: Add brancode in all pay circumstances To TEST: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL 4. Apply patch and restart_all 5. Make a partial payment using both the Pay select and Pay amount buttons. 6. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 7. Now you should see the branchcodes in the table and no NULL values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 00:08:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 23:08:39 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #7) > Created attachment 98721 [details] [review] > Bug 24586: Add tests > > Not sure about this approach. Maybe we are hiding a problem coming from > somewhere else. Maybe better to handle the error from the callers. Agreed. The patch I've attached is a hot fix just to workaround the issue temporarily and I figured I'd share it, but I don't think that it's a complete solution. For a long time, I've been thinking that we should catch errors from Zebra and Zebra libraries, and then display a user-friendly message to users from the calling script. Even something like "Something went wrong. Please contact your system administrator." I think that could actually help surface a lot of existing problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 00:09:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Feb 2020 23:09:55 +0000 Subject: [Koha-bugs] [Bug 24586] Double quote escape doesn't work properly in C4::AuthoritiesMarc::SearchAuthorities with QueryParser enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24586 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #7) > Created attachment 98721 [details] [review] > Bug 24586: Add tests > > Not sure about this approach. Maybe we are hiding a problem coming from > somewhere else. Maybe better to handle the error from the callers. In fact, I forgot to mention it, but my patch will produce duplicate authorities. In the short term, I was ok with making authority duplicates rather than failing a bib import, but that would be a regression in Koha I think. Better to fail rather than return nothing. I just haven't put the time into creating a complete solution as I have competing priorities :/. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:06:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:06:21 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:06:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:06:24 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98238|0 |1 is obsolete| | --- Comment #7 from Myka Kennedy Stephens --- Created attachment 98735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98735&action=edit Bug 24094: Unit tests Signed-off-by: Myka Kennedy Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:06:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:06:28 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98239|0 |1 is obsolete| | --- Comment #8 from Myka Kennedy Stephens --- Created attachment 98736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98736&action=edit Bug 24094: Strip trailing spaces and punctuation from authority headings Both when searching for and creating new authorities we need to remove punctuation that exists in the bibliographic record but does not belong in the authority record. For example, a series with a volume contains a semicolon in the bib record, however, this should not be passed to the authority as the volume is not included in the authority record. To test: 1 - Set AutoCreateAuthorities to 'generate' 2 - Set BiblioAddsAuthorities to 'true' 3 - Set CatalogModuleRelink to 'Do' 4 - Find or create a record with: a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. Eugene M ,$e author an 830 field with a volume preceded by a semicolon: 650$aLord of the rings ;$v 3. 5 - Save the records and check the links 6 - Note punctuation is passed through 7 - Save again, auth records are created again 8 - Apply patch 9 - Save again, new auth records are created again 10 - Check the records, punctuation has been removed 11 - Save again, no more records created. Signed-off-by: Myka Kennedy Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:24:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:24:47 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 --- Comment #9 from Myka Kennedy Stephens --- (In reply to Myka Kennedy Stephens from comment #8) > To test: > 1 - Set AutoCreateAuthorities to 'generate' > 2 - Set BiblioAddsAuthorities to 'true' The setting is actually 'allow' > 3 - Set CatalogModuleRelink to 'Do' 3a - Set LinkerModule to 'First Match' > 4 - Find or create a record with: > a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. > Eugene M ,$e author > an 830 field with a volume preceded by a semicolon: 650$aLord of the > rings ;$v 3. > 5 - Save the records and check the links > 6 - Note punctuation is passed through > 7 - Save again, auth records are created again > 8 - Apply patch > 9 - Save again, new auth records are created again > 10 - Check the records, punctuation has been removed > 11 - Save again, no more records created. [HUGE] CAVEATS - 1. This patch works optimally with Zebra. Results are mixed with ES. It is looking like ES cannot match headings with any type of punctuation--parentheses, hyphens, periods within headings, etc. Further development work will be needed to address this problem with ES. To observe the behavior, test with ES enabled and import/edit ISBN 9789004130784 which includes several subject headings with internal punctuation and a series title heading with parentheses. 2. This patch will strip any trailing punctuation. This includes a period after a middle initial on a personal name heading if that period is not followed by any other punctuation. It would also include the period at the end of a subject heading that ends with etc., B.C., or any other abbreviation in which a period might need to be preserved. This feels like a bandage that would hold for a little while but isn't a long-term fix. Bug #11300 holds a lot of promise to be a long-term fix, especially if the linker could search a Z39.50 server for a record during the cataloging process and import it (or prompt to import) if it doesn't exist. Ideally, this would import the record with the correct punctuation for an authority record while also preserving the punctuation in the bib record. In sum, I'm signing off on this but recognize that it has limitations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:26:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:26:55 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #32 from Myka Kennedy Stephens --- (In reply to Michal Denar from comment #31) > Any test plan? > > > Thanks. +1 - I'd be willing to try and test if there's a test plan. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:54:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:54:29 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:54:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:54:32 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98531|0 |1 is obsolete| | --- Comment #4 from Myka Kennedy Stephens --- Created attachment 98737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98737&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 02:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 01:58:26 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #5 from Myka Kennedy Stephens --- This patch works as expected. I tested with Dewey, LC, and home-grown alpha-numeric call numbers using the 'z Other/Generic classification scheme' and the results were all as expected. I wish I had a larger database of call numbers to test this with to be 100% certain, but from what I could test in the test database it works great and looks like a huge improvement on the current call number browser. Thank you for your great work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 04:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 03:15:33 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- Why would we not use koha-remove and then apt uninstall koha-common then apt autoremove? I'm not sure this bug needs a fix anymore? A developer is going to be using either a devbox or a koha-testing-docker; an average user hopefully will be using Debian packages as advised in our documentation, and certainly, support vendors will be using the packages as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 07:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 06:05:22 +0000 Subject: [Koha-bugs] [Bug 24638] New: UNIMARC Authorities update from IFLA for new Koha installations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Bug ID: 24638 Summary: UNIMARC Authorities update from IFLA for new Koha installations Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org Please, add: 010 - International Standard Name Identifier (ISNI) (new 2016) 017 - Other Identifier (new 2017) 033 - Other System Persistent Record Identifier (new 2012) UNIMARC Authorities, 3rd edition https://www.ifla.org/publications/unimarc-authorities--3rd-edition--updates?og=33 Where to enter authoritative values for 017 $2? EX 1 017 7# $a0000-0002-8038-722X$2orcid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:13:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:13:59 +0000 Subject: [Koha-bugs] [Bug 24639] New: Update libsearch-elasticsearch-perl to 6.00-1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 Bug ID: 24639 Summary: Update libsearch-elasticsearch-perl to 6.00-1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com Buster uses libsearch-elasticsearch-perl 6.00-1 as default https://packages.debian.org/buster/libsearch-elasticsearch-perl We should backport this package to stretch, and set 6.00-1 as the default fyi, currently buster ES tests fail, as Koha defaults to v5 but v6 is installed koha_1 | Test Summary Report koha_1 | ------------------- koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 512 Tests: 4 Failed: 0) koha_1 | Non-zero exit status: 2 koha_1 | Parse errors: Bad plan. You planned 13 tests but ran 4. koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 65280 Tests: 2 Failed: 1) koha_1 | Failed test: 2 koha_1 | Non-zero exit status: 255 koha_1 | Files=484, Tests=10443, 2797.37 wallclock secs ( 4.77 usr 4.35 sys + 1572.95 cusr 561.96 csys = 2144.03 CPU) koha_1 | Result: FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:15:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:15:18 +0000 Subject: [Koha-bugs] [Bug 24639] Update libsearch-elasticsearch-perl to 6.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 [OMNIBUS] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:15:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:15:18 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 [Bug 24639] Update libsearch-elasticsearch-perl to 6.00-1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:15:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:15:53 +0000 Subject: [Koha-bugs] [Bug 24639] Update libsearch-elasticsearch-perl to 6.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:27:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:27:16 +0000 Subject: [Koha-bugs] [Bug 24639] Update libsearch-elasticsearch-perl to 6.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24552 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:27:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:27:16 +0000 Subject: [Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24639 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:34:45 +0000 Subject: [Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 08:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 07:34:45 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 [Bug 24552] Koha does not work with Search::Elasticsearch 6.00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 09:44:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 08:44:44 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #17 from Stina Hallin --- Here's the description of itemtypes: +---------------------+---------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +---------------------+---------------+------+-----+---------+-------+ | itemtype | varchar(10) | NO | PRI | | | | description | longtext | YES | | NULL | | | rentalcharge | decimal(28,6) | YES | | NULL | | | rentalcharge_daily | decimal(28,6) | YES | | NULL | | | rentalcharge_hourly | decimal(28,6) | YES | | NULL | | | defaultreplacecost | decimal(28,6) | YES | | NULL | | | processfee | decimal(28,6) | YES | | NULL | | | notforloan | smallint(6) | YES | | NULL | | | imageurl | varchar(200) | YES | | NULL | | | summary | mediumtext | YES | | NULL | | | checkinmsg | varchar(255) | YES | | NULL | | | checkinmsgtype | char(16) | NO | | message | | | sip_media_type | varchar(3) | YES | | NULL | | | hideinopac | tinyint(1) | NO | | 0 | | | searchcategory | varchar(80) | YES | | NULL | | | can_suspend_hold | tinyint(1) | NO | | 1 | | | can_cancel_hold | tinyint(1) | NO | | 1 | | +---------------------+---------------+------+-----+---------+-------+ We discussed it here, and have a suggestion for solution. Replace: my $can_suspend_hold = $input->param('can_suspend_hold'); my $can_cancel_hold = $input->param('can_cancel_hold'); with: my $can_suspend_hold = $input->param('can_suspend_hold') // 0; my $can_cancel_hold = $input->param('can_cancel_hold') // 0; And replace: [% IF ( HOLD.is_cancelable_from_opac ) %] with: [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( HOLD.biblio.biblioitem.itemtype )) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:10:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:10:53 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:10:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:10:57 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #3 from Jonathan Druart --- Created attachment 98738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98738&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:11:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:11:42 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #4 from Jonathan Druart --- I think this patch will fix the issue you have. Can you confirm? hold skip needs to be tested from return.pl (checkin) and circulation.pl (checkout) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:22:22 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98738|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 98739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98739&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:23:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:23:18 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #3 from Jonathan Druart --- Indeed Magnus, I was missing your point (read too fast). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:23:33 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #4 from Jonathan Druart --- Created attachment 98740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98740&action=edit Bug 24629: SIP log - Display barcode instead of hash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:25:15 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #5 from Jonathan Druart --- (In reply to Magnus Enger from comment #0) > Feb 11 09:00:23 koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has > checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0) This one is weird, it seems that sometimes we have hash and itemnumber: Few lines before the syslog statement: 167 push( @{ $patron->{items} }, $item_id ); But, in renew: 458 foreach my $i (@{$patron->{items}}) { > Feb 11 09:00:25 koha koha_sip_koha[13575]: summary_info: list = > (HASH(0x55a5b18aea60), HASH(0x55a5b18ae718), HASH(0x55a5b184ef48)... Fixed with the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:27:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:27:01 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > (In reply to Magnus Enger from comment #0) > > > Feb 11 09:00:23 koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has > > checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0) > > This one is weird, it seems that sometimes we have hash and itemnumber: > > Few lines before the syslog statement: > 167 push( @{ $patron->{items} }, $item_id ); > > But, in renew: > 458 foreach my $i (@{$patron->{items}}) { then we are using $i->{barcode}, so it is supposed to be a hashref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 10:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 09:51:36 +0000 Subject: [Koha-bugs] [Bug 22332] Limit to currently available items in home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- But does "Limit to currently available items" work for you guys at all? It does not work for me in 19.05.07. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:04:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:04:25 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #42 from Magnus Enger --- Did this fix the "limit to available" for folks? I still can't seem to make it work on 19.05.07 (with Zebra). I do an advanced search for an itemtype and get lots of results, some on loan and some not. Then I click on the "Limit to currently available items" and get zero results. Same result after reindexing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:06:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:06:25 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_24594 --- Comment #3 from Jonathan Druart --- I have pushed the whole tree to a remote branch: https://gitlab.com/joubu/Koha/commits/bug_24594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:13:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:13:30 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:13:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:13:33 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:13:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:13:34 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:13:35 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #43 from Magnus Enger --- (In reply to Magnus Enger from comment #42) > Did this fix the "limit to available" for folks? I still can't seem to make > it work on 19.05.07 (with Zebra). I do an advanced search for an itemtype > and get lots of results, some on loan and some not. Then I click on the > "Limit to currently available items" and get zero results. Same result after > reindexing. Looks like I missed the update to biblios/etc/bib1.att from bug 18098 during an upgrade. Sorry for the noise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:13:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:13:37 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:14:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:14:00 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:28:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:28:50 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #52 from Jonathan Druart --- Created attachment 98741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98741&action=edit Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:37:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:37:27 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 --- Comment #15 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #13) > Created attachment 98476 [details] [review] > Bug 24584: Rewrite optional/sample_quotes to YAML > > YAML version of optional sample_quotes > > To test: > 1) Same test plan of first patch, only check table > quotes I am getting an error with sample_quotes.yml DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value at /kohadevbox/koha/C4/Installer.pm line 502. As it is the only one I think we should fix it at DB level ('timestamp' should be set to the current timestamp) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:43:07 +0000 Subject: [Koha-bugs] [Bug 24640] New: quotes.timestamp should default to current_timestamp Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Bug ID: 24640 Summary: quotes.timestamp should default to current_timestamp Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The quotes.timestamp column is a datetime without default value. It would be better to have it timestamp default current_timestamp() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:43:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:43:27 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to current_timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:43:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:43:35 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24640 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Bernardo Gonzalez Kriegel from comment #13) > > Created attachment 98476 [details] [review] [review] > > Bug 24584: Rewrite optional/sample_quotes to YAML > > > > YAML version of optional sample_quotes > > > > To test: > > 1) Same test plan of first patch, only check table > > quotes > > I am getting an error with sample_quotes.yml > > DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default > value at /kohadevbox/koha/C4/Installer.pm line 502. > > As it is the only one I think we should fix it at DB level ('timestamp' > should be set to the current timestamp) See bug 24640. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 [Bug 24640] quotes.timestamp should default to current_timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:43:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:43:35 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to current_timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 [Bug 24584] Rewrite optional installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:48:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:48:23 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to current_timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 --- Comment #1 from Jonathan Druart --- Wrong assumption. Actually this column is used as "last display at the OPAC". So it can be NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:53:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:53:50 +0000 Subject: [Koha-bugs] [Bug 23840] Overlap of top menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23840 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:54:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:54:27 +0000 Subject: [Koha-bugs] [Bug 23840] IntranetNav causes overlap of top menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23840 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overlap of top menu |IntranetNav causes overlap | |of top menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 11:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 10:56:42 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #2 from Kelly McElligott --- Lucas, I am getting this error: Could not compile /kohadevbox/koha/members/paycollect.pl: Global symbol "@acc" requires explicit package name (did you forget to declare "my @acc"?) at /kohadevbox/koha/members/paycollect.pl line 214. Global symbol "$select" requires explicit package name (did you forget to declare "my $select"?) at /kohadevbox/koha/members/paycollect.pl line 214. Global symbol "$note" requires explicit package name (did you forget to declare "my $note"?) at /kohadevbox/koha/members/paycollect.pl line 215. Global symbol "@lines" requires explicit package name (did you forget to declare "my @lines"?) at /kohadevbox/koha/members/paycollect.pl line 217. Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at /kohadevbox/koha/members/paycollect.pl line 234. Global symbol "@lines" requires explicit package name (did you forget to declare "my @lines"?) at /kohadevbox/koha/members/paycollect.pl line 235. Global symbol "$note" requires explicit package name (did you forget to declare "my $note"?) at /kohadevbox/koha/members/paycollect.pl line 236. syntax error at /kohadevbox/koha/members/paycollect.pl line 241, near ">>" Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at /kohadevbox/koha/members/paycollect.pl line 251. syntax error at /kohadevbox/koha/members/paycollect.pl line 271, near "if" /kohadevbox/koha/members/paycollect.pl has too many errors. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:02:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:02:54 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com Blocks| |24083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:02:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:02:54 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:28:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:28:15 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to current_timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:28:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:28:18 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to current_timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 --- Comment #2 from Jonathan Druart --- Created attachment 98742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98742&action=edit Bug 24640: Allow quotes.timestamp to be NULL It is broken with strict mode enable, timestamp is created without default value. Note that the .sql installer file init the value with NOW(), which is wrong. DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);" with ParamValues: 0="poeut", 1="pouet"] at /kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49. Test plan: Create a new quote of the day => Without this patch you will get an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:28:31 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|quotes.timestamp should |quotes.timestamp should |default to |default to NULL |current_timestamp | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:33:57 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #53 from Jonathan Druart --- Support for YAML files in misc4dev is available in this merge request: https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/37 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:35:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:35:02 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > I have pushed the whole tree to a remote branch: > https://gitlab.com/joubu/Koha/commits/bug_24594 And the support for YAML files in misc4dev: https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/37 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:37:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:37:27 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- This needs to be rebuilt on top of bug 18936. And even bug 15522 I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:56:01 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #36 from Jonathan Druart --- Created attachment 98743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98743&action=edit Bug 19735: Update cpanfile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:57:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:57:52 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Jonathan Druart --- Does not work for me, I get: Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at /kohadevbox/koha/C4/Installer/PerlModules.pm line 55 on about.pl % pmvers CPAN::Meta::Prereqs 2.150005 Debian 9.11 Am I missing something? Also, do we really need the "Bug 19735: Add support for max_ver" patch? Maybe on its own bug report if needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 12:59:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 11:59:47 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #7 from Jawad Makki --- we are using Zebra. some bibliographic records include few items (between 1 to 5 items). other bibliographic records are for Serials, they are including high number of issues (items) that can reach more than 1000 items in some cases. note also that we are using analytical biblio records. so do you think it is an indexing issue with Zebra, there are no errors in Zebra logs, but in zebra-output.log, we are getting thousands of this warning per day 13:56:30-20/01 zebrasrv(17643) [warn] ir_session (exception) 13:56:36-20/01 zebrasrv(17644) [warn] ir_session (exception) 13:56:42-20/01 zebrasrv(17645) [warn] ir_session (exception) 13:56:50-20/01 zebrasrv(17646) [warn] ir_session (exception) 13:56:57-20/01 zebrasrv(17647) [warn] ir_session (exception) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:12:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:12:52 +0000 Subject: [Koha-bugs] [Bug 22332] Limit to currently available items in home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:15:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:15:49 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #38 from Julian Maurice --- (In reply to Jonathan Druart from comment #37) > Does not work for me, I get: > Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at > /kohadevbox/koha/C4/Installer/PerlModules.pm line 55 > > on about.pl > > % pmvers CPAN::Meta::Prereqs > 2.150005 > > Debian 9.11 > > Am I missing something? You need CPAN::Meta 2.150006 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:22:12 +0000 Subject: [Koha-bugs] [Bug 24641] New: Spelling Error is System Preference in description of ClaimReturnedWarningThreshold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24641 Bug ID: 24641 Summary: Spelling Error is System Preference in description of ClaimReturnedWarningThreshold Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the description of the system preference, ClaimReturnedWarningThreshold, " Warn librarians that a patron has excessive return cliams if the patron has claimed the return of more than" The word claims is spelled incorrectly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:34:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:34:25 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #39 from Julian Maurice --- (In reply to Jonathan Druart from comment #37) > Also, do we really need the "Bug 19735: Add support for max_ver" patch? > Maybe on its own bug report if needed? On it own bug or not, it might become useful quickly (for example, see bug 24573) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:46:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:46:09 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #8 from Jonathan Druart --- What are the values of use_zebra_facets and zebra_max_record_size in your config file (koha-conf.xml)? You can ignore the zebrasrv warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:48:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:48:09 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #9 from Jonathan Druart --- Did you check the Koha about page? Tab 'server information', what say the 'PSGI' and 'Memcached'? Tab 'System information', no warnings there? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 13:58:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 12:58:28 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #40 from Jonathan Druart --- (In reply to Julian Maurice from comment #38) > (In reply to Jonathan Druart from comment #37) > > Does not work for me, I get: > > Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at > > /kohadevbox/koha/C4/Installer/PerlModules.pm line 55 > > > > on about.pl > > > > % pmvers CPAN::Meta::Prereqs > > 2.150005 > > > > Debian 9.11 > > > > Am I missing something? > > You need CPAN::Meta 2.150006 Weird, my docker container was not up-to-date, apt update then install fixed the problem. I now have libcpan-meta-perl 2.150010-1 Note that the package is not in buster, Martin, Mason, how is that blocking? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:11:59 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #41 from Julian Maurice --- (In reply to Jonathan Druart from comment #40) > Note that the package is not in buster, Martin, Mason, how is that blocking? CPAN::Meta is included in perl-modules-5.28 in buster -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:19:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:19:06 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #42 from Jonathan Druart --- (In reply to Julian Maurice from comment #41) > (In reply to Jonathan Druart from comment #40) > > Note that the package is not in buster, Martin, Mason, how is that blocking? > > CPAN::Meta is included in perl-modules-5.28 in buster Awesome! Did you investigate those warnings? t/Installer_PerlModules.t .. 1/6 [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Subroutine CORE::GLOBAL::time redefined at /usr/share/perl5/Test/MockTime.pm line 20. [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Prototype mismatch: sub CORE::GLOBAL::time () vs none at /usr/share/perl5/Test/MockTime.pm line 20. [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Subroutine CORE::GLOBAL::localtime redefined at /usr/share/perl5/Test/MockTime.pm line 21. [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Prototype mismatch: sub CORE::GLOBAL::localtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 21. [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Subroutine CORE::GLOBAL::gmtime redefined at /usr/share/perl5/Test/MockTime.pm line 22. [Wed Feb 12 13:16:29 2020] Installer_PerlModules.t: Prototype mismatch: sub CORE::GLOBAL::gmtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 22. t/Installer_PerlModules.t .. ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:24:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:24:13 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #43 from Julian Maurice --- (In reply to Jonathan Druart from comment #42) > Did you investigate those warnings? No. I believe they are here on master too ? (not sure, I haven't checked in a while) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:32:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:32:40 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #44 from Jonathan Druart --- (In reply to Julian Maurice from comment #43) > (In reply to Jonathan Druart from comment #42) > > Did you investigate those warnings? > > No. I believe they are here on master too ? (not sure, I haven't checked in > a while) No, they are not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:14 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:18 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98637|0 |1 is obsolete| | Attachment #98638|0 |1 is obsolete| | Attachment #98639|0 |1 is obsolete| | Attachment #98640|0 |1 is obsolete| | Attachment #98743|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 98744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98744&action=edit Bug 19735: Move Perl deps definitions into a cpanfile cpanfile is a format for describing CPAN dependencies for Perl applications. It is more concise - thus easier to read and maintain - than C4::Installer::PerlDependencies, and allows to describe requirements more accurately (using version ranges or features for instance) Additionally it can be read by tools such as cpanm or carton for an easy way to install dependencies on non-Debian-based systems. For more information on cpanfile, see http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod This patch replace C4::Installer::PerlDependencies by an equivalent cpanfile and update all scripts/modules that were using PerlDependencies It also removes dead code from C4::Installer::PerlModules (some subroutines were not used at all, except in unit tests) Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) Test plan: 1. Go to About page, tab Perl modules and keep this browser tab open 2. Apply patch 3. Install Module::CPANfile and CPAN::Meta a. On Debian-based systems: # will install libcpan-meta-perl as a dependency sudo apt install libmodule-cpanfile-perl b. Others: # will install CPAN::Meta as a dependency sudo cpanm Module::CPANfile 4. In a new browser tab, go to About page, tab Perl modules and compare the table with the one in the previous browser tab They should be identical, except for newly added dependencies (Module::CPANfile and CPAN::Meta) 5. Do a 'standard' install a. perl Makefile.PL (select 'standard') b. make c. sudo make install d. Configure your database, web server, ... and go through the web install process 6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which should be /usr/share/koha/lib) 7. Go to the about page of this fresh install and compare it with your dev install 8. Verify that debian/list-deps still works This takes a lot of time and it may not be necessary to wait until the end. If you see some Debian package names that correspond to modules in cpanfile, it means it still works (you need apt-file for this script to work) 9. Verify that koha_perl_deps.pl still works 10. prove t/Installer_pm.t t/Installer_PerlModules.t Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:23 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #46 from Jonathan Druart --- Created attachment 98745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98745&action=edit Bug 19735: Remove C4::Installer::PerlDependancies This patch does the actual removal of the PerlDependancies module. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:27 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #47 from Jonathan Druart --- Created attachment 98746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98746&action=edit Bug 19735: (QA follow-up) Drop references to 'usage' The 'usage' key was dropped as part of this migration to cpanfile but it was still refered to by the installed. This patch simply removes references to it. After considering how we might add it back in I decided that as it stands it wasn't a well maintained list and should be re-implimented in the future in a more consistent form if we miss it. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:31 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #48 from Jonathan Druart --- Created attachment 98747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98747&action=edit Bug 19735: Add support for max_ver This patchset adds support for extracting 'max_ver' from the cpanfile so we can use version ranges properly and report errors if we have modules installed that do not fit within that version range. Test plan: 1) Manually modify the module version of a required module in the cpanfile to have a max version greater than the version you have installed. 2) Run through the install proceedure and note the new warning that a module needs upgrade for the module in question. 3) The module should also be reported in the about page Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:33:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:33:35 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #49 from Jonathan Druart --- Created attachment 98748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98748&action=edit Bug 19735: Update cpanfile Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:38:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:38:13 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95865|0 |1 is obsolete| | --- Comment #11 from Andrew Isherwood --- Created attachment 98749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98749&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:38:16 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95866|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood --- Created attachment 98750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98750&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:38:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:38:20 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95867|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood --- Created attachment 98751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98751&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:38:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:38:23 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95868|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood --- Created attachment 98752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98752&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:58:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:58:34 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #10 from Jawad Makki --- Created attachment 98753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98753&action=edit Koha about page 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 14:59:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 13:59:15 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #11 from Jawad Makki --- Created attachment 98754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98754&action=edit Koha about page 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:01:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:01:27 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #12 from Jawad Makki --- for use_zebra_facets it is 1 / 1 zebra_max_record_size is missing in my config file (koha-conf.xml) ! should I add it with the default value 1024 or i will increase is to 2 MB (2048) this adjustment requires only to restart Zebra, there is no need to do a full re-index ? right ? concerning "Koha about page", every thing is normal (please check the attached screenshots) PSGI: Plack (deployment) Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_dblibrary | Status: running. | Config read from: koha-conf.xml in system information tab, there is the below warning related to "Patron relationship problems", this warning has appeared after the upgrade from 18.11 to 19.11. we have ignored it since we are not using borrower relationships. Patron relationship problems The following values have been used for guarantee/guarantor relationships, but do not exist in the 'borrowerRelationship' system preference: If the relationship is one you want, please add it to the 'borrowerRelationship' system preference, otherwise have your system's administrator correct the values in borrowers.relationship and/or borrower_relationships.relationship in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:03:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:03:54 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #25 from Jonathan Druart --- (In reply to Kelly McElligott from comment #19) > I am signing off on this bug. To comment on Jonathan's comments. > > > > 2. Click "Show only subscriptions" label does not select the checkbox. > Missing id. > > I created a subscription order and this worked as the other orders did. If > there are no subscriptions then it produces no results which will not let > you move on. The "missing label" thing means that when you click on the label of the checkbox, the checkbox does not check/uncheck. > 3. You can select subscriptions from the 2 tabs then click "Merge selected > invoices". It's expected but as the button is inside the tab (so 2 buttons) > it's not obvious. > > I am not sure what this means? I did merge two invoices and it worked > correctly. If anything the merge button is not as pronounced (no black > outline) The screen is: https://snipboard.io/yjkFzV.jpg The first question is: Are we suppose to merge open and close invoices? The "Merge selected invoices" button is inside the "open invoices" fieldset/block. However, if you select invoices from the "open invoices" and the "closed invoices", the merge button will work. IMO it's ergonomically wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:11:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:11:09 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #13 from Jonathan Druart --- I would try to turn the use_zebra_facets config flag off, restart memcached and plack, then wait and see if the problem appears again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:14:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:14:23 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:14:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:14:50 +0000 Subject: [Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:19:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:19:11 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23312=5D_Add_ability_to_mark_an_ite?= =?utf-8?b?bSDigJhMb3N04oCZIGZyb20g4oCYSG9sZHMgUXVldWUgTGlzdA==?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23312 --- Comment #1 from Sally --- Adding my support for this - it would be really useful to have this functionality in the Holds Queue screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:22:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:22:54 +0000 Subject: [Koha-bugs] [Bug 24642] New: Cache::Memcached::Fast::Safe must be marked as mandatory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Bug ID: 24642 Summary: Cache::Memcached::Fast::Safe must be marked as mandatory Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:24:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:24:00 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #62 from Jonathan Druart --- We are loosing the memcached cache after this change, as the module will not be installed by default and is not required. See bug 24642. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:25:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:25:40 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #63 from Jonathan Druart --- (In reply to Jonathan Druart from comment #62) > We are loosing the memcached cache after this change, as the module will not > be installed by default and is not required. > See bug 24642. I guess it's because the packages are not up-to-date (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:25:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:25:44 +0000 Subject: [Koha-bugs] [Bug 18440] tmp_holdsqueue should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18440 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:26:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:26:05 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 [Bug 13193] Make Memcached usage fork safe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:26:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:26:05 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:26:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:26:33 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:26:35 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 --- Comment #1 from Jonathan Druart --- Created attachment 98755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98755&action=edit Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:26:53 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:29:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:29:50 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:30:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:30:21 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #5 from Jonathan Druart --- Bernardo, could you explain the different use cases here? Is the idea to commit the gz files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:30:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:30:44 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98755|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 98756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98756&action=edit Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:30:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:30:55 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:33:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:33:30 +0000 Subject: [Koha-bugs] [Bug 9979] convert ./C4/Installer/PerlDependencies.pm into a YAML file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 | Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #8 from Jonathan Druart --- Replaced by bug 19735 (using a cpanfile instead). *** This bug has been marked as a duplicate of bug 19735 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:33:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:33:30 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9979 | --- Comment #50 from Jonathan Druart --- *** Bug 9979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:35:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:35:11 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24642 --- Comment #51 from Jonathan Druart --- Either this one or bug 24642 will need to be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:35:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:35:11 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:43:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:43:45 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #6 from Martin Renvoize --- Created attachment 98757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98757&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:43:47 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #7 from Martin Renvoize --- Created attachment 98758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98758&action=edit Bug 23975: Add 'Install' support for github results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:45:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:45:00 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:45:07 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:53:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:53:16 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:53:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:53:19 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 --- Comment #1 from Jonathan Druart --- Created attachment 98759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98759&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 15:55:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 14:55:05 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 16:01:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 15:01:16 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 --- Comment #3 from Lucas Gass --- Kelly, I think this is because this patch is intended for 19.05.x, and maybe you're attempting to apply it to master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 16:30:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 15:30:59 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 16:31:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 15:31:02 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #1 from Jonathan Druart --- Created attachment 98760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98760&action=edit Bug 24469: Record biblionumber in import_biblio when adding to basket via file The column import_biblios.matched_biblionumber was not populated when an order is created from a staged file. Test plan: A/ Create a new order from a stage file. Use the "Save" button at the bottom of the "Add orders from" page Then note the matched_biblionumber value. It should be populated correctly B/ Import again the same record, this time you will have to use the "Add order" link in the list of order (ie. not the "Save" button) Note the matched_biblionumber value. It should be populated correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 16:31:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 15:31:11 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 16:41:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 15:41:16 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #5) > Bernardo, could you explain the different use cases here? I see the following: 1) Compression before release (deb/tar.gz) In this case the installed system will use less space 2) Smaller docker images, perhaps using compressed files from deb/tar > > Is the idea to commit the gz files? I don't think so. I don't know much about git, but I think it would be worse for the size of the repository. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:02:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:02:15 +0000 Subject: [Koha-bugs] [Bug 24643] New: Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Bug ID: 24643 Summary: Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The RFC3339 spec (https://www.ietf.org/rfc/rfc3339.txt) says that the second component of a date/time can contain fractions of a second, e.g. 2011-10-05T14:48:00.000Z This is the format returned by Javascript's toISOString() function. Unfortunately, when dt_from_string encounters a string in this format, it effectively drops the time component entirely and you end up with: 2011-10-05T00:00:00Z The problem lies in the regex that attempts to match the string when dt_from_string is called with the 'rfc3339' parameter. Adding support for optional fractions is straightforward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:09:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:09:56 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:09:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:09:59 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #72 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:10:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:10:02 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:10:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:10:04 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #22 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:16:01 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:18:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:18:10 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:21:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:21:15 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |*Important Note*: You will release notes| |need to make sure you | |install | |`Cache::Memcached::Fast::Sa | |fe` to continue to use | |memcached after this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:22:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:22:52 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98756|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 98761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98761&action=edit Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:23:34 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:24:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:24:51 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:24:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:24:53 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:29:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:29:31 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #1 from Andrew Isherwood --- Created attachment 98762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98762&action=edit Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:29:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:29:34 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #2 from Andrew Isherwood --- Created attachment 98763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98763&action=edit Add unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:30:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:30:44 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:30:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:30:47 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #3 from Andrew Isherwood --- Created attachment 98764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98764&action=edit Bug 24643: Add unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:31:00 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:31:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:31:29 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:31:32 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #52 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:32:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:32:09 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry --- In my testing, matched_biblionumber remains null in test A using the Save button. Test B using the Add order link successfully populated matched_biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:32:50 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:32:50 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 [Bug 24608] Allow modification of checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:36:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:36:43 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves us release notes| |away from custom-built | |dependency management and | |to the widely adopted | |cpanfile format for perl | |dependency listing. | | | |If you | |are running koha from git | |for development purposes | |you can now install perl | |dependencies using standard | |perl tooling and the | |included cpanfile. | | | |This | |patch also introduces the | |ability to set maximum | |versions in our dependancy | |listing (and excluded | |versions too), which should | |help us better track our | |compatibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:37:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:37:21 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed, | |rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:39:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:39:02 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #53 from Martin Renvoize --- Note to RMaints.. this one is up to you whether you wish to backport it.. It removes C4::Installer::PerlDependancies and as such if you're backporting future bugs that require the addition of dependencies after this bug has been pushed, you will need to manually add them to PerlDependancies at backport time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:43:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:43:30 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:53:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:53:57 +0000 Subject: [Koha-bugs] [Bug 24644] New: Hold not marked filled if item set to positive not for loan value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Bug ID: 24644 Summary: Hold not marked filled if item set to positive not for loan value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Confirmed in master and 19.05. To test: 1: make sure AllowNotForLoanOverride is set to allow 2: place a hold on an item with notforloan=0 3: check item in, confirm hold now shows Waiting 4: edit item, set notforloan to any positive value 5: check item out, performing override to allow checkout 6: confirm hold still shows Waiting Not a situation one expects to see often, but confusing when it pops up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 17:54:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 16:54:08 +0000 Subject: [Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:02:33 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:02:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:02:36 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98749|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood --- Created attachment 98765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98765&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:02:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:02:39 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98750|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood --- Created attachment 98766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98766&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:02:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:02:42 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98751|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood --- Created attachment 98767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98767&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:02:45 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98752|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood --- Created attachment 98768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98768&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:07:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:07:25 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #2 from Julian Maurice --- Created attachment 98769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98769&action=edit Bug 24573: Add missing dependencies to cpanfile Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:07:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:07:35 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 --- Comment #16 from Christopher Davis --- (In reply to Fridolin SOMERS from comment #15) > Enhancement not pushed to 19.05.x Hear hear! Yes, please back-port this to 19.05.x. We need it at our site a.s.a.p. Please let me know how I can help make this happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:07:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:07:37 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:07:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:07:51 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Catmandu::Store::ElasticSea |Catmandu::Store::ElasticSea |rch and Catmandu::MARC are |rch and Catmandu::MARC are |missing from |missing from cpanfile |PerlDependencies.pm | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:19:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:19:05 +0000 Subject: [Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:20:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:20:39 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #24 from Martha Fuerst --- Seconding the request to backport this to 19.05. -Marti Fuerst Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:21:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:21:37 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #25 from Lisette Scheer --- (In reply to Martha Fuerst from comment #24) > Seconding the request to backport this to 19.05. > > -Marti Fuerst > Huntsville-Madison County Public Library +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:22:23 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #26 from George Williams (NEKLS) --- If this could be backported to 19.05, we'd appreciate it. George -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:23:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:23:41 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:24:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:24:44 +0000 Subject: [Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:24:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:24:47 +0000 Subject: [Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94455|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 98770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98770&action=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:25:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:25:36 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:26:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:26:58 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:27:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:27:58 +0000 Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:34:12 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:44:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:44:47 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Cori Lynn Arnold --- This is again ready for signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 18:55:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 17:55:54 +0000 Subject: [Koha-bugs] [Bug 24645] New: Review implementation checklist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24645 Bug ID: 24645 Summary: Review implementation checklist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I noticed some information in https://koha-community.org/manual/19.11/en/html/implementation_checklist.html is out of date (among others, the opac customizable sections, which are moving to the news tool). There are probably tons of system preferences that should be added in there too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:24:49 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohadevinim at devinim.com.tr |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:26:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:26:37 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:43:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:43:51 +0000 Subject: [Koha-bugs] [Bug 24646] New: RoundFinesAtPayment is not a self check in preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Bug ID: 24646 Summary: RoundFinesAtPayment is not a self check in preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Ended up in wrong section, assuming just a rebase confusion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:43:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:43:57 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:46:12 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:46:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:46:15 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #1 from Nick Clemens --- Created attachment 98771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98771&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 19:51:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 18:51:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #296 from Agustín Moyano --- (In reply to Agustín Moyano from comment #295) > (In reply to Jonathan Druart from comment #294) > > (In reply to Jonathan Druart from comment #290) > > > Another one (Koha_Master_D9 run 1061): > > > > > > koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | # Looks like you planned 114 tests but ran 121. > > > koha_1 | # Looks like you failed 7 tests of 121 run. > > > koha_1 | > > > koha_1 | # Failed test 'pickup_locations' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > > > koha_1 | # Looks like you failed 1 test of 4. > > > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > > > .............................................. > > > > These ones are still failing. > > Agustín, could you take a look at them? > > ASAP Hi Jonathan, I cannot reproduce failure kohadev-koha at cffdb0ae6429:/kohadevbox/koha$ cat /etc/issue Debian GNU/Linux 9 \n \l kohadev-koha at cffdb0ae6429:/kohadevbox/koha$ prove t/db_dependent/Holds.t t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t t/db_dependent/Holds.t ........... ok t/db_dependent/Koha/Biblios.t .... ok t/db_dependent/Koha/Items.t ...... ok t/db_dependent/Koha/Libraries.t .. ok t/db_dependent/LibraryGroups.t ... ok All tests successful. Files=5, Tests=106, 30 wallclock secs ( 0.08 usr 0.02 sys + 23.13 cusr 3.29 csys = 26.52 CPU) Result: PASS I'm testing in koha-testing-docker with Debian 9.. how are those tests run? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:13:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:13:18 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #297 from Jonathan Druart --- It's t/db_dependent/Koha/Item.t, but it's failing randomly. Failing on jenkins on D9: https://jenkins.koha-community.org/job/Koha_Master_D9/1061/consoleFull And more recently: https://jenkins.koha-community.org/job/Koha_Master_D9/1132/consoleFull You certainly need to launch them several times to see them fail (I cannot test right now). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:14:34 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:31:25 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:31:28 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 --- Comment #6 from Kyle M Hall --- Created attachment 98772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98772&action=edit Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:36:50 +0000 Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 --- Comment #3 from Patrick Robitaille --- Hi katrin, this problem seems to be in the 19.05 version of koha. To test: Do a specific search on the OPAC and be sure to habe enough results to have more than one page Add this searchs as a link to your OPAC home's page Click on that link to start the search Click on the "Limit to currently available items" button Go to another pages of the results See that the limit available items is gone. Does this help you recreate the problem? Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:56:05 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #29 from Lisette Scheer --- Created attachment 98773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98773&action=edit Bug 24366: Improve hashref construction Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:56:16 +0000 Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed' in action if no match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:56:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:56:18 +0000 Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed' in action if no match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 98774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98774&action=edit Attachment to Bug 23236 - Remove 'its items may still be processed' in action if no match is found Bug 23236 - Remove 'its items may still be processed' in action if no match is found When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To test: 1) Go to Tools > Stage MARC for import 2) Browse and choose a file with at least one record that is not already in your catalog and click on Upload file 3) Fill out the first section with the appropriate information 4) In the Look for existing records in catalog? section, choose a record matching rule 5) In the Action if no match is found drop-down menu, choose Ignore incoming record (its items may still be processed) 6) Click on Stage for import 7) Click on Manage staged records 8) Click Import this batch in the catalog 9) In the table, the record status should say Ignore 10) Apply patch 11) Redo steps 1-9, notice the option Ignore incoming records does not mention items 12) Make sure the tool still works and still ignores the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 20:57:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 19:57:16 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|0 |1 is obsolete| | Attachment #92601|0 |1 is obsolete| | Attachment #92602|0 |1 is obsolete| | Attachment #96210|0 |1 is obsolete| | Attachment #96219|0 |1 is obsolete| | --- Comment #30 from Lisette Scheer --- Created attachment 98775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98775&action=edit Bug 22880: Convert opacheader system preference to news block Signed-off-by: Lisette Scheer bsoletes: 98773 - Bug 24366: Improve hashref construction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:00:29 +0000 Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed' in action if no match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 98776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98776&action=edit test bib record I attached a bib record (bibliographic, encoding UTF-8, format MARC) that you can try to import. It has an ISBN and unless you have obscure Quebec authors in your catalog, you shouldn't already have it :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:02:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:02:12 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Attachment #98773|0 |1 is obsolete| | --- Comment #31 from Lisette Scheer --- Comment on attachment 98773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98773 Bug 24366: Improve hashref construction My devbox attached an incorrect patch to this bug. Fixing it so I can try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:02:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:02:43 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98775|0 |1 is obsolete| | --- Comment #32 from Lisette Scheer --- Comment on attachment 98775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98775 Bug 22880: Convert opacheader system preference to news block My devbox attached an incorrect patch to this bug. Fixing it so I can try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:04:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:04:36 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:04:41 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:04:45 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92601|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:04:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:04:51 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92602|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:04:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:04:57 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96210|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:09:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:09:18 +0000 Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:24:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:24:40 +0000 Subject: [Koha-bugs] [Bug 24647] New: PDF::API2::Simple is declared as a required dependency but it is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Bug ID: 24647 Summary: PDF::API2::Simple is declared as a required dependency but it is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org `git grep PDF::API2::Simple` returns only one occurence, in cpanfile. `git log -S PDF::API2::Simple` returns a few commits that move around the declaration of dependencies, and the commit https://github.com/Koha-Community/Koha/commit/e418db57f9544983a004b6a7b7f79ab5bdcb30a0 that introduces this dependency without using it. So it looks like it has been a required dependency for 10 years, without ever being used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:28:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:28:32 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 --- Comment #1 from Julian Maurice --- Created attachment 98777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98777&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:28:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:28:46 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:51:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:51:22 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:51:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:51:26 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84219|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia --- Created attachment 98778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98778&action=edit Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 21:59:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 20:59:48 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:34:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:34:52 +0000 Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83664|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 98779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98779&action=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:36:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:36:39 +0000 Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:42:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:42:35 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #64 from Katrin Fischer --- (In reply to Jonathan Druart from comment #63) > (In reply to Jonathan Druart from comment #62) > > We are loosing the memcached cache after this change, as the module will not > > be installed by default and is not required. > > See bug 24642. > > I guess it's because the packages are not up-to-date (?) Hm, we have strongly recommended use of memcached and actually Koha doesn't work well without in our experience. We had problems with Plack without memcached, like config changes not taking effect without lots of reloads etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:50:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:50:36 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 --- Comment #17 from Katrin Fischer --- (In reply to Christopher Davis from comment #16) > (In reply to Fridolin SOMERS from comment #15) > > Enhancement not pushed to 19.05.x > > Hear hear! Yes, please back-port this to 19.05.x. We need it at our site > a.s.a.p. Please let me know how I can help make this happen. This is marked as an enhancement, not as a bug - enhancements are usually not backported. It's up to the Rmaints to make exceptions, but it might help to reason why this should be in an oldstable version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:58:41 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:58:43 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98762|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 98780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98780&action=edit Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 22:58:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 21:58:46 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98764|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 98781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98781&action=edit Bug 24643: Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=24643 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:19:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:19:57 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #8 from Aleisha Amohia --- (In reply to Owen Leonard from comment #1) > I notice if you have TrackClicks enabled the links reads "Link to resource" > instead of the real URL. > > That seems strange, because I would think that with TrackClicks enabled it > would actually be /more/ important to show the actual URL, since the > browser's status bar is going to show the tracking link instead of the > destination URL. > > Of course nobody but me looks at the status bar. Perhaps the link text > should always be "Link to resource?" Looking at this now, I think it does make more sense to have the consistent 'Link to resource' text always. What do people think about using the URLLinkText syspref for this case as well, so we don't have to make another system preference? Will attach an alternative patch showcasing what I mean by this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:21:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:21:46 +0000 Subject: [Koha-bugs] [Bug 24648] New: Contextualization of past tense "Created" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Bug ID: 24648 Summary: Contextualization of past tense "Created" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. I'd like to add contextualization for the "Created" verb booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:46:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:46:21 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #23 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:49:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:49:44 +0000 Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:55:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:55:03 +0000 Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 12 23:59:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 22:59:52 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #22 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:09:21 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:09:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:09:50 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:09:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:09:52 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 98782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98782&action=edit Attachment to Bug 24648 - Contextualization of past tense "Created" Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:11:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:11:28 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97865|0 |1 is obsolete| | --- Comment #48 from Nightly Build Bot --- Created attachment 98783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98783&action=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:13:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:13:32 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #65 from David Cook --- Martin has already pushed #24642 so should be good now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 00:21:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Feb 2020 23:21:16 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.08 released in| | CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- this applied clean, passes all test, so I will go ahead and backport to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 01:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 00:11:55 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #31 from Barbara Johnson --- I agree with Catherine that it would be preferable to have the patch update ALL patrons to have both Email and Digest CHECKED for the Auto Renewal function. If our patrons stop receiving any renewal notices it will cause a big customer service issue for us. During our preparation for Go Live, we had some default messaging preferences put in place. New patrons, whether created via self-registration or by staff, all get specific messaging options checked which they can later change if they want. Perhaps adding Email and Digest Auto Renewal default messaging preferences would make sure that existing patrons don't lose anything. Does this sound like it would work? Barbara -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 01:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 00:38:57 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 01:39:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 00:39:00 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #9 from Aleisha Amohia --- Created attachment 98784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98784&action=edit Bug 15352: (alternative patch) Use URLLinkText instead of URL for item links Use the value in URLLinkText in 952$u, or if not set, use 'Link to resource'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 01:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 00:39:43 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #10 from Aleisha Amohia --- (In reply to Aleisha Amohia from comment #9) > Created attachment 98784 [details] [review] > Bug 15352: (alternative patch) Use URLLinkText instead of URL for item links > > Use the value in URLLinkText in 952$u, or if not set, use 'Link to > resource'. I didn't obselete the others but apply this patch ON ITS OWN to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 02:03:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 01:03:44 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #6) > Hi Aleisha, I think this is related to bug 21941/bug 17258 - a DBMS version > problem. Can you please check? Hi Katrin, sorry I'm not really sure how I'm meant to check? It could be related, but also that query is pretty horrible and I think this fix is nicer code to work with in the long term. Setting back to Needs signoff because I'm not getting the aforementioned error, and wonder if it happened when the reservedate was manually changed in the database? Regardless, patch still works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 03:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 02:21:22 +0000 Subject: [Koha-bugs] [Bug 20419] Current location not updated correctly on the return of an item on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED CC| |aleisha at catalyst.net.nz --- Comment #3 from Aleisha Amohia --- I believe this has been fixed in master. Can someone else confirm that this is no longer a bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 03:50:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 02:50:15 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 03:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 02:50:18 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 --- Comment #1 from Aleisha Amohia --- Created attachment 98785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98785&action=edit Bug 22655: Adding holds rules to Onboarding tool This patch adds the following fields to the circ rule step in the onboarding tool: - holds allowed (total) - holds allowed (daily) - holds per record (count) To test: 1) Apply patch, drop and recreate database, restart memcached and refresh page 2) Go through the installer and get to the final step of the onboarding tool 3) Confirm the above fields are now available to set in your circulation rule 4) Save and log in to Koha 5) Go to Admin -> Circ and fines rules 6) Confirm the fields saved correctly Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 03:50:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 02:50:33 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleymapley at catalyst.net.n |aleisha at catalyst.net.nz |z | Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 04:26:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 03:26:06 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 --- Comment #10 from Myka Kennedy Stephens --- Follow-up and further thoughts: Re: Caveat #1 - I went back and tried this again after making sure that the ES authority mapping on my test box was correct and complete. The linker still failed to link the headings. I am now wondering if bug #24269 could be the root cause of that, rather than a shortcoming on the patch for this bug. I tried to apply the patch for 24269 on top of the patch for this bug, but it failed to apply (I know it has already been signed off, though). Re: Caveat #2 - *If* one wanted to build a list of exceptions of authority punctuation that would need to be kept, here are a few places to start (from an incomplete U.S./Library of Congress perspective): - etc. - B.C. - A.D. - a period following a single letter (as in an initial) - Dr. - Jr. - Mrs. - Co. - Dept. - Inc. - hyphen (-) - closing parenthesis ) - question mark ? - exclamation point ! If this is the path taken, I strongly recommend this list be expanded to be inclusive of punctuation and abbreviations used in authority records of languages other than American English. It could probably use a few more English exceptions, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 04:51:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 03:51:18 +0000 Subject: [Koha-bugs] [Bug 24180] maintain separate repeated subfields when linking authority in advanced catalog editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24180 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #1 from Myka Kennedy Stephens --- +1 I've tested with a 630 and two $x fields and have the same experience. This seems to be a problem with the advanced editor and the linker. It is independent of a search engine (happens on both ES and Zebra). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 05:07:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 04:07:04 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from David Nind --- Hi Aleisha. Everything looks okay to me except for the details page for records on the staff interface from search results. I think this is this file about line 269: koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Note for testing: - Some icons only display for some pages if the item-level_itypes system preference is set to bibliographic record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 05:28:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 04:28:56 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94601|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 98786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98786&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 05:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 04:29:03 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #12 from Aleisha Amohia --- Created attachment 98787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98787&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 06:24:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 05:24:01 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- The search worked fine! Should I be able to install a plugin yet? I can install plugins the standard way. This is the start of the error message I got clicking the Install button from the search results: Can't locate object method "save_to" via package "Mojo::Message::Response" at /kohadevbox/koha/plugins/plugins-upload.pl line 78 in (eval) at /kohadevbox/koha/plugins/plugins-upload.pl line 78 75: if ( $uploadlocation ) { 76: my $ua = Mojo::UserAgent->new(max_redirects => 5); 77: my $tx = $ua->get($uploadlocation); 78: $tx->result->save_to($tempfile); 79: } else { 80: $errors{'EMPTYUPLOAD'} = 1 unless ( length($uploadfile) > 0 ); 81: } in CGI::Compile::ROOT::kohadevbox_koha_plugins_plugins_2dupload_2epl::__ANON__ at /kohadevbox/koha/plugins/plugins-upload.pl line 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 07:33:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 06:33:02 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 07:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 06:34:17 +0000 Subject: [Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Igor A. Sychev changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 07:37:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 06:37:54 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95657|0 |1 is obsolete| | --- Comment #5 from paxed --- Created attachment 98788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98788&action=edit Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters Signed-off-by: Kyle M Hall Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 07:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 06:37:57 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95658|0 |1 is obsolete| | --- Comment #6 from paxed --- Created attachment 98789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98789&action=edit Bug 24031: Fix warnings Signed-off-by: Kyle M Hall Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 07:47:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 06:47:07 +0000 Subject: [Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 --- Comment #1 from Igor A. Sychev --- Where do I keep a list of authoritative values for $2? orcid = Open Researcher and Contributor Identifier scopus = Scopus Author Identifier viaf = Virtual International Authority File EX 1 017 7# $a0000-0002-8038-722X$2orcid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 08:06:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 07:06:02 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #9 from Martin Renvoize --- Ah, 'save_to' was added to mojo in version 8.02. I'll have a look at how we can support this without using that call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:13:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:13:03 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:39:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:39:14 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:39:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:39:16 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98664|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 98790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98790&action=edit Bug 13574: Fix display of repeatable item subfields Applies to OPAC and staff: opac-MARCdetail and catalogue/MARCdetail. Test plan: [1] Pick an item. Pick two fields say URI and copy number, and fill these with a value like A | B. (The pipe char is important.) [2] Verify that the display of the item block on opac-MARCdetail shows both A and B in those columns. (Previously only B was shown.) [3] Verify the same on catalogue MARC detail, items tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:39:55 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Repeatable item subfields |Repeatable item subfields |don't show correctly in |don't show correctly in |MARC view |MARC view (OPAC and staff) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:42:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:42:13 +0000 Subject: [Koha-bugs] [Bug 24649] New: Cloning item subfields needs styling Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Bug ID: 24649 Summary: Cloning item subfields needs styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Mark an item subfield like URI as repeatable. And clone it in the item editor. You see some styling issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:43:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:43:26 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24649 --- Comment #6 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > On current master dd 2/20 clicking the clone button creates an unaligned > text box in the item editor. But saving and reediting works. > Deleting is done by clearing the text box. Perhaps adding a delete button > just like in cataloging should be nicer. Opened up a new bug for the styling issues. Bug 24649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:43:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:43:26 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields needs styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13574 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:50:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:50:14 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98757|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 98791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98791&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:50:18 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98758|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 98792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98792&action=edit Bug 23975: Add 'Install' support for github results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:50:21 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #12 from Martin Renvoize --- Created attachment 98793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98793&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 09:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 08:54:42 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #13 from Martin Renvoize --- The followup should get Install working more consistently now.. thanks for testing David. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:10:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:10:26 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields needs styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:10:29 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields needs styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #1 from Marcel de Rooy --- Created attachment 98794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98794&action=edit Bug 24649: Cloning item subfields misses a

  • tag Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: Mark item subfield URI repeatable. Clone the subfield. Notice the difference between patch applied or not applied. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:13:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:13:05 +0000 Subject: [Koha-bugs] [Bug 24650] New: API returned timestamps are incompatible with existing helpers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Bug ID: 24650 Summary: API returned timestamps are incompatible with existing helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org API endpoints that return system maintained timestamps (specified as datetime in the DB schema and specified as 'date-time' in the endpoint definition) return the timestamps as a form of RFC3339 timestamps. For example, from the GET /patrons/{patron_id} response: "last_seen": "2020-02-13T08:47:29+00:00" This is good as it's in a standard form. However, all the existing handlers in koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc that are used to transform a received timestamp into the instance's defined format are expecting timestamps in the format: (see DateTime_from_syspref) [datestring] [hours:minutes] Thereby making it impossible to display a returned timestamp to the user in their chosen format. We either need to create additional helpers or modify the API returning of ISO formatted timestamps to something the helpers can cope with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:13:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:13:32 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:14:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:14:36 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 --- Comment #1 from Andrew Isherwood --- Actually, it's not exclusively "system maintained" timestamps, it's anything defined as datetime in the DB -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:25:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:25:17 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields needs styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #2 from Marcel de Rooy --- Created attachment 98795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98795&action=edit Spacing between cloned subfields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:29:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:29:41 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:30:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:30:33 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cloning item subfields |Cloning item subfields |needs styling |misses a
  • tag -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:31:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:31:02 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Keywords| |Academy Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:31:19 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #12 from Jonathan Druart --- Created attachment 98796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98796&action=edit Bug 24361: Silent Items/GetItemsForInventory.t It was displaying undreds of: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Items.pm line 862. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:34:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:34:27 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #13 from Martin Renvoize --- Bug 24361: Silent Items/GetItemsForInventory.t Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:37:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:37:38 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #3 from Marcel de Rooy --- Created attachment 98797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98797&action=edit Bug 24649: Fix missing
  • tag on item editor for cloned subfield Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: To see the difference, test first without patch applied: Mark item subfield, say URI, as repeatable. Clone that subfield in item editor. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:37:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:37:42 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #4 from Marcel de Rooy --- Created attachment 98798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98798&action=edit Bug 24649: Fix missing
  • tag on batch mod item for cloned subfield Same problem as previous patch. Test plan: Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:37:57 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:41:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:41:25 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Marcel de Rooy --- Left one small thing on serials/serials-edit. Cloning on serial edit works, but the spacing between the original and cloned subfield is different from normal. See the attached image. Owen: Any chance to add a patch here for styling? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 10:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 09:56:42 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98783|0 |1 is obsolete| | --- Comment #49 from Nightly Build Bot --- Created attachment 98799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98799&action=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:06:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:06:00 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:06:03 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98791|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 98800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98800&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:06:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:06:07 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98792|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 98801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98801&action=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:06:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:06:10 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98793|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 98802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98802&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:07:32 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #17 from David Nind --- You may also need to add this to your Apache configuration (in the staff interface section - this folder location works for koha-testing-docker): Require all granted Alias /plugin "/var/lib/koha/kohadev/plugins/" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:15:24 +0000 Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to fines.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Component|Architecture, internals, |Fines and fees |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:15:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:15:54 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Command-line Utilities CC| |martin.renvoize at ptfs-europe | |.com, robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:16:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:16:00 +0000 Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to fines.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Fines and fees |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:19:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:19:34 +0000 Subject: [Koha-bugs] [Bug 24651] New: Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Bug ID: 24651 Summary: Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This would lead to a performance improvement by simply lowering the number of records that need to be processed. It would be safe to limit the overdues processed to those under X days overdues given that circulation policy often caps fines at a maximum after a number of days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:22:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:22:48 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | CC| |pasi.kallinen at koha-suomi.fi Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 98803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98803&action=edit Bug 20897: Add generic cronjob to run plugins with a cronjob method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:24:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:24:18 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 --- Comment #2 from paxed --- Created attachment 98804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98804&action=edit Plugin to test Bug 20897 This is a plugin to test bug 20897. All it does it implement the cronjob-method, and in that method, logs a warning: "PLUGIN Bug20897: CRONJOB" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:45:07 +0000 Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98711|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 98805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98805&action=edit Bug 24620: Close existing transfers when setting item to waiting This patch adds a clause in ModReserveAffect to check if there are existing transfers and close them when setting a hold to waiting To test: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting 9 - Apply patch 10 - Delete hold and repeat 11 - Confirm that transfer is closed when hold marked waiting Signed-off-by: Sally Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:47:13 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23571, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16528 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:47:13 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:47:13 +0000 Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to fines.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:49:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:49:19 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 --- Comment #1 from Martin Renvoize --- Created attachment 98806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98806&action=edit Bug 24651: Add maxdays option to fines cronjob This patch adds an optional maxdays parameter to the fines.pl cronjob. The new parameter allows system administrators to set a maximum number of days for the job to process overdues. This can improve performance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:49:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:49:28 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:49:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:49:32 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95759|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 98807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98807&action=edit Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using (change using OrderPdfFormat system preference): - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:49:33 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:50:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:50:13 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin at catalyst.net.nz |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:50:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:50:23 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 11:57:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 10:57:14 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|INVALID |--- --- Comment #3 from Jonathan Druart --- Reviving this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:03:23 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #4 from Jonathan Druart --- Context: I am trying to make koha-misc4dev stop when something wrong happens. Basically we do not want the process to continue of the DB has not been populated correctly. It will make the errors easier to catch. The issue: Say a script that will return an error (die in perl for an easy example), koha-shell will not return the 255 error code, but 0 instead. The caller cannot know something wrong happened The solution is to propagate the error and make koha-shell return the same error code as the command it executed An example: === t.pl === die('something wrong'); % perl t.pl;echo $? something wrong at t.pl line 1. 255 % sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $? something wrong at xxx.pl line 1. 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:05:02 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57055|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 98808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98808&action=edit Bug 17532: Make koha-shell propagate the error code Context: I am trying to make koha-misc4dev stop when something wrong happens. Basically we do not want the process to continue of the DB has not been populated correctly. It will make the errors easier to catch. The issue: Say a script that will return an error (die in perl for an easy example), koha-shell will not return the 255 error code, but 0 instead. The caller cannot know something wrong happened The solution is to propagate the error and make koha-shell return the same error code as the command it executed An example: === t.pl === die('something wrong'); % perl t.pl;echo $? something wrong at t.pl line 1. 255 % sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $? something wrong at xxx.pl line 1. 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:07:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:07:06 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:07:09 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98786|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 98809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98809&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:07:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:07:13 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98787|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 98810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98810&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:08:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:08:55 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 --- Comment #6 from Jonathan Druart --- Do you see any issues this change could cause? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:13:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:13:24 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 daniel.jones at cheshiresharedservices.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.jones at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:18:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:18:48 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:18:51 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98161|0 |1 is obsolete| | Attachment #98162|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 98811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98811&action=edit Bug 24532: Fix original DB update for bug 23049 Pathalogical cases of Payments and Writeoffs being converted to debits are identified during the DB update for bug 23049, but we are not correctly limiting to those types accountlines when subsequently populating the debit_type field. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:18:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:18:59 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 --- Comment #6 from Kyle M Hall --- Created attachment 98812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98812&action=edit Bug 24532: Fix misidentified credit_types from bug 23049 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:31:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:31:23 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98800|0 |1 is obsolete| | Attachment #98801|0 |1 is obsolete| | Attachment #98802|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 98813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98813&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:31:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:31:31 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #19 from Kyle M Hall --- Created attachment 98814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98814&action=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:31:34 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #20 from Kyle M Hall --- Created attachment 98815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98815&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:53:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:53:00 +0000 Subject: [Koha-bugs] [Bug 24652] New: Should TransformMarcToKoha check the repeatable flag for multiple subfields? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24652 Bug ID: 24652 Summary: Should TransformMarcToKoha check the repeatable flag for multiple subfields? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 21800 for the reverse operation TransformKohaToMarc. Currently, we rely on the interface for the operation of TransformMarcToKoha. It does not check the repeatable flag of subfields. If you give it two subfields for a non-repeatable subfields, it just merges both into a kohafield like "A | B". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:53:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:53:15 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24652 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:53:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:53:15 +0000 Subject: [Koha-bugs] [Bug 24652] Should TransformMarcToKoha check the repeatable flag for multiple subfields? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21800 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:55:18 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 --- Comment #2 from Andrew Isherwood --- Looking into this further it seems I have *completely* misunderstood the purpose of the *_from_syspref functions in calendar.inc. It would appear they accept a date / datetime in the format specified in the syspref, and return a Datetime. Much the same as Date.parse() will do. In which case, it would seem we're missing functions to take an ISO formatted datetime and return it in the format specified in the syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 12:57:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 11:57:19 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #2 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > At the same time wondering if we not should allow some item subfields to be > repeatable just as some under in MARC21 852 ? We should. We can specify it in the frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:12:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:12:01 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #3 from Marcel de Rooy --- Created attachment 98816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98816&action=edit Bug 21800: Add tests for repeatable subfields Test plan: Do not apply the second patch [note 1]. Run t/db_dependent/Biblio/TransformKohaToMarc.t Run t/db_dependent/Biblio/TransformMarcToKoha.t Apply the second patch and run them again. Both tests should pass now. Note 1: The TransformKohaToMarc test should fail with something like: # Failed test 'Check 260e' # at t/db_dependent/Biblio/TransformKohaToMarc.t line 60. # got: 'A' # expected: 'A | B' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:12:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:12:05 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #4 from Marcel de Rooy --- Created attachment 98817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98817&action=edit Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields If a kohafield (in Koha to MARC mappings) contains a pipe char (say A | B), we split it up into two subfields A and B in MARC. We will only do that for repeatable subfields now. If the field is not repeatable, the value will just be 'A | B'. Note: Does this impact the reverse operation in TransformMarcToKoha? No, the check on repeatable subfields is done in the interface and not in TransformMarcToKoha. This routine simply translates two instances of the same subfield, say A and B, into the value 'A | B' for a kohafield. Not allowing two instances of a non-repeatable subfield is not in the scope of this report. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:13:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:13:54 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #298 from Jonathan Druart --- They seem to fail quite consistently on U18: https://jenkins.koha-community.org/job/Koha_Master_U18/606/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U18/607/consoleFull -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:17:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:17:14 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #54 from Jonathan Druart --- Koha_Master_D9_MDB_Latest and Koha_Master_D9 are currently failing with: koha_1 | # Failed test 'No tests run for subtest "versions_info"' koha_1 | # at t/Installer_PerlModules.t line 35. koha_1 | Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at /kohadevbox/koha/C4/Installer/PerlModules.pm line 55. koha_1 | # Looks like your test exited with 2 just after 6. koha_1 | [10:05:40] t/Installer_PerlModules.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:34:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:34:42 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:34:45 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 --- Comment #3 from Andrew Isherwood --- Created attachment 98818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98818&action=edit Bug 24650: Convert ISO datetimes to syspref dates This patch adds a function 'ISO_to_syspref' that accepts an ISO8601 / RFC3339 formatted timestamp, as returned from the API for datetime DB columns, and returns a string formatted according to the 'dateformat' syspref, optionally including the time Test plan: - Apply the patch - Load a page that uses calendar.inc, for example a patron's loan list in the staff interface - In the JS console, type the following and notice the printed date is in the format according to the syspref: var dt = new Date; console.log(ISO_to_syspref(dt.toISOString())); - In the JS console, type the following and notice the printed date is in the format according to the syspref, and includes the time: console.log(ISO_to_syspref(dt.toISOString(), true)); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:35:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:35:12 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 [Bug 24650] API returned timestamps are incompatible with existing helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:35:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:35:12 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 [Bug 24609] Add routes for getting and setting checkout due date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:35:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:35:32 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24650 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 [Bug 24650] API returned timestamps are incompatible with existing helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:35:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:35:32 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24609 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 [Bug 24609] Add routes for getting and setting checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:36:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:36:48 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 [Bug 24650] API returned timestamps are incompatible with existing helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:36:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:36:48 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 [Bug 24608] Allow modification of checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:42:06 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50517|0 |1 is obsolete| | CC| |emmi.takkinen at outlook.com --- Comment #20 from Emmi Takkinen --- Created attachment 98819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98819&action=edit Bug 13961: Option to include patron's total amount of fines in notices Fixed patch to apply master version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:45:14 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #21 from Emmi Takkinen --- Created attachment 98820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98820&action=edit Bug 13961: Add currency format handling Added currency format handling proposed in comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 13:45:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 12:45:58 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #22 from Emmi Takkinen --- Created attachment 98821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98821&action=edit Bug 13961: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:09:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:09:27 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:09:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:09:31 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98592|0 |1 is obsolete| | Attachment #98593|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 98822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98822&action=edit Bug 24611: Regression test Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:09:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:09:34 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #10 from Jonathan Druart --- Created attachment 98823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98823&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:09:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:09:56 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #6 from Owen Leonard --- Marcel I don't think it's a styling issue. I think serials-edit.tt needs the same correction you made to additem.tt and batchMod-edit.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:22:38 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |18330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 [Bug 18330] REST API: Date-time handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:22:38 +0000 Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:24:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:24:36 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:24:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:24:39 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97683|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 98824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98824&action=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:25:41 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:25:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:25:44 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98780|0 |1 is obsolete| | Attachment #98781|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 98825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98825&action=edit Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:25:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:25:47 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #7 from Jonathan Druart --- Created attachment 98826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98826&action=edit Bug 24643: Add unit tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:25:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:25:50 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #8 from Jonathan Druart --- Created attachment 98827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98827&action=edit Bug 24643: Add test to cover the timezone Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:27:48 +0000 Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Jonathan Druart --- Lucas, Is that possible to list exhaustively the different HTML tags used by this ws? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:37:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:37:12 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:37:15 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98784|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 98828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98828&action=edit Bug 15352: (alternative patch) Use URLLinkText instead of URL for item links Use the value in URLLinkText in 952$u, or if not set, use 'Link to resource'. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:37:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:37:51 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #12 from Owen Leonard --- (In reply to Aleisha Amohia from comment #8) > What do people think about using the URLLinkText syspref for this case as > well, so we don't have to make another system preference? I think that makes a lot of sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:39:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:39:04 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98798|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 98829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98829&action=edit Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:39:36 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #8 from Marcel de Rooy --- (In reply to Owen Leonard from comment #6) > Marcel I don't think it's a styling issue. I think serials-edit.tt needs the > same correction you made to additem.tt and batchMod-edit.tt. Thanks. You are right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 14:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 13:40:04 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:03:38 +0000 Subject: [Koha-bugs] [Bug 21774] Cloned item subfields disappear when editing an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21800 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:03:38 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:05:35 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:05:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:05:38 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97267|0 |1 is obsolete| | Attachment #97268|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 98830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98830&action=edit Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:05:40 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #8 from Owen Leonard --- Created attachment 98831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98831&action=edit Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:15:30 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:15:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:15:34 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62473|0 |1 is obsolete| | Attachment #65335|0 |1 is obsolete| | Attachment #98828|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 98832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98832&action=edit Bug 15352: Use URLLinkText instead of URL for item links Use the value in URLLinkText in 952$u, or if not set, use 'Link to resource'. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:16:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:16:55 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|a way not to show the full |Use URLLinkText instead of |url in the holdings |URL for item links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:18:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:18:17 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97888|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 98833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98833&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:18:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:18:21 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97889|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 98834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98834&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:21:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:21:55 +0000 Subject: [Koha-bugs] [Bug 12902] Cronjob monitoring script, nagios3 compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:26:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:26:02 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #42 from Martin Renvoize --- Rebased... again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:21 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97816|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 98835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98835&action=edit Bug 23355: Add cash_register_actions table This patch adds the new cash_register_actions database table to allow for storing of cash register actions which are not already stored as accountlines. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:24 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97817|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 98836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98836&action=edit Bug 23355: [DO NOT PUSH] DBIC Classes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:29 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97818|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 98837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98837&action=edit Bug 23355: Add CASHUP actions This patch adds methods relating to cashup procedures to the cash register object to ease adding and querying for cashup actions related to the register. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:33 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97819|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 98838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98838&action=edit Bug 23355: Add accountline deletion test This patch adds a test to ensure database relations do not cascade deletions when a cash register is deleted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:36 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97820|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 98839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98839&action=edit Bug 23355: Link cash_register_actions to cash_registers by foreign key Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:40 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97821|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 98840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98840&action=edit Bug 23355: Split tests for Line vs Lines This patch simply splits the existing tests for accountlines into two test files, one for the singular object and one for the set. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:44 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97822|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 98841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98841&action=edit Bug 23355: Add register details page This patch adds a new page which can be accessed via the menu to the left of the point of sale page. This new page displays a list of transactions since the last 'cashup' action, a summary of transaction amounts and a button to allow the recording of a new 'cashup action. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:37:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:37:48 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97823|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 98842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98842&action=edit Bug 23355: Add cashup permissions Add new 'cashup' sub-permissions to the 'cash_management' permission to allow fine grained control over whome may 'cashup' a cash register. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:38:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:38:15 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:38:25 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:38:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:38:34 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:41:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:41:46 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98451|0 |1 is obsolete| | Attachment #98452|0 |1 is obsolete| | Attachment #98453|0 |1 is obsolete| | Attachment #98454|0 |1 is obsolete| | Attachment #98455|0 |1 is obsolete| | Attachment #98456|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 98843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98843&action=edit Bug 24156: move ColumnsSettings to TablesSettings We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:41:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:41:49 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #20 from Jonathan Druart --- Created attachment 98844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98844&action=edit Bug 24156: Add columns_settings.yml changes Modification of the structure of the yml file. It was table: - column list It now becomes table: default_display_length: X default_sort_order: Y columns: - column list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:41:52 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #21 from Jonathan Druart --- Created attachment 98845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98845&action=edit Bug 24156: Add missing columns to yml There were 2 columns missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:41:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:41:55 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #22 from Jonathan Druart --- Created attachment 98846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98846&action=edit Bug 24156: Adjust other tables in the yml file To match the new structure, we adjust the other tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:41:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:41:58 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #23 from Jonathan Druart --- Created attachment 98847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98847&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. Sponsored-by: Institute of Technology Tallaght -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:42:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:42:02 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #24 from Jonathan Druart --- Created attachment 98848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98848&action=edit Bug 24156: Fix set sort order to the first column In that case it's equal to 0 and we need to adjust the test condition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:42:53 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97826|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 98849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98849&action=edit Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. https://bugs.koha-community.org/show_bug.cgi?id=23355 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:42:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:42:56 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97827|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 98850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98850&action=edit Bug 24082: Add refund action to relevant lines https://bugs.koha-community.org/show_bug.cgi?id=23355 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:42:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:42:59 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97828|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 98851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98851&action=edit Bug 24082: Add access to historical transactions https://bugs.koha-community.org/show_bug.cgi?id=23355 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:43:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:43:12 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 --- Comment #8 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:43:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:43:35 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:44:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:44:17 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #25 from Jonathan Druart --- Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 15:59:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 14:59:42 +0000 Subject: [Koha-bugs] [Bug 24653] New: Failing tests in 19.05.x Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 Bug ID: 24653 Summary: Failing tests in 19.05.x Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: lucas at bywatersolutions.com tests are failing in 19.05: -t/db_dependent/Koha/Charges/Fees.t -t/db_dependent/SIP/Transaction.t Something is not accounted for when there is no ALL/ALL circ rule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:00:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:00:27 +0000 Subject: [Koha-bugs] [Bug 24653] Failing tests in 19.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:01:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:01:10 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:01:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:01:13 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98680|0 |1 is obsolete| | --- Comment #12 from Joonas Kylmälä --- Created attachment 98852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98852&action=edit Bug 24592: Database Update Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:01:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:01:16 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98681|0 |1 is obsolete| | --- Comment #13 from Joonas Kylmälä --- Created attachment 98853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98853&action=edit Bug 24592: Reword LOST_RETURN to LOST_FOUND This patch updates the wording in the 'lost and found' process to more closely reflect what the process is achieving by replacing 'RETURNED' with 'FOUND' Test plan: 1) Grep codebase for _FixAccountForLostAndReturned and note there are no longer any instanced of it. 2) Run t/db_dependent/Circulation.t and note it passes 3) Test returning/renewing an item that has been marked as lost and note the updated values in the accountlines now use LOST_FOUND as credit_type_code and 'FOUND' as the status for the 'LOST' fee (debit_type_code 'LOST') Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:02:45 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98849|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 98854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98854&action=edit Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:02:48 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98850|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 98855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98855&action=edit Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:02:51 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98851|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 98856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98856&action=edit Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:03:46 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- This bug was actually just split out from bug 23355 which was already signed off by Kyle.. just added his signoff back in as it got lost during the reshuffle to make QA simpler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:08:52 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #29 from Jonathan Druart --- Also notice that the input in the header has now a shadow. I think that if we cannot fix the regressions brought by bug 24181 easily, we will need to revert it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:15:09 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:15:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:15:16 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:15:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:15:19 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #30 from Jonathan Druart --- Created attachment 98857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98857&action=edit Bug 24363: Move the datepicker icon out of the input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:16:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:16:53 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #30) > Created attachment 98857 [details] [review] > Bug 24363: Move the datepicker icon out of the input What about this patch? https://snipboard.io/Lud1yE.jpg https://snipboard.io/d47B2a.jpg https://snipboard.io/0YQydX.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:20:32 +0000 Subject: [Koha-bugs] [Bug 24653] Failing tests in 19.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 --- Comment #1 from Jonathan Druart --- Those tests pass for me in 19.05.x, which errors do you get? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:33:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:33:00 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:33:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:33:07 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:33:13 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:33:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:33:20 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:35:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:35:00 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98790|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 98858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98858&action=edit Bug 13574: Fix display of repeatable item subfields Applies to OPAC and staff: opac-MARCdetail and catalogue/MARCdetail. Test plan: [1] Pick an item. Pick two fields say URI and copy number, and fill these with a value like A | B. (The pipe char is important.) [2] Verify that the display of the item block on opac-MARCdetail shows both A and B in those columns. (Previously only B was shown.) [3] Verify the same on catalogue MARC detail, items tab. Signed-off-by: Marcel de Rooy Signed-off-by: Holly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:36:19 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:38:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:38:06 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #299 from Jonathan Druart --- A different failure from jenkins (D9 run 1139): https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull koha_1 | koha_1 | # Failed test 'Patron can place hold if no circ_rules where defined' koha_1 | # at t/db_dependent/Holds.t line 1095. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'OK' koha_1 | koha_1 | # Failed test 'Patron cannot place hold because pickup location is not part of hold group' koha_1 | # at t/db_dependent/Holds.t line 1122. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' koha_1 | koha_1 | # Failed test 'Patron can place hold if default_branch_circ_rules is set to "any" for library 2' koha_1 | # at t/db_dependent/Holds.t line 1142. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'OK' koha_1 | koha_1 | # Failed test 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for library 2' koha_1 | # at t/db_dependent/Holds.t line 1162. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' koha_1 | koha_1 | # Failed test 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2' koha_1 | # at t/db_dependent/Holds.t line 1182. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'OK' koha_1 | koha_1 | # Failed test 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2' koha_1 | # at t/db_dependent/Holds.t line 1202. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' koha_1 | koha_1 | # Failed test 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 and library 2' koha_1 | # at t/db_dependent/Holds.t line 1222. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'OK' koha_1 | koha_1 | # Failed test 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2' koha_1 | # at t/db_dependent/Holds.t line 1242. koha_1 | # Structures begin differing at: koha_1 | # $got->{status} = 'libraryNotPickupLocation' koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' koha_1 | # Looks like you failed 8 tests of 9. koha_1 | koha_1 | # Failed test 'CanItemBeReserved / pickup_not_in_hold_group' koha_1 | # at t/db_dependent/Holds.t line 1249. koha_1 | # Looks like you failed 1 test of 61. koha_1 | [15:06:03] t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:13 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98426|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:19 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:26 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98428|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:26 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:45 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:41:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:41:49 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:43:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:43:26 +0000 Subject: [Koha-bugs] [Bug 24654] New: Trailing double-quote in rda 264 subfield b on opac xslt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Bug ID: 24654 Summary: Trailing double-quote in rda 264 subfield b on opac xslt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:46:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:46:01 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:46:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:46:04 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97863|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 98859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98859&action=edit Bug 24506: Multibranch limit does not work with ElasticSearch Test plan 1. Set up a system with ElasticSearch 2. Set up or make sure ther are at least two branches 3. create a group of branches 4. make sure there are items associated with any library in the group 5. make a search in opac limited by the library group 6. make an advanced search in intra limited by the library group 7. change SearchEngine system preference to Zebra and repeat 5. and 6. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:46:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:46:55 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:46:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:46:57 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 --- Comment #1 from Nick Clemens --- Created attachment 98860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98860&action=edit Bug 24654: Remove trailing quote in rda264 XSLT To test: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search 6 - Apply patch 7 - Refresh 8 - Link is correctly formed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:48:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:48:12 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:49:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:49:15 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14716 --- Comment #2 from Nick Clemens --- caused by commit 217c8a656f8ba46aa12e5e21f3d0d86132950788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 16:49:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 15:49:15 +0000 Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:50 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:53 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97825|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 98861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98861&action=edit Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules == Test plan == - work with SCSS (just recompile it if you never did) - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS - now you have a node_modules directory - prove -r t/00-valid-xml.t - it should fail on files in node_modules - apply this patch - prove -r t/00-valid-xml.t - it should work - sabotage a legitimate XML file, like etc/SIPconfig.xml - prove -r t/00-valid-xml.t - it should fail, good the test is still useful - undo the sabotage Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:54 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:56 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 --- Comment #3 from Jonathan Druart --- Created attachment 98862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98862&action=edit Bug 24494: Make the regex more exact Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:56 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:01:58 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:00 +0000 Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:02 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:04 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:05 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:07 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:07 +0000 Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:02:51 +0000 Subject: [Koha-bugs] [Bug 24653] Failing tests in 19.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 --- Comment #2 from Lucas Gass --- Jonathan, Is passes for me now since the update to misc4dev. But a missing circ rule should not cause test to fail? This was only failing locally for me once I deleted the all/all circ rule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:03:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:03:26 +0000 Subject: [Koha-bugs] [Bug 24653] Failing tests in 19.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 --- Comment #3 from Jonathan Druart --- (In reply to Lucas Gass from comment #2) > Jonathan, > > Is passes for me now since the update to misc4dev. But a missing circ rule > should not cause test to fail? > > This was only failing locally for me once I deleted the all/all circ rule. Yes, you need the default one to make the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:13 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94700|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 98863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98863&action=edit Bug 20307: Add DB column localization.interface Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:17 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94701|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 98864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98864&action=edit Bug 20307: DBIC Schema changes Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:21 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94702|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 98865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98865&action=edit Bug 20307: Update the localization unique key Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:25 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94703|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 98866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98866&action=edit Bug 20307: DBIC Schema changes 2 Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:29 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94704|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 98867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98867&action=edit Bug 20307: Language overlay for authorised values Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:32 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94705|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 98868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98868&action=edit Bug 20307: (QA follow-up) Move DB update to perl Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:36 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94706|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 98869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98869&action=edit Bug 20307: Some more fixes Signed-off-by: Martin Renvoize Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:40 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94707|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 98870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98870&action=edit Bug 20307: Remove debug statement Carp::Always Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:44 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94708|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 98871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98871&action=edit Bug 20307: Disable the translate links if the object has not been saved yet We do not have the code yet (or can be edited after the translation has been done) Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:48 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94709|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 98872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98872&action=edit Bug 20307: Use 'auhorised_values' instead of 'avs' to avoid confusion And so we need to extend the size of localization.entity Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:51 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94710|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 98873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98873&action=edit Bug 20307: Code for AVs must be category and value And not only the authorized value, otherwise we could not handle the case where 2 categories have an identical authorized value. FIXME: When editing an AV, if you translate then change the AV's value, we will have inconsistent data, we should add some JS code to disable the translate link if the AV's value is modified. I would suggest to do it on a follow-up bug. Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:09:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:09:55 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94711|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 98874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98874&action=edit Bug 20307: Few more fixes due to bad rebase conflict resolutions Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:10:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:10:01 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97074|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 98875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98875&action=edit Bug 20307: Fix existing tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:10:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:10:05 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97075|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 98876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98876&action=edit Bug 20307: Fix logic in search_with_localization and add tests Maybe we will want to replace this method at some point. There was something wrong in the logic. I did not manage to implement what I really needed here. The real SQL query we need is: SELECT SELECT *, COALESCE( `localization_intranet`.`translation`, `me`.`lib` ) AS `translated_description`, COALESCE( `localization_opac`.`translation`, `me`.`lib` ) AS `opac_translated_description` FROM `authorised_values` `me` LEFT JOIN (SELECT localization_id, code, lang, translation FROM localization WHERE entity='authorised_values' AND interface='intranet') `localization_intranet` ON ( `localization_intranet`.`lang` = 'es-ES' AND CONCAT(me.category, '_', `me`.`authorised_value`) = `localization_intranet`.`code` ) LEFT JOIN (SELECT localization_id, code, lang, translation FROM localization WHERE entity='authorised_values' AND interface='opac') `localization_opac` ON ( `localization_opac`.`lang` = 'es-ES' AND CONCAT(me.category, '_', `me`.`authorised_value`) = `localization_opac`.`code` ) WHERE me.category="?" ORDER BY `translated_description`; So 2 left join on the same table, with different on clause (to deal with the 2 interfaces) That would give us something like: | id | category | authorised_value | lib | lib_opac | imageurl | translated_description | opac_translated_description | Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:12:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:12:17 +0000 Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:13:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:13:16 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #95 from Martin Renvoize --- Re-tested and all seems to be working well.. Signing off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:14:08 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:16:03 +0000 Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass --- no cash_registers.tt in 19.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:22:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:22:36 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Martin Renvoize --- Needs a rebase for the circ rules work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:27:20 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- I still see one final warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Search.pm line 1818. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:29:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:29:28 +0000 Subject: [Koha-bugs] [Bug 24655] New: RoundFinesAtPayment can leave partial cent credits on patrons account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24655 Bug ID: 24655 Summary: RoundFinesAtPayment can leave partial cent credits on patrons account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Create a manual invoice for 1.4286 for a patron 2 - Enable RoundFinesAtPayment 3 - Pay 1.43 on the patrons account 4 - The fine is paid off, however, if you view the accountlines in the DB the patron has a credit of .0014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:29:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:29:41 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:29:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:29:44 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90208|0 |1 is obsolete| | Attachment #90241|0 |1 is obsolete| | Attachment #97655|0 |1 is obsolete| | Attachment #97656|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 98877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98877&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:29:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:29:48 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #15 from Jonathan Druart --- Created attachment 98878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98878&action=edit Bug 22898: Since bug 23957, submit element is now a button (no longer input) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:29:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:29:51 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #16 from Jonathan Druart --- Created attachment 98879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98879&action=edit Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:30:18 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #17 from Jonathan Druart --- I skip the 18.11 patch. New test plan: Make sure the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:32:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:32:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #300 from Agustín Moyano --- (In reply to Jonathan Druart from comment #299) > A different failure from jenkins (D9 run 1139): > > https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull > > > koha_1 | > koha_1 | # Failed test 'Patron can place hold if no circ_rules > where defined' > koha_1 | # at t/db_dependent/Holds.t line 1095. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'OK' > koha_1 | > koha_1 | # Failed test 'Patron cannot place hold because pickup > location is not part of hold group' > koha_1 | # at t/db_dependent/Holds.t line 1122. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > koha_1 | > koha_1 | # Failed test 'Patron can place hold if > default_branch_circ_rules is set to "any" for library 2' > koha_1 | # at t/db_dependent/Holds.t line 1142. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'OK' > koha_1 | > koha_1 | # Failed test 'Patron cannot place hold if > hold_fulfillment_policy is set to "hold group" for library 2' > koha_1 | # at t/db_dependent/Holds.t line 1162. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > koha_1 | > koha_1 | # Failed test 'Patron can place hold if > hold_fulfillment_policy is set to "any" for itemtype 2' > koha_1 | # at t/db_dependent/Holds.t line 1182. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'OK' > koha_1 | > koha_1 | # Failed test 'Patron cannot place hold if > hold_fulfillment_policy is set to "hold group" for itemtype 2' > koha_1 | # at t/db_dependent/Holds.t line 1202. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > koha_1 | > koha_1 | # Failed test 'Patron can place hold if > hold_fulfillment_policy is set to "any" for itemtype 2 and library 2' > koha_1 | # at t/db_dependent/Holds.t line 1222. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'OK' > koha_1 | > koha_1 | # Failed test 'Patron cannot place hold if > hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2' > koha_1 | # at t/db_dependent/Holds.t line 1242. > koha_1 | # Structures begin differing at: > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > koha_1 | # Looks like you failed 8 tests of 9. > koha_1 | > koha_1 | # Failed test 'CanItemBeReserved / pickup_not_in_hold_group' > koha_1 | # at t/db_dependent/Holds.t line 1249. > koha_1 | # Looks like you failed 1 test of 61. > koha_1 | [15:06:03] t/db_dependent/Holds.t Hi Jonathan, I think I spotted this failure.. should I make a new bug to fix this tests? The random failure on Item.t I'm at a loss. Supposedly I delete every circulation_rule, every item, every issue and every patron, but it seems not everything gets deleted.. or that's what I guess. Do you have any tip of what could be wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:33:14 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:33:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:33:20 +0000 Subject: [Koha-bugs] [Bug 24656] New: Koha should not allow creating partial cents fines/fees that cannot be paid in currency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24656 Bug ID: 24656 Summary: Koha should not allow creating partial cents fines/fees that cannot be paid in currency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha allows for 6 decimal places in accountlines amount - most currencies do not have units for amounts this small. We need to address this fact somehow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:36:19 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- (In reply to Liz Rea from comment #5) > Why would we not use koha-remove and then apt uninstall > koha-common then apt autoremove? > > I'm not sure this bug needs a fix anymore? A developer is going to be using > either a devbox or a koha-testing-docker; an average user hopefully will be > using Debian packages as advised in our documentation, and certainly, > support vendors will be using the packages as well. I tend to agree, but isn't installation from tarball still supported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:51:15 +0000 Subject: [Koha-bugs] [Bug 24656] Koha should not allow creating partial cents fines/fees that cannot be paid in currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24656 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:51:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:51:31 +0000 Subject: [Koha-bugs] [Bug 24655] RoundFinesAtPayment can leave partial cent credits on patrons account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24655 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:52:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:52:27 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 17:58:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 16:58:04 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #35 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:02:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:02:34 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.05.08, released in| |19.11.03 Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- backported to 19.11.x for 19.11.03 backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:02:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:02:42 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:03:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:03:11 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98877|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 98880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98880&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:03:14 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98878|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 98881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98881&action=edit Bug 22898: Since bug 23957, submit element is now a button (no longer input) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:03:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:03:17 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98879|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 98882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98882&action=edit Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:03:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:03:43 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Martin Renvoize --- We're better off with these tests than without.. they are all currently passing and read ok.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:03:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:03:48 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:07:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:07:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #301 from Agustín Moyano --- (In reply to Agustín Moyano from comment #300) > (In reply to Jonathan Druart from comment #299) > > A different failure from jenkins (D9 run 1139): > > > > https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull > > > > > > koha_1 | > > koha_1 | # Failed test 'Patron can place hold if no circ_rules > > where defined' > > koha_1 | # at t/db_dependent/Holds.t line 1095. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'OK' > > koha_1 | > > koha_1 | # Failed test 'Patron cannot place hold because pickup > > location is not part of hold group' > > koha_1 | # at t/db_dependent/Holds.t line 1122. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > > koha_1 | > > koha_1 | # Failed test 'Patron can place hold if > > default_branch_circ_rules is set to "any" for library 2' > > koha_1 | # at t/db_dependent/Holds.t line 1142. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'OK' > > koha_1 | > > koha_1 | # Failed test 'Patron cannot place hold if > > hold_fulfillment_policy is set to "hold group" for library 2' > > koha_1 | # at t/db_dependent/Holds.t line 1162. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > > koha_1 | > > koha_1 | # Failed test 'Patron can place hold if > > hold_fulfillment_policy is set to "any" for itemtype 2' > > koha_1 | # at t/db_dependent/Holds.t line 1182. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'OK' > > koha_1 | > > koha_1 | # Failed test 'Patron cannot place hold if > > hold_fulfillment_policy is set to "hold group" for itemtype 2' > > koha_1 | # at t/db_dependent/Holds.t line 1202. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > > koha_1 | > > koha_1 | # Failed test 'Patron can place hold if > > hold_fulfillment_policy is set to "any" for itemtype 2 and library 2' > > koha_1 | # at t/db_dependent/Holds.t line 1222. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'OK' > > koha_1 | > > koha_1 | # Failed test 'Patron cannot place hold if > > hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2' > > koha_1 | # at t/db_dependent/Holds.t line 1242. > > koha_1 | # Structures begin differing at: > > koha_1 | # $got->{status} = 'libraryNotPickupLocation' > > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup' > > koha_1 | # Looks like you failed 8 tests of 9. > > koha_1 | > > koha_1 | # Failed test 'CanItemBeReserved / pickup_not_in_hold_group' > > koha_1 | # at t/db_dependent/Holds.t line 1249. > > koha_1 | # Looks like you failed 1 test of 61. > > koha_1 | [15:06:03] t/db_dependent/Holds.t > > Hi Jonathan, > > I think I spotted this failure.. should I make a new bug to fix this tests? > > The random failure on Item.t I'm at a loss. Supposedly I delete every > circulation_rule, every item, every issue and every patron, but it seems not > everything gets deleted.. or that's what I guess. > > Do you have any tip of what could be wrong? Never mind, I think I nailed it!.. I'll submit patches in following bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:12:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:12:40 +0000 Subject: [Koha-bugs] [Bug 24657] New: Fix tests of bug 22284 - Groups of pickup locations for holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Bug ID: 24657 Summary: Fix tests of bug 22284 - Groups of pickup locations for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: agustinmoyano at theke.io QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Tests in bug 22284 had conditions where they randomly fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:14:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:14:03 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22284 Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:14:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:14:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:17:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:17:38 +0000 Subject: [Koha-bugs] [Bug 24658] New: Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Bug ID: 24658 Summary: Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: addie at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When batch deleting items through the staff client, the itemnumber in the accountlines table remains and does update to NULL. If you then go into the Accountlines tab of a borrower and into the Transactions you will get an internal server error if there is a fine in that patrons accountlines with an itemnumber in the database for the deleted item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:32:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:32:39 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |addie at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:42:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:42:05 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:42:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:42:08 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #1 from Agustín Moyano --- Created attachment 98883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98883&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:45:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:45:49 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:45:57 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:46:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:46:37 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98883|0 |1 is obsolete| | --- Comment #2 from Agustín Moyano --- Created attachment 98884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:51:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:51:52 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #27 from Lucas Gass --- i cannot make this patchset both work and pass tests in 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 18:56:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 17:56:25 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #19 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:04:41 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #28 from Lucas Gass --- if this needs to be in 19.05.x please rebase so it will pass unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:27:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:27:09 +0000 Subject: [Koha-bugs] [Bug 24659] New: Improve Patron Notice Status options to be more clear to staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24659 Bug ID: 24659 Summary: Improve Patron Notice Status options to be more clear to staff Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: margaret at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When patron messaging preferences are selected not to send courtesy notices, and there is no email for them to be sent to, Koha generates a notice and marks it as failed. The case I'm specifically looking at involves Auto Renewal notices. These “failures” are visible in the Patron Notices Log and then general circulation staff sees “failed” and gets confused. Staff education is important, but we can make things easier for our users by clarifying these types of messages. Either we could skip making them, as determined the Patron messaging preferences, to find a better status term for these types of messages. "Not applicable" "Unsent" "Not required" "No emails selected" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:31:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:31:45 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:31:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:31:47 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96919|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 98885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98885&action=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and view the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:31:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:31:52 +0000 Subject: [Koha-bugs] [Bug 24660] New: ModBiblio spams cataloguing log when linking to authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660 Bug ID: 24660 Summary: ModBiblio spams cataloguing log when linking to authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl bug 18816 altered ModItem to have a switch on logging, we need the same for ModBiblio so that authchanges by the linker are not recorded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:32:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:32:32 +0000 Subject: [Koha-bugs] [Bug 24660] ModBiblio spams cataloguing log when linking to authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |liz at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:32:38 +0000 Subject: [Koha-bugs] [Bug 24660] ModBiblio spams cataloguing log when linking to authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816 [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:32:38 +0000 Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24660 [Bug 24660] ModBiblio spams cataloguing log when linking to authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 19:41:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 18:41:24 +0000 Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export options to circulation and fine rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:02:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:02:01 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:02:03 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98824|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 98886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98886&action=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create your own lists" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:15:52 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:16:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:16:46 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98797|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 98887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98887&action=edit Bug 24649: Fix missing
  • tag on item editor for cloned subfield Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: To see the difference, test first without patch applied: Mark item subfield, say URI, as repeatable. Clone that subfield in item editor. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:16:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:16:54 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98829|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 98888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98888&action=edit Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:17:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:17:07 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:36:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:36:07 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- 19.05.x does not include QueryRegexEscapeOptions, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:43:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:43:58 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:52:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:52:48 +0000 Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:55:35 +0000 Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 21:58:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 20:58:57 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:01:22 +0000 Subject: [Koha-bugs] [Bug 14237] allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Rogan Hamby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rogan.hamby at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:12:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:12:23 +0000 Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special or repeatable holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:14:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:14:05 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #30 from Lucas Gass --- choosing not backport enhancement to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:19:08 +0000 Subject: [Koha-bugs] [Bug 7000] show home and holding branch on staff search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7000 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #2 from Aleisha Amohia --- It looks like this has been fixed in master and now uses the StaffSearchResultsDisplayBranch syspref. Can you confirm we can close this bug report? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:19:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:19:28 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:26:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:26:03 +0000 Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:26:11 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:26:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:26:15 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 --- Comment #3 from Aleisha Amohia --- Created attachment 98889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98889&action=edit Bug 8595: Rename 'host item' to 'host record' To test: 1) Enable the syspref EasyAnalyticalRecords 2) Find a biblio record, go to the detail page 3) Click the Edit dropdown and notice the option "Link to host item" 4) Apply patch and refresh page 5) Click the Edit dropdown and confirm the renamed "Link to host record" button Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:31:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:31:59 +0000 Subject: [Koha-bugs] [Bug 9872] Logs explode with messages when adding a new order in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9872 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #1 from Aleisha Amohia --- Hi Katrin, can you please confirm whether this test plan still produces these warns? I'm unable to reproduce them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:48:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:48:46 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:48:50 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 --- Comment #1 from Aleisha Amohia --- Created attachment 98890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98890&action=edit Bug 9989: Stay on basket page after closing it Instead of redirecting to the list of vendor's baskets. To test: 1) Go to Acquisitions. Ensure you have a budget, fund and vendor defined. 2) Create a basket. Add an item to it. 3) Close the basket. Do not attach to a basketgroup. 4) Notice you are redirected to the list of vendor's baskets. 5) Apply the patch and go to the basket's page. Reopen the basket. 6) Close the basket. Do not attach to a basketgroup. 7) Confirm you remain on the closed basket's page. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 22:49:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 21:49:06 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleisha at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 23:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 22:50:37 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #24 from Hayley Mapley --- Patches will not be backported to 18.11.x series as no one should be installing 18.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 23:54:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 22:54:06 +0000 Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #8 from Hayley Mapley --- Patch will not be backported to 18.11.x series (unless requested). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 13 23:57:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 22:57:00 +0000 Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #10 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 00:01:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 23:01:04 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #23 from Hayley Mapley --- Enhancement/patch will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 00:02:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 23:02:08 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #8 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 00:13:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Feb 2020 23:13:03 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #19 from Hayley Mapley --- Enhancement will not be backported to 18.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 02:05:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 01:05:23 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #7 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 03:17:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 02:17:17 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z --- Comment #16 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:00:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:00:18 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #6 from Hayley Mapley --- Hi there, Could you please rebase this patch for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:09:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:09:09 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #11 from Hayley Mapley --- Is someone able to also test 18.11.x for the presence of this bug? I have tested, and I am able to paginate with results still coming up even when searching with "cat". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:18:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:18:04 +0000 Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #9 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:21:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:21:49 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #12 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:27:03 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z --- Comment #36 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 04:30:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 03:30:03 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #9 from Hayley Mapley --- Hi, Could this please be rebased for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 05:37:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 04:37:22 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65696|0 |1 is obsolete| | Attachment #65697|0 |1 is obsolete| | --- Comment #58 from Srdjan Jankovic --- Created attachment 98891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98891&action=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 05:37:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 04:37:27 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73541|0 |1 is obsolete| | --- Comment #59 from Srdjan Jankovic --- Created attachment 98892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98892&action=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 05:41:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 04:41:18 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 06:28:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 05:28:18 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 07:38:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 06:38:43 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 07:38:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 06:38:47 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98857|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 98893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98893&action=edit Bug 24363: Move the datepicker icon out of the input Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:03:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:03:22 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #8 from Katrin Fischer --- Thx David, almost forgot about this one! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:06:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:06:39 +0000 Subject: [Koha-bugs] [Bug 24659] Improve Patron Notice Status options to be more clear to staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I'd vote for not generating notices in this case - if a patron has opted out of receiving notices by not adding an email address, we should not generate any. I think it doesn't generate emails for all notices, would you object to make this about the auto-renewal notice for now and change the bug description accordingly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:09:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:09:56 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:11:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:11:19 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #8 from Katrin Fischer --- (In reply to Hayley Mapley from comment #7) > Enhancement will not be backported to 18.11.x series. Really just a typo fix (adds one space) - but causes a string change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:49:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:49:19 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98221|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 98894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98894&action=edit Bug 24531 - Test for OAI-PMH sets and repeated fields This patch adds two tests related to OAI-PMH sets. It creates a dummy record with a repeated field, with different values. It then tests if the record is caught by mappings that match the value in the first field, and then if it is caught by mappings that match the second field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:49:22 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98222|0 |1 is obsolete| | --- Comment #9 from Magnus Enger --- Created attachment 98895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98895&action=edit Bug 24531 - Fix OAI-PMH sets for records with repeated fields Currently, an OAI-PMH set mapping will only match if the value it is looking for occurs in the first instance of a repeated field. To test: - Apply the first patch with two new tests - Run something like this: sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev - Verify that the last test fails - Apply this secind patch - Rerun the test file above - Verify that all tests now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:52:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:52:20 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:52:23 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98894|0 |1 is obsolete| | --- Comment #10 from Magnus Enger --- Created attachment 98896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98896&action=edit Bug 24531 - Test for OAI-PMH sets and repeated fields This patch adds two tests related to OAI-PMH sets. It creates a dummy record with a repeated field, with different values. It then tests if the record is caught by mappings that match the value in the first field, and then if it is caught by mappings that match the second field. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:52:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:52:26 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98895|0 |1 is obsolete| | --- Comment #11 from Magnus Enger --- Created attachment 98897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98897&action=edit Bug 24531 - Fix OAI-PMH sets for records with repeated fields Currently, an OAI-PMH set mapping will only match if the value it is looking for occurs in the first instance of a repeated field. To test: - Apply the first patch with two new tests - Run something like this: sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev - Verify that the last test fails - Apply this secind patch - Rerun the test file above - Verify that all tests now pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:53:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:53:55 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:53:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:53:59 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96055|0 |1 is obsolete| | --- Comment #4 from Hugo Agud --- Created attachment 98898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98898&action=edit Bug 23571: [DO NOT PUSH] crash condition builder This patch adds t/db_dependent/bug_23571_crash_condition_builder.t file This file is not intended to be part of Koha, but it's used to emulate crash conditions. It will create 5000 users, 5000 biblios with 2 items each, and each item issued to a user. It really takes a lot of time, so please be zen about it ;) To use it execute prove t/db_dependent/bug_23571_crash_condition_builder.t Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:54:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:54:03 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96056|0 |1 is obsolete| | --- Comment #5 from Hugo Agud --- Created attachment 98899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98899&action=edit Bug 23571: Add flock to fines.pl This patch adds a lock file for fines.pl. To test: 1. Apply this patch 2. In two separate consoles run misc/cronjobs/fines.pl SUCCESS => The first one runs normally, but the second one fails with a message flock failed for the lock file. 3. Sign off. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 08:54:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 07:54:21 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 --- Comment #12 from Magnus Enger --- (In reply to Josef Moravec from comment #6) > What if there is repeated subfield with same code in one field? Then only > first one is taken into account. I do think we want to count on all of > them... I have updated the tests and the code to account for repeated subfields. I reset the status to SO, please reset to NSO if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:20:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:20:24 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96787|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 98900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98900&action=edit [18.11.x] Bug 24214: Fix due date formatting when sticky When checking out and sticky due date is selected, on the next screen the due date is displayed iso-formatted, instead of following the dateformat syspref Test plan: 0/ Do not apply the patch 1/ Check an item out, with a selected due date. Tick "Remember for session" 2/ Next screen you see the date like YYYY-MM-DD HH:MM regarless the value of the dateformat syspref 3/ Apply this patch 4/ Reload the page => The date is correctly formatted 5/ Check an item out => Due date is correctly set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:20:41 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96787|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:24:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:24:59 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:25:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:25:17 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 --- Comment #12 from Jonathan Druart --- (In reply to Hayley Mapley from comment #11) > Is someone able to also test 18.11.x for the presence of this bug? > > I have tested, and I am able to paginate with results still coming up even > when searching with "cat". I do recreate with "cat" with the double quote :) Page 2 link is /cgi-bin/koha/cataloguing/addbooks.pl?q= With the patch (it applies correctly on 18.11.x), I get /cgi-bin/koha/cataloguing/addbooks.pl?idx=kw&q=%22cat%22&page=2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:27:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:27:36 +0000 Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:39:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:39:28 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #15 from Martin Renvoize --- Created attachment 98901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98901&action=edit Bug 15352: (RM follow-up) Add missing filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:40:04 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #2 from Andrew Isherwood --- Created attachment 98902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98902&action=edit Bug 24608: Add EditDueDates syspref This patch adds a EditDueDates syspref which determines whether a button for editing due dates appears in a patron's checkouts list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:40:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:40:07 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #3 from Andrew Isherwood --- Created attachment 98903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98903&action=edit Bug 24608: Allow due date modification This patch adds the ability to modify due dates from a patron's checkouts list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:42:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:42:57 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #6 from David Nind --- Created attachment 98904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98904&action=edit Bug 13327: Screenshots - select items to search issue I think the issues from the previous testing are now resolved. A new issue is the pop-up select boxes - they aren't formatted correctly. See the attachment Bug 13327 - Select items to search issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:43:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:43:34 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:44:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:44:35 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Hugo Agud --- 98624 - Bug 24561: Datatables api wrapper also filter and order embedded columns Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24561: Datatables api wrapper also filter and order embedded columns error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/datatables.js). error: could not build fake ancestor Patch failed at 0001 Bug 24561: Datatables api wrapper also filter and order embedded columns The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24561-Datatables-api-wrapper-also-filter-and-o-Tegmir.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:49:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:49:41 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #16 from Jonathan Druart --- Created attachment 98905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98905&action=edit Bug 15352: Do not display the link if item.uri does not exist Otherwise there is a "Link to ressource" that points to the current url -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:53:30 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #17 from Martin Renvoize --- Followup Pushed, thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:54:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:54:23 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:54:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:54:26 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98896|0 |1 is obsolete| | Attachment #98897|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 98906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98906&action=edit Bug 24531: Test for OAI-PMH sets and repeated fields This patch adds two tests related to OAI-PMH sets. It creates a dummy record with a repeated field, with different values. It then tests if the record is caught by mappings that match the value in the first field, and then if it is caught by mappings that match the second field. Signed-off-by: David Nind Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:54:30 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 --- Comment #14 from Josef Moravec --- Created attachment 98907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98907&action=edit Bug 24531: Fix OAI-PMH sets for records with repeated fields Currently, an OAI-PMH set mapping will only match if the value it is looking for occurs in the first instance of a repeated field. To test: - Apply the first patch with two new tests - Run something like this: sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev - Verify that the last test fails - Apply this secind patch - Rerun the test file above - Verify that all tests now pass Signed-off-by: David Nind Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:54:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:54:54 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 --- Comment #15 from Josef Moravec --- (In reply to Magnus Enger from comment #12) > (In reply to Josef Moravec from comment #6) > > What if there is repeated subfield with same code in one field? Then only > > first one is taken into account. I do think we want to count on all of > > them... > > I have updated the tests and the code to account for repeated subfields. I > reset the status to SO, please reset to NSO if necessary. Thanks Magnus, PQA now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:57:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:57:04 +0000 Subject: [Koha-bugs] [Bug 24661] New: Inclusion of locale-related javascript files is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Bug ID: 24661 Summary: Inclusion of locale-related javascript files is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 21156 Bug 21156 adds 2 js files (Gettext.js, i18n.js) + 1 generated js file (locale_data.js). On master, their URL are broken and the files are not loaded. Steps to reproduce: 1. Checkout master 2. Open Firefox/Chrome devtools, network tab, and go to any page in the staff interface (except the main page) 3. You should see 3 404 errors for the files mentioned above. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:57:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:57:04 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24661 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 [Bug 24661] Inclusion of locale-related javascript files is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:58:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:58:55 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98902|0 |1 is obsolete| | --- Comment #4 from Andrew Isherwood --- Created attachment 98908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98908&action=edit Bug 24608: Add EditDueDates syspref This patch adds a EditDueDates syspref which determines whether a button for editing due dates appears in a patron's checkouts list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 09:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 08:58:58 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98903|0 |1 is obsolete| | --- Comment #5 from Andrew Isherwood --- Created attachment 98909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98909&action=edit Bug 24608: Allow due date modification This patch adds the ability to modify due dates from a patron's checkouts list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:25 +0000 Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set for tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83230|0 |1 is obsolete| | Attachment #83231|0 |1 is obsolete| | Attachment #83232|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 98910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98910&action=edit Bug 22001: Remove the RaiseError occurrences from tests Unless it is needed! Also remove $dbh when not used later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:29 +0000 Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set for tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 --- Comment #5 from Jonathan Druart --- Created attachment 98911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98911&action=edit Bug 22001: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:33 +0000 Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set for tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 --- Comment #6 from Jonathan Druart --- Created attachment 98912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98912&action=edit Bug 22001: Enable RaiseError for tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:39 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:54 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Andrew Isherwood --- Test plan: - Apply the patch - View a patron's checkout list => TEST: Observe that the due date is displayed as normal - Enable the EditDueDates syspref - View a patron's checkout list => TEST: Observe that each checkout now has an "Edit" button next to the due date - Click the edit button next to a checkout's due date => TEST: Observe that the date is now editable => TEST: The edit button is replaced by a "Save" button => TEST: All other checkout "Edit" buttons are disabled => TEST: Clicking on the due date opens a calendar widget => TEST: It is not possible to select a date prior to the existing due date - Select a new due date - Click the "Save" button => TEST: The save button is replaced by a progress spinner while the update is performed => TEST: Once the update is complete, the displayed date reflects the selected date => TEST: Once the update is complete, the display returns to it's initial state -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:00:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:00:57 +0000 Subject: [Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #40 from Jonathan Druart --- Follow-ups on bug 22001 are waiting for signoff for more that a year now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:03:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:03:57 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #1 from Julian Maurice --- Created attachment 98913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98913&action=edit Bug 24661: Fix inclusion of locale-related javascript files Bug 21156 adds 2 js files (Gettext.js, i18n.js) + 1 generated js file (locale_data.js). Their URL are broken and the files are not loaded. Use Template::Toolkit plugin Asset to include these files, and exclude locale_data.js when language is english, because obviously translations are not needed in this case. Test plan: 1. Just make sure the files mentioned above are loaded correctly when in English and in other languages as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:04:41 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:08:53 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98908|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood --- Created attachment 98914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98914&action=edit Bug 24608: Add EditDueDates syspref This patch adds a EditDueDates syspref which determines whether a button for editing due dates appears in a patron's checkouts list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:08:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:08:57 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98909|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood --- Created attachment 98915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98915&action=edit Bug 24608: Allow due date modification This patch adds the ability to modify due dates from a patron's checkouts list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:14:04 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #3 from Jonathan Druart --- Comment on attachment 98884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884 Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t Review of attachment 98884: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24657&attachment=98884) ----------------------------------------------------------------- ::: t/db_dependent/Koha/Item.t @@ +173,5 @@ > + my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); > + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } ); > + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } ); > + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } ); > + my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } ); Do you really need to specify a branchcode here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:17:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:17:59 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:18:03 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96859|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98916&action=edit Bug 15850: Correct eslint errors in cataloging.js This patch makes corrections to cataloging.js so that there are no issues flagged by eslint. The fewer eslint warnings we have to see makes it more likely that real problems will be noticed. Some functions were unused have been removed. To test, apply the patch and clear your browser cache if necessary. - Open a MARC record for editing in the basic cataloging editor. - Test the JavaScript-driven functionality affected by the changed file: - Open the authority browser from a field (e.g. 100a) which is linked to an authority type. - Clone a repeatable tag. - Clone a repeatable subfield - "Unclone" a tag or subfield: This should remove the tag or subfield (if possible) or clear the contents of the tag or subfield if not. - Clone a subfield on the item edit page (In my MARC21 installation I had to modify the default framework in order to have a repeatable item subfield to test with). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:19:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:19:40 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #4 from Jonathan Druart --- I got another random failure, but not related to bug 22284. First time I see it I think. For the record: t/db_dependent/Holds.t ...... 1/61 # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 203. # got: undef # expected: '2304' t/db_dependent/Holds.t ...... 61/61 # Looks like you failed 1 test of 61. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:24:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:24:05 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:24:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:24:08 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98884|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 98917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98917&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:24:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:24:11 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #6 from Jonathan Druart --- Created attachment 98918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98918&action=edit Bug 24657: Do not explicitely pass a branchcode Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:24:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:24:26 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #7 from Jonathan Druart --- Thanks Agustin, good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:26:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:26:40 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie --- Comment #359 from Holly --- I work with a few sites that are very eager to be able to recall items. I wanted to check if there was any chance of some movement on this bug or if there is anything I can do to help with it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:36:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:36:16 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Addie, which error do you get? I do not recreate (19.05.x and master), can you give more detail please? What I did: * Create manual invoice, barcode=39999000018714, amount=42 * Delete the item with barcode=39999000018714 (from cataloguing/additem.pl) * Accounting > Transactions I see: https://snipboard.io/8GNMjB.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:45:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:45:11 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:45:14 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98684|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98919&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply this patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 10:51:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 09:51:37 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #40 from Jonathan Druart --- Martin, what about the 2 occurrences in Koha::Account->pay? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:09 +0000 Subject: [Koha-bugs] [Bug 24662] New: Remove global variables MSG_* from datatables.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug ID: 24662 Summary: Remove global variables MSG_* from datatables.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:28 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:32 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98677|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 98920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98920&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:37 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #1 from Julian Maurice --- Created attachment 98921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98921&action=edit Bug 24662: Remove global variables MSG_* from datatables.inc Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. This patch removes all global variables used in DataTables configuration Test plan: 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR 4. Go to the staff interface, in english, and check that DataTables tables are still working. You should check at least the following pages: - catalogue/detail.pl - circ/circulation.pl - tools/quotes.pl - tools/letter.pl 5. Switch to french and check again DataTables tables, and verify that strings are translated This patch depends on bug 24661 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:46 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24661 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 [Bug 24661] Inclusion of locale-related javascript files is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:46 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 [Bug 24662] Remove global variables MSG_* from datatables.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:00:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:00:56 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:11:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:11:02 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Jonathan Druart --- Kyle, any ideas about how we could fix this correctly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:18:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:18:52 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #41 from Martin Renvoize --- (In reply to Jonathan Druart from comment #40) > Martin, what about the 2 occurrences in Koha::Account->pay? I think I traced it back and found that it's only actually occurring via a call to apply (i.e the call inside _FixAccountForLostAndFound), but it's probably not a bad idea to match the code in the two locations. I'll add a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:24:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:24:04 +0000 Subject: [Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 --- Comment #2 from Holly --- Based on the last comment there doesn't seem much can be done for this right now, but I wanted to register that there is still interest in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:33:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:33:04 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Hugo Agud --- warning: 3 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23295-Automatically-restrict-debar-patrons-whe-6bIBRK.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:43:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:43:01 +0000 Subject: [Koha-bugs] [Bug 12297] Waitingreserves code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12297 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #3 from paxed --- This is no longer valid anyway, the tables in waitingreserves-page have changed to datatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:43:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:43:42 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at outlook.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:48:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:48:10 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:48:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:48:13 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 --- Comment #5 from Jonathan Druart --- Created attachment 98922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98922&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:50:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:50:22 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #42 from Martin Renvoize --- Created attachment 98923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98923&action=edit Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:50:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:50:42 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #43 from Martin Renvoize --- As promised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:51:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:51:35 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #2 from Andrew Isherwood --- Created attachment 98924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98924&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:51:38 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- Done on bug 19008. *** This bug has been marked as a duplicate of bug 19008 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:51:38 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #3 from Andrew Isherwood --- Created attachment 98925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98925&action=edit Bug 24609: Add API unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:51:38 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #50 from Jonathan Druart --- *** Bug 13667 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:51:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:51:39 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 13667, which changed state. Bug 13667 Summary: Provide script to regularly clean deletedborrowers table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:52:17 +0000 Subject: [Koha-bugs] [Bug 20604] Provide a way to anonymise patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 24151 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:52:17 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #34 from Jonathan Druart --- *** Bug 20604 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:52:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:52:18 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 20604, which changed state. Bug 20604 Summary: Provide a way to anonymise patron records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:52:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:52:18 +0000 Subject: [Koha-bugs] [Bug 20645] Print patrons before anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20645 Bug 20645 depends on bug 20604, which changed state. Bug 20604 Summary: Provide a way to anonymise patron records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:53:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:53:06 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Andrew Isherwood --- Test plan: - Apply patch - prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:56:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:56:41 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98707|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 98926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98926&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! Signed-off-by: Bernardo Gonzalez Kriegel Looks correct, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:57:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:57:26 +0000 Subject: [Koha-bugs] [Bug 23799] Mojolicious::Plugin::OpenAPI missing in Debian 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED --- Comment #2 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 22522 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 11:57:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 10:57:27 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 23799, which changed state. Bug 23799 Summary: Mojolicious::Plugin::OpenAPI missing in Debian 10 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:00:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:00:12 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98901|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 98927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98927&action=edit Bug 15352: (RM follow-up) Add missing filters Damn, I missed a case in the first followup! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:01:15 +0000 Subject: [Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:01:36 +0000 Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set for tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:07:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:07:45 +0000 Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #44 from Jonathan Druart --- Switching to Needs Signoff as I would like Aleisha to have a look at Martin's patches. However regression tests are missing, but that does not block human testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:17:47 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Code to select patrons to |Code to select patrons to |purge needs to be |purge needs to be |centralized |centralized (use of | |filter_by) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:36:50 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:36:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:36:52 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #3 from Nick Clemens --- Created attachment 98928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98928&action=edit Bug 24103: (follow-up) Dump query on opac authorities search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:56:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:56:19 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98772|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 98929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98929&action=edit Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:56:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:56:35 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98913|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 98930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98930&action=edit Bug 24661: Fix inclusion of locale-related javascript files 2 js files (Gettext.js, i18n.js) + 1 generated js file (locale_data.js) were added by bug 21156. Their URL are broken and the files are not loaded. Use Template::Toolkit plugin Asset to include these files, and exclude locale_data.js when language is english, because obviously translations are not needed in this case. Test plan: 1. Just make sure the files mentioned above are loaded correctly when in English and in other languages as well Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:00 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Thanks for the quick fix Julian.. works as expected.. going for a fast QA on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:04 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98914|0 |1 is obsolete| | --- Comment #9 from Andrew Isherwood --- Created attachment 98931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98931&action=edit Bug 24608: Add EditDueDates syspref This patch adds a EditDueDates syspref which determines whether a button for editing due dates appears in a patron's checkouts list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:05 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:07 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98915|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood --- Created attachment 98932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98932&action=edit Bug 24608: Allow due date modification This patch adds the ability to modify due dates from a patron's checkouts list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:09 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:15 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:19 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:33 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 12:57:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 11:57:34 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:02:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:02:15 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:02:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:02:17 +0000 Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #22 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:02:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:02:19 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:02:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:02:20 +0000 Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:06:42 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98806|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 98933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98933&action=edit Bug 24651: Add maxdays option to fines cronjob This patch adds an optional maxdays parameter to the fines.pl cronjob. The new parameter allows system administrators to set a maximum number of days for the job to process overdues. This can improve performance. Signed-off-by: Sally Healey -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:07:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:07:41 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:07:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:07:44 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #4 from Jonathan Druart --- Created attachment 98934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98934&action=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:07:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:07:47 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #5 from Jonathan Druart --- Created attachment 98935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98935&action=edit Bug 21746: Remove LoginBranchname and LoginBranchcode Those 2 variables can be replaced by logged_in_user that is passed to all the template via C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:07:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:07:50 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #6 from Jonathan Druart --- Created attachment 98936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98936&action=edit Bug 21746: Remove GetLoggedInBranchcode This method from the Branches TT plugin is not needed as we can use logged_in_user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:07:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:07:54 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #7 from Jonathan Druart --- Created attachment 98937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98937&action=edit Bug 21746: Remove 3 more uneeded variables from C4::Auth They are not used in the templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:10:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:10:11 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #8 from Jonathan Druart --- Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Loggin into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Other occurrences will be check by QA that will make sure there is no typo in the patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:10:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:10:43 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- This has been applied and tested on Cheshire Shared Services production system and they are pleased with the results. Setting the parameter to 6 months has meant that they do not miss any fines in their environment (as all caps will have been reached by this point), but reduced the runtime from 10 hours to 6 minutes (they have a lot of historical checkouts). Sally asked me to add her signoff line for her :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:10:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:10:56 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:19:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:19:57 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #19 from Andrew Isherwood --- - Apply patches (if on a platform requiring this to be done manually) - Run DB updates and rebuild schema (if on a platform requiring this to be done manually) - Rebuild CSS (if on a platform requiring this to be done manually) - Issue an item to a patron - Navigate to Koha Administration > Circulation and fines rules => TEST: Observe that there *isn't* a column titled "Unseen renewals allowed (count)" - Navigate to a patron's checkouts list => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "OpacRenewalAllowed" syspref - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "UnseenRenewals" syspref - Navigate to Koha Administration > Circulation and fines rules - If you have no circulation rules defined, define one that will: - Apply to all patron categories - Apply to item types - Allow renewals => TEST: Observe that there *is* a column titled "Unseen renewals allowed (count)" and the value is empty - Add a value for "Unseen renewals allowed", make the value reasonably low so we can test what happens when that value is reached - Navigate to a patron's checkouts list in the staff client => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - In the OPAC, renew an item => TEST: Observe that, since the renewal took place in the OPAC, the number of unseen renewals left is decremented - In the OPAC, repeatedly renew the item until the unseen renewals limit is reached => TEST: Observe that the item can no longer be renewed and the borrower is advised to take the item to the library - Navigate to the patron's checkouts list in the staff client => TEST: Observe that the item is listed as "Must be renewed at the library" and is blocked from renewal - Select the "Override renewal restrictions" checkbox => TEST: Observe that the item can now be selected for renewal - Select the item and click "Renew or check in selected items" => TEST: Observe that now the item has been renewed by the library, the unseen renewals remaining count has been reset - Select the item for renewal again and check the "Renew as unseen if appropriate" checkbox, click "Renew or check in selected items" => TEST: Observe that, since the item was renewed as "unseen", the unseen renewals remaining has been decremented - Navigate to Circulation > Renew => TEST: Observe that a new "Record renewal as unseen if appropriate" checkbox is displayed - Renew the item, do not check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has not been decremented - Renew the item, check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has been decremented - Navigate to Tools > Notices & Slips, edit the "AUTO_RENEWALS" Email notice => TEST: Observe that there is now a test for the "too_unseen" error, with an appropriate message SIP RENEWALS: - Use sip_cli_emulator.pl to send a renew message for the item, for example: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su -sp --patron --password -l CPL -i -m renew - TEST: Observe that, as the SIP renewal is considered to be "seen", the item's unseen renewals count has been reset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:22:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:22:43 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Kyle, any ideas about how we could fix this correctly? Something bad has happened to CourseReserves::_UpdateCourseItem. This function should check to see if the course is active. If it is inactive, it should edit the values in the course_items table, if it is active, it should edit the values in the items table. In master, it *always* edits the items table, and there is no way to ever update the course_items table no matter if the course is active or inactive! This is appears to be a deeper more problematic issue than the stated one though. I think the solution for the "Unchanged" issue is to add a 'use/ignore' column for each of the swappable columns (itype_enabled, ccode_enabled, etc), along with a checkbox in the editor to enable them. This would solves the original issue, that "Unchanged" as a value has been unreliable and weird. The module was first written without the expectation that a library would want an item column to be undef while *not* on course reserve, and have a value while *on* course reserve. Undef was used to signify the "Leave unchanged" status. It seems that after solving the more pressing issue above, moving the swap-ability indicator to it's own column would be the once-and-for-all solution to this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:25:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:25:14 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #8 from Kyle M Hall --- I'm wondering if we should have the course items editor *only* update the course items table and *never* the items table. That would also mean disabling the ability to edit course items on active course reserve. This could make the system more understandable, though less flexible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:25:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:25:18 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #7 from Magnus Enger --- The patch is an improvement, but there are still some HASH'es left. This one is interesting: Feb 14 12:40:05 kohaserver koha_sip[19050]: ILS::Checkout: patron x has checked out 52450820597 Feb 14 12:40:05 kohaserver koha_sip[19050]: ILS::Checkout: patron x has checked out HASH(0x5635b7193418), 80062844366 Feb 14 12:40:07 kohaserver koha_sip[19050]: ILS::Checkout: patron x has checked out HASH(0x5635b6f1ab80), HASH(0x5635b6f1a2c8), 80062908790 Feb 14 12:40:07 kohaserver koha_sip[19050]: ILS::Checkout: patron x has checked out HASH(0x5635b718c6c8), HASH(0x5635b6f31900), HASH(0x5635b6f20f20), 80059004255 x is the same in all 4 lines. I think this comes from ILS.pm, line 171. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:29:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:29:47 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Martin Renvoize from comment #4) > Nice work everyone! > > Pushed to master for 20.05 Too fast! I was about to sign this :) Anyway, I found the following, not related with this bug, that pops doing a language update (also create and install) to do the testing: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:569: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:858: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:904: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:911: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1095: warning: RegExp literal terminated too early -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:30:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:30:15 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:30:17 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98933|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 98938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98938&action=edit Bug 24651: Add maxdays option to fines cronjob This patch adds an optional maxdays parameter to the fines.pl cronjob. The new parameter allows system administrators to set a maximum number of days for the job to process overdues. This can improve performance. Signed-off-by: Sally Healey Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:42:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:42:37 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:42:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:42:40 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98885|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 98939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98939&action=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:43:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:43:11 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #8 from Owen Leonard --- (In reply to David Nind from comment #6) > A new issue is the pop-up select boxes - they aren't formatted correctly. I forgot to update the test plan with my revised patch: The OPAC CSS needs to be rebuilt! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:49:33 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #18 from Magnus Enger --- (In reply to Stina Hallin from comment #17) > And replace: > [% IF ( HOLD.is_cancelable_from_opac ) %] > > with: > [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( > HOLD.biblio.biblioitem.itemtype )) %] Hm, I think I'm already doing that in the last part of the diff here? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=diff Did I miss some occurrence of this, or did your template not get updated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:55:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:55:03 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #6 from Julian Maurice --- It looks like xgettext does not like ES6 template literals. https://savannah.gnu.org/bugs/?50920 >From what I understand, support for template literals was added in gettext 0.20 (still not packaged in debian) but is still buggy in latest released version 0.20.1 and a fix is present in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 13:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 12:58:41 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, two comments: a) You need to create fr-FR-messages-js.po first, or update fails. I'll try to write a Bug to create them all b) There are problems with qa-tools FAIL koha-tmpl/intranet-tmpl/prog/js/checkouts.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (Loading... you may continue scanning.) - See coding guideline JS5 FAIL koha-tmpl/intranet-tmpl/prog/js/datatables.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (First) - See coding guideline JS5 Untranslatable string found (Last) - See coding guideline JS5 Untranslatable string found (Next) - See coding guideline JS5 Untranslatable string found (Previous) - See coding guideline JS5 Untranslatable string found (No data available in table) - See coding guideline JS5 Untranslatable string found (Showing _START_ to _END_ of _TOTAL_ entries) - See coding guideline JS5 Untranslatable string found (No entries to show) - See coding guideline JS5 Untranslatable string found ((filtered from _MAX_ total entries)) - See coding guideline JS5 Untranslatable string found (Show _MENU_ entries) - See coding guideline JS5 Untranslatable string found (Loading...) - See coding guideline JS5 Untranslatable string found (Processing...) - See coding guideline JS5 Untranslatable string found (Search:) - See coding guideline JS5 Untranslatable string found (No matching records found) - See coding guideline JS5 Untranslatable string found (Copy to clipboard) - See coding guideline JS5 Untranslatable string found (Press ctrl or + C to copy the table data
    to your system clipboard.

    To cancel, click this message or press escape.) - See coding guideline JS5 Untranslatable string found (Copied %d rows to clipboard) - See coding guideline JS5 Untranslatable string found (Copied one row to clipboard) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (All) - See coding guideline JS5 Untranslatable string found (a an the) - See coding guideline JS5 False positives perhaps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:01:02 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 --- Comment #10 from Owen Leonard --- Created attachment 98940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98940&action=edit Bug 16683: (18.11.x) Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:03:04 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:03:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:03:07 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98889|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98941&action=edit Bug 8595: Rename 'host item' to 'host record' To test: 1) Enable the syspref EasyAnalyticalRecords 2) Find a biblio record, go to the detail page 3) Click the Edit dropdown and notice the option "Link to host item" 4) Apply patch and refresh page 5) Click the Edit dropdown and confirm the renamed "Link to host record" button Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel Change makes sense, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:19:07 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #7 from Bernardo Gonzalez Kriegel --- (In reply to Julian Maurice from comment #6) > It looks like xgettext does not like ES6 template literals. > > https://savannah.gnu.org/bugs/?50920 > > From what I understand, support for template literals was added in gettext > 0.20 (still not packaged in debian) but is still buggy in latest released > version 0.20.1 and a fix is present in master. Then we have a little problem with that. Current (19.10/18.04) ubuntu has 0.19.8.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:21:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:21:10 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:31:19 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #8 from Julian Maurice --- (In reply to Bernardo Gonzalez Kriegel from comment #7) > Then we have a little problem with that. Current (19.10/18.04) ubuntu has > 0.19.8.1 Yes, same version in Debian unstable, so we're stuck with this version for some time. One possible workaround is to declare translatable strings as soon as possible in the file (before the first template literal), since xgettext parse these strings correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:44:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:44:25 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #8 from Agustín Moyano --- (In reply to Jonathan Druart from comment #3) > Comment on attachment 98884 [details] [review] > Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t > > Review of attachment 98884 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Koha/Item.t > @@ +173,5 @@ > > + my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); > > + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } ); > > + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } ); > > + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } ); > > + my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } ); > > Do you really need to specify a branchcode here? Ups, that slipped away.. I used it to verify which libraries where tested, and when a library without one of those branchcodes appeared I realized that somewhere they where created. Thanks for the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:46:06 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:46:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:46:09 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 --- Comment #3 from Nick Clemens --- Created attachment 98942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98942&action=edit Bug 23695: Alter transferbook to take a hash of params and specify from_branch To test: 1 - Go to Circulation->Transfer 2 - Find an item from your branch and create a transfer to branch B 3 - Note you can specify the origin and default is 'Item's holding library' 4 - Confirm the item is marked as held at your current branch and is being transferred to B 5 - Find an item from a third branch, branch C 6 - Transfer that item to branch B from branch D 7 - Confirm the item is held at branch D and is being transferred to B 8 - prove -v t/db_dependent/Circulation.t 9 - prove -v t/db_dependent/Koha/Items.t 10 - prove -v t/db_dependent/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:56:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:56:43 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #19 from Stina Hallin --- (In reply to Magnus Enger from comment #18) > (In reply to Stina Hallin from comment #17) > > And replace: > > [% IF ( HOLD.is_cancelable_from_opac ) %] > > > > with: > > [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( > > HOLD.biblio.biblioitem.itemtype )) %] > > Hm, I think I'm already doing that in the last part of the diff here? > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=diff > > Did I miss some occurrence of this, or did your template not get updated? That was line 140. We think that you also need to add it to line 186. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:57:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:57:28 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #9 from Kyle M Hall --- Created attachment 98943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98943&action=edit Bug 23727: Add new columns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:57:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:57:38 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #10 from Kyle M Hall --- Created attachment 98944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98944&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 14:57:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 13:57:41 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #11 from Kyle M Hall --- Created attachment 98945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98945&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:02:27 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:02:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:02:30 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 --- Comment #11 from Nick Clemens --- Created attachment 98946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98946&action=edit Bug 19718: (follow-up) Make messages translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:24:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:24:16 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #20 from Magnus Enger --- Created attachment 98947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98947&action=edit Bug 22833 - QA followup This patch incorporates the suggestions made by Stina Hallin. To test: - Apply with the other patches and make sure there are no errors when following the previous test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:25:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:25:01 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #21 from Magnus Enger --- (In reply to Stina Hallin from comment #19) > That was line 140. We think that you also need to add it to line 186. Ah, gotach! Could you please test again now, with all the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:27:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:27:07 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- (In reply to Jonathan Druart from comment #8) > Test plan: > * Confirm that the library's name is updated This didn't work in my test. The previous library name still showed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:33:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:33:28 +0000 Subject: [Koha-bugs] [Bug 24664] New: Add missing *-messages-js.po Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 Bug ID: 24664 Summary: Add missing *-messages-js.po Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr We need to add missing [lang]-messages-js.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:41:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:41:00 +0000 Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 98948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98948&action=edit Bug 24664: Add missing *-messages-js.po If you try to update some language translation files translate script will complain of missing *-messajes-js.po file. This patch adds those missing files To test: 1) Go to misc translation 2) Update some language, eg- fr-FR Check error /usr/bin/msgmerge: error while opening "/.../misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory 3) Apply this patch 4) Repeat 2), no error message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:41:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:41:38 +0000 Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:41:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:41:57 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:42:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:42:01 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98888|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 98949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98949&action=edit Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:42:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:42:40 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:42:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:42:43 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92516|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 98950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98950&action=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:43:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:43:10 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98669|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes --- Created attachment 98951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98951&action=edit Bug 22833: Schema update, DO NOT PUSH Signed-off-by: Martin Renvoize Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:43:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:43:13 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98670|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 98952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98952&action=edit Bug 22833: Flag booleans in Itemtype.pm Signed-off-by: Martin Renvoize Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:43:15 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98671|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes --- Created attachment 98953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98953&action=edit Bug 22833: Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase Signed-off-by: Martin Renvoize Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:43:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:43:18 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98947|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes --- Created attachment 98954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98954&action=edit Bug 22833 - QA followup This patch incorporates the suggestions made by Stina Hallin. To test: - Apply with the other patches and make sure there are no errors when following the previous test plan. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:44:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:44:27 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #3 from Bernardo Gonzalez Kriegel --- See Bug 24664 for missing *-messages-js.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:44:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:44:39 +0000 Subject: [Koha-bugs] [Bug 24665] New: Add ability to Run Cash Register report with New Cash register feature Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Bug ID: 24665 Summary: Add ability to Run Cash Register report with New Cash register feature Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: martin.renvoize at ptfs-europe.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org With the introduction of Cash Registers in 19.11, it would be ideal if a library could run the "Cash register" report (found under Statistic Wizard in Reports) and specifically choose to refine the report to a specific Cash Register. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:45:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:45:58 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:45:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:45:59 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:46:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:46:02 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98919|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 98955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98955&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:47:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:47:27 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #26 from Magnus Enger --- Thanks, Stina! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:49:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:49:12 +0000 Subject: [Koha-bugs] [Bug 24666] New: Non Koha Guarantors should be able to be seen from the Patron Detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Bug ID: 24666 Summary: Non Koha Guarantors should be able to be seen from the Patron Detail page Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: kyle at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With the introduction of the bug [14570] a patron can have multiple guarantors - these guarantors can be registered patrons or not registered patrons. If they are not registered patrons, currently, they can not be seen from the patron detail or checkout page. At this time, the only way to see these non-Koha guarantors is to edit the patron details. It would be nice if this field was visible for staff on the patron detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:50:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:50:27 +0000 Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98948|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 98956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98956&action=edit Bug 24664: Add missing *-messages-js.po If you try to update some language translation files translate script will complain of missing *-messajes-js.po file. This patch adds those missing files To test: 1) Go to misc translation 2) Update some language, eg- fr-FR Check error /usr/bin/msgmerge: error while opening "/.../misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory 3) Apply this patch 4) Repeat 2), no error message Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:50:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:50:35 +0000 Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:53:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:53:14 +0000 Subject: [Koha-bugs] [Bug 24667] New: Displaying the Home Location of the Item from Search Results in Staff Client Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24667 Bug ID: 24667 Summary: Displaying the Home Location of the Item from Search Results in Staff Client Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some users would like to see the ability to change what is visible in the Location column when searching in the staff client. Currently, when a search is performed, on the brief result screen, the right-hand column is for the item's location. This location indicates where the item actually is, and not it's home location. Some users would like to have the ability to change this to see the home location of the item, not where the item currently is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:54:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:54:15 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:54:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:54:18 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98916|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 98957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98957&action=edit Bug 15850: Correct eslint errors in cataloging.js This patch makes corrections to cataloging.js so that there are no issues flagged by eslint. The fewer eslint warnings we have to see makes it more likely that real problems will be noticed. Some functions were unused have been removed. To test, apply the patch and clear your browser cache if necessary. - Open a MARC record for editing in the basic cataloging editor. - Test the JavaScript-driven functionality affected by the changed file: - Open the authority browser from a field (e.g. 100a) which is linked to an authority type. - Clone a repeatable tag. - Clone a repeatable subfield - "Unclone" a tag or subfield: This should remove the tag or subfield (if possible) or clear the contents of the tag or subfield if not. - Clone a subfield on the item edit page (In my MARC21 installation I had to modify the default framework in order to have a repeatable item subfield to test with). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:54:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:54:51 +0000 Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 [Bug 24664] Add missing *-messages-js.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:54:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:54:51 +0000 Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 [Bug 24662] Remove global variables MSG_* from datatables.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:56:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:56:12 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98887|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 98958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98958&action=edit Bug 24649: Fix missing
  • tag on item editor for cloned subfield Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: To see the difference, test first without patch applied: Mark item subfield, say URI, as repeatable. Clone that subfield in item editor. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 15:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 14:56:16 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98949|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 98959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98959&action=edit Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:06:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:06:53 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer --- Please rebase - should be a quick one, but I messed it up :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:11:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:11:08 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #8 from Katrin Fischer --- > DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_hold.reserve.reserve_id' > isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Issues with GROUP BY usually point to problems with stricter DB settings - that's what I meant. It's possible the tester had a different DBMS version / different settings which made it explode - trying to help because you said you cannot reproduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:14:25 +0000 Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #12 from Katrin Fischer --- If you are still interested in me testing again, please ping me when you are back from vacation - but I believe it's probably fine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:14:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:14:33 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98926|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 98960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98960&action=edit Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! Signed-off-by: Bernardo Gonzalez Kriegel Looks correct, no errors. Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:15:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:15:11 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #22 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #20) > Please rebase - should be a quick one, but I messed it up :( Rebased! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:17:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:17:18 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:17:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:17:22 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98920|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 98961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98961&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:18:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:18:39 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:19:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:19:18 +0000 Subject: [Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- (In reply to Igor A. Sychev from comment #1) > Where do I keep a list of authoritative values for $2? > > orcid = Open Researcher and Contributor Identifier > scopus = Scopus Author Identifier > viaf = Virtual International Authority File > > EX 1 > 017 7# $a0000-0002-8038-722X$2orcid You could link the subfield to an authorised value list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:21:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:21:18 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #23 from Katrin Fischer --- (In reply to Bernardo Gonzalez Kriegel from comment #22) > (In reply to Katrin Fischer from comment #20) > > Please rebase - should be a quick one, but I messed it up :( > > Rebased! Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:21:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:21:26 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #91 from Nick Clemens --- (In reply to Jonathan Druart from comment #90) > Looks like this dev will conflict with bug 15522. Agreed, but I don't think that should be a blocker here. 15522 needs some work, we are gathering notes to post on that bug. This is a much desired feature and should be allowed to proceed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:21:51 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- To summarise.. try setting `1` in your koha-conf.xml Aleisha.. it's on by default in sandboxes and dev environments to weed out queries that would fail we strict features enabled at the SQL level. Looking at the error Kelly is reporting it sounds like strict SQL is enabled and she's catching an error in your reworked SQL query that you're not seeing with sql in 'forgiving' mode ;). I've not looked at the code yet, but this usually arrises from a group by on a query with a join where you're trying to group by an id field in on table.. the fix, as horrible as it is, is to add all fields in that table to the group by. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:24:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:24:46 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:24:49 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95809|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 98962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98962&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:25:25 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #92 from Christopher Brannon --- It seems this only has the ability to have a single parent set. What about when you have a set limit for a smaller group, like video media, but you also have a bigger group that this group is a part of that has a limit? Can a group have a parent? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:32:33 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #19 from Katrin Fischer --- I am not sure about this one: The difference between the URL in the record and in the item is that I can define a link text for URLs in the record, but I can't for items. We are now forcing this change on everyone. Say the library has chosen "full text" on the UrlLinkText but that doesn't apply to all item urls? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:36:40 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:36:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:36:43 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #10 from Owen Leonard --- Created attachment 98963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98963&action=edit Bug 23888: Do not allow invalid vendor id on creating a subscription It will avoid crash and invalid data when creating/updating a subscription. This could have been done with a AJAX query but seems more convenient this way. Test plan: - Create or update a subscription - In the "Vendor" input try an empty string, a valid vendor's id, and invalid one. => With an empty string you get the existing alert message => With a valid id you do not get any messages => With an invalid id you are not allowed to go to page 2 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:36:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:36:46 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #11 from Owen Leonard --- Created attachment 98964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98964&action=edit Bug 23888: (follow-up) Wrap English string in translation function This patch makes alert added in subscription-add.js translatable using the new __() function. To test, apply the patch and confirm that the alert still works correctly when submitting the subscription edit form with an invalid vendor id. Test that the string can be translated (using fr-Fr for example): 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR Switch to the fr-FR translation and confirm the the alert shows your translated string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:40:30 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #12 from Owen Leonard --- Notes: - I squashed the original 2 patches according to guidelines - The QA tool will give a false positive on untranslatable strings because it hasn't been updated along with the new JS-translation features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:50:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:50:45 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:50:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:50:48 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93912|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 98965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98965&action=edit Bug 23384: Fix "strict subs" error This patch explicitly imports Koha::ArticleRequest::Status to avoid the strict subs error described in the bug. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:53:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:53:58 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 --- Comment #7 from Owen Leonard --- I signed this off because following this test plan is consistent with what the bug report says, with the assumption that the goal of the change is to allow at some future date the addition of "use Koha::Illrequests;" to Circulation.pm. 1. Add "use Koha::Illrequests;" to the top of C4/Circulation.pm 2. TEST: Nothing loads, the koha-plack-error log is stuck in an apparent loop 3. Add "use Koha::ArticleRequest::Status;" to Patron.pm 4. TEST: Pages are loading correctly again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:57:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:57:06 +0000 Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 16:57:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 15:57:10 +0000 Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78175|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98966&action=edit Bug 12187: Duplicate TT code for serial statuses Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. Needs a test plan, but I haven't used serials. Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:02:33 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #24 from Katrin Fischer --- Could we keep them from creeping back in with a new addition to the QA test tools? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:05:19 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dch at interleaf.ie --- Comment #11 from Daphne Hoolahan --- I applied the patch on Sandbox 5, set the syspref to allow, but I'm not seeing the new button beside the due date on the checkouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:05:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:05:48 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:05:51 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98922|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 98967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98967&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:08:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:08:49 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:08:53 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98960|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 98968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98968&action=edit j# Attachment to Bug 23084 - Replace grep {^$var$} with grep {$var eq $_} Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} We certainly faced 3 similar bugs due to this syntax: bug 23006, bug 22941 and bug 17526. To prevent other issues related to this syntax this patch suggests to replace them all in one go. Test plan: Confirm that the 2 syntaxes are similar Eyeball the patch and confirm that there is no typo! Signed-off-by: Bernardo Gonzalez Kriegel Looks correct, no errors. Rebased. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:14:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:14:48 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:14:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:14:50 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in rda 264 subfield b on opac xslt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98860|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 98969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98969&action=edit Bug 24654: Remove trailing quote in rda264 XSLT To test: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search 6 - Apply patch 7 - Refresh 8 - Link is correctly formed now Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:22:21 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:22:23 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98890|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 98970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98970&action=edit Bug 9989: Stay on basket page after closing it Instead of redirecting to the list of vendor's baskets. To test: 1) Go to Acquisitions. Ensure you have a budget, fund and vendor defined. 2) Create a basket. Add an item to it. 3) Close the basket. Do not attach to a basketgroup. 4) Notice you are redirected to the list of vendor's baskets. 5) Apply the patch and go to the basket's page. Reopen the basket. 6) Close the basket. Do not attach to a basketgroup. 7) Confirm you remain on the closed basket's page. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:23:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:23:54 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98422|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 98971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98971&action=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:24:43 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:27:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:27:46 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98809|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 98972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98972&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:27:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:27:50 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98810|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 98973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98973&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:27:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:27:54 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #17 from Katrin Fischer --- Created attachment 98974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98974&action=edit Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:28:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:28:49 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Katrin Fischer --- I am not in favor of relying on JavaScript here - so I am proposing a follow-up that uses checks on TT level instead. Could you have a look Aleisha or David? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:30:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:30:52 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Andrew Fuerste-Henry --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:31:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:31:54 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:39:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:39:01 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97944|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 98975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98975&action=edit Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC Test plan : - create a marc modification template which add a new field to a record - apply that template to some records - verify that the new field is always appended at the bottom of the record, even if some fields are higher. - apply patch - apply template to another set of records - verify the added field is now ordered within the already existing fields in the records Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:39:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:39:03 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97945|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 98976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98976&action=edit Bug 24480: Unit test Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:41:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:41:07 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:44:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:44:36 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #8 from Nick Clemens --- Created attachment 98977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98977&action=edit Bug 23102: Add fieldset to login for selenium usage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:44:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:44:39 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #9 from Nick Clemens --- Created attachment 98978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98978&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:45:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:45:18 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #10 from Nick Clemens --- The behaviour does still recur and can be fixed by this patch, however, I can't make the selenium tests fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:53:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:53:10 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #5 from Heather --- This would be SO useful and would save me SO much time if I could set the order of subfields in each MARC field in the framework for bibs, but especially for authorities, since there is only a basic editor for authorities, and I spend a lot of time going, "click, click, click, click..." to put the subfield in the correct order, e.g., in a 100 field, it's commonly $a, $q, $d... It would also encourage correct cataloging for those who use the basic bib editor because the the most commonly correct order of subfields could be set at the framework level, encouraging more correct input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:53:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:53:15 +0000 Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Sorry but with this patch applied the sorting is completely broken! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:54:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:54:05 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:54:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:54:08 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98858|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 98979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98979&action=edit Bug 13574: Fix display of repeatable item subfields Applies to OPAC and staff: opac-MARCdetail and catalogue/MARCdetail. Test plan: [1] Pick an item. Pick two fields say URI and copy number, and fill these with a value like A | B. (The pipe char is important.) [2] Verify that the display of the item block on opac-MARCdetail shows both A and B in those columns. (Previously only B was shown.) [3] Verify the same on catalogue MARC detail, items tab. Signed-off-by: Marcel de Rooy Signed-off-by: Holly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:59:03 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Donna --- Updated testing plan: Test Plan: 1) Apply this patch 2) Set NoIssuesChargeGuarantorsWithGuarantees to $14 3. Set NoIssuesChargeGuarantees to $14 4) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children 5) Give 3 of the 4 a $5 fine 6) None of them should be able to check out items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 17:59:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 16:59:24 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98970|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98980&action=edit Bug 9989: Stay on basket page after closing it Instead of redirecting to the list of vendor's baskets. To test: 1) Go to Acquisitions. Ensure you have a budget, fund and vendor defined. 2) Create a basket. Add an item to it. 3) Close the basket. Do not attach to a basketgroup. 4) Notice you are redirected to the list of vendor's baskets. 5) Apply the patch and go to the basket's page. Reopen the basket. 6) Close the basket. Do not attach to a basketgroup. 7) Confirm you remain on the closed basket's page. Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:02:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:02:07 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #6 from Donna --- When checking out to parent, the total that shows is the total fine amount for the guarantees, does not include the other guarantor dollar amount. For example, Child 1 owes $5, Child 2 owes $5, Parent 1 owes $5. When parent 2 checks out, message states $10 owed by guarantees. When Child 3 (no fines) checks out, message states: The patron's guarantors and their other guarantees collectively have a debt of 15.00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:02:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:02:46 +0000 Subject: [Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #6 from Heather --- The 035 is a repeatable field, so especially among OCLC users, there can be many 035 fields with record numbers from various systems that have had (or still have) versions of the record. The 001 field is *not* repeatable, so is commonly used by OCLC users as the current, unique OCLC record number. ByWater has done a lot of work for us to get our 7XX $w linking entry fields to work as a hyperlink to execute a search on the 001 (OCLC number) of the target record in our catalog, https://keys.bywatersolutions.com/ Liz Rea is the latest person that we worked with on it (c.f. ByWater support ticket #45916)--perhaps that work can be contributed to the community? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:03:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:03:36 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:03:38 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #93 from Nick Clemens --- (In reply to Christopher Brannon from comment #92) > It seems this only has the ability to have a single parent set. What about > when you have a set limit for a smaller group, like video media, but you > also have a bigger group that this group is a part of that has a limit? Can > a group have a parent? No, this development only allows for a single level groups, they cannot be nested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:04:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:04:59 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Severity|enhancement |normal Depends on| |14570 --- Comment #1 from Lisette Scheer --- This is going to be a big problem for us. We don't link the guarantors at all. I'm changing this from enhancement because on 19.05 we can see non-koha guarantors on the patron detail page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:04:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:04:59 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:05:58 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:06:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:06:00 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98785|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 98981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98981&action=edit Bug 22655: Adding holds rules to Onboarding tool This patch adds the following fields to the circ rule step in the onboarding tool: - holds allowed (total) - holds allowed (daily) - holds per record (count) To test: 1) Apply patch, drop and recreate database, restart memcached and refresh page 2) Go through the installer and get to the final step of the onboarding tool 3) Confirm the above fields are now available to set in your circulation rule 4) Save and log in to Koha 5) Go to Admin -> Circ and fines rules 6) Confirm the fields saved correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:07:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:07:46 +0000 Subject: [Koha-bugs] [Bug 20839] Edit as new (duplicate) doesn't work with advanced editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20839 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #2 from Heather --- I agree with Shanna completely! Right now I have to use two different browsers & this is my workaround workflow: Go to record in Chrome, which is set to basic editor. Duplicate record in Chrome with basic editor, save record. Copy URL. Go to Firefox, which is set to advanced editor, paste in record URL, then go to edit record. Lots of "click, click, click, click, click..." when I would save SO much time just being able to duplicate the record in the advanced editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:09:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:09:09 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97891|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 98982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98982&action=edit Bug 24514: Add option to exclude title from patron-title.inc Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:09:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:09:17 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98982|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98983&action=edit Bug 24514: Add option to exclude title from patron-title.inc Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:09:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:09:43 +0000 Subject: [Koha-bugs] [Bug 23828] Elasticsearch - ES - Authority record results not ordered correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:10:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:10:14 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Andrew Fuerste-Henry --- To test: - generate and capture a hold for a patron named "Mr. A A" - generate and capture a hold for a patron named "A A" - generste and capture a hold for patron named "Mr. B B" - generste and capture a hold for patron named "B B" - go to holds awaiting pickup - sort by patron name ascending - holds sort Mr. A, Mr. B, A, B - sort by patron name descending - holds sort B, A, Mr. B, Mr. A - APPLY PATCH - Reload holds awaiting pickup - Confirm holds sort on Surname -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:13:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:13:29 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:29:36 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96803|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 98984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98984&action=edit Bug 24176: add datelastborrowed column Signed-off-by: Maryse Simard Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:34:10 +0000 Subject: [Koha-bugs] [Bug 24601] Catalogue detail table last seen date not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24601 --- Comment #1 from Owen Leonard --- I can't reproduce this problem. Can you check again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:36:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:36:22 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Sorry, Nick: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt FAIL filters missing_filter at line 23 ( ) missing_filter at line 55 ( [% IF ( cn_loo.barcode ) %] ([% cn_loo.barcode %])[% END %]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:36:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:36:42 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer --- Created attachment 98985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98985&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:37:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:37:06 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- I never get a successful message when vendor has no contact -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:37:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:37:26 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96210|0 |1 is obsolete| | --- Comment #34 from Lisette Scheer --- Created attachment 98986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98986&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:37:28 +0000 Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:38:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:38:03 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92602|0 |1 is obsolete| | --- Comment #35 from Lisette Scheer --- Created attachment 98987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98987&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '
    .' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:38:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:38:29 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92601|0 |1 is obsolete| | --- Comment #36 from Lisette Scheer --- Created attachment 98988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98988&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:38:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:38:56 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96219|0 |1 is obsolete| | --- Comment #37 from Lisette Scheer --- Created attachment 98989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98989&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:39:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:39:10 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:40:23 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 --- Comment #1 from David Roberts --- Created attachment 98990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98990&action=edit Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:41:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:41:08 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:42:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:42:24 +0000 Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:42:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:42:43 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 --- Comment #2 from David Roberts --- I feel that any clarification to the use of this system preference would be better documented in more / greater detail in the manual, rather than in the system preference itself so I haven't changed the description at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:43:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:43:23 +0000 Subject: [Koha-bugs] [Bug 24503] Missing use in value builder barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- missing dependency for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:43:47 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:43:50 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98759|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 98991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98991&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:44:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:44:59 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:45:03 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98356|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 98992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98992&action=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:45:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:45:06 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98635|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 98993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98993&action=edit Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy Tested by enabling the prefs and passing contents to the template var. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:45:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:45:30 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #14 from Katrin Fischer --- Hope to see a patch for bug 24617 soon too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:47:16 +0000 Subject: [Koha-bugs] [Bug 24390] Add Item Total to Rotating collections (addItems.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97127|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 98994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98994&action=edit Bug 24390: Add Item Total to Rotating collections Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:47:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:47:39 +0000 Subject: [Koha-bugs] [Bug 24390] Add Item Total to Rotating collections (addItems.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:48:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:48:37 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:48:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:48:41 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98661|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 98995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98995&action=edit Bug 20882: Move items.uri to mediumtext Applies to items and deleteditems. Test plan: Run new install or upgrade. Check field size. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:49:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:49:14 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #6) > (In reply to Nick Clemens from comment #5) > > Signed-off-by: Nick Clemens > > Thx for very fast SO ! Thx for a nice clean patch and not forgetting about deleteditems :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:50:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:50:54 +0000 Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:50:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:50:54 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug 23996 depends on bug 24507, which changed state. Bug 24507 Summary: Checkouts/ReturnClaim.t is failing on MySQL 8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:54:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:54:19 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #23 from Andrew Fuerste-Henry --- The sandbox got mad about letting me sign off, but I followed the test plan successfully. Signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:54:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:54:35 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98442|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 98996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98996&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:54:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:54:36 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:54:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:54:37 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98634|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 98997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98997&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:54:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:54:39 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98859|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 98998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98998&action=edit Bug 24506: Multibranch limit does not work with ElasticSearch Test plan 1. Set up a system with ElasticSearch 2. Set up or make sure ther are at least two branches 3. create a group of branches 4. make sure there are items associated with any library in the group 5. make a search in opac limited by the library group 6. make an advanced search in intra limited by the library group 7. change SearchEngine system preference to Zebra and repeat 5. and 6. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:55:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:55:58 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:57:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:57:08 +0000 Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table does not hide Account Type properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #6 from Lucas Gass --- backported to 19.05.x. for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:59:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:59:19 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 18:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 17:59:21 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95486|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 98999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98999&action=edit Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:00:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:00:20 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:00:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:00:23 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #7 from Nick Clemens --- Created attachment 99000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99000&action=edit Bug 18499: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:08:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:08:10 +0000 Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I get this warning from the QA tool: FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column export_format.opac_option is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/ExportFormat.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:11:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:11:04 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- Christopher, I'm not able to replicate this in Master. I tried to confirm the behavior before applying the patch and haven't gotten the expiration date to come up null. Can you please confirm the problem still exists and/or provide steps to replicate it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:13:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:13:18 +0000 Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified email column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:14:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:14:42 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:16:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:16:27 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #11 from David Roberts --- That's odd - it seems to apply OK on the PTFS Europe sandboxes, and on my dev server. Please can you try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:16:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:16:31 +0000 Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:17:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:17:44 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:17:47 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98990|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 99001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99001&action=edit Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:27 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:30 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98939|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 99002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99002&action=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:39 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:42 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 99003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99003&action=edit error message This is the error Kyle got when trying to apply this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:42 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98972|0 |1 is obsolete| | Attachment #98973|0 |1 is obsolete| | Attachment #98974|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 99004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99004&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:45 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #20 from Owen Leonard --- Created attachment 99005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99005&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:31:48 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #21 from Owen Leonard --- Created attachment 99006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99006&action=edit Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:33:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:33:43 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #13 from David Roberts --- Very odd. I'll rewrite and re-submit. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:35:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:35:12 +0000 Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475 --- Comment #14 from Andrew Fuerste-Henry --- Tried it again on the sandbox, was unsuccessful again. Kyle tried it on his system, was also unsuccessful, and pulled out an error, which I've attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:35:21 +0000 Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:35:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:35:31 +0000 Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:39:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:39:51 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:40:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:40:59 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:02 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98449|0 |1 is obsolete| | Attachment #98450|0 |1 is obsolete| | Attachment #98843|0 |1 is obsolete| | Attachment #98844|0 |1 is obsolete| | Attachment #98845|0 |1 is obsolete| | Attachment #98846|0 |1 is obsolete| | Attachment #98847|0 |1 is obsolete| | Attachment #98848|0 |1 is obsolete| | --- Comment #26 from Liz Rea --- Created attachment 99007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99007&action=edit Bug 24156: DB changes Add a new table tables_settings to store default_display_length and default_sort_order. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:34 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #27 from Liz Rea --- Created attachment 99008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99008&action=edit Bug 24156: DBIC changes Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:37 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #28 from Liz Rea --- Created attachment 99009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99009&action=edit Bug 24156: move ColumnsSettings to TablesSettings We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:40 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #29 from Liz Rea --- Created attachment 99010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99010&action=edit Bug 24156: Add columns_settings.yml changes Modification of the structure of the yml file. It was table: - column list It now becomes table: default_display_length: X default_sort_order: Y columns: - column list Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:42 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #30 from Liz Rea --- Created attachment 99011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99011&action=edit Bug 24156: Add missing columns to yml There were 2 columns missing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:45 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #31 from Liz Rea --- Created attachment 99012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99012&action=edit Bug 24156: Adjust other tables in the yml file To match the new structure, we adjust the other tables. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:48 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #32 from Liz Rea --- Created attachment 99013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99013&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. Sponsored-by: Institute of Technology Tallaght Signed-off-by: Liz Rea Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:41:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:41:51 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #33 from Liz Rea --- Created attachment 99014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99014&action=edit Bug 24156: Fix set sort order to the first column In that case it's equal to 0 and we need to adjust the test condition. Signed-off-by: Liz Rea Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:46:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:46:11 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91303|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer --- Created attachment 99015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99015&action=edit Bug 6815: Add a 'Take Patron Image' ability This does not just click in place, which would be nice. But it does take the picture, download to a file, and then let's the user use the existing upload functionality to add the photo. If wording or formating is ugly, feel free to tweak. TEST PLAN --------- 1) the 'patronimages' system preference in Patrons system preferences must be set to 'Allow'. 2) apply the patch 3) go to any patron 4) click the 'Take' button. -- it is in the text area on the right, and not the hover over the image area. Adding here would require CSS changes, which are now difficult and ugly to do. -- new tab should open. If you have a working webcam, you should see it playing 'live'. 5) click the "Take the Patron's Picture" button -- this should download a photo SamplePhoto.jpg or some variation of that. 6) close this tab, and click the 'Edit' or 'Add' button for the patron image. 7) click 'Choose File' and choose the file that was created 8) click 'Upload' -- the webcam photo should now be used. 9) run koha qa test tools Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:46:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:46:48 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:46:51 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91335|0 |1 is obsolete| | --- Comment #34 from Lisette Scheer --- Created attachment 99016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99016&action=edit Bug 6815: Detect Webcam to show or not button It's hard to test on a laptop with a webcam built it. So, please attempt with: The system preference patronimage set to allow. And in any given patron detail page, see if the 'Take' button appears/disappears with a refresh while plugging and unplugging a webcam. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:49:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:49:02 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 19:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 18:58:01 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lisetteslatah at gmail.com --- Comment #4 from Lisette Scheer --- Applying: Bug 23695: Set holding branch to transferring branch when manually initiating a transfer Using index info to reconstruct a base tree... M C4/Circulation.pm M circ/branchtransfers.pl M t/db_dependent/Circulation.t M t/db_dependent/Koha/Items.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Items.t Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t Auto-merging circ/branchtransfers.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23695: Set holding branch to transferring branch when manually initiating a transfer The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:06:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:06:35 +0000 Subject: [Koha-bugs] [Bug 18922] Mana - Share review In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:07:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:07:41 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:07:43 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98803|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 99017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99017&action=edit Bug 20897: Add generic cronjob to run plugins with a cronjob method This adds a run_cronjob_plugins.pl script, which will run the cronjob-methods of the installed plugins. Test plan: 1) Enable plugins, upload the Bug20897 test plugin 2) Set up the run_cronjob_plugins.pl in cronjob 3) Check the cron logs to see the message "PLUGIN Bug20897: CRONJOB" shows up there every time the cronjob is run 4) Test that the plugins-home.pl -page can filter the cronjob plugins Signed-off-by: Pasi Kallinen Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:07:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:07:51 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 --- Comment #4 from Liz Rea --- Created attachment 99018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99018&action=edit Bug 20897 - add commented cron example to cron.hourly To test: Have a look at kohaclone/debian/koha-common.cron.hourly, see that there is a job in there for running the plugin cron jobs for every Koha instance. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:08:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:08:44 +0000 Subject: [Koha-bugs] [Bug 23717] Login for Mana Content Knowledge Base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23717 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:14:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:14:41 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass --- choosing to backport this enhancement into 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:27:38 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:27:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:27:42 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98726|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 99019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99019&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:27:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:27:45 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98727|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 99020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99020&action=edit Bug 21921: Add date publication year to biblio Z39.50 search form in acquisition Test plan: 1) Apply the patch 2) Have a Z39.50 endpoint with attr 31 defined - Library of Congress supports this 3) Try to find some biblio records through Z39.50 using the new field "Publication year" in acquisition module Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:33:55 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:33:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:33:58 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98924|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer --- Created attachment 99021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99021&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:34:12 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98925|0 |1 is obsolete| | --- Comment #6 from Lisette Scheer --- Created attachment 99022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99022&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:36:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:36:16 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95792|0 |1 is obsolete| | Attachment #98928|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 99023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99023&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:36:19 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #5 from Owen Leonard --- Created attachment 99024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99024&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:38:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:38:22 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #6 from Owen Leonard --- I tested these under Zebra ONLY, so I don't think I can mark this as signed off. But I wanted to at least give a signoff for Zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:47:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:47:00 +0000 Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 --- Comment #5 from David Nind --- Thanks Bernardo! I don't know anything about serials, so will wait for a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:53:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:53:22 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:53:24 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98782|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 99025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99025&action=edit Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 20:57:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 19:57:47 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lisetteslatah at gmail.com --- Comment #4 from Lisette Scheer --- It works except 2 different links are generated for clubs. If you click directly on the club name, you get this: http://localhost:8081/cgi-bin/koha/reserve/%2Fcgi-bin%2Fkoha%2Freserve%2Frequest.pl%3Fclub%3D2%26amp%3Bbiblionumber%3D6 If you click anywhere else on the table line you get this: http://localhost:8081/cgi-bin/koha/reserve/request.pl?club=2&biblionumber=6 Only the 2nd one works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:09:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:09:11 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #59 from Christopher Brannon --- In my humble opinion, I think: 1) There should be a preference as to whether or not lost items are renewed. Some libraries want that, others do not. 2) There should be a preference as to whether or not patrons can renew lost items via OPAC/SIP/Self Check. 3) There should be a preference as to whether or not there should be a warning when renewing a lost item. 4) There should be a preference as to whether or not the Renew all button/Select all link includes lost items. 5) There should be a preference as to whether or not the lost fee is refunded on renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:16:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:16:55 +0000 Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:18:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:18:15 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #229 from Andreas Roussos --- Created attachment 99026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99026&action=edit Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:18:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:18:20 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #230 from Andreas Roussos --- Created attachment 99027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99027&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:22:03 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:22:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:22:06 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #7 from Andreas Roussos --- Created attachment 99028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99028&action=edit Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:22:09 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #8 from Andreas Roussos --- Created attachment 99029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99029&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t https://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:23:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:23:05 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #12 from Kyle M Hall --- Follow work at: https://github.com/bywatersolutions/bywater-koha-devel/commits/bug_23727 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:26:35 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com --- Comment #12 from Bouzid Fergani --- HI, Rebase it for testing. Bug 21903 - koha-dump be able to include koha-upload 93862 - Bug 21903: koha-dump can export uploaded and temporary uploaded files Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21903: koha-dump can export uploaded and temporary uploaded files Using index info to reconstruct a base tree... M debian/scripts/koha-dump M debian/scripts/koha-functions.sh Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-functions.sh Auto-merging debian/scripts/koha-dump CONFLICT (content): Merge conflict in debian/scripts/koha-dump error: Failed to merge in the changes. Patch failed at 0001 Bug 21903: koha-dump can export uploaded and temporary uploaded files The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21903-koha-dump-can-export-uploaded-and-tempor-jZTdqB.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:27:08 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:28:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:28:58 +0000 Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #31 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:31:19 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95296|0 |1 is obsolete| | --- Comment #3 from Bouzid Fergani --- Created attachment 99030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99030&action=edit Bug 23596: Edit suggestion's reason when receiving This patch displays and let the librarian edit the suggestion.reason information when receiving an order. Note that if no reason was given the edit is not possible (easily modifiable if needed but it seems that we do not want to display too much details unnecessarily) Test plan: - Create a suggestion and fill the reason - Create an order from this suggestion - Close the basket and start receiving the order => The reason is displayed and editable - Modify the reason and click Save - Receive again => The reason has been correctly modified - Play with the "Others..." option and give a specific reason Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:32:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:32:07 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99029|0 |1 is obsolete| | --- Comment #9 from Andreas Roussos --- Created attachment 99031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99031&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:33:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:33:29 +0000 Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference description to make clear where it will apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:37:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:37:48 +0000 Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:40:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:40:51 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 --- Comment #4 from Bouzid Fergani --- Created attachment 99032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99032&action=edit Bug 24269: Adjust C4::Heading to generate headings from auth tags To test: 1 - Be using Elasticsearch 2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields don't matter) 3 - Add a topic term authority record like "150 $aCats$vFiction" 4 - Add a 650 with $aCats and $vFiction and $e depicted to a bibliographic record 5 - Run the linker for the bib perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v 6 - Confirm the record is not correctly linked to the record 7 - Apply patch 8 - Reindex authorities for ES perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a 9 - Run the linker and confirm record is correctly linked perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:42:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:42:05 +0000 Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:46:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:46:33 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:48:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:48:36 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #10 from Andreas Roussos --- I've just realised that the URL for the git-bz test bug here on Bugzilla (Bug 6473) got included at the end of my previous commits. I tried to attach my patches to the test bug before attaching them here (just to be on the safe side), but must have messed up somewhere. I will re-attach them now... Sorry for any confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:49:22 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 --- Comment #5 from Bouzid Fergani --- Created attachment 99033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99033&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:50:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:50:38 +0000 Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:51:38 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99028|0 |1 is obsolete| | Attachment #99031|0 |1 is obsolete| | --- Comment #11 from Andreas Roussos --- Created attachment 99034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99034&action=edit Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:51:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:51:41 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #12 from Andreas Roussos --- Created attachment 99035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99035&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:52:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:52:20 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 --- Comment #6 from Bouzid Fergani --- Created attachment 99036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99036&action=edit Bug 24009: Add Unit Tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:52:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:52:59 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99036|0 |1 is obsolete| | --- Comment #7 from Bouzid Fergani --- Created attachment 99037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99037&action=edit Bug 24009: Add Unit Tests Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=23596 Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:55:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:55:03 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Attachment #99032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:55:24 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:56:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:56:13 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:58:20 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98929|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 99038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99038&action=edit Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 21:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 20:58:39 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:00:10 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97996|0 |1 is obsolete| | --- Comment #8 from Bouzid Fergani --- Created attachment 99039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99039&action=edit Bug 24269: Adjust C4::Heading to generate headings from auth tags To test: 1 - Be using Elasticsearch 2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields don't matter) 3 - Add a topic term authority record like "150 $aCats$vFiction" 4 - Add a 650 with $aCats and $vFiction and $e depicted to a bibliographic record 5 - Run the linker for the bib perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v 6 - Confirm the record is not correctly linked to the record 7 - Apply patch 8 - Reindex authorities for ES perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a 9 - Run the linker and confirm record is correctly linked perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:00:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:00:42 +0000 Subject: [Koha-bugs] [Bug 24668] New: Allow users to specify in plugins how often to run the plugin's cron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24668 Bug ID: 24668 Summary: Allow users to specify in plugins how often to run the plugin's cron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 20897 as an extension of bug 20897, it would be nice for plugin authors to be able to specify when to run a cron. One way to do it might be to have minute, hourly, and daily default crons, and they each check for the timing flag in the plugin config. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:00:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:00:42 +0000 Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24668 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24668 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24668 [Bug 24668] Allow users to specify in plugins how often to run the plugin's cron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:00:47 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:01:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:01:10 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:01:18 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:01:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:01:20 +0000 Subject: [Koha-bugs] [Bug 24668] Allow users to specify in plugins how often to run the plugin's cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24668 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- and a "do not run the cron for this plugin" option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:02:11 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95530|0 |1 is obsolete| | --- Comment #11 from Bouzid Fergani --- Created attachment 99040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99040&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:02:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:02:14 +0000 Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:02:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:02:23 +0000 Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:02:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:02:23 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Bug 24363 depends on bug 24546, which changed state. Bug 24546 Summary: Club/Hold.t has a wrong call to build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:03:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:03:28 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95346|0 |1 is obsolete| | --- Comment #8 from Bouzid Fergani --- Created attachment 99041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99041&action=edit Bug 24009: Add Unit Tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:04:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:04:33 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95345|0 |1 is obsolete| | --- Comment #9 from Bouzid Fergani --- Created attachment 99042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99042&action=edit Bug 24009: Add filter_by option to outstanding_debits This patch adds an optional 'filter_by' argument to Koha::Account->outstanding_debits which current accepts 'blocks_issue' and will filter down the result set of outstanding_debits based upon the values of the following system preferences. * `HoldsInNoissuesCharge` * `RentalsInNoissuesCharge` * `ManInvInNoissuesCharge` Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:04:38 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99041|0 |1 is obsolete| | --- Comment #10 from Bouzid Fergani --- Created attachment 99043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99043&action=edit Bug 24009: Add Unit Tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:04:39 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 --- Comment #11 from Lucas Gass --- enhancement, not backporting to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:04:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:04:49 +0000 Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:09:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:09:04 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97847|0 |1 is obsolete| | --- Comment #9 from Bouzid Fergani --- Created attachment 99044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99044&action=edit Bug 22245: Allow copy/move from and to control fields The JS conditions were wrong, we want to allow copy and move between control fields. Test plan: Create a new MARC modification template action using control fields. Confirm that you are allowed to copy/move a control field to another one Signed-off-by: Hayley Mapley Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:13:50 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97070|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 99045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99045&action=edit Bug 22774: New systempreferences for suggestions Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:13:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:13:53 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97071|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 99046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99046&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:13:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:13:57 +0000 Subject: [Koha-bugs] [Bug 24669] New: Editing circulation rule breaks holds when total holds unlimited Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Bug ID: 24669 Summary: Editing circulation rule breaks holds when total holds unlimited Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 18936 Add a new rule, leave holds values empty and save. After saving, the values show in the table as 'unlimitd' Edit the rule, the editor shows the values not empty, but the string 'unlimited'. Saving the rule now without fixing this means you can no longer place holds. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:13:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:13:57 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 [Bug 24669] Editing circulation rule breaks holds when total holds unlimited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:14:08 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:22:12 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:22:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:22:51 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:23:33 +0000 Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget planning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98060|0 |1 is obsolete| | --- Comment #6 from Bouzid Fergani --- Created attachment 99047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99047&action=edit Bug 17016: Button to clear all fields in budget planning I have used the function from admin --> circ and fines rules To test: 1) Go to Admin --> Budgets 2) Click a budget 3) Click Planning -> any option 4) Test the Auto-fill button to see what it does 5) Apply patch and refresh page 6) Should now be a Clear button 7) Auto-fill the row then click Clear button. Confirm it clears all fields and sets the fund remaining back to the original amount and styles. 8) Add another fund and confirm that this still works with multiple funds. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:24:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:24:31 +0000 Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget planning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:27:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:27:34 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:28:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:28:07 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:31:33 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:34:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:34:06 +0000 Subject: [Koha-bugs] [Bug 24670] New: Circulation and fine rules page has performance issues since issuingrules change Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Bug ID: 24670 Summary: Circulation and fine rules page has performance issues since issuingrules change Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 18936 Opening the circulation and fines rules page takes much longer than before bug 18936 even if there is only a single rule. Saving and editing a rule also takes longer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:34:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:34:06 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:36:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:36:08 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:38:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:38:52 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:42:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:42:09 +0000 Subject: [Koha-bugs] [Bug 24671] New: Unable to set a holiday as repeating going forward only Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24671 Bug ID: 24671 Summary: Unable to set a holiday as repeating going forward only Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a library hasn't been closed on Fridays in the past but starting in the month of February, they will be closed every Friday. When this is put in as a Holiday repeated every same day of the week- Koha will make every Friday going forward in the calendar and going backward in the calendar as closed. A library would like to make a holiday repeating going forward only, not necessarily including past days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:45:04 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 --- Comment #7 from Lucas Gass --- doesn't clean apply and I don't think this is necessary in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:45:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:45:13 +0000 Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column should account for waiting on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:52:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:52:29 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:52:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:52:33 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95120|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 99048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99048&action=edit Bug 19718: Show message if patron has existing holds on a title To test: 1 - Set a rule to allow multiple holds on a title 2 - Place a single hold in the opac for a patron 3 - Return to record and attempt place a second hold 4 - Note there is no message but that you must match the type placed before (item or record level) 5 - Don't place the hold 6 - Apply patch 7 - Attempt to place second hold again 8 - Note there is a message informing you of which level hold you may place 9 - Test with both item/record level holds and placing a single request or multiple requests Signed-off-by: donnab Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:52:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:52:42 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98946|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 99049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99049&action=edit Bug 19718: (follow-up) Make messages translatable Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:57:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:57:13 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:57:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:57:44 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99035|0 |1 is obsolete| | --- Comment #13 from Lisette Scheer --- Created attachment 99050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99050&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:58:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:58:22 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99050|0 |1 is obsolete| | --- Comment #14 from Lisette Scheer --- Created attachment 99051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99051&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:58:58 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:59:01 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99034|0 |1 is obsolete| | --- Comment #15 from Lisette Scheer --- Created attachment 99052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99052&action=edit Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 22:59:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 21:59:48 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #29 from Katrin Fischer --- Currently blocked by dependency bug 23950. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:00:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:00:20 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Currently blocked by bug in FQA further up the dependency tree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:09:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:09:20 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #8 from Jon Knight --- Tried to test this on the Bywater Solutions sandboxes but despite it appearing to apply the patch I can't see any NLM output in the Normal view on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and adding a 060 field. This is even though can see LOC and DDC output (050 and 082) in the same output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:11:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:11:37 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1 on this. We've spent some time exploring the new interface and it's painfully slow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:11:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:11:56 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:11:59 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95400|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 99053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99053&action=edit Bug 23592: Link to the bibliographic record from the suggestion If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion detail page. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the detail page of the suggestion => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:13:35 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- A subtle but nice change :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 14 23:54:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 22:54:37 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 00:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 23:05:02 +0000 Subject: [Koha-bugs] [Bug 24672] New: Error on receiving orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Bug ID: 24672 Summary: Error on receiving orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When trying to receive orders after entering the invoice id this error is displayed: Can't call method "active_orders" on an undefined value at /home/vagrant/kohaclone/acqui/parcel.pl line 244 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 00:08:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 23:08:14 +0000 Subject: [Koha-bugs] [Bug 24672] Error on receiving orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 --- Comment #1 from Katrin Fischer --- Not sure if it's related, but I have a basket with 2 unreceived deleted records (it's not good, but can happen) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 00:10:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Feb 2020 23:10:35 +0000 Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error on receiving orders |Error on receiving orders | |when there is an order with | |a deleted record --- Comment #2 from Katrin Fischer --- It appears to be related - reopening the closed basket (taking the orders out of the list of orders to receive that way) makes the error go away. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 01:43:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 00:43:27 +0000 Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to select past date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.roberts at ptfs-europe.c | |om --- Comment #5 from David Roberts --- Tested in my dev environment, and works perfectly as per test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 02:34:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 01:34:08 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #9 from David Nind --- Patch no longer applies: Applying: Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl). error: could not build fake ancestor Patch failed at 0001 Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24322-National-Library-of-Medicine-NLM-call-nu-kgmgi2.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 02:57:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 01:57:25 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #10 from David Nind --- (In reply to Jon Knight from comment #8) > Tried to test this on the Bywater Solutions sandboxes but despite it > appearing to apply the patch I can't see any NLM output in the Normal view > on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and > adding a 060 field. This is even though can see LOC and DDC output (050 and > 082) in the same output. Hi Jon. That would be because the patch wasn't actually applied. The way to tell it hasn't applied in ByWater's sandboxes: 1) Go to Logs > Koha Git log. The commit for the patch(es) with the bug number you are testing should show at the top of the page, e.g. Bug 24322: National.... 2) Create a sandbox without putting a bug number in the 'Bug number' field. You will then get the current master branch for Koha. Then go to Actions > Apply patches. It will then show you what it has done and that the patch failed. Have to admit that it's not very obvious to identify that the patch didn't apply! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 03:58:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 02:58:33 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 03:58:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 02:58:37 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99023|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 99054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99054&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply the patch, update the database (perl installer/data/mysql/updatedatabase.pl) 2 - Note new system preference 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVarsIntranet and DumpTemplateVarsOpac system preferences 5 - Search on staff and opac 6 - View the page source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new system preference 9 - Repeat steps 5-7, but you should now find the 'search_query' 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search (/cgi-bin/koha/authorities/auth_finder.pl), adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 03:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 02:58:41 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99024|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 99055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99055&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 04:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 03:01:15 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Tested on Elastic Search and everything works as per the test plan. To enable Elastic Search on koha-testing-docker: 1) Start up with ku-es6 (instead of just ku) (see the note at bottom of koha-testing-docker README about 'Having Elasticsearch run') 2) Change the search engine from Zebra to Elasticsearch (SearchEngine system preference) 3) Reindex the content: go into the container using kshell then change to the koha directory and run ./misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Search in either the staff interface or OPAC to make sure you get results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 05:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 04:16:35 +0000 Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off --- Comment #2 from David Nind --- Tested using ByWaterSolutions sandboxes. Everything works as per the test plan. (Not sure if this the correct way to sign-off remote patches.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:33:42 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:38:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:38:26 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- In my testing, starting with an 'other' comment, then using cancel to get the pull down, will only offer 'other' and empty... not pulling the list of values the same action gives me on editing a suggestion in the acquisitions module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:39:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:39:22 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Limit Purchase Suggestion |Limit purchase suggestion |in a specified Time period |in a specified time period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:48:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:48:34 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- 1) The database update will limit the number of suggestions for existing installations: + $dbh->do( q{ + INSERT IGNORE INTO systempreferences (variable,value,explanation,type) VALUES + ('MaxTotalSuggestions','3','Number of total suggestions','free'), + ('NumberOfSuggestionDays','30','days','free') + }); This is against the "rules" as we always aim for having no change of behaviour on update. We should set them to empty (unlimited) 2) For the same reason I am wondering about the default settings in the YAML file, I don't think they are needed. 3) This patch set misses the change to sysprefs.sql for setting up new installations. While we could do the 3 and 30 there, I wonder if we should be a little less restrictive there as well? 4) Please (re)add descriptions of the changes and test plans to the commit messages. I've seen quite a lot of them showing here but not being part of the attached files. Make sure you write them up in your git commit step, not when using git bz attach, as the latter won't change the files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:51:15 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:51:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:51:18 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99001|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 99056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99056&action=edit Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 09:51:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 08:51:52 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Makes much more sense, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:01:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:01:59 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:02:02 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98737|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 99057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99057&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:02:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:02:06 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99000|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 99058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99058&action=edit Bug 18499: (follow-up) Add missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:02:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:02:10 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #10 from Katrin Fischer --- Created attachment 99059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99059&action=edit Bug 18499: (QA follow-up) Add missing colon after label description To match the line above, a colon (:) was added after the description: Callnumber classification scheme: [pull down] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:06:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:06:32 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:06:55 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:07:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:07:10 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 10:09:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 09:09:17 +0000 Subject: [Koha-bugs] [Bug 17954] Remove the sql code from the smart-rules.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I believe this is obsolete now with the move away from issuingrules to the new table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 11:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 10:32:33 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 11:32:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 10:32:37 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98509|0 |1 is obsolete| | --- Comment #59 from David Nind --- Created attachment 99060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99060&action=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Enable the new system preference: OpacBrowseSearch 3 - Rebuild the OPAC CSS (see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 4 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 5 - Test searching for author, title, and subject 6 - Verify that results are returned in expected order 7 - Experiment with fuzziness 8 - Click any result and verify specific titles are correct 9 - Click through title to record and verify it is the correct record Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 11:58:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 10:58:36 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 11:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 10:58:39 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98818|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 99061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99061&action=edit Bug 24650: Convert ISO datetimes to syspref dates This patch adds a function 'ISO_to_syspref' that accepts an ISO8601 / RFC3339 formatted timestamp, as returned from the API for datetime DB columns, and returns a string formatted according to the 'dateformat' syspref, optionally including the time Test plan: - Apply the patch - Load a page that uses calendar.inc, for example a patron's loan list in the staff interface - In the JS console, type the following and notice the printed date is in the format according to the syspref: var dt = new Date; console.log(ISO_to_syspref(dt.toISOString())); - In the JS console, type the following and notice the printed date is in the format according to the syspref, and includes the time: console.log(ISO_to_syspref(dt.toISOString(), true)); Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 23:39:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 22:39:18 +0000 Subject: [Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om CC| |david.roberts at ptfs-europe.c | |om --- Comment #2 from David Roberts --- This wasn't my patch, but will pick this up to try to resolve it as it is currently unassigned. Looks like most of the work has already been done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 23:44:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 22:44:44 +0000 Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out" should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 15 23:47:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Feb 2020 22:47:29 +0000 Subject: [Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 01:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 00:19:17 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 13:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 12:01:29 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #55 from Martin Renvoize --- OK, I've added the Meta dependencies as a cpan installed module for Jessie for master.. I don't believe we should go to the effort of backporting this dependency for Jessie given we will be deprecating support for that OS at the release of 20.05. However, this does make me believe this enhancement should certainly NOT be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 20:56:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 19:56:13 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 20:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 19:56:16 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98742|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 99062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99062&action=edit Bug 24640: Allow quotes.timestamp to be NULL It is broken with strict mode enable, timestamp is created without default value. Note that the .sql installer file init the value with NOW(), which is wrong. DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);" with ParamValues: 0="poeut", 1="pouet"] at /kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49. Test plan: Create a new quote of the day => Without this patch you will get an error Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 20:58:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 19:58:59 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Created attachment 99063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99063&action=edit Bug 24640: Screenshot of input field on Firefox Notes (using docker-testing-docker): - I don't see the error mentioned, but the quote is not added to the list - Seems like you couldn't add or edit a quote from at least 18.11.x - The styling is all wonky from at least 19.11.x on Firefox (very narrow height for the input boxes when adding or editing => Google Chrome or Chromium is okay)(see screenshot attachment) - happy to add a new bug for this Updated test plan: 1) Try and add a quote - when you press enter nothing happens and it is n0t added to the list of quotes 2) Apply the patch 3) Run the database update (updatedatabase on koha-testing-docker or perl installer/data/mysql/updatedatabase.pl) 4) Try and add a quote - it should now be added to the list 5) Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:04:45 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:04:48 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98771|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 99064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99064&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:07:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:07:50 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Aleisha Amohia --- I've misunderstood here - I thought that Katrin's comment was talking about the potential cause of the original bug reported, not in relation to reproducing Kelly's error. Also I'm more than happy to write tests. I had simply forgotten in the first instance. Will take another look when I get a chance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:11:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:11:01 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #9 from Hayley Mapley --- Yeah, I should have specified because of string change sorry! It's on my list for review for next minor point release :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:13:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:13:25 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #360 from Aleisha Amohia --- Hi Holly We have a few libraries that are using this recalls feature, plus many enhancements developed since. I will work on rebasing this throughout the year and catching master up to where our clients are at. Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:18:22 +0000 Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #10 from Katrin Fischer --- Thx Hayley! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 21:18:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 20:18:48 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #22 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #18) > I am not in favor of relying on JavaScript here - so I am proposing a > follow-up that uses checks on TT level instead. Could you have a look > Aleisha or David? Looks good Katrin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 23:19:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 22:19:04 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 16 23:19:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Feb 2020 22:19:51 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 02:24:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 01:24:04 +0000 Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #17 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 02:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 01:47:02 +0000 Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #6 from Aleisha Amohia --- (In reply to Owen Leonard from comment #5) > I get this warning from the QA tool: > > FAIL installer/data/mysql/kohastructure.sql > OK boolean_vs_tinyint > OK charset_collate > OK git manipulation > FAIL tinyint_has_boolean_flag > The new column export_format.opac_option is using TINYINT(1) > as type but is not defined as boolean in the schema file > (Koha/Schema/Result/ExportFormat.pm), see the SQL12 coding guideline Hi Owen, did you update the schema files? misc/devel/update_dbix_class_files.pl --db_name=koha_instance --db_user=koha_instance --db_passwd=thepassword -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 02:55:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 01:55:34 +0000 Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #13 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 03:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 02:15:33 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #52 from David Nind --- Patch no longer applies: ... Applying: Bug 17385: QA Critics Fixed and added Missing Filters error: sha1 information is lacking or useless (C4/XSLT.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17385: QA Critics Fixed and added Missing Filters ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 04:32:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 03:32:46 +0000 Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified email column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #8 from Hayley Mapley --- Dependency (script patron_emailer) not present in 18.11, so will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 04:46:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 03:46:48 +0000 Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 05:10:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 04:10:04 +0000 Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #15 from Hayley Mapley --- Dependency not in 18.11.x, not backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 07:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 06:12:03 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 07:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 06:12:07 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 --- Comment #6 from David Nind --- Created attachment 99065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99065&action=edit Bug 15377: Remove 'checked out' items from course reserves 1) removes the restriction of not allowing a reserve to be removed if it is onloan 2) adds a column to the display that says with the item is checked out or available based on the onloan flag Test plan: 1) Create a new course reserves list (Home > Course reserves) 2) Add some items to the course 3) Check out an item 4) Note that the Remove button on the course list page is greyed out for the item checked out 5) Apply the patch 6) Refresh the page 7) Note that the Remove button is no longer greyed out 8) Click the Remove button 9) A message pops up 'Are you sure you want to remove this item from the course?' - click OK 10) The item is no longer shown on the course list page Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 07:16:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 06:16:45 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #97369|0 |1 is obsolete| | --- Comment #7 from David Nind --- Comment on attachment 97369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97369 small patch to allow removal on course reserve items Not sure what happened here - have obsoleted the old patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 08:09:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 07:09:37 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 08:09:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 07:09:41 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98777|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 99067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99067&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Test plan: 1) Search for PDF::API2::Simple - git grep PDF::API2::Simple - there should be one result 2) Apply the patch 3) Search again 4) There should be no results 5) Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 08:34:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 07:34:42 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #12) > Signed-off-by: David Nind > Signed-off-by: Katrin Fischer Thx David and Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 08:35:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 07:35:14 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #8) > Signed-off-by: Holly > Signed-off-by: Katrin Fischer Thx Holly and Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 08:36:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 07:36:12 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #14 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #13) > Signed-off-by: Aleisha Amohia > Signed-off-by: Katrin Fischer Thx Aleisha and Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:17:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:17:31 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:17:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:17:42 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:23:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:23:15 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #18 from David Nind --- Patch no longer applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:26:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:26:48 +0000 Subject: [Koha-bugs] [Bug 16509] Koha::Logger dies when log4perl.conf has FileAppender files with different owners, also compatibility with logrotate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16509 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- The patch still applies, but how can I test this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:30:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:30:21 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 09:36:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 08:36:07 +0000 Subject: [Koha-bugs] [Bug 24601] Catalogue detail table last seen date not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24601 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Emmi Takkinen --- Sorry, my mistake. Tested again and sort works correctly. Closing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:14:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:14:19 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 --- Comment #5 from Jonathan Druart --- (In reply to Nick Clemens from comment #4) > I never get a successful message when vendor has no contact Ok, actually I get the problem when using reset_all: aqbooksellers.bookselleremail is set to an invalid email address. My assumption was incorrect, I thought it was because no contact was associated to the vendor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:22:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:22:28 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:22:32 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98270|0 |1 is obsolete| | Attachment #98271|0 |1 is obsolete| | Attachment #98278|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 99068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99068&action=edit Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:22:35 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #12 from Jonathan Druart --- Created attachment 99069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99069&action=edit Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:22:38 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #13 from Jonathan Druart --- Created attachment 99070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99070&action=edit Bug 24545: (follow-up) Fix license statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:37:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:37:25 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala at gmail.com |emmi.takkinen at outlook.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:42:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:42:14 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:48:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:48:47 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #190 from David Nind --- Had a go at testing but get an error when adding a rule (step 5 of the test plan): DBIx::Class::Row::delete(): Not in database at /kohadevbox/koha/Koha/Object.pm line 219 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm line 77 74: my $self = { msg => $msg }; 75: bless $self => $class; 76: 77: die $self; 78: } 79: 80: =head2 rethrow Show function arguments Can post the full error trace if required. Notes: The patch applied fine, I ran the database update, and enabled the new system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 10:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 09:58:58 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Patch no longer applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:06:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:06:47 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #11 from Jonathan Druart --- (In reply to Nick Clemens from comment #10) > The behaviour does still recur and can be fixed by this patch, however, I > can't make the selenium tests fail What are you using in the pref? Using what you used in the tests I am not able to recreate the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:09:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:09:45 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > I am not sure about this one: The difference between the URL in the record > and in the item is that I can define a link text for URLs in the record, but > I can't for items. We are now forcing this change on everyone. Say the > library has chosen "full text" on the UrlLinkText but that doesn't apply to > all item urls? Then we should use a new syspref? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:14:04 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #67 from David Nind --- What should the status of this be after Tomás's comment? (comment 66) Needs Signoff or Failed QA? I tried to apply the patch and got this - no sure whether this means it has applied cleanly or note: 94748 - Bug 17499: Add Koha-objects for messaging preferences Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17499: Add Koha-objects for messaging preferences Using index info to reconstruct a base tree... M Koha/Exceptions.pm M Koha/Patron.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Patron.pm Auto-merging Koha/Exceptions.pm Also, running the test resulted in the tests failing: prove t/db_dependent/Koha/Patron/Message/* t/db_dependent/Koha/Patron/Message/Attributes.t ............. 1/2 # Looks like you planned 6 tests but ran 4. # Failed test 'Test Koha::Patron::Message::Attributes' # at t/db_dependent/Koha/Patron/Message/Attributes.t line 72. Can't locate object method "_new_from_dbic" via package "Koha::MessageAttribute" (perhaps you forgot to load "Koha::MessageAttribute"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Attributes.t ............. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Preferences.t ............ 1/7 # Looks like you planned 3 tests but ran 2. # Failed test 'Test for a patron' # at t/db_dependent/Koha/Patron/Message/Preferences.t line 99. # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Test Koha::Patron::Message::Preferences' # at t/db_dependent/Koha/Patron/Message/Preferences.t line 125. Can't locate object method "_new_from_dbic" via package "Koha::BorrowerMessagePreference" (perhaps you forgot to load "Koha::BorrowerMessagePreference"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Preferences.t ............ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/7 subtests t/db_dependent/Koha/Patron/Message/Transport/Preferences.t .. 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transport::Preferences' # at t/db_dependent/Koha/Patron/Message/Transport/Preferences.t line 112. Can't locate object method "_new_from_dbic" via package "Koha::BorrowerMessageTransportPreference" (perhaps you forgot to load "Koha::BorrowerMessageTransportPreference"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transport/Preferences.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Transport/Types.t ........ 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transport::Types' # at t/db_dependent/Koha/Patron/Message/Transport/Types.t line 52. Can't locate object method "_new_from_dbic" via package "Koha::MessageTransportType" (perhaps you forgot to load "Koha::MessageTransportType"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transport/Types.t ........ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Transports.t ............. 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transports' # at t/db_dependent/Koha/Patron/Message/Transports.t line 70. Can't locate object method "_new_from_dbic" via package "Koha::MessageTransport" (perhaps you forgot to load "Koha::MessageTransport"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transports.t ............. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patron/Message/Attributes.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Preferences.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 Parse errors: Bad plan. You planned 7 tests but ran 2. t/db_dependent/Koha/Patron/Message/Transport/Preferences.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Transport/Types.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Transports.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 Files=5, Tests=10, 8 wallclock secs ( 0.04 usr 0.01 sys + 6.58 cusr 0.64 csys = 7.27 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:15:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:15:25 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #68 from David Nind --- Actually, I've answered my own question I think - I've run the tests and some failed, so back to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:19:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:19:06 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:19:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:19:09 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98934|0 |1 is obsolete| | Attachment #98935|0 |1 is obsolete| | Attachment #98936|0 |1 is obsolete| | Attachment #98937|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 99071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99071&action=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:20:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:20:19 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #11 from Jonathan Druart --- (In reply to Owen Leonard from comment #9) > (In reply to Jonathan Druart from comment #8) > > Test plan: > > * Confirm that the library's name is updated > > This didn't work in my test. The previous library name still showed up. Yes, sorry about that. I revived patches I had on a local branch, but they went to far and were wrong. Only the first patch is relevant here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:21:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:21:35 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:21:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:21:37 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97296|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 99072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99072&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:31:30 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #15 from Jonathan Druart --- (In reply to Martin Renvoize from comment #14) > I still see one final warning: > > Use of uninitialized value in concatenation (.) or string at > /kohadevbox/koha/C4/Search.pm line 1818. I don't have this one, how did you get it? kohadev-koha at b2404290bde5:/kohadevbox/koha$ prove t/db_dependent/Search.t t/db_dependent/Search.t .. ok All tests successful. Files=1, Tests=2, 12 wallclock secs ( 0.04 usr 0.01 sys + 7.26 cusr 1.60 csys = 8.91 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:36 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:39 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98760|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 99073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99073&action=edit Bug 24469: Record biblionumber in import_biblio when adding to basket via file The column import_biblios.matched_biblionumber was not populated when an order is created from a staged file. Test plan: A/ Create a new order from a stage file. Use the "Save" button at the bottom of the "Add orders from" page Then note the matched_biblionumber value. It should be populated correctly B/ Import again the same record, this time you will have to use the "Add order" link in the list of order (ie. not the "Save" button) Note the matched_biblionumber value. It should be populated correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:49 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:51 +0000 Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show correctly in MARC view (OPAC and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:53 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:55 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:57 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:45:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:45:59 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:01 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:03 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:05 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:06 +0000 Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:08 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:10 +0000 Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a
  • tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:46:12 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #4 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #2) > In my testing, matched_biblionumber remains null in test A using the Save > button. Test B using the Add order link successfully populated > matched_biblionumber. Indeed, can you try again with this new patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:04 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:08 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97804|0 |1 is obsolete| | Attachment #97805|0 |1 is obsolete| | Attachment #97806|0 |1 is obsolete| | Attachment #97807|0 |1 is obsolete| | Attachment #97808|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 99074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99074&action=edit Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC search results Added : Call number for all not for loan status XSLT Results template improvement : Use the NOT_LOAN authorised values Improvement : Use the NOT_LOAN authorised values when showing items status in the OPAC search results. Before this patch, these items were only considered as "unavailable". Note : This patch only affects the OPAC XSLT search results template for MARC21 records. This patch was not tested on UNIMARC or NORMARC records. I won't be able to support these formats, so I'm hoping someone could do the same for these other record formats. Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:13 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #47 from Jonathan Druart --- Created attachment 99075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99075&action=edit Bug 7611: Change negative notforloan as well This makes the changes apply to both positive and negative notforloan values The extra line generated before is removed Some spans are added and cleaned up and labels moved to CSS to allow for easier altering where needed Itemtypes marked notforloan remain as reference, the label can be changed via css To test: 1 - Have a record with items in various statuses, ideally - 3 available, with 2 in one branch, 1 in another - 3 with itemtype not for loan, 2 in one branch, 1 in another - 3 in a positive not for loan status, 2 and 1 as above - 3 in a negative not for loan status, 2 and 1 as above - 1 in a different positive loan status, but with the same opac description as the negative above 2 - Search the opac to include this record, take a screenshot 3 - Apply patch 4 - Restart all and refresh 5 - Compare to screen shot 6 - Differences include: - Positive statuses are now on separate line with opac description showing - Unavailable (not for loan items) now include callnumber and branch in display - Positive and negative notforloan with same description are combined where branches match - Inspect the elements, note new spans around 'Items available for loan/reference' 7 - Add to OPACUserCSS: .ItemSummary .ItemBranch{ display:none; } .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary .LabelCallNumber{ display:none; } 8 - Note the branches are hidden, and callnumbe rhidden for unavailable items Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:18 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #48 from Jonathan Druart --- Created attachment 99076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99076&action=edit Bug 7611: (follow-up) Add missing space Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:22 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #49 from Jonathan Druart --- Created attachment 99077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99077&action=edit Bug 7611: (follow-up) Fix display of undefined statuses and add a class Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 11:49:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 10:49:29 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #50 from Jonathan Druart --- Created attachment 99078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99078&action=edit Bug 7611: (follow-up) separate positive and negative statuses as in the past This patch preserves someting closer to previous functionality. Negative not for loan are in the 'unavailable' section in red, positive ones are in the 'reference' section in green. Itemtype level will also be in green in reference Item specific status will override an itemtype level. The line break between 'reference' and 'unavailable' existed before and is preserved - negative not for loan and checked out items appear here Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:00:34 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #36 from Jonathan Druart --- Can you put commit title and bug report title in sync please? I guess nobody will have time to provide tests to cover this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:00:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:00:36 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:00:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:00:38 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 --- Comment #1 from Joonas Kylmälä --- Created attachment 99079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99079&action=edit Bug 24669: Improve numeric input handling in smart-rules.pl This removes code duplication by introducing a new subroutine strip_non_numeric() that removes whitespace and makes the rule value '' if it is a string value instead of a digit. The call to strip_non_numeric() is now added also to all the rules it is needed in. To test: 1. Write some string like "test" to rules: - Current checkouts allowed - Current on-site checkouts allowed - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) - Holds per record (count) – can be found in default policy 2. Save rules 3. Apply patch 4. Edit the rule line where you just typed all those strings and save 5. Notice how the values are now empty strings (some say "unlimited" but if you go check from DB it should show empty value there) Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:00:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:00:41 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 --- Comment #2 from Joonas Kylmälä --- Created attachment 99080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99080&action=edit Bug 24669: Show "Unlimited" values correctly in smart-rules.pl The rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" were not set empty when in rule editing. Also, the text "Unlimited" was not shown for rule "Holds per record (count)" even though it should have been since empty value means unlimited holds per record. To test: 1. Apply patch 2. Edit the rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" to be empty and save 3. Make sure all of the above rules now say Unlimited 4. Edit the rules again and make sure the above rules are now in the rule editing empty. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:11:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:11:54 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #27 from Jonathan Druart --- (In reply to Katrin Fischer from comment #24) > Could we keep them from creeping back in with a new addition to the QA test > tools? I did not manage to end up with something that would not raise too many false positives. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:15:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:15:28 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #1) > +1 on this. We've spent some time exploring the new interface and it's > painfully slow. The new interface you are referring to is bug 15522. Not necessarily related to bug 18936. On bug 15522 the whole smart-rules.pl script is removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:44 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:47 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #51 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:51 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #100 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:54 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:56 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:31:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:31:58 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:00 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:02 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:04 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:06 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:08 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:10 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:12 +0000 Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the wrong tab and is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:13 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:32:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:32:16 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:46:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:46:00 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:46:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:46:03 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98178|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 99081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99081&action=edit Bug 24389: Better error handle when claiming late orders A successful message says that the email has been sent and the order has been claimed, but nothing happened. Test plan: 0. Do not apply this patch 1. Create a new vendor, does not create a contact 2. Create some orders, close the basket 3. Go to the late orders page and claims some orders => You get a successful message, but the claim has not been done! 4. Apply this patch 5. Claim the orders => You get an error 6. Set a contact for the vendor 7. Claim the orders => Success In the docker container, you may need to: % apt install postfix % postfix start Edit /etc/hosts 127.0.0.1 localhost localhost.localdomain Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:54:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:54:56 +0000 Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce the chance of re-processing very old, already capped, fines. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:55:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:55:58 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:56:01 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #3 from Jonathan Druart --- Created attachment 99082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99082&action=edit Bug 24670: Fetch all circulation rules at once to fix perf regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:57:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:57:04 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #4 from Jonathan Druart --- I do not have much circulation rules defined in my dev install, so it's a bit hard to notice the difference. Could you test this patch and tell me if it improves the performance? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 12:57:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 11:57:16 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 13:22:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 12:22:27 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #21 from Katrin Fischer --- I think I'd have preferred it as it also allows to keep the current behaviour (least surprise/no change on update) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 13:24:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 12:24:52 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 --- Comment #28 from Katrin Fischer --- (In reply to Jonathan Druart from comment #27) > (In reply to Katrin Fischer from comment #24) > > Could we keep them from creeping back in with a new addition to the QA test > > tools? > > I did not manage to end up with something that would not raise too many > false positives. Thx for checking Jonathan. Wonder if this is important enough for a note in the coding guidelines? Our case with a 100 libraries using $ in their barcode might be a bit specific... but I also think the new form of writing this is nicer and more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 13:31:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 12:31:17 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #33 from Andrew Isherwood --- Created attachment 99083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99083&action=edit Bug 23173: (follow-up) Allow for customisable display name We now allow for the service to return a name that can be specified in the plugin config. This patch switches to using that, rather than just the plugin name defined in the plugin's metadata hashref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:19:29 +0000 Subject: [Koha-bugs] [Bug 24674] New: Uncertain years for publicationyear/copyrightdate -- corrected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Bug ID: 24674 Summary: Uncertain years for publicationyear/copyrightdate -- corrected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: januszop at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl According to n. 4.3.8 od ISBD Consolidated Edition of 2011, valid for date description are also string like [1960-], [17-]. Currently strings like these are not interpreted correctly by C4::Biblio::_adjust_pubyear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:23:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:23:35 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek --- Created attachment 99088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99088&action=edit Bug 24674: Uncertain years for publicationyear/copyrightdate -- corrected This is a correction to Bug 11046: YYY- is also correct according to ISBD: uncertain year, but certain decade (cf. n. 4.3.8 in ISBD Consolidated Edition of 2011). (Question mark is not mandatory.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:43:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:43:06 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:43:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:43:09 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 --- Comment #2 from Jonathan Druart --- Created attachment 99089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99089&action=edit Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:43:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:43:28 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:45:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:45:56 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:45:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:45:58 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:46:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:46:02 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:40 +0000 Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:42 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:44 +0000 Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid successful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:46 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:47 +0000 Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:49 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:48:51 +0000 Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:57:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:57:54 +0000 Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |24430 --- Comment #3 from Jonathan Druart --- Caused by commit f31993d126ed97fdc80605931f41ed29b1dac5d1 Bug 24430: Remove CountBiblioInOrders and its traces Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 [Bug 24430] Remove C4::Biblio::CountBiblioInOrders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 14:57:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 13:57:54 +0000 Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 [Bug 24672] Error on receiving orders when there is an order with a deleted record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:01:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:01:00 +0000 Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:01:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:01:03 +0000 Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 --- Comment #4 from Jonathan Druart --- Created attachment 99090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99090&action=edit Bug 24672: (bug 24430 follow-up) Do not get active orders on deleted biblio record On bug 24430 we replaced the call to CountBiblioInOrders with Koha::Biblio->active_orders In case the bibliographic record is deleted, the count must be set to 0. This prevent the app to crash with: Can't call method "active_orders" on an undefined value at /home/vagrant/kohaclone/acqui/parcel.pl line 244 Test plan: Create 2+ orders Receive one, delete it, delete the bibliographic record Receive the order one => Without this patch, on the parcel page you should get the error => With this patch applied you must be allowed to finish the receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:07:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:07:20 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #18 from Marcel de Rooy --- Created attachment 99091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99091&action=edit Bug 24530: (QA follow-up) Add missing filter Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 The variable is just filled in the template but lets make Jenkins happy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:01 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94436|0 |1 is obsolete| | --- Comment #173 from Alex Arnaud --- Created attachment 99092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99092&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:10 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94437|0 |1 is obsolete| | --- Comment #174 from Alex Arnaud --- Created attachment 99093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99093&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:17 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94438|0 |1 is obsolete| | --- Comment #175 from Alex Arnaud --- Created attachment 99094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99094&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:25 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94439|0 |1 is obsolete| | --- Comment #176 from Alex Arnaud --- Created attachment 99095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99095&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:31 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94440|0 |1 is obsolete| | --- Comment #177 from Alex Arnaud --- Created attachment 99096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99096&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:39 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94441|0 |1 is obsolete| | --- Comment #178 from Alex Arnaud --- Created attachment 99097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99097&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:46 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94442|0 |1 is obsolete| | --- Comment #179 from Alex Arnaud --- Created attachment 99098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99098&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:21:53 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94443|0 |1 is obsolete| | --- Comment #180 from Alex Arnaud --- Created attachment 99099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99099&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori Rebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:00 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94444|0 |1 is obsolete| | --- Comment #181 from Alex Arnaud --- Created attachment 99100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99100&action=edit Bug 18823: Fix targets registering Signed-off-by: cori ebased-on: 2019-03-20 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:08 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94445|0 |1 is obsolete| | --- Comment #182 from Alex Arnaud --- Created attachment 99101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99101&action=edit Bug 18823: Add pod for UpdateMarcTimestamp and template filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:15 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94446|0 |1 is obsolete| | --- Comment #183 from Alex Arnaud --- Created attachment 99102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99102&action=edit Bug 18823: add unit tests for added/changed subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:22 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94447|0 |1 is obsolete| | --- Comment #184 from Alex Arnaud --- Created attachment 99103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99103&action=edit Bug 18823: C4::Koha::GetNormalizedISBN loading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:30 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94448|0 |1 is obsolete| | --- Comment #185 from Alex Arnaud --- Created attachment 99104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99104&action=edit Bug 18823: center sucess saving message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:37 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94449|0 |1 is obsolete| | --- Comment #186 from Alex Arnaud --- Created attachment 99105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99105&action=edit Bug 18823: reduce batches management modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:46 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94450|0 |1 is obsolete| | --- Comment #187 from Alex Arnaud --- Created attachment 99106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99106&action=edit Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:22:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:22:53 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94451|0 |1 is obsolete| | --- Comment #188 from Alex Arnaud --- Created attachment 99107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99107&action=edit Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:23:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:23:01 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94452|0 |1 is obsolete| | --- Comment #189 from Alex Arnaud --- Created attachment 99108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99108&action=edit Bug 18823: typo on loggelogged_in_user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:23:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:23:07 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #190 from Alex Arnaud --- Created attachment 99109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99109&action=edit Bug 18823: combine Duplicate and New Catalog Record save targets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:24:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:24:50 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #191 from Alex Arnaud --- All patches are rebased. Added a new patch to combine "Duplicate" and "New Catalog Record" save targets? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:28:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:28:56 +0000 Subject: [Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I have tracked this down a bit. The problem is that MoveReserve (called by AddIssue) calls CheckReserves: 1863 my ( $restype, $res, undef ) = CheckReserves( $itemnumber, undef, $lookahead ); 1864 return unless $res; Here $res is not defined because of: 792 # if item is not for loan it cannot be reserved either..... 793 # except where items.notforloan < 0 : This indicates the item is holdable. 794 return if ( $notforloan_per_item > 0 ) or $notforloan_per_itemtype; I have no idea how to fix this and making sure I am not introducing a regression somewhere else. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:37:28 +0000 Subject: [Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 --- Comment #2 from Jonathan Druart --- Created attachment 99110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99110&action=edit Bug 24644: Just a try That does not work, t/db_dependent/Reserves.t is failing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:38:30 +0000 Subject: [Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Created attachment 99110 [details] [review] > Bug 24644: Just a try > > That does not work, t/db_dependent/Reserves.t is failing This patch does fix the reported issue however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:52:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:52:52 +0000 Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize --- Followup pushed, thanks Marcel.. you beat me to it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 15:59:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 14:59:56 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #16 from Martin Renvoize --- Interesting.. I got it by just running that one test in koha-testing-docker on stretch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 16:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 15:17:45 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Depends on| |2720 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.05 |master --- Comment #1 from Jonathan Druart --- Confirmed on master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 [Bug 2720] Overdues which debar automatically should undebar automatically when returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 16:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 15:17:45 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 16:31:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 15:31:16 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #2 from Jonathan Druart --- Created attachment 99111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99111&action=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. This patch fixes the original issue report by bug 24413, but is submitted for discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 16:31:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 15:31:36 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 16:59:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 15:59:45 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #17 from Jonathan Druart --- Created attachment 99113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99113&action=edit Bug 24367: May fix another warning May fix the following warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Search.pm line 1818. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:00:47 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > Created attachment 99113 [details] [review] > Bug 24367: May fix another warning > > May fix the following warning: > Use of uninitialized value in concatenation (.) or string at > /kohadevbox/koha/C4/Search.pm line 1818. Martin, this patch may fix the warning you got. But I am not sure we push it if you are the only one to have it. We should confirm with someone else. I tried with ES and Zebra, and both passed without warning without this patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:05:12 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:05:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:05:16 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95401|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 99114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99114&action=edit Bug 23593: Link to the bibliographic record from the suggestion (OPAC) If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion list at the OPAC. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the suggestion list at the OPAC => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:07:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:07:44 +0000 Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Aha.. it's because their arrays as opposed to singles.. thanks. I'll take a look later today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:15:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:15:58 +0000 Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word order in Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:16:01 +0000 Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word order in Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97059|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 99115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99115&action=edit Bug 23488: Line wrapping doesn't always respect word order in Patron card creator When wrapping long lines of text, the line is divided by removing each word from the end of the line and putting it in a new one until the line is the right width. When the word to be removed appears multiple time in the line, it is not the last occurrence that is removed. This patch changes the regular expression used to remove the part of the text that is wrapped to a new line, making sure it removes it at the end of the text. Test plan: 1. Go to Tools > Patron card creator 2. Have a card template and a card batch -> If needs be, you can create them by using New > Card template or New > Card batch 3. Create a layout and use one text field containing a long text with at least one word which is repeated a minimum of 2 times (preferably towrdds the end of the text, since it has to be picked as one of the words to appear in the new line). You can use this: one two three one two three one two three one two three one two three one two three one two three one two three ... 4. Go to Manage > Card batches and export a batch 5. Choose the layout set up in 3. 6. Click the Export button and open the resulting pdf file 7. Notice all the repeated word have been grouped -> For this example : all of the ones appear first, followed by all the twos and only then the threes. 8. Apply patch 9. Repeat step 4 through 7 => this time the order of the words has not changed! Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. Tested adding addrees to test layout, and using the proposed text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:21:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:21:48 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:21:53 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 --- Comment #9 from Jonathan Druart --- Created attachment 99116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99116&action=edit Bug 23596: (follow-up) Add missing use statement and set correct variable name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:27:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:27:50 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 17:27:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 16:27:53 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98690|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 99117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99117&action=edit Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel No errors. Variable budget_lock is not set in acqui/lateorders.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:01:56 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b on OPAC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Trailing double-quote in |Trailing double-quote in |rda 264 subfield b on opac |RDA 264 subfield b on OPAC |xslt |XSLT CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:20:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:20:01 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #19 from Jonathan Druart --- Created attachment 99118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99118&action=edit Bug 24002: (follow-up) Incorrect DATE value: '00-00-0000' in C4/Serials.pm Oops, wrong copy/paste here! The column order changes was not expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:26:23 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #19) > Created attachment 99118 [details] [review] > Bug 24002: (follow-up) Incorrect DATE value: '00-00-0000' in C4/Serials.pm > > Oops, wrong copy/paste here! The column order changes was not expected. Sorry, it's part of 19.11, I will open a new bug report tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:31:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:31:24 +0000 Subject: [Koha-bugs] [Bug 24675] New: No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Bug ID: 24675 Summary: No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bouzid.fergani at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:31:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:31:36 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bouzid.fergani at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:52:57 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b on OPAC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:53:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:53:00 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b on OPAC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98969|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 99119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99119&action=edit Bug 24654: Remove trailing quote in rda264 XSLT To test: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search 6 - Apply patch 7 - Refresh 8 - Link is correctly formed now Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:56:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:56:48 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 18:56:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 17:56:51 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99062|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 99120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99120&action=edit Bug 24640: Allow quotes.timestamp to be NULL It is broken with strict mode enable, timestamp is created without default value. Note that the .sql installer file init the value with NOW(), which is wrong. DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);" with ParamValues: 0="poeut", 1="pouet"] at /kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49. Test plan: Create a new quote of the day => Without this patch you will get an error Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 19:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 18:33:55 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 19:33:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 18:33:58 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99072|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 99121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99121&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 19:58:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 18:58:42 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 19:58:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 18:58:44 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 --- Comment #1 from Bouzid Fergani --- Created attachment 99122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99122&action=edit Bug24675: Update MARC21 config for bib_heading_fields To reproduce: - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink - Edit or open any biblio record - fill all subfields of the field 100 In my case , I have $a, $d, $e, $q - Save and continue editing - Check the $9 of the field 100 filled for the authid(auto create of authority) - Open the detail of the new authority created using authid ($9) - In the new authority, $e is not filled This problem produce, because in C4/Heading/MARC21.pm, the list of subfields for each field is not upated since 2011. The source of new list of subfields is : library of congress (https://www.loc.gov/marc/bibliographic) When applying the patch, all subfields is reported correctly in the new authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:01:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:01:24 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95380|0 |1 is obsolete| | --- Comment #36 from David Nind --- Created attachment 99123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99123&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' (Home > Search > Item search) 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:01:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:01:27 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97479|0 |1 is obsolete| | --- Comment #37 from David Nind --- Created attachment 99124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99124&action=edit Bug 18433: Remember item search results selected rows in session storage Session storage is not shared between browser tabs, and is cleared when a tab is closed, so it seems like a good fit for storing selected rows Test plan: 1. Go to item search (intranet) and submit the form 2. Select some rows on the first page by clicking on checkboxes 3. Go to another page of results 4. Select more rows 5. Go back to the first page 6. Selected rows should still be checked 7. Play with sorting and filtering, and see that selected rows are always checked 8. Export as CSV and as a barcodes file, verify that the export contains all selected rows 9. Click on 'Clear selection', it should deselect all rows from all pages 10. Select some rows again 11. Click on 'Edit search' and submit the same search 12. No row should be selected 13. Select some rows again 14. Refresh the page and submit again the same search 15. No row should be selected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:06:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:06:11 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99122|0 |1 is obsolete| | --- Comment #2 from Bouzid Fergani --- Created attachment 99125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99125&action=edit Bug24675: Update MARC21 config for bib_heading_fields To reproduce: - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink - Edit or open any biblio record - fill all subfields of the field 100 In my case , I have $a, $d, $e, $q - Save and continue editing - Check the $9 of the field 100 filled for the authid(auto create of authority) - Open the detail of the new authority created using authid ($9) - In the new authority, $e is not filled This problem produce, because in C4/Heading/MARC21.pm, the list of subfields for each field is not upated since 2011. The source of new list of subfields is : library of congress (https://www.loc.gov/marc/bibliographic) When applying the patch, all subfields is reported correctly in the new authority. NB: All the subfields not written in the file C4/Heading/MARC21.pm have the same problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:06:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:06:18 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off --- Comment #38 from David Nind --- Note for others: - This is on the 'Item search' page rather than the normal 'Search the catalog' - Go to Staff interface homepage > Search dropdown list in the header > Item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:37:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:37:34 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #3 from Katrin Fischer --- Owen, I added your sign-off line manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:38:16 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:38:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:38:19 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99025|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 99126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99126&action=edit Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:59:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:59:24 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:59:28 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #5 from Katrin Fischer --- Created attachment 99127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99127&action=edit Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 20:59:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 19:59:55 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:00:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:00:27 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #6 from Katrin Fischer --- Hi David, just a tiny thing - the subject line of the patch always needs to start with XXXX: - fixed it during my QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:06:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:06:09 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:06:12 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99067|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 99128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99128&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:08:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:08:35 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:08:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:08:39 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98991|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 99129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99129&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:09:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:09:50 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 --- Comment #3 from Bouzid Fergani --- Created attachment 99130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99130&action=edit Bug 24675: Update MARC21 config for bib_heading_fields To reproduce: - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink - Edit or open any biblio record - fill all subfields of the field 100 In my case , I have $a, $d, $e, $q - Save and continue editing - Check the $9 of the field 100 filled for the authid(auto create of authority) - Open the detail of the new authority created using authid ($9) - In the new authority, $e is not filled This problem produce, because in C4/Heading/MARC21.pm, the list of subfields for each field is not upated since 2011. The source of new list of subfields is : library of congress (https://www.loc.gov/marc/bibliographic) When applying the patch, all subfields is reported correctly in the new authority. NB: All the subfields not written in the file C4/Heading/MARC21.pm have the same problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:10:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:10:14 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:20:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:20:49 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:20:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:20:53 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99117|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 99131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99131&action=edit Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel No errors. Variable budget_lock is not set in acqui/lateorders.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:28:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:28:45 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #9 from Hayley Mapley --- Dependency not in 18.11.x series, not backporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:29:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:29:51 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #13 from Hayley Mapley --- Enhancement will not be backported to 18.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 21:30:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 20:30:32 +0000 Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #7 from Hayley Mapley --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:08:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:08:00 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 --- Comment #9 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:19:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:19:23 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:19:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:19:27 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98886|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 99132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99132&action=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:24:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:24:27 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:24:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:24:32 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98642|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 99133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99133&action=edit Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:25:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:25:22 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Andrew, please don't forget to fill out the Assignee when you start working on a bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:27:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:27:46 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Nick, it looks like this patch needs a clean-up (check the diff, you will see) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:31:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:31:23 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 --- Comment #5 from Katrin Fischer --- Nick, you know better... commit message including only of a subject is a little spare ;) I'll fix it up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:35:44 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:35:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:35:48 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 --- Comment #6 from Katrin Fischer --- Created attachment 99134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99134&action=edit Bug 24514: Add option to exclude title from patron-title.inc and use it on 'holds awaiting pickup' Without this patch sorting by patron name on the 'holds awaiting pickup' report sorted by title, surname, firstname. With this patch the list will sort by surname, firstname, ignoring the title. To test: - generate and capture a hold for a patron named "Mr. A A" - generate and capture a hold for a patron named "A A" - generste and capture a hold for patron named "Mr. B B" - generste and capture a hold for patron named "B B" - go to holds awaiting pickup - sort by patron name ascending - holds sort Mr. A, Mr. B, A, B - sort by patron name descending - holds sort B, A, Mr. B, Mr. A - APPLY PATCH - Reload holds awaiting pickup - Confirm holds sort on Surname Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:40:44 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #19 from Martin Renvoize --- Lets push without that final patch.. hopefully it was just a blip on my system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:46:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:46:54 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:46:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:46:58 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98962|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 99135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99135&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting complicate to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:48:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:48:07 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|BakerTaylor images broken |BakerTaylor images broken |on opac lists |on OPAC lists CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:52:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:52:47 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #4 from Katrin Fischer --- Comment on attachment 95661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95661 Bug 23482: Fix BakerTaylor cover images on lists Review of attachment 95661: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23482&attachment=95661) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ +360,5 @@ > + No cover image available > + [% END %] > + [% END %] > + > + [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] Not sure why you start a new IF block here - conditions and variables appear to be the same as on the check right before it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:52:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:52:56 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:54:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:54:24 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |rogan.hamby at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:55:13 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:59:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:59:16 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 22:59:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 21:59:19 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99114|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 99136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99136&action=edit Bug 23593: Link to the bibliographic record from the suggestion (OPAC) If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion list at the OPAC. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the suggestion list at the OPAC => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:00:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:00:08 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 --- Comment #6 from Katrin Fischer --- Lovely little addition! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:07:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:07:47 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #48 from Hayley Mapley --- Hi, Are any of the obsoleted patches here supposed to be not obsoleted? I see this Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:10:36 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- I'd like it if this was not tied to the other preferences. It makes it hard to work with and not sure if we couldn't just have added to the output without needing a new pref? But working and helpful - passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:11:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:11:18 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:11:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:11:22 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99054|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 99137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99137&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:11:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:11:26 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99055|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 99138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99138&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:14:45 +0000 Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Owen, tried with the downloadable patch, but it does no longer apply. Can you please rebase and add David's sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:24:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:24:56 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:24:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:24:56 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:29:36 +0000 Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 --- Comment #32 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:40:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:40:52 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:40:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:40:56 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98893|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 99139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99139&action=edit Bug 24363: Move the datepicker icon out of the input Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:45:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:45:23 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #49 from Katrin Fischer --- Hi Hayley, I think this has a remote branch to be used instead of attached patches: https://gitlab.com/joubu/Koha/commits/bug_15522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 17 23:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 22:46:56 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #50 from Hayley Mapley --- Ahh, that makes sense. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 00:12:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Feb 2020 23:12:41 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #37 from David Cook --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? > > I guess nobody will have time to provide tests to cover this change? Well when you put it that way... hehe. I'll put it on my TODO list for tonight. I have a few patches I want to do tonight, so I'll try to get them all done at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 01:06:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 00:06:22 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #22 from Bernardo Gonzalez Kriegel --- Question: Why 'inscripts' instead of 'incipits'? I'm referring to the name of the preference and the displayed text. Came to this doing translation. Incipits makes sense, inscripts not so much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 01:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 00:50:31 +0000 Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z --- Comment #14 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 01:54:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 00:54:53 +0000 Subject: [Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #37 from David Cook --- Comment on attachment 81125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81125 Bug 21311: (follow-up) Adjust wording of failed login message Review of attachment 81125: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21311&attachment=81125) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +168,4 @@ > > > > +

    I think this must've been a typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 01:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 00:56:52 +0000 Subject: [Koha-bugs] [Bug 24676] New: opac-auth.tt contains trivial HTML error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Bug ID: 24676 Summary: opac-auth.tt contains trivial HTML error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 appears to have introduced a trivial little HTML error. Chrome seems to cope with it fine but probably better out than in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:01:36 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:01:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:01:39 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 --- Comment #1 from David Cook --- Created attachment 99140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99140&action=edit Bug 24676: Remove

    typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no

    block between and
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:02:02 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:11:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:11:58 +0000 Subject: [Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 --- Comment #29 from Aleisha Amohia --- Hey Alex, when you continue work on this, just a reminder to add changes to installer/data/mysql/sysprefs.sql and installer/data/mysql/userpermissions.sql ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:30:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:30:31 +0000 Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:42:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:42:57 +0000 Subject: [Koha-bugs] [Bug 23330] deleteditemsstocknumberidx should not be a unique index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23330 --- Comment #2 from David Cook --- We could probably close this one off as it only affects pre-3.04 versions of Koha. I think there are other cases where similar things have happened, so I'm sure upgraded databases vs new databases are already out of sync in other ways... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 02:44:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 01:44:33 +0000 Subject: [Koha-bugs] [Bug 21847] OAI-PMH server should enforce correct syntax for identifiers (including OAI-PMH:archiveID) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21847 --- Comment #1 from David Cook --- It would be good to actually have a subsystem of "global system preference" validation rules... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 03:11:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 02:11:43 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 03:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 02:35:16 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using QueryAutoTruncate |Search truncation disables |breaks relevance ranking |relevance ranking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 03:36:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 02:36:43 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search truncation disables |Search truncation disables |relevance ranking |relevance ranking when not | |using QueryParser --- Comment #38 from David Cook --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? > Actually, I'm not 100% sure what you mean by this, but I'm going to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 03:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 02:38:28 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98619|0 |1 is obsolete| | --- Comment #39 from David Cook --- Created attachment 99141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99141&action=edit Bug 12430: Force relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 03:39:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 02:39:27 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #40 from David Cook --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? Ok hopefully this is more in line with what you were thinking. > I guess nobody will have time to provide tests to cover this change? I'm going to try to do this now in the next 20 minutes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 04:03:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 03:03:18 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #41 from David Cook --- Created attachment 99142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99142&action=edit First Draft buildQuery unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 04:06:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 03:06:45 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #42 from David Cook --- (In reply to David Cook from comment #41) > Created attachment 99142 [details] [review] > First Draft buildQuery unit test This isn't complete yet, but it's a first pass before I have to run out of the office for a few hours. I need to add more permutations to the tests: 1. like a query with no * or QueryAutoTruncate to see if QueryWeightFields still works 2. like a more complex CCL/CCLish query 3. Turn on UseQueryParser (even if I think we should soon remove QueryParser from Koha) 4. Add limits to the unit tests Note that buildQuery spits out a lot of warnings, but I don't think they're relevant for this test. Rather, I think they're just indicative that buildQuery isn't very well written. Of course, these unit tests could be the basis for improving it. Thanks, Jonathan, for poking me on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 05:28:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 04:28:18 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z --- Comment #15 from Hayley Mapley --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 08:18:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 07:18:24 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #43 from David Cook --- Whoa... added unit tests when UseQueryParser is enabled and it's giving unpredictable results. Half the time, the expected result is correct and half the time it is wrong. It looks like it's swapping the order of the operands around. Bizarre. # got: '@or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=34 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=20 @attr 5=1 @attr 4=6 "test"' # expected: '@or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=20 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=34 @attr 5=1 @attr 4=6 "test"' I don't know what to do about that... it'll unpredictably bust the tests on master, but it is arguably a problem with the QueryParser or at least a problem of evaluating the query based on string matching instead of parsing the query and analyzing it logically... I think I'll leave out that test for now... especiallys ince we are planning to remove the QueryParser... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:08:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:08:07 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97843|0 |1 is obsolete| | --- Comment #164 from Ere Maijala --- Created attachment 99143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99143&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:08:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:08:13 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97844|0 |1 is obsolete| | --- Comment #165 from Ere Maijala --- Created attachment 99144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99144&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:08:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:08:18 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97845|0 |1 is obsolete| | --- Comment #166 from Ere Maijala --- Created attachment 99145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99145&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:08:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:08:23 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97846|0 |1 is obsolete| | --- Comment #167 from Ere Maijala --- Created attachment 99146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99146&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:08:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:08:55 +0000 Subject: [Koha-bugs] [Bug 24677] New: wrong year picked in serials Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Bug ID: 24677 Summary: wrong year picked in serials Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com >From bug 24002: commit 3d3336ed6607d80b72502075ebf9567cf48e1709 Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm The changes from this patch are like: - year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, + year(IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate)) as year, This is stilly, if publisheddate is null we do not want to return it. It comes from a wrong copy/paste from the other commits: - ORDER BY IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC"; + ORDER BY IF(publisheddate IS NULL,planneddate,publisheddate) DESC"; ="00-00-0000" vs <>"0000-00-00" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:10:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:10:50 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #168 from Ere Maijala --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:11:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:11:15 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:11:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:11:18 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 --- Comment #1 from Jonathan Druart --- Created attachment 99147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99147&action=edit Bug 24677: (bug 24002 follow-up) Incorrect DATE value: '00-00-0000' in C4/Serials.pm Oops, wrong copy/paste here! The column order changes was not expected. >From bug 24002: commit 3d3336ed6607d80b72502075ebf9567cf48e1709 Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm The changes from this patch are like: - year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, + year(IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate)) as year, This is stilly, if publisheddate is null we do not want to return it. It comes from a wrong copy/paste from the other commits: - ORDER BY IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC"; + ORDER BY IF(publisheddate IS NULL,planneddate,publisheddate) DESC"; ="00-00-0000" vs <>"0000-00-00" Test plan: Eyeball the previous patches from bug 24002 and notice that the changes in the commit listed previously are wrong -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:11:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:11:47 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24677 --- Comment #21 from Jonathan Druart --- Follow-up patch moved to bug 24677. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 [Bug 24677] wrong year picked in serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:11:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:11:47 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 [Bug 24002] Test suite is failing on MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:12:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:12:01 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:20:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:20:43 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #51 from Jonathan Druart --- Created attachment 99148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99148&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:20:48 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #52 from Jonathan Druart --- Created attachment 99149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99149&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:20:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:20:53 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #53 from Jonathan Druart --- Created attachment 99150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99150&action=edit Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:20:58 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #54 from Jonathan Druart --- Created attachment 99151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99151&action=edit Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:03 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #55 from Jonathan Druart --- Created attachment 99152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99152&action=edit Bug 15522: Add yarn.lock (autogenerated) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:08 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #56 from Jonathan Druart --- Created attachment 99153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99153&action=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:13 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #57 from Jonathan Druart --- Created attachment 99154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99154&action=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:17 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #58 from Jonathan Druart --- Created attachment 99155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99155&action=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:22 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #59 from Jonathan Druart --- Created attachment 99156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99156&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:21:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:21:27 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #60 from Jonathan Druart --- Created attachment 99157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99157&action=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:22:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:22:07 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #61 from Jonathan Druart --- Patches are now attached here! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:34:35 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:34:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:34:38 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99142|0 |1 is obsolete| | --- Comment #44 from David Cook --- Created attachment 99158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99158&action=edit Unit tests for buildQuery This patch adds unit tets for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:42:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:42:36 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #45 from David Cook --- Probably spent too long on the unit tests, but they should be useful. They test got vs expected values, plus they also do a CCL2RPN test to make sure it's actually valid CCL. I think the tests could probably be much more extensive, but they're a good base and they will hopefully be useful showcasing this change. Although as I say that it looks like the patch isn't actually working... so I'm going to investigate that now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:49:18 +0000 Subject: [Koha-bugs] [Bug 24354] Add public API for library information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24354 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:53:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:53:33 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #46 from Katrin Fischer --- Did you change the first patch too or only added the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:55:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:55:21 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking when not using QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #47 from David Cook --- (In reply to Katrin Fischer from comment #46) > Did you change the first patch too or only added the tests? I changed the title on the first patch but no code changes. The only code changes are on the second patch. -- And false alarm about the first patch not working now. It just turns out my search query "test" returned 3 records that had equal relevance. I updated biblio 134 and added "Test" to the title and now it's appearing at the top of the search results. Hurray! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:12 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:16 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99123|0 |1 is obsolete| | Attachment #99124|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 99159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99159&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:20 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #40 from Jonathan Druart --- Created attachment 99160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99160&action=edit Bug 18433: Remember item search results selected rows in session storage Session storage is not shared between browser tabs, and is cleared when a tab is closed, so it seems like a good fit for storing selected rows Test plan: 1. Go to item search (intranet) and submit the form 2. Select some rows on the first page by clicking on checkboxes 3. Go to another page of results 4. Select more rows 5. Go back to the first page 6. Selected rows should still be checked 7. Play with sorting and filtering, and see that selected rows are always checked 8. Export as CSV and as a barcodes file, verify that the export contains all selected rows 9. Click on 'Clear selection', it should deselect all rows from all pages 10. Select some rows again 11. Click on 'Edit search' and submit the same search 12. No row should be selected 13. Select some rows again 14. Refresh the page and submit again the same search 15. No row should be selected Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:23 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #41 from Jonathan Druart --- Created attachment 99161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99161&action=edit Bug 18433: Add missing filter Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:27 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #42 from Jonathan Druart --- Created attachment 99162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99162&action=edit Bug 18433: Display the number of selected items Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 09:58:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 08:58:57 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #43 from Jonathan Druart --- (In reply to Julian Maurice from comment #35) > (In reply to Jonathan Druart from comment #33) > > This is still valid. > > Not anymore ;) Awesome Julian, thanks for that follow-up! (In reply to Jonathan Druart from comment #42) > Created attachment 99162 [details] [review] > Bug 18433: Display the number of selected items > > Signed-off-by: Jonathan Druart Do you agree with that patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 10:04:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 09:04:29 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #44 from Julian Maurice --- (In reply to Jonathan Druart from comment #43) > Do you agree with that patch? Yep. I haven't tested it, but patch looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 10:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 09:17:04 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #10 from Jonathan Druart --- Typo: + var tz = (opitons&&options.tz)||def_tz; How is this related to bug 24650? It seems that it achieves the same goal without extra lib and very few lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 10:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 09:26:50 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #45 from David Cook --- (In reply to Martin Renvoize from comment #44) > Thanks David, that's great news. Finally getting around to this... Have to leave for the night but the following isn't working for some reason: t::lib::Mocks::mock_preference('koha_trusted_proxies', '1.1.1.1'); Will have to look at this more tomorrow... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 10:38:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 09:38:14 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #52 from Jonathan Druart --- Created attachment 99163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99163&action=edit Bug 7611: Adjust tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 10:52:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 09:52:06 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:02:02 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98722|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 99164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99164&action=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 Can be fixed by add this one line into /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:04:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:04:03 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #35 from Jonathan Druart --- Hello Rinrada, I have attached a file that has the correct format (patch). However I am not sure this is the correct way to fix the issue. Chris, can we get your opinion on it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:33:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:33:04 +0000 Subject: [Koha-bugs] [Bug 24678] New: Add missing search fields to Elasticsearch mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 Bug ID: 24678 Summary: Add missing search fields to Elasticsearch mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi The Elasticsearch mappings.yaml file is still missing a lot of search fields compared to Zebra. For example Zebra has 264a and 264c separately indexed but Elasticsearch only has 264 indexed in one search field 'provider'. You can compare MARC21 search mappings with the files: - etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml - admin/searchengine/elasticsearch/mappings.yaml -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:39:09 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:39:12 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98528|0 |1 is obsolete| | Attachment #98529|0 |1 is obsolete| | Attachment #98530|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 99165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99165&action=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:39:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:39:16 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #41 from Jonathan Druart --- Created attachment 99166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99166&action=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:39:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:39:20 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #42 from Jonathan Druart --- Created attachment 99167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99167&action=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:40:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:40:39 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90400|0 |1 is obsolete| | Attachment #97976|0 |1 is obsolete| | Attachment #97977|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 99168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99168&action=edit Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus We are using raw SQL statements, we should use Koha::Hold instead. This patch does not seem optimal, we would like to increment priority in only 1 statement and without the need to fetch and loop all holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:40:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:40:42 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #11 from Jonathan Druart --- Created attachment 99169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99169&action=edit Bug 23070: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:40:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:40:46 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 --- Comment #12 from Jonathan Druart --- Created attachment 99170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99170&action=edit Bug 23070: Increment all priorities in 1 query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:41:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:41:03 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21944 --- Comment #13 from Jonathan Druart --- Patches rebased on top of bug 21944. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 [Bug 21944] Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:41:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:41:03 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:49:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:49:53 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:49:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:49:58 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:50:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:50:00 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99079|0 |1 is obsolete| | Attachment #99080|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 99171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99171&action=edit Bug 24669: Improve numeric input handling in smart-rules.pl This removes code duplication by introducing a new subroutine strip_non_numeric() that removes whitespace and makes the rule value '' if it is a string value instead of a digit. The call to strip_non_numeric() is now added also to all the rules it is needed in. To test: 1. Write some string like "test" to rules: - Current checkouts allowed - Current on-site checkouts allowed - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) - Holds per record (count) – can be found in default policy 2. Save rules 3. Apply patch 4. Edit the rule line where you just typed all those strings and save 5. Notice how the values are now empty strings (some say "unlimited" but if you go check from DB it should show empty value there) Sponsored-by: The National Library of Finland Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:50:04 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 --- Comment #4 from Jonathan Druart --- Created attachment 99172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99172&action=edit Bug 24669: Show "Unlimited" values correctly in smart-rules.pl The rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" were not set empty when in rule editing. Also, the text "Unlimited" was not shown for rule "Holds per record (count)" even though it should have been since empty value means unlimited holds per record. To test: 1. Apply patch 2. Edit the rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" to be empty and save 3. Make sure all of the above rules now say Unlimited 4. Edit the rules again and make sure the above rules are now in the rule editing empty. Sponsored-by: The National Library of Finland Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 11:58:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 10:58:31 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99088|0 |1 is obsolete| | Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |januszop at gmail.com |ity.org | --- Comment #2 from Janusz Kaczmarek --- Created attachment 99173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99173&action=edit Bug 24674: Uncertain years for publicationyear/copyrightdate -- corrected An amended version: This is a correction to Bug 11046: YYY-, YY--, Y---, are also according to ISBD: uncertain year, but certain decade/century/millennium (cf. n. 4.3.8 in ISBD Consolidated Edition of 2011). (Question mark is not mandatory.) In addition, in Poland a form with only one dash is quite common, like YY- (== YY--). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:03:27 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #10 from Jonathan Druart --- Worth noting: having the formatting at currency level is not ideal actually. For instance we could have: * 1 234,56 € * €1.234,56 * 1.234,56 € * €1,234.56 * ... Letting QA decide if this can be considered as an improvement anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:06:03 +0000 Subject: [Koha-bugs] [Bug 14818] Add missing DBIx::Class relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22407, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5334 --- Comment #2 from Jonathan Druart --- That's getting better, but we still have missing relationship. I think we can keep this one open. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:06:03 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14818 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:06:03 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14818 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:15:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:15:36 +0000 Subject: [Koha-bugs] [Bug 24310] Use Text::Lorem instead of String::Random in Test::Builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 --- Comment #4 from Jonathan Druart --- The context was: * https://lists.koha-community.org/pipermail/koha-devel/2019-December/045450.html * https://gitlab.com/joubu/koha-plugin-jump I do not have time at the moment to get back to this, and I have not received much help on the list. So not sure it makes sense to have this into master now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:18:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:18:26 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #3 from Janusz Kaczmarek --- Test plan: o put a date like [198-] or [18--] or [17-] in 260 $c and save the record o check the error log -- you should see something like: Argument "[198-]." isn't numeric in int at /usr/share/koha/lib/C4/Biblio.pm line 2832 o apply the patch o open and save the record again (ModBiblio will be executed) o check the error log -- it should have no errors now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:26:42 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99147|0 |1 is obsolete| | Assignee|jonathan.druart at bugs.koha-c |januszop at gmail.com |ommunity.org | Status|Needs Signoff |Signed Off CC| |januszop at gmail.com --- Comment #2 from Janusz Kaczmarek --- Created attachment 99174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99174&action=edit Bug 24677: (bug 24002 follow-up) Incorrect DATE value: '00-00-0000' in C4/Serials.pm The patch applies smoothly on master and does what is supposed to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:41:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:41:46 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|januszop at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:48:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:48:58 +0000 Subject: [Koha-bugs] [Bug 24679] New: Allow to apply a MARC modification template in export tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 Bug ID: 24679 Summary: Allow to apply a MARC modification template in export tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:49:46 +0000 Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template in export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 --- Comment #1 from Julian Maurice --- Created attachment 99175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99175&action=edit Bug 24679: Allow to apply a MARC modification template in export tool Test plan: 1. Create a MARC modification template with a simple action (for instance, "Add new field 999$9 with value foobar") 2. Go to Tools » Export data 3. Select some records (for instance, from biblionumber 1 to 10) 4. In options, select the MARC modification template you just created 5. Select File format 'MARC' 6. Click on 'Export bibliographic records' 7. Verify that exported records contain the 999$9 field 8. Repeat steps 3-7 with other export formats, and with authority records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:49:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:49:56 +0000 Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template in export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 12:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 11:53:45 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #46 from Kyle M Hall --- koha_trusted_proxies is a config setting from the Koha conf xml file, so mock_preference won't work on that. You'll want to use mock_config instead. (In reply to David Cook from comment #45) > (In reply to Martin Renvoize from comment #44) > > Thanks David, that's great news. > > Finally getting around to this... > > Have to leave for the night but the following isn't working for some reason: > > t::lib::Mocks::mock_preference('koha_trusted_proxies', '1.1.1.1'); > > Will have to look at this more tomorrow... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:11:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:11:40 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Can we get a test plan please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:18:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:18:27 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:18:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:18:40 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99143|0 |1 is obsolete| | --- Comment #169 from Ere Maijala --- Created attachment 99176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99176&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:18:46 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99144|0 |1 is obsolete| | --- Comment #170 from Ere Maijala --- Created attachment 99177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99177&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:18:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:18:52 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99145|0 |1 is obsolete| | --- Comment #171 from Ere Maijala --- Created attachment 99178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99178&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:18:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:18:57 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99146|0 |1 is obsolete| | --- Comment #172 from Ere Maijala --- Created attachment 99179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99179&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:19:25 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #173 from Ere Maijala --- Fixed a typo introduced during last rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:30:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:30:36 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #5 from Jonathan Druart --- Created attachment 99180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99180&action=edit Bug 24071: Add a way to export debug info Actually this patch does much more, but still not enough. There are 2 goals that I would like to achieve with this patch: * Add an entry point to the Koha wiki from Koha * Explain a bit how to report a from within Koha, and export useful data TODO: * Stylish * Fix wording * Improve exported file (must be either a .txt or .zip with other text files, not a .pdf) * Display other log files, not only plack-error.log * Display the bottom of the log file, not the beginning * Only display the last X lines of the logs (500?) * Is there a way to retrieve the content of the JS console (sounds impossible to get it from other tabs anyway, unless we copy it in the local storage, which seems wrong). * Main question: how critical it is to display the log file? Is that ok to display it for superlibrarian only? They will need to be warned that the file could contain potential data they do not want to share publicly (IP, DB name, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:32:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:32:43 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > Going further, what about a new area in Koha to post an issue, we could > retrieve the correct info we need and open a new bug report for them? > (but... spam, support companies, too easy and so will skip ML, etc.) This last patch is more or less what I had in mind. Submitted to open/continue the discussion. What it looks like (quite ugly, needs to be styled): https://snipboard.io/OdjLr5.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:35:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:35:20 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 --- Comment #4 from Jonathan Druart --- The serial's year need to be the planneddate if publisheddate is null. The changes is obvious when you read the previous commit and this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 13:44:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 12:44:04 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Created attachment 99111 [details] [review] > Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items > > It's quite hard to know where this need to be fixed. > it can be either MarkIssueReturned or LostItem, depending on the > different cases we want to handle. > > This patch picked MarkIssueReturned, but maybe the similar code in > AddReturn needs to be removed then. > > This patch fixes the original issue report by bug 24413, but is > submitted for discussion Considering MarkIssueReturned and LostItem are not always called, should it not be in _FixAccountForLostAndFound? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:14:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:14:50 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Hi Janusz, One test is failing with your patch: t/db_dependent/Biblio/TransformMarcToKoha.t .. 1/3 # Failed test 'Missing question mark' # at t/db_dependent/Biblio/TransformMarcToKoha.t line 107. # got: '1980' # expected: '198-' # Looks like you failed 1 test of 10. # Failed test 'Testing _adjust_pubyear' # at t/db_dependent/Biblio/TransformMarcToKoha.t line 109. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:15:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:15:22 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Depends on| |11046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:15:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:15:22 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:20:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:20:28 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #4) > Comment on attachment 95661 [details] [review] > Bug 23482: Fix BakerTaylor cover images on lists > > Review of attachment 95661 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt > @@ +360,5 @@ > > + No cover image available > > + [% END %] > > + [% END %] > > + > > + [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] > > Not sure why you start a new IF block here - conditions and variables appear > to be the same as on the check right before it? One is: !Koha.Preference('BakerTaylorBookstoreURL') The other is: Koha.Preference('BakerTaylorBookstoreURL') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:20:37 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:23:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:23:36 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #4 from Jonathan Druart --- It seems that _FixAccountForLostAndFound is called from AddIssue and AddReturn. In our case none of them is called so I am pretty sure it will not fix the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:25:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:25:47 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:25:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:25:50 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99089|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 99184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99184&action=edit Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:27:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:27:42 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99184|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 99185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99185&action=edit Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:30:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:30:10 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #6 from Katrin Fischer --- Argh, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:30:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:30:58 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > It seems that _FixAccountForLostAndFound is called from AddIssue and > AddReturn. In our case none of them is called so I am pretty sure it will > not fix the issue. I see now, this code looks good from that perspective, though it would definitely be preferable to add a new subroutine now, otherwise we have duplicated code. It seems like a fairly trivial adjustment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:38:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:38:22 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #5 from Janusz Kaczmarek --- Jonathan, thank you. But the result is on purpose. I do want that 198- ([198-] in particular, with square braces) will be transformed into 1980. It is perfectly correct to have a date like this without question mark (cf. ISBD 2011 examples, p. 183-184, https://www.ifla.org/files/assets/cataloguing/isbd/isbd-cons_20110321.pdf). Could we correct the tests? (I do not know how to do this.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:50:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:50:26 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:50:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:50:29 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #6 from Jonathan Druart --- Created attachment 99186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99186&action=edit Bug 24674: Adjust tests and add new ones to cover changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:53:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:53:27 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 --- Comment #5 from Janusz Kaczmarek --- Created attachment 99187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99187&action=edit Test case Test plan: - receive some back issues (of past years) - see that they are aggregated under current year (i.e. 2020) - apply the patch - check that the attribution of volumes/issues to years is OK now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:54:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:54:21 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #7 from Jonathan Druart --- I adjusted the failing tests and add some more. I do not know if we need to adjust the year only if surrounded by square brackets. Letting someone else to signoff in order to get another point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:54:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:54:44 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:55:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:55:38 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #53 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:55:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:55:41 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 14:55:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 13:55:43 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #22 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:04:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:04:22 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #8 from Katrin Fischer --- I am wondering if this could be confusing to users as we display the information from publicationyear/copyrightdate in quite a lot of places. We just recently looked into the logic here too: 1999- = 1999 1999-2009 = 1999 19xx (very common here) = NULL So the user will see the first "4 digits" as year when not looking at the detail page. While publicationyear is text in the database (used by UNIMARC), copyrightdate is a smallint(6) and can only store numeric values. I wonder if we want or are treating both fields the same currently and if we should be less restrictive for publicationyear? I'd love to get some more eyes on this - from the standard I think you are right. It's just the issue of display that worries me a little. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:07:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:07:17 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #6 from Jonathan Druart --- (In reply to Kyle M Hall from comment #5) > (In reply to Jonathan Druart from comment #4) > > It seems that _FixAccountForLostAndFound is called from AddIssue and > > AddReturn. In our case none of them is called so I am pretty sure it will > > not fix the issue. > > I see now, this code looks good from that perspective, though it would > definitely be preferable to add a new subroutine now, otherwise we have > duplicated code. It seems like a fairly trivial adjustment. Do not you think we should remove the code from AddReturn (as it calls MarkIssueReturned)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:08:51 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #9 from Janusz Kaczmarek --- (In reply to Jonathan Druart from comment #7) > I adjusted the failing tests and add some more. I do not know if we need to > adjust the year only if surrounded by square brackets. > > Letting someone else to signoff in order to get another point of view. I think we do not have to bother about the braces here. In very formal ISBD a date like this should be surrounded by braces, but in older records the whole zone 4 could be in braces, not the individual elements (like: [Roma : s.n., 18--]). The function _adjust_pubyear works well in both cases, paying attention on numbers only and characters after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:10:47 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |19.11.00 20.05.00 released in| | --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize from comment #22) > Nice work everyone! > > Pushed to master for 20.05 Should not have been pushed regarding my last 2 comments :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:15:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:15:07 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #10 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #8) > I am wondering if this could be confusing to users as we display the > information from publicationyear/copyrightdate in quite a lot of places. We > just recently looked into the logic here too: > > 1999- = 1999 > 1999-2009 = 1999 > 19xx (very common here) = NULL > > So the user will see the first "4 digits" as year when not looking at the > detail page. > > While publicationyear is text in the database (used by UNIMARC), > copyrightdate is a smallint(6) and can only store numeric values. I wonder > if we want or are treating both fields the same currently and if we should > be less restrictive for publicationyear? > > I'd love to get some more eyes on this - from the standard I think you are > right. It's just the issue of display that worries me a little. I get the point -- this is an important design question. I totally agree, this effect can be and is misleading for the users. But here I just wanted to get rid of the annoying errors in errorlog which are caused by the current version of the _adjust_pubyear function. (If it transforms [198-?] into 1980, it should do the same with [198-]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:19:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:19:43 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 --- Comment #2 from Addie --- The process was: Using the batch item deletion tool, deleted items by barcode numbers. Then if you go to a patron account where a fine was at any point associated with those items, you would get a white page with black "internal server error" in the left corner of the page. >From the database side, the itemnumber of those items remained in the accountlines for associated fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:24:45 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:24:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:24:48 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98830|0 |1 is obsolete| | Attachment #98831|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 99188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99188&action=edit Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:24:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:24:51 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #10 from Jonathan Druart --- Created attachment 99189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99189&action=edit Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:33:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:33:44 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 --- Comment #3 from Jonathan Druart --- Which exact version of Koha? Do you recreate the problem on the latest 19.05.x? On master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:45:33 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > (In reply to Kyle M Hall from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > It seems that _FixAccountForLostAndFound is called from AddIssue and > > > AddReturn. In our case none of them is called so I am pretty sure it will > > > not fix the issue. > > > > I see now, this code looks good from that perspective, though it would > > definitely be preferable to add a new subroutine now, otherwise we have > > duplicated code. It seems like a fairly trivial adjustment. > > Do not you think we should remove the code from AddReturn (as it calls > MarkIssueReturned)? Yes, that makes sense. It's also worth noting that the code block is idempotent so it's not going to hurt to run it multiple times. It should just be kept in one place for code. maintenance purposes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:47:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:47:39 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #23 from Agustín Moyano --- (In reply to Bernardo Gonzalez Kriegel from comment #22) > Question: Why 'inscripts' instead of 'incipits'? > I'm referring to the name of the preference and the displayed text. > > Came to this doing translation. > Incipits makes sense, inscripts not so much. Ups!.. misread the title of the bug! I'll correct them in following bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:57:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:57:19 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- % git show master:koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt > /tmp/layout2pages_master.odt % git show BZ5016:koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt > /tmp/layout2pages_5016.odt % odt2txt /tmp/layout2pages_master.odt % odt2txt /tmp/layout2pages_5016.odt % diff /tmp/layout2pages_master.txt /tmp/layout2pages_5016.txt 7c7 < Order form N° on --- > Order form no. on 12c12 < Market Identification --- > Market identification % git show master:koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt > /tmp/layout3pages_master.odt % git show BZ5016:koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt > /tmp/layout3pages_5016.odt % odt2txt /tmp/layout3pages_master.odt % odt2txt /tmp/layout3pages_5016.odt % diff /tmp/layout3pages_master.txt /tmp/layout3pages_5016.txt 7c7 < Order form N° on --- > Order form no. on 12c12 < Market Identification --- > Market identification 59c59 < ORDER REFERENCES FOR ORDER FORM N° --- > ORDER REFERENCES FOR ORDER FORM NO. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:57:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:57:47 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 15:57:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 14:57:52 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98807|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 99190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99190&action=edit Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:03:33 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:04:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:04:58 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- I think we should also update those occurrences: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt:Koha › Cataloging ’ Link to host item koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:11:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:11:12 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #11 from Agustín Moyano --- (In reply to Jonathan Druart from comment #10) > Typo: > + var tz = (opitons&&options.tz)||def_tz; Ups, seems I forgot to attach the patch where I fixed that.. > How is this related to bug 24650? > It seems that it achieves the same goal without extra lib and very few lines. I hadn't seen that bug.. seems this bug is previous to that one.. but the main difference is that this implementation takes into account the timezone, so if a date comes from the api with UTC timezone it will be correctly translated to your current timezone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:11:55 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #11 from Janusz Kaczmarek --- But guess what will be displayed in this real life example: Warszawa : Universitas, [19]89-. http://katalog.nukat.edu.pl/lib/item?id=chamo:22190&fromLocationLink=false&theme=nukat BTW, I'm wondering why, in standard installation od Koha, is the same ISBD element "Date of publication, production and/or distribution" [4.3] mapped to biblio.copyrightdate when coming from MARC 21 (= 260 $c), but to biblioitems.publicationyear when coming from UNIMARC... Any clue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:16:25 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 --- Comment #8 from Jonathan Druart --- Created attachment 99191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99191&action=edit [ALTERNATIVE-PATCH] Bug 23384: Fix use statement order for ArticleRequest::Status Koha::ArticleRequest is used by Koha::ArticleRequests so Koha::ArticleRequest::Status should not be needed in Koha::ArticleRequest. Also Koha::ArticleRequest::Status must be loaded before Koha::ArticleRequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:17:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:17:08 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- I think this alternative patch is the way to go. Koha::ArticleRequests was missing from Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:49:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:49:45 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #12 from Jonathan Druart --- Created attachment 99192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99192&action=edit test tz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:52:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:52:35 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #13 from Jonathan Druart --- (In reply to Agustín Moyano from comment #11) > (In reply to Jonathan Druart from comment #10) > > How is this related to bug 24650? > > It seems that it achieves the same goal without extra lib and very few lines. > > I hadn't seen that bug.. seems this bug is previous to that one.. but the > main difference is that this implementation takes into account the timezone, > so if a date comes from the api with UTC timezone it will be correctly > translated to your current timezone. What do you mean by correctly translated to your current timezone? Do you mean the TZ from the server? I tried this patch, with Buenos Aires in the timezone config, I see: 2020-02-18T12:46:05-03:00 02/18/2020 16:46 (current date of the server is 16:46) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:53:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:53:58 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- This is blocked until I understand the need and the link with bug 24455. Andrew, what is your real-life use case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 16:54:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 15:54:13 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #12 from Katrin Fischer --- (In reply to Janusz Kaczmarek from comment #11) > But guess what will be displayed in this real life example: > > Warszawa : Universitas, [19]89-. > > http://katalog.nukat.edu.pl/lib/item?id=chamo: > 22190&fromLocationLink=false&theme=nukat > > BTW, I'm wondering why, in standard installation od Koha, is the same ISBD > element "Date of publication, production and/or distribution" [4.3] mapped > to biblio.copyrightdate when coming from MARC 21 (= 260 $c), but to > biblioitems.publicationyear when coming from UNIMARC... > > Any clue? I have no idea to the why... my guess is it was an early on oversight that turned out really hard to fix later on. So now we have a lot of 'glue code' that makes both work right in a lot of places :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 17:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 16:04:39 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- The BEGIN block is wrong, see bug 17896. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 17:06:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 16:06:43 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #36 from Rinrada Wongsaichua --- (In reply to Jonathan Druart from comment #35) > Hello Rinrada, > > I have attached a file that has the correct format (patch). > However I am not sure this is the correct way to fix the issue. > > Chris, can we get your opinion on it? Hi Jonathan, every time I edit template of patroncards which has no profile_id attached to template Profile will display first printer name from the selector list even if profile_id==0 Tested edit on template of labels that has no profile_id attached (profile_id==0) It will display 'Profile: No Profile/N/A' and able to save successfully no error Checked label-edit-template.pl and found this line >> push @$profile_list, {paper_bin => 'N/A', profile_id => 0, printer_name => 'No Profile'}; which only exist in label-edit-template.pl but does not exist in edit-template.pl Checked database and noticed that both patroncards and labels stored Printer profiles in the same table (printers_profile table) and identify by creator field Hopefully my investigation will help you guys on this case come how -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 17:11:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 16:11:49 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- I get a 404 Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 17:13:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 16:13:23 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > I get a 404 > Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png https://snipboard.io/8BbRWf.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 17:23:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 16:23:40 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #12 from Jonathan Druart --- Also, the style looks weird (I did yarn build --view opac): https://snipboard.io/ob6UZq.jpg And the popup does not display for the non XSLT view (new search is launched instead). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:40:11 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:40:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:40:17 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98078|0 |1 is obsolete| | Attachment #98079|0 |1 is obsolete| | --- Comment #32 from Agustín Moyano --- Created attachment 99193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99193&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:40:23 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #33 from Agustín Moyano --- Created attachment 99194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99194&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:45:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:45:29 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #34 from Agustín Moyano --- (In reply to Barbara Johnson from comment #31) > I agree with Catherine that it would be preferable to have the patch update > ALL patrons to have both Email and Digest CHECKED for the Auto Renewal > function. If our patrons stop receiving any renewal notices it will cause a > big customer service issue for us. > > During our preparation for Go Live, we had some default messaging > preferences put in place. New patrons, whether created via > self-registration or by staff, all get specific messaging options checked > which they can later change if they want. Perhaps adding Email and Digest > Auto Renewal default messaging preferences would make sure that existing > patrons don't lose anything. > > Does this sound like it would work? > Barbara Hi Barbara and Catherine, Both of you were right.. Category messaging preferences didn't work as I expected.. I thought that it would be a default value when a patron didn't set his/hers own preference, but it was more like a template when you create a new patron. So, in the update script I set email and digest options to checked. Could you please test this again? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:55:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:55:01 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98625|0 |1 is obsolete| | --- Comment #14 from Agustín Moyano --- Created attachment 99195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99195&action=edit Bug 24455: Add JS functions to format date and datetime strings This patch adds the a js-date-format.inc file on each opac and staff interface (date-format.inc whas not available as name) When you include that file in your TT, you'll get the following functions available: 1. $date(raw_date_string, options) This function parses a date string, as produced by an api call, and returns the corresponding date formatted according to 'dateformat' and 'TimeFormat' parameters. For example: // dateformat: us // timeformat: 12hr // Timezone: UTC $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020' $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get '03/23/2020 14:00' $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) // You will get '03/23/2020 15:00+01:00' Options: * dateformat: override date format as configured in staff interface (accepts also 'rfc3339') * timeformat: override time format as configured in staff client (available options are '12hr' and '24hr') * withtime: also print the time part (default false) * tz: set the timezone 2. $datetime(raw_date_string, option) The same as $date but sets withtime to true 3. $time(raw_date_string, option) The same as $datetime but shows only the time part To test you must implement and test bug 20936, where it will be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:55:04 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #35 from Barbara Johnson --- Hi Agustín, Thanks for the new test plan. I'm new at testing bugs. I'm not sure what I'm supposed to do for step 10 (perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v) or 15 (add -d flag) Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 18:57:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 17:57:49 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #15 from Agustín Moyano --- (In reply to Jonathan Druart from comment #13) > (In reply to Agustín Moyano from comment #11) > > (In reply to Jonathan Druart from comment #10) > > > How is this related to bug 24650? > > > It seems that it achieves the same goal without extra lib and very few lines. > > > > I hadn't seen that bug.. seems this bug is previous to that one.. but the > > main difference is that this implementation takes into account the timezone, > > so if a date comes from the api with UTC timezone it will be correctly > > translated to your current timezone. > > What do you mean by correctly translated to your current timezone? Do you > mean the TZ from the server? > > I tried this patch, with Buenos Aires in the timezone config, I see: > 2020-02-18T12:46:05-03:00 > 02/18/2020 16:46 > > (current date of the server is 16:46) according to the patch your uploaded, I believe you where using the code of bug 24650. I'll try to upload a patch with [DO NOT PUSH] with a test case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:12:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:12:10 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:12:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:12:15 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97303|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 99196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99196&action=edit Bug 19382: Add ability to block guarantees based on fees owed by guarantor and other guarantees Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items. Test Plan: 1) Apply this patch 2) Set NoIssuesChargeGuarantorsWithGuarantees to $14 3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children 4) Give 3 of the 4 a $5 fine 5) None of them should be able to check out items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:23:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:23:11 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #125 from Nick Clemens --- If I receive a few serials and then delete the expected issue from the serials collection screen I can only see an expected issue until I receive the expected issue, then all previously received undeleted issues show again. To recreate: 1 - Create a subscription that creates items 2 - Receive two issues 3 - From serial collection select the 'Expected' issue and delete 4 - You only see the new expected issue If I try to delete a serial with an item that cannot be deleted the serial deletion completes but the item remains with no feedback To recreate 1 - Follow 1 and 2 above 2 - Check out one of the items 3 - Select the serial for this issue and delete 4 - Check the box to confirm deleting items 5 - The serial is deleted, the item remains, no error shown to user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:24:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:24:36 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Signed Off |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Ooops, I pushed the followup added to bug 24002 before I realized this one existed. Closing as fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:30:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:30:03 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99185|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99197&action=edit Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:31:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:31:52 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99192|0 |1 is obsolete| | --- Comment #16 from Agustín Moyano --- Created attachment 99198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99198&action=edit [DO NOT PUSH] Bug 24455: test timezone This is just a test.. I added the .inc file to adimn's main page To test: 1. go to Koha main page and open chrome or firefox console 2. type $datetime('2020-02-18T12:46:05Z', {tz: 'America/Argentina/Buenos_Aires'}) and you should get "02/18/2020 09:46" because America/Argentina/Buenos_Aires is -03:00 3. type $datetime('2020-02-18T12:46:05Z', {tz: 'Asia/Shanghai'}) and you should get "02/18/2020 20:46" because Asia/Shanghai is +08:00 4. type $datetime('2020-02-18T12:46:05Z') and it should be translated to your koha instance configured timezone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:38:53 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #62 from Lisette Scheer --- (In reply to Jonathan Druart from comment #51) > Created attachment 99148 [details] [review] > Bug 15522: Add API for circulation rules > > Test plan: > 1) Run t/db_dependent/api/v1/circ_rules.t . kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/api/v1/circ_rules.t t/db_dependent/api/v1/circ_rules.t .. 1/5 # Failed test '403 Forbidden' # at t/db_dependent/api/v1/circ_rules.t line 128. # got: '400' # expected: '403' # Looks like you failed 1 test of 2. t/db_dependent/api/v1/circ_rules.t .. 3/5 # Failed test 'set_rules | unauthorized' # at t/db_dependent/api/v1/circ_rules.t line 132. # Failed test '200 OK' # at t/db_dependent/api/v1/circ_rules.t line 212. # got: '403' # expected: '200' # Looks like you failed 1 test of 6. # Failed test 'set_rules | restricted' # at t/db_dependent/api/v1/circ_rules.t line 223. # Looks like you failed 2 tests of 5. t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/5 subtests Test Summary Report ------------------- t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) Failed tests: 3, 5 Non-zero exit status: 2 Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 csys = 3.11 CPU) Result: FAIL I got this message when I tried to do this step in my devbox. Everything else worked great for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:42:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:42:04 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99148|0 |1 is obsolete| | --- Comment #63 from Lisette Scheer --- Created attachment 99199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99199&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:42:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:42:44 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99156|0 |1 is obsolete| | --- Comment #64 from Lisette Scheer --- Created attachment 99200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99200&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:43:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:43:03 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99200|0 |1 is obsolete| | --- Comment #65 from Lisette Scheer --- Created attachment 99201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99201&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:43:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:43:36 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99155|0 |1 is obsolete| | --- Comment #66 from Lisette Scheer --- Created attachment 99202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99202&action=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:44:08 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99154|0 |1 is obsolete| | --- Comment #67 from Lisette Scheer --- Created attachment 99203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99203&action=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:44:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:44:45 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99153|0 |1 is obsolete| | --- Comment #68 from Lisette Scheer --- Created attachment 99204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99204&action=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:45:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:45:15 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99152|0 |1 is obsolete| | --- Comment #69 from Lisette Scheer --- Created attachment 99205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99205&action=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:45:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:45:47 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99151|0 |1 is obsolete| | --- Comment #70 from Lisette Scheer --- Created attachment 99206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99206&action=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:46:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:46:14 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99150|0 |1 is obsolete| | --- Comment #71 from Lisette Scheer --- Created attachment 99207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99207&action=edit Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:46:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:46:33 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99149|0 |1 is obsolete| | --- Comment #72 from Lisette Scheer --- Created attachment 99208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99208&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:46:59 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99199|0 |1 is obsolete| | --- Comment #73 from Lisette Scheer --- Created attachment 99209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99209&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:47:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:47:48 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99157|0 |1 is obsolete| | Attachment #99209|0 |1 is obsolete| | --- Comment #74 from Lisette Scheer --- Created attachment 99210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99210&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:48:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:48:19 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:49:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:49:04 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #75 from Lisette Scheer --- Created attachment 99211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99211&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:49:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:49:09 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 --- Comment #6 from Martin Renvoize --- Created attachment 99212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99212&action=edit Bug 24666: (QA follow-up) Add missing filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:50:16 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99148|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:54:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:54:59 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99208|0 |1 is obsolete| | --- Comment #76 from Lisette Scheer --- Created attachment 99213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99213&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:55:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:55:00 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Works as expected, resolves a regression. QA follow-up added to fix filter errors, but otherwise no issues found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:55:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:55:14 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99207|0 |1 is obsolete| | --- Comment #77 from Lisette Scheer --- Created attachment 99214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99214&action=edit Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 19:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 18:56:05 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #78 from Lisette Scheer --- Created attachment 99215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99215&action=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:04:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:04:14 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99171|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99216&action=edit Bug 24669: Improve numeric input handling in smart-rules.pl This removes code duplication by introducing a new subroutine strip_non_numeric() that removes whitespace and makes the rule value '' if it is a string value instead of a digit. The call to strip_non_numeric() is now added also to all the rules it is needed in. To test: 1. Write some string like "test" to rules: - Current checkouts allowed - Current on-site checkouts allowed - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) - Holds per record (count) – can be found in default policy 2. Save rules 3. Apply patch 4. Edit the rule line where you just typed all those strings and save 5. Notice how the values are now empty strings (some say "unlimited" but if you go check from DB it should show empty value there) Sponsored-by: The National Library of Finland Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:04:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:04:17 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99172|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 99217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99217&action=edit Bug 24669: Show "Unlimited" values correctly in smart-rules.pl The rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" were not set empty when in rule editing. Also, the text "Unlimited" was not shown for rule "Holds per record (count)" even though it should have been since empty value means unlimited holds per record. To test: 1. Apply patch 2. Edit the rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per record (count)" to be empty and save 3. Make sure all of the above rules now say Unlimited 4. Edit the rules again and make sure the above rules are now in the rule editing empty. Sponsored-by: The National Library of Finland Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:05:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:05:04 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Thanks for the quick followup here Joonas, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:11:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:11:52 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99044|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 99218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99218&action=edit Bug 22245: Allow copy/move from and to control fields The JS conditions were wrong, we want to allow copy and move between control fields. Test plan: Create a new MARC modification template action using control fields. Confirm that you are allowed to copy/move a control field to another one Signed-off-by: Hayley Mapley Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:12:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:12:39 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- No regressions found and bug opened for followup work I see.. QA scripts are happy and I believe this patch moves us forward. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:18:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:18:35 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98999|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 99219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99219&action=edit Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:18:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:18:58 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Trivial and obvious fix. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:23:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:23:27 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98967|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 99220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99220&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:24:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:24:51 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works as expected, no regressions found and QA scripts pass.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:45:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:45:51 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #7 from Lisette Scheer --- (In reply to Andrew Fuerste-Henry from comment #6) > Christopher, I'm not able to replicate this in Master. I tried to confirm > the behavior before applying the patch and haven't gotten the expiration > date to come up null. Can you please confirm the problem still exists and/or > provide steps to replicate it? I was able to replicate is this way: 1. In notices and slips, add [% hold.reserve_id %] to your hold slip. 2. Place 2 bib level holds for the same patron on a bib. 3. Check in one of the items and click print slip. 4. Observe that the slip doesn't have an expiration date at all. 5. Cancel the waiting hold. 6. Check in the other item and click print slip. 7. Observe the expiration date on the slip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:46:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:46:53 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98861|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 99221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99221&action=edit Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules == Test plan == - work with SCSS (just recompile it if you never did) - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS - now you have a node_modules directory - prove -r t/00-valid-xml.t - it should fail on files in node_modules - apply this patch - prove -r t/00-valid-xml.t - it should work - sabotage a legitimate XML file, like etc/SIPconfig.xml - prove -r t/00-valid-xml.t - it should fail, good the test is still useful - undo the sabotage Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:46:56 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98862|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99222&action=edit Bug 24494: Make the regex more exact Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:47:10 +0000 Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons, report who was not deleted and why In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:47:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:47:29 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Great work, been meaning to do this myself for ages.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:52:17 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98735|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 99223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99223&action=edit Bug 24094: Unit tests Signed-off-by: Myka Kennedy Stephens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:52:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:52:20 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98736|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 99224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99224&action=edit Bug 24094: Strip trailing spaces and punctuation from authority headings Both when searching for and creating new authorities we need to remove punctuation that exists in the bibliographic record but does not belong in the authority record. For example, a series with a volume contains a semicolon in the bib record, however, this should not be passed to the authority as the volume is not included in the authority record. To test: 1 - Set AutoCreateAuthorities to 'generate' 2 - Set BiblioAddsAuthorities to 'true' 3 - Set CatalogModuleRelink to 'Do' 4 - Find or create a record with: a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. Eugene M ,$e author an 830 field with a volume preceded by a semicolon: 650$aLord of the rings ;$v 3. 5 - Save the records and check the links 6 - Note punctuation is passed through 7 - Save again, auth records are created again 8 - Apply patch 9 - Save again, new auth records are created again 10 - Check the records, punctuation has been removed 11 - Save again, no more records created. Signed-off-by: Myka Kennedy Stephens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:52:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:52:55 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Works well, QA scripts are happy and it's got unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:53:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:53:47 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #22 from Aleisha Amohia --- My initial patches introduced a new syspref. Should I submit a follow up to this bug or make a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:57:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:57:57 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97809|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 99225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99225&action=edit Bug 21633: Remove finesMode 'test' Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:58:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:58:00 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97810|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 99226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99226&action=edit Bug 21633: (follow-up) Cleanup other values for finesMode Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 20:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 19:58:45 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- Nice bit of clean up.. thanks guys. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 21:02:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 20:02:06 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #7 from Lisette Scheer --- On master the expiration date can be edited/cleared once the hold is reverted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 21:11:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 20:11:33 +0000 Subject: [Koha-bugs] [Bug 8595] link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org, | |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Are we sure that item is not correct? When I click on "Link to host item" I am asked to enter an item barcode - not a record number. As far as I know the 773 created contains a subfield with the itemnumber and the host item is displayed on all analytical records linked to it. I think this is actually item based. Adding Elaine - I know her library is using this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 21:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 20:11:59 +0000 Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|link to 'host item' |Link to 'host item' |confusing |confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 21:18:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 20:18:23 +0000 Subject: [Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- I've just had this problem with a branch that was deleted and the rules didn't go away, crashing out the overdues script! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 21:38:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 20:38:56 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 --- Comment #4 from Addie --- This happened either on 19.05.05 or 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 22:04:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 21:04:24 +0000 Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 --- Comment #7 from Elaine Bradtke --- In answer to Katrin - We don't link to the item number in 773 (the item number is $o in our records) We use the record control number instead. 773 0# - HOST ITEM ENTRY o Other item identifier 17188 w Record control number LS01459 t Title [Political pamphlets from 1820] 'Item' here is from MARC - http://www.loc.gov/marc/bibliographic/bd773.html but I don't think it necessarily means the same as 'item record'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 22:05:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 21:05:30 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #23 from Katrin Fischer --- I'd like a separate pref, but maybe we should get some more opinions (Owen and me are like 1:1 so far :) ), before we create more work for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 22:17:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 21:17:30 +0000 Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #39 from John Sterbenz --- This is a new issue to me (as of yesterday) on the 18.11 series on 18.04 LTS. This process had worked for years prior (all the way back to 2016 / 3.22 on 14.04)--now every load I try fails. I did upgrade my production server to 18.04 in preparation for installation of the 19.05 series--that is the only difference (in terms of anything I've directly initiated) between success and failure, yet the comments here indicate this has been an issue for nearly 5 years and reported (at least here) as recently as a few months ago. Prod was already running the 18.11 series--it was only the OS I upgraded. Thanks to VM snapshots, I took my dev server back to 17.11 on 16.04 and everything worked again, but that doesn't do me any good for production. This is the only way we load records--and do so to the tune of 260K-300K records a month (in files of 20K records). Most of these records are overlaid--perhaps only 1-2% are new records. We are at a standstill until this is resolved or I identify some sort of workaround. I have not yet tried anything like a smaller file size since this was just discovered yesterday by my staff in the course of regular work. I note the mention of Plack (without having read the entire comment thread yet to see if this is relevant/related or not) and have not turned that off for this instance to see if that will matter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 22:28:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 21:28:51 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #24 from Lisette Scheer --- (In reply to Katrin Fischer from comment #21) > I think I'd have preferred it as it also allows to keep the current > behaviour (least surprise/no change on update) I think I'm with Cait on this one, especially since items aren't currently effected by the sys pref that effect records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:37:14 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from Katrin Fischer --- I've switched the sequence of patches when applying, but still get a conflict: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 3137: HideFieldsPatronAddForm syspref Applying: Bug 21156: (RM follow-up) Add missing filters Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 21156: (RM follow-up) Add missing filters The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21156-RM-follow-up-Add-missing-filters-BipPBa.patch Can you please rebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:45:04 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #36 from Agustín Moyano --- (In reply to Barbara Johnson from comment #35) > Hi Agustín, > > Thanks for the new test plan. I'm new at testing bugs. I'm not sure what > I'm supposed to do for step 10 (perl misc/cronjobs/automatic_renewals.pl -c > --send-notices -v) or 15 (add -d flag) > > Thanks. Hi Barbara, that step executes what a cronjob would do. You should copy that line and paste it in a console, un the root of Koha project. To get a console: * if you are using koha-testing-docker in your linux console you should: 1. docker exec -ti koha_koha_1 bash 2. cd koha 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v * If you use vagrant, in your linux console, in the root of your vagrant project execute: 1. vagrant ssh 2. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v * If you've got a testing server you should: 1. ssh youruser at kohatestingserver 2. cd /koha/project/path 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v I'm assuming in all cases that you are using any distribution of Linux to develop. If you're using windows I don't know. Hope it helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:47:51 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #37 from Agustín Moyano --- (In reply to Agustín Moyano from comment #36) > (In reply to Barbara Johnson from comment #35) > > Hi Agustín, > > > > Thanks for the new test plan. I'm new at testing bugs. I'm not sure what > > I'm supposed to do for step 10 (perl misc/cronjobs/automatic_renewals.pl -c > > --send-notices -v) or 15 (add -d flag) > > > > Thanks. > > Hi Barbara, that step executes what a cronjob would do. > > You should copy that line and paste it in a console, un the root of Koha > project. > > To get a console: > * if you are using koha-testing-docker in your linux console you should: > 1. docker exec -ti koha_koha_1 bash > 2. cd koha > 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v > > * If you use vagrant, in your linux console, in the root of your vagrant > project execute: > 1. vagrant ssh > 2. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v > > * If you've got a testing server you should: > 1. ssh youruser at kohatestingserver > 2. cd /koha/project/path > 3. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v > > I'm assuming in all cases that you are using any distribution of Linux to > develop. > > If you're using windows I don't know. > > Hope it helps! Sorry, just crossed my mind.. if you're not a developer, then you should ask the help of a technician -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:54:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:54:25 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- Hi Aleisha, starting with review and QA tools here: 1) Can you check if this is a real one or a false positive? FAIL Koha/ProblemReport.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 2) Please fix filters: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt FAIL filters missing_filter at line 3 ([% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Report a Problem) missing_filter at line 31 (
    Your problem report has been sent to the [% IF ( recipient == 'admin' ) %]Koha Administrator[% ELSE %][% recipient %][% END %].
    ) missing_filter at line 56 ( ) missing_filter at line 61 ( ) missing_filter at line 65 ( ) 3) Database update You got: + $dbh->do(q{ DROP TABLE IF EXISTS `problem_reports` }); I think this could be destructive in some cases. I think checking for existence of the table is better: 20126 if ( !TableExists('return_claims') ) { 4) Capitalization catalog › Report a Problem Koha Administrator 5) print $input->redirect("/cgi-bin/koha/opac-reportproblem?norecipients=1.pl"); Looks like a typo with the .pl at the end? 6) Translatatability I these go in the email to the library/admin, but won't be translatable: + $problemreport->{code} = 'PROBLEM_REPORT'; + $problemreport->{content} .= "\nUsername: $username"; + $problemreport->{content} .= "\nProblem page: $place"; Using a notice template would be the most elegant way to make those translatable. I think with https://bugs.koha-community.org/bugzilla3/showdependencytree.cgi?id=15395&hide_resolved=1 you can not yet add strings to .pl fils in a translatable way. If I understand correctly the only way to access the reports for now would be a report? It might be nice (new bug!) to have this on the dashoard and visible in staff or even the patron account :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:55:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:55:12 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 18 23:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 22:59:28 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #25 from Aleisha Amohia --- Thanks Katrin I'll work on fixing those. The staff side follow-up was already in my plan: (In reply to Aleisha Amohia from comment #11) > After this feature is passed: > - i would like to add a staff-side feature where staff can see the > problem reports and mark them as 'read'. i'll work on that once this > gets through :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:00:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:00:05 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:01:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:01:39 +0000 Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:05:33 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #47 from David Cook --- (In reply to Kyle M Hall from comment #46) > koha_trusted_proxies is a config setting from the Koha conf xml file, so > mock_preference won't work on that. You'll want to use mock_config instead. > So obvious in the light of day hehe. Thanks, Kyle. Yesterday was a loooong day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:05:33 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #35 from Katrin Fischer --- QA tools pass without problems. Some smaller issues: 1) Capitalization Koha Patron Image Via Webcam

    Koha Patron Image Taker

    ... that's it so far :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:24:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:24:56 +0000 Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #40 from David Cook --- (In reply to John Sterbenz from comment #39) > This is a new issue to me (as of yesterday) on the 18.11 series on 18.04 > LTS. This process had worked for years prior (all the way back to 2016 / > 3.22 on 14.04)--now every load I try fails. > > I did upgrade my production server to 18.04 in preparation for installation > of the 19.05 series--that is the only difference (in terms of anything I've > directly initiated) between success and failure, yet the comments here > indicate this has been an issue for nearly 5 years and reported (at least > here) as recently as a few months ago. Prod was already running the 18.11 > series--it was only the OS I upgraded. > > Thanks to VM snapshots, I took my dev server back to 17.11 on 16.04 and > everything worked again, but that doesn't do me any good for production. > > This is the only way we load records--and do so to the tune of 260K-300K > records a month (in files of 20K records). Most of these records are > overlaid--perhaps only 1-2% are new records. We are at a standstill until > this is resolved or I identify some sort of workaround. > > I have not yet tried anything like a smaller file size since this was just > discovered yesterday by my staff in the course of regular work. I note the > mention of Plack (without having read the entire comment thread yet to see > if this is relevant/related or not) and have not turned that off for this > instance to see if that will matter. Based on what you've said, I suspect that your issue might be unrelated to this discussion. This issue is about running scripts like "stage-marc-import.pl" using Plack, but there has been a workaround, which is provided out of the box, for that for many years. I'd suggest that you look for support for your particular issue via https://koha-community.org/support/. For example, the mailing lists (https://koha-community.org/support/koha-mailing-lists/) and/or the #koha IRC channel. There we can run through a series of specific questions to help you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:38:25 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- >4) click the 'Take' button. > -- it is in the text area on the right, and not the > hover over the image area. Adding here would require > CSS changes, which are now difficult and ugly to do. Don't agree about this and don't feel it should be in a commit message and then in git... if you want to raise an issue, there are better ways. In general I think the page to take pictures needs some more work, it's quite a raw HTML page currently and doesn't fit well into Koha as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:41:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:41:59 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:42:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:42:50 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #69 from Katrin Fischer --- Hi Aleisha, this no longer applies, can you please rebase and run QA tools on the set? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8628: Digital signs - db changes Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 8628: Digital signs - db changes Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-Digital-signs---db-changes-T0d215.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 00:47:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Feb 2020 23:47:49 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:00:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:00:06 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- There is 2 places now where one can close the basket: - From the basket summary page. I totally agree with the new redirect there. - From the vendor search results list - This one I am not sure about. I think the old redirect works better there as it would allow you to quickly close multiple baskets. Jessica, as you signed off, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:09:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:09:31 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:12:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:12:56 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:13:13 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98598|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer --- Created attachment 99227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99227&action=edit Bug 11297: Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:13:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:13:28 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98599|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer --- Created attachment 99228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99228&action=edit Bug 11297: Add atomicupdate patch and modify kohastructure.sql Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:13:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:13:42 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98600|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer --- Created attachment 99229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99229&action=edit Bug 11297: Modify Z3950server schema file Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:13:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:13:59 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98601|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer --- Created attachment 99230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99230&action=edit Bug 11297: (follow-up) Add html filter to new input field Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:16:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:16:14 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #120 from Katrin Fischer --- Created attachment 99231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99231&action=edit Bug 11297: (QA follow-up) Make table headings match other pages - use Actions instead of Options The patch set adds a table hading for the Actions column on the summary page. If you compare with other pages, this should be labelled 'Actions' instead of 'Options'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:24:43 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #121 from Katrin Fischer --- Still missing tests... :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:27:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:27:31 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #110 from Katrin Fischer --- I just realized I gave this the first sign-off - so I am out for QA. But also, patch doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. Using index info to reconstruct a base tree... M C4/Biblio.pm M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt M koha-tmpl/intranet-tmpl/prog/js/cataloging.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11299-Add-a-button-to-the-biblio-edition-page--LuP6BI.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 01:31:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 00:31:49 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #9 from Katrin Fischer --- Currently BLOCKED by the dependency on bug 20307. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:16:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:16:15 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:16:18 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #2 from David Cook --- Created attachment 99232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99232&action=edit Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:16:21 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #3 from David Cook --- Created attachment 99233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99233&action=edit Bug 24538: Handle Net::Netmask parser errors This patch switches from the new() to new2() constructor, which will return an undef value when it fails to parse a value. This patch warns on parser failures, but otherwise silently drops the invalid value, and returns objects for any valid input it can parse. This way one mistake won't disable the whole feature. To test: 1. Run the unit test t/Koha/Middlware/RealIP.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:17:45 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #4 from David Cook --- I'd suggest applying the "Add unit tests..." patch first, running it, seeing the failures, and then applying the 2nd patch, and then running the unit test again (and seeing the successes). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:18:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:18:40 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #48 from David Cook --- (In reply to Martin Renvoize from comment #44) > Thanks David, that's great news. It only took me nearly 3 weeks but I finally got there heh. Unit test and bug fix available at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:50:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:50:51 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 03:50:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 02:50:54 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99064|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 99234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99234&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 07:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 06:09:51 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at koha-suomi.fi --- Comment #12 from paxed --- Comment on attachment 98932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98932 Bug 24608: Allow due date modification Is the "Edit" in checkouts.js untranslatable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 07:45:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 06:45:59 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #29 from Frédéric Demians --- There is somehow a regression with ES language facets compared to Zebra facets. Zebra language facet is decoded from LANG authorized values list. ES language facet (thanks to this patch) is decoded from language_* tables. But there are more languages defined in LANG authorized values list: all old languages for example, like grc = Ancient Greek (to 1453). Solution : add missing languages to language_* tables. But is it the purpose of those tables which are designed to allow Koha interface translation rather than storing MARC biblio records usable languages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:07:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:07:47 +0000 Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #41 from Mason James --- (In reply to John Sterbenz from comment #39) > This is a new issue to me (as of yesterday) on the 18.11 series on 18.04 > LTS. This process had worked for years prior (all the way back to 2016 / > 3.22 on 14.04)--now every load I try fails. > hi John you've probably hit the issue below... pay attention to your various 'tmp' dirs, and their owner/perm values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:52:37 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99176|0 |1 is obsolete| | --- Comment #174 from Ere Maijala --- Created attachment 99235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99235&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:52:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:52:42 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #175 from Ere Maijala --- Created attachment 99236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99236&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:52:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:52:48 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #176 from Ere Maijala --- Created attachment 99237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99237&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:52:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:52:53 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99178|0 |1 is obsolete| | --- Comment #177 from Ere Maijala --- Created attachment 99238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99238&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:52:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:52:59 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99179|0 |1 is obsolete| | --- Comment #178 from Ere Maijala --- Created attachment 99239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99239&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 08:54:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 07:54:07 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #179 from Ere Maijala --- Added a minimal patch to include holding_id in the item definition of the REST API. I'll defer actual API functionality to a later bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:05:51 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #17 from Jonathan Druart --- So, in your opinion, do we need both approaches or only one? (bug 24455 and bug 24650) I miss the real-life use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:13:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:13:12 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 --- Comment #5 from Jonathan Druart --- Tested on 19.05.06: * Create manual invoice, barcode=39999000018714, amount=12 * Create manual invoice, barcode=39999000018653, amount=23. Then pay it * Delete the 2 items * Accounting > Transactions => No crash You need to provide more detail on the error you have in the log, or what kind of transaction was associated to the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:26:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:26:02 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #30 from Katrin Fischer --- (In reply to Frédéric Demians from comment #29) > There is somehow a regression with ES language facets compared to Zebra > facets. Zebra language facet is decoded from LANG authorized values list. ES > language facet (thanks to this patch) is decoded from language_* tables. But > there are more languages defined in LANG authorized values list: all old > languages for example, like grc = Ancient Greek (to 1453). > > Solution : add missing languages to language_* tables. But is it the purpose > of those tables which are designed to allow Koha interface translation > rather than storing MARC biblio records usable languages? Afaik they are used to build the list of languages on advanced search and also the language options when you have different langaugaes installed. The big win of the tables currently is that they are transalatable/offer the language name in the language of the language (hope that makes sense). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:28:57 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #31 from Katrin Fischer --- That said - are you sure the langauge facet is in standard Koha for Zebra? I don't see a definition for it in getfacets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:31:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:31:03 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #13 from Katrin Fischer --- (In reply to paxed from comment #12) > Comment on attachment 98932 [details] [review] > Bug 24608: Allow due date modification > > Is the "Edit" in checkouts.js untranslatable? In the way it's done now it is not - it could be made translatable with bug 21156. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:31:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:31:54 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 --- Comment #10 from Andrew Isherwood --- Sounds like you did a better job of getting to the bottom of the problem than I did Jonathan! At least your patch has some reasoning behind it, whereas mine was just "I don't know why this works, but it does" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:32:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:32:49 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #5 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:33:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:33:25 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 --- Comment #7 from Andrew Isherwood --- Receiving ISO timestamps back from the API and needing to display them in the UI according to the format specified in the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:34:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:34:51 +0000 Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible with existing helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 --- Comment #8 from Andrew Isherwood --- Looking at bug 24455, it looks like it may make this redundant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:36:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:36:36 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #14 from Andrew Isherwood --- (In reply to paxed from comment #12) > Comment on attachment 98932 [details] [review] > Bug 24608: Allow due date modification > > Is the "Edit" in checkouts.js untranslatable? This is an oversight on my part, I should be using strings.inc as per the "Save" button. I'll create a patch to address this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:46:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:46:58 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #15 from Andrew Isherwood --- Created attachment 99240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99240&action=edit Bug 24608: (follow-up) Use strings.inc for "Edit" As per comment #14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:47:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:47:30 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:47:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:47:39 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- We now have a double signoff on this including my own.. I'll do a quick final check before pushing but I think we can safely say this is PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:51:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:51:02 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Is this 'just fines' or payments in general? If it's payments in general perhaps it should live under the new 'Accounting' tab instead, under the 'Policy' section? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:51:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:51:52 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrew.isherwood at ptfs-europ |jonathan.druart at bugs.koha-c |e.com |ommunity.org Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 09:52:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 08:52:04 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:21:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:21:47 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie --- Comment #3 from Holly --- This seems to still be an issue in 19.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:32:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:32:44 +0000 Subject: [Koha-bugs] [Bug 24680] New: Hold modification endpoints don't always work properly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Bug ID: 24680 Summary: Hold modification endpoints don't always work properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi PUT request to /api/v1/holds/{hold_id} requires the priority parameter (non-mandatory in the API spec) for the request to actually do anything and POST request to /api/v1/holds/{hold_id}/suspension without end_date improperly returns current date as the date. Patch coming up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:33:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:33:06 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:33:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:33:26 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:47:45 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:47:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:47:48 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #1 from Ere Maijala --- Created attachment 99241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99241&action=edit Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided Before this fix the endpoint would accept the request but fail to actually update the hold if the request does not contain a priority parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:47:51 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #2 from Ere Maijala --- Created attachment 99242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99242&action=edit Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint Before this patch the response would return current date as the suspension end date for a hold that is suspended with no end date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 10:49:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 09:49:31 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 10:14:58 +0000 Subject: [Koha-bugs] [Bug 24681] New: Branch address country is used for HEA as-is Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24681 Bug ID: 24681 Summary: Branch address country is used for HEA as-is Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr If you set the country address field for a branch, that text will be sent to HEA as the country where the branch is - but this is not useful for HEA, where the country statistics will get splintered between english-language name of the country vs localized name for the country. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:40:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 10:40:42 +0000 Subject: [Koha-bugs] [Bug 24682] New: Clarify UsageStatsGeolocation syspref description and behaviour Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Bug ID: 24682 Summary: Clarify UsageStatsGeolocation syspref description and behaviour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The syspref UsageStatsGeolocation needs to be improved, in couple ways: Perform value format checking (eg. there should be no spaces, no letters) OR Make the value read-only. AND Change the syspref description to mention this is edited in /cgi-bin/koha/admin/usage_statistics.pl (with a link to there, of course) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 11:50:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 10:50:46 +0000 Subject: [Koha-bugs] [Bug 24681] Branch address country is used for HEA as-is In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24681 --- Comment #1 from paxed --- Sort-of tangentially relevant is also bug 20281 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:16:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:16:16 +0000 Subject: [Koha-bugs] [Bug 24455] date formatting from JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #18 from Agustín Moyano --- (In reply to Jonathan Druart from comment #17) > So, in your opinion, do we need both approaches or only one? (bug 24455 and > bug 24650) I believe both do basically the same > I miss the real-life use case. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98630&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdsrecord.tt_sec1 In line 170, I use it to format dates retrieved from the API into datatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:19:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:19:04 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #98983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:33:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:33:53 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:33:55 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:33:57 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:33:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:33:59 +0000 Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:01 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:03 +0000 Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging preferences to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:05 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:07 +0000 Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:09 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:11 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 --- Comment #17 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:12 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:15 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #43 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:17 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:20 +0000 Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:22 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:24 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:25 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:27 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:29 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:31 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:33 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:34 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:36 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:38 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:39 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:41 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:43 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:45 +0000 Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:47 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:49 +0000 Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:51 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:53 +0000 Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title before surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:54 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:56 +0000 Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:34:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:34:58 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:00 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:02 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:04 +0000 Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required dependency but it is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:06 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b on OPAC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:08 +0000 Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b on OPAC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:10 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:13 +0000 Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be seen from the Patron Detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:15 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 12:35:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 11:35:17 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:08:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:08:48 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:08:53 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99232|0 |1 is obsolete| | Attachment #99233|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 99243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99243&action=edit Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:12:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:12:44 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99243|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 99244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99244&action=edit Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:13:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:13:09 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #7 from Kyle M Hall --- Created attachment 99245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99245&action=edit Bug 24538: Handle Net::Netmask parser errors This patch switches from the new() to new2() constructor, which will return an undef value when it fails to parse a value. This patch warns on parser failures, but otherwise silently drops the invalid value, and returns objects for any valid input it can parse. This way one mistake won't disable the whole feature. To test: 1. Run the unit test t/Koha/Middlware/RealIP.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:32:55 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #48 from Joonas Kylmälä --- These patches introduce new files without the GPL license header which is mandatory as per our coding guidelines: . The patches should be re-done so that there is the license header. Setting this as 'Failed QA' until this is resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:34:26 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24094 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:34:26 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24269 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:48:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:48:05 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99039|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 99246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99246&action=edit Bug 24269: Adjust C4::Heading to generate headings from auth tags To test: 1 - Be using Elasticsearch 2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields don't matter) 3 - Add a topic term authority record like "150 $aCats$vFiction" 4 - Add a 650 with $aCats and $vFiction and $e depicted to a bibliographic record 5 - Run the linker for the bib perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v 6 - Confirm the record is not correctly linked to the record 7 - Apply patch 8 - Reindex authorities for ES perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a 9 - Run the linker and confirm record is correctly linked perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:58:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:58:15 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:58:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:58:19 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95661|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 99247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99247&action=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 13:58:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 12:58:23 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #9 from Nick Clemens --- Created attachment 99248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99248&action=edit Bug 23482: Remove conditional from BEGIN block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:19:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:19:18 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98572|0 |1 is obsolete| | --- Comment #111 from Bouzid Fergani --- Created attachment 99249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99249&action=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:21:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:21:32 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:22:00 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #112 from Bouzid Fergani --- Hi Kat, The patch it's apply correctly now. Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:35:16 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:35:19 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:52:37 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:52:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:52:40 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #13 from Owen Leonard --- Created attachment 99250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99250&action=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 14:56:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 13:56:23 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Owen Leonard --- (In reply to Jonathan Druart from comment #10) > Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png > Also, the style looks weird (I did yarn build --view opac): My follow-up should correct these mistakes. > And the popup does not display for the non XSLT view (new search is launched > instead). I don't see this problem. I believe the popup displays in all cases where it did previously, which excepts the "magnifying glass" link which links directly to an authority search. Can you re-test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:02:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:02:50 +0000 Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when total holds unlimited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 --- Comment #9 from Jonathan Druart --- Created attachment 99251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99251&action=edit Bug 24669: Fix selenium test There is one more "Unlimited" on the circ rules now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:09:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:09:17 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:09:21 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98605|0 |1 is obsolete| | Attachment #98611|0 |1 is obsolete| | --- Comment #27 from Agustín Moyano --- Created attachment 99252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99252&action=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:09:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:09:26 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #28 from Agustín Moyano --- Created attachment 99253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99253&action=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:11:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:11:17 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #29 from Agustín Moyano --- (In reply to David Nind from comment #26) > After all that, 1 test failed for me! > > root at 5bbe8b290c9a:koha(bz24502)$ prove t/Koha/REST/Plugin/Query.t > t/db_dependent/Koha/REST/Plugin/Objects.t > t/Koha/REST/Plugin/Query.t ................. 3/6 > # Failed test '200 OK' > # at t/Koha/REST/Plugin/Query.t line 314. > # got: '500' > # expected: '200' > > # Failed test 'exact match for JSON Pointer "/-and"' > # at t/Koha/REST/Plugin/Query.t line 314. > # Structures begin differing at: > # $got = undef > # $expected = ARRAY(0x5564a4153a48) > # Looks like you failed 2 tests of 3. > > # Failed test '/merge_q_params' > # at t/Koha/REST/Plugin/Query.t line 357. > # Looks like you failed 1 test of 6. > t/Koha/REST/Plugin/Query.t ................. Dubious, test returned 1 (wstat > 256, 0x100) > Failed 1/6 subtests > t/db_dependent/Koha/REST/Plugin/Objects.t .. ok > > Test Summary Report > ------------------- > t/Koha/REST/Plugin/Query.t (Wstat: 256 Tests: 6 Failed: 1) > Failed test: 4 > Non-zero exit status: 1 > Files=2, Tests=14, 25 wallclock secs ( 0.06 usr 0.01 sys + 21.66 cusr 3.74 > csys = 25.47 CPU) > Result: FAIL Hi David, sorry for the delay. Now it should work ok. Thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:18:42 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #3 from Agustín Moyano --- Dependency 24502 was in Failed QA state. Patches now apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:19:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:19:30 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:24:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:24:08 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98624|0 |1 is obsolete| | --- Comment #3 from Agustín Moyano --- Created attachment 99254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99254&action=edit Bug 24561: Datatables api wrapper also filter and order embedded columns This patch adds the ability to filter and order by embedded columns. To use it you must in JS: $('datatable_selector').api({datatables_options}) where datatables_options are all datatables options plus: 1. embed: [list of embeddable tables] This option adds x-koha-embed header to request. 2. header_filter: true|false This option if true sets x-koha-query header with stringyfied json of filters Oderable and searchable columns must define data option as string, otherwise filter and order won't be possible. If you must custom the output, use the render function. For example: * Don't > $('.table_selector').api({ > columns: [ > { > data: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); * Do > $('.table_selector').api({ > columns: [ > { > data: 'holds.patron.firstname', > render: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); To test you must implement and test bug 20936, where it will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:35:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:35:25 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99254|0 |1 is obsolete| | --- Comment #4 from Agustín Moyano --- Created attachment 99255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99255&action=edit Bug 24561: Datatables api wrapper also filter and order embedded columns This patch adds the ability to filter and order by embedded columns. To use it you must in JS: $('datatable_selector').api({datatables_options}) where datatables_options are all datatables options plus: 1. embed: [list of embeddable tables] This option adds x-koha-embed header to request. 2. header_filter: true|false This option if true sets x-koha-query header with stringyfied json of filters Oderable and searchable columns must define data option as string, otherwise filter and order won't be possible. If you must custom the output, use the render function. For example: * Don't > $('.table_selector').api({ > columns: [ > { > data: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); * Do > $('.table_selector').api({ > columns: [ > { > data: 'holds.patron.firstname', > render: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); To test you must implement and test bug 20936, where it will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:39:43 +0000 Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 --- Comment #5 from Agustín Moyano --- I don't know why, but when applying this bug with git bz, bug 20212 doesn't appear as an option. Maybe it's because is in state "ASSIGNED" To succesfully apply this bug, first apply 20212 manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 15:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 14:45:04 +0000 Subject: [Koha-bugs] [Bug 18386] Renew message in Default messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:03:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 15:03:48 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #7 from Agustín Moyano --- For some reason, automatic dependency resolution of git bz doesn't show bug 20212 (that ist's a dependency of 24561) as an option to apply. To successfuly apply this patch, first apply 20212 manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 15:25:41 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Augustin - it's because it's ASSIGNED I think - not NSO or SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:55:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 15:55:05 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:55:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 15:55:08 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95984|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 99256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99256&action=edit Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: where and are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 16:56:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 15:56:21 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Signed Off |Failed QA --- Comment #113 from Joonas Kylmälä --- I think it would have been beneficial to split this patch (as cait also suggested in the bug report) since there seems to be at least two logical changes. This would also increase the chances people have the time to sign-off and QA the patches. This is not a comprehensive review but I noticed this introduces new subroutine GetRecordValue which is a) not used at all b) doesn't appear to be functional since the DB table it uses doesn't exists. Also MARC::Field module is used without importing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:03 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #114 from Joonas Kylmälä --- It also appears that the new sub AddAuthorityFromHeading() should go at least to C4/AuthoritiesMarc.pm because it has nothing to do with biblio(?). It would be even better if it was in a Koha object since C4 namespace is being deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:47 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:49 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #23 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:51 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:54 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #122 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:56 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:12:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:12:58 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #45 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:00 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:02 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:04 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:06 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:08 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:10 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #34 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:12 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:13:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:13:14 +0000 Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:19:32 +0000 Subject: [Koha-bugs] [Bug 24683] New: Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Bug ID: 24683 Summary: Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: hans.palsson at hkr.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 99257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99257&action=edit An example of a biblio with mixed itemtype items. When having different rules for placing holds for each item type, having both item types on one biblio "breaks" these rules. As shown in the attachment: Smart rules for item type "Course literature" allows patrons to place holds on items. The smart rules for the item type "Dayloan" does not allow patrons to place holds on the items. When having both item types on one biblio, it should in theory be possible to place a hold on biblio level even if the dayloan item type is available. Setting the option "AllowHoldItemTypeSelection" to allow does not solve the problem. Various other options have been tried, but as long as there is an available item that is not "not for loan", then placing holds is not possible. This is troublesome for us, since holds must be placed manually by staff. The Dayloan item type is for having a copy available for many students and should not be placed on hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:40:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:40:56 +0000 Subject: [Koha-bugs] [Bug 24684] New: Adding text "Address: 1" as circulation note makes field disappear - moremember.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24684 Bug ID: 24684 Summary: Adding text "Address: 1" as circulation note makes field disappear - moremember.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Edit patron record Add the text Address: 1 into the circulation note field Save record Circulation note is not visible. Also, in editing the record, the field is not available to edit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:41:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:41:27 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98899|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 99263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99263&action=edit Bug 23571: Add flock to fines.pl This patch adds a lock file for fines.pl. To test: 1. Apply this patch 2. In two separate consoles run misc/cronjobs/fines.pl SUCCESS => The first one runs normally, but the second one fails with a message flock failed for the lock file. 3. Sign off. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:57:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:57:45 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99263|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 99264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99264&action=edit Bug 23571: Add flock to fines.pl This patch adds a lock file for fines.pl. To test: 1. Apply this patch 2. In two separate consoles run misc/cronjobs/fines.pl SUCCESS => The first one runs normally, but the second one fails with a message flock failed for the lock file. 3. Sign off. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 17:57:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 16:57:48 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #8 from Martin Renvoize --- Created attachment 99265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99265&action=edit Bug 23571: (follow-up) Only look for overdues after obtaining the lock No point in performing the overdues fetch before obtaining the lock and knowing we can do something with them. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:03:27 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #9 from Martin Renvoize --- Comment on attachment 99264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99264 Bug 23571: Add flock to fines.pl Review of attachment 99264: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23571&attachment=99264) ----------------------------------------------------------------- So, this generally looks pretty good to me.. However... I'd love to see the locking mechanisms factored out into the Koha::Script base class so we could share the common code between command-line scripts and make adding flocking elsewhere a simple pattern to follow. Would you be willing to have a go at that Agustin? ::: misc/cronjobs/fines.pl @@ +82,5 @@ > cronlogaction(); > > +my ($lockfile, $LockFH); > +foreach ( > + '/var/lock/koha', How did you come up with these locations? I note in the equivalent in rebuild_zebra.pl we use a config variable, followed by a fallback order... I actually like the idea of using /var/lock/koha but I'm not sure I understand where if came from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:05:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:05:50 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:06:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:06:10 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:06:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:06:19 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:07:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:07:57 +0000 Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column name "Pending order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98583|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 99266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99266&action=edit Bug 17611: Change 'Pending order' to 'Quantity ordered' Picking Quantity ordered as it seems more in line with other pages in Koha where we show information. We always show the quantity, so it makes sense to also have this label on the 'order search' and 'copy existing order'. Order search 1) Make sure you have some orders in your acq module 2) Go to the top and do an empty orders search 3) Review the column headings of the search results 4) Find "Pending order" Order from existing order (copy) 1) Create or choose an existing open basket 2) 'Add to basket' - 'From existing orders' 3) Search to find some of your orders 4) Look at the column headings, find 'Pending order' 5) Pick some orders and fill out order information, save 6) Summary: Find 'Pending order' in the table again x) Apply the patch and make sure all 'Pending' orders above have been changed to 'Quantity ordered'. Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:08:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:08:18 +0000 Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column name "Pending order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- String fix.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:09:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:09:36 +0000 Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:34:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:34:34 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #115 from Nick Clemens --- Overall this works and I agree, it is a much desired functionality. Test plan missing step: Must enable BiblioAddsAuthorities Blockers: When creating a new record the popup does not close / links not added automatically The record is saved an picked up if I relink sub AddAuthorityFromHeading - can this just be an option for AddAuthority? I don't understand why it is in C4/Biblio.pm - it checks the heading for things like 'series_added_entry' - i cannot identify where in the code these are being set sub GetRecordValue - added but not used? Change to POD in Linker.pm doesn't seem to have corresponding code change? Why a change to default linker behavior? -if ( $behavior eq 'default' && $#{$authorities} == 0 ) { +if ( $behavior eq 'default' && $#{$authorities} >= 0 ) { automatic_linker.pl - duplicates a lot of code from C4/Biblio->BiblioAutoLink - we should rather pass verbose option through that sub - should this be in svc? I am a bit confused about new param biblioindex vs index, we only ever seem to pass index, unless I missed something here Without edit authorities permission I get a warning that I cannot use the 'Link authorities automatically' button - I shouldn't see it if I can't use it As has been noted, test coverage is needed for changes to modules Other improvement, could be on new bug: 1 - This doesn't work with the advanced cataloging editor - code should be made flexible enough that can be done 2 - If links are changed they become green - if button clicked again they are not green - may not be obvious that I still need to save changes - i think a second run should preserve what was changed since the record was opened/created. 3 - The notice about links should show the headings that were linked/not-linked otherwise it can be confusing which individual 650 had an issue - colors are nice but we should no rely only on colors for accessibility 4 - The js uses hardcoded styles for colors - can this be made css so the js just adds a class, would allow easier override by users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:51:36 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84526|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 99267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99267&action=edit Bug 20582: Turn Koha into a Mojolicious application This patch is a proof-of-concept of Koha as a Mojolicious application This has several benefits: - Development setup is easier. No need for apache or nginx. Just run `morbo bin/intranet` or `morbo bin/opac` and go to http://localhost:3000 (URL rewrites and static files are handled by the app) - apache2/nginx configuration is simpler too (an example of nginx configuration is included in the patch) - starman and plack middlewares can still be used for debug or gzip compression for instance (see app.psgi) - Using Test::Mojo we can test the whole application, as we do with the REST API (which is a Mojolicious application too) - It opens a way for converting CGI scripts into Mojolicious controllers and actions (even if that's not possible at the moment because of the authentication code) It uses the same mechanism as Plack::App::CGIBin to deal with CGI scripts, so it should be equivalent in terms of performance How to test ? - Run `morbo bin/intranet`, then go to http://localhost:3000/ and try to find bugs. Check the REST API at http://localhost:3000/api/v1 - Run `morbo bin/opac`, then go to http://localhost:3000/ and try to find bugs. Check the REST API at http://localhost:3000/api/v1 - Run `starman -l :5000 -l :5001` and verify that intranet (http://localhost:5000) and opac (http://localhost:5001) work normally - Read the code (and the comments), it's not very long -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:15 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:18 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:22 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:26 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:30 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:52:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:52:36 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:56:42 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 --- Comment #7 from Nick Clemens --- I read this one over, looked at code and looked at an affected site - this should resolve the issue and prevent further. I didn't test with actual data but feel confident this should do what is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 18:59:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 17:59:32 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #50 from Julian Maurice --- I squashed all patches, added the missing license headers, and made small changes to emphasize the fact that opac and intranet are two different apps. This makes the patch smaller and removes one of the FIXMEs. I also had to fix OPAC login when running app.psgi with starman (see comment in Koha::App::Plugin::CGIBinKoha::_psgi_env) Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:23:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 18:23:52 +0000 Subject: [Koha-bugs] [Bug 24685] New: history.txt - entry for epoch 978712245 is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24685 Bug ID: 24685 Summary: history.txt - entry for epoch 978712245 is misaligned Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: sacha+koha at ssl.co.uk On https://koha-community.org/about/history/ the entry for 978712245 has a date which bleeds into the adjacent column and pushes the table out. While you're in there... a few rows above that a release event is tagged with "award". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:30:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 18:30:57 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 19:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 18:31:00 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 --- Comment #1 from Lucas Gass --- Created attachment 99268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99268&action=edit Bug 23547: Add column configuration to course reserves table in the OPAC This patch adds opac-course-reserves to the column config tool TEST PLAN: 1. Have some course reserves and go look at opac-course-reserves.pl 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > course_reserves_table 5. Try hiding each column and make sure the correct column is hidden on opac-course-reserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 19:09:51 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 19:09:51 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24054 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 19:11:11 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 --- Comment #7 from Kyle M Hall --- This should be reverted from 19.05 and 18.11, those version do not have the Claims Returned feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 20:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 19:31:40 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #5 from Lisette Scheer --- When I try to load the page, I get this message: Could not compile /home/vagrant/kohaclone/admin/smart-rules.pl: Global symbol "$rules" requires explicit package name (did you forget to declare "my $rules"?) at /home/vagrant/kohaclone/admin/smart-rules.pl line 584. Global symbol "$rules" requires explicit package name (did you forget to declare "my $rules"?) at /home/vagrant/kohaclone/admin/smart-rules.pl line 595. BEGIN not safe after errors--compilation aborted at /home/vagrant/kohaclone/admin/smart-rules.pl line 633. at /usr/share/perl5/CGI/Compile.pm line 132 I reset_all and dbic and yarn build but still get this message. Is there another command I'm missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:00:10 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:00:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:00:12 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98943|0 |1 is obsolete| | Attachment #98944|0 |1 is obsolete| | Attachment #98945|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 99269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99269&action=edit Bug 23727: Add new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:00:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:00:20 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #14 from Kyle M Hall --- Created attachment 99270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99270&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:00:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:00:23 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #15 from Kyle M Hall --- Created attachment 99271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99271&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:00:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:00:26 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #16 from Kyle M Hall --- Created attachment 99272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99272&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:17:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:17:37 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99269|0 |1 is obsolete| | Attachment #99270|0 |1 is obsolete| | Attachment #99271|0 |1 is obsolete| | Attachment #99272|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 99273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99273&action=edit Bug 23727: Add new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:17:45 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #18 from Kyle M Hall --- Created attachment 99274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99274&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:17:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:17:49 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #19 from Kyle M Hall --- Created attachment 99275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99275&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:17:52 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #20 from Kyle M Hall --- Created attachment 99276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99276&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:31:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:31:04 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99276|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 99277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99277&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 21:43:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 20:43:17 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 --- Comment #8 from Hayley Mapley --- Thanks Kyle, I followed the test plan but forgot to check for the system preference before I applied the patch! Commit has been reverted in 18.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:00:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:00:42 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:00:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:00:45 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99082|0 |1 is obsolete| | --- Comment #6 from Lisette Scheer --- Created attachment 99278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99278&action=edit Attachment to Bug 24670 - Circulation and fine rules page has performance issues since issuingrules change Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:02:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:02:18 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #7 from Lisette Scheer --- I went back later and it worked this time. Much faster now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:08:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:08:57 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:08:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:08:59 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98734|0 |1 is obsolete| | --- Comment #4 from Benjamin Daeuber --- Created attachment 99279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99279&action=edit Bug 24637: Add brancode in all pay circumstances Signed-off-by: Benjamin Daeuber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:17:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:17:01 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #8 from Martin Renvoize --- Created attachment 99280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99280&action=edit Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:17:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:17:32 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #99278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:18:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:18:31 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- This makes a big difference on my test system, thanks for the quick work guys. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:23:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:23:52 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:26:30 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Martin Renvoize --- Ooops.. false positive there.. had the wrong branch checked out. I see the same error as Lisette I'm afraid.. looks like $rules is defined in a local scope but then assigned to in a global one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:33:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:33:24 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99280|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 99281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99281&action=edit Bug 24670: Fetch all circulation rules at once to fix perf regression Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:33:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:33:28 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #12 from Martin Renvoize --- Created attachment 99282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99282&action=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:34:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:34:49 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Martin Renvoize --- Now it's looking good to me.. Setting back to SO as I'd like Jonathan to check my followup.. seems strange it was missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:41:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:41:07 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #30 from Katrin Fischer --- Hi Johanna, can you please rebase? Small thing:
  • Print checked-in today -slip
  • I think I'd just label that as 'Print checkin slip' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:45:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:45:48 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99244|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 99283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99283&action=edit Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:45:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:45:51 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99245|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 99284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99284&action=edit Bug 24538: Handle Net::Netmask parser errors This patch switches from the new() to new2() constructor, which will return an undef value when it fails to parse a value. This patch warns on parser failures, but otherwise silently drops the invalid value, and returns objects for any valid input it can parse. This way one mistake won't disable the whole feature. To test: 1. Run the unit test t/Koha/Middlware/RealIP.t Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:46:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:46:27 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Cheers guys, Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:48:17 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:49:40 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99279|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99285&action=edit Bug 24637: Add brancode in all pay circumstances To TEST: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL 4. Apply patch and restart_all 5. Make a partial payment using both the Pay select and Pay amount buttons. 6. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 7. Now you should see the branchcodes in the table and no NULL values. Signed-off-by: Benjamin Daeuber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:50:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:50:08 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Works as expected.. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:53:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:53:23 +0000 Subject: [Koha-bugs] [Bug 24686] New: Capturing circulation statistics per number of items in an item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Bug ID: 24686 Summary: Capturing circulation statistics per number of items in an item Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A library would like to see a possible enhancement to Koha. If a DVD has 5 discs in the item, when this item (with 5 dvds) is circulated- they would like Koha to count this circulation as 5 issues (as in each of the items included in the 1 main item) was circulated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:56:42 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #110 from Katrin Fischer --- Hi Maryse, small failure in the QA script: 1) QA script FAIL installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column categories.canbeguarantee is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline The first could be fixed by squashing the patches in question, but should only be done if they got the same author/tester lines. 2) Quick code review Looks good so far, will continue testing with the follow-ups (switch back to signed-off) Note: I feel that GuarantorFields and "Shows guarantees' fines in the guarantor's page" should have been separate features/bugs - they add even more code to check and work through and make this this harder to test and harder to advertise/document. The bug title/description is actually not what this patch does, but is what will show up in release notes. - Too late now I guess, but I think it's part of the reason this has not been moving as fast as hoped for. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:56:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:56:55 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 22:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 21:58:47 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Owen, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1347) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:15:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:15:01 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer --- Hi Nicolas, starting with QA review here: 1) QA test tools Possibly a false positive: FAIL Koha/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Desks.pm FAIL pod coverage POD is missing for 'object_class' Possibly a false positive: FAIL Koha/Schema/Result/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc FAIL filters missing_filter at line 3 (

    [% LibraryName %]

    ) missing_filter at line 7 (
    ) missing_filter at line 8 ( ) FAIL forbidden patterns forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 28) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt FAIL filters missing_filter at line 79 ( ) missing_filter at line 79 ( ) missing_filter at line 81 ( ) missing_filter at line 81 ( ) 2) Quick code review admin/desks.pl Are the copyright statements correct? +# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN +# Copyright 2015 Koha Development Team Leftover debugging code: +use Data::Dumper; The new page requires a new permission: manage_desks + flagsrequired => { parameters => 'manage_desks' }, But the new permission is not properly added. It looks like maybe you were planning to use manage_libraries here instead? Check: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:15:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:15:31 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #35 from Katrin Fischer --- Also missing tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:15:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:15:57 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99282|0 |1 is obsolete| | --- Comment #14 from Lisette Scheer --- Created attachment 99286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99286&action=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:22:32 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #60 from Katrin Fischer --- False positive ;) FAIL spelling Sheat ==> Sheath, sheet, cheat Testing further... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:30:49 +0000 Subject: [Koha-bugs] [Bug 18024] Adding a "genres/ form term" search in Authorities module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #3 from Heather --- This would save so much time if it were added; it is a wonderful way to import authorities, but the fact that we can't use it for "Genre/Form Term" means that we must save Genre/Form authority records & then import them into Koha via the much slower "Stage MARC records..." workflow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:37:55 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #61 from Katrin Fischer --- Notes: - Pref appears on Search/OpenUrl - I think move up by one: Features - Test plan and commit message needs a little update: * Run yarn build --view opac * Mention OpacBrowseSearch system preference ... ? - Capitalization: Really Fuzzy As the QA queue is really full right now, I will leave the follow-ups to the devs right now. But they should be quick and I will come back asap! Improvement ideas (separate bugs): - Show number of records for each list entry - It would be cool if you could move up and down list entries with the arrow keys, making it quick move between entries and see linked records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:41:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:41:02 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #11 from Heather --- Could there be some way to choose this or not (e.g., syspref)? We are an OCLC library, and retain the OCLC record number in the 001 when importing authorities as our primary key; we match and replace authority records on the 010 field (Library of Congress Control Number). We (and perhaps other OCLC users) would definitely not want the OCLC number data moved out of the 001 field and into the 035 upon import. (The 001 also contains the OCLC record number in our bibs.) Could the desired moving of 001 data to 035 be accomplished with the new MARC modification templates capabilities upon record import? (So then maybe this enhancement isn't needed?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:45:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:45:54 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:45:57 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98631|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 99287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99287&action=edit Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:46:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:46:01 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98632|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 99288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99288&action=edit Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:46:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:46:05 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98633|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 99289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99289&action=edit Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:46:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:46:09 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #20 from Katrin Fischer --- Created attachment 99290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99290&action=edit Bug 14647: Make spelling in file format pull downs match While bibliographic had XML and MARC, authorities had xml and marc in the pull down. This just makes both the same. To test: - Look at the pull downs on both tabs and verify they are now using the same spelling Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 19 23:58:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 22:58:40 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer --- Hi Aleisha, can you please take a look at David'd comment#95? I also got a lot of fails with the QA tools for missing filters :( FAIL koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc FAIL filters missing_filter at line 4 (
  • First
  • ) missing_filter at line 6 (
  • Previous
  • ) missing_filter at line 12 (
  • [% PAGE_NUMBER.pg | html %]
  • ) missing_filter at line 16 (
  • Next
  • ) missing_filter at line 17 (
  • Last
  • ) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL filters missing_filter at line 274 ( Results per page: [% results_per_page %] ) missing_filter at line 281 ( [% END %] Library default: [% Koha.Preference('numSearchResults') %]) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc FAIL filters wrong_html_filter at line 6 (
  • First
  • ) missing_filter at line 6 (
  • First
  • ) wrong_html_filter at line 7 (
  • Previous
  • ) missing_filter at line 7 (
  • Previous
  • ) wrong_html_filter at line 13 (
  • [% PAGE_NUMBER.pg | html %]
  • ) missing_filter at line 13 (
  • [% PAGE_NUMBER.pg | html %]
  • ) wrong_html_filter at line 17 (
  • Next
  • ) missing_filter at line 17 (
  • Next
  • ) wrong_html_filter at line 18 (
  • Last
  • ) missing_filter at line 18 (
  • Last
  • ) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL filters missing_filter at line 172 ( ) missing_filter at line 172 ( ) missing_filter at line 174 ( ) missing_filter at line 174 ( ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:01:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:01:19 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:15:38 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Owen Leonard --- (In reply to Katrin Fischer from comment #15) > forbidden pattern: Contains old bootstrap style for buttons (see bug It's a false positive. That check doesn't apply to OPAC templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:16:25 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #17 from Katrin Fischer --- Thx! I'll try to come back to this one in my next QA session (not mad if someone beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:17:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:17:33 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 --- Comment #8 from Katrin Fischer --- Asked Kyle to take a look here and he wanted to get some libraries to take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:28:38 +0000 Subject: [Koha-bugs] [Bug 24687] New: Installation errors in Koha-common Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Bug ID: 24687 Summary: Installation errors in Koha-common Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: jwboulier at sbcglobal.net QA Contact: testopia at bugs.koha-community.org Getting errors about unable to locate Koha configuration file koha-conf.xml at line 245. /usr/share/koha/lib/C4/Context.pm. (Repeated 4 times) Can't call method "config" on unblessed reference at /usr/share/koha/lib/Koha/Database/pm line 56. Setting up koha-common (19.11.02-1) ... failed to load external entity "/etc/koha/sites/jack/koha-conf.xml" Upgrading database schema for jack unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245. Can't call method "config" on unblessed reference at /usr/share/koha/lib/Koha/Database.pm line 56. dpkg: error processing package koha-common (--configure): installed koha-common package post-installation script subprocess returned error exit status 2 Errors were encountered while processing: koha-common E: Sub-process /usr/bin/dpkg returned an error code (1) Using a Dell 7500, 6 core 48 Gig of ram, Mint 19.3 Cannot load any Koha software. Attempted a live DVD. Does not respond to the install software from the admin menu, Following instructions from the Live DVD. Why is this software so difficult to install? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 00:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Feb 2020 23:38:27 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of items in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 01:22:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 00:22:34 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 02:36:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 01:36:29 +0000 Subject: [Koha-bugs] [Bug 24688] New: Hold priority isn't adjusted correctly if checking out a middle priority hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Bug ID: 24688 Summary: Hold priority isn't adjusted correctly if checking out a middle priority hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. So the priorities have not been adjusted to be consecutive which can cause problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 02:44:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 01:44:15 +0000 Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 02:44:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 01:44:18 +0000 Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 --- Comment #1 from Aleisha Amohia --- Created attachment 99291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99291&action=edit Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 02:44:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 01:44:29 +0000 Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if checking out a middle priority hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 02:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 01:52:49 +0000 Subject: [Koha-bugs] [Bug 22302] ITEMTYPECAT description doesn't fall back to description if OPAC description is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22302 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:01:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 03:01:51 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:01:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 03:01:55 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99060|0 |1 is obsolete| | --- Comment #62 from Nick Clemens --- Created attachment 99292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99292&action=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Apply patches 2 - Update database (updatedatabase on kohadevbox) 3 - Compile the CSS https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client yarn build --view=opac on kohadevbox 4 - Enable the new syspref OpacBrowseSearch 5 - Have ES running and some records in it SearchEngine syspref set to Elasticsearch 6 - Browse to opac home, click 'Browse search' link for your site) 7 - Test searching for author, title, and subject 8 - Verify that results are returned in expected order 9 - Experiment with fuzziness https://www.elastic.co/guide/en/elasticsearch/reference/5.6/common-options.html#fuzziness Options are: exact (0 edits), fuzzy (1 edit), very fuzzy (2 edits) 10 - Click any result and verify specific titles are correct 11 - Click through title to record and verify it is the correct record 12 - Test that disabling pref removes the link on the opac home Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:28:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 03:28:51 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 03:28:54 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99234|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 99293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99293&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 04:47:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 03:47:37 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z --- Comment #19 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:02:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 04:02:52 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #11 from David Cook --- Thanks for the quick turnaround on this, guys. Really appreciated. I love Koha::Middleware::RealIP, so glad I was able to contribute :D. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 05:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 04:05:36 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #123 from David Cook --- Reminds me how I really should work on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 one of these days 😅 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 06:46:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 05:46:20 +0000 Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 06:47:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 05:47:06 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 06:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 05:50:28 +0000 Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 --- Comment #3 from AspenCat Team --- If alphabetical sort by title is not correct (in that it ignores the 245 second indicator) it should not be offered as an option as it is misleading. One usually sorts by title because there are more records than can easily be reviewed in one page. I have been misled! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:17:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:17:42 +0000 Subject: [Koha-bugs] [Bug 24689] New: Fix missing 'hold' class regression from BZ 23903 (19.11.x) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Bug ID: 24689 Summary: Fix missing 'hold' class regression from BZ 23903 (19.11.x) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org This trival patch replaces the missing 'hold' class, regressed in BZ 23903 (19.11.x) This issue have been fixed in master :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:17:56 +0000 Subject: [Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:17:56 +0000 Subject: [Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:20:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:20:47 +0000 Subject: [Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 --- Comment #1 from Mason James --- Created attachment 99294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99294&action=edit Bug 24689: Fix missing 'hold' class regression from BZ 23903 (19.11.x) this trival patch replaces the missing 'hold' class, regressed in BZ 23903 (19.11.x) this issue have been fixed in master :) test plan.. 1/ apply patch, 2/ observe missing hold class exists (pic attached) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:51:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:51:06 +0000 Subject: [Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Mason James --- aah, it seems the hold claas has been intentionally removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:56:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:56:23 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|After adding manual invoice |Add 'Save and pay' button |redirect to pay tab instead |to use after adding a |of account tab |manual invoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:59:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:59:02 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 07:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 06:59:06 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98610|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 99295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99295&action=edit Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create manual invoice for any patron and click on "Save", you should be redirected to Account tab 2. Create manual invoice for any patron and click on "Save and pay", you should be redirected to Account tab Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:02:13 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #18 from Katrin Fischer --- hi Owen, sorry, just realized it was even in the test plan: Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:05:36 +0000 Subject: [Koha-bugs] [Bug 24690] New: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug ID: 24690 Summary: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org As noted in bug 13327 this feature doesn't work when the selected search terms contain (). No results will be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:05:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:05:44 +0000 Subject: [Koha-bugs] [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:06:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:06:11 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:06:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:06:11 +0000 Subject: [Koha-bugs] [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:07:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:07:11 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:07:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:07:14 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99002|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 99296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99296&action=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:07:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:07:18 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99250|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 99297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99297&action=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:10:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:10:16 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:10:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:10:21 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99292|0 |1 is obsolete| | --- Comment #63 from Katrin Fischer --- Created attachment 99298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99298&action=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Apply patches 2 - Update database (updatedatabase on kohadevbox) 3 - Compile the CSS https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client yarn build --view=opac on kohadevbox 4 - Enable the new syspref OpacBrowseSearch 5 - Have ES running and some records in it SearchEngine syspref set to Elasticsearch 6 - Browse to opac home, click 'Browse search' link for your site) 7 - Test searching for author, title, and subject 8 - Verify that results are returned in expected order 9 - Experiment with fuzziness https://www.elastic.co/guide/en/elasticsearch/reference/5.6/common-options.html#fuzziness Options are: exact (0 edits), fuzzy (1 edit), very fuzzy (2 edits) 10 - Click any result and verify specific titles are correct 11 - Click through title to record and verify it is the correct record 12 - Test that disabling pref removes the link on the opac home Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:13:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:13:24 +0000 Subject: [Koha-bugs] [Bug 24691] New: OpacBrowseSearch: Show number of results behind each list entry Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 Bug ID: 24691 Summary: OpacBrowseSearch: Show number of results behind each list entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Depends on: 14567 When using the new OpacBrowseSearch feature from bug 14567 it would be great if the number of results showed behind each list entry when browsing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:13:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:13:24 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 [Bug 24691] OpacBrowseSearch: Show number of results behind each list entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:16:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:16:00 +0000 Subject: [Koha-bugs] [Bug 24692] New: OpacBrowseSearch: enable navigating result list with arrow keys Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Bug ID: 24692 Summary: OpacBrowseSearch: enable navigating result list with arrow keys Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With the new OpacBrowseSearch feature from bug 14567 a list of authors, titles or subjects will show. When clicking on an entry, the records linked to it will show on the right of the list. It would be nice if jumping between entries was possible using the arrow keys (up and down). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:16:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:16:07 +0000 Subject: [Koha-bugs] [Bug 24692] OpacBrowseSearch: enable navigating result list with arrow keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:16:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:16:07 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 [Bug 24692] OpacBrowseSearch: enable navigating result list with arrow keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:37:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:37:48 +0000 Subject: [Koha-bugs] [Bug 24693] New: GD is declared as an optional dependency but Koha dies without it Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bug ID: 24693 Summary: GD is declared as an optional dependency but Koha dies without it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:38:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:38:18 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #1 from Julian Maurice --- Created attachment 99299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99299&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:38:27 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:48:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:48:21 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #21 from Jonathan Druart --- I wanted to get back to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:48:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:48:25 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:56:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:56:25 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:56:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:56:28 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99286|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 99300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99300&action=edit Bug 24670: (QA follow-up) Add missing $rules definition Signed-off-by: Martin Renvoize Signed-off-by: Lisette Scheer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:56:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:56:37 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:57:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:57:18 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #16 from Jonathan Druart --- (In reply to Martin Renvoize from comment #13) > Now it's looking good to me.. Setting back to SO as I'd like Jonathan to > check my followup.. seems strange it was missed. Oops, I have the bad habit to modify my patches after I already tested them. I guess I renamed something just before attaching it here, sorry about that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 08:59:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 07:59:02 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:07:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:07:40 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #22 from Jonathan Druart --- > Note that OPACPopupAuthorsSearch feature has a problem with terms > containing parentheses. The issue predates this patch. To avoid that, should not we search using the id instead of the string? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:27:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:27:28 +0000 Subject: [Koha-bugs] [Bug 24687] Installation errors in Koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Mason James --- (In reply to jwboulier from comment #0) > Getting errors about unable to locate Koha configuration file koha-conf.xml > at line 245. /usr/share/koha/lib/C4/Context.pm. (Repeated 4 times) > > Can't call method "config" on unblessed reference at > /usr/share/koha/lib/Koha/Database/pm line 56. > Setting up koha-common (19.11.02-1) ... > failed to load external entity "/etc/koha/sites/jack/koha-conf.xml" > Upgrading database schema for jack hi there, i think you have bumped into a file permission problem (that you've introduced?), while upgrading try checking the owner/perms for /etc/koha/sites/jack/* > Cannot load any Koha software. Attempted a live DVD. Does not respond to the > install software from the admin menu, Following instructions from the Live > DVD. "Live CDs and DVDs ... are not officially supported by Koha, and any difficulties should be taken up with the creator of them. https://wiki.koha-community.org/wiki/Koha_LiveCD perhaps send an email to the general mailing list for further help https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:31:33 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #23 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > > Note that OPACPopupAuthorsSearch feature has a problem with terms > > containing parentheses. The issue predates this patch. > > To avoid that, should not we search using the id instead of the string? We could, but we still need to fix it, as not all entries will be linked to authorities - some libraries don't use them at all and there can also be a mix. For example 653 (uncontrolled term) will show as subject but is, if i am not mistaken, usually unlinked (uncontrolled). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:32:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:32:05 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #24 from Katrin Fischer --- (In reply to Katrin Fischer from comment #23) > (In reply to Jonathan Druart from comment #22) > > > Note that OPACPopupAuthorsSearch feature has a problem with terms > > > containing parentheses. The issue predates this patch. > > > > To avoid that, should not we search using the id instead of the string? > > We could, but we still need to fix it, as not all entries will be linked to > authorities - some libraries don't use them at all and there can also be a > mix. For example 653 (uncontrolled term) will show as subject but is, if i > am not mistaken, usually unlinked (uncontrolled). Oh, see bug 24690 - I filed it for follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:33:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:33:06 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #25 from Katrin Fischer --- Sorry, working on the older bugs by bug number - missed your QA contact (also sometimes it's not reliable :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:33:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:33:23 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #17 from Martin Renvoize --- No worries, I often do the same :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:33:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:33:25 +0000 Subject: [Koha-bugs] [Bug 24694] New: Installing the sample data produces some errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24694 Bug ID: 24694 Summary: Installing the sample data produces some errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Getting the following errors when installing the default sample data: sample_holidays.sql [Thu Feb 20 08:26:09 2020] install.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`repeatable_holidays`, CONSTRAINT `repeatable_holidays_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) message_transport_types.sql [Thu Feb 20 08:26:07 2020] install.pl: DBD::mysql::st execute failed: Duplicate entry 'email' for key 'PRIMARY' sample_notices_message_attributes.sql [Thu Feb 20 08:26:10 2020] install.pl: DBD::mysql::st execute failed: Duplicate entry '1' for key 'PRIMARY' sample_notices_message_transports.sql [Thu Feb 20 08:26:10 2020] install.pl: DBD::mysql::st execute failed: Duplicate entry '1-email-0' for key 'PRIMARY' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:37:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:37:00 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:37:44 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 --- Comment #8 from Martin Renvoize --- I've tested on a series of sites here now and am confident in the change.. with Kyle and Nick having both taken a look too I think we're safe to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:43:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:43:49 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #18 from Katrin Fischer --- *puts hands over her ears and sings loudly* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:44:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:44:30 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #19 from Katrin Fischer --- (In reply to Katrin Fischer from comment #18) > *puts hands over her ears and sings loudly* ... hands over the eyes might work better in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:10 +0000 Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column name "Pending order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:12 +0000 Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column name "Pending order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:14 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:16 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:18 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:19 +0000 Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:21 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:23 +0000 Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:46:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:46:44 +0000 Subject: [Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Still, but without any info: koha_1 | [17:33:12] t/db_dependent/api/v1/items.t ........................................... koha_1 | Failed 2/2 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:48:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:48:41 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 --- Comment #5 from Julian Maurice --- Created attachment 99301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99301&action=edit Bug 19036: Add ability to auto generate a number for account credits In some areas it's required to sequentially number payment slips / receipts. This patch adds a database column accountlines.credit_number and a system preference AutoCreditNumber to control how this number will be generated. The following options are available: - Do not automatically generate credit numbers. This is the current behaviour and the default syspref value. - Automatically generate credit numbers in the form -0001 (annual) - Automatically generate credit numbers in the form yyyymm0001 (branchyyyymmincr) where is the branch where the user (staff member) is logged in - Automatically generate credit numbers in the form 1, 2, 3 (incremental) It also adds a column (hidden by default) in the table under Transactions tab to display this number. Test plan: 0. Apply patch, run updatedatabase and update_dbix_class_files 1. Go to Admin » Column settings, and uncheck the 'hidden' box for column credit_number in table account-fines. It will be easier for testing 2. Create a manual credit for a borrower. Verify in Transactions tab that this credit has no number generated 3. Change syspref 'AutoCreditNumber' to 'incremental' 4. Create more manual credits, and verify that the numbers generated are 1, 2, 3, ... 5. Change syspref 'AutoCreditNumber' to 'annual' 6. Create more manual credits, and verify that the numbers generated are '2020-0001', '2020-0002', ... 7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr' 8. Create more manual credits, and verify that the numbers generated are 'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are connected to library BRANCHA, and it's February 2020) 9. Set library to another one, say BRANCHB 10. Create more manual credits, and verify that the numbers generated are 'BRANCHB2020020001', 'BRANCHB2020020002', ... 11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %] somewhere. Go back to Transactions tab and click on 'Print' for one line that has a credit number. Make sure the number is there. 12. prove t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:49:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:49:14 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 09:56:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 08:56:37 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Tests only and all look like sane and sensible changes to me. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:02:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:02:59 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99301|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 99302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99302&action=edit Bug 19036: Add ability to auto generate a number for account credits In some areas it's required to sequentially number payment slips / receipts. This patch adds a database column accountlines.credit_number and a system preference AutoCreditNumber to control how this number will be generated. The following options are available: - Do not automatically generate credit numbers. This is the current behaviour and the default syspref value. - Automatically generate credit numbers in the form -0001 (annual) - Automatically generate credit numbers in the form yyyymm0001 (branchyyyymmincr) where is the branch where the user (staff member) is logged in - Automatically generate credit numbers in the form 1, 2, 3 (incremental) It also adds a column (hidden by default) in the table under Transactions tab to display this number. Test plan: 0. Apply patch, run updatedatabase and update_dbix_class_files 1. Go to Admin » Column settings, and uncheck the 'hidden' box for column credit_number in table account-fines. It will be easier for testing 2. Create a manual credit for a borrower. Verify in Transactions tab that this credit has no number generated 3. Change syspref 'AutoCreditNumber' to 'incremental' 4. Create more manual credits, and verify that the numbers generated are 1, 2, 3, ... 5. Change syspref 'AutoCreditNumber' to 'annual' 6. Create more manual credits, and verify that the numbers generated are '2020-0001', '2020-0002', ... 7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr' 8. Create more manual credits, and verify that the numbers generated are 'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are connected to library BRANCHA, and it's February 2020) 9. Set library to another one, say BRANCHB 10. Create more manual credits, and verify that the numbers generated are 'BRANCHB2020020001', 'BRANCHB2020020002', ... 11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %] somewhere. Go back to Transactions tab and click on 'Print' for one line that has a credit number. Make sure the number is there. 12. prove t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:04:07 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- Wow.. such a simple and nice little addition.. such a shame it took 5 years to work through the process :( Thanks for persevering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:06:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:06:19 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99302|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 99303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99303&action=edit Bug 19036: Add ability to auto generate a number for account credits In some areas it's required to sequentially number payment slips / receipts. This patch adds a database column accountlines.credit_number and a system preference AutoCreditNumber to control how this number will be generated. The following options are available: - Do not automatically generate credit numbers. This is the current behaviour and the default syspref value. - Automatically generate credit numbers in the form -0001 (annual) - Automatically generate credit numbers in the form yyyymm0001 (branchyyyymmincr) where is the branch where the user (staff member) is logged in - Automatically generate credit numbers in the form 1, 2, 3 (incremental) It also adds a column (hidden by default) in the table under Transactions tab to display this number. Test plan: 0. Apply patch, run updatedatabase and update_dbix_class_files 1. Go to Admin » Column settings, and uncheck the 'hidden' box for column credit_number in table account-fines. It will be easier for testing 2. Create a manual credit for a borrower. Verify in Transactions tab that this credit has no number generated 3. Change syspref 'AutoCreditNumber' to 'incremental' 4. Create more manual credits, and verify that the numbers generated are 1, 2, 3, ... 5. Change syspref 'AutoCreditNumber' to 'annual' 6. Create more manual credits, and verify that the numbers generated are '2020-0001', '2020-0002', ... 7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr' 8. Create more manual credits, and verify that the numbers generated are 'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are connected to library BRANCHA, and it's February 2020) 9. Set library to another one, say BRANCHB 10. Create more manual credits, and verify that the numbers generated are 'BRANCHB2020020001', 'BRANCHB2020020002', ... 11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %] somewhere. Go back to Transactions tab and click on 'Print' for one line that has a credit number. Make sure the number is there. 12. prove t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:08:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:08:57 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #64 from Martin Renvoize --- Who sponsored this one Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:10:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:10:59 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:01 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #65 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:04 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:06 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #21 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:08 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:10 +0000 Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after adding a manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:13 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:11:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:11:14 +0000 Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:29:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:29:52 +0000 Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template in export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99175|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 99304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99304&action=edit Bug 24679: Allow to apply a MARC modification template in export tool Test plan: 1. Create a MARC modification template with a simple action (for instance, "Add new field 999$9 with value foobar") 2. Go to Tools » Export data 3. Select some records (for instance, from biblionumber 1 to 10) 4. In options, select the MARC modification template you just created 5. Select File format 'MARC' 6. Click on 'Export bibliographic records' 7. Verify that exported records contain the 999$9 field 8. Repeat steps 3-7 with other export formats, and with authority records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:38:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:38:17 +0000 Subject: [Koha-bugs] [Bug 24695] New: Improve SQL report validation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695 Bug ID: 24695 Summary: Improve SQL report validation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org The saved SQL report code validates the SQL in multiple places: when saving, when updating, and when executing the query. Move the validation code into Koha::Reports, and write tests for it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:41:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:41:36 +0000 Subject: [Koha-bugs] [Bug 24695] Improve SQL report validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 99305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99305&action=edit Bug 24695: Improve SQL report validation The saved SQL report code validates the SQL in multiple places: when saving, when updating, and when executing the query. Move the validation code into Koha::Reports, and write tests for it. Test plan: 1) Apply patch 2) Create a new valid SQL report, save it (success) 3) Create a new illegal SQL report, try to save (fails) 4) Update already saved SQL report by adding one of the forbidden words, eg. delete or drop (saving will fail) 5) Edit a save_sql in the database, changing it to eg. "drop borrowers", and try to execute it (fails) 6) Prove t/db_dependent/Koha/Reports.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 10:43:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 09:43:46 +0000 Subject: [Koha-bugs] [Bug 21215] Saved SQL reports code improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 --- Comment #12 from paxed --- Splitting this up into multiple parts. One is bug 24695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 10:34:35 +0000 Subject: [Koha-bugs] [Bug 24696] New: We should output completion times in the updatedatabase output. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Bug ID: 24696 Summary: We should output completion times in the updatedatabase output. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Updatedatabase reports a line for each update, but there's no time added so it's hard to track down which update was responsible for a very long-running upgrade if you're not actually watching the upgrade. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 11:34:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 10:34:41 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:08:52 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- I would opt for the real URL instead of Link to resource if the syspref has not been enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:11:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:11:30 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #26 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #25) > I would opt for the real URL instead of Link to resource if the syspref has > not been enabled. Since 952$u is a repeatable subfield, I will be splitting the URL on the bar character on another report. Showing multiple Link to resource is kind of weird. Admittedly, having more URIs for one item might be exceptional, but not impossible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:12:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:12:37 +0000 Subject: [Koha-bugs] [Bug 24697] New: Split items.uri on staff detail view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Bug ID: 24697 Summary: Split items.uri on staff detail view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:12:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:12:59 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:12:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:12:59 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 12:33:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 11:33:34 +0000 Subject: [Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 Ronald Wijlens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.j.wijlens at saxion.nl --- Comment #2 from Ronald Wijlens --- Agreed. We have many duplicate authority records dating back from the original conversion, with some duplicates appearing over 50 times. Manually merging them in pairs takes forever. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:08:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:08:35 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 [Bug 24696] We should output completion times in the updatedatabase output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:08:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:08:35 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 [Bug 24131] Improved formatting for output of updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:09:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:09:22 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:09:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:09:28 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98659|0 |1 is obsolete| | Attachment #98660|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 99306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99306&action=edit Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:09:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:09:44 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #29 from Kyle M Hall --- Created attachment 99307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99307&action=edit Bug 17702: (QA follow-up) Add new field to kohastructure Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:13:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:13:47 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:13:50 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 --- Comment #1 from Marcel de Rooy --- Created attachment 99308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99308&action=edit Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:14:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:14:24 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:17:04 +0000 Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #27 from Marcel de Rooy --- On bug 24697 I finally decided to follow the preference on the item URL if there is only one URL. And show the real URL text if there are more. Please have a look there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:44:28 +0000 Subject: [Koha-bugs] [Bug 24698] New: UNIMARC authorities leader plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Bug ID: 24698 Summary: UNIMARC authorities leader plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: vitorfernandes87 at gmail.com QA Contact: testopia at bugs.koha-community.org The leader for authority record is different than for bibliographic record. We need a plugin for UNIMARC Authorities leader. Page 27 - https://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 13:45:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 12:45:13 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:10:47 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:25:23 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:25:25 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98816|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 99309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99309&action=edit Bug 21800: Add tests for repeatable subfields Test plan: Do not apply the second patch [note 1]. Run t/db_dependent/Biblio/TransformKohaToMarc.t Run t/db_dependent/Biblio/TransformMarcToKoha.t Apply the second patch and run them again. Both tests should pass now. Note 1: The TransformKohaToMarc test should fail with something like: # Failed test 'Check 260e' # at t/db_dependent/Biblio/TransformKohaToMarc.t line 60. # got: 'A' # expected: 'A | B' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:25:29 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98817|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 99310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99310&action=edit Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields If a kohafield (in Koha to MARC mappings) contains a pipe char (say A | B), we split it up into two subfields A and B in MARC. We will only do that for repeatable subfields now. If the field is not repeatable, the value will just be 'A | B'. Note 1: As bug 10306 and its friends (19096) made the Default framework authoritative, we do no longer have the frameworkcode in this routine. Formally, we should check the corresponding framework. Note 2: Does this impact the reverse operation in TransformMarcToKoha? No, the check on repeatable subfields is done in the interface and not in TransformMarcToKoha. This routine simply translates two instances of the same subfield, say A and B, into the value 'A | B' for a kohafield. Not allowing two instances of a non-repeatable subfield is not in the scope of this report. Test plan: [1] Mark an item field as repeatable in the Default framework. Edit an item. Insert A|B in this field and another not-repeatable field. Save and reopen. Verify that the repeatable field is duplicated and the other one contains the pipe character in the text box. [2] Look for a repeatable subfield in MARC like e.g. 260$c. Go to the cataloguing editor and add A|B in this field. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:25:34 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #7 from Marcel de Rooy --- Created attachment 99311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99311&action=edit Bug 21800: Check the correct framework for the repeatable tag This depends on the framework parameter. Which should be added back to the call in C4::Items. Test plan: [1] Mark in Default framework one subfield A repeatable and B not repeatable. Go to item editor. (Work on a biblio in Default framework.) Check saving and reopening these subfields with VAL1 | VAL2. Subfield A should be cloned, B should be glued as entered. [2] Mark in another Framework A not repeatable and B repeatable. Change framework for this biblio. Go to item editor again. Reopen item. Behavior subfields in reverse? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:25:37 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #8 from Marcel de Rooy --- Created attachment 99312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99312&action=edit Bug 21800: Add tests for _check_split This new subroutine supports checking the repeatable tag from another framework. (It will be useful for the item editor.) Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:26:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:26:07 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:26:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:26:43 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:29:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:29:26 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99312|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 99313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99313&action=edit Bug 21800: Add tests for _check_split This new subroutine supports checking the repeatable tag from another framework. (It will be useful for the item editor.) Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:32:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:32:14 +0000 Subject: [Koha-bugs] [Bug 24695] Improve SQL report validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- (In reply to paxed from comment #1) > Created attachment 99305 [details] [review] > Bug 24695: Improve SQL report validation Works well, no errors, test pass, but... > 5) Edit a save_sql in the database, changing it to eg. > "drop borrowers", and try to execute it (fails) ended with an empty borrowers table :( (I wrote 'delete from borrowers') Works this for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:47:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:47:43 +0000 Subject: [Koha-bugs] [Bug 24699] New: Split items.uri on OPAC detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Bug ID: 24699 Summary: Split items.uri on OPAC detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See 24697 (counterpart) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 14:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 13:47:51 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:01:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:01:49 +0000 Subject: [Koha-bugs] [Bug 24700] New: Improve Mojo startup speed for REST APIs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Bug ID: 24700 Summary: Improve Mojo startup speed for REST APIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi Currently the API spec is validated multiple times, and the whole spec loaded so far is re-validated for each (if any) REST API plugin. Coming up with a patch to avoid multiple validation unless the complete spec doesn't validate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:02:11 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:19:29 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:19:32 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 --- Comment #1 from Ere Maijala --- Created attachment 99314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99314&action=edit Bug 24700: Avoid validating REST API spec multiple times This patch changes the spec loading so that it is fully loaded and merged with any plugin routes before validation. The individual parts are separately validated only if the resulting complete spec is invalid. Note: the OpenAPI plugin validates the spec given to it, so normally no manual validation is necessary. Test plan: 1. prove -v t/db_dependent/Koha/REST/* 2. prove -v t/db_dependent/api/v1/* Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:20:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:20:28 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi, | |josef.moravec at gmail.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:21:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:21:30 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:33:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:33:15 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98536|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99315&action=edit Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:33:18 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98537|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 99316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99316&action=edit Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:33:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:33:21 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 --- Comment #7 from Martin Renvoize --- Created attachment 99317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99317&action=edit Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:35:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:35:55 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Martin Renvoize --- Well.. this patch doesn't go as far as I was initially thinking and goes in a bit of a different direction.. but I like the factoring out of the version statement and believe it can be used as the basis for more work. As such, I'm signing if off as is. I toyed with adding colour output for the terminal, but that is a bigger piece that would require code in the controller to either strip out the color sequences or upgrade them to css classes or something. I have however added a new bug which adds timestamps to the output based atop this to show where we could go with it. Signing off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:36:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:36:01 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:36:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:36:21 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 --- Comment #1 from Martin Renvoize --- Created attachment 99318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99318&action=edit Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:36:50 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:40:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:40:52 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 --- Comment #9 from Martin Renvoize --- One issue I did spot, however, was that the tab spacing is stripped when going via the web installer. It would be good to fix that here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:45:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:45:02 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:46:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:46:04 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:51:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:51:46 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 15:51:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 14:51:48 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #30 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:03:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:03:47 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:06:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:06:21 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #37 from Owen Leonard --- I've done some follow-up work on this and will hopefully be able to get back to it soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:06:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:06:53 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99314|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 99319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99319&action=edit Bug 24700: Avoid validating REST API spec multiple times This patch changes the spec loading so that it is fully loaded and merged with any plugin routes before validation. The individual parts are separately validated only if the resulting complete spec is invalid. Note: the OpenAPI plugin validates the spec given to it, so normally no manual validation is necessary. Test plan: 1. prove -v t/db_dependent/Koha/REST/* 2. prove -v t/db_dependent/api/v1/* Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:16:18 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #10 from Ere Maijala --- Why isn't the default framework also authoritative for repeatability? If not, at least the framework information should be fetched e.g. with GetMarcSubfieldStructure so that it's cached to avoid a performance penalty, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:16:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:16:54 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99319|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 99320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99320&action=edit Bug 24700: Avoid validating REST API spec multiple times This patch changes the spec loading so that it is fully loaded and merged with any plugin routes before validation. The individual parts are separately validated only if the resulting complete spec is invalid. Note: the OpenAPI plugin validates the spec given to it, so normally no manual validation is necessary. Test plan: 1. prove -v t/db_dependent/Koha/REST/* 2. prove -v t/db_dependent/api/v1/* Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:18:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:18:24 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- This is a nice improvement and the code is fairly clear. I'm struggling a little to find where this is tested to date though.. so I haven't run tests against it yet to fully prove there are no regressions.. human testing gave me no issues though so I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:26:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:26:31 +0000 Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99065|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 99321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99321&action=edit Bug 15377: Remove 'checked out' items from course reserves 1) removes the restriction of not allowing a reserve to be removed if it is onloan 2) adds a column to the display that says with the item is checked out or available based on the onloan flag testplan: add an item to course reserves, check the item out, check that the Ciruclation column changes to Checked Out and that you can remove it Signed-off-by: David Nind Signed-off-by: Hannah Olsen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:46:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:46:48 +0000 Subject: [Koha-bugs] [Bug 24637] Pay selected & Pay amount does not log branchcode in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.08 released in| | Status|Passed QA |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:50:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:50:22 +0000 Subject: [Koha-bugs] [Bug 24689] Fix missing 'hold' class regression from BZ 23903 (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24689 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:51:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:51:45 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 --- Comment #9 from Lucas Gass --- reverted from the 19.05.x series, thanks Kyle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:52:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:52:00 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02. |20.05.00, 19.11.02 released in|19.05.07, 18.11.14 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 16:58:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 15:58:42 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #10 from Benjamin Daeuber --- I think we'd be willing to fund some of this, but I'm curious what libraries want it to look like. There are a lot of things that happen on check-in (holds, transfers, notification of statuses). Do we want a table to appear (similar to the batch item modification tool) or do we want all those items to be checked in without user interaction and the various messages can be dealt with in other ways? For example, holds would later show up in the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:25:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:25:58 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 --- Comment #11 from Christopher Brannon --- (In reply to Benjamin Daeuber from comment #10) > I think we'd be willing to fund some of this, but I'm curious what libraries > want it to look like. There are a lot of things that happen on check-in > (holds, transfers, notification of statuses). Do we want a table to appear > (similar to the batch item modification tool) or do we want all those items > to be checked in without user interaction and the various messages can be > dealt with in other ways? For example, holds would later show up in the > holds queue. I think options like forgiving fines, check-in date, and trigger holds would all be good options. It should present a table of results. If there is a fine, it should show if it was forgiven. If there is a hold, there should be a button to confirm, confirm and print, or cancel (maybe), and when clicked, it would do it, but the buttons would disappear, but the table results remain intact. If nothing, it will just show it was checked in and the date it was checked in for. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:30:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:30:59 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #43 from Kyle M Hall --- Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 453: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 122 FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 453: unexpected end of input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:40:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:40:13 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 --- Comment #12 from Benjamin Daeuber --- (In reply to Christopher Brannon from comment #11) > > I think options like forgiving fines, check-in date, and trigger holds would > all be good options. > > It should present a table of results. If there is a fine, it should show if > it was forgiven. If there is a hold, there should be a button to confirm, > confirm and print, or cancel (maybe), and when clicked, it would do it, but > the buttons would disappear, but the table results remain intact. If > nothing, it will just show it was checked in and the date it was checked in > for. I like these ideas too, especially making trigger holds optional so this can be applied in a variety of situations. Trigger transfers would also need to be considered if libraries printed transfer slips or simply wanted to handle transfers some other way. Another option I'd like to throw out is to integrate batch check-in with batch item modification. When we process new items or remove them from display it would be easier if they could be checked in all at once. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:41:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:41:54 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #30 from Kyle M Hall --- root at 6d3e2c82bf14:koha(bug22690-qa)$ prove t/db_dependent/Koha/Item.t t/db_dependent/Koha/Item.t .. 4/5 # No tests run! t/db_dependent/Koha/Item.t .. 5/5 # Failed test 'No tests run for subtest "move_to_biblio() tests"' # at t/db_dependent/Koha/Item.t line 435. Can't use string ("k8XjSy") as a HASH ref while "strict refs" in use at /kohadevbox/koha/C4/Reserves.pm line 175. # Looks like your test exited with 255 just after 5. t/db_dependent/Koha/Item.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/5 subtests Test Summary Report ------------------- t/db_dependent/Koha/Item.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Files=1, Tests=5, 6 wallclock secs ( 0.04 usr 0.01 sys + 3.30 cusr 0.62 csys = 3.97 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:48:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:48:39 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:48:51 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:49:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:49:06 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #22 from Martin Renvoize --- Just testing this now.. so far so good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:53:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:53:25 +0000 Subject: [Koha-bugs] [Bug 24495] Reword change collection feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:54:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:54:00 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #31 from Martin Renvoize --- Created attachment 99322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99322&action=edit Bug 17702: (RM follow-up) Remove use of I18N tt This patch removes the use of the I18N TT plugin in introduced for all strings in the new template. We're not yet ready to use this plugin for all strings as we need to further investigate performance for such a move and perhaps add template compilation. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:56:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:56:53 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98833|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 99323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99323&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:56:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:56:57 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98834|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 99324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99324&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:57:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:57:00 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #46 from Martin Renvoize --- Created attachment 99325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99325&action=edit Bug 22359: (follow-up) Fix rebase error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:57:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:57:19 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 17:59:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 16:59:45 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99140|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 99326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99326&action=edit Bug 24676: Remove

    typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no

    block between and
    Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:00:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:00:04 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:06:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:06:44 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99273|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 99327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99327&action=edit Bug 23727: Add new columns Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:06:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:06:47 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99274|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 99328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99328&action=edit Bug 23727: Update Schema Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:06:50 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99275|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 99329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99329&action=edit Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:06:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:06:54 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99277|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 99330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99330&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:17:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:17:46 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99327|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 99331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99331&action=edit Bug 23727: Add new columns Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:17:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:17:49 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99328|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 99332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99332&action=edit Bug 23727: Update Schema Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:17:52 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99329|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 99333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99333&action=edit Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:17:56 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99330|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 99334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99334&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:17:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:17:59 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #31 from Martin Renvoize --- Created attachment 99335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99335&action=edit Bug 23727: (QA follow-up) Fix script tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:18:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:18:02 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #32 from Martin Renvoize --- Created attachment 99336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99336&action=edit Bug 23727: (QA follow-up) Fix for boolean flags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:18:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:18:27 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Martin Renvoize --- Works as expected, Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:29:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:29:30 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:29:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:29:46 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 18:29:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 17:29:49 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99323|0 |1 is obsolete| | Attachment #99324|0 |1 is obsolete| | Attachment #99325|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 99337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99337&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:23:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 19:23:26 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to the release notes| |catalog export data tool | |automatically changes the | |file extension in the file | |name to the selected export | |format (such as as CSV, or | |XML), rather than leaving | |it as .mrc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 19:31:32 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This bug fixes display release notes| |issues with the date picker | |and some other style | |changes that were | |inadvertently introduced by | |bug 24181. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 20:56:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 19:56:43 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Will test if I could have a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 20:05:53 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows you release notes| |to view the search query | |used by Zebra or Elastic | |Search, to help with | |troubleshooting. To use, | |enable the new system | |preference | |DumpSearchQueryTemplate, | |enable | |DumpTemplateVarsIntranet | |and DumpTemplateVarsOpac, | |and then search the page | |source in the staff | |interface or OPAC for | |'search_query'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:18:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 20:18:38 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to the release notes| |item search in the staff | |interface (Home > Search > | |Item search) adds the | |ability to export selected | |items. Before this | |enhancement the only option | |available was to export all | |the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:22:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 20:22:20 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:22:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 20:22:24 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98604|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 99338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99338&action=edit Bug 24615: Make object.search helper also order by embedded columns With this patch REST API request can order results by embedded columns. Full path to the column must be given for it to work. For example: If you are on biblio endpoint and you want to order by holding patron's card number you could > GET /biblio/1?_order_by=item.holds.cardnumber HTTP/1.1 > x-koha-embed: item.holds To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 21:53:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 20:53:52 +0000 Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:51:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 21:51:03 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #50 from Hayley Mapley --- Backported to 18.11.x for 18.11.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 22:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 21:52:23 +0000 Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #14 from Hayley Mapley --- Depends on code not in 18.11.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:15:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:15:55 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #2 from Lisette Scheer --- This adds column configuration to the opac course_reserves_table. I think Katrin was asking about the opac course_items_table since that has a link column. I think this is also a good addition, so I'm going to SO and open a new bug for the other table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:24:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:24:41 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:24:43 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99268|0 |1 is obsolete| | --- Comment #3 from Lisette Scheer --- Created attachment 99339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99339&action=edit Bug 23547: Add column configuration to course reserves table in the OPAC This patch adds opac-course-reserves to the column config tool TEST PLAN: 1. Have some course reserves and go look at opac-course-reserves.pl 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > course_reserves_table 5. Try hiding each column and make sure the correct column is hidden on opac-course-reserves.pl Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:27:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:27:33 +0000 Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:29:06 +0000 Subject: [Koha-bugs] [Bug 24701] New: Add column configuration to course_items_table in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Bug ID: 24701 Summary: Add column configuration to course_items_table in the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org from Bug 23547 Katrin Fischer 2019-09-05 16:00:44 UTC It would be nice if it was easy to hide columns from the course reserves table in the OPAC (example: hide the Link column because it doesn't contain full text links reliably). Bug 23547 adds the ability to configure columns for course_reserves_table on the OPAC. It would be helpful to also add configuration for course_items_table in the OPAC. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:29:21 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:29:21 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 20 23:54:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 22:54:25 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #94 from Lisette Scheer --- Applying: Bug 21946: Database updates Applying: Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes .git/rebase-apply/patch:95: trailing whitespace. } else { .git/rebase-apply/patch:96: trailing whitespace. $count_query .= " JOIN biblioitems USING (biblionumber) warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Circulation.pm M t/db_dependent/Circulation/TooMany.t .git/rebase-apply/patch:95: trailing whitespace. } else { .git/rebase-apply/patch:96: trailing whitespace. $count_query .= " JOIN biblioitems USING (biblionumber) warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/TooMany.t Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21946-Update-C4Circulation-TooMany-to-check-pa-mluqOe.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 00:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 23:11:29 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capturing circulation |Capturing circulation |statistics per number of |statistics per number of |items in an item |pieces in an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 00:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 23:17:35 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 --- Comment #16 from Hayley Mapley --- Can this please be rebased for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 00:18:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Feb 2020 23:18:09 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 --- Comment #1 from Daniel Gaghan --- What we were thinking when we requested this enhancement was to have an item checkouted to a users show up on their accounts as one checkout but have the Koha statistics count the number of pieces of the item as the number of material issued. For example a DVD set with 5 discs would count in the statistics as five checkout/issues in the stats. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 06:28:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 05:28:13 +0000 Subject: [Koha-bugs] [Bug 24695] Improve SQL report validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695 --- Comment #3 from paxed --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > (In reply to paxed from comment #1) > > Created attachment 99305 [details] [review] [review] > > Bug 24695: Improve SQL report validation > > Works well, no errors, test pass, but... > > > 5) Edit a save_sql in the database, changing it to eg. > > "drop borrowers", and try to execute it (fails) > > ended with an empty borrowers table :( > (I wrote 'delete from borrowers') > > Works this for you? update saved_sql set savedsql='DROP borrowers'; then try to run the report, it'll cause an error. Ideally, this should be changed to produce an actual koha page with an explanation instead, but that is outside the scope of this bug, and behaves the same as before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 07:58:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 06:58:17 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99326|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 99340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99340&action=edit Bug 24676: Remove

    typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no

    block between and
    Signed-off-by: Sally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 07:58:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 06:58:37 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Trivial fix passes all tests.. passing qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 07:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 06:58:41 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:26 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97685|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 99341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99341&action=edit Bug 23777: Fix auth finder escaping Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:29 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97686|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 99342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99342&action=edit Bug 23777: Fix for the advanced editor Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:33 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97687|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 99343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99343&action=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:36 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97688|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 99344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99344&action=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:39 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98698|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 99345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99345&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:43 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98699|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 99346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99346&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:01:46 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98700|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 99347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99347&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:04:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:04:26 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #35 from Martin Renvoize --- Created attachment 99348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99348&action=edit Bug 23777: (QA follow-up) Fix TT closing braces Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:05:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:05:34 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #36 from Martin Renvoize --- Great to see these moving to more traditional filters/escaping/parsing practices. QA scripts are happy and in testing I found all cases working. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:12:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:12:38 +0000 Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 --- Comment #5 from Ere Maijala --- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t contains the tests for PluginRoutes, but I don't think there's anything for V1.pm's startup. I can try to create something, but it's pretty huge if all that the startup method does is to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:20:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:20:05 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98602|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 99349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99349&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:20:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:20:08 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98603|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 99350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99350&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:21:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:21:07 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #28 from Martin Renvoize --- Well written and clear patch which passes all qa script tests and works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:21:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:21:56 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99252|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 99351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99351&action=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:22:00 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99253|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 99352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99352&action=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:23:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:23:11 +0000 Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Martin Renvoize --- All works as expected and passes qa tests.. Well done Agustin, this is a great feature to have added.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:23:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:23:51 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99338|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99353&action=edit Bug 24615: Make object.search helper also order by embedded columns With this patch REST API request can order results by embedded columns. Full path to the column must be given for it to work. For example: If you are on biblio endpoint and you want to order by holding patron's card number you could > GET /biblio/1?_order_by=item.holds.cardnumber HTTP/1.1 > x-koha-embed: item.holds To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:24:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:24:13 +0000 Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Clear patch and no QA failures. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:47:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:47:40 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99308|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 99354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99354&action=edit Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:48:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:48:25 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24699 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:48:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:48:25 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 08:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 07:59:08 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Warning from qa tools: File not found : /js/locale_data.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% Asset.js(lang _ '/js/locale_data.js') | $raw %] Cannot find this file. Not sure if this construction works in template toolkit btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:15:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:15:25 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #32 from Julian Maurice --- I did investigate performance at the time of bug 15395. See https://gitlab.com/jajm/time-i18n. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:20:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:20:57 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > Warning from qa tools: > File not found : /js/locale_data.js at > /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. > > koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% > Asset.js(lang _ '/js/locale_data.js') | $raw %] > Cannot find this file. Not sure if this construction works in template > toolkit btw. The construction is fine btw. Not sure why qa tools doesnt like it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:22:32 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:22:35 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 --- Comment #1 from Marcel de Rooy --- Created attachment 99355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99355&action=edit Bug 24699: Split items.uri in OPAC detail view Same change as in bug 24697 for staff. If there are more URIs in 952u, we split them and show the real URL instead of Link to resource or the value of pref URLLinkText. I introduced a few template variables here to make the code a bit more compact and readable. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:29:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:29:59 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99051|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 99356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99356&action=edit Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:30:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:30:03 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99052|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 99357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99357&action=edit Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems. Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:30:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:30:24 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- Obvious fix, now well covered by tests.. Thanks Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:31:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:31:06 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 --- Comment #11 from Julian Maurice --- > The construction is fine btw. Not sure why qa tools doesnt like it.. Probably because lang is not defined so it looks for absolute path /js/locale_data.js Not sure why qa tools has to process templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:35:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:35:37 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #4 from Ere Maijala --- Test plan for no priority provided: 1. Create a hold (you can use the UI or API for it, doesn't matter) and take note of its id and pickup location. 2. Find branchcode for another pickup location. 3. Without the patch, do a PUT request to /api/v1/holds/{id} with the following JSON: { "pickup_library_id":"" } 4. Check the response. It still has the original location pickup_library_id. Check the hold in the UI, it still has the original pickup location. 5. Apply the patch and do the PUT request again. 6. Check the response. It should now reflect the new location in pickup_library_id. Check the hold in the UI, it should also have the new pickup location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:36:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:36:46 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #38 from Martin Renvoize --- Still on this one Marcelr..? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:36:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:36:58 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:38:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:38:35 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98981|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 99358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99358&action=edit Bug 22655: Adding holds rules to Onboarding tool This patch adds the following fields to the circ rule step in the onboarding tool: - holds allowed (total) - holds allowed (daily) - holds per record (count) To test: 1) Apply patch, drop and recreate database, restart memcached and refresh page 2) Go through the installer and get to the final step of the onboarding tool 3) Confirm the above fields are now available to set in your circulation rule 4) Save and log in to Koha 5) Go to Admin -> Circ and fines rules 6) Confirm the fields saved correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:38:57 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Works well, passes QA tests.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 09:41:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 08:41:45 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #5 from Ere Maijala --- Test plan for suspension endpoint: 1. Create a hold and take note of its id 2. Without the patch, do a POST request to /api/v1/holds/{id}/suspension with no body 3. Take note that it returns the current date as end_date. Check in the database that reserves.suspend_until is actually null. 4. Apply the patch and do the POST request again. 5. Verify that the response now contains null as end_date. 6. Make another POST request to /api/v1/holds/{id}/suspension with the following JSON body (use tomorrow as the date): { "end_date": "2020-xx-yy" } 7. Verify that the response reflects the given date. Verify that the database also has the given date in reserves.suspend_until field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:06:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:06:43 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a problem with release notes| |the QOTD tool - you can now | |add and edit quotes again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:09:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:09:39 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97754|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 99359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99359&action=edit [18.11.x] Bug 23064: Use Koha::Subscription in ModSubscription We must use Koha::Subscription instead of raw SQL. It will fix issue with default and integer values. Test plan: Edit a subscription and set number of issues = "f" Save => Without this patch there is a SQL error in the log: Incorrect integer value: 'f' for column 'numberlength' => With this patch the other changes are effective. Note: We also could change the type attribute of the input to "number", to have a client-side check Also, the return value of ModSuggestion is never used, so we are safe with that. Signed-off-by: Hayley Mapley The flag must be present and set to 1 in the section of koha-conf.xml Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:12:24 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #11 from David Nind --- Still valid for master (February 2020) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:16:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:16:26 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 --- Comment #18 from Jonathan Druart --- (In reply to Hayley Mapley from comment #16) > Can this please be rebased for 18.11.x? Done, see last patch. Worth noting, when I tested it I saw that ergonomic issue: https://snipboard.io/tHK4ao.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:16:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:16:57 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #39 from Marcel de Rooy --- There we go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:29:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:29:25 +0000 Subject: [Koha-bugs] [Bug 24702] New: QOTD editor - input form for adding and editing quotes is very narrow when using Firefox Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24702 Bug ID: 24702 Summary: QOTD editor - input form for adding and editing quotes is very narrow when using Firefox Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Created attachment 99360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99360&action=edit Screenshot: QOTD editing Firefox The input form for adding or editing a quote using the Quote of the Day (QOTD) feature is very narrow when using Firefox (Home > More > Tools > Additional tools > Edit quotes for QOTD feature). The attached screenshot shows what this looks like in Firefox - evident on 19.11.x and master. The input form displays as expected on Google Chrome and Chromium. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:29:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:29:40 +0000 Subject: [Koha-bugs] [Bug 24702] QOTD editor - input form for adding and editing quotes is very narrow when using Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24702 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:31:34 +0000 Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 --- Comment #7 from David Nind --- (In reply to David Nind from comment #4) > - The styling is all wonky from at least 19.11.x on Firefox (very narrow > height for the input boxes when adding or editing => Google Chrome or > Chromium is okay)(see screenshot attachment) - happy to add > a new bug for this Bug 24702 created for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:37:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:37:06 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:37:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:37:09 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 --- Comment #1 from Jonathan Druart --- Created attachment 99361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99361&action=edit Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:37:18 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:40:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:40:03 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 --- Comment #7 from Jonathan Druart --- (In reply to Martin Renvoize from comment #6) This needs to be backported. I think we should reopen it for Rmaints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:41:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:41:30 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #40 from Marcel de Rooy --- Hmm bit of a struggle to get this rebased.. Hang on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:41:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:41:49 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #41 from Marcel de Rooy --- FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc OK forbidden patterns OK git manipulation SKIP spelling OK tt_valid FAIL valid_template koha_news_block: not found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:42:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:42:07 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:42:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:42:19 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #42 from Marcel de Rooy --- Removing Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:44:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:44:03 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:46:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:46:55 +0000 Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- (In reply to Julian Maurice from comment #11) > > The construction is fine btw. Not sure why qa tools doesnt like it.. > > Probably because lang is not defined so it looks for absolute path > /js/locale_data.js > Not sure why qa tools has to process templates. It's coming from xt/tt_valid.t (or similar code from the qa script) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:54:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:54:05 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #10 from Jonathan Druart --- This is not enough for me to PQA. The original code is wrong (see bug 17896), you copy it, then modify it. I would prefer to fix the original issue, then reuse it. Here we are going to end up with 2 different versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:54:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:54:12 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #43 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #40) > Hmm bit of a struggle to get this rebased.. Hang on Something with masthead.inc and the atomic update .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:57:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:57:03 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98985|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 99362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99362&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:57:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:57:08 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98986|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy --- Created attachment 99363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99363&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:57:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:57:13 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98987|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy --- Created attachment 99364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99364&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '
    .' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:57:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:57:18 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98988|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy --- Created attachment 99365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99365&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:57:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:57:22 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98989|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 99366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99366&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 10:59:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 09:59:42 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #49 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #47) > Created attachment 99365 [details] [review] > Bug 22880: Use placeholders > > Always. Not really the most descriptive commit title and message I've seen.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:11:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:11:04 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #50 from Marcel de Rooy --- DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( timestamp,content,title,expirationdate,branchcode,lang,borrowernumber,number ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0='2020-02-21', 1="

    TESTing

    ", 2="Welcome", 3=undef, 4=undef, 5="opacheader_en", 6="51", 7=""] at /usr/share/koha/C4/NewsChannels.pm line 68. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:22:18 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- A couple of things: 1. test plan says "the second one fails", but it actually prints. I would die instead. 2. That will make you avoid the indentation level you add with this patch. The algo would be: - try to get a lock - if lock already exists then exit/die with "cannot get lock" (or something more meaningful: "previous run is still alive, cannot start") - continue the normal process of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:22:37 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > A couple of things: > 1. test plan says "the second one fails", but it actually prints. I would > die instead. s/would/should! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:27:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:27:47 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Enhancements to lists: release notes| |- | |Log in links to create a | |new list now take you to | |the 'Create a new list' | |form after you log in, | |instead of to your account | |summary page. | |- Logging in | |is required for any action | |other the viewing public | |lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:32:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:32:36 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #12 from Jonathan Druart --- Also, do you know that you can lock a portion of the file? I have no idea why your code is that complicated, I think you should investigate this code: use Modern::Perl; use Fcntl qw(:flock); sub is_locked { unless ( flock(DATA, LOCK_EX|LOCK_NB) ) { return 1; } return 0; } die "is locked" if is_locked(); say "is not locked! sleeping 5 sec"; sleep(5); __DATA__ USED BY LOCK - DO NOT REMOVE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:34:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:34:45 +0000 Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > We usually have a "Show inactive" checkbox right after the dropdown list. > Should not we implement that here as well? Failing QA to get feedback on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:35:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:35:33 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #51 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #50) > DBD::mysql::st execute failed: Incorrect integer value: '' for column > `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO > opac_news ( > timestamp,content,title,expirationdate,branchcode,lang,borrowernumber,number > ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0='2020-02-21', > 1="

    TESTing

    ", 2="Welcome", 3=undef, 4=undef, 5="opacheader_en", > 6="51", 7=""] at /usr/share/koha/C4/NewsChannels.pm line 68. Can be prevented by less strict sql mode, needs attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:39:19 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |--enable and --disable | |options to the koha-sip | |Debian package command. | | | |Usage: | |- koha-sip --enable | |instancename => Enables the | |Koha SIP server | |- koha-sip | |--disable instancename => | |Disables and stops the Koha | |SIP server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:42:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:42:55 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Changes to to_api_mapping should not be part of this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:48:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:48:46 +0000 Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 --- Comment #10 from Jonathan Druart --- Also, I think the method should reflect the lack of FK, something like: sub creator { my ($self) = @_; my $borrowernumber = $self->authorisedby; # FIXME missing FK here return unless $borrowernumber; return Koha::Patrons->find( $self->authorisedby ); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:49:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:49:38 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #52 from Marcel de Rooy --- Owen, Please verify that my rebase did not introduce another problem in masthead or the atomic update. I'm having issues now getting the opacheader to work. Somehow it looks for opacheader while I add opacheader_en items into the database via the interface. select title,lang from opac_news; +-----------------+---------------+ | title | lang | +-----------------+---------------+ | Welcome to Koha | koha | | What's Next? | koha | | Test | opacheader_en | +-----------------+---------------+ When I deleted my database, the installer crashes now on the language step. So very soon. (Apparently, for some other reason..) DBD::mysql::st execute failed: Table 'koha_master.language_descriptions' doesn't exist [for Statement "SELECT description FROM language_descriptions WHERE subtag=? AND lang=? AND type=?" with ParamValues: 0='en', 1='en', 2='language'] at /usr/share/koha/C4/Languages.pm line 389. DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for Statement "SELECT description FROM language_descriptions WHERE subtag=? AND lang=? AND type=?" with ParamValues: 0='en', 1='en', 2='language'] at /usr/share/koha/C4/Languages.pm line 390. Keeping this in BLOCKED. Will come back here next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:50:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:50:09 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #53 from Marcel de Rooy --- Created attachment 99367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99367&action=edit Bug 22880: (QA follow-up) Fix "koha_news_block: not found" To make qa tools happy again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:55:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:55:12 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:55:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:55:15 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98274|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 99368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99368&action=edit Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface It was noted, that 'sub fund' might be a better term to use than 'child fund'. So this patch changes it. To test, check with and without patch: - Add a budget in acquisitions - Add a fund in acquisitions - Add a sub/child fund to your fund (label of menu item #1) - Edit your first fund, check option to update owners of sub/child funds (#2) - Try to delete your 'parent' fund (tooltip #3) - Click on the greyed out entry (alert ÃÃ#4) If you like the chane, please sign-off. If you think otherwise, please comment on the bug report. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 11:55:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 10:55:36 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Maybe also admin/aqbudgets.pl: die("Delete a fund with children is not possible"); But not important.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:01:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:01:45 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #97 from Jonathan Druart --- Missing filters can be added easily with misc/devel/add_missing_filters.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:10:29 +0000 Subject: [Koha-bugs] [Bug 13187] Access keys should be localizable/translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13187 --- Comment #1 from paxed --- These could be done with the i18n template plugin, eg. would become something like -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:18:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:18:04 +0000 Subject: [Koha-bugs] [Bug 24703] New: Show accesskeys with CSS instead of hardcoding them in the button text Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24703 Bug ID: 24703 Summary: Show accesskeys with CSS instead of hardcoding them in the button text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Currently the accesskeys are hardcoded into the button texts, like so: This is a problem eg. when translating the texts. A more elegant solution would be to use CSS to show the actual access key value, such as button[accesskey]:after { margin-left: 0.5em; content: "(" attr(accesskey) ")"; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:32:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:32:53 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #25) > Sorry, working on the older bugs by bug number - missed your QA contact > (also sometimes it's not reliable :) ) No worries I was not, I assigned to me after you PQAed it! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:34:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:34:42 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- Owen, sorry but I found a regression. With OPACPopupAuthorsSearch and NOT OPACXSLTDetailsDisplay Hit /cgi-bin/koha/opac-detail.pl?biblionumber=15 Without the patch, the link on "Additional authors: Bradbury, Nicola." opens a popup. It does not with your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:41:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:41:44 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart --- This change makes sense to me, but I am not able to provide a test plan, as it is hard to predict the side-effects. I would like Jason to test this patch, and QA to make a full review and try to anticipate potential regressions. 2 pairs of QA eyes would be great here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 12:45:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 11:45:41 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 --- Comment #9 from Jonathan Druart --- Created attachment 99369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99369&action=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:30:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 12:30:16 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- 1. Should not we want the X-Mailer value to be more specific? Like with the library name for instance? 2. I suspect Email::MessageID to be "buggy" under plack. My understanding (may be wrong!): "my %uniq" is supposed to contain " $epoch => $nb_occ " with $nb_occ the number of time $epoch has been associated to an id. Say the following Message-ID generated by the module: 15822877730.63BC8.7268 at df2c0b4bf86c 1582287773 is $epoch, 0 is the first occurrence 63BC8 is a random value 7268 at df2c0b4bf86c is the hostname The next ID generated in the same second will be 15822877731. If another script is ran at the same time, we will have this "uniq" 15822877730 used several time. Short version: All of that to say that we are safe as there is the random value that is concatenated, it will be bad luck to get twice the same generated random value, in the same second, with 2 scripts . But it is possible :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:32:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 12:32:51 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) You can really forget 2. as the same behavior exists without Plack (the variable will obviously not be shared). I guess that's why the author added the randomly generated string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:33:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 12:33:08 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #8 from Nick Clemens --- Created attachment 99370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99370&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 13:35:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 12:35:31 +0000 Subject: [Koha-bugs] [Bug 24704] New: Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Bug ID: 24704 Summary: Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:02:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:02:44 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:02:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:02:47 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 --- Comment #1 from Nick Clemens --- Created attachment 99371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99371&action=edit Bug 24704: load BakerTaylor module with use We are incinsistent here, Amazon and Syndetics module are always loaeded in some places BakerTaylor is conditional everywhere, and causes issues under plack For simplicity sake I think we should just load this (small) module where it might be needed To test: 1 - Disable Baker and Taylor images 2 - Restart plack 3 - Visit opac-readingrecord, opac-detail, opac-search, opac-shelves, opac-user Log in to opac Virew your reading history Make/view a list Search the catalog Look at an individual title 4 - Enable BakerTaylorEnabled If you don't have Baker and Taylor credentials, simply fudge them with bad data and enable 5 - Repeat steps above, in the word of Joubu "Kaboom" 6 - Apply patch 7 - Repeat 1-4 8 - You shoudl be able to load all the pages after enabling the pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:03:23 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24704 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:03:23 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:04:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:04:31 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:04:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:04:31 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 [Bug 23482] BakerTaylor images broken on OPAC lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:04:34 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99247|0 |1 is obsolete| | Attachment #99248|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 99372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99372&action=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:05:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:05:54 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Ere Maijala --- Setting to Failed QA until my previous comments have been resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:09:54 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:09:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:09:57 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58891|0 |1 is obsolete| | Attachment #66251|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 99373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99373&action=edit Bug 17896: load BakerTaylor module with use We are incinsistent here, Amazon and Syndetics module are always loaeded in some places BakerTaylor is conditional everywhere, and causes issues under plack For simplicity sake I think we should just load this (small) module where it might be needed To test: 1 - Disable Baker and Taylor images 2 - Restart plack 3 - Visit opac-readingrecord, opac-detail, opac-search, opac-shelves, opac-user Log in to opac Virew your reading history Make/view a list Search the catalog Look at an individual title 4 - Enable BakerTaylorEnabled If you don't have Baker and Taylor credentials, simply fudge them with bad data and enable 5 - Repeat steps above, in the word of Joubu "Kaboom" 6 - Apply patch 7 - Repeat 1-4 8 - You shoudl be able to load all the pages after enabling the pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:10:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:10:18 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 17896 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:10:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:10:18 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #14 from Nick Clemens --- *** Bug 24704 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:10:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:10:19 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Bug 23482 depends on bug 24704, which changed state. Bug 24704 Summary: Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:10:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:10:51 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|BakerTaylorEnabled is not |BakerTaylorEnabled is not |plack safe in reading |plack safe in the OPAC |history at the OPAC | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:11:29 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24704 |17896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:11:29 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 [Bug 23482] BakerTaylor images broken on OPAC lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:11:29 +0000 Subject: [Koha-bugs] [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23482 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 [Bug 23482] BakerTaylor images broken on OPAC lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:14:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:14:31 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99372|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:14:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:14:44 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99247|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:17:04 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99247|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 99374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99374&action=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:17:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:17:44 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:17:47 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98584|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 99375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99375&action=edit Bug 24211: Compress/uncompress translation files This patch adds the ability to compress/uncompress translations files. On update/install the files are uncompressed first The only gain is to use less space. To test: 1) Apply the patch 2) Go to misc/translator 3) Try it $ ./translate compress fr-FR (check po/*.gz) $ ./translate uncompress fr-FR ( check normal files) 4) Try again with verbose mode $ ./translate compress fr-FR -v (list compressed files) $ ./translate uncompress fr-FR -v (list uncompressed files) 5) Try update compressed files $ ./translate compress fr-FR $ ./translate update fr-FR (result is uncompressed) 6) Try install compressed files $ ./translate compress fr-FR $ ./translate install fr-FR 7) Try compress all $ ./translate compress (add '-v' for verbose output) 8) Try uncompress all $ ./translate uncompress (add '-v' for verbose output) Signed-off-by: David Nind Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:18:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:18:32 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #8 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #6) > (In reply to Jonathan Druart from comment #5) > 2) Smaller docker images, perhaps using compressed files from deb/tar > > > > > Is the idea to commit the gz files? > > I don't think so. I don't know much about git, but I think it would be worse > for the size of the repository. We must not, that's why I was asking :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:30:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:30:03 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98211|0 |1 is obsolete| | --- Comment #31 from Ere Maijala --- Created attachment 99376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99376&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Items/MoveItemFromBiblio.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:30:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:30:47 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Ere Maijala --- Fixed tests (use the new params for AddReserve). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:36:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:36:41 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:36:44 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99373|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 99377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99377&action=edit Bug 17896: load BakerTaylor module with use We are incinsistent here, Amazon and Syndetics module are always loaeded in some places BakerTaylor is conditional everywhere, and causes issues under plack For simplicity sake I think we should just load this (small) module where it might be needed To test: 1 - Disable Baker and Taylor images 2 - Restart plack 3 - Visit opac-readingrecord, opac-detail, opac-search, opac-shelves, opac-user Log in to opac Virew your reading history Make/view a list Search the catalog Look at an individual title 4 - Enable BakerTaylorEnabled If you don't have Baker and Taylor credentials, simply fudge them with bad data and enable 5 - Repeat steps above, in the word of Joubu "Kaboom" 6 - Apply patch 7 - Repeat 1-4 8 - You shoudl be able to load all the pages after enabling the pref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:36:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:36:47 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #16 from Jonathan Druart --- Created attachment 99378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99378&action=edit Bug 17896: Remove duplicated use statements and remove uneeded '&' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:37:28 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99376|0 |1 is obsolete| | --- Comment #33 from Ere Maijala --- Created attachment 99379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99379&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Items/MoveItemFromBiblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:38:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:38:24 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha at catalyst.net.nz |nick at bywatersolutions.com Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart --- Did not test but regression tested. Passing QA, thanks Nick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:41:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:41:36 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Have you tried to compile them (with msgfmt) instead of compressing them ? Maybe .mo files can be read by the translator tool without being uncompressed on disk first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:50:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:50:24 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:56:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:56:04 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 14:56:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 13:56:07 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #12 from Devinim --- Created attachment 99380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99380&action=edit New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:01:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:01:27 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:07:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:07:22 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #10 from Bernardo Gonzalez Kriegel --- (In reply to Julian Maurice from comment #9) > Have you tried to compile them (with msgfmt) instead of compressing them ? > Maybe .mo files can be read by the translator tool without being > uncompressed on disk first. Current translation process does not use .mo files, we only use .po files as a bag of matching strings (msgid -> msgsrt) to do search and replace inspecting tt, xml and js files. Besides, .mo binary files are not much smaller than .po files :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:09:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:09:16 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99380|0 |1 is obsolete| | --- Comment #13 from Devinim --- Created attachment 99381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99381&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:14:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:14:42 +0000 Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99045|0 |1 is obsolete| | --- Comment #14 from Devinim --- Created attachment 99382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99382&action=edit Bug 22774: (follow-up) New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:17:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:17:00 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99374|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 99383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99383&action=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:17:04 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #12 from Katrin Fischer --- I found this explanation: "the X-Mailer line in the email header tells you what program was used to draft and send the original email" Example: X-Mailer: Mozilla 4.05 [de] (Win95; I) Koha seems accurate enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:17:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:17:34 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart --- I have tried to put this code in an include file but failed. They are all different! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:24:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:24:39 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:26:54 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:26:57 +0000 Subject: [Koha-bugs] [Bug 24588] Prevent e-mails from Koha to be flagged as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98518|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 99384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99384&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490 at FQDN> 6) Sign off. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:34:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:34:57 +0000 Subject: [Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:34:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:34:59 +0000 Subject: [Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82618|0 |1 is obsolete| | --- Comment #5 from Devinim --- Created attachment 99385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99385&action=edit Bug 21879: Code cleaning in printinvoice.pl The problem is solved. Please apply again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:39:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:39:22 +0000 Subject: [Koha-bugs] [Bug 24705] New: Holds placed via SIP will be given first priority Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Bug ID: 24705 Summary: Holds placed via SIP will be given first priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:42:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:42:52 +0000 Subject: [Koha-bugs] [Bug 24706] New: Toolbar not rendered correctly when a list is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Bug ID: 24706 Summary: Toolbar not rendered correctly when a list is empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org https://snipboard.io/QL5ylv.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:43:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:43:01 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:45:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:45:01 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:45:03 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 --- Comment #1 from Kyle M Hall --- Created attachment 99386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99386&action=edit Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:45:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:45:16 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:45:38 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:45:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:45:41 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 --- Comment #1 from Jonathan Druart --- Created attachment 99387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99387&action=edit Bug 24706: Fix ergonomic issue on the list view if empty If the list is empty, the toolbar does not render correctly. Buttons are displayed instead of links, also the "Sort" is displayed when it should not Test plan: - Create a new list, do not add items - Notice that the toolbar now renders correctly - Use the different link to create/edit/delete - Confirm that the sort link is not displayed - Add a new item - Confirm that the toolbar is looking the same as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 15:51:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 14:51:22 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #11 from Julian Maurice --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > Current translation process does not use .mo files, we only use .po files as > a bag of matching strings (msgid -> msgsrt) to do search and replace > inspecting tt, xml and js files. I know that. What I suggested was to use .mo files as bag of strings too. But that may require additional dependencies, so it may not be worth it, especially if: > .mo binary files are not much smaller than .po files :) I just did a small test: msgfmt -o fr-FR-staff-prog.mo fr-FR-staff-prog.po gzip -k fr-FR-staff-prog.po du -h fr-FR-staff-prog* 824K fr-FR-staff-prog.mo 2,1M fr-FR-staff-prog.po 392K fr-FR-staff-prog.po.gz So, .mo files are smaller than .po files, but not as small as gzipped .po Which is kind of disappointing :/ Anyway, I just wanted to know if you had considered this approach. Thanks for answering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:10:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:10:29 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 --- Comment #12 from Jonathan Druart --- Created attachment 99388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99388&action=edit Bug 22828: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:13:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:13:01 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 --- Comment #13 from Jonathan Druart --- kohadev-koha at df2c0b4bf86c:/kohadevbox/koha$ perl misc/search_tools/rebuild_elasticsearch.pl -v [9614] Checking state of biblios index [9614] Checking state of authorities index [9614] Indexing biblios [9614] Committing final records... [9614] There were errors during indexing [9614] Total 436 records indexed [9614] Indexing authorities [9614] 1000 records processed [9614] Committing final records... [9614] Total 1706 records indexed with -v -v the output is not readable and the error is lost in the middle of the id. Should not we have it at the end? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:19:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:19:54 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Christofer Zorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #2 from Christofer Zorn --- Thank you Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:21:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:21:30 +0000 Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget planning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 --- Comment #7 from Jonathan Druart --- Comment on attachment 99047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99047 Bug 17016: Button to clear all fields in budget planning Review of attachment 99047: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17016&attachment=99047) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt @@ +6,5 @@ > Koha › Administration › Budgets › Funds › Planning for [% budget_period_description | html %] by [% authcat | html %] > [% INCLUDE 'doc-head-close.inc' %] > > + Not needed. @@ +317,5 @@ > + if (type != "button" && type != "submit" ) { > + $(this).val(""); > + $(this).prop('disabled', false); > + } > + if ( type == "checkbox" ) { When is it a checkbox? I always see text inputs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:22:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:22:02 +0000 Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget planning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:40:20 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #48 from Martin Renvoize --- Created attachment 99389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99389&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:40:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:40:24 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99337|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 99390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99390&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:44:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:44:41 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > There is 2 places now where one can close the basket: > - From the basket summary page. I totally agree with the new redirect there. > - From the vendor search results list - This one I am not sure about. I > think the old redirect works better there as it would allow you to quickly > close multiple baskets. > > Jessica, as you signed off, what do you think? I agree with that. Failing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:44:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:44:58 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:00 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #18 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:02 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:04 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #50 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:07 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:09 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:11 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:13 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #37 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:15 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 16:45:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 15:45:16 +0000 Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:00:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:00:27 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99387|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 99391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99391&action=edit Bug 24706: Fix ergonomic issue on the list view if empty If the list is empty, the toolbar does not render correctly. Buttons are displayed instead of links, also the "Sort" is displayed when it should not Test plan: - Create a new list, do not add items - Notice that the toolbar now renders correctly - Use the different link to create/edit/delete - Confirm that the sort link is not displayed - Add a new item - Confirm that the toolbar is looking the same as before Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:00:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:00:59 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:03:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:03:47 +0000 Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent e-mails from Koha |Set `Mailer-X` and |to be flagged as spam |`MessageID` mail headers to | |reduce the likelihood of | |Koha mail being marked as | |spam. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:07:09 +0000 Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:15 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:17 +0000 Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:19 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:21 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 --- Comment #19 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:23 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:25 +0000 Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:27 +0000 Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:08:29 +0000 Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:09:58 +0000 Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:13:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:13:03 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:20:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:20:15 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97068|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 99392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99392&action=edit Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:20:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:20:19 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97069|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 99393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99393&action=edit Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:20:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:20:23 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98507|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 99394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99394&action=edit Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:20:27 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98741|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 99395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99395&action=edit Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:21:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:21:00 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #58 from Martin Renvoize --- Great work Bernardo, thanks for your efforts here.. All looking good and working as expected for me.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:25:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:25:29 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98506|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 99396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99396&action=edit Bug 24262: Translate installer data in YAML format This patch adds the ability to: 1) Create new translation files from yaml installer files 2) Create installer directory for a given language It will not create a installer directory if it already exists. New (possible) translation files: xx-YY-installer.po xx-YY-installer-MARC21.po xx-YY-installer-UNIMARC.po Needs Bug 13897 (for yaml files) NOTE: updated version adding ability to process multiline fields, discard small ( < 2) strings, and discard strings with pure html, TT or punctuation. To test: 1) Apply patches from Bug 13897 2) Apply this patch 3) Go to misc/translation 4) Create translation files for a NEW language $ ./translate create xx-YY check new file 'xx-YY-installer.po' 5) Copy ../../installer/data/mysql/en/optional/auth_val.yml into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/ and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/ remove po/xx-YY*, then repeat creation check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po' and 'xx-YY-installer-UNIMARC.po' remove all new files 6) Create for xx-YY again and try update $ ./translate create xx-YY edit ../../installer/data/mysql/en/optional/auth_val.yml and change one char in one of the translatable values, also edit 'xx-YY-installer.po', translate the same string (in msgstr). Do an update $ ./translate update xx-YY check in 'xx-YY-installer.po' a fuzzy value for the translated value and the preservation of the translation Fix the translation, or add a new one. 7) Create an install dir for xx-YY ./translate install xx-YY Check new dir '../../installer/data/mysql/xx-YY/' Check files on it $ tree ../../installer/data/mysql/xx-YY/ and compare with ../../installer/data/mysql/en/ All installation files must be present 8) Try a new Koha install using this language in the usual way. Check in authorised_values table for the translated string. 9) Try create an install dir for an existing language (eg. es-ES, de-DE or fr-FR ), eg. ./translate install de-DE Install dir is detected and not changed, a note is printed. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:26:52 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Followed the test plan and all looks good to me.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:29:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:29:14 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98414|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 99397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99397&action=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:29:17 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98415|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 99398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99398&action=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:29:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:29:20 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98416|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 99399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99399&action=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:29:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:29:23 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98417|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 99400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99400&action=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:29:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:29:26 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98418|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 99401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99401&action=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:35:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:35:45 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- Great work Bernardo, looks solid to me and installs fine. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:23 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98464|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 99402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99402&action=edit Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:26 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98465|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 99403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99403&action=edit Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:30 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98466|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 99404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99404&action=edit Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:33 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98467|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 99405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99405&action=edit Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:36 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98468|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 99406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99406&action=edit Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:39 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98469|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 99407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99407&action=edit Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:42 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98470|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 99408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99408&action=edit Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:45 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98471|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 99409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99409&action=edit Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:48 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98472|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 99410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99410&action=edit Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:51 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98473|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 99411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99411&action=edit Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:54 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98474|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 99412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99412&action=edit Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:39:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:39:57 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98475|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 99413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99413&action=edit Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:40:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:40:01 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98476|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 99414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99414&action=edit Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:40:04 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98477|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 99415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99415&action=edit Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:40:23 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #31 from Martin Renvoize --- Works well for me.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:42:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:42:57 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98494|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 99416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99416&action=edit Bug 24593: Rewrite marc21_default_matching_rules to YAML YAML version of marc21 optional marc21_default_matching_rules. To test: 1) Do a clean install with optional data, dump table marc_matchers, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' Error! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:43:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:43:00 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98495|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 99417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99417&action=edit Bug 24593: Rewrite marc21_sample_fastadd_framework to YAML YAML version of marc21_sample_fastadd_framework To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:43:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:43:03 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98496|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 99418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99418&action=edit Bug 24593: Rewrite marc21_simple_bib_frameworks to YAML YAML version of marc21_simple_bib_frameworks To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 17:43:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 16:43:58 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Works well.. Signing off. Side note.. we should really standardise on a single YAML module for our parsing :(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:10:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:10:59 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Marcel de Rooy --- (In reply to Ere Maijala from comment #10) > Why isn't the default framework also authoritative for repeatability? We only consider it authoritative for the Koha to MARC mapping. The interface allows you to set repeatability per framework. Which is good. Since we changed mappings, it does no longer look at the other frameworks. So this is the crux of the change. > If not, at least the framework information should be fetched e.g. with > GetMarcSubfieldStructure so that it's cached to avoid a performance penalty, > right? I did experiment a bit with caching but didnt submit that portion. The existing cached structures are based on entry by kohafield, not MARC tags. Makes it a bit less handy. Performance penalty is a big word here. We use this for items. The item editor needs 2 or 3 ms more to open one record (in my benchmarking). Batch item modification depends on the number of items, but is a staff action, probably not executed continuously. Rebuild zebra should not be a problem too. Considering that, I feel that caching is no requirement here. And we can always add it on its own report. Back to NSO. Hoping for a SO ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:14:45 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:14:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:14:48 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96977|0 |1 is obsolete| | Attachment #96978|0 |1 is obsolete| | Attachment #96979|0 |1 is obsolete| | Attachment #96980|0 |1 is obsolete| | Attachment #96981|0 |1 is obsolete| | Attachment #96982|0 |1 is obsolete| | Attachment #96983|0 |1 is obsolete| | Attachment #96984|0 |1 is obsolete| | Attachment #96985|0 |1 is obsolete| | Attachment #96986|0 |1 is obsolete| | Attachment #96987|0 |1 is obsolete| | --- Comment #95 from Nick Clemens --- Created attachment 99419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99419&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:14:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:14:52 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #96 from Nick Clemens --- Created attachment 99420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99420&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:14:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:14:56 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #97 from Nick Clemens --- Created attachment 99421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99421&action=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:15:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:15:00 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #98 from Nick Clemens --- Created attachment 99422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99422&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:15:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:15:04 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #99 from Nick Clemens --- Created attachment 99423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99423&action=edit Bug 21946: Update unit tests to pass under ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:15:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:15:08 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #100 from Nick Clemens --- Created attachment 99424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99424&action=edit Bug 21946: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:18:30 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #101 from Nick Clemens --- (In reply to Nick Clemens from comment #91) > (In reply to Jonathan Druart from comment #90) > > Looks like this dev will conflict with bug 15522. > > Agreed, but I don't think that should be a blocker here. 15522 needs some > work, we are gathering notes to post on that bug. > > This is a much desired feature and should be allowed to proceed Rebased and squashed some patches. In terms of 15522 this only affects dropdowns to select itemtype and ordering of display, otherwise rules are set per itemtype as they have always been, TooMany handles the logic of which to apply when. I don't think this will require large changes there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:42:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:42:37 +0000 Subject: [Koha-bugs] [Bug 24707] New: Remove AMICUS from default fr-CA z39.50 servers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Bug ID: 24707 Summary: Remove AMICUS from default fr-CA z39.50 servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. I propose to remove that entry in the installation files since it is useless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:42:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:42:55 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:55:22 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 18:55:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 17:55:25 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 99425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99425&action=edit Attachment to Bug 24707 - Remove AMICUS from default fr-CA z39.50 servers Bug 24707: Remove AMICUS from default fr-CA z39.50 servers In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. This patch removes that entry in the installation files since it is useless. To test: 1) Apply patch 2) Make a fresh fr-CA install 3) Make sure there are no errors 4) In Administration > Z39.50/SRU servers, make sure AMICUS is not there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 19:04:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 18:04:46 +0000 Subject: [Koha-bugs] [Bug 24708] New: Update Z39.50 server attribute in fr-CA installation file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Bug ID: 24708 Summary: Update Z39.50 server attribute in fr-CA installation file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Now that bug 11297 has been pushed to master, I'd like to amend the installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql file to add the attribute necessary for one of the servers to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 19:04:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 18:04:51 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 19:16:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 18:16:23 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Depends on| |11297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 19:16:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 18:16:23 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 [Bug 24708] Update Z39.50 server attribute in fr-CA installation file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 19:16:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 18:16:27 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 99426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99426&action=edit Attachment to Bug 24708 - Update Z39.50 server attribute in fr-CA installation file Bug 24708: Update Z39.50 server attribute in fr-CA installation file Now that bug 11297 has been pushed to master, I'd like to amend the installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql file to add the attribute necessary for one of the servers to work. This patch adds the attribute in the fr-CA sample_z3950_servers.sql file. To test : 1) Apply patch 2) Go to the database and delete all Z39.50 servers (delete from z3950servers;) 3) Apply the sample_z3950_servers.sql found in installer/data/mysql/fr-CA/facultatif/ 4) In Koha, go to Cataloging and choose to add a record from Z39.50 5) Check BANQ and make a search, you should get results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:07:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:07:23 +0000 Subject: [Koha-bugs] [Bug 24709] New: Advanced editor - show space after delimiter visually Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Bug ID: 24709 Summary: Advanced editor - show space after delimiter visually Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Catalogers would like to visually see if there is a space after the delimiter in the Advanced editor, much like what was done for Bug 24452 - Advanced editor - show multiple spaces visually -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:14:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:14:59 +0000 Subject: [Koha-bugs] [Bug 24710] New: patron-title.inc should have seperate span classes for firstname, othername, surname Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Bug ID: 24710 Summary: patron-title.inc should have seperate span classes for firstname, othername, surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would prefer to be able to customize how the name is displayed in the patron details. If these included classes we could easily move/hide/reorder bits we don;t want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:15:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:15:14 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:15:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:15:27 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:15:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:15:29 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99386|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 99427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99427&action=edit Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:23:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:23:53 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:23:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:23:56 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #1 from Lucas Gass --- Created attachment 99428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99428&action=edit Bug 24710: Add span classes to patron first/other/sur names This patch adds some elements with classes to patron-title.inc TEST PLAN: 1. Have a patron with a firstname, surname, and othername 2. Apply patch 3. There should be no visible changes but if you inscept each element you should see seperate elements with clases. 4. Add each of these to IntranetUserCSS to make sure it hides that element (this effects patroninfo section AND breadcrumbs) .firstname {display: none;} .othernames {display:none}; .surname{display:none} 5. Sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:35:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:35:42 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:35:44 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 --- Comment #1 from Cori Lynn Arnold --- Created attachment 99429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99429&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:36:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:36:11 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |carnold at dgiinc.com |ity.org | --- Comment #2 from Cori Lynn Arnold --- Assigning to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:50:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:50:55 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #2 from Sarah Cornell --- Here's our use case: We want to display the "other name" value at the end of the patron name because we use it for both additional patron names and for nicknames. Current display: Jo (Joy Harjo, Sharon Olds, Gertrude Stein, Mary Oliver) Tech (24518000721715) Ideal display: Jo Tech (Joy Harjo, Sharon Olds, Gertrude Stein, Mary Oliver) (24518000721715) I'd test Lucas' patch myself but I'm not good at the IntranetUserCSS syspref yet. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:56:01 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 20:56:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 19:56:04 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 --- Comment #2 from David Nind --- Created attachment 99430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99430&action=edit Bug 24708: Update Z39.50 server attribute in fr-CA installation file Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:00:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:00:26 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94995|0 |1 is obsolete| | --- Comment #52 from Bouzid Fergani --- Created attachment 99431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99431&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:00:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:00:32 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94996|0 |1 is obsolete| | --- Comment #53 from Bouzid Fergani --- Created attachment 99432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99432&action=edit Bug 20116: Flush the caches When languages are added or removed when need to flush the caches to keep the interface consistent Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:00:37 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94997|0 |1 is obsolete| | --- Comment #54 from Bouzid Fergani --- Created attachment 99433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99433&action=edit Bug 20116: Cache language list Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:02:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:02:26 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #99426|0 |1 is obsolete| | --- Comment #3 from David Nind --- Comment on attachment 99426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99426 Attachment to Bug 24708 - Update Z39.50 server attribute in fr-CA installation file Not sure what I did here, obsoleting so only one patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:13:50 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #126 from Maryse Simard --- Created attachment 99434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99434&action=edit Bug 17674: Handling of special cases This patch adds handling for those 2 particular cases: 1. Deleting the expected issue 2. Deleting a serial and it's item, but one item cannot be deleted To test: 1.1 Create a subscription that creates items 1.2 Receive two issues 1.3 Use the new button to delete the 'Expected' issue 1.4 The issue is correctly deleted, but the new expected issue created to replace the one which has been deleted don't have a published or received date and is show in it's own tab. 1.5 Apply patch 1.6 Repeat steps 1.1 through 1.4 => The new expected issue is created correctly 2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2 2.2 Check out one of the items 2.3 Delete the corresponding serial and check box to delete items 2.4 The serial is deleted, but not the item. => No feedback is show to the user 2.5 Apply patch 2.6 Repeat step 2.1 through 2.4 => As before, the serial is deleted, but not the item => This time, an error is shown to inform the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:14:17 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:38 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81894|0 |1 is obsolete| | --- Comment #41 from Bouzid Fergani --- Created attachment 99435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99435&action=edit Bug 19821: Run tests on a separate database Running the tests on the same database as the one used for dev has some drawbacks: - Everybody has different data, so we cannot make any assumptions about data in tests and it can make tests fail for non-obvious reasons. - Tests have to clean up every change to the database using SQL transactions, so we cannot write testable code that use transactions (AFAIK) - Transactions in tests happen to be committed sometimes, resulting in garbage data added to the dev database This patch provides a .proverc file that will load t/lib/Bootstrap.pm before the tests are run. t/lib/Bootstrap.pm is responsible for recreating a fresh database and telling the test scripts to use it. To use it, just run prove normally from the root directory of Koha. By default, the database is 'koha_test' and it's created using MARC21 SQL files, it can be changed by running: prove --norc \ --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC Test plan: 1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO @localhost 2. cd /path/to/koha 3. prove t/db_dependent/.t 4. Verify that it created the database koha_test and that the one you use usually was untouched (you can edit the test file and comment the lines related to a transaction (txn_begin, txn_rollback)) Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:41 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81895|0 |1 is obsolete| | --- Comment #42 from Bouzid Fergani --- Created attachment 99436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99436&action=edit Bug 19821: Close filehandle after writing Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:45 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81896|0 |1 is obsolete| | --- Comment #43 from Bouzid Fergani --- Created attachment 99437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99437&action=edit Bug 19821: Install sample data, ES mappings and Version syspref Also move .proverc to .proverc.dist, so it cannot be used by accident. Different ways to use it: 1/ prove --rc .proverc.dist Use defaults 2/ cp .proverc.dist .proverc && prove Allows to configure db name, marcflavour, and prove options Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:48 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81897|0 |1 is obsolete| | --- Comment #44 from Bouzid Fergani --- Created attachment 99438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99438&action=edit Bug 19821: Ignore .proverc and .proverc.dist in Makefile.t Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:51 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81898|0 |1 is obsolete| | --- Comment #45 from Bouzid Fergani --- Created attachment 99439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99439&action=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:54 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81899|0 |1 is obsolete| | --- Comment #46 from Bouzid Fergani --- Created attachment 99440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99440&action=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:21:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:21:58 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81900|0 |1 is obsolete| | --- Comment #47 from Bouzid Fergani --- Created attachment 99441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99441&action=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:24:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:24:58 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:53:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:53:36 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95024|0 |1 is obsolete| | --- Comment #3 from Bouzid Fergani --- Created attachment 99442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99442&action=edit Bug 23966 - Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. Test Plan: 1) Enable BranchTransferLimits 2) Create some limits, test adding and removing limits 3) Apply this patch 4) Restart all the things! 5) Reload the page, you should see the same limits in place as before 6) Test adding and removing limits, everything should behave the same as it did before the patch was applied! Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:54:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:54:31 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:54:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:54:34 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99442|0 |1 is obsolete| | --- Comment #4 from Bouzid Fergani --- Created attachment 99443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99443&action=edit Bug 23966 - Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. Test Plan: 1) Enable BranchTransferLimits 2) Create some limits, test adding and removing limits 3) Apply this patch 4) Restart all the things! 5) Reload the page, you should see the same limits in place as before 6) Test adding and removing limits, everything should behave the same as it did before the patch was applied! Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:55:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:55:55 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:55:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:55:58 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99429|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 99444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99444&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. 1) Go to Cataloging -> Advanced editor. 2) On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. 3) Remove the extra space and confirm that the highlight disappears. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:58:43 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:58:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:58:46 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 --- Comment #1 from Lucas Gass --- Created attachment 99445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99445&action=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 21:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 20:59:03 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:00:34 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:00:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:00:36 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95874|0 |1 is obsolete| | --- Comment #14 from Bouzid Fergani --- Created attachment 99446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99446&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:01:15 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99446|0 |1 is obsolete| | --- Comment #15 from Bouzid Fergani --- Created attachment 99447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99447&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:02:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:02:28 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99447|0 |1 is obsolete| | --- Comment #16 from Bouzid Fergani --- Created attachment 99448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99448&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:02:33 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95875|0 |1 is obsolete| | --- Comment #17 from Bouzid Fergani --- Created attachment 99449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99449&action=edit Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290. Coming from an empty or undefined FailedLoginAttempts. Test plan: Verify that Koha/Patrons.t still passes. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:02:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:02:37 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95876|0 |1 is obsolete| | --- Comment #18 from Bouzid Fergani --- Created attachment 99450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99450&action=edit Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Since these operations impact on the resultset, the counts should be saved before. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:03:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:03:49 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99428|0 |1 is obsolete| | --- Comment #3 from Maryse Simard --- Created attachment 99451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99451&action=edit Bug 24710: Add span classes to patron first/other/sur names This patch adds some elements with classes to patron-title.inc TEST PLAN: 1. Have a patron with a firstname, surname, and othername 2. Apply patch 3. There should be no visible changes but if you inscept each element you should see seperate elements with clases. 4. Add each of these to IntranetUserCSS to make sure it hides that element (this effects patroninfo section AND breadcrumbs) .firstname {display: none;} .othernames {display:none}; .surname{display:none} 5. Sign-off Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:04:00 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:09:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:09:35 +0000 Subject: [Koha-bugs] [Bug 24711] New: Can't log in to OPAC after logout if OpacPublic disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Bug ID: 24711 Summary: Can't log in to OPAC after logout if OpacPublic disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org With OpacPublic disabled you are routed to http://localhost:8080/cgi-bin/koha/opac-main.pl?logout.x=1 upon logout. opac-auth.tt adds any inputs it is passed to the login form So you get: Login, and immediately get logged out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:13:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:13:36 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99361|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 99452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99452&action=edit Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:13:49 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:14:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:14:38 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:14:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:14:41 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 --- Comment #1 from Nick Clemens --- Created attachment 99453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99453&action=edit Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:17:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:17:06 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:34:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:34:51 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99322|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer --- Created attachment 99454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99454&action=edit Bug 17702: (RM follow-up) Remove use of I18N tt This patch removes the use of the I18N TT plugin in introduced for all strings in the new template. We're not yet ready to use this plugin for all strings as we need to further investigate performance for such a move and perhaps add template compilation. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:37:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:37:01 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:37:03 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99445|0 |1 is obsolete| | --- Comment #2 from Lisette Scheer --- Created attachment 99455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99455&action=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:38:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:38:14 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #34 from Lisette Scheer --- Apologies for the incorrect patch attachment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:38:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:38:50 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99454|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:38:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:38:55 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99322|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 21 22:51:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 21:51:59 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #2 from Lisette Scheer --- I definitely think this should be configurable by item type, possibly by library as well. I can see the reason for wanting to do it for your example, but might not want to count as multiple items for say, a kit that includes a sewing machine and a power cord listed as different materials on the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 00:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 23:09:58 +0000 Subject: [Koha-bugs] [Bug 23567] Printable QR links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23567 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 00:11:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Feb 2020 23:11:43 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98799|0 |1 is obsolete| | --- Comment #50 from Nightly Build Bot --- Created attachment 99456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99456&action=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 02:39:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 01:39:03 +0000 Subject: [Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 02:42:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 01:42:28 +0000 Subject: [Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 --- Comment #1 from AspenCat Team --- If sort by publication date is not working, it should probably not be an option. It is a nice option so it would be good to have fixed. When results return more records than are easily reviewed it is nice to be able to sort either alphabetical by title (which is also not working) or publication date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 02:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 01:45:33 +0000 Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 02:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 01:47:13 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 06:35:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 05:35:34 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind --- The first patch no longer applies: Bug 24680 - Hold modification endpoints don't always work properly 99241 - Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided 99242 - Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided error: sha1 information is lacking or useless (t/db_dependent/api/v1/holds.t). error: could not build fake ancestor Patch failed at 0001 Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided The second patch works as per the test plan. (For my information - Figured out how to test: installed Insomnia REST client, enabled RESTPublicAPI and RESTBasicAuth system preferences. This is all new to me, so any suggestions on the appropriate tools to use would be appreciated.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 06:58:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 05:58:00 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 06:58:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 05:58:03 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99453|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 99457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99457&action=edit Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 07:15:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 06:15:29 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 07:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 06:15:33 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 --- Comment #2 from David Nind --- Created attachment 99458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99458&action=edit Bug 24707: Remove AMICUS from default fr-CA z39.50 servers In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. This patch removes that entry in the installation files since it is useless. To test: 1) Apply patch 2) Make a fresh fr-CA install 3) Make sure there are no errors 4) In Administration > Z39.50/SRU servers, make sure AMICUS is not there Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 07:17:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 06:17:24 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #99425|0 |1 is obsolete| | --- Comment #3 from David Nind --- Comment on attachment 99425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99425 Attachment to Bug 24707 - Remove AMICUS from default fr-CA z39.50 servers Not sure what I did incorrectly again. Obsoleting patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 09:22:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 08:22:51 +0000 Subject: [Koha-bugs] [Bug 24687] Installation errors in Koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- I do not have a Mint OS to test against, but I can inform you that we are not testing against that distro. Our CI tooks test again Debian 8,9, 10 and Ubuntu 18.04 with various combinations of MySQL and MariaDB. As such those are the recommended and guaranteed distributions. Now, as Mint is Debian based it's likely to work but we do not officially support it. I'm de-escalating this ticket until it's varified. I think Mason may have given the best advice to check on the mailing list to see if anyone else is having similar issues in a similar configuration. As he also states, the community do not maintain any live CDs and as such asking for support with them here will be met with a lack of knowledge. Good luck, I hope your experience with the software improves. In the majority of cases I am met with friendly thanks for all the efforts this wonderful team undertake to support and improve this free and open software. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 09:24:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 08:24:18 +0000 Subject: [Koha-bugs] [Bug 24687] Installation errors in Koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24687 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 09:50:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 08:50:57 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #35 from Martin Renvoize --- (In reply to Martin Renvoize from comment #31) > Created attachment 99322 [details] [review] > Bug 17702: (RM follow-up) Remove use of I18N tt > > This patch removes the use of the I18N TT plugin in introduced for all > strings in the new template. We're not yet ready to use this plugin for > all strings as we need to further investigate performance for such a > move and perhaps add template compilation. > > Signed-off-by: Martin Renvoize I somehow missed that performance comparison.. I'll have a look, thanks for bringing it up.. Jonathan is looking to work on a mass replacement of existing strings to move us over to this standard as a mass change and also update the QA scripts and xt test for filters to prevent the false failures we were seeing on this patch. Thanks Julian.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:09:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:09:38 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 --- Comment #10 from Martin Renvoize --- OK.. I'm loving this work.. I just had a moment of inspiration though.. what about upgrades? Currently, we add to both an atomicupdate file (which gets put into updatedatabase) and add nearly the same code into various .SQL files (now becoming .yaml files) for install time. I'm now wondering if as a further bug we could add a function into updatedatabase to walk through the tree of yaml files to install translated missing default data at the end of any run of updatedatabase and save ourselves from having to write the atomicupdate and the yaml file for such DB changes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:15:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:15:28 +0000 Subject: [Koha-bugs] [Bug 24712] New: Use YAML files for some of the update data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 Bug ID: 24712 Summary: Use YAML files for some of the update data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 13897, 24262 Bug 13897 with bug 24262 refine our translation process for install files converting the old SQL files used in the installer for mandatory and optional data into YAML files and adding processing to allow centralised translation of those files alongside the rest of the translation project. It raises the question, however, of how we should deal with the same data during upgrades. Currently we add the American English values with standard SQL in an atomicupdate file (copied into updatedatabase at push time). I'm envisaging we may be able to do away with the atomicupdates for this type of data insertion during upgrade and replace it with a step inside updatedatabase that pulls the data, translations and all from the yaml files. Opening this bug to discus and attempt such an implementation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:15:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:15:28 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 [Bug 24712] Use YAML files for some of the update data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:15:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:15:28 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 [Bug 24712] Use YAML files for some of the update data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:16:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:16:15 +0000 Subject: [Koha-bugs] [Bug 24712] Use YAML files for some of the update data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:16:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:16:28 +0000 Subject: [Koha-bugs] [Bug 24712] Use YAML files for some of the update data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:16:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:16:40 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:16:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:16:55 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:17:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:17:22 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:18:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:18:25 +0000 Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:18:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:18:25 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24583 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 [Bug 24583] Rewrite mandatory installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:18:46 +0000 Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:18:46 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24584 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 [Bug 24584] Rewrite optional installation files to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:19:01 +0000 Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:19:01 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24593 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 [Bug 24593] Rewrite MARC21 optional data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:19:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:19:21 +0000 Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 10:19:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 09:19:21 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24594 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 [Bug 24594] Rewrite MARC21 mandatory data to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:15:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:15:43 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:29:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:29:10 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:29:21 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:29:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:29:33 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:29:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:29:40 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:29:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:29:47 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:30:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:30:23 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 --- Comment #8 from Martin Renvoize --- Reopened and I will alert them to it personally in Monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:31:48 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 11:32:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 10:32:04 +0000 Subject: [Koha-bugs] [Bug 24677] wrong year picked in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 17:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 16:48:48 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 17:48:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 16:48:52 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99293|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 99459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99459&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 18:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 17:26:54 +0000 Subject: [Koha-bugs] [Bug 24306] Add debug option to koha-indexer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24306 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 24306] Add debug option to koha-indexer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24306 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96621|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 99460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99460&action=edit Bug 24306: Add debug switch to koha-indexer This raises the debug level a lot, it it a bit overwhelming, but may be useful in debugging indexing issues To test: 1 - Apply patches 2 - sudo koha-indexer --stop instance 3 - sudo debian/scripts/koha-indexer --start --debug instance 4 - tail -f /var/log/koha/instance/indexer-output.log 5 - Note you get a listing that nothign in the queue 6 - Go to staff client and make a change to a record 7 - Note the logs have tons of info Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 18:56:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 17:56:48 +0000 Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #8 from David Nind --- Patch no longer applies: root at 333442e28e76:koha(21591)$ git bz apply 21591 Bug 21591 - Data inconsistencies - Item types and biblio level 80757 - Bug 21591: Check for record level item type issues too 88377 - Bug 21591: Additionally check for blank strings in itypes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21591: Check for record level item type issues too Applying: Bug 21591: Additionally check for blank strings in itypes error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 21591: Additionally check for blank strings in itypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 19:37:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 18:37:40 +0000 Subject: [Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #3 from David Nind --- I'm getting a fail on running the tests - everything else seems okay: root at bed39bee2cb5:koha(23763)$ prove -v t/Koha/SearchEngine/Search.t t/Koha/SearchEngine/Search.t .. 1..5 # Subtest: pagination_bar tests 1..14 ok 1 - We paginate all hits if less than max_result_window ok 2 - We have hits/hits_to_paginate pages ok 3 - We calculate current page by offset/results_per_page plus 1 ok 4 - Previous page is current offset minus reults per page ok 5 - Next page is current offset plus reults per page ok 6 - Last page is pages minus 1 times reults per page ok 7 - If on first ten pages we only show 10 pages ok 8 - We paginate all hits if less than max_result_window ok 9 - We have hits/hits_to_paginate pages ok 10 - We calculate current page by offset/results_per_page plus 1 ok 11 - Previous page is current offset minus reults per page ok 12 - Next page is current offset plus reults per page ok 13 - Last page is pages minus 1 times reults per page ok 14 - If past first ten pages we show 20 pages ok 1 - pagination_bar tests # Looks like you planned 5 tests but ran 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/5 subtests Test Summary Report ------------------- t/Koha/SearchEngine/Search.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.86 cusr 0.07 csys = 0.95 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 19:55:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 18:55:02 +0000 Subject: [Koha-bugs] [Bug 24713] New: Staff interface search results page - checkbox to select records is not visible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Bug ID: 24713 Summary: Staff interface search results page - checkbox to select records is not visible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Created attachment 99461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99461&action=edit Screenshots - Checkbox not visible in staff interface search results The checkbox for selecting records for the standard search results in the staff interface is no longer visible. Checked on latest Firefox, Chromium, and Google Chrome on Ubuntu 18.04. I've only noticed this in the last few days - it is fine in 19.11.x and at least a week ago in master. See the screenshots attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 19:55:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 18:55:39 +0000 Subject: [Koha-bugs] [Bug 24713] Staff interface search results page - checkbox to select records is not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 22 23:51:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Feb 2020 22:51:53 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Signed Off |Patch doesn't apply --- Comment #10 from David Nind --- Patch no longer applies: Bug 24131 - Improved formatting for output of updatedatabase 99315 - Bug 24131: Move the print statement to a new subroutine 99316 - Bug 24131: Handle several descriptions 99317 - Bug 24131: (follow-up) Fix and rebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24131: Move the print statement to a new subroutine Applying: Bug 24131: Handle several descriptions Applying: Bug 24131: (follow-up) Fix and rebase error: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). error: could not build fake ancestor Patch failed at 0001 Bug 24131: (follow-up) Fix and rebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 01:04:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 00:04:31 +0000 Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification fallback order is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens --- I think our library is experiencing this bug. When a patron submits a note on an item through the OPAC, Koha sends the email to make it look like it came from the patron's email address. We are able to receive these emails if it is a patron email with the same domain (lancasterseminary.edu). A patron from a different domain (e.g., yahoo.com) had their OPAC note email returned to them because it couldn't be authenticated as coming from their domain. OPAC note emails need to come from the email address set in Koha admin instead of trying to look like they came from the patron. Are we on the same page, Martin? Or do I need to submit this as a separate bug? Thanks, Myka -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 02:38:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 01:38:17 +0000 Subject: [Koha-bugs] [Bug 24714] New: Include ISBN tag in search result items even if no in-built Enhanced Content service for cover images is used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24714 Bug ID: 24714 Summary: Include ISBN tag in search result items even if no in-built Enhanced Content service for cover images is used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: webi at runbox.com QA Contact: testopia at bugs.koha-community.org 3rd-party services commonly use ISBN for image links. This makes it easy to use UserJS to produce them from simple ISBN tags in the HTML. Currently though, one has to check e.g. Google Jackets, only to get them. This works, but also adds completely redundant loading. One solution: a simple unconditional (or conditioned by no Enhanced Content used - after the [% IF ( GoogleJackets ) %] etc. sections ) addition of SEARCH_RESULT.normalized_isbn in opac-results.tt; and corresponding .tt:s, for Intra etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 09:40:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 08:40:47 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #90 from David Nind --- Sorry, the patch no longer applies 8-(... Applying: Bug 7957: Routing lists enhancements .git/rebase-apply/patch:146: trailing whitespace. FROM serial warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Serials.pm M installer/data/mysql/kohastructure.sql M serials/routing-preview.pl .git/rebase-apply/patch:146: trailing whitespace. FROM serial warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Removing serials/routing.pl CONFLICT (modify/delete): serials/routing-preview.pl deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of serials/routing-preview.pl left in tree. Removing serials/reorder_members.pl Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 7957: Routing lists enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:32:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:32:35 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #37 from David Nind --- Patch no longer applies Applying: Bug 17229: Add unit test for BlockExpiredPatronOpacActions check .git/rebase-apply/patch:41: space before tab in indent. dateexpiry => '2000-01-01', warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M t/db_dependent/Holds.t .git/rebase-apply/patch:41: space before tab in indent. dateexpiry => '2000-01-01', .git/rebase-apply/patch:56: new blank line at EOF. + warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t CONFLICT (content): Merge conflict in t/db_dependent/Holds.t error: Failed to merge in the changes. Patch failed at 0001 Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:35:56 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- (In reply to Martin Renvoize from comment #10) > OK.. I'm loving this work.. > > I just had a moment of inspiration though.. what about upgrades? > > Currently, we add to both an atomicupdate file (which gets put into > updatedatabase) and add nearly the same code into various .SQL files (now > becoming .yaml files) for install time. I'm now wondering if as a further > bug we could add a function into updatedatabase to walk through the tree of > yaml files to install translated missing default data at the end of any run > of updatedatabase and save ourselves from having to write the atomicupdate > and the yaml file for such DB changes? I think this might get a little too complicated. For example libraries might have removed sample data on purpose, changed or reconfigured it. It would be hard to differentiate. We will want to add a new notice on update, but should respect if a library deleted it etc. (hope I understood correctly). So I think having different mechanisms (triggered for new and for a specific update) would be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:38:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:38:32 +0000 Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers to reduce the likelihood of Koha mail being marked as spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set `Mailer-X` and |Set `Mailer-X` and |`MessageID` mail headers to |`MessageID` mail headers to |reduce the likelihood of |reduce the likelihood of |Koha mail being marked as |Koha mail being marked as |spam. |spam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:40:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:40:29 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Thx Lucas and Lisette! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:49:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:49:48 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:49:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:49:51 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99430|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 99462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99462&action=edit Bug 24708: Update Z39.50 server attribute in fr-CA installation file Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:52:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:52:09 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Might have a little conflict with bug 24708, but should be easy to resolve for RM ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:52:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:52:33 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:52:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:52:36 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99458|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 99463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99463&action=edit Bug 24707: Remove AMICUS from default fr-CA z39.50 servers Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:56:16 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #38 from David Nind --- You get an error on the patron's page when following the test plan, but before trying to apply the patch - the URL is entered: 1) For the patron, the holds tab heading shows that there is a hold (1). 2) When you click on the patron's holds tab a message pops up with "DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7" 3) The bibliographic record shows that there is a hold. Other notes for testing: - Enable the ILS-DI system preference - The BlockExpiredPatronOpacActions system preference options are now 'Block' and 'Don't block', rather then 'ON' - For the URL, enter the bibliographic record id, not an individual item id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 10:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 09:56:44 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Lucas, looking at the patch I wonder why some classes seem to be missing: [%- IF display_patron_name -%] [%- IF data.category_type == 'I' -%] - [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] + [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] [%- ELSIF invert_name -%] - [% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%] + [% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%] Here the surname could have a class as well, to keep things consistent. [%- ELSE -%] - [% data.title | $raw %][%- data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname | html -%] + [% data.title | $raw %][%- data.firstname | html %] [% IF data.othernames %]([% data.othernames | html %]) [% END %] [% data.surname | html -%] Should we add a class for title as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:02:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:02:49 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:02:53 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99459|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 99464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99464&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:10:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:10:30 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Love the patch, but sadly it removes the 'search' input field above the table in my tests, that we have without the configuration. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:13:50 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:13:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:13:54 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99391|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 99465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99465&action=edit Bug 24706: Fix ergonomic issue on the list view if empty If the list is empty, the toolbar does not render correctly. Buttons are displayed instead of links, also the "Sort" is displayed when it should not Test plan: - Create a new list, do not add items - Notice that the toolbar now renders correctly - Use the different link to create/edit/delete - Confirm that the sort link is not displayed - Add a new item - Confirm that the toolbar is looking the same as before Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:17:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:17:25 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 11:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 10:17:28 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99457|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 99466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99466&action=edit Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 14:57:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 13:57:39 +0000 Subject: [Koha-bugs] [Bug 23510] Allow QR codes to be used in label/patroncard creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23510 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 15:29:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 14:29:13 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel --- Hi, is this still valid? I tested using 18.11.14 and error message from test plan does not show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 16:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 15:39:15 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 16:39:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 15:39:18 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99354|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 99467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99467&action=edit Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 16:43:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 15:43:04 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 16:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 15:43:07 +0000 Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99355|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 99468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99468&action=edit Bug 24699: Split items.uri in OPAC detail view Same change as in bug 24697 for staff. If there are more URIs in 952u, we split them and show the real URL instead of Link to resource or the value of pref URLLinkText. I introduced a few template variables here to make the code a bit more compact and readable. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 18:05:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 17:05:27 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #93 from David Nind --- Patch no longer applies: root at e83d8895749e:koha(bz11999)$ git bz apply 11999 Bug 11999 - Add two checks in CanBookBeReserved and CanItemBeReserved 91581 - Bug 11999: Check for age restriction in CanBookBeReserved 91591 - Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved 91593 - Bug 11999: Test improvements Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11999: Check for age restriction in CanBookBeReserved error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 11999: Check for age restriction in CanBookBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 18:10:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 17:10:26 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #94 from David Nind --- Similar to Bug 17229 you get an error on the patron's page when following the test plan (step 2 before patch), but before trying to apply the patch: 1) For the patron, the holds tab heading shows that there is a hold (1). 2) When you click on the patron's holds tab a message pops up with "DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7" 3) The bibliographic record shows that there is a hold. I'm assuming that is because the DataTables feature for displaying results is a more recent addition to Koha. (Test URL I used for ILS_DI was http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=15&request_location='127.0.0.1' using koha-testing-docker) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 18:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 17:29:03 +0000 Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- The patch still applies! Not sure whether comment 2 needs to be addressed (make it work when creating from the command line) so that bug can progress. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:21:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:21:23 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:21:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:21:27 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99455|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 99469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99469&action=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:25:41 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99469|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 99470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99470&action=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:27:38 +0000 Subject: [Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 --- Comment #7 from Lucas Gass --- Cait, It looks like I was missing a dataTable configuation, I added this back in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:38:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:38:44 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:38:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:38:47 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99339|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 99471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99471&action=edit Bug 23547: Add column configuration to course reserves table in the OPAC This patch adds opac-course-reserves to the column config tool TEST PLAN: 1. Have some course reserves and go look at opac-course-reserves.pl 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > course_reserves_table 5. Try hiding each column and make sure the correct column is hidden on opac-course-reserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 19:40:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 18:40:09 +0000 Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 --- Comment #5 from Lucas Gass --- re-added the dataTables confiuration line to allow for a search bar within the table. reset to needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:00:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:00:59 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:01:02 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99451|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 99472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99472&action=edit Bug 24710: Add span classes to patron first/other/sur names This patch adds some elements with classes to patron-title.inc TEST PLAN: 1. Have a patron with a title, firstname, surname, and othername 2. Apply patch 3. There should be no visible changes but if you inscept each element you should see seperate elements with clases. 4. Add each of these to IntranetUserCSS to make sure it hides that element (this effects patroninfo section AND breadcrumbs) .firstname {display: none;} .othernames {display:none}; .surname{display:none;} .title{display:none;} 5. Sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:29:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:29:23 +0000 Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget planning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:30:17 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 --- Comment #6 from Aleisha Amohia --- I wrote a patch addressing the solution in the description of this bug. If we don't want that solution anymore, surely just close the bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:35:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:35:38 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 --- Comment #7 from Katrin Fischer --- Hi Aleiha, when there was only one page where you could close the basket (the basket summary page) this made a lot of sense - and it still does. The problem is that a not so long while ago another page was added where you can close the basket - the 'search result' page when you search for the vendor. So the thing that was strange here, that it would not return to the page where you started from, applies now there. Would it be possible to just return to the page where you came from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:37:17 +0000 Subject: [Koha-bugs] [Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #8 from Aleisha Amohia --- Ah yup understood, thanks Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:48:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:48:05 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 20:48:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 19:48:09 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97939|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 99473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99473&action=edit Bug 24291: Update the item type form text for library limitation field Bug 15497 introduced the ability to limit item types by library. However, the text next to the 'Library limitation' selection field on the item type form mentions authorized values and is confusing. The current text reads: "Select 'All libraries' if this authorized value must be displayed all the time. Otherwise select libraries you want to associate with this value." This patch updates the text on the item type add or edit form for the 'Library limitation' field to something more understandable. To test: 1) Apply the patch 2) Go to Administration > Basic parameters > Item types 3) Click 'Edit' for any item type 4) The text next to the 'Library limitation' field should now show "Select 'All libraries' if all libraries use this item type. Otherwise, select the specific libraries that use this item type." 5) Sign off Signed-off-by: Bernardo Gonzalez Kriegel String change, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 23:08:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 22:08:30 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 23:08:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 22:08:34 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 99474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99474&action=edit Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental, has a problem for biblio with multiple items. The first SQL query gets the biblios linked to items with issues in statistics : SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit GROUP BY biblio.biblionumber The second SQL query is : SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL GROUP BY biblio.biblionumber The problem is that this second query will set to 0 where ANY item has no entry in statistics table. So when running it sets 0 to the biblio that had a value from first query. I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN : LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue') Test plan : 1) Begin with an empty database 2) Create a biblio 1 with no items 3) Create a biblio 2 with 3 items 4) Create a biblio 3 with 2 items 5) Checkout and checkin all items of biblio 2 6) Checkout and checkin the firt item of biblio 3 7) run misc/cronjobs/update_totalissues.pl --use-stats -v 8) Check biblio 1 has biblioitems.totalissues = 0 9) Check biblio 2 has biblioitems.totalissues = 3 10) Without patch the biblio 3 has biblioitems.totalissues = 0 11) With patch the biblio 3 has biblioitems.totalissues = 1 12) Check misc/cronjobs/update_totalissues.pl --incremental is OK Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. totalissues is calculated correctly, incremental works ok. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 23 23:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 22:50:18 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, What kind of record is needed? I edited a record to add an 830 field, does not show in the opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 00:00:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 23:00:41 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 00:00:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 23:00:44 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99299|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 99475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99475&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally Signed-off-by: Bernardo Gonzalez Kriegel catalogue/detail.pl dies without GD. Seems correct switch to require No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 00:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 23:04:00 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #29 from David Cook --- I won't be at the Marseille hackfest, but maybe some folk will think about working on this there next month? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 00:52:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Feb 2020 23:52:08 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Hayley Mapley --- Backported to 18.11.x for 18.11.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:17:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:17:03 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Bernardo, you also need a 490 where the indicator is set to traced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:19:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:19:42 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #6 from Katrin Fischer --- Hi Lucas, if you do a follow-up (a second patch with the requested changes) next time, you can keep the signed-off status most of the time (also applies to bug 23547) and the original sign-offer won't be lost either. It's how we usually handle things once the first sign-off has been achieved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:23:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:23:58 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 --- Comment #4 from Marcel de Rooy --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > Signed-off-by: Bernardo Gonzalez Kriegel > Works as described, no errors. Thx Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:26:28 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Ere Maijala --- Ok, I'm fine with the framework stuff, but it strikes me a bit odd that we use mapping from default framework and repeatability from another. Unless I'm completely lost it provides ample opportunity for user confusion. Sorry, I'd say that caching is pretty crucial. TransformKohaToMarc is used also e.g. in the Elasticsearch index builder, OAI-PMH Provider and exporter (really, anything that calls e.g. EmbedItemsInMarcBiblio). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:31:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:31:26 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #14 from Marcel de Rooy --- (In reply to Ere Maijala from comment #13) > Ok, I'm fine with the framework stuff, but it strikes me a bit odd that we > use mapping from default framework and repeatability from another. Unless > I'm completely lost it provides ample opportunity for user confusion. The interface follows this line. No frameworks in Koha to MARC mappings. No possibility to change kohafield in framework editor (as before). All other fields (like repeatability) are framework based. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:31:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:31:54 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #15 from Marcel de Rooy --- (In reply to Ere Maijala from comment #13) > Sorry, I'd say that caching is pretty crucial. TransformKohaToMarc is used > also e.g. in the Elasticsearch index builder, OAI-PMH Provider and exporter > (really, anything that calls e.g. EmbedItemsInMarcBiblio). Will address that on a new report then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:32:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:32:46 +0000 Subject: [Koha-bugs] [Bug 24715] New: Cache repeatable subfield in TransformKohaToMarc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Bug ID: 24715 Summary: Cache repeatable subfield in TransformKohaToMarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Follow-up of bug 21800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:32:55 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:32:55 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 [Bug 24715] Cache repeatable subfield in TransformKohaToMarc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:33:13 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 08:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 07:33:36 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:19:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:19:28 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #16 from Ere Maijala --- If it's in a separate issue, how do we make sure bug 24715 and this one are committed at same time? My concern is that this one alone will introduce a serious performance regression, and if 24715 doesn't get committed at the same time, developers and in worst case also users suffer the consequences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:40:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:40:06 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:40:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:40:09 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99241|0 |1 is obsolete| | --- Comment #7 from Ere Maijala --- Created attachment 99476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99476&action=edit Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided Before this fix the endpoint would accept the request but fail to actually update the hold if the request does not contain a priority parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:40:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:40:12 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99242|0 |1 is obsolete| | --- Comment #8 from Ere Maijala --- Created attachment 99477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99477&action=edit Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint Before this patch the response would return current date as the suspension end date for a hold that is suspended with no end date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:44:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:44:23 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #9 from Ere Maijala --- Oops, sorry. I had some remnants of another fix there. Should apply properly now. For tools, I use RESTer plugin for Firefox (it's mentioned in bug 20402). It supports also OAuth2 with Koha. For this bug it doesn't really matter, though, so whatever client that can send a proper request is fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:50:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:50:25 +0000 Subject: [Koha-bugs] [Bug 22820] Display 830 series information when there is no 490 tag (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 09:54:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 08:54:57 +0000 Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Should we add a dependency reference here for Cache::Memcached::Fast::Safe ? Strange that it is not even mentioned anywhere on the report.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:05:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:05:47 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at outlook.com --- Comment #6 from Emmi Takkinen --- Maybe this needs to be reworked entirely? Bug 12603 introduced TestBuilder module so bug 13906 might not be valid anymore. Also I think GetAllBorrowersWithUnpaidFines should be implemented in Patrons.pm instead of C4::Accounts.pm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:07:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:07:33 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart --- Failing QA. Agustin please investigate comment 12 and tell us if there is a possibility to simplify your code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:23:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:23:02 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Magnus Enger --- Setting status to NSO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:23:19 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:23:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:23:23 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98740|0 |1 is obsolete| | --- Comment #10 from Magnus Enger --- Created attachment 99478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99478&action=edit Bug 24629: SIP log - Display barcode instead of hash Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:24:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:24:02 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #69 from Emmi Takkinen --- Created attachment 99479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99479&action=edit Bug 17499: Define koha_object(s)_class where needed This patch adds koha_object(s)_class for needed modules to fix issues with tests. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:24:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:24:39 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99370|0 |1 is obsolete| | --- Comment #11 from Magnus Enger --- Created attachment 99480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99480&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes Signed-off-by: Magnus Enger This patch and the one from Jonathan taken together seems to solve the problem, I no longer see messages with HASH(...). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:26:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:26:03 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:26:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:26:06 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99476|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 99481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99481&action=edit Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided Before this fix the endpoint would accept the request but fail to actually update the hold if the request does not contain a priority parameter. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:26:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:26:10 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99477|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 99482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99482&action=edit Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint Before this patch the response would return current date as the suspension end date for a hold that is suspended with no end date. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:27:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:27:28 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #12 from David Nind --- (In reply to Ere Maijala from comment #9) > For tools, I use RESTer plugin for Firefox (it's mentioned in bug 20402). It > supports also OAuth2 with Koha. For this bug it doesn't really matter, > though, so whatever client that can send a proper request is fine. Thanks! All tested and signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:28:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:28:39 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #70 from Emmi Takkinen --- Tests should work now. Keeping status as Failed QA since I'm also unsure what it should be after Tomás's comment (comment 66) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:31:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:31:53 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:37:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:37:25 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #71 from David Nind --- (In reply to Emmi Takkinen from comment #70) > Tests should work now. > > Keeping status as Failed QA since I'm also unsure what it should be after > Tomás's comment (comment 66) Can confirm, tests all pass now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:43:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:43:41 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:43:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:43:44 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99427|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 99483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99483&action=edit Bug 24705: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:43:47 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 --- Comment #5 from Jonathan Druart --- Created attachment 99484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99484&action=edit Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:54:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:54:07 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- That does not work. To replicate: uncheck first checkbox from tab 1 uncheck second checkbox from tab 2 uncheck third checkbox from tab 3 save third first checkboxes are unchecked from all 3 tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:54:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:54:23 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 --- Comment #6 from Jonathan Druart --- Also please fix commit title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:35 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:37 +0000 Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:39 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:41 +0000 Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:42 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:44 +0000 Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:46 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 10:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 09:58:47 +0000 Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:05:33 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:05:35 +0000 Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:05:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:05:37 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:05:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:05:38 +0000 Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:06:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:06:57 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #72 from Jonathan Druart --- I had a very quick look at the patch. About the tests I would like to see the subroutines replaced with a call to $builder->build_object when it is the only thing they actually do. Example: sub build_a_test_transport_type { my $mtt = $builder->build({ source => 'MessageTransportType' }); return Koha::Patron::Message::Transport::Types->find( $mtt->{message_transport_type} ); } can be replaced with: $builder->build_object({ class => 'Koha::Patron::Message::Transport::Types' }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:07:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:07:01 +0000 Subject: [Koha-bugs] [Bug 24716] New: Foreign language doesnt show. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24716 Bug ID: 24716 Summary: Foreign language doesnt show. Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: thanasisthanasis96 at windowslive.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi everyone, i am new to Koha. My library has both English and Greek books. When i add a book with greek characters, the biblio table fills correctly, but biblio_metadata (in the collumn metadata) the xml doesnt show the greek characters. That way the recordings have only the ISBN code correctly. It is a coding issue because he english books are all saved correctly, but what is it?! Thank you all :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:44:28 +0000 Subject: [Koha-bugs] [Bug 24306] Add debug option to koha-indexer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Why --debug and not --verbose? Note that koha-elasticsearch has a verbose flag (and other script in debian/scripts) You should also update debian/docs/koha-indexer.xml, and maybe tell that the new flag is not for production use, bug debug purpose only (obvious if you keep --debug, but worth a note if we go with --verbose). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:49:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:49:16 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Why do you split on | ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 11:51:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 10:51:30 +0000 Subject: [Koha-bugs] [Bug 24697] Split items.uri on staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24697 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > Why do you split on | ? It is the character used when gluing values in MARC to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:10:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:10:28 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:10:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:10:31 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99473|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 99485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99485&action=edit Bug 24291: Update the item type form text for library limitation field Bug 15497 introduced the ability to limit item types by library. However, the text next to the 'Library limitation' selection field on the item type form mentions authorized values and is confusing. The current text reads: "Select 'All libraries' if this authorized value must be displayed all the time. Otherwise select libraries you want to associate with this value." This patch updates the text on the item type add or edit form for the 'Library limitation' field to something more understandable. To test: 1) Apply the patch 2) Go to Administration > Basic parameters > Item types 3) Click 'Edit' for any item type 4) The text next to the 'Library limitation' field should now show "Select 'All libraries' if all libraries use this item type. Otherwise, select the specific libraries that use this item type." 5) Sign off Signed-off-by: Bernardo Gonzalez Kriegel String change, no errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:28:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:28:45 +0000 Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:32:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:32:00 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #13 from Andrew Isherwood --- Some weirdness going on here. The error is a result of the "jsinclude" block (which should not be there in 18.11, and which this bug removed) being parsed by TT. jsinclude blocks should only be parsed if the "footerjs" flag is set prior to the "jsinclude" block in the mark up. As far as I can see, the 18.11 version of this template has *never* included a footerjs flag, so I don't see how the jsinclude block can ever have been parsed and the resulting error displayed (scratches head). So, you're right Bernardo, the error is not being displayed. However, the jsinclude block should not be present in the template because it references files that do not exist in 18.11. So we still need to get the patches in this bug merged. I think the only test plan I can offer in that case is: - Do not apply the patch - View koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt - TEST: Verify that it includes a "jsinclude" block near the bottom of the template - Apply the patch - Re-open the template - TEST: Verify that the "jsinclude" block is now gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:32:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:32:05 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:32:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:32:08 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98040|0 |1 is obsolete| | Attachment #99474|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 99486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99486&action=edit Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental, has a problem for biblio with multiple items. The first SQL query gets the biblios linked to items with issues in statistics : SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit GROUP BY biblio.biblionumber The second SQL query is : SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL GROUP BY biblio.biblionumber The problem is that this second query will set to 0 where ANY item has no entry in statistics table. So when running it sets 0 to the biblio that had a value from first query. I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN : LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue') Test plan : 1) Begin with an empty database 2) Create a biblio 1 with no items 3) Create a biblio 2 with 3 items 4) Create a biblio 3 with 2 items 5) Checkout and checkin all items of biblio 2 6) Checkout and checkin the firt item of biblio 3 7) run misc/cronjobs/update_totalissues.pl --use-stats -v 8) Check biblio 1 has biblioitems.totalissues = 0 9) Check biblio 2 has biblioitems.totalissues = 3 10) Without patch the biblio 3 has biblioitems.totalissues = 0 11) With patch the biblio 3 has biblioitems.totalissues = 1 12) Check misc/cronjobs/update_totalissues.pl --incremental is OK Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. totalissues is calculated correctly, incremental works ok. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:32:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:32:49 +0000 Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 --- Comment #3 from Martin Renvoize --- Could you elaborate a bit for me Owen.. broken in what way.. for me sorting is working on all fields with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:38:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:38:36 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- It does not die for me, it dies if I enable LocalCoverImages, then try to upload an image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:41:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:41:56 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- Ere, do not you think we should set the values only if passed, instead? Like: my $params = { id => $id, ( defined $foo ? foo => $foo : () ), ( defined $bar ? bar => $bar : () ), }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:44:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:44:35 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #14 from Ere Maijala --- Jonathan, unfortunately ModReserve wants them all, and I think that changing it to make the call easier is far more risky. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:52:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:52:44 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #4 from Julian Maurice --- Maybe we should clarify what does *required* mean for us. Personally I believe that every Perl module that we directly `use` or `require` without checking its presence should be flagged as required. Even if the require is behind a syspref check or something like that. Put more simply, if Koha dies because of a missing Perl module, that module is a required dependency. Maybe later we can build something based on cpanfile's `feature` (https://metacpan.org/pod/distribution/Module-CPANfile/lib/cpanfile.pod#feature) to warn when an optional feature is enabled and the required modules for this feature are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 12:59:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 11:59:49 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Arthur, the tests from t/SimpleMARC.t will need to be adjusted as well. # Failed test 'copy_and_replace_field' # at t/SimpleMARC.t line 1471. # Looks like you failed 2 tests of 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:01:29 +0000 Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24533 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:01:29 +0000 Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24456 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:05:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:05:41 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- (In reply to Julian Maurice from comment #4) > Maybe we should clarify what does *required* mean for us. > > Personally I believe that every Perl module that we directly `use` or > `require` without checking its presence should be flagged as required. Even > if the require is behind a syspref check or something like that. Put more > simply, if Koha dies because of a missing Perl module, that module is a > required dependency. > > Maybe later we can build something based on cpanfile's `feature` > (https://metacpan.org/pod/distribution/Module-CPANfile/lib/cpanfile. > pod#feature) to warn when an optional feature is enabled and the required > modules for this feature are missing. The whole 'feature' stuff from the cpanfile move came up earlier that I was expecting.. but I suspected it would raise it's head at some point. I'm really not sure what way to fall on this one.. I don't like that changing a syspref can completely 'break', i.e lead to a die, koha.. but at the same time if a set of functionality is optional, the dependencies it requires really aught to be too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:12:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:12:48 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99478|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 99487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99487&action=edit Bug 24629: SIP log - Display barcode instead of hash Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:12:51 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99480|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 99488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99488&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:13:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:13:09 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Trivial fix, thanks guys.. PQA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:15:56 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99452|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 99489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99489&action=edit Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:21 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Useful simple improvement.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:22 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:25 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99362|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy --- Created attachment 99490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99490&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:30 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99363|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy --- Created attachment 99491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99491&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:35 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99364|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy --- Created attachment 99492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99492&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '
    .' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:36 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Hi Aleisha, A couple of things: 1. After 7, I still have the "Add to a list:" popup that does not close. I think that is not correct. 2. I am wondering how we could improve the ergonomic of the last view, maybe Owen could help us? https://snipboard.io/GYxbaS.jpg Especially if there is no list, we see """ Next steps: * New batch record modification """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:41 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99365|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy --- Created attachment 99493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99493&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:45 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99366|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 99494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99494&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:50 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99367|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 99495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99495&action=edit Bug 22880: (QA follow-up) Fix "koha_news_block: not found" To make qa tools happy again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:55 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #60 from Marcel de Rooy --- Created attachment 99496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99496&action=edit Bug 22880: (QA follow-up) Remove opacheader from C4::Auth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:16:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:16:59 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #61 from Marcel de Rooy --- Created attachment 99497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99497&action=edit Bug 22880: (QA follow-up) Pass lang instead of news_lang in masthead Might be a rebase problem. Not sure if I look at the third patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:17:04 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #62 from Marcel de Rooy --- Created attachment 99498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99498&action=edit Bug 22880: (QA follow-up) Replace use by require Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:19:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:19:02 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #14 from Marcel de Rooy --- Fasten your seatbelts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:22:09 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99448|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 99499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99499&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:22:12 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99449|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 99500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99500&action=edit Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290. Coming from an empty or undefined FailedLoginAttempts. Test plan: Verify that Koha/Patrons.t still passes. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:22:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:22:15 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99450|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 99501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99501&action=edit Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Since these operations impact on the resultset, the counts should be saved before. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:22:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:22:39 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #22 from Martin Renvoize --- Nice improvement, no regressions found.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:24:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:24:25 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:24:45 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 --- Comment #4 from Martin Renvoize --- Sorry Jonathan, this one needs a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:27:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:27:02 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Are you intending to come back to this one Kyle? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:28:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:28:09 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:28:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:28:12 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #15 from Marcel de Rooy --- Created attachment 99502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99502&action=edit Bug 24705: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:28:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:28:17 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #16 from Marcel de Rooy --- Created attachment 99503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99503&action=edit Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:28:21 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #17 from Marcel de Rooy --- Created attachment 99504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99504&action=edit Bug 24708: Update Z39.50 server attribute in fr-CA installation file Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:29:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:29:50 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:29:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:29:52 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:29:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:29:54 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:29:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:29:56 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:30 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99068|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 99505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99505&action=edit Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:34 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99069|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 99506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99506&action=edit Bug 24545: Fix find-license-problems.t to catch future wrong license statements File adjust to run tests and be executed on all our codebase. Test plan: - Apply this patch without the other one - run the tests => Several failures - apply the other patch - run the tests => Should pass now Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:38 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99070|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 99507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99507&action=edit Bug 24545: (follow-up) Fix license statements Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:48 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:49 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:31:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:31:52 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99130|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 99508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99508&action=edit Bug 24675: Update MARC21 config for bib_heading_fields To reproduce: - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink - Edit or open any biblio record - fill all subfields of the field 100 In my case , I have $a, $d, $e, $q - Save and continue editing - Check the $9 of the field 100 filled for the authid(auto create of authority) - Open the detail of the new authority created using authid ($9) - In the new authority, $e is not filled This problem produce, because in C4/Heading/MARC21.pm, the list of subfields for each field is not upated since 2011. The source of new list of subfields is : library of congress (https://www.loc.gov/marc/bibliographic) When applying the patch, all subfields is reported correctly in the new authority. NB: All the subfields not written in the file C4/Heading/MARC21.pm have the same problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:34:18 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #21 from Marcel de Rooy --- xt/find-license-problems.t # Looks like you failed 6 tests of 1134. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:37:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:37:06 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:37:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:37:09 +0000 Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98539|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 99509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99509&action=edit Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:39:09 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #17 from Marcel de Rooy --- (In reply to Ere Maijala from comment #16) > If it's in a separate issue, how do we make sure bug 24715 and this one are > committed at same time? My concern is that this one alone will introduce a > serious performance regression, and if 24715 doesn't get committed at the > same time, developers and in worst case also users suffer the consequences. We did that before, Ere. And note that I do not confirm that this is a serious performance regression. If so, please make it solid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:43:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:43:43 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > It does not die for me, it dies if I enable LocalCoverImages, then try to > upload an image. That was wrong, I removed libgd-perl, that removed koha-common. The alias restart_all got broken, as it did not correctly restart plack, etc. So yes, detail.pl crashes with GD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:44:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:44:57 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:44:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:44:59 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99475|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 99510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99510&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally Signed-off-by: Bernardo Gonzalez Kriegel catalogue/detail.pl dies without GD. Seems correct switch to require No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:45:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:45:21 +0000 Subject: [Koha-bugs] [Bug 22248] Error when incrementing Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Any update here Alex? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:45:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:45:43 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #8 from Jonathan Druart --- We will make it (really) optional if there is a real need for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:48:48 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #15 from Jonathan Druart --- (In reply to Martin Renvoize from comment #14) > Trivial fix, thanks guys.. > > PQA That is not that trivial in my opinion. We should track down a bit where does come from (and the possible problems) the 2 different types in the item list (scalar vs hashref). I think I asked Nick last Friday but cannot remember the conclusion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:49:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:49:07 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:49:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:49:09 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91907|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 99511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99511&action=edit Bug 23411 - SMS messages should not fall back to 'email' To test: 1 - Have a patron wiht an sms number, but no email 2 - Enable sms by setting SMSDriver syspref to Email 3 - Set Notice triggers to send an overdue via sms and email 4 - Ensure the selected notice is defined only for 'email' 5 - Checkout an overdue to the patron above You can set a specify a due date in the past 6 - perl misc/cronjobs/overdue_notices.pl -t 7 - Check the patron notices tab, they have a print notice and an SMS notice pending 8 - The SMS notice used the 'email' template 9 - Apply patch 10 - sudo koha-mysql kohadev 11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; 12 - Run the cron again 13 - Patron should have a print notice queued, no sms 14 - Define an SMS notice 15 - delete the message queue 16 - Run again 17 - The patron should have a print and an SMS Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:53:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:53:58 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:54:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:54:01 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96390|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 99512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99512&action=edit Bug 24219: Preserve sort order when returning to result list There is a mismatch between sort_cgi, sort and sort_by variables. * sort_cgi I did not find relevant occurrences of sort_cgi in the git log of both search.pl and results.tt. So it seems that it never worked correctly. * sort It is the JS variable use in browser.js * sort_by is the search.pl parameter to set the sort_by option Test plan: 1. Perform a search in the staff client 2. Change the sort order to something different (try Author A-Z) 3. Click on a result to view the record 4. Click on "Results" button on left side to return to result list => Without this patch the result list is sorted by relevancy => With this patch applied the Author A-Z is kept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 13:55:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 12:55:54 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Afraid this one no longer applies.. I'm not close enough to MARC practices at the moment to rebase.. looks reasonably trivial for someone who is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:00:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:00:48 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #22 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #21) > xt/find-license-problems.t > # Looks like you failed 6 tests of 1134. Those are newly added scripts, they need to be fixed as well before push. Follow-up coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:05:36 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #23 from Jonathan Druart --- Created attachment 99513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99513&action=edit Bug 24545: Fix newly added files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:10:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:10:11 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:10:13 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 --- Comment #1 from Marcel de Rooy --- Created attachment 99514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99514&action=edit Bug 24715: Cache repeatable subfield in TransformKohaToMarc Implemented by calling GetMarcSubfieldStructure. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Optionally, follow the test plan of 21800#comment7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:11:00 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99514|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 99515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99515&action=edit Bug 24715: Cache repeatable subfield in TransformKohaToMarc Implemented by calling GetMarcSubfieldStructure. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Optionally, follow the test plan of bug 21800#comment7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:14:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:14:09 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 --- Comment #3 from Marcel de Rooy --- Ere: Hopefully this proves to be faster. In a bad case we are reading and caching the whole framework instead of reading one record. But note that a few checks are done before wasting time on that.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:20:35 +0000 Subject: [Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99515|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 99516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99516&action=edit Bug 24715: Cache repeatable subfield in TransformKohaToMarc Implemented by calling GetMarcSubfieldStructure. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Optionally, follow the test plan of bug 21800#comment7. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:21:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:21:14 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:21:53 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:21:54 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #23 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:21:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:21:56 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:21:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:21:58 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:00 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:02 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #29 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:04 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:05 +0000 Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:07 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:09 +0000 Subject: [Koha-bugs] [Bug 24629] SIP2 logs garbage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:11 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:12 +0000 Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:14 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:22:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:22:16 +0000 Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:31 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:33 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #63 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:35 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:36 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:38 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:27:40 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #24 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:37:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:37:02 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #18 from Ere Maijala --- (In reply to Marcel de Rooy from comment #17) > (In reply to Ere Maijala from comment #16) > > If it's in a separate issue, how do we make sure bug 24715 and this one are > > committed at same time? My concern is that this one alone will introduce a > > serious performance regression, and if 24715 doesn't get committed at the > > same time, developers and in worst case also users suffer the consequences. > > We did that before, Ere. And note that I do not confirm that this is a > serious performance regression. If so, please make it solid. I failed to realize that the code checks for the pipe character first. So the database call doesn't actually get executed that often. Sorry about the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:38:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:38:19 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:38:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:38:22 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99309|0 |1 is obsolete| | --- Comment #19 from Ere Maijala --- Created attachment 99517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99517&action=edit Bug 21800: Add tests for repeatable subfields Test plan: Do not apply the second patch [note 1]. Run t/db_dependent/Biblio/TransformKohaToMarc.t Run t/db_dependent/Biblio/TransformMarcToKoha.t Apply the second patch and run them again. Both tests should pass now. Note 1: The TransformKohaToMarc test should fail with something like: # Failed test 'Check 260e' # at t/db_dependent/Biblio/TransformKohaToMarc.t line 60. # got: 'A' # expected: 'A | B' Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:38:25 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99310|0 |1 is obsolete| | --- Comment #20 from Ere Maijala --- Created attachment 99518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99518&action=edit Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields If a kohafield (in Koha to MARC mappings) contains a pipe char (say A | B), we split it up into two subfields A and B in MARC. We will only do that for repeatable subfields now. If the field is not repeatable, the value will just be 'A | B'. Note 1: As bug 10306 and its friends (19096) made the Default framework authoritative, we do no longer have the frameworkcode in this routine. Formally, we should check the corresponding framework. Note 2: Does this impact the reverse operation in TransformMarcToKoha? No, the check on repeatable subfields is done in the interface and not in TransformMarcToKoha. This routine simply translates two instances of the same subfield, say A and B, into the value 'A | B' for a kohafield. Not allowing two instances of a non-repeatable subfield is not in the scope of this report. Test plan: [1] Mark an item field as repeatable in the Default framework. Edit an item. Insert A|B in this field and another not-repeatable field. Save and reopen. Verify that the repeatable field is duplicated and the other one contains the pipe character in the text box. [2] Look for a repeatable subfield in MARC like e.g. 260$c. Go to the cataloguing editor and add A|B in this field. Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:38:28 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99311|0 |1 is obsolete| | --- Comment #21 from Ere Maijala --- Created attachment 99519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99519&action=edit Bug 21800: Check the correct framework for the repeatable tag This depends on the framework parameter. Which should be added back to the call in C4::Items. Test plan: [1] Mark in Default framework one subfield A repeatable and B not repeatable. Go to item editor. (Work on a biblio in Default framework.) Check saving and reopening these subfields with VAL1 | VAL2. Subfield A should be cloned, B should be glued as entered. [2] Mark in another Framework A not repeatable and B repeatable. Change framework for this biblio. Go to item editor again. Reopen item. Behavior subfields in reverse? Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:38:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:38:32 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99313|0 |1 is obsolete| | --- Comment #22 from Ere Maijala --- Created attachment 99520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99520&action=edit Bug 21800: Add tests for _check_split This new subroutine supports checking the repeatable tag from another framework. (It will be useful for the item editor.) Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:46:10 +0000 Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 --- Comment #23 from Marcel de Rooy --- (In reply to Ere Maijala from comment #18) > I failed to realize that the code checks for the pipe character first. So > the database call doesn't actually get executed that often. Sorry about the > confusion. Thanks for signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:46:59 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99315|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 99521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99521&action=edit Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:47:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:47:03 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99316|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 99522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99522&action=edit Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:47:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:47:06 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99317|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 99523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99523&action=edit Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:47:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:47:09 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 --- Comment #14 from Martin Renvoize --- Created attachment 99524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99524&action=edit Bug 24131: (follow-up) Another rebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:47:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:47:25 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:47:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:47:31 +0000 Subject: [Koha-bugs] [Bug 24306] Add debug option to koha-indexer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24306 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Why --debug and not --verbose? > Note that koha-elasticsearch has a verbose flag (and other script in > debian/scripts) > > You should also update debian/docs/koha-indexer.xml, and maybe tell that the > new flag is not for production use, bug debug purpose only (obvious if you > keep --debug, but worth a note if we go with --verbose). I think I went with debug because it is incredibly verbose. The script is hardcoded with verbose=1 in the options elsewhere, so you never really have a non-verbose option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:48:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:48:02 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99318|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 99525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99525&action=edit Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 14:49:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 13:49:34 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 --- Comment #3 from Martin Renvoize --- Test plan. Run updatedatabase (via either command line or staff client) and note that since the 19.12.00 update we now include timestamps in the output. QA note, I'm tempted to backdate this timestamp handling to prior versions on the release of 20.05 as part of this cycle release process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:08:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:08:55 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:08:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:08:58 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 --- Comment #1 from Marcel de Rooy --- Created attachment 99526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99526&action=edit Bug 24617: Add number to Descriptions in catalogue detail view Same change as in bug 24530 for OPAC. Only much easier. No trouble from Syndetics. Test plan: Add or remove a few notes from the MARC record (tag 500 etc). Verify the number is correct on the detail page. Signed-off-by: Marcel de Rooy Tested the else part for 'notes' with a [% SET notes = 'test' %] in tt file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:09:54 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Marcel de Rooy --- Moving to SO: trivial one liner. Katrin: Please have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:10:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:10:03 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:12:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:12:54 +0000 Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail (following 24530) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99526|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 99527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99527&action=edit Bug 24617: Add number to Descriptions in catalogue detail view Same change as in bug 24530 for OPAC. Only much easier. No trouble from Syndetics. Test plan: Add or remove a few notes from the MARC record (tag 500 etc). Verify the number is correct on the detail page. Signed-off-by: Marcel de Rooy Tested the else part for 'notes' with a [% SET notes = 'test' %] in tt file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:17:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:17:42 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:17:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:17:46 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92611|0 |1 is obsolete| | --- Comment #9 from Ere Maijala --- Created attachment 99528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99528&action=edit Bug 21958: Fix bibliographic record field comparison with authority This makes the comparison between bibliographic field and authority field more robust and per subfield. This makes the comparison not consider the same e.g. the following fields: $a Test User $a Test $b User The actual issue cannot be as easily reproduced with the patches for bug 21826 applied, but here's a test plan anyway: 1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*) 2. Make sure authority linking still works properly 3. Make sure authority and biblio frameworks allow subfield i 4. Make sure that even if you add subfield i to 700 in biblio, authority link is kept the same 5. Make sure that even if you add subfield i to the authority record, the authority link is kept the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:18:18 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 --- Comment #4 from Jonathan Druart --- Created attachment 99529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99529&action=edit Bug 24696: Use strftime Seems easier to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:23:34 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #15 from Jonathan Druart --- (In reply to Ere Maijala from comment #14) > Jonathan, unfortunately ModReserve wants them all, and I think that changing > it to make the call easier is far more risky. Indeed! However, should not we test for "exists" instead of "defined" (//)? As it, it will be impossible to set suspend_until to NULL, which I think is something we want to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:31:19 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #25 from Jonathan Druart --- Created attachment 99530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99530&action=edit Bug 24545: (follow-up) Fix license statements Oops, missing # here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:36:00 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:38:16 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |15967 --- Comment #3 from Jonathan Druart --- Nick, the test plan is considering SMS, but the code is for any MTT. What about the test plan from bug 15967? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 [Bug 15967] Print notices are not generated if the patron cannot be notified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:38:16 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 [Bug 23411] SMS messages should not fall back to 'email' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:50:28 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:50:31 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99481|0 |1 is obsolete| | --- Comment #16 from Ere Maijala --- Created attachment 99531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99531&action=edit Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided Before this fix the endpoint would accept the request but fail to actually update the hold if the request does not contain a priority parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:50:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:50:35 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99482|0 |1 is obsolete| | --- Comment #17 from Ere Maijala --- Created attachment 99532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99532&action=edit Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint Before this patch the response would return current date as the suspension end date for a hold that is suspended with no end date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:51:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:51:56 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #18 from Ere Maijala --- (In reply to Jonathan Druart from comment #15) > (In reply to Ere Maijala from comment #14) > > Jonathan, unfortunately ModReserve wants them all, and I think that changing > > it to make the call easier is far more risky. > > Indeed! > > However, should not we test for "exists" instead of "defined" (//)? > As it, it will be impossible to set suspend_until to NULL, which I think is > something we want to. Right, that was indeed broken (in a couple of ways). I don't think this applies to the other parameters, so I didn't change them. I also added a test to verify setting suspended_until to null. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 15:59:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 14:59:29 +0000 Subject: [Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680 --- Comment #19 from Jonathan Druart --- I think it also applies to priority as it can be null in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 16:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 15:01:12 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Nick, the test plan is considering SMS, but the code is for any MTT. The only time $effective_mtt and $mtt should be different are for email/sms - for email nothing will change, only SMS is affected. Future types could be affected by this code, however, I think it is the correct behaviour > > What about the test plan from bug 15967? This does not invalidate that - there we fellback to email if we were sending a print but didn't have a print notice. We continue to do that, but only change falling back to SMS when sending SMS via print if there is no print notice. The issue was that sometimes we would send an email notice via SMS if we didn't have an SMS notice defined - that causes problems and can generate multiple messages etc. If sending SMS and no SMS notice is defined, then we should not send. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 24 16:02:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Feb 2020 15:02:43 +0000 Subject: [Koha-bugs] [Bug 24717] New: Koha should set a referrer policy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24717 Bug ID: 24717 Summary: Koha should set a referrer policy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Koha should set a referrer policy [0] to restrict what is passed in the Referer header when external resources (e.g., cover images, added content of various stripes, electronic resources, external images and CSS, etc.) are embedded or navigated to. If a referrer policy is not set, the default policy of no-referrer-when-downgrade means that (say) the full referring URL, which can include record IDs and catalog search strings, will be sent to outside webservers providing external resources provided that loading the external resource doesn't mean downgrading from HTTPS to HTTP. Better values for the referrer policy include: * strict-origin-when-cross-origin * origin-when-cross-origin Values that might break current Koha functionality that inspects the Referer header include: * no-referrer * origin * strict-origin Values that might break legitimate inspection of the Referer header by services that perform referring URL "authentication" include: * no-referrer * same-origin A referrer policy can be set in various ways: - Using a Referrer-Policy HTTP header configured at the Apache or NGINX level - Using a meta tag: - Using a referrerpolicy attribute in , , ,