[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #69 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Notes & questions

1) We might want to modify the bug title a little - in addition to allow
changing the manager, this will also store the last person to change and date.
Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
2) lastmodificationdate and lastmodificationby are quite long. It might be
nicer to used something more readable like: last_modified_on and
last_modified_by. Not blocker for me, but putting the thought out there.
3) Is there a reason why we don't let the db update thelastmodificationdate?
4) Please check my follow-up

Blockers

1) When I change the manager, the lastmodification* are not updated.

2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for
the manager. I believe this should be handled separately. ( Bug 13014: Notify
budget owner on new suggestion - cronjob)

3)
+            if ( $notify ) {
+                my $patron = Koha::Patrons->find(
$suggestion_only->{managedby} );
+                my $email_address = $patron->notice_email_address;
+                if ($patron->notice_email_address) {
+                    my $budget = C4::Budgets::GetBudget(
$suggestion_only->{budgetid} );
$budget appears not to be used - possibly a copy&paste because of 2).

-- 
You are receiving this mail because:
You are watching all bug changes.