[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #7)
> I gave a try to this, wrote the test then try to fix it.
> 
> But my understanding of the code leads me to abandon. I do not understand
> why there are 3 calls to ReturnLostItem:
> 
> Koha/Account.pm:            C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account.pm:            C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account/Line.pm:                C4::Circulation::ReturnLostItem(
> $self->borrowernumber, $debit->itemnumber );
> 
> That seems wrong to me.
> 
> So I guess my test will not cover all the cases. Hope it could help as a
> start anyway.

Not sure I understand what you tried here Jonathan.. looking like you're simply
adding a second check to see if the item is still checked out before returning
it..

I think we need clarification on the requested behaviour before continuing
here.

-- 
You are receiving this mail because:
You are watching all bug changes.