[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 6 13:12:44 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry, does not apply, conflicts in 

C4/Items.pm
C4/OAI/Sets.pm
C4/Search.pm
admin/searchengine/elasticsearch/mappings.pl

also a few more cases.

C4/OAI/Sets.pm:        if(0 == grep /^$value$/, @subfield_values) {
C4/OAI/Sets.pm:        if(0 < grep /^$value$/, @subfield_values) {
misc/translator/translate:    if ( $cmd ne 'create' and $lang and not grep(
/^$lang$/, @{ $installer->{langs} } ) ) {
t/db_dependent/Acquisition.t:          unless grep ( /^$field$/, @$exp_fields
);
t/db_dependent/Budgets.t:        my $is_in_new_budgets = grep
/^$budget->{budget_id}$/, @new_budget_ids;
t/db_dependent/Budgets.t:        my $is_in_old_budgets = grep
/^$budget->{budget_id}$/, @old_budget_ids;
t/db_dependent/Serials.t:my @arrived_missing = map { my $status = $_->{status};
( grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? $_ : () } @serials;
t/db_dependent/Serials.t:my @others = map { my $status = $_->{status}; ( grep {
/^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? () : $_ } @serials;
t/db_dependent/Serials.t:@arrived_missing = map { my $status = $_->{status}; (
grep { /^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? $_ : () } @serials;
t/db_dependent/Serials.t:@others = map { my $status = $_->{status}; ( grep {
/^$status$/ } qw( 2 4 41 42 43 44 5 ) ) ? () : $_ } @serials;

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list