[Koha-bugs] [Bug 24602] New: The fallback value for onshelfholds should be 0

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602

            Bug ID: 24602
           Summary: The fallback value for onshelfholds should be 0
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The onshelfholds circulation rules values are more of an ENUM type (as opposed
to other rules with integers like max*qty). In the quantities cases, it makes
sense to have undef mean unlimited. In the enum type it is clearer to just set
a default value (0) as the code already expects (Note: undef and 0 both eval to
false so there's no behaviour problem, but warnings or we get forced to check
for defined when the rule is used. It seems trivial to just make the rule
fallback to a chosen default value)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.