[Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 11 13:43:09 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
It applies now, no (new) qa errors.

Just a question:
In C4/TAGS.pm you replace

  scalar grep {/^ $key $/x} @ok_fields

with

  scalar grep { $_ eq $key } @ok_fields

Is this correct?
The spaces in '/^ $key $/x' are in the matching string (by way of /x), then
perhaps

  scalar grep { $_ eq " $key " } @ok_fields

is preferable.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list