[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #301 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #300)
> (In reply to Jonathan Druart from comment #299)
> > A different failure from jenkins (D9 run 1139):
> > 
> > https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
> > 
> > 
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron can place hold if no circ_rules
> > where defined'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1095.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'OK'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron cannot place hold because pickup
> > location is not part of hold group'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1122.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron can place hold if
> > default_branch_circ_rules is set to "any" for library 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1142.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'OK'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for library 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1162.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1182.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'OK'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1202.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1222.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'OK'
> > koha_1       | 
> > koha_1       |     #   Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
> > koha_1       |     #   at t/db_dependent/Holds.t line 1242.
> > koha_1       |     #     Structures begin differing at:
> > koha_1       |     #          $got->{status} = 'libraryNotPickupLocation'
> > koha_1       |     #     $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1       |     # Looks like you failed 8 tests of 9.
> > koha_1       | 
> > koha_1       | #   Failed test 'CanItemBeReserved / pickup_not_in_hold_group'
> > koha_1       | #   at t/db_dependent/Holds.t line 1249.
> > koha_1       | # Looks like you failed 1 test of 61.
> > koha_1       | [15:06:03] t/db_dependent/Holds.t
> 
> Hi Jonathan,
> 
> I think I spotted this failure.. should I make a new bug to fix this tests?
> 
> The random failure on Item.t I'm at a loss. Supposedly I delete every
> circulation_rule, every item, every issue and every patron, but it seems not
> everything gets deleted.. or that's what I guess.
> 
> Do you have any tip of what could be wrong?

Never mind, I think I nailed it!.. I'll submit patches in following bug!

-- 
You are receiving this mail because:
You are watching all bug changes.