[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98884|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98917&action=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t

on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );

I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this

my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );

on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this

my $library1  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries' } );

but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this

my $library1  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3  = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );

To test:
1. do not apply this patch
2. in bash:
   for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.