[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

--- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #3)
> Comment on attachment 98884 [details] [review]
> Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
> 
> Review of attachment 98884 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/db_dependent/Koha/Item.t
> @@ +173,5 @@
> > +    my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
> > +    my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } );
> > +    my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } );
> > +    my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } );
> > +    my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } );
> 
> Do you really need to specify a branchcode here?

Ups, that slipped away.. I used it to verify which libraries where tested, and
when a library without one of those branchcodes appeared I realized that
somewhere they where created.

Thanks for the patch

-- 
You are receiving this mail because:
You are watching all bug changes.