[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) The database update will limit the number of suggestions for existing
installations:

+    $dbh->do( q{
+            INSERT IGNORE INTO systempreferences
(variable,value,explanation,type) VALUES
+                ('MaxTotalSuggestions','3','Number of total
suggestions','free'),
+                ('NumberOfSuggestionDays','30','days','free')
+            });

This is against the "rules" as we always aim for having no change of behaviour
on update. We should set them to empty (unlimited)

2) For the same reason I am wondering about the default settings in the YAML
file, I don't think they are needed.

3) This patch set misses the change to sysprefs.sql for setting up new
installations. While we could do the 3 and 30 there, I wonder if we should be a
little less restrictive there as well?

4) Please (re)add descriptions of the changes and test plans to the commit
messages. I've seen quite a lot of them showing here but not being part of the
attached files. Make sure you write them up in your git commit step, not when
using git bz attach, as the latter won't change the files.

-- 
You are receiving this mail because:
You are watching all bug changes.