[Koha-bugs] [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Feb 17 21:08:39 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98991|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 99129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99129&action=edit
Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled
If the showLastPatron syspref is disabled, we should not store the 3
cookies we use for this feature.
Test plan:
0/ Do not apply this patch
1/ Turn off showLastPatron
2/ Search for a patron, click on a result
3/ Open the cookie list of your browser
=> You see 3 cookies named lastborrowercard, lastborrowername,
lastborrowernumber
4/ Remove them
5/ Apply the patch
6/ Reload the patron detail page
=> The 3 cookies are not created
7/ Turn the pref on
8/ Reload the patron detail page
=> The 3 cookies are created
9/ Eat one of them.
QA note: it's a bit dirty, we should do that JS side, but
staff-global.js is too widely used to make the change easy. Any other
suggestions welcomed.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list