[Koha-bugs] [Bug 24677] wrong year picked in serials

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99147&action=edit
Bug 24677: (bug 24002 follow-up) Incorrect DATE value: '00-00-0000' in
C4/Serials.pm

Oops, wrong copy/paste here! The column order changes was not expected.

>From bug 24002:
  commit 3d3336ed6607d80b72502075ebf9567cf48e1709
  Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm

The changes from this patch are like:
-           
year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate))
as year,
+            year(IF(serial.publisheddate IS
NULL,serial.publisheddate,serial.planneddate)) as year,

This is stilly, if publisheddate is null we do not want to return it.

It comes from a wrong copy/paste from the other commits:
-                        ORDER BY
IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC";
+                        ORDER BY IF(publisheddate IS
NULL,planneddate,publisheddate) DESC";

="00-00-0000" vs <>"0000-00-00"

Test plan:
Eyeball the previous patches from bug 24002 and notice that the changes in the
commit listed previously are wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.