[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Kyle M Hall from comment #5)
> > (In reply to Jonathan Druart from comment #4)
> > > It seems that _FixAccountForLostAndFound is called from AddIssue and
> > > AddReturn. In our case none of them is called so I am pretty sure it will
> > > not fix the issue.
> > 
> > I see now, this code looks good from that perspective, though it would
> > definitely be preferable to add a new subroutine now, otherwise we have
> > duplicated code. It seems like a fairly trivial adjustment.
> 
> Do not you think we should remove the code from AddReturn (as it calls
> MarkIssueReturned)?

Yes, that makes sense. It's also worth noting that the code block is idempotent
so it's not going to hurt to run it multiple times. It should just be kept in
one place for code. maintenance purposes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.