[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 

starting with review and QA tools here:

1) Can you check if this is a real one or a false positive? 
 FAIL   Koha/ProblemReport.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666


2) Please fix filters:

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
   FAIL   filters
                missing_filter at line 3 (<title>[% IF ( LibraryNameTitle )
%][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Report
a Problem</title>)
                missing_filter at line 31 (                        <div
class="alert alert-info">Your problem report has been sent to the [% IF (
recipient == 'admin' ) %]Koha Administrator[% ELSE %][% recipient %][% END
%].</div>)
                missing_filter at line 56 (                                    
       <input type="hidden" name="place" id="place" value="[% probpage %]">)
                missing_filter at line 61 (                                    
       <input type="hidden" name="user" id="user" value="[% username %]"
class="span3">)
                missing_filter at line 65 (                                    
       <input type="text" name="subject" id="subject" value="[% subject %]"
class="span3">)


3) Database update

You got:
+    $dbh->do(q{ DROP TABLE IF EXISTS `problem_reports` });

I think this could be destructive in some cases. I think checking for existence
of the table is better:

20126     if ( !TableExists('return_claims') ) {


4) Capitalization

catalog › Report a Problem</title>
Koha Administrator

5)   print
$input->redirect("/cgi-bin/koha/opac-reportproblem?norecipients=1.pl");

Looks like a typo with the .pl at the end?

6) Translatatability

I these go in the email to the library/admin, but won't be translatable: 

+    $problemreport->{code} = 'PROBLEM_REPORT';
+    $problemreport->{content} .= "\nUsername: $username";
+    $problemreport->{content} .= "\nProblem page: $place";

Using a notice template would be the most elegant way to make those
translatable. I think with
https://bugs.koha-community.org/bugzilla3/showdependencytree.cgi?id=15395&hide_resolved=1
you can not yet add strings to .pl fils in a translatable way.


If I understand correctly the only way to access the reports for now would be a
report? It might be nice (new bug!) to have this on the dashoard and visible in
staff or even the patron account :)

-- 
You are receiving this mail because:
You are watching all bug changes.