[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 19 16:56:21 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi
             Status|Signed Off                  |Failed QA

--- Comment #113 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
I think it would have been beneficial to split this patch (as cait also
suggested in the bug report) since there seems to be at least two logical
changes. This would also increase the chances people have the time to sign-off
and QA the patches.

This is not a comprehensive review but I noticed this introduces new subroutine
GetRecordValue which is a) not used at all b) doesn't appear to be functional
since the DB table it uses doesn't exists. Also MARC::Field module is used
without importing it.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list