[Koha-bugs] [Bug 23727] Editing course reserve items is broken

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99272&action=edit
Bug 23727: Editing course reserve items is broken

Adding an item to course reserves and trying to edit any values in a second
step does not work. Values are not saved and the table shows all values as
"Unchanged".

This patch set adds two new sets of columns to the course_items table.

The first set determines if the specified column should be swapped or
not. The was previously 'implied' by the column being set to undef which
has been the root problem with that way of knowing if a column should
swap or not.

The second set of new columns are for storing the item field values
while the item is on course reserve. Previously, the column values
were swapped between the items table and the course_items table,
which leaves ambiguity as to what each value is. Now, the original
columns *always* store the value when the item is on course reserve,
and the new storage columns store the original item value while the
item is on reserve, and are NULL when an item is *not* on reserve.

Test Plan:
1) Apply this patch
2) Add and edit course items, not the new checkboxes for enabling fields
3) Everything should function as before

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.