[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #96 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 

can you please take a look at David'd comment#95?

I also got a lot of fails with the QA tools for missing filters :(

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
   FAIL   filters
                missing_filter at line 4 (        <li><a class="nav"
href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF
results_per_page %]&count=[% results_per_page %][% END %]"><i class="fa
fa-fw fa-angle-double-left"></i> First</a></li>)
                missing_filter at line 6 (        <li><a class="nav"
href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&offset=[% previous_page_offset | html %][% IF ( sort_by )
%]&sort_by=[% sort_by |url %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]"><i class="fa fa-fw
fa-angle-left"></i> Previous</a></li>)
                missing_filter at line 12 (            <li><a class="nav"
href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&offset=[% PAGE_NUMBER.offset | html %][% IF ( sort_by )
%]&sort_by=[% sort_by |url %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                missing_filter at line 16 (        <li><a class="nav"
href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&offset=[% next_page_offset | html %][% IF ( sort_by )
%]&sort_by=[% sort_by |url %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Next <i class="fa fa-fw
fa-angle-right"></i></a></li>)
                missing_filter at line 17 (        <li><a class="nav"
href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi |
$raw %]&offset=[% last_page_offset | html %][% IF ( sort_by )
%]&sort_by=[% sort_by |url %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Last <i class="fa fa-fw
fa-angle-double-right"></i></a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
   FAIL   filters
                missing_filter at line 274 (                                   
    Results per page: [% results_per_page %] <span class="caret"></span>)
                missing_filter at line 281 (                                   
            [% END %] Library default: [% Koha.Preference('numSearchResults')
%])
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
   FAIL   filters
                wrong_html_filter at line 6 (                <li
class="page-first"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][%
END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"><i
class="fa fa-fw fa-angle-double-left"></i>  First</a></li>)
                missing_filter at line 6 (                <li
class="page-first"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][%
END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"><i
class="fa fa-fw fa-angle-double-left"></i>  First</a></li>)
                wrong_html_filter at line 7 (                <li
class="page-prev"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% previous_page_offset | uri %][% IF (
sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]"> <i class="fa fa-fw
fa-angle-left"></i>  Previous</a></li>)
                missing_filter at line 7 (                <li
class="page-prev"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% previous_page_offset | uri %][% IF (
sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]"> <i class="fa fa-fw
fa-angle-left"></i>  Previous</a></li>)
                wrong_html_filter at line 13 (                    <li
class="page-num"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][%
limit_cgi | $raw %]&offset=[% PAGE_NUMBER.offset | uri %][% IF ( sort_by )
%]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                missing_filter at line 13 (                    <li
class="page-num"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][%
limit_cgi | $raw %]&offset=[% PAGE_NUMBER.offset | uri %][% IF ( sort_by )
%]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html
%]</a></li>)
                wrong_html_filter at line 17 (                <li
class="page-next"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% next_page_offset | uri %][% IF ( sort_by
) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Next <i class="fa fa-fw
fa-angle-double-right"></i></a></li>)
                missing_filter at line 17 (                <li
class="page-next"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% next_page_offset | uri %][% IF ( sort_by
) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Next <i class="fa fa-fw
fa-angle-double-right"></i></a></li>)
                wrong_html_filter at line 18 (                <li
class="page-last"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% last_page_offset | uri %][% IF ( sort_by
) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Last <i class="fa fa-fw
fa-angle-double-right"></i></a></li>)
                missing_filter at line 18 (                <li
class="page-last"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw
%][% limit_cgi | $raw %]&offset=[% last_page_offset | uri %][% IF ( sort_by
) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page
%]&count=[% results_per_page %][% END %]">Last <i class="fa fa-fw
fa-angle-double-right"></i></a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   FAIL   filters
                missing_filter at line 172 (                                   
                            <option value="[%
Koha.Preference('OPACnumSearchResults') %]" selected="selected">Library
default: [% Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 172 (                                   
                            <option value="[%
Koha.Preference('OPACnumSearchResults') %]" selected="selected">Library
default: [% Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 174 (                                   
                            <option value="[%
Koha.Preference('OPACnumSearchResults') %]">Library default: [%
Koha.Preference('OPACnumSearchResults') %]</option>)
                missing_filter at line 174 (                                   
                            <option value="[%
Koha.Preference('OPACnumSearchResults') %]">Library default: [%
Koha.Preference('OPACnumSearchResults') %]</option>)

-- 
You are receiving this mail because:
You are watching all bug changes.