[Koha-bugs] [Bug 24695] Improve SQL report validation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from paxed <pasi.kallinen at koha-suomi.fi> ---
Created attachment 99305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99305&action=edit
Bug 24695: Improve SQL report validation

The saved SQL report code validates the SQL in multiple places:
when saving, when updating, and when executing the query.
Move the validation code into Koha::Reports, and write tests for it.

Test plan:
1) Apply patch
2) Create a new valid SQL report, save it (success)
3) Create a new illegal SQL report, try to save (fails)
4) Update already saved SQL report by adding one of
   the forbidden words, eg. delete or drop (saving will fail)
5) Edit a save_sql in the database, changing it to eg.
   "drop borrowers", and try to execute it (fails)
6) Prove t/db_dependent/Koha/Reports.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.