[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Ere Maijala from comment #10)
> Why isn't the default framework also authoritative for repeatability? 

We only consider it authoritative for the Koha to MARC mapping. The interface
allows you to set repeatability per framework. Which is good. Since we changed
mappings, it does no longer look at the other frameworks. So this is the crux
of the change.

> If not, at least the framework information should be fetched e.g. with
> GetMarcSubfieldStructure so that it's cached to avoid a performance penalty,
> right?

I did experiment a bit with caching but didnt submit that portion. The existing
cached structures are based on entry by kohafield, not MARC tags. Makes it a
bit less handy. Performance penalty is a big word here. We use this for items.
The item editor needs 2 or 3 ms more to open one record (in my benchmarking).
Batch item modification depends on the number of items, but is a staff action,
probably not executed continuously. Rebuild zebra should not be a problem too.
Considering that, I feel that caching is no requirement here. And we can always
add it on its own report.

Back to NSO. Hoping for a SO ;)

-- 
You are receiving this mail because:
You are watching all bug changes.