[Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #3 from David Nind <david at davidnind.com> ---
I'm getting a fail on running the tests  - everything else seems okay:

root at bed39bee2cb5:koha(23763)$ prove -v t/Koha/SearchEngine/Search.t
t/Koha/SearchEngine/Search.t .. 
1..5
# Subtest: pagination_bar tests
    1..14
    ok 1 - We paginate all hits if less than max_result_window
    ok 2 - We have hits/hits_to_paginate pages
    ok 3 - We calculate current page by offset/results_per_page plus 1
    ok 4 - Previous page is current offset minus reults per page
    ok 5 - Next page is current offset plus reults per page
    ok 6 - Last page is pages minus 1 times reults per page
    ok 7 - If on first ten pages we only show 10 pages
    ok 8 - We paginate all hits if less than max_result_window
    ok 9 - We have hits/hits_to_paginate pages
    ok 10 - We calculate current page by offset/results_per_page plus 1
    ok 11 - Previous page is current offset minus reults per page
    ok 12 - Next page is current offset plus reults per page
    ok 13 - Last page is pages minus 1 times reults per page
    ok 14 - If past first ten pages we show 20 pages
ok 1 - pagination_bar tests
# Looks like you planned 5 tests but ran 1.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 4/5 subtests 

Test Summary Report
-------------------
t/Koha/SearchEngine/Search.t (Wstat: 65280 Tests: 1 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 5 tests but ran 1.
Files=1, Tests=1,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.86 cusr  0.07
csys =  0.95 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.