[Koha-bugs] [Bug 17499] Koha objects for messaging preferences

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I had a very quick look at the patch. About the tests I would like to see the
subroutines replaced with a call to $builder->build_object when it is the only
thing they actually do.

Example:

sub build_a_test_transport_type {
    my $mtt = $builder->build({
        source => 'MessageTransportType' });

    return Koha::Patron::Message::Transport::Types->find(
        $mtt->{message_transport_type}
    );
}

can be replaced with:

  $builder->build_object({ class => 'Koha::Patron::Message::Transport::Types'
});

-- 
You are receiving this mail because:
You are watching all bug changes.