[Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Some weirdness going on here. The error is a result of the "jsinclude" block
(which should not be there in 18.11, and which this bug removed) being parsed
by TT. jsinclude blocks should only be parsed if the "footerjs" flag is set
prior to the "jsinclude" block in the mark up. As far as I can see, the 18.11
version of this template has *never* included a footerjs flag, so I don't see
how the jsinclude block can ever have been parsed and the resulting error
displayed (scratches head).

So, you're right Bernardo, the error is not being displayed. However, the
jsinclude block should not be present in the template because it references
files that do not exist in 18.11. So we still need to get the patches in this
bug merged.

I think the only test plan I can offer in that case is:

- Do not apply the patch
- View koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
- TEST: Verify that it includes a "jsinclude" block near the bottom of the
template
- Apply the patch
- Re-open the template
- TEST: Verify that the "jsinclude" block is now gone

-- 
You are receiving this mail because:
You are watching all bug changes.