[Koha-bugs] [Bug 24693] GD is declared as an optional dependency but Koha dies without it

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Julian Maurice from comment #4)
> Maybe we should clarify what does *required* mean for us.
> 
> Personally I believe that every Perl module that we directly `use` or
> `require` without checking its presence should be flagged as required. Even
> if the require is behind a syspref check or something like that. Put more
> simply, if Koha dies because of a missing Perl module, that module is a
> required dependency.
> 
> Maybe later we can build something based on cpanfile's `feature`
> (https://metacpan.org/pod/distribution/Module-CPANfile/lib/cpanfile.
> pod#feature) to warn when an optional feature is enabled and the required
> modules for this feature are missing.

The whole 'feature' stuff from the cpanfile move came up earlier that I was
expecting.. but I suspected it would raise it's head at some point.

I'm really not sure what way to fall on this one.. I don't like that changing a
syspref can completely 'break', i.e lead to a die, koha.. but at the same time
if a set of functionality is optional, the dependencies it requires really
aught to be too.

-- 
You are receiving this mail because:
You are watching all bug changes.