[Koha-bugs] [Bug 24719] New: C4::Context::set_remote_address() prevents file upload for non-Plack Koha

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 25 03:16:20 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

            Bug ID: 24719
           Summary: C4::Context::set_remote_address() prevents file upload
                    for non-Plack Koha
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Unfortunately, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
appears to have broken file upload in non-Plack CGI Koha (I haven't checked
Plack enabled Koha).

If you have koha_trusted_proxies set, when you load C4::Auth, it'll create a
CGI object. 

It appears that creating this CGI object does some global work, which causes
CGI::init to malfunction, and as a result Koha::Uploader's CGI upload hook
never runs.

--

I was comparing two 19.11 instances. File upload worked on one but not the
other. The likely culprit looked like system preferences or koha-conf.xml and
thus code being invoked by C4::Context or C4::Auth. In the end it was C4::Auth
calling C4::Context->set_remote_address(). (Not a fun experience
troubleshooting this one by any means O_O.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list