[Koha-bugs] [Bug 24725] New: xgettext does not support (yet) ES template literals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725

            Bug ID: 24725
           Summary: xgettext does not support (yet) ES template literals
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 21156

>From Julian on bug 24661 comment 6:
"""
It looks like xgettext does not like ES6 template literals.

https://savannah.gnu.org/bugs/?50920

>From what I understand, support for template literals was added in gettext 0.20
(still not packaged in debian) but is still buggy in latest released version
0.20.1 and a fix is present in master.
"""

We should not use backticks ` in .js file, it breaks xgettext.

To replicate:
kohadev-koha at e1f3025cca60:/kohadevbox/koha/misc/translator$ perl translate
update es-ES
koha-tmpl/intranet-tmpl/prog/js/checkouts.js:569: warning: unterminated string
koha-tmpl/intranet-tmpl/prog/js/checkouts.js:858: warning: unterminated string
koha-tmpl/intranet-tmpl/prog/js/checkouts.js:904: warning: unterminated string
koha-tmpl/intranet-tmpl/prog/js/checkouts.js:911: warning: unterminated string
koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1095: warning: RegExp literal
terminated too early
/usr/bin/msgmerge: error while opening
"/kohadevbox/koha/misc/translator/po/es-ES-messages-js.po" for reading: No such
file or directory

(last error 'No such file or directory' is not related to this).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.