[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 25 17:39:51 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #5)
> Those tests are 90% a copy of the subtest "cancel_hold" from
> t/db_dependent/SIP/Transaction.t, that is actually testing drop_hold...

Yes, but cancel_hold calls drop_hold - and does other things. These tests test
that all the extra stuff happens - the other tests test that function
specifically.

We can move those tests here, but they cover two different modules - it seemed
reasonable to cover the functions indivudally in their own files

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list