[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some notes:

1. reportdate must be created_on, with a type "timestamp".

2. opac/opac-reportproblem.pl

112     my $from_address = $member->email || $member->emailpro ||
$member->B_email || $koha_admin;

We usually do not specify the from_address on enqueuing the notice, but when
sending it (from _send_message_by_email). That way a) the code is centralized
(as we must use $patron->notice_email_address) and b) the email used is the one
that is in the DB when the letter is effectively sent.
Here I guess you need to give it when the notice is enqueued as you want to
default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from" if not
really sent by the user.
We have the borrowernumber anyway to know who filled the form.

-- 
You are receiving this mail because:
You are watching all bug changes.