[Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Ere Maijala from comment #29)
> (In reply to Jonathan Druart from comment #28)
> > About suspend_until:
> > 
> > +    my $suspended_until   = exists $body->{suspended_until} ?
> > $body->{suspended_until} : $hold->suspend_until;
> > 
> > then
> > 
> > +        suspend_until => $suspended_until ?
> > output_pref(dt_from_string($suspended_until, 'rfc3339')) : '',
> > 
> > last '' must be undef I'd say.
> 
> No, ModReserve needs it to be defined, otherwise it won't clear out any old
> value. It is a peculiar little function indeed. The test block starting with
> comment "Reset suspended_until, everything else should remain" tests this.

Erk yes, indeed. That's pretty ugly!

-- 
You are receiving this mail because:
You are watching all bug changes.