[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #7)
> CGI->http code is
> 
> sub http {
>     my ($self,$parameter) = self_or_CGI(@_);
>     if ( defined($parameter) ) {
>         $parameter =~ tr/-a-z/_A-Z/;
>         if ( $parameter =~ /^HTTP(?:_|$)/ ) {
>             return $ENV{$parameter};
>         }
>         return $ENV{"HTTP_$parameter"};
>     }
>     return grep { /^HTTP(?:_|$)/ } keys %ENV;
> }
> 
> So that could should be safe.
> But, are we suppose to suppose non-plack? How slow that should be!

Until not so long ago Shibboleth did not work with Plack enabled - I am not
sure if there are other features that block use of Plack still... but there
might?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.