[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 27 01:20:35 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
Ok a few things:

1. I can confirm that CGI->http works with CGI. Thanks for the suggestion,
Jonathan! 

2. $cgi->http worked fine for Plack-enabled Koha presumably because
C4::Context->set_remote_address is just called by C4::Auth when it's loaded
into memory the first time. After that the Koha::Middleware::RealIP and other
Plack CGI emulation does all the heavy lifting I think.

So really C4::Context->set_remote_address is really only relevant for CGI in
the first place, so I guess it's worth fixing the bug, since that function just
exists for CGI anyway.

Will provide an alternate patch with CGI->http

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list