[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 28 00:23:02 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
My bad. I should have looked more closely at that. 

I suppose the IPv6 handling would be useful if the reverse proxy is trusted,
because then it doesn't pass that IP address on to the rest of Koha, but yeah
if the REMOTE_ADDR was an IPv6 address I'm not sure. Let's see...

Looks like REMOTE_ADDR gets directly requested by:
- C4/Context.pm
#Used by Koha::Middleware::RealIP, so no drama
- C4/InstallAuth.pm
#Actually this is commented out, so should be removed anyway
- C4/Auth.pm
#Used by SessionRestrictionByIP which is just string equality matching, so 
should be OK
#Saved/retrieved from session, so should be OK
- Koha/Middleware/RealIP.pm
#Parsed with Net::Netmask, so no drama
- opac/ilsdi.pl
#Currently string equality matching, so should be OK
#In the future with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537, hopefully will
use Net::Netmask too, so should be OK
- opac/opac-detail.pl
#Uses regex for OpacSuppressionByIPRange, which is essentially string matching,
so nothing should bust. 
- opac/opac-search.pl
#Uses regex for OpacSuppressionByIPRange, which is essentially string matching,
so nothing should bust. 
- opac/opac-restrictedpage.pl
#Uses regex for RestrictedPageLocalIPs, which is essentially string matching,
so nothing should bust

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list