[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koh::Item method

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
This uncovered some issues, previously if you chose 'NULL' in the system
preferences for OpacRenewalBranch it saved as "" - and the test for null looked
for the string 'NULL' - so setting it to null was like setting it to
'opacrenew', having it undef was the same. Only having it set to the string
value 'NULL' gave you a blank string in statistics (which, I must point out, is
not the same a NULL)

The second patch here makes the NULL option 'none' and cleans up old pref
values - it shouldn't change behaviour, but may change pref value

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.