[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 28 17:50:33 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 99786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99786&action=edit
Bug 23753: Add missing humanMsg library to pages using background job
JavaScript

The JavaScript used to process background uploads calls the humanMsg
library under some circumstances. There are several templates which use
background-job-progressbar.js which don't include the humanMsg assets.
This patch corrects those templates.

Note: upload-images.tt has been modified to remove the inclusion of
background-job-progressbar.js because it was unused.

To test, apply the patch and test the following processes which include
background job processing:

 - Batch item modification -- the background job is triggered when you
   submit your changes
 - Batch record modification -- the background job is triggered when you
   submit your changes
 - Stage MARC for import -- the background job is triggered when you
   click the "Sage for import" button after uploading a file
 - Staged MARC management -- the background job is triggered when you
   click "Import this batch into the catalog"

In each case the process should complete correctly. If you would like to
test the error message handling provided by the humanMsg library you can
deliberately introduce an error into the JavaScript. After applying the
patch you can modify js/background-job-progressbar.js to alter line 63
from:

   url: f.action,

...to:

   url: f.action + "foo",

Perform the same tests and confirm that you see an error message. Don't
forget to undo your changes to background-job-progressbar.js before
signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list