[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lucas,

sorry, but after looking into this more deeply, I saw that I was mistaken to
ask for a span around title - we already got one! 

I am sorry for not noticing these things earlier:

1) Remove the title span again, because:

[%- IF data.title %]
    [%- IF no_html %]
        [%- span_start = '' %]
        [%- span_end   = '' %]
    [%- ELSE %]
        [%- span_start = '<span class="patron-title">' %]
        [%- span_end   = '</span>' %]
    [%- END %]
    [% data.title = data.title | html %]
    [%- SET data.title = span_start _ data.title _ span_end _ ' ' -%]

This code already adds a class patron-title. See the no_html flag?

2) Change the other spans to be added the same way, to honor the no_html flag.

I think the no_html is needed because there are some tags that don't allow the
use of spans inside. Especially the title tag. Example:

koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt:<title>Koha
› Patrons › Purchase suggestions for [% INCLUDE
'patron-title.inc' no_html = 1 %]</title>

3) There is a corresponding file for the OPAC we should change - prefrrably on
this bug, but we could also do a separate one:

koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc

-- 
You are receiving this mail because:
You are watching all bug changes.